Wednesday, 2019-03-06

*** Sravan has joined #openstack-glance00:12
*** hoonetorg has quit IRC00:24
*** hoonetorg has joined #openstack-glance00:26
*** Sravan has quit IRC00:30
*** brinzhang has joined #openstack-glance00:31
*** markvoelker has joined #openstack-glance00:49
*** itlinux has joined #openstack-glance00:58
*** gyee has quit IRC01:21
*** markvoelker has quit IRC01:22
*** itlinux_ has joined #openstack-glance01:39
*** itlinux_ has quit IRC01:40
*** itlinux has quit IRC01:41
*** markvoelker has joined #openstack-glance02:19
*** markvoelker has quit IRC02:52
*** _alastor_ has quit IRC03:39
*** markvoelker has joined #openstack-glance03:49
*** Sravan has joined #openstack-glance04:17
*** markvoelker has quit IRC04:22
*** ratailor has joined #openstack-glance04:27
*** Sravan has quit IRC04:53
*** Sravan has joined #openstack-glance04:59
*** Sravan has quit IRC05:02
*** Sravan has joined #openstack-glance05:03
*** Sravan has quit IRC05:04
*** abhishekk has joined #openstack-glance05:06
*** Sravan has joined #openstack-glance05:07
*** Sravan has quit IRC05:10
*** bhagyashris_ has joined #openstack-glance05:11
*** Sravan has joined #openstack-glance05:12
*** Sravan has quit IRC05:18
*** Sravan has joined #openstack-glance05:19
*** hoonetorg has quit IRC05:33
*** nehaalhat has joined #openstack-glance05:40
*** bhagyashris_ has quit IRC05:43
*** Sravan has quit IRC05:46
*** Sravan has joined #openstack-glance05:47
*** Sravan has quit IRC05:50
*** hoonetorg has joined #openstack-glance05:50
*** Sravan has joined #openstack-glance05:52
*** udesale has joined #openstack-glance06:07
*** nehaalhat has quit IRC06:13
openstackgerritMerged openstack/glance master: Document fileystem drv chunk size option  https://review.openstack.org/63205406:23
*** Sravan has quit IRC06:33
*** markvoelker has joined #openstack-glance06:49
*** Luzi has joined #openstack-glance06:53
*** Sravan has joined #openstack-glance06:54
*** Sravan has quit IRC06:58
*** mosulica has joined #openstack-glance07:00
*** cfriesen has quit IRC07:14
*** markvoelker has quit IRC07:21
*** bhagyashris has joined #openstack-glance07:27
openstackgerritBhagyashri Shewale proposed openstack/python-glanceclient master: Remove redundant information from error message  https://review.openstack.org/47535107:34
*** tkajinam has quit IRC08:09
*** awalende has joined #openstack-glance08:15
*** markvoelker has joined #openstack-glance08:19
*** mosulica has quit IRC08:29
*** pcaruana has joined #openstack-glance08:29
*** mosulica has joined #openstack-glance08:31
*** Sravan has joined #openstack-glance08:32
*** Sravan has quit IRC08:36
*** markvoelker has quit IRC08:52
*** mosulica has quit IRC08:54
*** mosulica has joined #openstack-glance08:59
*** mosulica has quit IRC09:34
*** mosulica has joined #openstack-glance09:43
*** markvoelker has joined #openstack-glance09:49
*** bhagyashris has quit IRC09:54
*** mosulica has quit IRC09:58
*** abhishekk has quit IRC10:19
*** markvoelker has quit IRC10:22
*** mosulica has joined #openstack-glance10:30
openstackgerritMerged openstack/python-glanceclient master: add python 3.7 unit test job  https://review.openstack.org/63725210:37
*** udesale has quit IRC10:57
*** FlorianFa has quit IRC11:01
*** FlorianFa has joined #openstack-glance11:02
*** pcaruana has quit IRC11:04
*** markvoelker has joined #openstack-glance11:19
openstackgerritMerged openstack/python-glanceclient master: Remove redundant information from error message  https://review.openstack.org/47535111:28
*** pcaruana has joined #openstack-glance11:32
*** markvoelker has quit IRC11:52
*** ratailor has quit IRC11:54
*** mvkr has joined #openstack-glance12:13
*** brinzhang has quit IRC12:31
*** udesale has joined #openstack-glance12:38
*** markvoelker has joined #openstack-glance12:49
*** markvoelker has quit IRC13:22
*** pcaruana has quit IRC13:51
*** pcaruana has joined #openstack-glance14:01
*** FlorianFa has quit IRC14:09
*** jaypipes has quit IRC14:14
*** markvoelker has joined #openstack-glance14:19
openstackgerritjacky06 proposed openstack/python-glanceclient master: Update hacking version  https://review.openstack.org/64140014:42
*** markvoelker has quit IRC14:52
*** cfriesen has joined #openstack-glance15:07
*** Luzi has quit IRC15:09
*** awalende has quit IRC15:15
*** awalende has joined #openstack-glance15:16
*** awalende has quit IRC15:20
rosmaitajokke_: around?15:32
rosmaitajokke_: i will be afk for a bit, but when you have a chance, take a look at the bottom of https://etherpad.openstack.org/p/glance_store-py3-swift-driver-problem and see if you can make any sense out of it15:33
*** udesale has quit IRC15:37
jokke_yeah15:45
jokke_ok thanls15:45
*** lpetrut has joined #openstack-glance15:50
*** markvoelker has joined #openstack-glance15:50
*** pcaruana has quit IRC15:53
*** mosulica has quit IRC15:58
*** pcaruana has joined #openstack-glance16:06
*** _alastor_ has joined #openstack-glance16:17
*** markvoelker has quit IRC16:22
*** imacdonn has quit IRC16:36
*** imacdonn has joined #openstack-glance16:36
*** pcaruana has quit IRC16:55
*** gyee has joined #openstack-glance17:06
*** lpetrut has quit IRC17:14
*** awalende has joined #openstack-glance17:17
*** lpetrut has joined #openstack-glance17:17
*** markvoelker has joined #openstack-glance17:19
*** awalende has quit IRC17:22
jokke_rosmaita: when you're back, have a look of my comment at the end of that etherpad if it makes sense. Thanks for digging into this17:25
*** lpetrut has quit IRC17:32
*** markvoelker has quit IRC17:52
rosmaitajokke_: looking18:00
*** Sravan has joined #openstack-glance18:08
*** Sravan has quit IRC18:47
*** Sravan has joined #openstack-glance18:49
*** markvoelker has joined #openstack-glance18:50
*** Sravan has quit IRC18:56
*** Sravan has joined #openstack-glance18:58
*** Sravan has quit IRC19:17
*** Sravan has joined #openstack-glance19:19
*** markvoelker has quit IRC19:22
*** Sravan has quit IRC19:56
*** Sravan has joined #openstack-glance19:58
*** Sravan has quit IRC20:01
*** Sravan has joined #openstack-glance20:13
*** markvoelker has joined #openstack-glance20:19
openstackgerritBrian Rosmaita proposed openstack/glance_store master: Prevent unicode object error from zero-byte read  https://review.openstack.org/62023420:40
openstackgerritBrian Rosmaita proposed openstack/glance_store master: Prevent unicode object error from zero-byte read  https://review.openstack.org/62023420:43
jokke_rosmaita: nice one, I was just going to flag it :D20:45
rosmaita:D20:45
jokke_If that solves the issue, I'm super happy20:45
jokke_thanks for the efforts digging into this. It was bitch to debug20:46
rosmaitayeah, thanks to bandini for the environment to work in20:46
rosmaitayou spotted the problem right away20:46
*** markvoelker has quit IRC20:53
jokke_I quess too many times being bit by how python handles those ... would be lovely to understand what happens on those 0 length I/O requests20:58
*** Sravan has quit IRC21:04
openstackgerritSean McGinnis proposed openstack/glance master: Switch to using stestr  https://review.openstack.org/57852921:05
smcginnisjokke_, rosmaita: That's needed to address an stestr requirements upgrade issue. ^^21:05
rosmaitasmcginnis: wow, that's a blast from the past21:07
smcginnisRight?21:07
*** irclogbot_1 has joined #openstack-glance21:07
smcginnisAlmost made it a year.21:07
*** Sravan has joined #openstack-glance21:09
*** timburke has joined #openstack-glance21:11
*** Sravan has quit IRC21:14
rosmaitajokke_: sean's change ^^ looks OK to me, you may want to take a look while zuul is doing its thing21:19
rosmaitajokke_: looks like the swift BufferedReader doesn't hit that problem21:22
rosmaita(at least at first glance, i need to look in the logs and make sure the buffered reader is actually being used)21:22
*** irclogbot_1 has quit IRC21:28
jokke_rosmaita: I think what happened there is that while swift is not py3 yet, the zero size read was transcoded to empty string with encoding to get it over the http and that flipped the hashing algorithm on py3 that expected string being encoded differently. As long as it was actual bytes everyone played nicely21:29
jokke_And the buffered reader would avoid that problem by rotating it via the buffer at which point the data is again uniform and everything behaves21:30
rosmaitai am not sure, i think the read is happening before the PUT to swift.  in any case, i think i messed up the configuration, log message from debugging the ChunkReader is showing up in the log21:31
timburkei wonder if the trouble might be https://github.com/openstack/glance_store/blob/0.28.0/glance_store/common/utils.py#L138 ...21:36
rosmaitatimburke: that definitely looks bad21:38
rosmaitai don't think it's what we're hitting in swift, the ChunkReader inherits from object, but that line definitely looks like an accident waiting to happen21:39
*** markvoelker has joined #openstack-glance21:50
jokke_timburke: uuh that was nice find, thank you!21:54
timburkefwiw, there's something similar at https://github.com/openstack/glance/blob/17.0.0/glance/common/utils.py#L23122:04
rosmaitatimburke: ty, that looks ugly as well22:06
*** MattMan_1 has quit IRC22:11
*** MattMan_1 has joined #openstack-glance22:11
*** Sravan has joined #openstack-glance22:12
*** Sravan has quit IRC22:16
rosmaitatimburke: https://bugs.launchpad.net/glance/+bug/1818919 and https://bugs.launchpad.net/glance-store/+bug/1818915 if you have time to put up some patches22:17
openstackLaunchpad bug 1818919 in Glance "CooperativeReader not py3-ready" [High,Triaged]22:17
openstackLaunchpad bug 1818915 in glance_store "CooperativeReader not py3-ready" [High,Triaged]22:17
jokke_Let me know if you don't want to patch them and I will22:17
*** markvoelker has quit IRC22:22
openstackgerritTim Burke proposed openstack/glance master: py3: Fix return type on CooperativeReader.read  https://review.openstack.org/64150922:46
*** rcernin has joined #openstack-glance22:52
*** tkajinam has joined #openstack-glance23:01
*** Sravan has joined #openstack-glance23:04
openstackgerritTim Burke proposed openstack/glance master: py3: Fix return type on CooperativeReader.read  https://review.openstack.org/64150923:07
*** markvoelker has joined #openstack-glance23:19
*** Sravan has quit IRC23:24
*** Sravan has joined #openstack-glance23:25
*** Sravan has quit IRC23:28
*** Sravan has joined #openstack-glance23:32
timburkehm.... https://github.com/openstack/glance_store/blob/0.28.0/glance_store/_drivers/swift/store.py#L86423:35
*** Sravan has quit IRC23:40
*** Sravan has joined #openstack-glance23:42
*** Sravan has quit IRC23:52
*** Sravan has joined #openstack-glance23:52
*** markvoelker has quit IRC23:53
*** Sravan has quit IRC23:56
*** Sravan has joined #openstack-glance23:59

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!