*** Sravan has joined #openstack-glance | 00:12 | |
*** hoonetorg has quit IRC | 00:24 | |
*** hoonetorg has joined #openstack-glance | 00:26 | |
*** Sravan has quit IRC | 00:30 | |
*** brinzhang has joined #openstack-glance | 00:31 | |
*** markvoelker has joined #openstack-glance | 00:49 | |
*** itlinux has joined #openstack-glance | 00:58 | |
*** gyee has quit IRC | 01:21 | |
*** markvoelker has quit IRC | 01:22 | |
*** itlinux_ has joined #openstack-glance | 01:39 | |
*** itlinux_ has quit IRC | 01:40 | |
*** itlinux has quit IRC | 01:41 | |
*** markvoelker has joined #openstack-glance | 02:19 | |
*** markvoelker has quit IRC | 02:52 | |
*** _alastor_ has quit IRC | 03:39 | |
*** markvoelker has joined #openstack-glance | 03:49 | |
*** Sravan has joined #openstack-glance | 04:17 | |
*** markvoelker has quit IRC | 04:22 | |
*** ratailor has joined #openstack-glance | 04:27 | |
*** Sravan has quit IRC | 04:53 | |
*** Sravan has joined #openstack-glance | 04:59 | |
*** Sravan has quit IRC | 05:02 | |
*** Sravan has joined #openstack-glance | 05:03 | |
*** Sravan has quit IRC | 05:04 | |
*** abhishekk has joined #openstack-glance | 05:06 | |
*** Sravan has joined #openstack-glance | 05:07 | |
*** Sravan has quit IRC | 05:10 | |
*** bhagyashris_ has joined #openstack-glance | 05:11 | |
*** Sravan has joined #openstack-glance | 05:12 | |
*** Sravan has quit IRC | 05:18 | |
*** Sravan has joined #openstack-glance | 05:19 | |
*** hoonetorg has quit IRC | 05:33 | |
*** nehaalhat has joined #openstack-glance | 05:40 | |
*** bhagyashris_ has quit IRC | 05:43 | |
*** Sravan has quit IRC | 05:46 | |
*** Sravan has joined #openstack-glance | 05:47 | |
*** Sravan has quit IRC | 05:50 | |
*** hoonetorg has joined #openstack-glance | 05:50 | |
*** Sravan has joined #openstack-glance | 05:52 | |
*** udesale has joined #openstack-glance | 06:07 | |
*** nehaalhat has quit IRC | 06:13 | |
openstackgerrit | Merged openstack/glance master: Document fileystem drv chunk size option https://review.openstack.org/632054 | 06:23 |
---|---|---|
*** Sravan has quit IRC | 06:33 | |
*** markvoelker has joined #openstack-glance | 06:49 | |
*** Luzi has joined #openstack-glance | 06:53 | |
*** Sravan has joined #openstack-glance | 06:54 | |
*** Sravan has quit IRC | 06:58 | |
*** mosulica has joined #openstack-glance | 07:00 | |
*** cfriesen has quit IRC | 07:14 | |
*** markvoelker has quit IRC | 07:21 | |
*** bhagyashris has joined #openstack-glance | 07:27 | |
openstackgerrit | Bhagyashri Shewale proposed openstack/python-glanceclient master: Remove redundant information from error message https://review.openstack.org/475351 | 07:34 |
*** tkajinam has quit IRC | 08:09 | |
*** awalende has joined #openstack-glance | 08:15 | |
*** markvoelker has joined #openstack-glance | 08:19 | |
*** mosulica has quit IRC | 08:29 | |
*** pcaruana has joined #openstack-glance | 08:29 | |
*** mosulica has joined #openstack-glance | 08:31 | |
*** Sravan has joined #openstack-glance | 08:32 | |
*** Sravan has quit IRC | 08:36 | |
*** markvoelker has quit IRC | 08:52 | |
*** mosulica has quit IRC | 08:54 | |
*** mosulica has joined #openstack-glance | 08:59 | |
*** mosulica has quit IRC | 09:34 | |
*** mosulica has joined #openstack-glance | 09:43 | |
*** markvoelker has joined #openstack-glance | 09:49 | |
*** bhagyashris has quit IRC | 09:54 | |
*** mosulica has quit IRC | 09:58 | |
*** abhishekk has quit IRC | 10:19 | |
*** markvoelker has quit IRC | 10:22 | |
*** mosulica has joined #openstack-glance | 10:30 | |
openstackgerrit | Merged openstack/python-glanceclient master: add python 3.7 unit test job https://review.openstack.org/637252 | 10:37 |
*** udesale has quit IRC | 10:57 | |
*** FlorianFa has quit IRC | 11:01 | |
*** FlorianFa has joined #openstack-glance | 11:02 | |
*** pcaruana has quit IRC | 11:04 | |
*** markvoelker has joined #openstack-glance | 11:19 | |
openstackgerrit | Merged openstack/python-glanceclient master: Remove redundant information from error message https://review.openstack.org/475351 | 11:28 |
*** pcaruana has joined #openstack-glance | 11:32 | |
*** markvoelker has quit IRC | 11:52 | |
*** ratailor has quit IRC | 11:54 | |
*** mvkr has joined #openstack-glance | 12:13 | |
*** brinzhang has quit IRC | 12:31 | |
*** udesale has joined #openstack-glance | 12:38 | |
*** markvoelker has joined #openstack-glance | 12:49 | |
*** markvoelker has quit IRC | 13:22 | |
*** pcaruana has quit IRC | 13:51 | |
*** pcaruana has joined #openstack-glance | 14:01 | |
*** FlorianFa has quit IRC | 14:09 | |
*** jaypipes has quit IRC | 14:14 | |
*** markvoelker has joined #openstack-glance | 14:19 | |
openstackgerrit | jacky06 proposed openstack/python-glanceclient master: Update hacking version https://review.openstack.org/641400 | 14:42 |
*** markvoelker has quit IRC | 14:52 | |
*** cfriesen has joined #openstack-glance | 15:07 | |
*** Luzi has quit IRC | 15:09 | |
*** awalende has quit IRC | 15:15 | |
*** awalende has joined #openstack-glance | 15:16 | |
*** awalende has quit IRC | 15:20 | |
rosmaita | jokke_: around? | 15:32 |
rosmaita | jokke_: i will be afk for a bit, but when you have a chance, take a look at the bottom of https://etherpad.openstack.org/p/glance_store-py3-swift-driver-problem and see if you can make any sense out of it | 15:33 |
*** udesale has quit IRC | 15:37 | |
jokke_ | yeah | 15:45 |
jokke_ | ok thanls | 15:45 |
*** lpetrut has joined #openstack-glance | 15:50 | |
*** markvoelker has joined #openstack-glance | 15:50 | |
*** pcaruana has quit IRC | 15:53 | |
*** mosulica has quit IRC | 15:58 | |
*** pcaruana has joined #openstack-glance | 16:06 | |
*** _alastor_ has joined #openstack-glance | 16:17 | |
*** markvoelker has quit IRC | 16:22 | |
*** imacdonn has quit IRC | 16:36 | |
*** imacdonn has joined #openstack-glance | 16:36 | |
*** pcaruana has quit IRC | 16:55 | |
*** gyee has joined #openstack-glance | 17:06 | |
*** lpetrut has quit IRC | 17:14 | |
*** awalende has joined #openstack-glance | 17:17 | |
*** lpetrut has joined #openstack-glance | 17:17 | |
*** markvoelker has joined #openstack-glance | 17:19 | |
*** awalende has quit IRC | 17:22 | |
jokke_ | rosmaita: when you're back, have a look of my comment at the end of that etherpad if it makes sense. Thanks for digging into this | 17:25 |
*** lpetrut has quit IRC | 17:32 | |
*** markvoelker has quit IRC | 17:52 | |
rosmaita | jokke_: looking | 18:00 |
*** Sravan has joined #openstack-glance | 18:08 | |
*** Sravan has quit IRC | 18:47 | |
*** Sravan has joined #openstack-glance | 18:49 | |
*** markvoelker has joined #openstack-glance | 18:50 | |
*** Sravan has quit IRC | 18:56 | |
*** Sravan has joined #openstack-glance | 18:58 | |
*** Sravan has quit IRC | 19:17 | |
*** Sravan has joined #openstack-glance | 19:19 | |
*** markvoelker has quit IRC | 19:22 | |
*** Sravan has quit IRC | 19:56 | |
*** Sravan has joined #openstack-glance | 19:58 | |
*** Sravan has quit IRC | 20:01 | |
*** Sravan has joined #openstack-glance | 20:13 | |
*** markvoelker has joined #openstack-glance | 20:19 | |
openstackgerrit | Brian Rosmaita proposed openstack/glance_store master: Prevent unicode object error from zero-byte read https://review.openstack.org/620234 | 20:40 |
openstackgerrit | Brian Rosmaita proposed openstack/glance_store master: Prevent unicode object error from zero-byte read https://review.openstack.org/620234 | 20:43 |
jokke_ | rosmaita: nice one, I was just going to flag it :D | 20:45 |
rosmaita | :D | 20:45 |
jokke_ | If that solves the issue, I'm super happy | 20:45 |
jokke_ | thanks for the efforts digging into this. It was bitch to debug | 20:46 |
rosmaita | yeah, thanks to bandini for the environment to work in | 20:46 |
rosmaita | you spotted the problem right away | 20:46 |
*** markvoelker has quit IRC | 20:53 | |
jokke_ | I quess too many times being bit by how python handles those ... would be lovely to understand what happens on those 0 length I/O requests | 20:58 |
*** Sravan has quit IRC | 21:04 | |
openstackgerrit | Sean McGinnis proposed openstack/glance master: Switch to using stestr https://review.openstack.org/578529 | 21:05 |
smcginnis | jokke_, rosmaita: That's needed to address an stestr requirements upgrade issue. ^^ | 21:05 |
rosmaita | smcginnis: wow, that's a blast from the past | 21:07 |
smcginnis | Right? | 21:07 |
*** irclogbot_1 has joined #openstack-glance | 21:07 | |
smcginnis | Almost made it a year. | 21:07 |
*** Sravan has joined #openstack-glance | 21:09 | |
*** timburke has joined #openstack-glance | 21:11 | |
*** Sravan has quit IRC | 21:14 | |
rosmaita | jokke_: sean's change ^^ looks OK to me, you may want to take a look while zuul is doing its thing | 21:19 |
rosmaita | jokke_: looks like the swift BufferedReader doesn't hit that problem | 21:22 |
rosmaita | (at least at first glance, i need to look in the logs and make sure the buffered reader is actually being used) | 21:22 |
*** irclogbot_1 has quit IRC | 21:28 | |
jokke_ | rosmaita: I think what happened there is that while swift is not py3 yet, the zero size read was transcoded to empty string with encoding to get it over the http and that flipped the hashing algorithm on py3 that expected string being encoded differently. As long as it was actual bytes everyone played nicely | 21:29 |
jokke_ | And the buffered reader would avoid that problem by rotating it via the buffer at which point the data is again uniform and everything behaves | 21:30 |
rosmaita | i am not sure, i think the read is happening before the PUT to swift. in any case, i think i messed up the configuration, log message from debugging the ChunkReader is showing up in the log | 21:31 |
timburke | i wonder if the trouble might be https://github.com/openstack/glance_store/blob/0.28.0/glance_store/common/utils.py#L138 ... | 21:36 |
rosmaita | timburke: that definitely looks bad | 21:38 |
rosmaita | i don't think it's what we're hitting in swift, the ChunkReader inherits from object, but that line definitely looks like an accident waiting to happen | 21:39 |
*** markvoelker has joined #openstack-glance | 21:50 | |
jokke_ | timburke: uuh that was nice find, thank you! | 21:54 |
timburke | fwiw, there's something similar at https://github.com/openstack/glance/blob/17.0.0/glance/common/utils.py#L231 | 22:04 |
rosmaita | timburke: ty, that looks ugly as well | 22:06 |
*** MattMan_1 has quit IRC | 22:11 | |
*** MattMan_1 has joined #openstack-glance | 22:11 | |
*** Sravan has joined #openstack-glance | 22:12 | |
*** Sravan has quit IRC | 22:16 | |
rosmaita | timburke: https://bugs.launchpad.net/glance/+bug/1818919 and https://bugs.launchpad.net/glance-store/+bug/1818915 if you have time to put up some patches | 22:17 |
openstack | Launchpad bug 1818919 in Glance "CooperativeReader not py3-ready" [High,Triaged] | 22:17 |
openstack | Launchpad bug 1818915 in glance_store "CooperativeReader not py3-ready" [High,Triaged] | 22:17 |
jokke_ | Let me know if you don't want to patch them and I will | 22:17 |
*** markvoelker has quit IRC | 22:22 | |
openstackgerrit | Tim Burke proposed openstack/glance master: py3: Fix return type on CooperativeReader.read https://review.openstack.org/641509 | 22:46 |
*** rcernin has joined #openstack-glance | 22:52 | |
*** tkajinam has joined #openstack-glance | 23:01 | |
*** Sravan has joined #openstack-glance | 23:04 | |
openstackgerrit | Tim Burke proposed openstack/glance master: py3: Fix return type on CooperativeReader.read https://review.openstack.org/641509 | 23:07 |
*** markvoelker has joined #openstack-glance | 23:19 | |
*** Sravan has quit IRC | 23:24 | |
*** Sravan has joined #openstack-glance | 23:25 | |
*** Sravan has quit IRC | 23:28 | |
*** Sravan has joined #openstack-glance | 23:32 | |
timburke | hm.... https://github.com/openstack/glance_store/blob/0.28.0/glance_store/_drivers/swift/store.py#L864 | 23:35 |
*** Sravan has quit IRC | 23:40 | |
*** Sravan has joined #openstack-glance | 23:42 | |
*** Sravan has quit IRC | 23:52 | |
*** Sravan has joined #openstack-glance | 23:52 | |
*** markvoelker has quit IRC | 23:53 | |
*** Sravan has quit IRC | 23:56 | |
*** Sravan has joined #openstack-glance | 23:59 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!