| *** zhanglong has joined #openstack-glance | 01:06 | |
| *** bhagyashris_ has joined #openstack-glance | 01:25 | |
| *** brinzhang has joined #openstack-glance | 03:16 | |
| brinzhang | jokke_: Could you please review this patch "Spec Lite: Add description field to image", https://review.openstack.org/#/c/623405/ | 03:33 |
|---|---|---|
| *** abhishekk has joined #openstack-glance | 04:31 | |
| *** udesale has joined #openstack-glance | 04:33 | |
| *** ratailor has joined #openstack-glance | 06:08 | |
| *** zhanglong has quit IRC | 06:09 | |
| *** zhanglong has joined #openstack-glance | 06:11 | |
| *** brinzhang has quit IRC | 06:27 | |
| *** brinzhang has joined #openstack-glance | 06:27 | |
| *** baojg has joined #openstack-glance | 06:48 | |
| *** rcernin has quit IRC | 06:56 | |
| *** Luzi has joined #openstack-glance | 06:57 | |
| *** dpawlik has joined #openstack-glance | 07:29 | |
| *** Liang__ has joined #openstack-glance | 08:10 | |
| *** pcaruana has joined #openstack-glance | 08:14 | |
| *** pcaruana has quit IRC | 08:24 | |
| *** ratailor has quit IRC | 08:41 | |
| *** ratailor has joined #openstack-glance | 08:44 | |
| *** pcaruana has joined #openstack-glance | 08:46 | |
| *** baojg has quit IRC | 08:54 | |
| *** Liang__ has quit IRC | 09:33 | |
| *** Liang__ has joined #openstack-glance | 09:43 | |
| *** bhagyashris_ has quit IRC | 09:45 | |
| *** belmoreira has joined #openstack-glance | 09:50 | |
| jokke_ | abhishekk: around? | 09:54 |
| abhishekk | jokke_, yeah | 09:57 |
| jokke_ | abhishekk: looks amazing, thanks for digging into those tests | 09:58 |
| *** zhanglong has quit IRC | 09:58 | |
| jokke_ | so we have one more to look into? | 09:58 |
| abhishekk | jokke_, thanks, still 2 tests are failing, I am having a look | 09:59 |
| abhishekk | I have added a reason, as it is making a rpc call to registry I am not able to find out from where exactly shared value is added to the visibility | 10:00 |
| abhishekk | needs some more time, also tempest is failing which needs changes as well :( | 10:01 |
| jokke_ | lets throw that test away. we can get rid of the registry anyways this cycle | 10:01 |
| *** zhanglong has joined #openstack-glance | 10:01 | |
| abhishekk | makes sense | 10:02 |
| abhishekk | we can move those to blacklist till then | 10:02 |
| jokke_ | I must have missed something on the TestMembershipVisibility 'cause I was expecting the test set needing to be ran on visibility shared for all those | 10:02 |
| jokke_ | so that was nice catch | 10:02 |
| abhishekk | yeah, initially I thought same as well | 10:03 |
| abhishekk | still, glance.tests.functional.db.test_migrations.ModelsMigrationsSyncSqlite.test_models_sync needs fix | 10:04 |
| jokke_ | yeah, do we really need to change the migration script to have those migrations working btw? | 10:04 |
| abhishekk | it runs from oslo.db so very difficult to debug | 10:04 |
| jokke_ | that was one of the things that feels bit nasty to touch | 10:05 |
| abhishekk | yes, they compare migration script with the models | 10:05 |
| abhishekk | and as you have changed the model, I guess either we need new migrartion/alembic script or (* is there a need to change the model?) | 10:06 |
| jokke_ | well that was kind of my thought as well if it is needed or not. I just couldn't figure out any code patch that would not set the field, but wanted to play it safe if there is one | 10:07 |
| jokke_ | I think we should set the default on the object already from the api in all the creation cases so it likely is not required | 10:08 |
| abhishekk | sounds good | 10:08 |
| jokke_ | Honestly if we want to or have to change the model, we should make new migration then. I think it's horrible idea to get inconsistent end results depending of which route you upgrade | 10:09 |
| abhishekk | agree | 10:09 |
| jokke_ | I just had no idea that needs new migration script nor how to actually do it so did not touch and tried to figure out if the tests blow on that or give some nice indication what to do ;P | 10:10 |
| abhishekk | :P | 10:11 |
| jokke_ | I kind of feel that we should not have different defaults on our API and our DB layers | 10:13 |
| jokke_ | just in case the api does not prepopulate the defaults in all cases | 10:13 |
| jokke_ | having inconsistency like that would be fecking nightmare to try to debug in few months when we totally forget what we did on this :D | 10:13 |
| abhishekk | yeah, and it will be hard to verify all the cases | 10:13 |
| abhishekk | agree | 10:14 |
| jokke_ | indeed | 10:14 |
| abhishekk | I never thought this change will cause this much headache ;) | 10:15 |
| jokke_ | ikr | 10:15 |
| abhishekk | tomorrow I will give a try to write a new migration script | 10:16 |
| jokke_ | thanks buddy | 10:16 |
| abhishekk | i guess I need to write alter table query | 10:16 |
| abhishekk | no problem :) | 10:17 |
| jokke_ | I'm trying to not worry about too much work on my days off, but I saw that you had looked into this so jumped on and wanted to have quick chat with you before you call it a night | 10:17 |
| jokke_ | ;) | 10:17 |
| abhishekk | :D, I will keep you posted | 10:17 |
| jokke_ | cheers, I'll keep an eye on during the week at some point of the day | 10:18 |
| abhishekk | :D, I will keep you posted :d | 10:18 |
| abhishekk | great, have a nice time | 10:18 |
| jokke_ | good news is that as I'm in Finland and actually got my rythm nudged nicely to mornings as well the time difference is not horrible :D | 10:19 |
| jokke_ | I've been weird enough out from the bed like between 0830 and 0930 every morn, which is weird thinking that this +2hrs from my normal time | 10:19 |
| jokke_ | I'm never up that early when home ;) | 10:20 |
| *** zhanglong has quit IRC | 10:33 | |
| *** abhishekk has quit IRC | 10:46 | |
| *** udesale has quit IRC | 10:54 | |
| *** pcaruana has quit IRC | 11:11 | |
| *** pcaruana has joined #openstack-glance | 11:16 | |
| *** Liang__ has quit IRC | 11:41 | |
| *** ratailor has quit IRC | 11:51 | |
| *** dpawlik has quit IRC | 11:58 | |
| *** dpawlik has joined #openstack-glance | 12:25 | |
| *** zigo has quit IRC | 12:31 | |
| *** rosmaita has joined #openstack-glance | 13:01 | |
| *** brinzhang has quit IRC | 13:04 | |
| *** zul has joined #openstack-glance | 13:26 | |
| *** udesale has joined #openstack-glance | 13:36 | |
| *** jdillaman has joined #openstack-glance | 14:08 | |
| *** irclogbot_1 has quit IRC | 14:14 | |
| *** irclogbot_1 has joined #openstack-glance | 14:38 | |
| *** irclogbot_1 has quit IRC | 15:01 | |
| *** irclogbot_1 has joined #openstack-glance | 15:09 | |
| *** dpawlik has quit IRC | 15:18 | |
| *** openstackgerrit has quit IRC | 15:22 | |
| *** Luzi has quit IRC | 15:24 | |
| *** zul has quit IRC | 16:11 | |
| *** zul has joined #openstack-glance | 16:20 | |
| *** pcaruana has quit IRC | 16:21 | |
| *** udesale has quit IRC | 16:40 | |
| *** imacdonn has joined #openstack-glance | 16:51 | |
| *** zul has quit IRC | 17:07 | |
| *** markvoelker has joined #openstack-glance | 17:33 | |
| *** markvoelker has quit IRC | 17:34 | |
| *** gyee has joined #openstack-glance | 17:45 | |
| *** MattMan has quit IRC | 18:09 | |
| *** MattMan has joined #openstack-glance | 18:10 | |
| *** jmlowe has quit IRC | 18:32 | |
| *** jmlowe has joined #openstack-glance | 18:50 | |
| *** jmlowe has quit IRC | 18:58 | |
| *** jmlowe has joined #openstack-glance | 18:59 | |
| *** itlinux has joined #openstack-glance | 19:16 | |
| *** jmlowe has quit IRC | 20:01 | |
| *** jmlowe has joined #openstack-glance | 20:03 | |
| *** jmlowe has quit IRC | 20:42 | |
| *** jmlowe has joined #openstack-glance | 21:27 | |
| *** itlinux has quit IRC | 22:37 | |
| *** rcernin has joined #openstack-glance | 22:45 | |
| *** zhanglong has joined #openstack-glance | 23:40 | |
| *** zhanglong has quit IRC | 23:45 | |
| -openstackstatus- NOTICE: The Etherpad service at https://etherpad.openstack.org/ has been offline since 23:22 UTC due to a hypervisor issue in our service provider, but should hopefully return to service shortly. | 23:48 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!