| *** linkmark has quit IRC | 00:12 | |
| *** r-daneel has joined #openstack-glance | 01:33 | |
| *** btully has joined #openstack-glance | 01:44 | |
| *** btully has quit IRC | 01:48 | |
| *** links has joined #openstack-glance | 03:39 | |
| *** udesale has joined #openstack-glance | 03:40 | |
| *** dalgaaf has quit IRC | 03:41 | |
| *** dalgaaf has joined #openstack-glance | 03:42 | |
| *** itlinux has quit IRC | 04:06 | |
| *** links has quit IRC | 04:15 | |
| *** hoonetorg has quit IRC | 04:28 | |
| *** abhishekk has joined #openstack-glance | 04:32 | |
| *** links has joined #openstack-glance | 04:33 | |
| *** hoonetorg has joined #openstack-glance | 04:45 | |
| *** tshefi has quit IRC | 04:46 | |
| *** pdeore has joined #openstack-glance | 05:15 | |
| *** bkopilov has joined #openstack-glance | 05:25 | |
| *** tshefi has joined #openstack-glance | 05:26 | |
| *** mosulica has joined #openstack-glance | 05:56 | |
| *** alexchadin has joined #openstack-glance | 06:12 | |
| *** alexchadin has quit IRC | 06:14 | |
| *** ratailor has joined #openstack-glance | 06:14 | |
| *** melwitt has quit IRC | 06:31 | |
| *** melwitt has joined #openstack-glance | 06:32 | |
| *** melwitt is now known as Guest9714 | 06:32 | |
| *** threestrands has joined #openstack-glance | 06:38 | |
| *** threestrands has quit IRC | 06:38 | |
| *** threestrands has joined #openstack-glance | 06:38 | |
| *** pcaruana has joined #openstack-glance | 06:56 | |
| *** zhurong has joined #openstack-glance | 06:59 | |
| *** tesseract has joined #openstack-glance | 07:04 | |
| *** rcernin has quit IRC | 07:09 | |
| *** btully has joined #openstack-glance | 07:11 | |
| *** pcaruana has quit IRC | 07:14 | |
| *** btully has quit IRC | 07:15 | |
| *** pcaruana has joined #openstack-glance | 07:18 | |
| *** threestrands has quit IRC | 07:32 | |
| *** AlexeyAbashkin has joined #openstack-glance | 07:39 | |
| *** peereb has joined #openstack-glance | 07:43 | |
| *** Luzi has joined #openstack-glance | 07:52 | |
| *** zhurong has quit IRC | 08:09 | |
| *** d0ugal has joined #openstack-glance | 08:31 | |
| *** d0ugal has quit IRC | 08:31 | |
| *** d0ugal has joined #openstack-glance | 08:31 | |
| *** btully has joined #openstack-glance | 08:42 | |
| *** btully has quit IRC | 09:18 | |
| *** pdeore has quit IRC | 09:26 | |
| *** dtantsur|afk is now known as dtantsur | 09:35 | |
| *** abhishekk-mbl has joined #openstack-glance | 09:43 | |
| *** abhishekk has quit IRC | 09:43 | |
| *** ratailor has quit IRC | 09:44 | |
| *** AlexeyAbashkin has quit IRC | 09:53 | |
| *** ratailor has joined #openstack-glance | 10:00 | |
| *** bkopilov has quit IRC | 10:07 | |
| *** udesale has quit IRC | 10:47 | |
| *** zzzeek has quit IRC | 10:49 | |
| *** zzzeek has joined #openstack-glance | 10:53 | |
| *** ratailor has quit IRC | 10:56 | |
| *** btully has joined #openstack-glance | 11:04 | |
| *** AlexeyAbashkin has joined #openstack-glance | 11:06 | |
| *** btully has quit IRC | 11:08 | |
| *** rosmaita has joined #openstack-glance | 11:08 | |
| *** bkopilov has joined #openstack-glance | 11:24 | |
| openstackgerrit | Brin Zhang proposed openstack/glance master: Add or modify document links to README https://review.openstack.org/579327 | 11:43 |
|---|---|---|
| *** Luzi has quit IRC | 12:02 | |
| *** MattMan has quit IRC | 12:09 | |
| *** MattMan has joined #openstack-glance | 12:10 | |
| *** Luzi has joined #openstack-glance | 12:18 | |
| *** peereb has quit IRC | 12:19 | |
| *** ratailor has joined #openstack-glance | 12:19 | |
| *** links has quit IRC | 12:44 | |
| *** mugsie has quit IRC | 12:49 | |
| *** mugsie has joined #openstack-glance | 12:49 | |
| *** mugsie has quit IRC | 12:49 | |
| *** mugsie has joined #openstack-glance | 12:49 | |
| *** edmondsw has joined #openstack-glance | 12:56 | |
| *** links has joined #openstack-glance | 12:56 | |
| *** edmondsw has quit IRC | 13:06 | |
| *** Luzi has quit IRC | 13:08 | |
| *** r-daneel has quit IRC | 13:28 | |
| *** udesale has joined #openstack-glance | 13:30 | |
| *** udesale has quit IRC | 13:35 | |
| *** AlexeyAbashkin has quit IRC | 13:40 | |
| *** AlexeyAbashkin has joined #openstack-glance | 13:41 | |
| *** lbragstad has joined #openstack-glance | 13:46 | |
| *** ratailor has quit IRC | 13:55 | |
| *** links has quit IRC | 14:27 | |
| *** udesale has joined #openstack-glance | 14:34 | |
| *** ChanServ changes topic to "OpenStack Glance | priorities: http://lists.openstack.org/pipermail/openstack-dev/2018-March/128739.html | logs at http://eavesdrop.openstack.org/irclogs/%23openstack-glance/" | 14:36 | |
| *** dtantsur is now known as dtantsur|brb | 14:38 | |
| *** btully has joined #openstack-glance | 14:41 | |
| *** btully has quit IRC | 14:46 | |
| abhishekk-mbl | smcginnis, rosmaita please have a look on multistore patches when you get some time | 14:51 |
| smcginnis | abhishekk-mbl: Will do! | 14:51 |
| *** imacdonn has quit IRC | 14:53 | |
| *** imacdonn has joined #openstack-glance | 14:53 | |
| abhishekk-mbl | Thank you | 15:08 |
| *** pcaruana has quit IRC | 15:16 | |
| *** tshefi has quit IRC | 15:17 | |
| *** r-daneel has joined #openstack-glance | 15:23 | |
| *** gyee has joined #openstack-glance | 15:25 | |
| abhishekk-mbl | jokke_: hi around? | 15:27 |
| jokke_ | abhishekk-mbl: yes | 15:34 |
| abhishekk-mbl | Just give me 5 minutes to start the laptop | 15:35 |
| *** dtantsur|brb is now known as dtantsur | 15:37 | |
| *** abhishekk has joined #openstack-glance | 15:37 | |
| abhishekk | jokke_, just to confirm If backend is not appropriate I should just exit with 404 and let image be in staging state right? | 15:39 |
| jokke_ | Not 404, I think the BadRequest (or conflict for consistency) is fine, If you look few rows down we have bunch of checks before the taskflow is created. It would make sense to add the backend check there as well | 15:42 |
| abhishekk | yeah sorry, 400 | 15:43 |
| jokke_ | Like i would pretty much prefer to put it into the try block strating on L121 on that patch and make the check just raising exception.Conflict like the rest. That would eliminate few lines of duplication and keep the checks together | 15:44 |
| jokke_ | easier to read and find from the code | 15:45 |
| abhishekk | ok, I will do that change | 15:45 |
| abhishekk | regarding your 2nd comment on the same file | 15:45 |
| abhishekk | could you explain it? and now as we are removing _cleanup call I don't think we need that | 15:46 |
| jokke_ | tru, we do not need that | 15:46 |
| abhishekk | great | 15:46 |
| abhishekk | will upload a new patch soon | 15:46 |
| jokke_ | What I meant is that we should reserve the "staging" or "os_staging" store ID for glance internal use | 15:46 |
| abhishekk | if we do so, we should also mention that the file path for that should be different from default path | 15:47 |
| jokke_ | that would push the staging config to be just one more store configuration in the config file (and allow the deployer to use any writable back-end they wish) | 15:47 |
| abhishekk | and also we need to deprecate node_staging_uri config option | 15:48 |
| jokke_ | and we will get rid of all the black magic we do in the tasks | 15:48 |
| jokke_ | yes, but I think that all is for Stein, only thing we should do now, is to document the ID reservation so people don't start using it | 15:48 |
| abhishekk | I think we should do it in S when we are retiring old store logic | 15:48 |
| *** tesseract has quit IRC | 15:49 | |
| abhishekk | Ok, I will add that in documentation | 15:49 |
| jokke_ | ++ | 15:49 |
| jokke_ | as we have started to use the os_prefix a lot in the properties, I think we should use the os_ prefix in these as well | 15:50 |
| jokke_ | obviously depends what smcginnis and rosmaita thinks | 15:50 |
| rosmaita | i have no opinion | 15:51 |
| jokke_ | but "os_staging" and "os_working_dir" would be my preference | 15:51 |
| *** itlinux has joined #openstack-glance | 15:51 | |
| *** itlinux has quit IRC | 15:51 | |
| jokke_ | just to keep that message consistent "Don't use os_ prefix on any of your named things" ;) | 15:51 |
| smcginnis | I do like consistency. | 15:51 |
| abhishekk | ok, I will first put implementation patch and then the doc patch | 15:51 |
| jokke_ | abhishekk: sounds good | 15:52 |
| jokke_ | rosmaita: how is multihash looking? | 15:52 |
| jokke_ | (no pressure yet, just checking) | 15:52 |
| rosmaita | working on a few tests | 15:52 |
| jokke_ | coolcool | 15:52 |
| rosmaita | some bad news though | 15:52 |
| *** mosulica has quit IRC | 15:52 | |
| rosmaita | that wrapper function in glance_store ... | 15:53 |
| rosmaita | that actually isn't the one we call from glance | 15:53 |
| jokke_ | so we need to backport new wrapping and get another glance_store tagged, it sounds | 15:55 |
| rosmaita | i will put up a quick patch for your perusal | 15:55 |
| openstackgerrit | Brian Rosmaita proposed openstack/glance_store master: Add interface function for multihash https://review.openstack.org/587098 | 15:57 |
| *** itlinux has joined #openstack-glance | 16:10 | |
| *** itlinux has quit IRC | 16:12 | |
| *** itlinux has joined #openstack-glance | 16:12 | |
| *** itlinux has left #openstack-glance | 16:12 | |
| *** Guest9714 is now known as melwitt | 16:15 | |
| openstackgerrit | Abhishek Kekane proposed openstack/glance master: Add multi-store support https://review.openstack.org/574582 | 16:18 |
| *** mvk_ has quit IRC | 16:19 | |
| *** itlinux_ has joined #openstack-glance | 16:19 | |
| *** AlexeyAbashkin has quit IRC | 16:30 | |
| *** priteau has joined #openstack-glance | 16:33 | |
| jokke_ | rosmaita: can we open a bug that store_add_to_backend_with_multihash was not wrapped correctly instead of calling that implements bp? As it is proposed now (new feature), we cannot backport it to stable/rocky, bugging it (what it really is as we missed that on the implementation) would permit us to do so | 16:33 |
| rosmaita | ok, will do | 16:33 |
| itlinux_ | hello rosmaita: as we talked last week.. I wonder what could be the issue if you move glance as cinder backend.. | 16:34 |
| itlinux_ | since I am using OOO, it pretty much was unable to spin up vms | 16:34 |
| itlinux_ | I tested with packstack.. and that works.. the changes are pretty simple.. | 16:34 |
| itlinux_ | one line | 16:34 |
| rosmaita | itlinux_: do you want to put up a patch? | 16:35 |
| itlinux_ | no | 16:35 |
| jokke_ | itlinux_: you probably get better response from #openstack channel for usage support or https://ask.openstack.org ... the individual project channels are for development work. I'm pretty sure TripleO has also documented how to deploy with cinder back-end, in general you don't want to knife in manually on anything you control with TripleO as you will regret them being out of sync later on | 16:41 |
| itlinux_ | jokke_: I did enable it on OOO, so just trying to debug the issue.. :) | 16:42 |
| *** udesale has quit IRC | 16:43 | |
| *** priteau has quit IRC | 16:44 | |
| jokke_ | I can't at least tell out of my head how TripleO deploys Glance, Cinder and Keystone with all their permissions and I think I wasn't involved with that deployment model on TripleO (I might have been tbh. have slept since so can't remember) :D | 16:45 |
| jokke_ | But I'm pretty sure we have customers running that model and I'm 100% we (as in Red Hat) do test that as part of our packaging/productizing effort. So if configured correctly, I'd be very strongly claiming that it works :) | 16:47 |
| openstackgerrit | Abhishek Kekane proposed openstack/glance master: Unit/Functional tests for multi store support https://review.openstack.org/577502 | 16:51 |
| openstackgerrit | Brian Rosmaita proposed openstack/glance_store master: Wrap interface function for multihash correctly https://review.openstack.org/587098 | 16:53 |
| *** idlemind has joined #openstack-glance | 16:58 | |
| *** priteau has joined #openstack-glance | 17:02 | |
| openstackgerrit | Abhishek Kekane proposed openstack/glance master: Doc:Multiple stores support https://review.openstack.org/576075 | 17:13 |
| abhishekk | jokke_, made changes as per your suggestions | 17:14 |
| abhishekk | thank you for review | 17:14 |
| openstackgerrit | Abhishek Kekane proposed openstack/glance master: Add multi-store support https://review.openstack.org/574582 | 17:52 |
| openstackgerrit | Abhishek Kekane proposed openstack/glance master: Unit/Functional tests for multi store support https://review.openstack.org/577502 | 17:52 |
| abhishekk | rebased patches with current master | 17:53 |
| openstackgerrit | Abhishek Kekane proposed openstack/glance master: Doc:Multiple stores support https://review.openstack.org/576075 | 18:06 |
| *** dtantsur is now known as dtantsur|afk | 18:31 | |
| openstackgerrit | Matt Riedemann proposed openstack/glance master: Document hw_cpu_policy and hw_cpu_thread_policy image properties https://review.openstack.org/587199 | 19:27 |
| *** abhishekk-mbl has quit IRC | 19:43 | |
| *** abhishekk has quit IRC | 20:00 | |
| *** btully has joined #openstack-glance | 20:08 | |
| *** btully has quit IRC | 20:12 | |
| *** mvk_ has joined #openstack-glance | 20:59 | |
| openstackgerrit | Brian Rosmaita proposed openstack/glance master: Multihash implementation for Glance https://review.openstack.org/587225 | 20:59 |
| *** r-daneel has quit IRC | 21:03 | |
| *** ThomasWhite has quit IRC | 21:03 | |
| *** ThomasWhite has joined #openstack-glance | 21:04 | |
| *** r-daneel has joined #openstack-glance | 21:11 | |
| *** abhishekk-mbl has joined #openstack-glance | 21:13 | |
| *** priteau has quit IRC | 21:14 | |
| *** itlinux_ has quit IRC | 21:16 | |
| *** itlinux has joined #openstack-glance | 21:18 | |
| *** itlinux has quit IRC | 21:59 | |
| *** rcernin has joined #openstack-glance | 22:02 | |
| *** priteau has joined #openstack-glance | 22:14 | |
| *** threestrands has joined #openstack-glance | 22:18 | |
| *** threestrands has quit IRC | 22:18 | |
| *** threestrands has joined #openstack-glance | 22:18 | |
| *** linkmark has joined #openstack-glance | 22:40 | |
| *** r-daneel has quit IRC | 23:16 | |
| *** btully has joined #openstack-glance | 23:45 | |
| *** btully has quit IRC | 23:50 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!