| *** gyee has quit IRC | 00:03 | |
| *** itlinux has quit IRC | 00:13 | |
| *** markvoelker has quit IRC | 00:19 | |
| *** threestrands has quit IRC | 00:38 | |
| *** markvoelker has joined #openstack-glance | 00:47 | |
| openstackgerrit | Chen Hanxiao proposed openstack/python-glanceclient master: image-list: add checksum algorithm description https://review.openstack.org/580065 | 00:50 |
|---|---|---|
| *** rcernin_ has joined #openstack-glance | 00:56 | |
| *** rcernin has quit IRC | 00:58 | |
| *** btully has joined #openstack-glance | 01:12 | |
| *** btully has quit IRC | 01:17 | |
| *** links has joined #openstack-glance | 01:17 | |
| *** edmondsw has joined #openstack-glance | 01:27 | |
| *** edmondsw has quit IRC | 01:31 | |
| *** gcb has joined #openstack-glance | 02:16 | |
| *** btully has joined #openstack-glance | 03:01 | |
| *** btully has quit IRC | 03:05 | |
| *** edmondsw has joined #openstack-glance | 03:15 | |
| *** edmondsw has quit IRC | 03:19 | |
| *** r-daneel has joined #openstack-glance | 03:21 | |
| *** r-daneel has quit IRC | 03:39 | |
| *** dalgaaf has quit IRC | 03:53 | |
| *** tshefi has quit IRC | 03:54 | |
| *** dalgaaf has joined #openstack-glance | 03:55 | |
| *** pdeore has joined #openstack-glance | 03:55 | |
| *** btully has joined #openstack-glance | 04:05 | |
| *** r-daneel has joined #openstack-glance | 04:17 | |
| *** pdeore has quit IRC | 04:32 | |
| *** btully has quit IRC | 04:52 | |
| *** abhishekk has joined #openstack-glance | 04:55 | |
| *** edmondsw has joined #openstack-glance | 05:03 | |
| *** tshefi has joined #openstack-glance | 05:05 | |
| *** edmondsw has quit IRC | 05:08 | |
| *** pdeore has joined #openstack-glance | 05:15 | |
| *** fnordahl has quit IRC | 05:16 | |
| *** ratailor has joined #openstack-glance | 05:19 | |
| *** fnordahl has joined #openstack-glance | 05:23 | |
| *** Luzi has joined #openstack-glance | 05:45 | |
| openstackgerrit | Abhishek Kekane proposed openstack/python-glanceclient master: Add support for hide old images https://review.openstack.org/579117 | 05:50 |
| *** pcaruana has joined #openstack-glance | 06:34 | |
| *** alexchadin has joined #openstack-glance | 06:35 | |
| *** btully has joined #openstack-glance | 06:38 | |
| *** btully has quit IRC | 06:42 | |
| *** udesale has joined #openstack-glance | 07:06 | |
| *** alexchadin has quit IRC | 07:13 | |
| *** alexchadin has joined #openstack-glance | 07:15 | |
| *** tesseract has joined #openstack-glance | 07:18 | |
| *** markvoelker has quit IRC | 07:29 | |
| *** AlexeyAbashkin has joined #openstack-glance | 07:50 | |
| *** rcernin_ has quit IRC | 07:56 | |
| *** kushalAgrawal has joined #openstack-glance | 07:57 | |
| *** alexchadin has quit IRC | 08:01 | |
| *** alexchadin has joined #openstack-glance | 08:03 | |
| *** rcernin_ has joined #openstack-glance | 08:09 | |
| *** Luzi has quit IRC | 08:11 | |
| jokke_ | abhishekk: you there? | 08:19 |
| abhishekk | jokke_, yes, I am | 08:19 |
| jokke_ | you missed yesterday? | 08:19 |
| abhishekk | jokke_, what? | 08:20 |
| abhishekk | ohh I pinged you | 08:20 |
| abhishekk | I forgot | 08:20 |
| jokke_ | yeah ;) | 08:20 |
| abhishekk | just to know you, your comments on mult-store client support makes sense :D | 08:21 |
| abhishekk | I have fixed all of them | 08:21 |
| *** Luzi has joined #openstack-glance | 08:26 | |
| jokke_ | the test_shell_v2.py | 08:28 |
| jokke_ | why the line 435? | 08:29 |
| abhishekk | let me check | 08:30 |
| abhishekk | jokke_, that is required as while creating the image I am not passing backend and args it will have backend as none, so I need to remove it | 08:31 |
| abhishekk | otherwise it will fails assert on the next line | 08:31 |
| abhishekk | there is one decorator which removes arguments if it does not has any values | 08:32 |
| *** dtantsur|afk is now known as dtantsur | 08:33 | |
| jokke_ | But where that gets the backend key from? :o | 08:33 |
| jokke_ | it has no such defined anywhere | 08:33 |
| abhishekk | check line #418 | 08:34 |
| jokke_ | yeah | 08:34 |
| jokke_ | it creates args from temp_args | 08:34 |
| jokke_ | 413-417 is where that temp_args is defined and there is no backend there | 08:35 |
| jokke_ | only thing that touches it since is 434 that just removes the file from it | 08:35 |
| abhishekk | line 418 is calling a method where backend is added to the args | 08:36 |
| jokke_ | yes, and you're trying to remove it from temp_args | 08:39 |
| abhishekk | jokke_, I will try to find a workaround, I got your point here | 08:40 |
| jokke_ | nono ... I'm just trying to understand how that backend ended up to the dict | 08:41 |
| jokke_ | as I literally can't see anything putting it up there | 08:41 |
| abhishekk | jokke_, I am passing this dict to _make_args function | 08:43 |
| jokke_ | it gets put to the args that is used to call the do_image_create and I would understand if we needed to add it to the dict when testing as it's a new parameter passed to the call, but instead I see you trying to remove it from the disct it should not be in the first place | 08:43 |
| abhishekk | and then in that function I am adding backend to that dictionary | 08:43 |
| jokke_ | just trying to figure out what kind of black magic is happening there :D | 08:43 |
| abhishekk | :D | 08:45 |
| jokke_ | so in lines 413-417 we define temp_args on line 418 args = self._make_args(temp_args) ... that function has temp_args as input, not output | 08:45 |
| jokke_ | it outputs args | 08:45 |
| abhishekk | yes but python has something that if you passed dictionary to the function and modify that dict inside function then original dict gets modified | 08:46 |
| jokke_ | ohhh riight! That's where it is coming from! | 08:47 |
| abhishekk | jokke_, yeah | 08:47 |
| abhishekk | and If i don't add backend in args then tests are failing saying backend is not passed | 08:48 |
| jokke_ | still after you put the defaults in there? | 08:48 |
| abhishekk | no that I have not checked, I will check it now :D | 08:49 |
| *** priteau has joined #openstack-glance | 08:56 | |
| *** udesale has quit IRC | 09:06 | |
| *** ratailor has quit IRC | 09:18 | |
| *** ratailor has joined #openstack-glance | 09:20 | |
| *** alexchadin has quit IRC | 09:24 | |
| *** udesale has joined #openstack-glance | 09:28 | |
| *** markvoelker has joined #openstack-glance | 09:33 | |
| *** tshefi has quit IRC | 09:44 | |
| *** tshefi has joined #openstack-glance | 09:45 | |
| *** stephenfin has quit IRC | 09:47 | |
| *** stephenfin has joined #openstack-glance | 09:49 | |
| *** ratailor has quit IRC | 09:55 | |
| *** alexchadin has joined #openstack-glance | 09:55 | |
| *** ratailor has joined #openstack-glance | 09:56 | |
| *** alexchadin has quit IRC | 10:00 | |
| *** markvoelker has quit IRC | 10:04 | |
| *** btully has joined #openstack-glance | 10:15 | |
| *** btully has quit IRC | 10:19 | |
| *** mvk_ has quit IRC | 10:23 | |
| *** alexchadin has joined #openstack-glance | 10:25 | |
| *** alexchadin has quit IRC | 10:30 | |
| *** alexchadin has joined #openstack-glance | 10:30 | |
| *** alexchadin has quit IRC | 10:31 | |
| *** alexchadin has joined #openstack-glance | 10:31 | |
| *** alexchadin has quit IRC | 10:31 | |
| *** alexchadin has joined #openstack-glance | 10:32 | |
| *** alexchadin has quit IRC | 10:32 | |
| *** edmondsw has joined #openstack-glance | 10:35 | |
| *** edmondsw has quit IRC | 10:40 | |
| *** alexchadin has joined #openstack-glance | 10:41 | |
| *** rcernin_ has quit IRC | 10:52 | |
| *** mvk_ has joined #openstack-glance | 10:53 | |
| *** alexchadin has quit IRC | 10:54 | |
| *** alexchad_ has joined #openstack-glance | 10:57 | |
| openstackgerrit | Abhishek Kekane proposed openstack/python-glanceclient master: Add multi-store support https://review.openstack.org/575370 | 11:01 |
| *** markvoelker has joined #openstack-glance | 11:01 | |
| *** alexchad_ has quit IRC | 11:02 | |
| *** rosmaita has joined #openstack-glance | 11:05 | |
| *** alexchadin has joined #openstack-glance | 11:06 | |
| openstackgerrit | Abhishek Kekane proposed openstack/python-glanceclient master: Unit tests for multi-store support https://review.openstack.org/577115 | 11:10 |
| abhishekk | jokke_, done ^^^ | 11:11 |
| abhishekk | need release notes patches for multi hash, multi store and hide old images (rosmaita, jokke_) | 11:12 |
| rosmaita | abhishekk, jokke_ i can write some/all release notes, let me know which ones (don't want to duplicate efforts) | 11:16 |
| rosmaita | got to do some local stuff this morning | 11:17 |
| abhishekk | great, thank you take all unless jokke_ thinks otherwise :D | 11:18 |
| rosmaita | abhishekk, jokke_ ok sounds good, jokke_ can handle the bugfixes and prelude | 11:19 |
| abhishekk | thank you | 11:19 |
| *** gcb has quit IRC | 11:23 | |
| jokke_ | rosmaita: I don't mind, either way | 11:24 |
| jokke_ | let me know if you have no time for them (we need your reviews as well) | 11:24 |
| rosmaita | jokke_ i'll work on notes this morning, reviews this afternoon | 11:25 |
| *** udesale has quit IRC | 11:28 | |
| abhishekk | i will be back online few hours after | 11:31 |
| *** abhishekk has quit IRC | 11:32 | |
| *** mvk_ has quit IRC | 11:33 | |
| *** markvoelker has quit IRC | 11:34 | |
| *** tshefi has quit IRC | 11:36 | |
| *** r-daneel has quit IRC | 11:46 | |
| *** mvk_ has joined #openstack-glance | 11:47 | |
| openstackgerrit | Merged openstack/python-glanceclient master: image-list: add checksum algorithm description https://review.openstack.org/580065 | 11:49 |
| *** linkmark has joined #openstack-glance | 11:54 | |
| *** edmondsw has joined #openstack-glance | 11:57 | |
| *** pdeore has quit IRC | 11:57 | |
| *** MattMan has quit IRC | 12:08 | |
| *** MattMan has joined #openstack-glance | 12:08 | |
| *** r-daneel has joined #openstack-glance | 12:11 | |
| *** markvoelker has joined #openstack-glance | 12:12 | |
| *** r-daneel has quit IRC | 12:14 | |
| *** ratailor has quit IRC | 12:19 | |
| *** pdeore has joined #openstack-glance | 12:51 | |
| *** kushalAgrawal has quit IRC | 13:07 | |
| *** pdeore has quit IRC | 13:42 | |
| *** Luzi has quit IRC | 13:53 | |
| *** r-daneel has joined #openstack-glance | 14:02 | |
| *** imacdonn has quit IRC | 14:07 | |
| *** links has quit IRC | 14:31 | |
| *** wxy| has joined #openstack-glance | 14:31 | |
| *** imacdonn has joined #openstack-glance | 14:51 | |
| *** udesale has joined #openstack-glance | 14:56 | |
| *** tshefi has joined #openstack-glance | 15:02 | |
| *** rcernin_ has joined #openstack-glance | 15:04 | |
| *** alexchadin has quit IRC | 15:10 | |
| *** udesale has quit IRC | 15:18 | |
| *** rcernin_ has quit IRC | 15:30 | |
| *** pcaruana has quit IRC | 15:32 | |
| *** gyee has joined #openstack-glance | 15:37 | |
| *** itlinux has joined #openstack-glance | 15:49 | |
| itlinux | hello guys, I wanted to doublecheck since I asked the cinder team but they suggest to ask this channel about having glance to use cinder backend.. I read some docs where it states to change cinder.conf and also glance-api.conf but as I remember there was only one thing to change in glance-api.conf | 16:17 |
| itlinux | can someone confirm it | 16:17 |
| jokke_ | itlinux: afaik you just need glance configured to use the cinder backend and cinder provides the privsep conf for brick so that it all works together | 16:20 |
| itlinux | ok jokke_: | 16:21 |
| jokke_ | rosmaita: I'm gonna be driving to the East coast. Will take my laptop with me so ping if something needs attention. I'll check later | 16:21 |
| itlinux | looks like cinder backend is pretty simple changes.. | 16:21 |
| *** abhishekk-away has joined #openstack-glance | 16:32 | |
| *** abhishekk-away is now known as abhishekk | 16:33 | |
| *** dtantsur is now known as dtantsur|afk | 16:39 | |
| *** itlinux_ has joined #openstack-glance | 17:07 | |
| *** wxy| has quit IRC | 17:07 | |
| *** itlinux has quit IRC | 17:09 | |
| *** mvk_ has quit IRC | 17:09 | |
| *** AlexeyAbashkin has quit IRC | 17:11 | |
| abhishekk | jokke_, rosmaita, smcginnis we only have a day between client release, and looking at the gate queue it will take 3-4 hours to get patch in | 17:17 |
| *** tesseract has quit IRC | 17:17 | |
| smcginnis | Also feature freeze too. I haven't had time to look. Do we have a set of patches ready that I could help review? | 17:18 |
| abhishekk | Yep, i have multistore and hidden images patch ready | 17:19 |
| abhishekk | https://review.openstack.org/575370 | 17:20 |
| abhishekk | https://review.openstack.org/577115 | 17:20 |
| abhishekk | https://review.openstack.org/579117 | 17:21 |
| abhishekk | Also there might be possibility patches goes in merged conflict as all changes are around shell.py and test_shell_v2.py | 17:22 |
| abhishekk | smcginnis thank you | 17:24 |
| smcginnis | abhishekk: Cool, I will try to get to those after I take a quick lunch break. | 17:25 |
| smcginnis | abhishekk: If you're not around and we get merge conflicts I will try to resolve them to keep things moving. It must be getting pretty late there, right? | 17:26 |
| abhishekk | Yes, | 17:27 |
| abhishekk | I will try to be around till next 2-3 hours though | 17:27 |
| abhishekk | But I dont mind if you coauthor patches :D | 17:27 |
| smcginnis | If I update anything I don't think I will be coauthor. Git should still show you as the author of the patch. | 17:29 |
| smcginnis | But hopefully it can be avoided. ;) | 17:29 |
| *** btully has joined #openstack-glance | 17:30 | |
| *** btully has quit IRC | 17:35 | |
| abhishekk | smcginnis: fyi, later in day brian will propose release notes patches as well | 17:42 |
| rosmaita | hopefully within the next hour | 17:42 |
| *** itlinux_ has quit IRC | 17:42 | |
| *** itlinux has joined #openstack-glance | 17:43 | |
| abhishekk | great | 17:44 |
| *** mvk_ has joined #openstack-glance | 17:50 | |
| rosmaita | abhishekk smcginnis jokke_ could use input on https://bugs.launchpad.net/python-glanceclient/+bug/1783290 | 18:21 |
| openstack | Launchpad bug 1783290 in Glance Client "glance will return 401 error if the request token contains url code" [High,Triaged] - Assigned to wangxiyuan (wangxiyuan) | 18:21 |
| abhishekk | whatever wan has described makes sense to me | 18:32 |
| abhishekk | I will have a look in the morning my time | 18:34 |
| rosmaita | ty | 18:34 |
| smcginnis | Looks like the patch is cutting it close, but it makes sense. | 18:35 |
| abhishekk | smcginnis: thank you for reviews, i will test if dest is working as you said and the push a patch in few minutes | 18:46 |
| smcginnis | Great! | 18:47 |
| *** abhishekk is now known as abhishekk-mbl | 18:50 | |
| *** abhishekk has joined #openstack-glance | 18:51 | |
| *** itlinux has quit IRC | 18:54 | |
| *** itlinux has joined #openstack-glance | 19:02 | |
| *** itlinux has quit IRC | 19:03 | |
| openstackgerrit | Abhishek Kekane proposed openstack/python-glanceclient master: Add support for hide old images https://review.openstack.org/579117 | 19:04 |
| *** abhishekk has quit IRC | 19:17 | |
| *** btully has joined #openstack-glance | 19:19 | |
| *** btully has quit IRC | 19:23 | |
| *** itlinux has joined #openstack-glance | 19:58 | |
| openstackgerrit | Brian Rosmaita proposed openstack/python-glanceclient master: Add multihash release note. https://review.openstack.org/585535 | 20:06 |
| *** rcernin_ has joined #openstack-glance | 20:18 | |
| openstackgerrit | Brian Rosmaita proposed openstack/python-glanceclient master: Add release note for multi-store support https://review.openstack.org/585541 | 20:35 |
| *** tshefi has quit IRC | 20:42 | |
| *** d0ugal has quit IRC | 20:44 | |
| *** btully has joined #openstack-glance | 21:08 | |
| openstackgerrit | Brian Rosmaita proposed openstack/python-glanceclient master: Add release note for hidden images support https://review.openstack.org/585555 | 21:11 |
| *** btully has quit IRC | 21:12 | |
| *** abhishekk-mbl has quit IRC | 21:26 | |
| *** rcernin_ has quit IRC | 21:30 | |
| openstackgerrit | Merged openstack/python-glanceclient master: Add support for multihash https://review.openstack.org/584642 | 21:34 |
| *** edmondsw has quit IRC | 21:34 | |
| *** abhishekk-mbl has joined #openstack-glance | 21:36 | |
| abhishekk-mbl | rosmaita: hi, around? | 21:36 |
| abhishekk-mbl | You mean to say, i should remove hidden from schema and instead add --hidden as argument? | 21:37 |
| *** itlinux has quit IRC | 21:38 | |
| abhishekk-mbl | Its very late at my end, if you suggest this please add a comment on the patch so that i can fix it in the morning my time, thank you | 21:47 |
| *** abhishekk-mbl has quit IRC | 21:49 | |
| *** priteau has quit IRC | 21:51 | |
| rosmaita | abhishekk-mbl: left a comment on the patch, not sure how helpful it is | 22:19 |
| *** rcernin has joined #openstack-glance | 22:30 | |
| *** Nil_ has quit IRC | 22:42 | |
| jokke_ | rosmaita: that 1783290 is something we likely want to fix but unless we have batch ready it's totally backportable as well after Thu | 22:57 |
| openstackgerrit | Merged openstack/python-glanceclient master: Add multihash release note. https://review.openstack.org/585535 | 23:01 |
| *** Nil_ has joined #openstack-glance | 23:03 | |
| jokke_ | ok, will be back at the morn | 23:33 |
| *** r-daneel has quit IRC | 23:38 | |
| *** linkmark has quit IRC | 23:57 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!