Monday, 2018-07-09

*** btully has joined #openstack-glance00:00
*** threestrands has joined #openstack-glance00:03
*** threestrands has quit IRC00:03
*** threestrands has joined #openstack-glance00:03
*** btully has quit IRC00:05
*** aniketh has quit IRC00:20
*** dalgaaf has quit IRC00:23
*** dalgaaf has joined #openstack-glance00:24
*** edmondsw has joined #openstack-glance01:04
*** edmondsw has quit IRC01:08
*** threestrands_ has joined #openstack-glance01:18
*** threestrands_ has quit IRC01:18
*** threestrands_ has joined #openstack-glance01:18
*** threestrands_ has quit IRC01:19
*** threestrands_ has joined #openstack-glance01:20
*** threestrands_ has quit IRC01:21
*** threestrands_ has joined #openstack-glance01:21
*** threestrands_ has quit IRC01:21
*** threestrands_ has joined #openstack-glance01:21
*** threestrands has quit IRC01:21
*** edmondsw has joined #openstack-glance02:52
*** edmondsw has quit IRC02:57
*** btully has joined #openstack-glance03:38
*** btully has quit IRC03:43
*** abhishekk has joined #openstack-glance04:39
*** edmondsw has joined #openstack-glance04:40
*** bkopilov has quit IRC04:44
*** edmondsw has quit IRC04:44
*** links has joined #openstack-glance05:00
*** pdeore has joined #openstack-glance05:03
*** btully has joined #openstack-glance05:27
*** btully has quit IRC05:31
*** pooja_jadhav has joined #openstack-glance05:46
*** mosulica has joined #openstack-glance05:58
*** tshefi has joined #openstack-glance06:14
*** Luzi has joined #openstack-glance06:27
*** edmondsw has joined #openstack-glance06:28
*** edmondsw has quit IRC06:33
*** aniketh has joined #openstack-glance06:36
*** bkopilov has joined #openstack-glance06:43
*** alexchadin has joined #openstack-glance06:45
*** peereb has joined #openstack-glance07:05
*** tesseract has joined #openstack-glance07:06
*** rcernin has quit IRC07:08
*** amoralej|off is now known as amoralej07:21
*** tesseract has quit IRC07:25
*** tesseract has joined #openstack-glance07:27
*** itlinux has joined #openstack-glance07:32
*** d0ugal_ has quit IRC07:33
*** d0ugal has joined #openstack-glance07:33
*** d0ugal has quit IRC07:33
*** d0ugal has joined #openstack-glance07:33
*** alexchadin has quit IRC07:36
*** alexchadin has joined #openstack-glance07:42
*** itlinux has quit IRC07:52
*** itlinux has joined #openstack-glance08:00
*** zigo has quit IRC08:03
*** zigo has joined #openstack-glance08:05
*** dpawlik has joined #openstack-glance08:09
*** threestrands_ has quit IRC08:12
*** edmondsw has joined #openstack-glance08:16
*** edmondsw has quit IRC08:21
*** bkopilov has quit IRC08:33
*** w|zzy has quit IRC08:37
*** w|zzy has joined #openstack-glance08:40
*** gvrangan has joined #openstack-glance08:44
*** bkopilov has joined #openstack-glance08:49
*** bkopilov has quit IRC09:09
*** d0ugal has quit IRC09:17
*** d0ugal has joined #openstack-glance09:23
*** alexchadin has quit IRC09:25
*** alexchadin has joined #openstack-glance09:29
*** bkopilov has joined #openstack-glance09:31
*** abhishekk is now known as abhishekk|afk09:34
*** gvrangan has quit IRC09:42
*** itlinux has quit IRC09:42
*** itlinux has joined #openstack-glance09:48
*** gvrangan has joined #openstack-glance09:52
*** gvrangan has quit IRC09:53
*** finucannot is now known as stephenfin09:53
*** gvrangan has joined #openstack-glance09:54
*** gvrangan has quit IRC09:55
*** gvrangan has joined #openstack-glance09:56
*** rosmaita has joined #openstack-glance09:57
rosmaita#startmeeting glance_bs10:01
openstackMeeting started Mon Jul  9 10:01:57 2018 UTC and is due to finish in 60 minutes.  The chair is rosmaita. Information about MeetBot at http://wiki.debian.org/MeetBot.10:01
openstackUseful Commands: #action #agreed #help #info #idea #link #topic #startvote.10:01
*** openstack changes topic to " (Meeting topic: glance_bs)"10:02
openstackThe meeting name has been set to 'glance_bs'10:02
rosmaitagood morning, time for the glance bug squad meeting10:02
abhishekk|afko/10:02
abhishekk|afkgood morning10:02
*** abhishekk|afk is now known as abhishekk10:02
rosmaitao/10:02
rosmaitai think let's concentrate on glance-store today10:03
abhishekksounds good10:03
rosmaitayou are reading my mind!10:04
rosmaita#link https://etherpad.openstack.org/p/glance-bug-squad-meeting10:05
abhishekk:D10:05
rosmaitaglad tomoki is already working on it10:05
*** alexchadin has quit IRC10:06
abhishekkhttps://review.openstack.org/#/c/579335/10:06
rosmaitathink we should target it for 0.25.0 ?10:07
abhishekkthis is the patch for resolving the issue10:07
rosmaitait seems like a bad error10:07
abhishekkyes, it requires otherwise cinder backend is broken10:07
rosmaitawe should ask smcginnis[m] to take a look10:08
abhishekkI will add him as a reviewer10:08
rosmaitathanks!10:09
rosmaitaok, i marked it as critical for 0.25.010:09
abhishekkok10:09
rosmaitaalthough i guess that's overstating it a bit since the cinder driver still says it's experimental10:09
jokke_It might be good time to drop that statement as well ... I did not realize it's still stating so ;)10:10
rosmaitajokke_ : hello!10:11
rosmaitayes, i think it gets logged when the store is loaded10:11
abhishekkjokke_, o/10:11
rosmaitai'll file a bug for that ... do we want to do it before 0.25.0 ?10:12
abhishekkI don't think so10:12
jokke_I'd be ok with that10:13
rosmaitaalso, i guess this one is unreleated? https://bugs.launchpad.net/glance-store/+bug/176420010:13
openstackLaunchpad bug 1764200 in glance_store "Glance Cinder backed images & multiple regions" [High,Triaged]10:13
jokke_if we get this bugfix in as well10:13
rosmaitatrue, it would be bad to say it's no longer experimental AND it doesn't work!10:13
jokke_indeed ;)10:14
rosmaitahere's the list of open bugs, newest first: https://bugs.launchpad.net/glance-store/?orderby=-id&start=010:15
rosmaitalet's take a quick glance (ha!) at them and see if anything looks critical10:16
rosmaitabecause we have abhishekk's multiple backends that def needs to get in10:16
rosmaitaand i have a new multihash patch up10:16
*** alexchadin has joined #openstack-glance10:17
abhishekkagree10:18
rosmaitathis one is a year old: https://bugs.launchpad.net/glance-store/+bug/170640510:19
openstackLaunchpad bug 1706405 in glance_store "ceph jobs failing to upload images in pike due to "AttributeError: 'NoneType' object has no attribute 'Rados'" on py35" [Undecided,Confirmed]10:19
jokke_is https://bugs.launchpad.net/glance-store/+bug/1732036 still valid bug?10:19
openstackLaunchpad bug 1732036 in glance_store "Glance cannot delete incomplete chunked upload to Swift backend if token expires" [Undecided,New]10:19
rosmaitait's a ceph thing, have you guys seen it?10:19
rosmaitajokke_ i don't know10:20
rosmaitamy note on it says its a multitenant store problem10:20
jokke_I thought the trust implementation fixed that ...10:20
jokke_it's just even that bug is from 201710:21
rosmaitame too, but dmitry says otherwise10:21
abhishekkrosmaita, I haven't got this error10:21
rosmaitayes, but november 201710:21
abhishekkI have done lots of testing for ceph backend and never encounter this issue10:21
rosmaitaabhishekk: maybe it's a packaging thing, then -- you mean https://bugs.launchpad.net/glance-store/+bug/1706405 ?10:22
openstackLaunchpad bug 1706405 in glance_store "ceph jobs failing to upload images in pike due to "AttributeError: 'NoneType' object has no attribute 'Rados'" on py35" [Undecided,Confirmed]10:22
rosmaitajokke_ i'm not sure how well the trusts stuff is tested in multitenant environment10:22
abhishekkrosmaita, yes10:22
rosmaitaabhishekk great, i will mark that as incomplete for now, then10:23
abhishekkrosmaita, ok10:23
jokke_indeed ... well I'd assume we would have got a lot more heat if those two were broken in general10:23
rosmaitajokke_ agreed, i think we can back-burner them both10:24
abhishekkagain, I haven't faced this issue as well10:25
abhishekkhttps://bugs.launchpad.net/glance-store/+bug/170640510:25
openstackLaunchpad bug 1706405 in glance_store "ceph jobs failing to upload images in pike due to "AttributeError: 'NoneType' object has no attribute 'Rados'" on py35" [Undecided,Incomplete]10:25
abhishekksorry wrong link10:25
abhishekkhttps://bugs.launchpad.net/glance-store/+bug/167328010:26
openstackLaunchpad bug 1673280 in glance_store "BackendException: Failed to add object to Swift. - While trying to upload image size of around 400 MB" [Undecided,New]10:26
rosmaitathat one is pretty old10:27
abhishekkyes10:28
rosmaitalooks like swift is failing on the first segment (or the error message is misleading, not sure about the '...' in it)10:29
rosmaitathat's weird though, because the large object size is 5120 MB, and this is a 400 MB image10:31
abhishekkyes10:32
rosmaitai think we ask for more information on this one10:32
abhishekkok, I have tried to upload around 2 gb image without any issue10:33
rosmaitaok, back to https://bugs.launchpad.net/glance-store/+bug/176420010:34
openstackLaunchpad bug 1764200 in glance_store "Glance Cinder backed images & multiple regions" [High,Triaged]10:34
rosmaitajokke_ you marked that one as high10:35
jokke_yes, I think that's pretty high importance issue if it's really broken10:36
jokke_but looks like you were able to confirm it10:37
rosmaitajokke_ maybe shoot tomoki an email ?10:37
rosmaitano, i only marked it as triaged because you assigned it an importance!10:38
abhishekkgood idea10:38
jokke_I left the status intentionally unmarked as I did not have means to verify it ;)10:39
rosmaitajokke_ can you shoot tomoki an email?10:39
rosmaitahe would be able to confirm right away, and would know if the proposed fix makes sense10:39
jokke_yeah10:40
jokke_will do10:40
rosmaitaok, cool10:40
*** mosulica has quit IRC10:41
rosmaitaalso, should we remove Glance from that bug?10:41
abhishekkyes10:43
rosmaitaok, i removed glance, marked it back to incomplete, and left a note that if confirmed, we want to get it into 0.25.010:43
abhishekkok10:44
rosmaitajokke_ should i just go ahead and target it for 0.25.0 ?10:44
*** mosulica has joined #openstack-glance10:45
jokke_yeah, feel free10:47
rosmaitadone10:47
rosmaitaok, that's all for now, bug-wise10:51
rosmaitathanks! but stick around, i have a question10:51
rosmaita#endmeeting10:51
*** openstack changes topic to "OpenStack Glance | priorities: http://lists.openstack.org/pipermail/openstack-dev/2018-March/128739.html | logs at http://eavesdrop.openstack.org/irclogs/%23openstack-glance/"10:51
openstackMeeting ended Mon Jul  9 10:51:32 2018 UTC.  Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4)10:51
openstackMinutes:        http://eavesdrop.openstack.org/meetings/glance_bs/2018/glance_bs.2018-07-09-10.01.html10:51
openstackMinutes (text): http://eavesdrop.openstack.org/meetings/glance_bs/2018/glance_bs.2018-07-09-10.01.txt10:51
openstackLog:            http://eavesdrop.openstack.org/meetings/glance_bs/2018/glance_bs.2018-07-09-10.01.log.html10:51
rosmaitai put up a new patch for the multihash stuff: https://review.openstack.org/#/c/528790/310:52
rosmaitamy question is how i handled the config option in backend.py10:52
rosmaitait's really a glance thing, needs to be defined in glance so that the hash algorithm metadata is populated correctly10:53
*** btully has joined #openstack-glance10:53
rosmaitaso i look for it, but fall back to sha512 if it's not available10:53
rosmaitathat way other glance_store consumers don't need to worry about how to configure it10:54
*** mosulica has quit IRC10:54
rosmaitabut i don't know if that's a good idea10:55
rosmaitaalso, the object that computes the hash is named 'os_hash_value' (which is what the metadata for it will be named in glance)10:56
rosmaitascott did that because the current code refers to 'checksum'10:56
jokke_I'm actually more worried about the fect that it's backwards incompatible change on that store_add_to_backend and so breaks the store api for any consumer who is not prepared10:56
rosmaitabut they are both misleading, because they are not the actual values10:56
rosmaitayes, it is very backward-incompatible10:56
rosmaitaglare for instance will not want to move to 0.25.010:57
abhishekkagree with jokke_10:57
rosmaitaso are you thinking add a new call, store_add_to_backend_with_multihash?10:57
*** btully has quit IRC10:58
abhishekkor should we introduce a new config option and deprecate it later?10:58
jokke_I think that's pretty much our only option if we don't want to break possible other consumers and go to 1.0.0 this cycle10:58
jokke_abhishekk: has good point ... instead of defaulting to sha512 we could not return the multihash at all if it's not configured/provided10:59
abhishekkeven if we introduce new call we need this new config option to decide which api needs to be called10:59
abhishekkmakes more sense11:00
jokke_this obviously needs more logic on consumer end when the multihash is enabled as the consumer needs to know to expect different output11:01
rosmaitayeah, so that's why i am thinking new call11:01
rosmaitaif you make the old call, you get 411:02
rosmaitanew call gets 511:02
jokke_but at least it would not break unexpectedly11:02
rosmaitai don't like hiding it in a config option11:02
rosmaitajust to be clear, though, since the drivers are all in _drivers, i can just modify their add methods without worrying, right?11:03
abhishekkyes11:04
rosmaitathat's a relief :)11:05
jokke_well ...11:05
jokke_will be shooting ourselves to the foot with that11:05
rosmaitawhy?11:06
abhishekki don't think so11:06
rosmaitajust for future reference, instead of returning tuples, multi-return functions should return a single dict11:06
rosmaitathen the consumer looks in there for what they want11:06
jokke_hmm-m I might and hope to be wrong, but the tasks and import has still that creative invocation of file store in there11:07
rosmaitai am hoping that you use store-add-to-backend!11:07
jokke_I can't remember out of my head as I just copied what was done in the same thing happening in the old tasks api task11:08
abhishekkjokke_, is right we are calling directly add method on file store :(11:08
jokke_I thought that might have been the case11:09
rosmaitaok, well we can handle that on the glance side11:10
rosmaitaglance will have the config option, will be able to pass in the hash_algo11:10
rosmaitaalthough now i see what you mean11:10
rosmaitait will immediately break glance11:11
jokke_yeah, so the problem will be setting the upper and lower constrains11:11
jokke_we need to make sure that Rocky >= 0.25.0 and before Rocky < 0.25.011:12
jokke_which is really not a great thing11:12
rosmaitahere is the filesystem add signature:11:12
rosmaita def add(self, image_id, image_file, image_size, hashing_algo, context=None,11:12
rosmaita            verifier=None):11:12
rosmaitawhy don't i make hashing_algo=None, and then check in the method whether to use it11:13
abhishekkcan we make it kw argument?11:13
rosmaitaif present, return 5 tuple11:13
rosmaitaif absent, return 4 tuple11:13
rosmaitawhich really sucks11:13
jokke_that will work but indeed sucks horribly11:13
jokke_but I think it's the only way getting away with this for now11:14
jokke_whoever though returning tuples was great idea11:14
jokke_...11:14
jokke_;)11:15
rosmaitamaybe in 2.0.0 we switch to returning dicts11:15
rosmaita:)11:15
abhishekk:D11:15
jokke_utf-8 encoded strings with json payload :P11:16
jokke_"do what ever you want with that, sucker!"11:17
abhishekkHaha11:17
rosmaitaok, so looks like i need a new patch.  so to be clear:11:18
abhishekkI need to rush back to home, kindly review store patches I will be back online after 3 hours to assist with doubts11:18
jokke_abhishekk: before you go11:18
rosmaita1 - introduce new store_add_to_backend_2018() that returns multihash11:18
jokke_could you link me again that etherpad where you had the manual test process streamlined for multi back-end?11:19
rosmaita2 - old store_Add_to_Backend() stays the same11:19
abhishekkjokke_, https://etherpad.openstack.org/p/multi-store-scenarios11:19
jokke_ty11:19
jokke_abhishekk: safe commute11:19
abhishekkjokke_, ty11:19
rosmaita3 - modify each store.add() so that it returns a 4-tuple as it does now if no hash_algo is specified, otherwise, it returns a 5 tuple including the multihash11:19
rosmaitaabhishekk : safe travels!11:19
abhishekkrosmaita, yes, ty11:20
rosmaita4 - there is no #411:20
abhishekk:P11:20
*** abhishekk has quit IRC11:20
jokke_rosmaita: maybe instead of rewriting all the individual stores with that dance, you might want to consider passing None and write small wrapper?11:21
jokke_python wrappers are pretty powerful and it would be easier to deal with now and when we finally are able to/want to rip the 4 - 5 return values dance off from the code11:23
rosmaitaso i would write a _add() for each store that does everything (basically what i have on the current patch), and add a new add() that returns 4 if hash_algo is None, 5 if hash_algo is not None ?11:25
jokke_no11:27
rosmaitayou mean use an actual wrapper decorator11:27
jokke_i mean writing actual pythong decorator that checks if the hashing_algo is None, calls the store.add with hashing_algo="md5" and strips the multihash out of that returned tuple11:28
jokke_then we could just default the hashing_algo to None in the add_to_backend and have fully backwards compatible glance_store that we can rip out when we bump the major11:29
rosmaitayeah, that would also solve the config problem11:31
rosmaitaglance would just make the call with the hashing algo it wants used11:32
jokke_yeap11:32
jokke_which would also mean that who ever wants to consume glance_store would not need to have that very specific config option in their DEFAULT config segment as the lib is expecting that somewhere it does not provide11:33
jokke_or do similar crap as we're doing in the tasks code11:33
jokke_in perfect world we would have enough man power to rip the oslo_config dependency totally out of glance_store and have what ever is consuming it just providing it all the needed info and configuring itself just as they want11:35
jokke_but as of now, we at least can make it bit easier for ourselves and the consumers. Even it's not great solution I think in this case it would be the best and definitely easiest to maintain for the time we need to11:36
rosmaitaok, this makes sense11:37
rosmaitai have not worked much with decorators, but will give it a shot11:37
rosmaitabut i like eliminating the config worry in the store and eliminating the backward-compat problem11:37
jokke_they are pretty easy, look the python official doc example for them and this is going to be really simple one11:38
jokke_feel free to poke me if you need help with that11:38
rosmaitaok, will do!11:38
*** itlinux has quit IRC11:39
jokke_The thing I do hate about the python decorators is that they hide stuff like this from the who ever is reading the code (as it's just something like @utils.fix_backwards_compatibility_because_we_fucked_up on top of the func delcaration) but on the same time it makes this kind of job really easy and clean when it's desperately needed11:40
*** alexchadin has quit IRC11:42
jokke_and when you don't need it anymore you just remove the @ lines from the functions you were decorating and reove the decorator and you're done11:42
jokke_instead of doing it individually on every function and risking typos etc.11:42
rosmaitayeah, the centralization makes it very attractive11:46
rosmaitai'll work on mocking something up to make sure i have the basic idea right and will ping you later11:47
jokke_sure11:47
*** pdeore has quit IRC11:58
*** amoralej is now known as amoralej|lunch12:03
*** csatari has joined #openstack-glance12:04
*** MattMan has quit IRC12:04
*** MattMan has joined #openstack-glance12:04
*** d0ugal has quit IRC12:06
*** alexchadin has joined #openstack-glance12:08
*** d0ugal has joined #openstack-glance12:08
*** jistr is now known as jistr|mtg12:12
*** alexchadin has quit IRC12:14
*** alexchadin has joined #openstack-glance12:14
*** alexchadin has quit IRC12:14
*** alexchadin has joined #openstack-glance12:15
*** alexchadin has quit IRC12:15
*** alexchadin has joined #openstack-glance12:16
*** alexchadin has quit IRC12:16
*** edmondsw has joined #openstack-glance12:24
*** alexchadin has joined #openstack-glance12:28
*** edmondsw has quit IRC12:29
*** edmondsw has joined #openstack-glance12:31
*** edmondsw has quit IRC12:35
*** jdillaman has joined #openstack-glance12:35
*** edmondsw has joined #openstack-glance12:37
*** btully has joined #openstack-glance12:42
*** edmondsw has quit IRC12:42
*** jmlowe has quit IRC12:45
*** edmondsw has joined #openstack-glance12:45
*** btully has quit IRC12:46
*** edmondsw has quit IRC12:49
*** edmondsw has joined #openstack-glance12:51
openstackgerritNguyen Hai proposed openstack/glance master: replace cmp with total_ordering decorator  https://review.openstack.org/57302712:52
*** edmondsw has quit IRC12:53
*** edmondsw has joined #openstack-glance12:53
*** mvk has quit IRC13:03
*** abhishekk{zzz} has joined #openstack-glance13:03
*** abhishekk{zzz} is now known as abhishekk13:04
*** amoralej|lunch is now known as amoralej13:11
*** jistr|mtg is now known as jistr13:14
*** gvrangan has quit IRC13:29
*** jmlowe has joined #openstack-glance13:34
*** aniketh has quit IRC13:36
*** jistr is now known as jistr|mtg13:36
*** lbragstad has joined #openstack-glance13:37
*** alexchad_ has joined #openstack-glance14:01
*** alexchadin has quit IRC14:02
*** Luzi has quit IRC14:05
*** jistr|mtg is now known as jistr14:05
*** links has quit IRC14:18
*** mvk_ has joined #openstack-glance14:20
*** tshefi has quit IRC14:35
*** bkopilov has quit IRC14:36
*** abhishekk has quit IRC14:56
*** alexchadin has joined #openstack-glance15:02
*** alexchad_ has quit IRC15:03
*** peereb has quit IRC15:03
*** abhishekk has joined #openstack-glance15:14
openstackgerritErno Kuvaja proposed openstack/glance master: Remove Images API v1 entry points  https://review.openstack.org/53250315:18
*** gyee has joined #openstack-glance15:35
*** alexchadin has quit IRC15:45
openstackgerritTomoki Sekiyama proposed openstack/glance_store master: specify region on creating cinderclient  https://review.openstack.org/58106915:47
*** aniketh has joined #openstack-glance16:14
*** btully has joined #openstack-glance16:20
*** btully has quit IRC16:24
*** hoonetorg has quit IRC16:32
*** mvk_ has quit IRC16:33
*** abhishekk has quit IRC16:34
*** hoonetorg has joined #openstack-glance16:34
*** abhishekk has joined #openstack-glance16:48
*** imacdonn has joined #openstack-glance17:03
*** tesseract has quit IRC17:15
openstackgerritMerged openstack/glance master: replace cmp with total_ordering decorator  https://review.openstack.org/57302717:27
*** amoralej is now known as amoralej|off17:49
*** vishakha has quit IRC18:18
*** vishakha has joined #openstack-glance18:32
*** bkopilov has joined #openstack-glance18:56
*** abhishekk has quit IRC19:20
*** mvk_ has joined #openstack-glance20:02
*** jmlowe has quit IRC20:20
*** btully has joined #openstack-glance21:46
*** btully has quit IRC21:50
*** rcernin has joined #openstack-glance22:20
*** threestrands_ has joined #openstack-glance22:20
*** threestrands_ has quit IRC22:20
*** threestrands_ has joined #openstack-glance22:20
*** jappleii__ has joined #openstack-glance22:23
*** jappleii__ has quit IRC22:24
*** jappleii__ has joined #openstack-glance22:25
*** aniketh has quit IRC22:25
*** threestrands_ has quit IRC22:26
*** rybridges has quit IRC22:36
*** dpawlik_ has joined #openstack-glance23:22
*** bhagyashri_s has joined #openstack-glance23:22
*** dpawlik has quit IRC23:24
*** gyee has quit IRC23:25
*** bhagyashris has quit IRC23:25
*** edmondsw has quit IRC23:26
*** gyee has joined #openstack-glance23:28

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!