Friday, 2018-02-16

*** AlexeyAbashkin has joined #openstack-glance00:13
*** AlexeyAbashkin has quit IRC00:18
openstackgerritMerged openstack/glance master: Update admin docs for web-download import method  https://review.openstack.org/54459600:28
*** gyee has quit IRC00:41
*** AlexeyAbashkin has joined #openstack-glance01:13
*** AlexeyAbashkin has quit IRC01:18
openstackgerritBrian Rosmaita proposed openstack/glance master: Revise interoperable image import documentation  https://review.openstack.org/54518801:59
*** harlowja_ has quit IRC03:23
*** abhishekk has joined #openstack-glance03:39
abhishekkrosmaita, good evening04:02
*** pdeore has joined #openstack-glance04:02
*** btully has joined #openstack-glance04:02
*** btully has quit IRC04:07
rosmaitaabhishekk hello04:07
rosmaitaabhishekk can you look at https://review.openstack.org/#/c/545179/ ?04:07
rosmaitalast change to get into rc-204:07
abhishekkrosmaita, yes, was looking to that only04:07
rosmaitaty04:07
abhishekkbut I can only put +1 their04:08
rosmaitai forgot!04:08
*** mdnadeem has joined #openstack-glance04:08
abhishekkNeed to wait for jokke_ or sean or flavio for this :(04:09
*** udesale has joined #openstack-glance04:09
abhishekkrosmaita, should I go ahead and make changes for postgresql (with reference to what we discussed yesterday)04:10
rosmaitaabhishekk sure, you know what my concern is, mainly, being able to migrate an existing postgresql database04:11
abhishekkrosmaita, yes understood, lets see whether with this it will work or not04:11
rosmaitasounds great, thanks for sticking with this04:11
abhishekkrosmaita, one thing to point out is we have migration for only visibility things right?04:12
rosmaitayes, i think that's been the only database table change in a while04:12
rosmaitawe will have another in rocky for the multihash04:13
abhishekkif that is so then under sqlalchemy/migration_repo/versions/ script 45 takes care of that04:13
abhishekkBut we need to make provision for future as well so lets see whether this approach works or not04:14
rosmaitai didn't realize we still had those scripts hanging around04:14
rosmaitaabhishekk go ahead and +1 that cherry-pick04:18
abhishekkAgain I guess we will face one issue with db_sync and offline is as we are calling internally EMC and suppose only contract sript needs to run and for postgresql if someone run db_sync then it will exit from the expand function with message No Expansion needed04:18
rosmaitayeah04:18
abhishekklets see, I will refactor that logic as well04:19
abhishekkrosmaita, Do we have rc2 release patch ready? I will ping jokke_ as soon as he is available04:20
rosmaitayes, it is https://review.openstack.org/#/c/545191/04:21
rosmaitai think tony is going to +A the doc cherry-pick04:21
abhishekkgreat04:21
rosmaitaactually, don't need to ping jokke_ , only release team can +2 it04:22
abhishekkyes, i thought if it is not ready then i should ping him04:22
abhishekkrosmaita, its late at your end as well, have a good evening and rest04:23
rosmaitathanks ... hope you are feeling better?04:24
abhishekkrosmaita, lot better now04:26
rosmaitaabhishekk great!04:27
ShilpaDAbhishek: any help needed, do let me know04:27
rosmaitaabhishekk are you going to be around for a while?04:27
abhishekkrosmaita, yes04:28
abhishekkShilpaD, yes sure, I will need help in testing :D04:28
rosmaitado me a favor: take a look at https://review.openstack.org/#/c/545191/ and see if you have the ability to -1 workflow it04:28
ShilpaDAbhishek: so are u removing validate engine check or you are adding postgraseSQL there?04:29
abhishekkrosmaita, no :(04:29
rosmaitaok, it was just a thought ... thanks for looking04:29
abhishekkShilpaD, removing validate_engine check04:30
abhishekkrosmaita, sorry for that :(04:30
rosmaitano worries04:30
abhishekkShilpaD, if we add postgresql their then it will misinterpret that we supports online migration for postgresql as well04:30
ShilpaDAbhishek: ok, so do we need to document else where that for triggers there has to be engine check at expand and contract scripts?04:31
ShilpaDAbhishek, ok, agree04:31
abhishekkShilpaD, yes, we can add them as a warning in the rolling_upgrades document04:31
ShilpaDthat will be great04:32
abhishekkShilpaD, I will let you know as soon as patch is up so that you can help me with the testing04:32
ShilpaDAbhsihek, sure04:32
abhishekkShilpaD, thank you for your efforts on this04:32
ShilpaDAbhishek, kindly review https://review.openstack.org/#/c/540736/5, whenever you will get time04:32
ShilpaDAlways welcome04:32
abhishekkShilpaD, sure04:33
ShilpaDthat helps me to understand the DB migration more in details04:33
abhishekkrosmaita, tonyb has approved the patch, so just little time to remove workflow -104:33
rosmaitayes, we'll see how fast the gate is04:34
tonybt-30mins04:34
rosmaitanot bad04:34
rosmaitathanks tonyb04:34
tonybrosmaita: If you'd pinged me *before* I +W'd the noce queue you'd be done by now ;P04:35
tonybthat'll learn'ya04:35
tonyb;P04:35
tonyb*nova*04:35
rosmaita:)04:36
rosmaitatonyb will you be in Dublin?04:36
tonybrosmaita: I will be.  You?04:37
rosmaitayes ... i owe you a beverage04:37
tonybrosmaita: Solid plan!04:37
abhishekk:D, attend retrospective04:38
rosmaita:D04:39
*** ykarel has joined #openstack-glance04:44
*** harlowja has joined #openstack-glance04:46
*** dalgaaf has quit IRC04:55
*** dalgaaf has joined #openstack-glance04:56
*** harlowja has quit IRC04:59
tonybt-4mins .... I'm getting excited!05:01
*** rmcall has joined #openstack-glance05:02
tonyb:(05:12
*** mdbooth has quit IRC05:13
*** harlowja has joined #openstack-glance05:19
abhishekkfinally merged05:20
rosmaitayep, the release patch is in the check queue now05:20
abhishekkgreat05:20
*** harlowja has quit IRC05:27
abhishekkso rc2 is approved as well \0/05:35
rosmaita:)05:38
rosmaitai'm outta here ... have a good day!05:39
*** rosmaita has quit IRC05:39
*** hoonetorg has quit IRC05:40
*** hoonetorg has joined #openstack-glance05:53
openstackgerritAbhishek Kekane proposed openstack/glance master: Migration support for postgresql  https://review.openstack.org/54521106:17
abhishekkShilpaD, hi ^^06:18
abhishekkwith this patch, I am able to see in the logs "migrated 0 rows"06:19
abhishekkwhich means it is now executing migration scripts06:19
*** threestrands has quit IRC06:20
*** openstackstatus has quit IRC06:27
*** openstack has joined #openstack-glance06:28
*** ChanServ sets mode: +o openstack06:28
*** openstackstatus has joined #openstack-glance06:28
*** ChanServ sets mode: +v openstackstatus06:28
ShilpaDabhishek: Hi will test https://review.openstack.org/545211 and will share the test results06:31
abhishekkShilpaD, thank you06:31
*** pdeore has quit IRC06:54
ShilpaDabhishekk: hi06:55
abhishekkShilpaD, hi06:56
ShilpaDjust need to discuss point related to triggers06:57
abhishekkok06:57
ShilpaDtriggers are to sync data in column if altered, right06:57
abhishekkthat will be for online use only06:58
abhishekkmeans online upgrades only06:58
ShilpaDyes, that got it, but now offline, if we have column altered, say name, then do we need to retain old data in new column as well, right06:59
abhishekkso trigger doesn't do that part06:59
ShilpaDok, what triggers here are menat for06:59
*** pdeore has joined #openstack-glance06:59
abhishekkthat logic you need to right in expand script only06:59
ShilpaDplease help me to understand06:59
abhishekksuppose in images table you are having is_public column and now you are changing it to visibility07:00
abhishekkyou are having 2 glance nodes and 1 is updated to use visibility and one is still using is_public07:01
abhishekkso if request goes to node where is_public is used then using trigger data will be inserted to visibility as well and vice a versa07:01
ShilpaDwhat @ the entries they are already there in is_public? We need that also in visibility, right07:02
openstackgerritOpenStack Proposal Bot proposed openstack/glance master: Imported Translations from Zanata  https://review.openstack.org/54521807:03
abhishekkYes so those will be copied to visibility column in the same script where you are adding new visibilty column07:03
ShilpaDSo its part of expand07:04
ShilpaD?07:04
abhishekkyes07:05
abhishekkit should be part of expand07:05
ShilpaDbut in ocata, is it taking care by trigger?07:05
abhishekkFor ocata actually it uses 045 script from migrations repo07:06
abhishekkTriggers are not migrating existing values to new column07:07
abhishekkTriggers executes only after certain actions, for example before/after insert,update or delete only07:08
abhishekkFor ocata actually existing values are migrated using https://github.com/openstack/glance/blob/master/glance/db/sqlalchemy/alembic_migrations/data_migrations/ocata_migrate01_community_images.py07:10
abhishekkSo the part of copying existing values to new column is job of migration scripts07:11
ShilpaDunderstood07:13
ShilpaDso in case of ocata 045 and migrate both doing same jobs?07:14
abhishekkIn EMC now, expand script should contains additive operations like add new column, table etc. migrate script should contains migrating data from old column to new column and contract script should contains droping of old column or table07:14
ShilpaD going forward no need to have files at glance/db/sqlalchemy/migrate_repo/versions?07:15
abhishekkShilpaD, yes, so as your earlier discussion with rosmaita we should get rid of migrate_repo/versions07:15
abhishekkin rocky I suppose07:15
ShilpaDok, thnak you, if any doubt further, will ping you07:16
abhishekkyup, I will be back shortly from lunch07:17
ShilpaDokay, me too07:17
*** threestrands has joined #openstack-glance07:22
*** threestrands has quit IRC07:22
*** threestrands has joined #openstack-glance07:23
*** threestrands has quit IRC07:23
*** threestrands has joined #openstack-glance07:23
*** AlexeyAbashkin has joined #openstack-glance07:26
*** threestrands has quit IRC07:34
*** btully has joined #openstack-glance07:40
*** rcernin has quit IRC07:41
*** btully has quit IRC07:44
*** dtantsur|afk is now known as dtantsur07:46
*** MattMan has quit IRC08:02
*** MattMan has joined #openstack-glance08:02
*** aniketh has joined #openstack-glance08:08
*** alexchadin has joined #openstack-glance08:13
*** alexchadin has quit IRC08:24
*** alexchadin has joined #openstack-glance08:25
*** tesseract has joined #openstack-glance08:27
*** e0ne has joined #openstack-glance08:35
openstackgerritAbhishek Kekane proposed openstack/glance master: Remove use of mox/mox3  https://review.openstack.org/54523908:47
*** e0ne has quit IRC08:54
*** belmoreira has joined #openstack-glance09:11
*** pcaruana has joined #openstack-glance09:11
*** rmcall has quit IRC09:14
*** rmcall has joined #openstack-glance09:15
*** rmcall has quit IRC09:23
*** stephenfin is now known as finucannot09:35
*** links has joined #openstack-glance09:47
*** links has quit IRC09:49
*** links has joined #openstack-glance09:58
*** abhishekk has quit IRC09:58
*** alexchadin has quit IRC10:01
*** udesale_ has joined #openstack-glance10:07
*** udesale has quit IRC10:10
*** links has quit IRC10:12
*** udesale__ has joined #openstack-glance10:16
*** openstackgerrit has quit IRC10:18
*** udesale_ has quit IRC10:19
*** pdeore_ has joined #openstack-glance10:19
*** pdeore has quit IRC10:22
*** dosaboy has quit IRC10:33
*** e0ne has joined #openstack-glance10:34
*** dosaboy has joined #openstack-glance10:38
*** aniketh has quit IRC10:47
*** alexchadin has joined #openstack-glance10:54
*** alexchadin has quit IRC11:10
*** e0ne has quit IRC11:12
*** e0ne has joined #openstack-glance11:13
*** alexchadin has joined #openstack-glance11:22
*** belmoreira has quit IRC11:28
*** udesale_ has joined #openstack-glance11:29
*** pbourke has quit IRC11:32
*** udesale__ has quit IRC11:32
*** pbourke has joined #openstack-glance11:34
*** udesale_ has quit IRC11:34
*** AlexeyAbashkin has quit IRC11:37
*** pdeore_ has quit IRC11:38
*** AlexeyAbashkin has joined #openstack-glance11:40
*** alexchadin has quit IRC11:41
*** alexchadin has joined #openstack-glance11:42
*** links has joined #openstack-glance12:03
*** udesale has joined #openstack-glance12:41
*** rosmaita has joined #openstack-glance12:42
*** belmoreira has joined #openstack-glance12:43
rosmaitabelmoreira are you still interested in the "hidden" images spec?12:52
belmoreirarosmaita I'm. My fault that I didn't update the spec.12:53
belmoreirais it open for rocky?12:53
rosmaitayes, afaik ... if you can update before the PTG, that would be good12:54
rosmaitapriorities for Rocky will mostly be decided in Dublin, week of Feb 2612:54
belmoreirarosmaita I'm sorry for the delay... This is in my todo list for a long time12:54
belmoreirarosmaita there is any other work for quotas?12:55
rosmaitano12:55
rosmaitawell, what i mean is, there is no work on the glance side, no one has proposed anything12:56
rosmaitai'll add that to the PTG etherpad, though12:56
belmoreiracan I propose a spec for the PTG12:56
belmoreiraimplementing something like quotas will be a big effort and I envision that several people will need to help12:57
rosmaitathat would be great ... would be good to have it a bit early as Monday and Tuesday are cross-project days, we can talk with people to find out what exactly happened with the community quotas or limits idea12:57
rosmaitabelmoreira yes, that is true, we need to find someone who (a) really wants quotas, and (b) can put some developers on the project12:58
belmoreirarosmaita thanks again. I will update the specs12:59
rosmaitaappreciate it!12:59
rosmaitabelmoreira here is the ptg planning etherpad, i will put a session on there for each of hidden images and quotas, you might want to update the description to make sure we address what you are interested in13:01
rosmaitahttps://etherpad.openstack.org/p/glance-rocky-ptg-planning13:01
belmoreirathanks13:04
*** nicolasbock has joined #openstack-glance13:10
*** nicolasbock has quit IRC13:10
*** r-daneel has joined #openstack-glance13:14
*** openstackgerrit has joined #openstack-glance13:34
openstackgerritMerged openstack/glance master: Imported Translations from Zanata  https://review.openstack.org/54521813:34
*** ChanServ changes topic to "OpenStack Glance"13:37
*** ChanServ changes topic to "OpenStack Glance | priorities: http://lists.openstack.org/pipermail/openstack-dev/2018-February/127472.html"13:37
*** ChanServ changes topic to "OpenStack Glance | priorities: http://lists.openstack.org/pipermail/openstack-dev/2018-February/127472.html | logs at http://eavesdrop.openstack.org/irclogs/%23openstack-glance/"13:37
*** udesale has quit IRC14:08
*** udesale_ has joined #openstack-glance14:08
*** ykarel has quit IRC14:13
*** Supun has joined #openstack-glance14:17
*** konan has joined #openstack-glance14:18
*** Supun has quit IRC14:22
*** Supun has joined #openstack-glance14:23
*** rmcall has joined #openstack-glance14:24
*** mdnadeem has quit IRC14:25
jokke_rosmaita: morn14:27
rosmaitahello14:32
*** Supun has quit IRC14:34
jokke_sent you a link in pm14:35
*** alexchadin has quit IRC14:37
ShilpaDJokke_: hi, kindly review https://review.openstack.org/#/c/540736/5, whenever you will get time14:39
rosmaitaShilpaD we are aware of that patch, but holding off until the postgres situation is clearly understood14:44
rosmaitain case we have to revert anything before release14:44
ShilpaDrosmaita thanks for updating14:45
rosmaitaShilpaD np, and sorry that it's dragging out so log14:45
rosmaita*long14:45
ShilpaDno issues, i can understand14:45
ShilpaDFYI: For postgres, i have written test scripts, requesting Abhishek to review the same14:46
ShilpaDAbhishek: hi, to verify changes https://review.openstack.org/#/c/545211/, i have written test scripts http://paste.openstack.org/show/674262/ , Please verify are they correct from migration point of you.14:47
*** mosulica has joined #openstack-glance14:47
ShilpaDrosmaita: bye leaving now14:48
rosmaitaShilpaD have a good weekend!14:48
rosmaitaShilpaD thanks for the links above, they will be helpful14:49
rosmaitaand thanks for your work on this14:49
belmoreirarosmaita we discussed to have the "hide_image" option as a property. But to clarify something in image_properties tables or a new column in images tables14:49
ShilpaDrosmaita: please review once them from migration point of view.14:49
ShilpaDbefore use14:50
ShilpaDi have written from my understanding point of view14:50
rosmaitabelmoreira propose it for the images table because it will have to be indexed and be heavily used in constructing the image list response14:50
belmoreirarosmaita agreed14:50
rosmaitaif someone disagrees, they can explain on the patch14:50
rosmaitacool14:50
openstackgerritBrian Rosmaita proposed openstack/glance master: Update Queens info about Glance and uWSGI  https://review.openstack.org/54535214:51
rosmaitajokke_ ^^14:51
*** jistr is now known as jistr|mtg14:52
ShilpaDrosmaita bye, happy weekend14:52
*** ShilpaD has quit IRC14:53
*** btully has joined #openstack-glance14:55
*** mdbooth has joined #openstack-glance14:57
*** r-daneel has quit IRC14:58
*** btully has quit IRC15:00
*** pooja_jadhav has quit IRC15:00
*** ykarel has joined #openstack-glance15:01
*** jistr|mtg is now known as jistr15:15
konanShilpaD, will check those scripts soon15:16
mtreinishrosmaita: on 545352 I left some comments you might want to fix before it merges...15:25
rosmaitaok15:27
rosmaitamtreinish don'15:29
rosmaitat see anything about the scale, which clouds do mnaser and j mccrory represent?15:30
mnaserhi, vexxhost :)15:30
rosmaitahi mnaser15:30
* mnaser reads buffer15:30
rosmaitajust curious about the size of your cloud (question about running the chunked transfer encoding patch at scale)15:31
mtreinishrosmaita: jmccrory is at walmart iirc15:32
mnaserThat’s not an easy question to answer publicly but I can say we spin up 1000s of instances per day, with many daily image uploads both from OpenStack infra and other customers15:32
mnaserSo we’ve had an extensive amount of uploaded images with that patch under wsgi15:33
rosmaitamnaser ok, thanks15:33
mnaserThat’s the only patch we maintain on top of stable/pike (and hoping to avoid doing that)15:33
*** r-daneel has joined #openstack-glance15:40
*** e0ne_ has joined #openstack-glance15:43
*** e0ne has quit IRC15:43
*** e0ne has joined #openstack-glance15:45
*** e0ne_ has quit IRC15:47
*** r-daneel has quit IRC15:55
*** pcaruana has quit IRC15:57
*** r-daneel has joined #openstack-glance16:03
*** finucannot is now known as stephenfin16:10
*** ykarel_ has joined #openstack-glance16:10
*** mosulica has quit IRC16:11
*** ykarel has quit IRC16:13
*** slunkad_ has joined #openstack-glance16:17
*** weshay has joined #openstack-glance16:20
*** markvoelker has quit IRC16:23
*** markvoelker_ has joined #openstack-glance16:27
openstackgerritMerged openstack/glance master: Update Queens info about Glance and uWSGI  https://review.openstack.org/54535216:32
*** AlexeyAbashkin has quit IRC16:33
*** udesale_ has quit IRC16:37
*** ykarel_ is now known as ykarel|away16:47
jokke_rosmaita: wanna backport that ^^ really quick before I go?16:50
rosmaitagood idea16:50
rosmaitahttps://review.openstack.org/#/c/545384/16:50
*** itlinux has joined #openstack-glance16:56
*** r-daneel has quit IRC17:02
*** e0ne has quit IRC17:06
*** arcolife has joined #openstack-glance17:12
*** links has quit IRC17:18
*** itlinux has quit IRC17:22
*** arcolife has quit IRC17:23
*** itlinux has joined #openstack-glance17:25
openstackgerritBelmiro Moreira proposed openstack/glance-specs master: Hide old images from default image-list  https://review.openstack.org/54539717:28
*** belmoreira has quit IRC17:29
*** Supun has joined #openstack-glance17:35
*** harlowja has joined #openstack-glance17:55
*** gyee has joined #openstack-glance18:00
*** r-daneel has joined #openstack-glance18:05
*** AlexeyAbashkin has joined #openstack-glance18:24
*** tesseract has quit IRC18:26
*** AlexeyAbashkin has quit IRC18:28
*** dtantsur is now known as dtantsur|afk18:29
*** btully has joined #openstack-glance18:32
*** btully has quit IRC18:36
*** r-daneel has quit IRC18:37
*** r-daneel has joined #openstack-glance18:38
*** harlowja has quit IRC18:44
*** harlowja has joined #openstack-glance18:48
*** weshay is now known as weshay|bbiab18:50
*** r-daneel has quit IRC18:54
*** konan has quit IRC18:57
*** ykarel|away has quit IRC18:58
*** r-daneel has joined #openstack-glance18:58
*** harlowja has quit IRC19:10
*** gyee has quit IRC19:16
*** Supun has quit IRC19:33
*** weshay|bbiab is now known as weshay19:50
*** harlowja has joined #openstack-glance19:50
*** r-daneel_ has joined #openstack-glance20:02
*** r-daneel has quit IRC20:05
*** r-daneel_ is now known as r-daneel20:05
*** markvoelker_ has quit IRC20:55
*** markvoelker has joined #openstack-glance20:56
*** r-daneel has quit IRC21:10
*** r-daneel has joined #openstack-glance21:48
*** edmondsw has quit IRC22:01
*** edmondsw has joined #openstack-glance22:01
*** edmondsw has quit IRC22:06
*** btully has joined #openstack-glance22:10
*** btully has quit IRC22:14
*** zzzeek has quit IRC22:38
*** kuzko has joined #openstack-glance22:40
*** zzzeek has joined #openstack-glance22:42
*** weshay is now known as weshay_PTO23:14

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!