| *** mvk has joined #openstack-glance | 00:02 | |
| *** hoonetorg has quit IRC | 00:10 | |
| *** AlexeyAbashkin has joined #openstack-glance | 00:11 | |
| *** AlexeyAbashkin has quit IRC | 00:15 | |
| *** edmondsw has joined #openstack-glance | 00:19 | |
| *** edmondsw has quit IRC | 00:23 | |
| *** takedakn has joined #openstack-glance | 00:28 | |
| *** hoonetorg has joined #openstack-glance | 00:30 | |
| *** edmondsw has joined #openstack-glance | 00:31 | |
| *** edmondsw has quit IRC | 00:36 | |
| *** edmondsw has joined #openstack-glance | 00:37 | |
| *** edmondsw has quit IRC | 00:41 | |
| *** edmondsw has joined #openstack-glance | 00:44 | |
| *** edmondsw has quit IRC | 00:45 | |
| *** edmondsw has joined #openstack-glance | 00:46 | |
| *** edmondsw has quit IRC | 00:50 | |
| *** zhurong has joined #openstack-glance | 01:05 | |
| *** hoonetorg has quit IRC | 01:17 | |
| *** hoonetorg has joined #openstack-glance | 01:21 | |
| *** btully has joined #openstack-glance | 01:23 | |
| *** btully has quit IRC | 01:27 | |
| *** dalgaaf has quit IRC | 01:40 | |
| *** dalgaaf has joined #openstack-glance | 01:40 | |
| *** Brin has joined #openstack-glance | 01:44 | |
| *** zhurong has quit IRC | 02:14 | |
| *** gcb has joined #openstack-glance | 02:15 | |
| *** zhurong has joined #openstack-glance | 03:08 | |
| *** harlowja has quit IRC | 03:21 | |
| openstackgerrit | Merged openstack/glance master: Skip one functional test https://review.openstack.org/536939 | 03:23 |
|---|---|---|
| *** zhurong_ has joined #openstack-glance | 03:27 | |
| openstackgerrit | Bhagyashri Shewale proposed openstack/glance master: Implementation of db check command https://review.openstack.org/455837 | 03:32 |
| openstackgerrit | Brian Rosmaita proposed openstack/glance master: Add functional test gates https://review.openstack.org/536630 | 03:33 |
| *** openstackgerrit has quit IRC | 03:33 | |
| *** abhishekk has joined #openstack-glance | 03:44 | |
| *** tshefi has joined #openstack-glance | 03:53 | |
| *** namnh has joined #openstack-glance | 03:57 | |
| *** udesale has joined #openstack-glance | 04:05 | |
| *** rosmaita has quit IRC | 04:06 | |
| *** links has joined #openstack-glance | 04:10 | |
| *** harlowja has joined #openstack-glance | 04:28 | |
| *** zhurong_ has quit IRC | 04:39 | |
| *** ratailor has joined #openstack-glance | 05:07 | |
| *** harlowja has quit IRC | 05:17 | |
| *** openstackgerrit has joined #openstack-glance | 05:30 | |
| openstackgerrit | Gao Fei proposed openstack/glance master: Replace curly quotes with straight quotes https://review.openstack.org/537229 | 05:30 |
| *** tshefi has quit IRC | 05:40 | |
| *** zhurong has quit IRC | 06:13 | |
| *** rcernin has quit IRC | 06:14 | |
| *** AlexeyAbashkin has joined #openstack-glance | 06:22 | |
| *** zhurong has joined #openstack-glance | 06:22 | |
| *** AlexeyAbashkin has quit IRC | 06:30 | |
| *** udesale has quit IRC | 06:47 | |
| *** udesale has joined #openstack-glance | 06:48 | |
| *** markvoelker has quit IRC | 06:52 | |
| *** markvoelker has joined #openstack-glance | 06:53 | |
| *** markvoelker has quit IRC | 06:57 | |
| *** threestrands_ has quit IRC | 07:02 | |
| *** hoonetorg has quit IRC | 07:17 | |
| openstackgerrit | Abhishek Kekane proposed openstack/glance master: Execute py35 functional tests under py35 environment https://review.openstack.org/536733 | 07:21 |
| *** jose-phi_ has quit IRC | 07:26 | |
| *** hoonetorg has joined #openstack-glance | 07:29 | |
| *** e0ne has joined #openstack-glance | 07:30 | |
| *** abhishekk is now known as abhishekk|away | 07:51 | |
| *** pcaruana has joined #openstack-glance | 07:55 | |
| *** e0ne has quit IRC | 07:56 | |
| *** AlexeyAbashkin has joined #openstack-glance | 08:04 | |
| *** mvk has quit IRC | 08:08 | |
| *** jose-phillips has joined #openstack-glance | 08:16 | |
| *** tesseract has joined #openstack-glance | 08:20 | |
| *** jose-phillips has quit IRC | 08:25 | |
| *** arcolife has joined #openstack-glance | 08:25 | |
| *** jose-phillips has joined #openstack-glance | 08:25 | |
| *** gcb has quit IRC | 08:26 | |
| *** gcb has joined #openstack-glance | 08:29 | |
| *** takedakn has quit IRC | 08:34 | |
| *** abhishekk|away is now known as abhishekk | 08:47 | |
| *** jose-phillips has quit IRC | 08:47 | |
| openstackgerrit | Shilpa Devharakar proposed openstack/glance master: Modify glance manage db sync to use EMC https://review.openstack.org/433934 | 08:49 |
| *** markvoelker has joined #openstack-glance | 08:54 | |
| *** zhurong has quit IRC | 08:55 | |
| *** takedakn has joined #openstack-glance | 09:00 | |
| *** zhurong has joined #openstack-glance | 09:25 | |
| *** markvoelker has quit IRC | 09:27 | |
| *** itlinux has joined #openstack-glance | 09:31 | |
| *** e0ne has joined #openstack-glance | 09:31 | |
| *** MattMan has quit IRC | 09:31 | |
| *** MattMan has joined #openstack-glance | 09:32 | |
| *** zhurong_ has joined #openstack-glance | 09:56 | |
| *** itlinux has quit IRC | 09:58 | |
| *** itlinux has joined #openstack-glance | 10:01 | |
| openstackgerrit | Bhagyashri Shewale proposed openstack/glance master: Implementation of db check command https://review.openstack.org/455837 | 10:04 |
| *** bkopilov has quit IRC | 10:05 | |
| *** bkopilov has joined #openstack-glance | 10:06 | |
| *** itlinux has quit IRC | 10:09 | |
| *** hoonetorg has quit IRC | 10:09 | |
| *** hoonetorg has joined #openstack-glance | 10:22 | |
| *** markvoelker has joined #openstack-glance | 10:25 | |
| *** btully has joined #openstack-glance | 10:36 | |
| *** abhishekk has quit IRC | 10:38 | |
| *** btully has quit IRC | 10:40 | |
| *** vladiskuz has joined #openstack-glance | 10:45 | |
| *** jistr is now known as jistr|mtg | 10:49 | |
| *** udesale has quit IRC | 10:56 | |
| *** markvoelker has quit IRC | 10:58 | |
| *** vkmc has quit IRC | 10:58 | |
| *** arcolife has quit IRC | 11:00 | |
| *** vkmc has joined #openstack-glance | 11:05 | |
| *** gcb has quit IRC | 11:17 | |
| openstackgerrit | Vladislav Kuzmin proposed openstack/glance master: Replace xml defusedxml https://review.openstack.org/537855 | 11:20 |
| *** gcb has joined #openstack-glance | 11:20 | |
| *** takedakn has quit IRC | 11:25 | |
| *** alexchadin has joined #openstack-glance | 11:31 | |
| *** namnh has quit IRC | 11:31 | |
| *** zhurong has quit IRC | 11:35 | |
| *** sapd_ has quit IRC | 11:45 | |
| *** zhurong has joined #openstack-glance | 11:54 | |
| *** markvoelker has joined #openstack-glance | 11:55 | |
| *** AlexeyAbashkin has quit IRC | 11:58 | |
| *** AlexeyAbashkin has joined #openstack-glance | 11:58 | |
| *** sapd_ has joined #openstack-glance | 11:58 | |
| *** tesseract has quit IRC | 12:24 | |
| *** markvoelker has quit IRC | 12:29 | |
| *** udesale has joined #openstack-glance | 12:34 | |
| *** alexchadin has quit IRC | 12:35 | |
| *** alexchadin has joined #openstack-glance | 12:36 | |
| *** Brin has quit IRC | 12:36 | |
| *** jistr|mtg is now known as jistr | 12:38 | |
| *** sjmc7 has joined #openstack-glance | 12:40 | |
| *** Supun has joined #openstack-glance | 12:43 | |
| *** Supun has quit IRC | 12:51 | |
| *** alexchadin has quit IRC | 12:52 | |
| *** alexchadin has joined #openstack-glance | 12:53 | |
| *** ratailor has quit IRC | 12:54 | |
| *** rosmaita has joined #openstack-glance | 12:56 | |
| *** Supun has joined #openstack-glance | 12:56 | |
| *** alexchadin has quit IRC | 13:00 | |
| *** alexchadin has joined #openstack-glance | 13:00 | |
| *** Supun has quit IRC | 13:01 | |
| *** Supun has joined #openstack-glance | 13:02 | |
| openstackgerrit | Haïkel Guémar proposed openstack/glance master: Fix pip install failure https://review.openstack.org/537453 | 13:03 |
| *** belmoreira has joined #openstack-glance | 13:04 | |
| *** Supun has quit IRC | 13:08 | |
| *** Supun has joined #openstack-glance | 13:09 | |
| kairat | rosmaita, jokke_ seems we need https://review.openstack.org/537855 to be merged before enabling import by default | 13:09 |
| kairat | otr at least reviewed | 13:09 |
| kairat | and then merged =) | 13:09 |
| rosmaita | hi kairat | 13:11 |
| rosmaita | i saw that this morning | 13:11 |
| kairat | JFYI | 13:11 |
| rosmaita | actually, i was very surprised to see the gerrit review (if you know what i mean) | 13:11 |
| rosmaita | appreciate the heads-up, though | 13:12 |
| *** Supun has quit IRC | 13:14 | |
| *** Supun has joined #openstack-glance | 13:15 | |
| *** zhurong has quit IRC | 13:16 | |
| *** alexchadin has quit IRC | 13:18 | |
| *** abhishekk has joined #openstack-glance | 13:24 | |
| *** markvoelker has joined #openstack-glance | 13:26 | |
| *** tesseract has joined #openstack-glance | 13:28 | |
| *** edmondsw_ has joined #openstack-glance | 13:30 | |
| *** tesseract has quit IRC | 13:42 | |
| *** cleong has joined #openstack-glance | 13:42 | |
| *** tesseract has joined #openstack-glance | 13:42 | |
| *** zhurong_ has quit IRC | 13:44 | |
| *** edmondsw_ is now known as edmondsw | 13:48 | |
| *** alexchadin has joined #openstack-glance | 13:49 | |
| *** alexchadin has quit IRC | 13:52 | |
| rosmaita | Courtesy meeting reminder on #openstack-meeting-4: ativelkov, cpallares, flaper87, flwang1, hemanthm, jokke_, kragniz, lakshmiS, mclaren, mfedosin, nikhil_k, Nikolay_St, Olena, pennerc, rosmaita, sigmavirus24, sabari, TravT, ajayaa, GB21, bpoulos, harshs, abhishekk, bunting, dshakhray, wxy, dhellmann, kairat, alex_bash, smcginnis, arcolife,zhangbailin | 13:58 |
| *** McClymontS has joined #openstack-glance | 13:58 | |
| *** markvoelker has quit IRC | 13:59 | |
| *** McClymon_ has joined #openstack-glance | 14:05 | |
| *** McClymontS has quit IRC | 14:07 | |
| *** jose-phillips has joined #openstack-glance | 14:09 | |
| *** tesseract has quit IRC | 14:17 | |
| *** tesseract has joined #openstack-glance | 14:18 | |
| -openstackstatus- NOTICE: We're currently experiencing issues with the logs.openstack.org server which will result in POST_FAILURE for jobs, please stand by and don't needlessly recheck jobs while we troubleshoot the problem. | 14:25 | |
| *** alexchadin has joined #openstack-glance | 14:25 | |
| *** Shilpa has quit IRC | 14:26 | |
| *** jose-phillips has quit IRC | 14:29 | |
| *** markvoelker has joined #openstack-glance | 14:34 | |
| *** McClymon_ has quit IRC | 14:36 | |
| *** McClymontS has joined #openstack-glance | 14:44 | |
| *** McClymontS has quit IRC | 14:47 | |
| *** rmcall has joined #openstack-glance | 14:49 | |
| jokke_ | oh gr9^^ | 14:55 |
| rosmaita | ok, Q-3 war planning about to commence | 14:55 |
| jokke_ | gr8 | 14:55 |
| abhishekk | o/ | 14:55 |
| rosmaita | i think that was worth a gr9 (1 more than gr8) | 14:56 |
| rosmaita | i am tempted to say a bad word, but find my vocabulary insufficient | 14:56 |
| jokke_ | there's plenty in Finnish :D | 14:57 |
| *** alexchadin has quit IRC | 14:57 | |
| jokke_ | but yeah, infra has something serious in their hands ... there's less than 300 changes in queues atm. and that's crawling | 14:57 |
| rosmaita | just when i thought this week couldn't get any worse | 14:57 |
| jokke_ | I don't want to be too negative/devils advocate but .... | 14:58 |
| rosmaita | i also forgot to mention that monty has a patch up to get more log info out of our failures | 14:58 |
| jokke_ | I think one of the problems is what we for example just did ... splitting the test runs to smaller and smaller pieces which will cause more parallel jobs ran by change | 14:59 |
| abhishekk | i saw that patch | 14:59 |
| jokke_ | yeah +2d it already looked gr8 | 14:59 |
| rosmaita | oh, ok | 14:59 |
| rosmaita | i had a stupid comment about using strip() but didn't feel like pursuing it | 14:59 |
| rosmaita | and since i couldn't get the failures locally, i couldn't see the log improvements | 15:00 |
| jokke_ | just drop one of the skips :D | 15:01 |
| jokke_ | but to the war plan | 15:02 |
| abhishekk | so what's the plan | 15:02 |
| abhishekk | wait is the first thing i guess | 15:02 |
| jokke_ | as said I do not feel comfortable cutting the milestone at this state of the gate | 15:02 |
| jokke_ | no matter how much it's deadline on the calendar | 15:02 |
| *** r-daneel has joined #openstack-glance | 15:02 | |
| rosmaita | abhishek, i just saw your https://review.openstack.org/#/c/536733/ | 15:03 |
| abhishekk | andreas suggested that we will require that patch | 15:03 |
| jokke_ | smcginnis: what was the original reson to recycle the envs? | 15:04 |
| *** belmoreira has quit IRC | 15:05 | |
| rosmaita | i think it was in the old tox.ini ? | 15:05 |
| jokke_ | abhishekk: any idea why that was reguired? Are we doing some stupid monkeypatching there? | 15:05 |
| jokke_ | rosmaita: IIRC no, it was introduced on smcginnis' split change ... might be wrong as well | 15:06 |
| abhishekk | jokke_, not sure, from the logs I have pointed out that py35 job is running under py27 | 15:06 |
| rosmaita | which def seems incorrect | 15:07 |
| *** udesale has quit IRC | 15:07 | |
| rosmaita | just a quick reminder that there are no functional tests running in-gate right now on this patch | 15:07 |
| *** udesale has joined #openstack-glance | 15:08 | |
| jokke_ | that could explain the odd failures rosmaita has seen in the py3 tests since | 15:08 |
| rosmaita | i sure hope so | 15:08 |
| *** pooja-jadhav has joined #openstack-glance | 15:08 | |
| rosmaita | because they make absolutely no sense | 15:08 |
| jokke_ | yeah, well the whole current gate situation makes no sense | 15:09 |
| jokke_ | which is why I don't like to release in middle of this | 15:09 |
| rosmaita | jokke_ want to +2A https://review.openstack.org/#/c/536733/2 ? | 15:09 |
| rosmaita | yeah, i agree | 15:09 |
| rosmaita | about not releasing | 15:09 |
| jokke_ | lets get these changes in we do know we need to fix some major issues first | 15:09 |
| rosmaita | the only gate that moves quickly is the release gate! | 15:10 |
| rosmaita | ok, so let's try: | 15:10 |
| abhishekk | rosmaita, I made sure after running py35 on new ubuntu it was failing with same errors as py17 and with my patch it was passed | 15:10 |
| *** pooja_jadhav has quit IRC | 15:10 | |
| rosmaita | abhishekk you are the greatest! | 15:11 |
| jokke_ | abhishekk: sounds great ... I hope you're our this weeks hero! | 15:11 |
| abhishekk | s/py17/py27 | 15:11 |
| rosmaita | abhishekk beverage of choice or desert of choice in dublin on me! | 15:11 |
| abhishekk | rosmaita, jokke_ thanks | 15:12 |
| rosmaita | abhishekk do i need to do anything to https://review.openstack.org/#/c/536630 | 15:12 |
| rosmaita | or does your patch handle the env issue? | 15:12 |
| rosmaita | oh yeah, yours does | 15:12 |
| abhishekk | rosmaita, my patch does | 15:13 |
| rosmaita | i forgot these arent the devstack func tests like for the client and store | 15:13 |
| rosmaita | abhishekk ++ | 15:13 |
| smcginnis | jokke_: Just to reuse idential venv's and it's done elsewhere. | 15:13 |
| rosmaita | +++ , even | 15:13 |
| smcginnis | abhishekk: The running under py27 piece was an original misconfiguration in the functional job. | 15:13 |
| abhishekk | rosmaita, not sure about that one py35 test failure as it was not failing in my environment | 15:14 |
| rosmaita | ok, so to be clear, what my https://review.openstack.org/#/c/536630/8 does is get the functional tests running in-gate on py35 only | 15:14 |
| rosmaita | we will not be running py27 func tests in-gate | 15:14 |
| rosmaita | so question: | 15:14 |
| rosmaita | assuming we get these 2 patches merged and working, how to we feel about cutting Q-3 ? | 15:15 |
| abhishekk | smcginnis, that doesn't make sense to me as it was failing in my local environment and when I removed envdir it worked | 15:15 |
| smcginnis | abhishekk: Using the updated test? Or just calling tox -e functional-py35? | 15:15 |
| abhishekk | smcginnis, using later one, tox -e functional-py35 | 15:16 |
| jokke_ | rosmaita: unless something magical happens and gate starts getting stuff in under 24 hour processing windows, Monday should be fine for cutting the release | 15:16 |
| smcginnis | abhishekk: That would be very odd. | 15:16 |
| abhishekk | jokke_, rosmaita : we still need to bother about one migration related failing test (skip is not working) | 15:17 |
| jokke_ | as usual, we do not release on Fridays unless absolutely necessary and if we get stable gate running during the weekend I would have peace of mind to release first thing at Mon | 15:17 |
| jokke_ | abhishekk: lets see what happens if that John L.'s and your patches finally merges .... we just might see some improvements there | 15:19 |
| abhishekk | just to update, tomorrow will be public holiday in India,but I will be online and can work from home as well | 15:20 |
| *** pcaruana has quit IRC | 15:20 | |
| jokke_ | abhishekk: don't feel obligated to do so, same time you're always welcome addition hanving online ;P | 15:21 |
| jokke_ | having | 15:22 |
| abhishekk | jokke_, will be indeed :) | 15:22 |
| *** abhishekk_ has joined #openstack-glance | 15:22 | |
| *** abhishekk has quit IRC | 15:23 | |
| *** abhishekk_ is now known as abhishekk | 15:23 | |
| jokke_ | smcginnis: do we need to alert someone else or is release team sufficiently informed that we won't be releasing Q-3 in time due to all this? | 15:24 |
| *** alexchadin has joined #openstack-glance | 15:25 | |
| *** itlinux has joined #openstack-glance | 15:27 | |
| sjmc7 | rosmaita: take a look at https://review.openstack.org/#/c/537863/1/neutron/common/eventlet_utils.py regarding your test failure | 15:30 |
| *** d0ugal has quit IRC | 15:31 | |
| jokke_ | sjmc7: thanks! I was just gonna link that change as I saw the discussion on infra! | 15:34 |
| jokke_ | That might be the key indeed | 15:34 |
| sjmc7 | yeah, i’d asked in there earlier but this looks like the best lead | 15:34 |
| jokke_ | sjmc7: so it wasn't only us 2 that got broken | 15:35 |
| sjmc7 | if it was eventlet it’ll be a lot of projects | 15:35 |
| jokke_ | yup | 15:35 |
| jokke_ | https://github.com/eventlet/eventlet/commit/b756447bab51046dfc6f1e0e299cc997ab343701 | 15:36 |
| rosmaita | was afk | 15:36 |
| jokke_ | from Ihar's comment on that neutron patch | 15:36 |
| rosmaita | that does sound like what we're seeing | 15:38 |
| sjmc7 | looks like that fixes it for us | 15:38 |
| smcginnis | jokke_: Got it, you're good on the release front. | 15:38 |
| sjmc7 | race to the release deadline begins! | 15:38 |
| jokke_ | smcginnis: thanks | 15:39 |
| rosmaita | so to be clear, release on monday? | 15:40 |
| *** d0ugal has joined #openstack-glance | 15:40 | |
| jokke_ | sjmc7: rosmaita abhishekk regarding that neutron change and that eventlet patch, it seems that eventlet is fixing that issue. should we wait that they release and it comes down to us or should we introduce that sleep as well | 15:41 |
| rosmaita | that was my next question | 15:41 |
| smcginnis | Release patch can be posted as soon as you are ready. Due to a lot of delays, we may decide to do some releases on Friday anyway. | 15:42 |
| smcginnis | But as soon as things are in good enough shape for q-3. | 15:42 |
| *** belmoreira has joined #openstack-glance | 15:42 | |
| sjmc7 | i’m putting the sleep in for now at least | 15:43 |
| sjmc7 | it shouldn’t do any harm even when they do fix it | 15:43 |
| jokke_ | sjmc7: I was thinking the same ... it's less intrusive than calling the get_hub outside of the monkeypatching code and in there again when the monkeypatching is done | 15:44 |
| rosmaita | yeah, i do not want to be calling get hub outside of eventlet | 15:44 |
| sjmc7 | yeah. the sleep bodge is easier to explain as a mystery with that version | 15:45 |
| jokke_ | while normally I don't think arbitary sleeps are bad idea fixing race conditions, in this case it's less bad thing knowing that the actual cause is being worked on | 15:45 |
| *** alexchadin has quit IRC | 15:45 | |
| rosmaita | the u-c on eventlet right now is 0.20.0 | 15:45 |
| jokke_ | I do think they are | 15:45 |
| rosmaita | so like 2 behind the fix | 15:45 |
| rosmaita | ok, so our situation now is complex enough that i will start an etherpad instead of typing it here | 15:47 |
| rosmaita | https://etherpad.openstack.org/p/glance-q3 | 15:48 |
| jokke_ | fuq! | 15:49 |
| jokke_ | we do not have anything consolidating the monkeypatching ... we call the eventlet.patcher.monkey_patch all over the place | 15:49 |
| rosmaita | yuck | 15:50 |
| sjmc7 | pick the first one! or all of them | 15:55 |
| rosmaita | looks like neutron just updated the patch to call eventlet.hubs.get_hub() right before eventlet.monkey_patch() | 15:56 |
| jokke_ | sjmc7, rosmaita: I think we need to do it in the test __init__ and in the commands ... the rest of the tests should be fine as the __init__ should be executed before anyways | 15:59 |
| sjmc7 | well, are you sure the server will run properly though with eventlet? | 15:59 |
| *** e0ne has quit IRC | 15:59 | |
| sjmc7 | in ours at least, it’s not the tests failing, it’s the API subprocess | 15:59 |
| rosmaita | i think sjmc7 is right | 16:00 |
| sjmc7 | it’s too early for my annual ‘being right’! | 16:00 |
| *** belmoreira has quit IRC | 16:00 | |
| rosmaita | ok, sjmc7 is possibly not incorrect | 16:01 |
| -openstackstatus- NOTICE: logs.openstack.org is stabilized and there should no longer be *new* POST_FAILURE errors. Logs for jobs that ran in the past weeks until earlier today are currently unavailable pending FSCK completion. We're going to temporarily disable *successful* jobs from uploading their logs to reduce strain on our current limited capacity. Thanks for your patience ! | 16:01 | |
| jokke_ | sjmc7: only place we monkeypatch is tests and registry, api and scrubber launchers ... the rest are on the tests themselves so if the tests/__init__.py has it any test calling monkeypatch after that should be safe | 16:01 |
| jokke_ | I'd rather have it once too many than fight with the gate to patch it again | 16:03 |
| *** btully has joined #openstack-glance | 16:03 | |
| rosmaita | ok, i misunderstood | 16:03 |
| rosmaita | i thought you were saying patch only tests/__init__ | 16:03 |
| rosmaita | but you are saying, patch registry, api, and scrubber launchers, *and* tests/__init__ | 16:03 |
| jokke_ | nope, we need to patch that and the 3 files in cmd/ that calls the monkeypatch when the service is started | 16:04 |
| jokke_ | correct | 16:04 |
| rosmaita | ok, that makes sense | 16:04 |
| jokke_ | anything else under tests/ that calls it should be covered if we patch the tests/__init__ | 16:04 |
| rosmaita | well, given the update to the neutron patch, i withdraw my objection to calling eventlet.hubs.get_hub() | 16:04 |
| rosmaita | because i guess it's unlikely that the requirements u-c will be lifted to 0.22.0 ? | 16:05 |
| jokke_ | well it will ... the real question is when ... so this is needed anyways just until we have moved to the eventlet version that handles it | 16:06 |
| *** btully has quit IRC | 16:07 | |
| jokke_ | I think the real question is, is that sleep going to solve the issue and is there any caveats calling the get hub all over the place | 16:07 |
| rosmaita | sure, i guess what i'm saying is we can move faster than getting the constraints change | 16:07 |
| jokke_ | we have to ... it's just which way we want to proceed | 16:08 |
| jokke_ | what is less intrusive and solves the problem | 16:08 |
| jokke_ | and doesn't break us when we move there | 16:08 |
| abhishekk | rosmaita, jokke_ : I am running back to home, will be back in 1.5 hours | 16:08 |
| rosmaita | sjmc7 what's your opinion? sleep or get_hub? | 16:08 |
| jokke_ | abhishekk: safe commute | 16:08 |
| rosmaita | abhishekk sounds good, and it looks like we are making progress | 16:08 |
| rosmaita | have a safe commute and a nice holiday tomorrow | 16:09 |
| rosmaita | this stuff won't get through the gates until saturday or sunday, anyway! | 16:09 |
| abhishekk | Sounds good, I will be online though, let me know anything is required | 16:09 |
| rosmaita | ok, will do | 16:09 |
| sjmc7 | i guess get_hub is maybe more correct if it works? i’m gonna stick with sleep because either way it’s a magic call for no obvious reason | 16:09 |
| rosmaita | thanks for all your work on this, abhishekk | 16:09 |
| jokke_ | well infra just pushed update that the logs fs issue should be solved for now ... hopefully that speeds things up | 16:10 |
| jokke_ | sjmc7: if you look the eventlet commit comment there it actually gives pretty obvious reason why that happens | 16:10 |
| sjmc7 | yeah, i meant as a reader of our code | 16:11 |
| sjmc7 | get_hub is probably more correct | 16:11 |
| jokke_ | oh yeah | 16:11 |
| jokke_ | that needs comments :D | 16:11 |
| sjmc7 | that commit mentions python 2.7.13 | 16:12 |
| rosmaita | this looks pretty good: https://review.openstack.org/#/c/537863/2/neutron/common/eventlet_utils.py | 16:12 |
| sjmc7 | yeah, i copied the neutron one and seems to work on my VM, testing it in zuul now | 16:12 |
| rosmaita | i think it makes sense to mention 2.7.12-1ubuntu0~16.04.3 in the comment, though, since something in there suddenly got this going | 16:14 |
| openstackgerrit | Erno Kuvaja proposed openstack/glance master: Fix py27 eventlet issue <0.22.0 https://review.openstack.org/537951 | 16:17 |
| jokke_ | rosmaita: smcginnis sjmc7 abhishekk ^^ | 16:17 |
| sjmc7 | it | 16:18 |
| sjmc7 | it’s spreading! | 16:18 |
| sjmc7 | i wonder if this is going to come as a surprise to projects that don’t try to run the server during tests | 16:19 |
| sjmc7 | tempest might catch it i guess | 16:19 |
| jokke_ | sjmc7: it seems to need quite specific conditions to occur | 16:19 |
| sjmc7 | lucky us | 16:19 |
| rosmaita | no kidding | 16:19 |
| jokke_ | like the specific versions (that OS seems to be utilizing right now) and using the default hub and monkeypatching before eventlet is properly initialized | 16:20 |
| jokke_ | rosmaita: mind to cherry-pick that to your environment and see what happens? | 16:26 |
| rosmaita | just doing that now | 16:26 |
| jokke_ | gr8 | 16:26 |
| rosmaita | jokke_ can you add partial-bug #1744824 to your commit message ? | 16:26 |
| openstack | bug 1744824 in Glance "functional tests broken under py27" [Critical,Triaged] https://launchpad.net/bugs/1744824 | 16:26 |
| jokke_ | is it partial? | 16:27 |
| jokke_ | or does that actually fix he issue? | 16:27 |
| rosmaita | depends on how confident you are | 16:27 |
| jokke_ | that's why I asked you to run it :P | 16:27 |
| jokke_ | will put fixes-bug when I get green light from you it actually solves the issue :D | 16:28 |
| rosmaita | give me a sec, i just built a new vm, need to do apt-get dist-upgrade or i won't see the problem | 16:28 |
| jokke_ | sure ... I actually put fixes in the commit message so we don't need to gate it again once you're done | 16:28 |
| openstackgerrit | Erno Kuvaja proposed openstack/glance master: Fix py27 eventlet issue <0.22.0 https://review.openstack.org/537951 | 16:30 |
| *** dtantsur|afk is now known as dtantsur | 16:31 | |
| rosmaita | running functional tests in unpatched glance to make sure i see the failure | 16:35 |
| rosmaita | YES!!! FAILURE | 16:40 |
| rosmaita | (can't believe i said that) | 16:41 |
| sjmc7 | haha | 16:41 |
| sjmc7 | urgh, zuul’s backed up | 16:41 |
| *** openstackstatus has quit IRC | 16:41 | |
| *** openstackstatus has joined #openstack-glance | 16:42 | |
| *** ChanServ sets mode: +v openstackstatus | 16:42 | |
| *** linkmark has joined #openstack-glance | 16:43 | |
| jokke_ | afk for a bit | 16:47 |
| rosmaita | ok, running your patch now | 16:48 |
| rosmaita | YES!!! SUCCESS | 16:50 |
| *** udesale has quit IRC | 16:53 | |
| *** links has quit IRC | 16:57 | |
| *** tesseract has quit IRC | 16:58 | |
| jlvillal | rosmaita, You may want to get glance out of the 'integrated' queue for the gate | 17:00 |
| jlvillal | https://docs.openstack.org/infra/zuul/feature/zuulv3/user/config.html | 17:00 |
| jlvillal | The 'integrated' queue seems to get a lot of projects in it and if one thing fails everything gets restarted. | 17:01 |
| rosmaita | that does seem to be a problem we are having | 17:02 |
| rosmaita | what do i need to do | 17:02 |
| rosmaita | ? | 17:02 |
| jlvillal | rosmaita, https://docs.openstack.org/infra/zuul/feature/zuulv3/user/config.html#project | 17:02 |
| jlvillal | rosmaita, I'm not sure where you zuul definitions are | 17:02 |
| jlvillal | rosmaita, If you look at that example it has: | 17:03 |
| *** abhishekk has quit IRC | 17:03 | |
| jlvillal | gate: | 17:03 |
| rosmaita | i am afraid they're in infra/project-config | 17:03 |
| jlvillal | queue: integrated | 17:03 |
| jlvillal | You probably want | 17:03 |
| jlvillal | queue: glance | 17:03 |
| jlvillal | Like we do in Ironic | 17:03 |
| rosmaita | i didn't know you could have your own queue! | 17:04 |
| rosmaita | TIL | 17:04 |
| rosmaita | thanks for the pointer, i will put up a patch | 17:04 |
| jlvillal | rosmaita, You're welcome | 17:05 |
| *** abhishekk has joined #openstack-glance | 17:06 | |
| abhishekk | rosmaita, jokke_ anything I can do now? | 17:07 |
| rosmaita | i think we are ok | 17:08 |
| rosmaita | erno put up a patch for the eventlet issue | 17:08 |
| abhishekk | rosmaita, just looking at that | 17:08 |
| rosmaita | works for me locally, fixes functional-py27 and does not break functional-py35 | 17:09 |
| abhishekk | great | 17:09 |
| abhishekk | should I cross check it, or not required? | 17:10 |
| rosmaita | i think we are ok | 17:12 |
| rosmaita | thanks | 17:12 |
| *** jistr is now known as jistr|conf | 17:13 | |
| abhishekk | great | 17:13 |
| abhishekk | will wait for the results then +2A on it | 17:13 |
| rosmaita | cool, although i am willing to ninja it in | 17:14 |
| abhishekk | sounds good | 17:14 |
| rosmaita | (not sure how long it will take in the gate!) | 17:14 |
| abhishekk | if it still there during my day time then I will do it, ow you can ninja approve it | 17:14 |
| rosmaita | cool ... i sure hope it's not there in your day time! | 17:15 |
| *** dtantsur is now known as dtantsur|afk | 17:15 | |
| abhishekk | :D, drop me mail if anything else needs to be addressed, thank you | 17:15 |
| rosmaita | will do, enjoy your holiday! | 17:15 |
| abhishekk | yes | 17:16 |
| openstackgerrit | Jean-Philippe Evrard proposed openstack/glance master: Fix pip install failure https://review.openstack.org/537979 | 17:16 |
| *** evrardjp has joined #openstack-glance | 17:17 | |
| evrardjp | hello | 17:17 |
| rosmaita | evrardjp just looking at your patch | 17:18 |
| evrardjp | wow that was quick! | 17:18 |
| evrardjp | :D | 17:18 |
| evrardjp | good mornign rosmaita :) | 17:18 |
| rosmaita | someone else also has a patch up for this | 17:18 |
| evrardjp | yes | 17:18 |
| rosmaita | i think the problem may be setup.cfg | 17:18 |
| rosmaita | because that is supposed to be an optional file | 17:18 |
| evrardjp | yes | 17:18 |
| evrardjp | well | 17:18 |
| evrardjp | if it's an optional file, we shoudl remove it from setup.cfg then | 17:19 |
| evrardjp | I can fix that quick on my patch | 17:19 |
| evrardjp | but I think it would make sense to be at least consistent for the generator? | 17:19 |
| evrardjp | so at least the rename makes sense, probably removing it from setup.cfg on top | 17:19 |
| rosmaita | i think our generators all make only .sample filews | 17:19 |
| evrardjp | mmm | 17:19 |
| rosmaita | the non-sample ones we commit explicitly | 17:20 |
| rosmaita | which i would like to get away from , but there is some disagreement about that | 17:20 |
| rosmaita | but that's a different issue | 17:20 |
| evrardjp | yeah | 17:20 |
| evrardjp | ok so let me abandon my patch then | 17:20 |
| rosmaita | ok, i see you already saw the other patch | 17:21 |
| evrardjp | wait | 17:21 |
| rosmaita | yes, please abandon | 17:21 |
| evrardjp | haha well | 17:21 |
| rosmaita | and thank you for putting it up | 17:21 |
| evrardjp | ... | 17:21 |
| *** abhishekk has quit IRC | 17:22 | |
| evrardjp | yes, I think I was confused, because I see other files in etc/ | 17:22 |
| evrardjp | that could be generated from oslo-config-generator | 17:22 |
| evrardjp | yeah I think as long as we agree :) | 17:23 |
| evrardjp | sorry for the inconvenience! | 17:24 |
| evrardjp | it's late for me, time to do something else with my life! :D | 17:24 |
| evrardjp | see you later everyone! | 17:24 |
| rosmaita | evrardjp not at all ... and actually, thanks for putting up your patch, i've been looking at other stuff and would have left the other patch sitting for a day or two | 17:25 |
| evrardjp | haha :D | 17:27 |
| evrardjp | I know the feeling :D | 17:27 |
| jlvillal | rosmaita, FYI on the queue thing. So if your project depends on nova or cinder or neutron or anything else in the integrated queue and something in the gate breaks you, you won't find out until later. | 17:30 |
| jlvillal | rosmaita, But I'm not sure if that is a big deal or not. But you should know. | 17:30 |
| rosmaita | jlvillal ty, that's why i have not put up a patch yet, am trying to figure out the implications | 17:31 |
| rosmaita | jlvillal thanks! | 17:31 |
| jlvillal | rosmaita, I'm not sure if nova breaking you and now your patch can't get merged in new tests is a big deal or not. | 17:31 |
| jlvillal | rosmaita, Since you are broken anyway... | 17:31 |
| jlvillal | rosmaita, But yes consider the implications :) | 17:31 |
| *** jose-phillips has joined #openstack-glance | 17:32 | |
| *** abhishekk has joined #openstack-glance | 17:37 | |
| *** itlinux has quit IRC | 17:38 | |
| *** abhishekk has quit IRC | 17:42 | |
| *** abhishekk has joined #openstack-glance | 17:51 | |
| *** btully has joined #openstack-glance | 17:51 | |
| *** btully has quit IRC | 17:55 | |
| *** abhishekk has quit IRC | 17:58 | |
| *** AlexeyAbashkin has quit IRC | 17:59 | |
| *** jistr|conf is now known as jistr | 18:14 | |
| *** rmcall has quit IRC | 18:20 | |
| jokke_ | rosmaita: so it worked, I can hop off for now? ;) | 18:22 |
| rosmaita | jokke_ sure | 18:30 |
| rosmaita | i will ninja-approve once zuul gives +1 | 18:31 |
| jokke_ | :) | 18:41 |
| *** hoonetorg has quit IRC | 19:07 | |
| *** AlexeyAbashkin has joined #openstack-glance | 19:24 | |
| *** AlexeyAbashkin has quit IRC | 19:28 | |
| *** abhishekk has joined #openstack-glance | 19:35 | |
| *** rmcall has joined #openstack-glance | 19:35 | |
| *** harlowja has joined #openstack-glance | 19:44 | |
| *** e0ne has joined #openstack-glance | 19:49 | |
| *** Supun has quit IRC | 19:58 | |
| *** e0ne has quit IRC | 20:08 | |
| *** hoonetorg has joined #openstack-glance | 20:14 | |
| *** e0ne has joined #openstack-glance | 20:36 | |
| *** e0ne has quit IRC | 20:54 | |
| *** mvk has joined #openstack-glance | 20:55 | |
| *** cleong has quit IRC | 21:32 | |
| *** linkmark has quit IRC | 22:00 | |
| *** abhishekk has quit IRC | 22:05 | |
| *** itlinux has joined #openstack-glance | 22:37 | |
| *** mvk has quit IRC | 23:00 | |
| *** itlinux has quit IRC | 23:04 | |
| *** itlinux has joined #openstack-glance | 23:06 | |
| *** itlinux has quit IRC | 23:11 | |
| *** btully has joined #openstack-glance | 23:18 | |
| *** rmcall has quit IRC | 23:20 | |
| *** btully has quit IRC | 23:23 | |
| *** edmondsw has quit IRC | 23:27 | |
| *** r-daneel has quit IRC | 23:57 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!