Friday, 2017-11-17

openstackgerritSean McGinnis proposed openstack/glance master: Fix SQLAlchemy reference link  https://review.openstack.org/51845900:09
*** gyee_ has quit IRC00:13
*** markvoelker has quit IRC00:31
*** zhurong has joined #openstack-glance00:34
*** Sukhdev has joined #openstack-glance00:43
*** markvoelker has joined #openstack-glance00:43
*** zhurong has quit IRC01:34
*** Sukhdev has quit IRC01:38
*** trungnv has quit IRC02:11
*** dalgaaf has quit IRC02:39
*** dalgaaf has joined #openstack-glance02:39
*** namnh has joined #openstack-glance02:45
*** links has joined #openstack-glance03:03
*** akekane has joined #openstack-glance03:13
*** akekane is now known as abhishekk03:14
*** _ix has joined #openstack-glance03:27
*** Sukhdev has joined #openstack-glance03:36
openstackgerritMerged openstack/glance master: Fix SQLAlchemy reference link  https://review.openstack.org/51845903:44
*** rosmaita has quit IRC03:56
*** flwang1 has quit IRC04:05
abhishekkjokke_: still around?04:23
*** nikhil has quit IRC04:25
*** udesale has joined #openstack-glance04:50
*** Sukhdev has quit IRC05:26
openstackgerritNguyen Van Trung proposed openstack/glance master: Add validation to improve pep8 check for glance project  https://review.openstack.org/52033705:34
*** trungnv has joined #openstack-glance05:34
*** ratailor has joined #openstack-glance05:36
*** ratailor has quit IRC05:36
*** ratailor has joined #openstack-glance05:36
*** Sukhdev has joined #openstack-glance05:41
*** Sukhdev has quit IRC05:42
*** _ix has quit IRC05:48
*** zhurong has joined #openstack-glance06:41
*** belmoreira has joined #openstack-glance06:42
openstackgerritAbhishek Kekane proposed openstack/glance master: Stage call fails with TypeError  https://review.openstack.org/52094506:57
*** markvoelker has quit IRC06:59
*** pcaruana has joined #openstack-glance07:04
*** flwang1 has joined #openstack-glance07:17
*** rcernin has quit IRC07:18
*** namnh has quit IRC07:27
*** trungnv has quit IRC07:42
*** zhurong has quit IRC07:43
*** markvoelker has joined #openstack-glance08:00
*** AlexeyAbashkin has joined #openstack-glance08:01
*** alexchadin has joined #openstack-glance08:24
*** belmoreira has quit IRC08:47
*** sdatko has joined #openstack-glance08:51
*** alexchadin has quit IRC09:05
*** alexchadin has joined #openstack-glance09:05
*** arcolife has joined #openstack-glance09:07
*** e0ne has joined #openstack-glance09:29
*** alexchadin has quit IRC09:46
*** alexchadin has joined #openstack-glance09:47
*** alexchadin has quit IRC09:57
*** alexchadin has joined #openstack-glance09:58
*** sapd__ has quit IRC10:09
*** sapd__ has joined #openstack-glance10:14
*** arcolife has quit IRC10:22
*** arcolife has joined #openstack-glance10:36
*** udesale has quit IRC10:56
*** abhishekk has quit IRC11:00
*** alexchadin has quit IRC11:04
*** alexchadin has joined #openstack-glance11:05
*** alexchadin has quit IRC11:17
*** e0ne has quit IRC11:26
*** e0ne has joined #openstack-glance11:26
*** e0ne has quit IRC11:41
*** e0ne has joined #openstack-glance11:44
*** ratailor has quit IRC11:54
*** pbourke has quit IRC12:10
*** pbourke has joined #openstack-glance12:12
*** udesale has joined #openstack-glance12:13
*** clayton has quit IRC12:44
*** arcolife has quit IRC12:47
*** gcb has quit IRC12:47
*** MattMan has quit IRC12:54
*** MattMan has joined #openstack-glance12:54
*** mosulica has joined #openstack-glance13:05
*** links has quit IRC13:19
*** clayton has joined #openstack-glance13:29
*** markvoelker has quit IRC13:34
*** markvoelker has joined #openstack-glance13:34
*** clayton has quit IRC13:38
*** clayton has joined #openstack-glance13:39
*** gabor_antal_ has quit IRC14:04
*** udesale has quit IRC14:31
*** ratailor has joined #openstack-glance14:58
*** udesale has joined #openstack-glance15:11
*** udesale has quit IRC15:12
*** e0ne_ has joined #openstack-glance15:14
*** e0ne has quit IRC15:17
*** odyssey4me has joined #openstack-glance15:22
odyssey4mehi everyone - is there anything in particular holding back a final core vote for https://review.openstack.org/#/c/506145/ ?15:23
*** rosmaita has joined #openstack-glance15:23
*** ratailor has quit IRC15:31
odyssey4merosmaita ^15:35
odyssey4mesorry, I see you just joined, so I'll repeat the message :)15:35
odyssey4mehi everyone - is there anything in particular holding back a final core vote for https://review.openstack.org/#/c/506145/ ?15:35
* rosmaita looking15:46
odyssey4methanks rosmaita15:47
rosmaitaodyssey4me: LGTM15:49
rosmaitaodyssey4me: at the PTG you mentioned perhaps having time to help set up upgrade testing for glance ... how's your time looking?15:50
odyssey4merosmaita terrible, that said I think I can put some time into making that happen15:51
odyssey4meI can push up a patch to add the job as a non-voting job now, then we can improve the job to a point of it doing all the right things. Happy with that?15:51
rosmaitatotally understand15:51
rosmaitayes, that would be a good start and very helpful15:52
odyssey4melet me do that now, then we can liaise in the hope that we do all the right things by M3 (hopefully)15:53
rosmaitaworks for me!15:53
*** mosulica has quit IRC16:00
*** AlexeyAbashkin has quit IRC16:05
*** gyee_ has joined #openstack-glance16:09
openstackgerritJesse Pretorius (odyssey4me) proposed openstack/glance master: Add non-voting rolling upgrade test  https://review.openstack.org/52112316:11
rosmaitathat was quick!16:11
odyssey4meyeah, it's pretty straightforward to define the job, as we have the framework there already16:12
rosmaitathanks for the detailed commit message16:12
odyssey4mebut our glance role needs to actually do rolling upgrades (currently it does the old style of deploying glance-registry and glance-api, so it can't do rolling upgrades), but I'll patch that in asap and add a depends-on to this once that's going so that they're tested together16:13
rosmaitaodyssey4me : on line 31 in .zuul.yaml, should s/keystone/glance/ ?16:14
odyssey4meyes, lemme fix16:14
rosmaitanp16:14
odyssey4meif there're any other excludes or notes you'd like added then please comment in review :)16:16
openstackgerritJesse Pretorius (odyssey4me) proposed openstack/glance master: Add non-voting rolling upgrade test  https://review.openstack.org/52112316:18
*** _ix has joined #openstack-glance16:34
*** jistr has quit IRC16:39
*** jistr has joined #openstack-glance16:43
openstackgerritMerged openstack/glance master: Add default configuration files to data_files  https://review.openstack.org/50614516:59
odyssey4merosmaita it appears that the glance docs stop somewhere after ocata - I guess they need updating?16:59
odyssey4methe install docs still describe the setup for glance with both registry and api17:00
odyssey4meI take it that the consolidation required for rolling upgrades is that registry is no longer running, and therefore only the api is running?17:00
rosmaitayes, so a v2-only installation17:15
rosmaitawith no registry17:15
*** _ix has quit IRC17:21
odyssey4mehmm, ok - are there any plans to go beyond deprecating v1 (ie removing it entirely?)17:23
odyssey4melooks like I'll have to implement some changes to allow deployers to enable/disable these things first, and to be able to do online/offline upgrades based on whatever's enabled/disabled... so this is going to get a little complex, but it'll be worth it I think :)17:24
odyssey4meit's especially important to do it this way because of that nasty THIS IS EXPERIMENTAL warning in the rolling upgrade docs :)17:25
rosmaitaodyssey4me: so v1 is scheduled to be removed in Queens17:25
odyssey4meoh really? hmm - that makes it easier to force the hand17:25
odyssey4meis there a patch up for that already? if not, what's holding it back?17:26
rosmaitawell, image import has to be feature-complete17:26
rosmaitawhich we are working on ...17:26
rosmaitabut there may not be a v1 removal patch until Q-317:27
rosmaitaalso, registry is deprecated in Q and will be removed in S17:27
odyssey4meok, I think I'll need to still implement it the way I'm thinking17:28
odyssey4meit'll hopefully give us something to test and validate that rolling upgrades are safe so that that big warning can be removed for Queens, or perhaps in R17:28
rosmaitayes, that would be great17:29
odyssey4meeverything we implement goes into production environments, so the conservative approach is better for the defaults we apply17:29
odyssey4mebut there's nothing that says we can't enable someone to opt-in to new features, giving people the option to try it out and give feedback17:30
rosmaitai agree17:30
odyssey4meI'm building a test environment now and will put together a series of patches in the next week or two to get everything in place. I may ping questions to the channel as I go.17:31
odyssey4merosmaita does glance have any tests which exercise different stores (eg rbd, swift, etc)? would that be something of interest to have?17:36
odyssey4meI'm speaking of functional tests here, of course.17:37
rosmaitai think we're pretty light on those, both in glance and glance_store17:40
rosmaitahttp://git.openstack.org/cgit/openstack/glance_store/tree/glance_store/tests/functional17:40
rosmaitahttp://git.openstack.org/cgit/openstack/glance/tree/glance/tests/functional17:41
odyssey4meok, we can extend to implementing more of those too later17:41
*** akekane has joined #openstack-glance17:41
rosmaitaok, cool17:42
*** akekane is now known as abhishekk17:42
abhishekkrosmaita: hi, when you get some free time, please let me know your opinion about this bug, https://bugs.launchpad.net/glance/+bug/173283017:47
openstackLaunchpad bug 1732830 in Glance "Unreachable 'ImageSizeLimitExceeded' exception block in stage call" [Undecided,New] - Assigned to Abhishek Kekane (abhishek-kekane)17:47
rosmaitaabhishekk: ok17:47
abhishekkrosmaita: thank you17:47
*** e0ne_ has quit IRC17:49
odyssey4meif I'm currently running the v1 api and the registry service, is there anything special that needs to be done to disable the registry service?17:52
odyssey4medo I have to first remove the v1 api before I can disable the registry service?17:53
rosmaitaodyssey4me: no, there are settings in the glance-api.conf file for whether v2 uses the registry or not17:54
odyssey4meok, but if v1 is running the registry has to be used, right?17:55
rosmaitayes17:55
rosmaitaby v117:56
odyssey4meand the v2 options for glance-api to use registry are noted here: https://docs.openstack.org/glance/latest/configuration/glance_api.html#DEFAULT.data_api17:58
odyssey4mealong with the enable_v2_* options17:59
rosmaitayes18:06
*** abhishekk has quit IRC18:07
openstackgerritJesse Pretorius (odyssey4me) proposed openstack/glance master: Correct spelling error for config section DEFAULT  https://review.openstack.org/52115118:15
odyssey4merosmaita ^ just a little thing I found along the way that needed fixing18:15
rosmaitai thought we fixed that, but guess not18:17
rosmaitaodyssey4me : did you regenerate the config files, or fix them by hand?18:18
odyssey4merosmaita I just did a sed, but it's clearly the confi.py entry that was the cause of the docs issue18:25
rosmaitaodyssey4me : ok, just commit the config.py if you don't mind18:26
rosmaitaor you could regenerate the config files and include them in the commit18:26
rosmaitaup to you18:26
rosmaitai think some more stuff will be brought in on regeneration18:26
odyssey4merosmaita the change for that is in the same review18:27
odyssey4meI didn't think it appropriate to bring in unrelated changes, but I can regen the file if you like.18:27
rosmaitawell, the only reason to commit new sample .conf files is if they've been regenerated18:28
rosmaitawe have a policy about that, but i can't remember what it is18:29
*** _ix has joined #openstack-glance18:29
odyssey4meok, will regen and submit with the code patch18:29
odyssey4methanks for having a tox env for that, otherwise it'd be a thing to figure out :)18:30
rosmaitathanks, just mention in the commit message that your patch includes a sample conf file refresh18:30
odyssey4meyup, will do18:30
rosmaitathanks!18:30
openstackgerritJesse Pretorius (odyssey4me) proposed openstack/glance master: Correct related section for enable_image_import  https://review.openstack.org/52115118:35
odyssey4methere we go18:35
odyssey4mequite a bit of new content18:36
rosmaitayes, i forgot to regenerate in master when i regenerated for the pike release18:36
rosmaitathanks for taking the time to correct that help text18:37
odyssey4meapparently it's not desirable to keep these sample conf files in the git tree - downstream consumers are supposed to learn to generate them rather than rely on a sample which may not be current18:38
odyssey4meglance appears to be one of the few projects still doing it18:38
rosmaitathat's good to know18:38
rosmaitabecause it is an enormous pain in the butt18:39
odyssey4methis is what nova does instead: https://github.com/openstack/nova/blob/master/etc/nova/README-nova.conf.txt18:39
odyssey4meI'm guessing that they have something for docs which generates the same in docs whenever the docs are published18:40
rosmaitai was hoping we could take advantage of zuul3 to set up a job to do the refresh18:40
rosmaitayeah, thanks for the link, i will have to look into that18:40
odyssey4mewell, you kinda can do it with the proposal bot - probably18:40
odyssey4mebut a better option would probably be to have it publish with docs as nova's doing18:41
rosmaitayeah, we were thinking generate, compare to current, if any diff, put up a patch18:41
rosmaitabut i agree, better to do it like nova18:41
odyssey4meaha: https://github.com/openstack/nova/commit/83a9c2ac334712b27704a814552628cf0e536a8518:42
rosmaitameans we will have to fix all those docstrings, you probably noticed that the generated html looks pretty bad in ours18:42
odyssey4meyeah, I wondered if that was a known bug18:43
odyssey4meI can push up a patch to switch to doing this if you like?18:43
rosmaitai have no objection!18:43
odyssey4meok, I've got to run now but I'll pick that up tomorrow I think... it doesn't look too complicated and would save you some time18:44
rosmaitaif you have time, that would be great18:45
odyssey4memake the tools work for you :)18:45
rosmaitaexactly!18:45
*** e0ne has joined #openstack-glance19:03
*** _ix has quit IRC19:12
*** ChanServ changes topic to "OpenStack Glance"19:12
*** ChanServ changes topic to "OpenStack Glance | priorities: http://lists.openstack.org/pipermail/openstack-dev/2017-November/124678.html"19:12
*** ChanServ changes topic to "OpenStack Glance | priorities: http://lists.openstack.org/pipermail/openstack-dev/2017-November/124678.html | logs at http://eavesdrop.openstack.org/irclogs/%23openstack-glance/"19:12
*** e0ne has quit IRC19:15
*** Sukhdev has joined #openstack-glance19:38
openstackgerritMerged openstack/glance master: Remove setting of version/release from releasenotes  https://review.openstack.org/52064419:40
*** rosmaita has quit IRC19:52
*** _ix has joined #openstack-glance20:09
*** Sukhdev has quit IRC20:51
*** AlexeyAbashkin has joined #openstack-glance21:19
*** AlexeyAbashkin has quit IRC21:24
*** Sukhdev has joined #openstack-glance21:53
openstackgerritMerged openstack/glance master: Correct related section for enable_image_import  https://review.openstack.org/52115122:08
*** hoonetorg has quit IRC22:28
*** _ix has quit IRC22:36
*** _ix has joined #openstack-glance22:50
*** pcaruana has quit IRC23:54

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!