openstackgerrit | Sean McGinnis proposed openstack/glance master: Separate out functional tests https://review.openstack.org/474816 | 00:05 |
---|---|---|
*** masuberu has joined #openstack-glance | 00:17 | |
*** masber has quit IRC | 00:20 | |
*** mtanino has quit IRC | 01:03 | |
*** zhurong has joined #openstack-glance | 01:11 | |
*** lucasxu has joined #openstack-glance | 01:20 | |
*** lucasxu has quit IRC | 01:22 | |
*** zzzeek has quit IRC | 01:23 | |
*** zzzeek has joined #openstack-glance | 01:24 | |
*** r-daneel has quit IRC | 01:24 | |
*** tonyb has quit IRC | 01:24 | |
*** zzzeek has quit IRC | 01:25 | |
*** tonyb has joined #openstack-glance | 01:25 | |
*** zzzeek has joined #openstack-glance | 01:25 | |
*** rydou has joined #openstack-glance | 01:27 | |
*** rydou has quit IRC | 01:28 | |
*** rydou has joined #openstack-glance | 01:29 | |
*** rydou has quit IRC | 01:31 | |
*** rydou has joined #openstack-glance | 01:32 | |
*** masber has joined #openstack-glance | 01:34 | |
*** masber has quit IRC | 01:34 | |
*** masuberu has quit IRC | 01:34 | |
*** markvoelker has joined #openstack-glance | 01:41 | |
*** markvoelker has quit IRC | 02:15 | |
*** amrith has joined #openstack-glance | 02:54 | |
amrith | hola rosmaita | 02:54 |
rosmaita | hola | 02:54 |
amrith | didn't realize that my new bouncer had booted glance channel. just added it back | 02:55 |
amrith | just figured I'd say hello. nothing fun and interesting, tty tomorrow | 02:57 |
rosmaita | sounds good! ttyl | 02:57 |
*** markvoelker has joined #openstack-glance | 03:12 | |
*** mine0901 has joined #openstack-glance | 03:13 | |
rydou | hi rosmaita , pls review https://review.openstack.org/#/c/494349/ again, updated the commit msg, thx | 03:25 |
*** nicolasbock_ has joined #openstack-glance | 03:25 | |
rosmaita | rydou: thanks for the quick work on that | 03:26 |
rosmaita | rydou: next time you cherry pick, use -x and git will put the cherry-pick info in the commit message for you | 03:27 |
rydou | rosmaita : OK, and can you help to review another bug-fix for glance-client https://review.openstack.org/#/c/491656/ | 03:28 |
rosmaita | rydou: i'll put that on my list for tomorrow (i am in new york time zone) | 03:30 |
rydou | rosmaita : OK thank you | 03:31 |
*** udesale has joined #openstack-glance | 03:42 | |
*** markvoelker has quit IRC | 03:46 | |
*** masber has joined #openstack-glance | 03:49 | |
*** masber has quit IRC | 03:53 | |
*** mkrcmari__ has joined #openstack-glance | 04:01 | |
*** hoonetorg has joined #openstack-glance | 04:18 | |
*** links has joined #openstack-glance | 04:23 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/glance_store master: Updated from global requirements https://review.openstack.org/494809 | 04:40 |
*** markvoelker has joined #openstack-glance | 04:43 | |
*** gyee has quit IRC | 04:45 | |
openstackgerrit | Brian Rosmaita proposed openstack/glance master: Add 'tasks_api_access' policy https://review.openstack.org/494732 | 04:47 |
*** abhishekk has joined #openstack-glance | 04:50 | |
*** abhishekk is now known as abhishekk|busy | 04:50 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/python-glanceclient master: Updated from global requirements https://review.openstack.org/494894 | 04:51 |
*** adisky__ has joined #openstack-glance | 04:55 | |
*** masber has joined #openstack-glance | 05:09 | |
*** markvoelker has quit IRC | 05:16 | |
openstackgerrit | Brian Rosmaita proposed openstack/glance master: Return 404 for import-info call https://review.openstack.org/494544 | 05:17 |
*** rosmaita has quit IRC | 05:19 | |
*** ratailor has joined #openstack-glance | 05:25 | |
*** zhurong has quit IRC | 05:38 | |
*** zhurong has joined #openstack-glance | 05:41 | |
*** abhishekk|busy is now known as abhishekk | 05:59 | |
*** groen692 has joined #openstack-glance | 05:59 | |
*** markvoelker has joined #openstack-glance | 06:13 | |
*** pdeore has joined #openstack-glance | 06:33 | |
*** rcernin has joined #openstack-glance | 06:41 | |
*** markvoelker has quit IRC | 06:46 | |
*** tesseract has joined #openstack-glance | 07:13 | |
*** namnh has joined #openstack-glance | 07:18 | |
*** namnh has quit IRC | 07:18 | |
*** namnh has joined #openstack-glance | 07:19 | |
*** namnh has quit IRC | 07:20 | |
*** abhishekk is now known as abhishekk|lunch | 07:31 | |
openstackgerrit | Abhishek Kekane proposed openstack/python-glanceclient master: image-create-via-import fails with ValueError https://review.openstack.org/494982 | 07:31 |
*** pcaruana has quit IRC | 07:32 | |
*** markvoelker has joined #openstack-glance | 07:43 | |
*** e0ne has joined #openstack-glance | 07:46 | |
*** e0ne has quit IRC | 07:53 | |
*** pcaruana has joined #openstack-glance | 07:54 | |
*** e0ne has joined #openstack-glance | 07:55 | |
*** e0ne has quit IRC | 08:05 | |
*** e0ne has joined #openstack-glance | 08:06 | |
*** nicolasbock_ has quit IRC | 08:14 | |
*** markvoelker has quit IRC | 08:16 | |
*** abhishekk|lunch is now known as abhishekk | 08:23 | |
*** masber has quit IRC | 08:26 | |
*** mine0901 has quit IRC | 08:33 | |
*** markvoelker has joined #openstack-glance | 09:14 | |
*** rydou has quit IRC | 09:31 | |
*** dalgaaf has quit IRC | 09:34 | |
*** dalgaaf has joined #openstack-glance | 09:37 | |
*** markvoelker has quit IRC | 09:47 | |
*** pcaruana has quit IRC | 10:02 | |
*** udesale has quit IRC | 10:04 | |
*** pcaruana has joined #openstack-glance | 10:22 | |
*** markvoelker has joined #openstack-glance | 10:44 | |
*** zhurong has quit IRC | 11:01 | |
*** markvoelker has quit IRC | 11:17 | |
*** ratailor has quit IRC | 11:29 | |
*** adisky__ has quit IRC | 11:31 | |
*** mvk has joined #openstack-glance | 11:32 | |
*** mkrcmari__ has quit IRC | 11:35 | |
*** pdeore has quit IRC | 11:44 | |
*** rosmaita has joined #openstack-glance | 11:49 | |
*** gcb has quit IRC | 12:10 | |
*** abhishekk has quit IRC | 12:11 | |
*** rcernin has quit IRC | 12:21 | |
*** markvoelker has joined #openstack-glance | 12:25 | |
*** rcernin has joined #openstack-glance | 12:38 | |
*** Dinesh_Bhor has quit IRC | 12:39 | |
*** catintheroof has joined #openstack-glance | 12:40 | |
*** catinthe_ has joined #openstack-glance | 12:41 | |
*** catintheroof has quit IRC | 12:41 | |
*** jaosorior has quit IRC | 13:05 | |
*** lucasxu has joined #openstack-glance | 13:08 | |
*** ejat has quit IRC | 13:16 | |
*** ejat has joined #openstack-glance | 13:20 | |
openstackgerrit | Sean McGinnis proposed openstack/glance master: Separate out functional tests https://review.openstack.org/474816 | 13:26 |
*** mosulica has joined #openstack-glance | 13:33 | |
openstackgerrit | Sean McGinnis proposed openstack/glance master: Separate out functional tests https://review.openstack.org/474816 | 13:34 |
*** mtanino has joined #openstack-glance | 13:58 | |
*** efried is now known as fried_rice | 14:06 | |
*** lucasxu has quit IRC | 14:07 | |
*** baojg has joined #openstack-glance | 14:12 | |
openstackgerrit | Merged openstack/glance master: Fix 500 error from image-stage call https://review.openstack.org/494036 | 14:22 |
openstackgerrit | Merged openstack/glance master: Add 'api_image_import' type to task(s) schemas https://review.openstack.org/494063 | 14:22 |
*** MVenesio has joined #openstack-glance | 14:27 | |
*** MVenesio has quit IRC | 14:28 | |
*** MVenesio has joined #openstack-glance | 14:28 | |
rosmaita | mtreinish: can you answer kairat's question on https://review.openstack.org/#/c/494595/ ? | 14:53 |
*** dpawlik is now known as danpawlik_ | 15:03 | |
*** danpawlik_ is now known as dpawlik_ | 15:03 | |
*** mosulica has quit IRC | 15:07 | |
*** links has quit IRC | 15:10 | |
openstackgerrit | Brian Rosmaita proposed openstack/python-glanceclient master: Fix image-import call https://review.openstack.org/494352 | 15:12 |
*** udesale has joined #openstack-glance | 15:21 | |
*** MVenesio has quit IRC | 15:25 | |
*** gyee has joined #openstack-glance | 15:28 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/glance master: Updated from global requirements https://review.openstack.org/494808 | 15:46 |
*** sapd has quit IRC | 15:55 | |
*** aarefiev is now known as aarefiev_afk | 15:55 | |
*** e0ne has quit IRC | 16:09 | |
*** pcaruana has quit IRC | 16:12 | |
*** tesseract has quit IRC | 16:12 | |
*** rcernin has quit IRC | 16:12 | |
*** abhishekk_ has joined #openstack-glance | 16:15 | |
*** markvoelker has quit IRC | 16:16 | |
*** groen692 has quit IRC | 16:17 | |
openstackgerrit | Octave Orgeron proposed openstack/glance master: Alembic should use oslo_db facades https://review.openstack.org/477665 | 16:28 |
*** mvk_ has joined #openstack-glance | 16:36 | |
*** mvk_ has quit IRC | 16:38 | |
*** mvk has quit IRC | 16:39 | |
*** mvk has joined #openstack-glance | 16:40 | |
openstackgerrit | Sean McGinnis proposed openstack/glance master: Separate out functional tests https://review.openstack.org/474816 | 16:41 |
*** mvk_ has joined #openstack-glance | 16:43 | |
*** catinthe_ has quit IRC | 16:43 | |
abhishekk_ | rosmaita: hi, please let me know if any thing is required | 16:45 |
*** catintheroof has joined #openstack-glance | 16:45 | |
*** mvk has quit IRC | 16:46 | |
rosmaita | abhishekk_ i do have something, looking ... | 16:47 |
rosmaita | abhishekk_ could use you restoring your +2 on https://review.openstack.org/#/c/494352/ when it passes tests | 16:48 |
abhishekk_ | Ok | 16:48 |
rosmaita | (gate is getting kind of slow) | 16:48 |
abhishekk_ | I will keep look on that | 16:48 |
rosmaita | thanks, saw your latest glanceclient patch, i +2d it | 16:49 |
abhishekk_ | Thank you, just saw that | 16:49 |
rosmaita | np, thanks for finding that | 16:49 |
abhishekk_ | As you mentioned Ihave applied all required glance and client patches for testing it | 16:50 |
openstackgerrit | Merged openstack/glance master: api-ref: update container_format, disk_format https://review.openstack.org/493880 | 16:50 |
openstackgerrit | Merged openstack/glance master: Add 'tasks_api_access' policy https://review.openstack.org/494732 | 16:50 |
rosmaita | i guess the other thing to keep an eye on is the cherry picks | 16:50 |
rosmaita | to stable/pike | 16:50 |
rosmaita | i;m adding them to the etherpad | 16:50 |
abhishekk_ | Will look at those too | 16:51 |
rosmaita | thanks ... what time is it where you are? | 16:52 |
abhishekk_ | 10.30 pm now | 16:52 |
rosmaita | getting late ... | 16:53 |
abhishekk_ | No issue | 16:54 |
rosmaita | well, i don't want you to burn out! | 16:54 |
rosmaita | i think i can merge all the cherry picks myself | 16:54 |
abhishekk_ | Tomorrow is a rest day, so I can stretch little extra | 16:55 |
rosmaita | i appreciate your dedication! | 16:55 |
abhishekk_ | Its my duty :) | 16:55 |
*** abhishekk_ has quit IRC | 16:59 | |
*** abhishekk has joined #openstack-glance | 17:00 | |
*** lucasxu has joined #openstack-glance | 17:06 | |
rosmaita | abhishekk i think it's just https://review.openstack.org/494352 ... the two remaining non-doc glance patches are ones where flaper87 had questions | 17:12 |
rosmaita | if he accepts my responses, he can +2 those | 17:12 |
rosmaita | i think it's ok if the glanceclient release is a bit later than glance | 17:12 |
abhishekk | great, hopefully he will +2 those patches | 17:13 |
rosmaita | the only broken stuff we know about is all around image import | 17:13 |
abhishekk | yes | 17:13 |
abhishekk | gate is very slow, so IMO we need to wait on glanceclient release | 17:14 |
rosmaita | i agree | 17:14 |
rosmaita | it will probably speed up tomorrow! | 17:14 |
abhishekk | I am pretty sure that 494352 is just commit message change and it will pass the tests | 17:15 |
abhishekk | If required I will be available tomorrow | 17:15 |
rosmaita | thanks ... hopefully not. i'll shoot you an email if there's something that could use your attention | 17:16 |
rosmaita | we can always release monday ... today was really just a suggestion | 17:17 |
abhishekk | Do we need to backport glanceclient patches to stable/pike? | 17:17 |
rosmaita | good question | 17:17 |
rosmaita | i think maybe we do | 17:18 |
abhishekk | ok, if we decided to delay client release then I can backport them tomorrow morning my time | 17:19 |
rosmaita | that would be helpful ... not sure those will all be merged by then, though | 17:20 |
abhishekk | I will backport them once merged (anytime tomorrow or day after tomorrow) | 17:20 |
rosmaita | ok, cool, that will be great | 17:22 |
rosmaita | smcginnis: when you have a minute, i've got a question about the glanceclient and stable/pike | 17:22 |
abhishekk | is flavio around, I guess he might be away now | 17:24 |
rosmaita | not sure what time zone he is in these days | 17:25 |
rosmaita | i need to grab some lunch and walk the dog, will be away for half hour or so | 17:33 |
abhishekk | ok | 17:33 |
*** lucasxu has quit IRC | 17:48 | |
*** mvk_ has quit IRC | 18:10 | |
*** lucasxu has joined #openstack-glance | 18:20 | |
*** catinthe_ has joined #openstack-glance | 18:33 | |
*** catinth__ has joined #openstack-glance | 18:33 | |
*** udesale has quit IRC | 18:34 | |
*** catintheroof has quit IRC | 18:35 | |
*** catinthe_ has quit IRC | 18:37 | |
*** markvoelker has joined #openstack-glance | 19:05 | |
*** lucasxu has quit IRC | 19:06 | |
*** e0ne has joined #openstack-glance | 19:17 | |
smcginnis | rosmaita: I'm back now. What's up? | 19:25 |
rosmaita | got some release questions | 19:26 |
rosmaita | (and now i'm trying to remember what they are) | 19:26 |
smcginnis | Hah! :) | 19:27 |
rosmaita | i guess it's mostly about the glanceclient | 19:27 |
smcginnis | I see some mention in the scrollback. You need a new client release? | 19:27 |
rosmaita | yeah, partially bugfixes and partly compatibility changes to go with the v2.6 experimental api | 19:28 |
rosmaita | so, we have a stable/pike branch of glanceclient | 19:28 |
rosmaita | do we do the same thing that we're doing with glance: make fixes in master, and then cherry-pick to stable/pike? | 19:28 |
smcginnis | rosmaita: Yeah. So here's the maybe tricky part... | 19:28 |
smcginnis | rosmaita: Since it's past client lib freeze and everything is branched, the only real constraint is you can no longer raise the minimum required version. | 19:29 |
smcginnis | rosmaita: So if there's some functionality that must have the new client release, there's a risk that a deployment may have an older version because we can't raise that. | 19:29 |
smcginnis | rosmaita: Other than that, if it's just making something available, as soon as the freeze is over (next week I think) you can backport to stable/pike and request a new release. | 19:30 |
smcginnis | rosmaita: And the upper constraint in the requirements can be raised, that part is not a probelm. | 19:30 |
smcginnis | rosmaita: It works just like any stable release at that point. | 19:31 |
rosmaita | ok, another question ... we tagged glanceclient at 2.8.0 and that's where stable/pike was cut | 19:32 |
rosmaita | would the next release be 2.8.1? | 19:32 |
smcginnis | rosmaita: Are there only bug fixes, or are there new features included? | 19:33 |
rosmaita | just bugfixes (pretty sure) | 19:33 |
smcginnis | rosmaita: OK, in that case it makes sense to be a .1 release. | 19:34 |
*** greghayn1 has joined #openstack-glance | 19:34 | |
*** greghaynes has quit IRC | 19:34 | |
smcginnis | rosmaita: You have the option to do a 2.9 since a new release hasn't been done off of master with that. | 19:34 |
*** greghayn1 has left #openstack-glance | 19:34 | |
smcginnis | rosmaita: But then after GA of Pike, it should only be .1, .2, etc. | 19:34 |
rosmaita | (sorry to be dense, but i find this stuff confusing) | 19:35 |
rosmaita | so, we'll be putting bugfixes in master | 19:35 |
rosmaita | then do we tag master with 2.8.1? | 19:36 |
smcginnis | rosmaita: No worries, it's definitely confusing until you've done it a few times. :) | 19:36 |
rosmaita | or do we cherry pick the bugfixes into stable/pike and make that 2.8.1 ? | 19:36 |
smcginnis | rosmaita: So any patches should get merged to master first before backporting. | 19:36 |
smcginnis | rosmaita: But yeah, they do need to be cherry-picked to stable/pike. | 19:37 |
smcginnis | rosmaita: And the pike update would then be off of that stable/pike commit hash. | 19:37 |
smcginnis | rosmaita: You can just do a new release off of master, but the limitation there is the stable/pike upper constraints would not be able to be raised to that. I think. I'm not even 100% on that point though. | 19:38 |
smcginnis | rosmaita: But if it's needed for pike, probably better to do off of pike. | 19:38 |
rosmaita | ok, makes sense | 19:39 |
rosmaita | i keep forgetting about the upper constraints | 19:39 |
smcginnis | rosmaita: Are these client side bugfixes, or client lib code used by the glance service? | 19:39 |
smcginnis | In other words, do we even need to raise upper constraints? | 19:39 |
rosmaita | i think they're all client side | 19:40 |
smcginnis | rosmaita: OK, then u-c might not be a concern. But I think there are some distro packages that would not include the bugfix release if it's not from the stable/pike code. | 19:41 |
smcginnis | rosmaita: So I think you've got it. Merge fixes to master, backport to stable/pike, then request a release off of the stable branch hash and we should be good. | 19:41 |
rosmaita | ok, so it sounds like we definitely want to update stable/pike code, even if we don't mess with u-c | 19:42 |
rosmaita | great, thanks! | 19:42 |
smcginnis | rosmaita: Yeah, I think so. | 19:42 |
smcginnis | rosmaita: No problem, glad to help. It is a little confusing since there are so many moving parts. | 19:42 |
rosmaita | no kidding! | 19:42 |
rosmaita | one last thing ... probably add a release note about the bugs fixed ? | 19:43 |
smcginnis | rosmaita: If you think they are significant enough for end users to need to know about in reading through the release notes. | 19:43 |
smcginnis | rosmaita: No requirement, but can be useful depending on the bug. | 19:43 |
rosmaita | ok | 19:45 |
smcginnis | rosmaita: Low priority, so I hesitate to even bring it up at this point and cause a distraction, but breaking out the functional tests separate from the unit tests now work. | 19:47 |
smcginnis | rosmaita: https://review.openstack.org/474816 | 19:47 |
rosmaita | i noticed you were working on that | 19:47 |
rosmaita | glad it's working, thanks | 19:47 |
smcginnis | rosmaita: Something to think about maybe in the near future. Makes it a little faster running ut validation locally. | 19:47 |
rosmaita | i think it's a good idea, we can make the change after we've got all the import stuff cherry picked out of master | 19:48 |
smcginnis | rosmaita: Cool, sounds good. | 19:48 |
rosmaita | i appreciate your work, you've been a big part of the glance pike release | 19:49 |
smcginnis | rosmaita: Thanks, I appreciate that. Just trying to help where I can. | 19:50 |
*** e0ne has quit IRC | 19:51 | |
*** jdillaman has quit IRC | 19:51 | |
*** abhishekk has quit IRC | 20:07 | |
*** eastmde has joined #openstack-glance | 20:10 | |
*** eastmde has quit IRC | 20:23 | |
rosmaita | smcginnis: one more question if you're still around | 21:07 |
smcginnis | rosmaita: Yep, still here | 21:08 |
rosmaita | cool | 21:08 |
rosmaita | so, if i include some release notes for glance RC-2, do those go directly into stable/pike ? | 21:08 |
smcginnis | rosmaita: I believe reno handles it right if you merge them in master and cherry pick them stable/pike. | 21:09 |
rosmaita | ok, great | 21:09 |
rosmaita | thanks! | 21:10 |
smcginnis | Any time | 21:10 |
*** catintheroof has joined #openstack-glance | 21:22 | |
*** catinth__ has quit IRC | 21:25 | |
openstackgerrit | Brian Rosmaita proposed openstack/glance master: Add release note for Glance Pike RC-2 https://review.openstack.org/495437 | 21:29 |
*** mtanino has quit IRC | 21:54 | |
*** catintheroof has quit IRC | 21:57 | |
*** rosmaita has quit IRC | 22:01 | |
*** rosmaita has joined #openstack-glance | 22:07 | |
openstackgerrit | Brian Rosmaita proposed openstack/glance master: Add release note for Glance Pike RC-2 https://review.openstack.org/495437 | 22:10 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!