Thursday, 2017-07-27

*** mtanino has quit IRC00:07
*** Sukhdev has quit IRC01:06
*** jamielennox has quit IRC01:08
*** jamielennox has joined #openstack-glance01:15
*** harlowja has quit IRC01:19
*** cdelatte has quit IRC01:27
*** zhurong has joined #openstack-glance01:38
*** markvoelker has quit IRC02:03
*** markvoelker has joined #openstack-glance02:06
*** mtanino_ has joined #openstack-glance02:09
*** jamielennox has quit IRC02:17
*** jamielennox has joined #openstack-glance02:24
*** dillaman has joined #openstack-glance02:29
*** zhurong has quit IRC03:13
*** harlowja has joined #openstack-glance03:31
*** udesale has joined #openstack-glance03:36
*** mtanino_ has quit IRC03:53
*** nicolasbock has joined #openstack-glance04:07
*** hoonetorg has joined #openstack-glance04:26
*** links has joined #openstack-glance04:33
*** zhurong has joined #openstack-glance04:39
*** harlowja has quit IRC04:52
*** c06 has joined #openstack-glance04:59
c06hi all04:59
c06need suggestions on this one -> https://bugs.launchpad.net/glance/+bug/170606804:59
openstackLaunchpad bug 1706068 in Glance "(docker) uploaded and downloaded image having different image name" [Undecided,New]04:59
c06give some suggestions so that i can work on this one..05:08
*** abhishekk has joined #openstack-glance05:11
*** groen692 has joined #openstack-glance05:14
*** pdeore has joined #openstack-glance05:23
*** jdwidari has joined #openstack-glance05:36
*** jdwidari has quit IRC05:36
*** udesale__ has joined #openstack-glance05:47
*** udesale has quit IRC05:50
*** ratailor has joined #openstack-glance05:58
*** udesale has joined #openstack-glance06:12
*** udesale__ has quit IRC06:14
*** aavraham has joined #openstack-glance06:27
*** zhurong has quit IRC06:33
*** tshefi has joined #openstack-glance07:09
*** rcernin has joined #openstack-glance07:13
*** namnh has joined #openstack-glance07:27
*** obre has quit IRC07:36
*** obre has joined #openstack-glance07:36
*** abhishekk is now known as abhishekk|away07:48
*** jaosorior has joined #openstack-glance07:52
*** testuro has joined #openstack-glance08:07
*** e0ne has joined #openstack-glance08:11
*** dpawlik has quit IRC08:32
*** danpawlik has joined #openstack-glance08:34
*** e0ne has quit IRC08:40
*** e0ne has joined #openstack-glance08:42
*** abhishekk|away is now known as abhishekk08:43
*** e0ne has quit IRC08:54
*** e0ne has joined #openstack-glance08:54
*** c06 has left #openstack-glance08:54
*** mvk has quit IRC09:04
openstackgerritArtem Tiumentcev proposed openstack/glance-specs master: [SPEC] Add basic quotas  https://review.openstack.org/48777709:09
*** udesale has quit IRC09:14
openstackgerritArtem Tiumentcev proposed openstack/glance master: Add image quotas  https://review.openstack.org/48436109:17
openstackgerritArtem Tiumentcev proposed openstack/python-glanceclient master: Add client commands for quotas  https://review.openstack.org/48436209:24
*** c06 has joined #openstack-glance09:25
c06anyone on.??09:26
*** bhagyashris has quit IRC09:29
kairatc06, i fell your bug may be closed as invalid09:29
kairatglance do not update image containment09:30
c06y any reason09:30
kairatimage it is name in glance09:30
kairatand not related to some files in tar09:30
kairatIIUC you want some files inside tar to be updated09:31
kairatc06, do i unserstand correctly&09:31
c06kairat: yes but small change09:31
kairati think it wouldn't be small09:32
c06i didnt want the file to be updated. i am uploading one docker cirros image as updated-cirros to glance09:32
*** e0ne has quit IRC09:32
kairatso09:33
kairatwhat do you want then?09:33
c06after downloading and importing to docker, still docker is showing the image name as cirros09:33
c06not as updated-cirros(glance_image_name)09:33
kairatit requires update of tar. file, does it?09:34
kairatat the current moment name of glance image and docker image are not related, iirc, sorry09:35
c06yes that one i downloaded from glance09:35
kairatglance just stores bytes under some name09:35
kairatand return bytes under some name09:36
c06oops09:36
c06if you want i can make some steps to elaborate the issue09:36
c06just it will take 5 mins09:37
*** e0ne has joined #openstack-glance09:37
*** mvk has joined #openstack-glance09:44
c06kairat: http://paste.openstack.org/show/616681/09:45
c06hope it will give some idea regarding the issue09:50
*** masber has quit IRC09:55
c06kairat: does it valid or not.?10:08
kairatso imagine you uploaded file to google disk10:09
kairatand changed name in google disk10:09
kairatdo you expect some file content to be changed?10:09
kairati understand what you want and there were some features that potentially can support your cases10:10
kairatnut none of them are stable iiuc10:10
c06kairat: reasonable example10:11
c06no issue i will simply try10:11
kairatyou can try to look into image import refactoring10:12
kairator tasks(which are deprecated and may be deleted soon)10:12
kairathth10:12
c06refactoring also they will depercate.? or only tasks10:13
*** udesale has joined #openstack-glance10:17
openstackgerritMerged openstack/glance master: Updated from global requirements  https://review.openstack.org/48746210:19
*** abhishekk has quit IRC10:36
*** abhishekk has joined #openstack-glance10:47
*** smatzek has joined #openstack-glance10:57
*** testuro has quit IRC11:14
*** rosmaita has joined #openstack-glance11:16
*** namnh has quit IRC11:20
kairatc06, no11:30
kairatrefactoring won't11:30
kairatbut i am not an expert in this feature11:30
kairattbh11:30
c06ok ty kairat .. :) i will check that one..11:31
kairatyou re welcome11:31
c06atleast you responded ty dude.. :)11:31
c06gave some idea and i am cleared ty .:)11:31
*** pdeore_ has joined #openstack-glance11:54
*** pdeore has quit IRC11:56
*** jokke_ has joined #openstack-glance11:58
*** catintheroof has joined #openstack-glance12:11
*** abhishekk has quit IRC12:20
*** bhagyashris has joined #openstack-glance12:22
jokke_mfedosin, flaper87, rosmaita: if you have any cycles we have 3 patches still pending before requesting the client release. Listed in the meeting agenda12:27
jokke_Also anything we _must_ get in before requesting P-3 for glance?12:27
rosmaitai don't think so ... your /info router change was merged yesterday, i think?12:29
jokke_yes12:29
rosmaitaoh, there was the wsgi release note12:30
rosmaitahttps://review.openstack.org/#/c/485913/12:30
jokke_that, yes lets deal with that12:31
*** c06 has left #openstack-glance12:47
*** pdeore__ has joined #openstack-glance12:49
*** pdeore_ has quit IRC12:51
*** links has quit IRC12:52
openstackgerritErno Kuvaja proposed openstack/python-glanceclient master: Add image import features to client  https://review.openstack.org/48663012:54
*** ratailor has quit IRC12:56
*** ratailor has joined #openstack-glance12:56
*** ratailor has quit IRC12:57
*** gcb has quit IRC13:02
*** leni1 has joined #openstack-glance13:02
*** lucasxu has joined #openstack-glance13:03
*** gcb has joined #openstack-glance13:04
openstackgerritErno Kuvaja proposed openstack/python-glanceclient master: Add image import features to client  https://review.openstack.org/48663013:10
*** abhishekk has joined #openstack-glance13:37
*** jdillaman has quit IRC13:38
*** efried_zzz is now known as efried13:40
openstackgerritBrian Rosmaita proposed openstack/python-glanceclient master: Add release note for Pike  https://review.openstack.org/48726913:44
*** pdeore__ has quit IRC13:49
*** mtanino_ has joined #openstack-glance13:49
*** leni1 has left #openstack-glance13:49
*** udesale has quit IRC13:55
rosmaitaCourtesy meeting reminder on #openstack-meeting-4: ativelkov, cpallares, flaper87, flwang1, hemanthm, jokke_, kragniz, lakshmiS, mclaren, mfedosin, nikhil_k, Nikolay_St, Olena, pennerc, rosmaita, sigmavirus24, sabari, TravT, ajayaa, GB21, bpoulos, harshs, abhishekk, bunting, dshakhray, wxy, dhellmann, kairat, aavraham, alex_bash, smcginnis13:59
*** mvk has quit IRC14:06
*** aavraham has quit IRC14:17
*** aavraham has joined #openstack-glance14:18
*** lucasxu has quit IRC14:30
*** lucasxu has joined #openstack-glance14:32
*** tshefi has quit IRC14:55
*** abhishekk has quit IRC14:56
*** lucasxu has quit IRC14:59
*** lucasxu has joined #openstack-glance15:02
*** rcernin has quit IRC15:03
*** links has joined #openstack-glance15:04
*** links has quit IRC15:07
openstackgerritMerged openstack/glance master: Add release note for wsgi containerization  https://review.openstack.org/48591315:08
*** gyee has joined #openstack-glance15:35
*** aavraham has left #openstack-glance15:41
openstackgerritErno Kuvaja proposed openstack/python-glanceclient master: Add missing docstring  https://review.openstack.org/48791115:45
*** e0ne has quit IRC15:47
openstackgerritBrian Rosmaita proposed openstack/python-glanceclient master: Add documentation for image import commands  https://review.openstack.org/48791315:50
openstackgerritBrian Rosmaita proposed openstack/python-glanceclient master: Add documentation for image import commands  https://review.openstack.org/48791315:52
openstackgerritBrian Rosmaita proposed openstack/python-glanceclient master: Add release note for Pike  https://review.openstack.org/48726916:03
*** lucasxu has quit IRC16:06
openstackgerritBrian Rosmaita proposed openstack/python-glanceclient master: Add documentation for image import commands  https://review.openstack.org/48791316:08
openstackgerritMerged openstack/python-glanceclient master: Update glanceclient version ref  https://review.openstack.org/48682416:08
*** abhishekk has joined #openstack-glance16:14
openstackgerritCyril Roelandt proposed openstack/glance master: Add a default rootwrap.conf file.  https://review.openstack.org/48524416:54
*** hyakuhei has quit IRC17:02
*** hyakuhei has joined #openstack-glance17:02
*** hyakuhei has quit IRC17:02
*** hyakuhei has joined #openstack-glance17:02
openstackgerritErno Kuvaja proposed openstack/python-glanceclient master: Add image import features to client  https://review.openstack.org/48663017:06
*** harlowja has joined #openstack-glance17:09
*** mvk has joined #openstack-glance17:13
*** rcernin has joined #openstack-glance17:16
*** groen692 has quit IRC17:23
jokke_abhishekk, rosmaita: ok lets continue here17:31
abhishekkhi17:31
rosmaitahello17:32
rosmaitalooks like abhishekk found a problem in the client import stuff17:33
abhishekkyes17:33
abhishekkIMO these changes required, http://paste.openstack.org/show/616758/17:34
abhishekkfor example right now, https://review.openstack.org/#/c/486630/9/glanceclient/v2/images.py@239 returns resp, body but https://github.com/openstack/python-glanceclient/blob/master/glanceclient/common/utils.py#L482 requires body, resp17:35
rosmaitai'm kind of crippled atm by lack of test environment17:36
rosmaitawhich is not a very helpful comment17:36
rosmaitaif it's not too big a change, let's do it17:37
rosmaitai think it's getting pretty late where abhishekk is17:38
abhishekknot a issue, I will be still around17:38
abhishekk:)17:38
jokke_I have the change ready17:41
jokke_what a C*nty way of doing that wrapper17:41
rosmaitawell, i must admit, in glance everything is wrapped into something, and some wrappings make more sense than otehrs17:42
openstackgerritErno Kuvaja proposed openstack/python-glanceclient master: Add image import features to client  https://review.openstack.org/48663017:43
openstackgerritErno Kuvaja proposed openstack/python-glanceclient master: Add missing docstring  https://review.openstack.org/48791117:43
abhishekkunfortunately that wrapper was added by me after discussion with crossproject team :(17:43
abhishekksorry for that17:44
rosmaita:)17:44
rosmaitayou were definitely the right person to be reviewing this code, then!17:45
jokke_there is nothing wrong with wrappers, but expecting the returns in wrong order and just swapping them around everywhere instead of dealing with it inside the wrapper is bit of @~£$%&^*$^$17:45
jokke_;)17:45
jokke_abhishekk: _and_ the blame is not on you, it's on Ravi :P17:46
abhishekkjokke_: :D17:46
jokke_git blame at least17:46
abhishekkjokke_: should I publish the edit on the patch?17:46
jokke_abhishekk: which one?17:47
jokke_did i mess up something else there?17:48
abhishekk https://review.openstack.org/48663017:48
abhishekkon this one17:48
abhishekkyes17:48
jokke_abhishekk: ahh17:48
abhishekkinstead of return (resp,body), resp just return body, resp for import-info and image-import17:49
abhishekkin stage method you are calling upload so just return self.uplpad will be fine as upload is already returning (resp,body), resp17:50
jokke_ohh17:50
jokke_actually don't let me do the change so you can approve it :P17:51
abhishekkand in shell.py https://review.openstack.org/#/c/486630/9..10/glanceclient/v2/shell.py@322 requires do_import_info(gc, args)17:51
abhishekkhttps://review.openstack.org/#/c/486630/10/glanceclient/v2/shell.py@834 in _get_import_info, just add return gc.images.get_import_info()17:52
jokke_why?17:53
jokke_is there any reason why we want that response up to the do_* ?17:54
abhishekkno17:55
abhishekkbut now we are just returning RequestIdProxy object and not a tuple17:56
openstackgerritErno Kuvaja proposed openstack/python-glanceclient master: Add image import features to client  https://review.openstack.org/48663017:56
openstackgerritErno Kuvaja proposed openstack/python-glanceclient master: Add missing docstring  https://review.openstack.org/48791117:56
abhishekkif you do body, resp = gc.images.get_import_info() it will say need one or more values to unpack17:57
abhishekkhttps://github.com/openstack/python-glanceclient/blob/master/glanceclient/common/utils.py#L545, it just returning single value and not tuple17:58
abhishekksorry for the trouble17:59
jokke_so the images.get_import_info should have returned (body, resp), resp18:00
abhishekkeven that should have worked but that is not as per design18:00
abhishekkif we are expecting a return then that should be wrapped with response in a wrapper18:01
jokke_hmm-m so the print_dict won't work because te return is wrapper object not a dict18:01
abhishekkand if nothing was returned for example in case of delete earlier nothing was returned so it is decided to return tuple  with response18:02
abhishekkno if you do the change what i suggested now then print_dict will work18:03
jokke_so need to usewill it work if I throw that whole _get_import_info out?18:04
jokke_will it work if I throw that whole _get_import_info out?18:04
abhishekkhttp://wrapt.readthedocs.io/en/latest/wrappers.html#object-proxy18:04
jokke_yes, it should ... so lets forget tht whole function then as it just became useless18:05
abhishekkyes then you should call gc.images.get_import_info() whereever required18:06
openstackgerritErno Kuvaja proposed openstack/python-glanceclient master: Add image import features to client  https://review.openstack.org/48663018:07
smcginnisWhat's the reason for changing images.py to add temporary variables?18:09
smcginnisOh, nevermind. I see now.18:09
abhishekksounds good now18:10
jokke_smcginnis: took me about an hour to understand ;)18:11
jokke_and 15 revs18:11
smcginnisjokke_: Hah! :)18:11
abhishekkthank you for bearing with me18:12
jokke_abhishekk: nonono, thank you18:12
abhishekkhow much time is left for release?18:12
rosmaitathat's some good reviewing, abhishekk18:12
abhishekkthank you18:13
jokke_abhishekk: quess who will be my trusted client reviewer from now on ... and all the bugs assignee ;)18:13
abhishekk:D18:14
smcginnisGate queue looks like it's taking a little over 2 hours right now. So better not wait too much longer.18:18
jokke_abhishekk: you still around?18:32
abhishekkyes18:32
jokke_left you the honours for +A the relnotes and documentations18:33
rosmaitathose are the only two patches outstanding18:33
rosmaitawe're closing in on a release!18:34
abhishekkok18:34
rosmaitajokke_: will you have time to put the release patch together, or do you want me to do it?18:34
jokke_I'll do it once those has merged18:35
jokke_it's not like I have life anyways :P18:36
abhishekkmy connection is breaking in between its taking lots of time to load the patch18:37
jokke_I can ninja them if it's easier for you18:38
abhishekkjokke_: please do the needful18:39
jokke_ok, then we just wait the gate to finish and request tag :D18:40
jokke_Thanks guys!18:40
rosmaitathanks everyone!18:40
jokke_I feel almost like ready to start my holidays18:41
*** rosmaita has quit IRC18:42
*** abhishekk is now known as abhishekk|away19:00
openstackgerritOpenStack Proposal Bot proposed openstack/glance_store master: Updated from global requirements  https://review.openstack.org/48799619:09
*** abhishekk|away has quit IRC19:27
*** nicolasbock has quit IRC19:48
*** e0ne has joined #openstack-glance19:51
openstackgerritMerged openstack/python-glanceclient master: Add release note for Pike  https://review.openstack.org/48726920:12
openstackgerritOpenStack Proposal Bot proposed openstack/python-glanceclient master: Updated from global requirements  https://review.openstack.org/48811420:14
*** smatzek has quit IRC20:15
*** e0ne has quit IRC20:17
openstackgerritOpenStack Proposal Bot proposed openstack/glance master: Updated from global requirements  https://review.openstack.org/48799520:21
openstackgerritOpenStack Proposal Bot proposed openstack/glance_store master: Updated from global requirements  https://review.openstack.org/48799620:21
openstackgerritOpenStack Proposal Bot proposed openstack/python-glanceclient master: Updated from global requirements  https://review.openstack.org/48811420:32
*** rajathagasthya has joined #openstack-glance21:02
openstackgerritMerged openstack/python-glanceclient master: Add image import features to client  https://review.openstack.org/48663021:04
openstackgerritOpenStack Proposal Bot proposed openstack/python-glanceclient master: Updated from global requirements  https://review.openstack.org/48811421:07
openstackgerritBrian Rosmaita proposed openstack/python-glanceclient master: Add missing docstring  https://review.openstack.org/48791121:09
*** rosmaita has joined #openstack-glance21:10
*** e0ne has joined #openstack-glance21:37
*** mtanino_ has quit IRC22:06
*** e0ne has quit IRC22:09
*** rcernin has quit IRC22:26
*** catintheroof has quit IRC22:27
*** dalgaaf has quit IRC22:30
*** dalgaaf has joined #openstack-glance22:30
*** openstack has joined #openstack-glance22:42
*** fnordahl has quit IRC22:42
*** fnordahl_ has joined #openstack-glance22:42
*** hemanthm has joined #openstack-glance22:42
*** Daviey_ has quit IRC22:42
*** jmccrory has quit IRC22:42
*** hemanthm_ has quit IRC22:42
*** jmccrory has joined #openstack-glance22:43
*** oomichi has quit IRC22:45
*** oomichi has joined #openstack-glance22:47
*** aavraham has joined #openstack-glance22:53
*** rosmaita has left #openstack-glance22:58
*** aavraham has quit IRC23:34
openstackgerritMerged openstack/python-glanceclient master: Add missing docstring  https://review.openstack.org/48791123:38
*** catintheroof has joined #openstack-glance23:52
*** rajathagasthya has quit IRC23:57
openstackgerritOpenStack Proposal Bot proposed openstack/python-glanceclient master: Updated from global requirements  https://review.openstack.org/48811423:58

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!