| *** gatuus has joined #openstack-glance | 00:02 | |
| openstackgerrit | John Perkins proposed openstack/glance: Integrate oslo.config validator https://review.openstack.org/426980 | 00:10 |
|---|---|---|
| openstackgerrit | John Perkins proposed openstack/glance: Integrate oslo.config validator https://review.openstack.org/426980 | 00:28 |
| *** mtanino_ has joined #openstack-glance | 00:29 | |
| *** jose-phillips has quit IRC | 00:29 | |
| *** jose-phillips has joined #openstack-glance | 00:30 | |
| *** mtanino has quit IRC | 00:30 | |
| *** haplo37 has quit IRC | 00:32 | |
| *** haplo37 has joined #openstack-glance | 00:33 | |
| stevelle | johndperkins: depending on your dev environment, it can be tricky to get everything to run right | 00:52 |
| openstackgerrit | Hemanth Makkapati proposed openstack/glance: Add expand/migrate/contract commands to glance-manage CLI https://review.openstack.org/392993 | 00:54 |
| *** jamielennox is now known as jamielennox|away | 00:58 | |
| *** catintheroof has quit IRC | 01:02 | |
| *** gatuus has quit IRC | 01:07 | |
| *** jamielennox|away is now known as jamielennox | 01:12 | |
| openstackgerrit | Shinya Kawabata proposed openstack/glance: Fix rendering of list elements https://review.openstack.org/423880 | 01:21 |
| *** ducttape_ has joined #openstack-glance | 01:22 | |
| johndperkins | stevelle: okay thanks | 01:27 |
| *** TravT has quit IRC | 01:32 | |
| *** dims has quit IRC | 01:35 | |
| *** dims_ has joined #openstack-glance | 01:35 | |
| *** catintheroof has joined #openstack-glance | 01:37 | |
| *** catintheroof has quit IRC | 01:37 | |
| *** catintheroof has joined #openstack-glance | 01:37 | |
| *** dims_ has quit IRC | 01:42 | |
| *** dims has joined #openstack-glance | 01:42 | |
| *** newmember has joined #openstack-glance | 01:45 | |
| *** ducttape_ has quit IRC | 02:06 | |
| *** mtanino has joined #openstack-glance | 02:17 | |
| *** mtanino_ has quit IRC | 02:19 | |
| *** ducttape_ has joined #openstack-glance | 02:33 | |
| *** mtanino has quit IRC | 02:34 | |
| *** newmember has quit IRC | 03:05 | |
| *** newmember has joined #openstack-glance | 03:05 | |
| *** catintheroof has quit IRC | 03:09 | |
| *** catintheroof has joined #openstack-glance | 03:11 | |
| *** zzzeek has quit IRC | 03:13 | |
| *** zzzeek has joined #openstack-glance | 03:15 | |
| *** catintheroof has quit IRC | 03:15 | |
| *** ducttape_ has quit IRC | 03:23 | |
| *** bkopilov has quit IRC | 03:24 | |
| *** mtanino has joined #openstack-glance | 03:35 | |
| *** nicolasbock has quit IRC | 03:50 | |
| *** newmember has quit IRC | 03:55 | |
| *** newmember has joined #openstack-glance | 03:56 | |
| openstackgerrit | Hemanth Makkapati proposed openstack/glance: Add expand/migrate/contract migrations for CI https://review.openstack.org/424774 | 04:00 |
| *** ducttape_ has joined #openstack-glance | 04:13 | |
| *** flwang1 has quit IRC | 04:19 | |
| *** mtanino has quit IRC | 04:19 | |
| *** jose-phillips has quit IRC | 04:19 | |
| *** ducttape_ has quit IRC | 04:33 | |
| *** adisky_ has joined #openstack-glance | 04:38 | |
| *** bkopilov has joined #openstack-glance | 04:47 | |
| *** udesale has joined #openstack-glance | 04:48 | |
| *** ratailor has joined #openstack-glance | 05:01 | |
| *** pdeore has joined #openstack-glance | 05:12 | |
| *** tshefi has joined #openstack-glance | 05:22 | |
| *** tshefi has quit IRC | 05:26 | |
| *** tshefi has joined #openstack-glance | 05:27 | |
| *** ducttape_ has joined #openstack-glance | 05:35 | |
| *** ducttape_ has quit IRC | 05:41 | |
| *** jose-phillips has joined #openstack-glance | 05:42 | |
| *** udesale__ has joined #openstack-glance | 05:51 | |
| *** udesale has quit IRC | 05:54 | |
| *** udesale__ has quit IRC | 06:34 | |
| *** udesale has joined #openstack-glance | 06:34 | |
| openstackgerrit | Bhagyashri Shewale proposed openstack/python-glanceclient: Replace functions 'dict.get' and 'del' with 'dict.pop' https://review.openstack.org/361851 | 06:36 |
| *** groen692 has joined #openstack-glance | 06:54 | |
| *** mosulica has joined #openstack-glance | 07:06 | |
| *** ducttape_ has joined #openstack-glance | 07:06 | |
| *** ducttape_ has quit IRC | 07:11 | |
| *** rcernin has joined #openstack-glance | 07:12 | |
| *** gb21 has joined #openstack-glance | 07:38 | |
| *** pdeore__ has joined #openstack-glance | 07:39 | |
| *** pdeore has quit IRC | 07:41 | |
| *** tesseract has joined #openstack-glance | 07:54 | |
| *** udesale__ has joined #openstack-glance | 08:06 | |
| *** udesale has quit IRC | 08:08 | |
| *** newmember has quit IRC | 08:27 | |
| openstackgerrit | Béla Vancsics proposed openstack/glance: Reduce code duplication https://review.openstack.org/427057 | 08:32 |
| openstackgerrit | Merged openstack/glance: Update api-ref for image visibility changes https://review.openstack.org/426603 | 08:35 |
| *** zzzeek has quit IRC | 09:00 | |
| *** zzzeek has joined #openstack-glance | 09:01 | |
| *** udesale has joined #openstack-glance | 09:09 | |
| *** udesale__ has quit IRC | 09:10 | |
| *** e0ne has joined #openstack-glance | 09:14 | |
| *** groen692 has quit IRC | 09:14 | |
| *** groen692 has joined #openstack-glance | 09:14 | |
| *** mvk has quit IRC | 09:24 | |
| openstackgerrit | Merged openstack/glance: refactor glare plugin loader tests to not mock private methods of stevedore https://review.openstack.org/426789 | 09:25 |
| openstackgerrit | Merged openstack/glance: Add release note for image visibility changes https://review.openstack.org/422897 | 09:26 |
| *** udesale__ has joined #openstack-glance | 09:32 | |
| *** udesale has quit IRC | 09:34 | |
| *** gb21 has quit IRC | 09:35 | |
| *** udesale__ has quit IRC | 09:48 | |
| *** gcb has joined #openstack-glance | 09:52 | |
| *** mvk has joined #openstack-glance | 09:55 | |
| openstackgerrit | Béla Vancsics proposed openstack/glance: Reduce code duplication https://review.openstack.org/427057 | 09:58 |
| *** ducttape_ has joined #openstack-glance | 10:07 | |
| *** bhagyashris has joined #openstack-glance | 10:12 | |
| *** ducttape_ has quit IRC | 10:12 | |
| *** dalgaaf has quit IRC | 10:49 | |
| *** dalgaaf has joined #openstack-glance | 10:51 | |
| *** mvk has quit IRC | 11:10 | |
| *** nicolasbock has joined #openstack-glance | 11:16 | |
| *** mvk has joined #openstack-glance | 11:23 | |
| *** newmember has joined #openstack-glance | 11:24 | |
| *** adisky_ has quit IRC | 11:29 | |
| *** newmember has quit IRC | 11:30 | |
| *** ducttape_ has joined #openstack-glance | 11:38 | |
| *** ducttape_ has quit IRC | 11:43 | |
| *** gb21 has joined #openstack-glance | 11:49 | |
| *** mfedosin has joined #openstack-glance | 11:52 | |
| *** ratailor has quit IRC | 12:01 | |
| *** udesale has joined #openstack-glance | 12:01 | |
| *** nicolasbock has quit IRC | 12:06 | |
| *** bkopilov has quit IRC | 12:11 | |
| *** catintheroof has joined #openstack-glance | 12:22 | |
| *** nicolasbock has joined #openstack-glance | 12:23 | |
| *** gb21 has quit IRC | 12:48 | |
| *** udesale has quit IRC | 13:02 | |
| *** udesale has joined #openstack-glance | 13:03 | |
| *** groen692 has quit IRC | 13:03 | |
| *** ducttape_ has joined #openstack-glance | 13:06 | |
| *** groen692 has joined #openstack-glance | 13:10 | |
| *** pdeore__ has quit IRC | 13:11 | |
| *** groen692 has quit IRC | 13:21 | |
| *** ducttape_ has quit IRC | 13:28 | |
| *** pdeore has joined #openstack-glance | 13:35 | |
| *** catinthe_ has joined #openstack-glance | 13:36 | |
| *** groen692 has joined #openstack-glance | 13:38 | |
| *** catintheroof has quit IRC | 13:40 | |
| *** cburgess has quit IRC | 13:48 | |
| *** cburgess has joined #openstack-glance | 13:49 | |
| *** fnordahl has quit IRC | 13:51 | |
| *** fnordahl has joined #openstack-glance | 13:51 | |
| *** fnordahl has quit IRC | 13:55 | |
| *** fnordahl has joined #openstack-glance | 13:55 | |
| openstackgerrit | Brian Rosmaita proposed openstack/glance: Correct 2.5 minor version bump release note https://review.openstack.org/427225 | 14:23 |
| *** gcb has quit IRC | 14:24 | |
| *** ducttape_ has joined #openstack-glance | 14:27 | |
| *** ducttape_ has quit IRC | 14:31 | |
| *** mtanino has joined #openstack-glance | 14:45 | |
| *** vkmc has quit IRC | 14:47 | |
| *** vkmc has joined #openstack-glance | 14:52 | |
| sigmavirus | johndperkins: did you follow our dev ref setup docs? | 14:56 |
| sigmavirus | rosmaita: stevelle hemanthm dharinic nikhil, reminder that we have two days to get rolling upgrades merged | 14:58 |
| sigmavirus | Given the time to get through the gate, that means we need it all approved within the next day | 14:58 |
| sigmavirus | That, or we push it off until P-1 | 14:58 |
| hemanthm | sigmavirus: ack | 14:59 |
| sigmavirus | Personally, I don't like rushing y'all into getting something approved within the next day, but, y'all really seem committed to having it in for Ocata | 14:59 |
| sigmavirus | Also, keep in mind, that our stable branch core reviewer size seems to be pretty much just me | 14:59 |
| sigmavirus | IOW, if rolling upgrades is rushed in, is found to be broken, and we start backporting fixes, I alone will not be able to approve them | 15:00 |
| hemanthm | Makes sense | 15:01 |
| hemanthm | The first two patches in a 4 patch review chain have one +2 | 15:02 |
| hemanthm | I don't where the 2nd +2 is going to come from | 15:02 |
| sigmavirus | Did the cores who committed to reviewing this all contribute? | 15:02 |
| sigmavirus | Or did they disappear? | 15:02 |
| rosmaita | i didnt' contribute, so i should be able to review | 15:03 |
| *** bkopilov has joined #openstack-glance | 15:03 | |
| *** burgerk has quit IRC | 15:06 | |
| hemanthm | sigmavirus: What you said about backporting makes sense. Even if rolling upgrades manage to get in, they'll probably be marked experimental | 15:09 |
| hemanthm | The regular cold upgrade would still be the default upgrade path | 15:10 |
| hemanthm | just FYI | 15:10 |
| *** cdelatte has joined #openstack-glance | 15:14 | |
| *** pdeore has quit IRC | 15:16 | |
| sigmavirus | Right, all I meant was that any backports made before the final Ocata release would be acceptable for experimental feature stability, but not after, but even so I'm the only person who seems to be actively reviewing stable backports | 15:18 |
| sigmavirus | which we need to fix | 15:18 |
| *** burgerk has joined #openstack-glance | 15:26 | |
| *** gatuus has joined #openstack-glance | 15:27 | |
| *** mfedosin has quit IRC | 15:29 | |
| *** udesale has quit IRC | 15:35 | |
| *** mtanino_ has joined #openstack-glance | 15:39 | |
| *** mtanino has quit IRC | 15:40 | |
| *** catinthe_ has quit IRC | 15:45 | |
| *** TravT has joined #openstack-glance | 15:46 | |
| *** ducttape_ has joined #openstack-glance | 16:03 | |
| *** rcernin has quit IRC | 16:04 | |
| dharinic | sigmavirus: I had +1'd patches 1 and 2 due to incomplete manual testing from my end. Would be able to upgrade my vote after i do that. Code wise, it looks clean, great to me. Both patches 1 and 2 | 16:06 |
| sigmavirus | dharinic: did you contribute anything to those patches? | 16:07 |
| dharinic | Nope sigmavirus. I did not code contribute to those 2 patches | 16:07 |
| sigmavirus | If so, it would be better you don't approve the patches (simply +2 them) and wait for rosmaita to finish his review to approve them | 16:07 |
| sigmavirus | Okay | 16:07 |
| dharinic | Patches 3 and 4, stevelle and I were reviewing yesterday. They are almost there. | 16:08 |
| nikhil | sigmavirus: ack | 16:15 |
| sigmavirus | nikhil: if you have time to help review those priorities that would be wonderful | 16:16 |
| nikhil | sigmavirus: also, please feel free to ping me about any stuck stable backports (now or later) | 16:16 |
| sigmavirus | nikhil: oh, well | 16:16 |
| sigmavirus | In that case | 16:16 |
| *** d0ugal has quit IRC | 16:16 | |
| sigmavirus | nikhil: https://review.openstack.org/#/c/410535/ | 16:17 |
| sigmavirus | nikhil: https://review.openstack.org/#/c/396620/ | 16:17 |
| *** d0ugal has joined #openstack-glance | 16:17 | |
| *** d0ugal has quit IRC | 16:17 | |
| *** d0ugal has joined #openstack-glance | 16:17 | |
| *** ducttape_ has quit IRC | 16:19 | |
| *** ducttape_ has joined #openstack-glance | 16:19 | |
| nikhil | sigmavirus: oh I just did that and was gunna link it to you :) | 16:20 |
| nikhil | sigmavirus: any one of this likely https://review.openstack.org/#/q/status:open+project:openstack/glance_store+branch:stable/newton ? | 16:21 |
| *** mosulica has quit IRC | 16:22 | |
| sigmavirus | the three newest I haven't reviewed nikhil | 16:25 |
| sigmavirus | I'm killing bugs right now, but I'll look afterwards | 16:25 |
| sigmavirus | If you want to check those out, we could probably cut a release of stable/newton in a couple weeks | 16:25 |
| sigmavirus | (Fyi, we're under 100 open bugs for python-glanceclient now) | 16:26 |
| *** newmember has joined #openstack-glance | 16:26 | |
| nikhil | dearness | 16:27 |
| nikhil | sigmavirus: will check'em out | 16:27 |
| *** _ducttape_ has joined #openstack-glance | 16:29 | |
| openstackgerrit | Brian Rosmaita proposed openstack/glance: Correct 2.5 minor version bump release note https://review.openstack.org/427225 | 16:29 |
| *** ducttape_ has quit IRC | 16:32 | |
| nikhil | sigmavirus: easy breezy https://review.openstack.org/#/c/401961/ | 16:38 |
| *** _ducttape_ has quit IRC | 16:40 | |
| *** ducttape_ has joined #openstack-glance | 16:41 | |
| *** _ducttape_ has joined #openstack-glance | 16:44 | |
| * nikhil bbiab | 16:45 | |
| *** ducttape_ has quit IRC | 16:47 | |
| *** tesseract has quit IRC | 16:56 | |
| sigmavirus | nice catch nikhil | 16:59 |
| *** e0ne has quit IRC | 17:08 | |
| *** pdeore has joined #openstack-glance | 17:31 | |
| dharinic | niikhil: Including a releasenote in backport is causing an issue. | 17:31 |
| dharinic | http://logs.openstack.org/97/417197/3/check/gate-glance_store-releasenotes/762764f/console.html#_2017-01-31_17_26_32_410319 | 17:31 |
| dharinic | https://review.openstack.org/#/c/417197/3 | 17:32 |
| *** _ducttape_ has quit IRC | 17:42 | |
| *** jose-phillips has quit IRC | 17:52 | |
| *** gatuus has quit IRC | 17:53 | |
| *** mvk has quit IRC | 17:54 | |
| *** catintheroof has joined #openstack-glance | 17:55 | |
| *** jamielennox is now known as jamielennox|away | 17:58 | |
| *** groen692 has quit IRC | 17:59 | |
| *** newmember has quit IRC | 18:10 | |
| *** johndperkins has quit IRC | 18:26 | |
| *** dharinic is now known as dharinic|lunch | 18:28 | |
| *** mvk has joined #openstack-glance | 18:28 | |
| *** ducttape_ has joined #openstack-glance | 18:28 | |
| *** ducttape_ has quit IRC | 18:33 | |
| *** pdeore has quit IRC | 18:38 | |
| *** ducttape_ has joined #openstack-glance | 18:43 | |
| openstackgerrit | Hemanth Makkapati proposed openstack/glance: Add expand/migrate/contract migrations for CI https://review.openstack.org/424774 | 18:49 |
| *** ducttape_ has quit IRC | 18:49 | |
| *** jdurgin has quit IRC | 18:51 | |
| *** ducttape_ has joined #openstack-glance | 19:00 | |
| *** ducttape_ has quit IRC | 19:00 | |
| *** ducttape_ has joined #openstack-glance | 19:01 | |
| *** _ducttape_ has joined #openstack-glance | 19:02 | |
| *** ducttape_ has quit IRC | 19:05 | |
| *** jdurgin has joined #openstack-glance | 19:10 | |
| *** dharinic|lunch is now known as dharinic | 19:11 | |
| *** _ducttape_ has quit IRC | 19:14 | |
| *** pcaruana has quit IRC | 19:31 | |
| *** mfedosin has joined #openstack-glance | 19:36 | |
| openstackgerrit | Dharini Chandrasekar proposed openstack/glance: Handling scrubber's exit in non-daemon mode. https://review.openstack.org/382711 | 19:36 |
| *** jose-phillips has joined #openstack-glance | 19:53 | |
| *** ducttape_ has joined #openstack-glance | 19:56 | |
| *** ducttape_ has quit IRC | 20:01 | |
| openstackgerrit | Dharini Chandrasekar proposed openstack/glance: Handling scrubber's exit in non-daemon mode. https://review.openstack.org/382711 | 20:06 |
| *** ducttape_ has joined #openstack-glance | 20:21 | |
| *** mtanino_ has quit IRC | 20:25 | |
| *** mfedosin has quit IRC | 20:30 | |
| *** newmember has joined #openstack-glance | 20:45 | |
| *** cdelatte has quit IRC | 20:51 | |
| *** e0ne has joined #openstack-glance | 20:54 | |
| *** _ducttape_ has joined #openstack-glance | 20:54 | |
| *** ducttape_ has quit IRC | 20:57 | |
| *** mfedosin has joined #openstack-glance | 21:02 | |
| *** newmember has quit IRC | 21:05 | |
| *** flwang1 has joined #openstack-glance | 21:05 | |
| openstackgerrit | Merged openstack/glance: Correct 2.5 minor version bump release note https://review.openstack.org/427225 | 21:13 |
| flwang | rosmaita: ping re bug https://review.openstack.org/#/c/378460/ | 21:21 |
| *** mtanino has joined #openstack-glance | 21:22 | |
| *** TravT has quit IRC | 21:24 | |
| nikhil | dharinic: can we get a merge please https://review.openstack.org/#/c/426283/ :) ? (lol I meant review) | 21:25 |
| dharinic | nikhil: looking | 21:27 |
| dharinic | nikhil: merge indeed. :) | 21:31 |
| nikhil | :) | 21:33 |
| *** TravT has joined #openstack-glance | 21:34 | |
| *** e0ne has quit IRC | 21:37 | |
| *** catintheroof has quit IRC | 21:38 | |
| *** catintheroof has joined #openstack-glance | 21:38 | |
| *** catintheroof has quit IRC | 21:39 | |
| *** e0ne has joined #openstack-glance | 21:40 | |
| *** e0ne has quit IRC | 21:42 | |
| rosmaita | flwang: sorry, was not paying attention | 21:43 |
| rosmaita | looking now | 21:43 |
| flwang | rosmaita: no problem, just want to discuss this since i saw there are people discussing this issue in operators mail list | 21:44 |
| flwang | hopefully we can merge this in Ocata | 21:44 |
| rosmaita | did you have any ideas about tests? | 21:44 |
| rosmaita | it's glance_store which is already released, it will have to be a backport and new release | 21:45 |
| *** _ducttape_ has quit IRC | 21:46 | |
| *** ducttape_ has joined #openstack-glance | 21:46 | |
| flwang | rosmaita: i would say it's hard to test, because it's a randomly issue based on the bug of ceph | 21:48 |
| flwang | i mean from glance PoV | 21:48 |
| flwang | in bug, http://tracker.ceph.com/issues/17310 | 21:49 |
| rosmaita | yeah, but i'm thinking a test to make sure that image.stat() is not called anywhere? | 21:49 |
| flwang | the originator said he can recreate the problem by a script | 21:49 |
| flwang | but i'm not really sure how to reproduce it in glance | 21:49 |
| rosmaita | well, the bug is that image.stat() is being called; we thought we had replaced all calls to image.stat() with image.size(), but we had missed one | 21:50 |
| rosmaita | so it would be good to have a test that fails if anything calls image.stat() | 21:50 |
| flwang | manually? or by unit/function test? | 21:51 |
| rosmaita | ideally by unit/functional test | 21:52 |
| rosmaita | i just want to be sure such a test would be impossible/ridiculous amount of work before giving up on it | 21:52 |
| rosmaita | because apparently a grep for 'image.stat(' missed one occurrence last time | 21:53 |
| stevelle | rosmaita: hacking check for image.stat() maybe | 21:54 |
| *** mfedosin has quit IRC | 21:54 | |
| rosmaita | stevelle: good idea ... we just want to limit it to the ceph driver in glance_store, though | 21:55 |
| flwang | stevelle: good idea | 21:55 |
| flwang | rosmaita: and as you mentioned in the patch, we do need a release note for this | 21:55 |
| stevelle | I would expect that you could limit scope of hacking checks, never done so myself | 21:55 |
| rosmaita | flwang: why don't you give stevelle 's idea a try | 21:56 |
| flwang | rosmaita: yep, i do | 21:56 |
| flwang | i'm give it a try and report it in the patch | 21:57 |
| rosmaita | yes, i think we need a release note about this fix requiring ceph to be version hammer or more recent (or whatever is appropriate) | 21:57 |
| rosmaita | flwang: sounds good, thanks | 21:57 |
| flwang | rosmaita: thanks | 21:57 |
| flwang | rosmaita: do you think have time to discuss the very oooooooooold bug? will pm you | 21:58 |
| rosmaita | ok | 21:58 |
| *** catintheroof has joined #openstack-glance | 22:05 | |
| *** catintheroof has quit IRC | 22:05 | |
| *** catintheroof has joined #openstack-glance | 22:06 | |
| *** catintheroof has quit IRC | 22:11 | |
| *** ducttape_ has quit IRC | 22:14 | |
| *** jamielennox|away is now known as jamielennox | 22:15 | |
| *** johndperkins has joined #openstack-glance | 22:19 | |
| *** tshefi has quit IRC | 22:25 | |
| *** ducttape_ has joined #openstack-glance | 22:31 | |
| *** markvoelker_ has joined #openstack-glance | 22:58 | |
| *** markvoelker has quit IRC | 22:58 | |
| *** _ducttape_ has joined #openstack-glance | 23:03 | |
| *** ducttape_ has quit IRC | 23:06 | |
| *** _ducttape_ has quit IRC | 23:29 | |
| *** ducttape_ has joined #openstack-glance | 23:30 | |
| *** ducttape_ has quit IRC | 23:35 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!