| *** rcernin has joined #openstack-glance | 00:00 | |
| *** mingyu has quit IRC | 00:01 | |
| *** harlowja has quit IRC | 00:04 | |
| *** kebray has quit IRC | 00:42 | |
| *** jose-phillips has quit IRC | 00:43 | |
| *** rcernin has quit IRC | 00:51 | |
| *** rcernin has joined #openstack-glance | 00:54 | |
| *** rcernin has quit IRC | 00:55 | |
| *** rcernin has joined #openstack-glance | 00:55 | |
| *** mtanino has quit IRC | 01:10 | |
| openstackgerrit | Dharini Chandrasekar proposed openstack/glance: Stricter checks for registry API calls https://review.openstack.org/416766 | 01:57 |
|---|---|---|
| *** kebray has joined #openstack-glance | 02:00 | |
| openstackgerrit | Merged openstack/glance: Updated from global requirements https://review.openstack.org/425669 | 02:09 |
| *** dims_ has joined #openstack-glance | 02:14 | |
| *** dims has quit IRC | 02:14 | |
| *** dims_ has quit IRC | 02:47 | |
| *** dims has joined #openstack-glance | 02:50 | |
| *** mtanino has joined #openstack-glance | 03:15 | |
| *** mtanino has quit IRC | 03:21 | |
| *** kebray has quit IRC | 03:52 | |
| *** nicolasbock has quit IRC | 04:17 | |
| *** mtreinish has quit IRC | 04:22 | |
| *** mtreinish has joined #openstack-glance | 04:22 | |
| openstackgerrit | Hemanth Makkapati proposed openstack/glance: Add expand/contract commands to glance-manage CLI. https://review.openstack.org/392993 | 04:47 |
| openstackgerrit | Hemanth Makkapati proposed openstack/glance: Add expand/contract commands to glance-manage CLI. https://review.openstack.org/392993 | 04:51 |
| *** udesale has joined #openstack-glance | 04:58 | |
| *** kebray has joined #openstack-glance | 05:01 | |
| *** adisky_ has joined #openstack-glance | 05:11 | |
| *** ratailor has joined #openstack-glance | 05:12 | |
| *** gb21 has joined #openstack-glance | 05:38 | |
| *** david-lyle has quit IRC | 05:46 | |
| *** ezoszed has joined #openstack-glance | 06:34 | |
| *** groen692 has joined #openstack-glance | 07:06 | |
| *** rcernin has quit IRC | 07:24 | |
| *** adisky_ has quit IRC | 07:29 | |
| *** mfedosin has joined #openstack-glance | 07:40 | |
| *** mfedosin has quit IRC | 08:29 | |
| *** adisky_ has joined #openstack-glance | 08:36 | |
| *** e0ne has joined #openstack-glance | 08:44 | |
| *** e0ne has quit IRC | 08:57 | |
| *** e0ne has joined #openstack-glance | 08:59 | |
| *** zzzeek has quit IRC | 09:00 | |
| *** zzzeek has joined #openstack-glance | 09:01 | |
| *** ezoszed1 has joined #openstack-glance | 09:04 | |
| *** ezoszed has quit IRC | 09:06 | |
| openstackgerrit | Merged openstack/glance: Update api-ref for partial download requests. https://review.openstack.org/425925 | 09:09 |
| *** gabor_antal has joined #openstack-glance | 09:52 | |
| gabor_antal | Hey! Can someone help me? I've watching the code and got confused | 09:53 |
| *** dalgaaf has quit IRC | 10:54 | |
| *** dalgaaf has joined #openstack-glance | 10:55 | |
| *** udesale has quit IRC | 11:01 | |
| *** mvk has quit IRC | 11:06 | |
| *** chlong has joined #openstack-glance | 11:24 | |
| *** gb21 has quit IRC | 11:43 | |
| *** smatzek has joined #openstack-glance | 11:52 | |
| *** catintheroof has joined #openstack-glance | 12:04 | |
| *** mvk has joined #openstack-glance | 12:04 | |
| *** nicolasbock has joined #openstack-glance | 12:04 | |
| *** ratailor has quit IRC | 13:03 | |
| *** catintheroof has quit IRC | 13:05 | |
| sigmavirus | gabor_antal: watching what code? Glance? Has it become sentient? | 13:13 |
| *** catintheroof has joined #openstack-glance | 13:16 | |
| dims | LOL good one sigmavirus | 13:46 |
| sigmavirus | dims: I tend to be slightly ... not so serious ... before the caffeine has fully sunk in | 13:47 |
| *** ratailor has joined #openstack-glance | 14:09 | |
| *** ratailor has quit IRC | 14:11 | |
| *** markvoelker has joined #openstack-glance | 14:16 | |
| *** takedakn has joined #openstack-glance | 14:28 | |
| *** Dinesh_Bhor has quit IRC | 14:37 | |
| *** gb21 has joined #openstack-glance | 14:44 | |
| *** takedakn has quit IRC | 15:07 | |
| *** TravT has joined #openstack-glance | 15:07 | |
| gabor_antal | lol, no | 15:16 |
| *** mtanino has joined #openstack-glance | 15:16 | |
| sigmavirus | Hey gabor_antal what's up? | 15:22 |
| gabor_antal | Just some random thing | 15:22 |
| gabor_antal | https://github.com/openstack/glance/blob/master/glance/api/v2/metadef_tags.py#L242 | 15:22 |
| gabor_antal | https://github.com/openstack/glance/blob/master/glance/api/v2/metadef_tags.py#L255 | 15:22 |
| gabor_antal | Why they are using base_definitions method which simply returns None? | 15:23 |
| gabor_antal | They arent in a class or so, so this None must be None (so they are not overridden in child) | 15:24 |
| *** bhagyashris has quit IRC | 15:24 | |
| sigmavirus | gabor_antal: that's an excellent question | 15:24 |
| sigmavirus | Sadly I think all of our metadef experts (the folks who wrote that code) no longer work on openstack | 15:24 |
| gabor_antal | :( | 15:24 |
| sigmavirus | gabor_antal: is that causing problems for you? | 15:25 |
| gabor_antal | I thought for the first time, that it will be improved in the future, but this was merged 2 yes ago | 15:25 |
| gabor_antal | for me? not really. I just checked our Sonar analyzer and found these weird thing. | 15:26 |
| gabor_antal | Maybe I can upload a patch, which modifies them to None | 15:26 |
| sigmavirus | gabor_antal: what is "them" in your last message? | 15:26 |
| gabor_antal | There are 2 methods, which uses the _get_base_definitions(), but obviously, both of them are None, so we can change these occurences (along with definitions variable, which can be None in the method call) | 15:28 |
| gabor_antal | and also remove this simple method which literally just returns None | 15:28 |
| gabor_antal | sigmavirus: how do you think about that? | 15:29 |
| sigmavirus | gabor_antal: I think that's an change which has a negative improvement value | 15:30 |
| gabor_antal | why do you think? | 15:30 |
| gabor_antal | sry, why do you think that this is a negative improvement? | 15:30 |
| *** gb21 has quit IRC | 15:30 | |
| sigmavirus | gabor_antal: so right now, it indicates that those two functions should be using the same definitions (even if that function returns None) | 15:32 |
| sigmavirus | If you replace those function calls with None, you lose that clarity | 15:32 |
| sigmavirus | Further, you modify the file and those lines which gives the appearance of the code being maintained, which it's not | 15:33 |
| sigmavirus | It's being trivially updated with very little value | 15:33 |
| sigmavirus | So the change not only masks an area for future improvement and obfuscates the code, it also makes it appear that this was a valuable and necessary change | 15:33 |
| gabor_antal | Yeah, but it was last updated 2 years ago, so scarcely will be updated in the near. Whoever wanted to work on this, he has other things, or left. So it's basically just a useless complication which always (and always will be) None. Removing this would improve readibility as the code will be clearer, as a useless method disappears. | 15:37 |
| gabor_antal | However, you are also right on this. So probably I just let it the way it was. | 15:37 |
| sigmavirus | gabor_antal: I'm not sure it improves readability | 15:40 |
| sigmavirus | It definitely doesn't improve the understanding that both functions need the same definitions if you remove the function | 15:40 |
| gabor_antal | Yeah I understand your point too | 15:40 |
| sigmavirus | Ideally someone will come along and create those definitions and replace "None" with the definition(s) | 15:41 |
| gabor_antal | Yeah, that's right | 15:46 |
| *** kebray has quit IRC | 15:48 | |
| openstackgerrit | Brian Rosmaita proposed openstack/glance: Update deprecated show_multiple_locations helptext https://review.openstack.org/426283 | 15:54 |
| rosmaita | sigmavirus: ^^ need your opinion on the above (it's a one word change, basically) | 15:55 |
| sigmavirus | I think we should refer them to real docs rather than newton relnotes | 15:57 |
| sigmavirus | but that's orthogonal | 15:57 |
| rosmaita | that would be nice if such docs existed | 15:57 |
| rosmaita | :) | 15:57 |
| rosmaita | we need a section of documentation headed "Here there be dragons" and put the dangerous stuff in there | 15:58 |
| *** mvk has quit IRC | 15:58 | |
| rosmaita | while i'm wishing for stuff, it would be nice to have someone really interested in docs work with glance for a cycle to reorganize and write some missing documentation | 16:00 |
| rosmaita | though actually, a lot of the help text for config options stuff that dharinic and hemanthm did in Newton has documented how to use most of the config options | 16:01 |
| *** kebray has joined #openstack-glance | 16:10 | |
| *** groen692 has quit IRC | 16:20 | |
| *** burgerk has joined #openstack-glance | 16:21 | |
| *** groen692 has joined #openstack-glance | 16:23 | |
| *** david-lyle has joined #openstack-glance | 16:29 | |
| *** e0ne has quit IRC | 16:31 | |
| *** thiagolib has joined #openstack-glance | 16:34 | |
| *** groen692 has quit IRC | 17:02 | |
| *** harlowja has joined #openstack-glance | 18:02 | |
| *** chlong has quit IRC | 18:03 | |
| *** jose-phillips has joined #openstack-glance | 18:07 | |
| *** mvk has joined #openstack-glance | 18:16 | |
| openstackgerrit | Nikhil Komawar proposed openstack/glance: Update deprecated show_multiple_locations helptext https://review.openstack.org/426283 | 18:25 |
| *** jose-phillips has quit IRC | 18:26 | |
| openstackgerrit | Nikhil Komawar proposed openstack/glance: Update deprecated show_multiple_locations helptext https://review.openstack.org/426283 | 18:27 |
| *** david-lyle has quit IRC | 18:39 | |
| *** kebray has quit IRC | 18:42 | |
| *** dharinic is now known as dharinic|lunch | 18:42 | |
| *** dharinic|lunch is now known as dharinic | 19:27 | |
| openstackgerrit | Nikhil Komawar proposed openstack/glance: Update deprecated show_multiple_locations helptext https://review.openstack.org/426283 | 19:29 |
| openstackgerrit | Brian Rosmaita proposed openstack/glance: Add release note for image visibility changes https://review.openstack.org/422897 | 19:33 |
| openstackgerrit | Nikhil Komawar proposed openstack/glance: Update deprecated show_multiple_locations helptext https://review.openstack.org/426283 | 19:34 |
| sigmavirus | For those of you subscribed to glance/glance-store/python-glanceclient bugs I'm trying to close out bugs/preapre bugs to close out. I apologize in advance for the spam you may receive | 19:41 |
| *** jose-phillips has joined #openstack-glance | 19:49 | |
| openstackgerrit | Dharini Chandrasekar proposed openstack/glance: Stricter checks for registry API calls https://review.openstack.org/416766 | 19:50 |
| *** david-lyle has joined #openstack-glance | 19:53 | |
| *** david-lyle has quit IRC | 19:53 | |
| *** david-lyle has joined #openstack-glance | 19:54 | |
| *** david-lyle has quit IRC | 20:01 | |
| *** david-lyle has joined #openstack-glance | 20:01 | |
| dharinic | nikhil: There? I was not sure I understood your comment in https://review.openstack.org/#/c/416766/ | 20:14 |
| *** jose-phillips has quit IRC | 20:29 | |
| *** e0ne has joined #openstack-glance | 20:31 | |
| *** e0ne has quit IRC | 20:33 | |
| *** e0ne has joined #openstack-glance | 20:38 | |
| *** jose-phillips has joined #openstack-glance | 20:52 | |
| *** e0ne has quit IRC | 20:56 | |
| *** jose-phillips has quit IRC | 20:58 | |
| *** smatzek has quit IRC | 20:58 | |
| *** smatzek has joined #openstack-glance | 20:59 | |
| *** e0ne has joined #openstack-glance | 21:02 | |
| *** e0ne has quit IRC | 21:02 | |
| *** e0ne has joined #openstack-glance | 21:04 | |
| *** kebray has joined #openstack-glance | 21:04 | |
| *** e0ne has quit IRC | 21:06 | |
| *** thiagolib has quit IRC | 21:08 | |
| *** TravT has quit IRC | 21:11 | |
| *** TravT has joined #openstack-glance | 21:14 | |
| *** kebray has quit IRC | 21:18 | |
| dims | rosmaita : glance/glare tests are mocking non-public stevedore API stopping us from moving to latest stevedore | 21:22 |
| dims | rosmaita : http://codesearch.openstack.org/?q=_find_entry_points&i=nope&files=&repos=glance | 21:22 |
| dims | sigmavirus : ^ | 21:22 |
| *** smatzek has quit IRC | 21:22 | |
| *** catintheroof has quit IRC | 21:44 | |
| *** catintheroof has joined #openstack-glance | 21:45 | |
| *** catintheroof has quit IRC | 21:49 | |
| *** ducttape_ has joined #openstack-glance | 21:54 | |
| *** alex_bash has quit IRC | 22:08 | |
| *** abashmak_ has joined #openstack-glance | 22:08 | |
| *** jose-phillips has joined #openstack-glance | 22:11 | |
| *** abashmak_ is now known as alex_bash | 22:16 | |
| *** alex_bash has quit IRC | 22:20 | |
| *** abashmak_ has joined #openstack-glance | 22:22 | |
| *** abashmak_ is now known as alex_bash | 22:22 | |
| *** alex_bash has quit IRC | 22:23 | |
| *** abashmak_ has joined #openstack-glance | 22:24 | |
| openstackgerrit | Hemanth Makkapati proposed openstack/glance: Testing changes required with Alembic move https://review.openstack.org/397409 | 22:29 |
| oomichi | rosmaita: nice to skip unittests also on doc patches. It is great if you take a look at https://review.openstack.org/#/c/426412 | 22:30 |
| *** abashmak_ is now known as alex_bash | 22:39 | |
| openstackgerrit | Hemanth Makkapati proposed openstack/glance: Testing changes required with Alembic move https://review.openstack.org/397409 | 22:39 |
| openstackgerrit | Hemanth Makkapati proposed openstack/glance: Testing changes required with Alembic move https://review.openstack.org/397409 | 22:40 |
| *** burgerk has quit IRC | 22:50 | |
| *** takedakn has joined #openstack-glance | 22:59 | |
| openstackgerrit | Doug Hellmann proposed openstack/glance: do not mock private methods of objects from libraries https://review.openstack.org/426423 | 22:59 |
| dhellmann | rosmaita, sigmavirus, dims: I think this ^^ fixes the stevedore issue. | 23:00 |
| openstackgerrit | Doug Hellmann proposed openstack/glance: do not mock private methods of objects from libraries https://review.openstack.org/426423 | 23:02 |
| *** ducttape_ has quit IRC | 23:03 | |
| *** ducttape_ has joined #openstack-glance | 23:03 | |
| *** greghaynes has quit IRC | 23:10 | |
| *** ducttape_ has quit IRC | 23:24 | |
| *** greghaynes has joined #openstack-glance | 23:37 | |
| *** smatzek has joined #openstack-glance | 23:52 | |
| *** greghaynes has quit IRC | 23:52 | |
| *** smatzek_ has joined #openstack-glance | 23:53 | |
| *** smatzek_ has quit IRC | 23:54 | |
| *** smatzek_ has joined #openstack-glance | 23:55 | |
| *** ducttape_ has joined #openstack-glance | 23:56 | |
| *** smatzek has quit IRC | 23:57 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!