Friday, 2017-01-20

*** mtanino has quit IRC00:13
*** ducttape_ has joined #openstack-glance00:20
*** ducttape_ has quit IRC00:31
*** jose-phillips has quit IRC00:38
dharinicWanted to remind on this glance_store backports:00:49
dharinichttps://review.openstack.org/#/c/417329/00:49
dharinichttps://review.openstack.org/#/c/41719700:49
*** tovin07 has joined #openstack-glance00:57
openstackgerritBrian Rosmaita proposed openstack/glance: Add release note for image visibility changes  https://review.openstack.org/42289701:10
openstackgerritCao Xuan Hoang proposed openstack/glance_store: Add Python 3.5 classifier and venv  https://review.openstack.org/42235601:27
*** jdurgin has quit IRC01:34
*** ducttape_ has joined #openstack-glance01:55
*** ducttape_ has quit IRC01:59
*** ducttape_ has joined #openstack-glance02:13
*** links has joined #openstack-glance02:53
*** ducttape_ has quit IRC02:54
tovin07nikhil, could you review this patch https://review.openstack.org/#/c/316799/ it's quite small and being held for a long time... thanks! :D03:14
*** itisha has joined #openstack-glance03:30
*** gb21 has joined #openstack-glance03:36
*** nicolasbock has quit IRC03:41
*** flwang1 has quit IRC03:50
*** links has quit IRC04:16
*** links has joined #openstack-glance04:18
*** pdeore has joined #openstack-glance04:24
*** udesale has joined #openstack-glance04:25
*** ratailor has joined #openstack-glance04:28
*** udesale has quit IRC04:30
*** ratailor has quit IRC04:50
*** catinthe_ has quit IRC04:54
*** catintheroof has joined #openstack-glance05:02
*** pdeore has quit IRC05:03
*** gb21 has quit IRC05:09
*** gb21 has joined #openstack-glance05:09
*** udesale has joined #openstack-glance05:09
*** udesale has quit IRC05:10
*** udesale has joined #openstack-glance05:11
*** catintheroof has quit IRC05:14
*** sabari has quit IRC05:35
*** pdeore has joined #openstack-glance05:41
*** sabari has joined #openstack-glance05:41
*** catintheroof has joined #openstack-glance05:46
*** ratailor has joined #openstack-glance05:50
*** pdeore__ has joined #openstack-glance06:41
*** pdeore has quit IRC06:42
*** pdeore__ has quit IRC06:52
*** pdeore__ has joined #openstack-glance06:53
*** pdeore__ has quit IRC06:58
*** pdeore__ has joined #openstack-glance07:01
*** pdeore__ has quit IRC07:06
*** pdeore__ has joined #openstack-glance07:07
*** gabor_antal_ has joined #openstack-glance07:13
*** gabor_antal has quit IRC07:14
*** adisky_ has joined #openstack-glance07:17
*** pdeore__ has quit IRC07:23
*** pdeore__ has joined #openstack-glance07:24
*** pdeore has joined #openstack-glance07:30
*** pdeore__ has quit IRC07:30
*** gabor_antal_ has quit IRC07:37
*** gabor_antal has joined #openstack-glance07:37
*** pcaruana has joined #openstack-glance07:43
*** jokke__ has joined #openstack-glance07:46
*** dosaboy has joined #openstack-glance07:47
*** melwitt_ has joined #openstack-glance07:48
*** flwang has quit IRC07:51
*** dosaboy_ has quit IRC07:51
*** melwitt has quit IRC07:51
*** jokke_ has quit IRC07:51
*** ccard has quit IRC07:51
*** ccard has joined #openstack-glance07:52
*** flwang has joined #openstack-glance07:54
*** mosulica has joined #openstack-glance08:02
*** gb21 has quit IRC08:03
*** tesseract has joined #openstack-glance08:05
*** jlwhite has quit IRC08:29
*** tovin07 has quit IRC08:30
*** tovin07 has joined #openstack-glance08:30
*** jlwhite has joined #openstack-glance08:31
*** mfedosin has joined #openstack-glance08:31
*** zzzeek has quit IRC09:00
*** zzzeek has joined #openstack-glance09:00
*** openstackgerrit has quit IRC09:02
*** namnh has joined #openstack-glance09:05
*** johnthetubaguy has quit IRC09:16
*** openstackgerrit has joined #openstack-glance09:18
openstackgerritAdam Kijak proposed openstack/glance_store: An unit test passes because is launched as non-root user  https://review.openstack.org/42257909:18
*** johnthetubaguy has joined #openstack-glance09:19
*** ratailor has quit IRC09:29
*** timburke has quit IRC09:32
*** timburke has joined #openstack-glance09:35
*** pdeore has quit IRC09:37
tovin07mfedosin, hi09:41
openstackgerritAbhishek Kekane proposed openstack/python-glanceclient: Add request id to returned objects  https://review.openstack.org/35289209:42
mfedosintovin07: hi :)09:44
*** mvk has quit IRC09:46
*** pdeore has joined #openstack-glance09:47
*** pdeore is now known as pdeore|afk09:47
tovin07Could you review this one: https://review.openstack.org/#/c/316799/ i saw you +2 before09:48
mfedosinsure, give me a minute09:50
tovin07oh, thanks, too fast for me to handle this :v09:53
tovin07nikhil, are you there?09:53
*** ratailor has joined #openstack-glance09:54
*** e0ne has joined #openstack-glance10:12
*** gcb has joined #openstack-glance10:14
*** mvk has joined #openstack-glance10:17
*** abhishekk has joined #openstack-glance10:18
*** aarefiev_afk is now known as aarefiev10:26
*** mdbooth has quit IRC10:26
*** mdbooth has joined #openstack-glance10:26
*** namnh has quit IRC10:29
*** gcb has quit IRC10:34
*** mosulica has quit IRC10:58
*** mosulica has joined #openstack-glance11:00
*** ducttape_ has joined #openstack-glance11:29
*** ducttape_ has quit IRC11:31
*** mosulica has quit IRC11:32
*** nicolasbock has joined #openstack-glance11:35
*** mosulica has joined #openstack-glance11:38
*** pdeore|afk has quit IRC11:57
*** pcaruana has quit IRC11:59
*** pcaruana has joined #openstack-glance12:06
*** cdelatte has joined #openstack-glance12:08
*** adisky_ has quit IRC12:09
*** smatzek_ has joined #openstack-glance12:24
*** catinthe_ has joined #openstack-glance12:32
*** catintheroof has quit IRC12:33
*** ratailor has quit IRC12:42
*** links has quit IRC12:55
*** ducttape_ has joined #openstack-glance13:11
sigmavirusdharinic: when you get in it looks like community images may have broken Glance v1: http://logs.openstack.org/54/423154/1/check/gate-osc-dsvm-functional-ubuntu-xenial/f23fbfa/testr_results.html.gz13:12
sigmaviruscc hemanthm rosmaita ^13:13
rosmaitaNOOOOOOOO!!!!13:13
openstackgerritChangBo Guo(gcb) proposed openstack/glance: Use OS::Nova::HostAggregate instead of OS::Nova::Aggregate  https://review.openstack.org/35974213:17
*** gcb has joined #openstack-glance13:19
gcbglance cores, glance review https://review.openstack.org/#/c/359742/  is needed by horizon review https://review.openstack.org/#/c/367161/, please help review when you're free, thanks13:20
*** ducttape_ has quit IRC13:21
*** ducttape_ has joined #openstack-glance13:24
openstackgerritBrian Rosmaita proposed openstack/glance: Add release note for image visibility changes  https://review.openstack.org/42289713:28
*** ducttape_ has quit IRC13:34
*** dtroyer has joined #openstack-glance13:49
openstackgerritDean Troyer proposed openstack/glance: Revert "Implement and Enable Community Images"  https://review.openstack.org/42328614:02
*** Dinesh_Bhor has quit IRC14:04
openstackgerritDean Troyer proposed openstack/glance: Revert "Implement and Enable Community Images"  https://review.openstack.org/42328614:13
sigmavirusgcb: that should have been mentioned at the meeting. We'll add it to our priorities when we next create the list (at next week's meeting)14:15
gcbsigmavirus,  thanks14:15
*** smatzek_ has quit IRC14:31
*** catintheroof has joined #openstack-glance14:33
*** mosulica has quit IRC14:36
*** catinthe_ has quit IRC14:36
*** mosulica has joined #openstack-glance14:37
*** ducttape_ has joined #openstack-glance14:53
*** ratailor has joined #openstack-glance14:55
*** melwitt_ is now known as melwitt14:55
*** smatzek has joined #openstack-glance14:58
*** ducttape_ has quit IRC15:02
*** gcb has quit IRC15:09
*** mtanino has joined #openstack-glance15:10
*** TravT has joined #openstack-glance15:11
*** david-lyle has joined #openstack-glance15:13
*** udesale has quit IRC15:21
*** udesale has joined #openstack-glance15:21
*** udesale has quit IRC15:24
*** udesale has joined #openstack-glance15:25
*** david-lyle has quit IRC15:25
*** david-lyle has joined #openstack-glance15:25
*** ducttape_ has joined #openstack-glance15:29
*** david-lyle has quit IRC15:42
*** mvk has quit IRC15:48
*** ratailor has quit IRC15:52
*** burgerk has joined #openstack-glance15:59
openstackgerritDean Troyer proposed openstack/glance: Add image update tests for is_public  https://review.openstack.org/42334416:01
openstackgerritDean Troyer proposed openstack/glance: Add image update tests for is_public  https://review.openstack.org/42334516:02
dtroyerI am attempting to isolate the change in v1 both with and without https://review.openstack.org/369110 in those two ^^^^^16:02
*** pcaruana has quit IRC16:03
dtroyersigmavirus, rosmaita: ^^^  hope that helps narrow it down16:03
sigmavirusdtroyer: thanks =)16:04
sigmaviruswe just want to unblock you for now and swarm on making sure we don't break that when we unrevert the change16:04
sigmavirusor revert your revert16:04
sigmavirusor however you want to think about it ;)16:05
sigmavirusMeanwhile I'm tackling the WebOb 1.7 incompatibilities16:05
sigmavirusSo I'm not much use yet16:05
sigmavirushopefully I'm down to the last test16:05
sigmavirusWhich if it's a glare test, rosmaita, I'm just going to skip16:05
sigmavirusBecause I thought glare was going to be burnt to a crisp this cycle but apparently it's not16:05
dtroyerthanks for that. and the webob bits too, that sounds like a nasty situation16:06
sigmavirusdtroyer: glance's functional tests were what was primarily failing and there's no way to pdb into those subprocesses effectively so it's a whole lot of pausing the test before the temp logs are gone and a lot of log debugging16:07
sigmavirusbut I think I'm down to the last failing test16:07
*** tovin07 has quit IRC16:08
sigmavirusIt appears, in glance, to be too much to not duplicate logic/code between API versions16:08
*** hieulq has quit IRC16:09
*** mosulica has quit IRC16:09
dtroyerI still get pushback on that in OSC, but this sort of thing is exactly why I believe we need to duplicate it.  Plus it makes removing an old API _really_ easy later.16:10
sigmavirusSome of the request deserialization doesn't change though16:10
sigmavirusI also have a feeling our tests would be faster if we could lesson the verbosity of our test suite16:12
*** tovin07 has joined #openstack-glance16:14
*** hieulq has joined #openstack-glance16:15
dharinicsigmavirus: looking.16:24
*** e0ne has quit IRC16:44
openstackgerritIan Cordasco proposed openstack/glance: Fix incompatibilities with WebOb 1.7  https://review.openstack.org/42336616:47
*** itisha has quit IRC16:52
*** sigmavirus sets mode: -o sigmavirus16:53
*** _ducttape_ has joined #openstack-glance16:59
*** jose-phillips has joined #openstack-glance17:00
*** udesale has quit IRC17:02
*** ducttape_ has quit IRC17:02
*** jose-phillips has quit IRC17:12
*** nicolasbock has quit IRC17:18
*** nicolasbock has joined #openstack-glance17:18
*** jdillaman has quit IRC17:28
*** jdillaman has joined #openstack-glance17:29
*** mvk has joined #openstack-glance17:29
*** _ducttape_ has quit IRC17:35
*** ducttape_ has joined #openstack-glance17:36
*** marst has joined #openstack-glance17:49
*** hieulq has quit IRC17:56
*** tovin07 has quit IRC17:56
*** e0ne has joined #openstack-glance18:06
*** hieulq has joined #openstack-glance18:12
*** tovin07 has joined #openstack-glance18:12
sigmavirusdtroyer: rosmaita can one of you make a bug for the v1 regression and tag me in it?18:14
sigmavirusI have suspect I'll have a fix before EOD18:14
sigmavirusrosmaita: did you ever send out a priorities email for this week?18:15
*** dalgaaf has joined #openstack-glance18:15
rosmaitasigmavirus: not yet18:19
sigmavirusokay can you include https://review.openstack.org/423366 like we discussed yesterday18:20
rosmaitawill do18:20
rosmaitawill also create bug for you18:21
rosmaitasigmavirus: https://bugs.launchpad.net/glance/+bug/165816418:27
openstackLaunchpad bug 1658164 in Glance "community images breaks Images v1 API" [Critical,Triaged] - Assigned to Ian Cordasco (icordasc)18:27
*** mvk has quit IRC18:30
sigmavirusthanks18:33
*** e0ne has quit IRC18:35
*** esmiurium has quit IRC18:40
sigmavirusdharinic: do you have a public ssh key somewhere?18:45
sigmavirusI'm can add you to this environment and we can dig into this together18:45
*** esmiurium has joined #openstack-glance18:47
dharinicsure sigmavirus18:48
*** TravT has quit IRC18:59
*** TravT has joined #openstack-glance19:11
*** TravT_ has joined #openstack-glance19:13
*** TravT has quit IRC19:16
*** david-lyle has joined #openstack-glance19:17
*** david-lyle has quit IRC19:24
*** dalgaaf has quit IRC19:29
*** dalgaaf has joined #openstack-glance19:30
*** tesseract has quit IRC19:32
*** kebray has joined #openstack-glance19:32
openstackgerritIan Cordasco proposed openstack/glance: Fix regression introduced by Community Images  https://review.openstack.org/42349919:33
sigmavirusdtroyer: rosmaita ^19:34
sigmavirusstevemar: too ^19:35
sigmavirusand now I'm going to go take a break19:35
stevemarsigmavirus: heyo!19:35
rosmaitasigmavirus: well earned break19:35
rosmaitathat was not easy to see19:36
sigmavirusrosmaita: not in the slightest19:36
sigmavirusthe func test helped though19:36
rosmaitahooray for tests19:36
sigmavirusI should probably pull in dtroyer's unit test too but19:36
stevemarsigmavirus: func tests usually do :)19:36
sigmaviruswe can also just rebase it atop19:37
dharinicsigmavirus: yayy19:38
rosmaitai am just writing up the priorities, what't the procedure on this?19:38
sigmavirusrosmaita: huh?19:38
sigmaviruswell we could unapprove dtroyer's patch19:38
sigmavirusno need to go through with a revert when we have a fix19:39
sigmavirusI'd like stevemar or dtroyer to okay that though19:39
stevelle+119:39
rosmaitathat would be easiest19:39
sigmavirus*patch -> revert19:39
sigmavirusWhen I get back, I think I might through up a test no-merge patch to osc that depends on our fix19:40
sigmavirus*throw19:40
* sigmavirus needs coffee19:40
stevemarsigmavirus: rosmaita you could ask someone from infra to snipe the revert out of the gate19:40
stevemarnot sure if its merged yet19:40
sigmavirusstevemar: wasn't last I checked19:40
sigmavirusrosmaita: can you handle that?19:40
rosmaitasure19:41
stevemarrosmaita: ask fungi hes the guru there19:41
fungi(for some definitions of "guru" anyway)19:42
stevemari trust sigmavirus to have it fixed up :)19:42
stevemarfungi: can you snipe https://review.openstack.org/#/c/423286/ ?19:42
fungiahh, you need it to stop running tests in the gate? sure19:43
openstackgerritJeremy Stanley proposed openstack/glance: Revert "Implement and Enable Community Images"  https://review.openstack.org/42328619:43
fungithere you go (rebase button in gerrit to the rescue!)19:43
stevemarfungi: yeah, turns out sigmavirus found a solution that doesn't involve undoing everything https://review.openstack.org/#/c/423499/19:44
stevelleheh19:44
stevemarfungi: i waaaas gonna do that if you didn't get back to me hehe19:44
fungiif a new patchset gets pushed for a change, zuul will immediately remove it from dependent pipelines like the gate19:44
fungigerrit's server-side rebase is the fastest means of making one of those, unless the change can't be rebased for $reasons19:45
fungii don't have an super secret admin tool to remove changes from a pipeline. a few people started work on a dequeue subcommand for the zuul rpc cli client but it's never been finished19:46
rosmaitafungi: thanks for the help19:46
fungiand will almost certainly wait for zuul v3 at this stage19:46
fungiany time!19:46
stevemarfungi: if can't rebase, then re-propose with a character change :)19:47
fungiyup19:47
fungikeep in mind that it's far easier to block a change from merging if you don't care that it hangs around in the gate pipeline until it tries and fails to merge. any of the following will get you that: remove all workflow +1 or code-review +2 votes, add a workflow -1 or code-review -2 vote19:48
*** jose-phillips has joined #openstack-glance19:48
fungialso abandoning will do the trick (i don't recall if that also removes it from the gate immediately or simply prevents it from eventually merging)19:49
*** catinthe_ has joined #openstack-glance19:50
rosmaitathat's actually a lot of options, funny how in the anxiety of making this patch not merge, i didn't think of any of them!19:51
*** catintheroof has quit IRC19:53
dtroyerrosmaita, sigmavirus: woot!  Thanks guys, that fix makes my little unit test happy locally20:00
rosmaitadtroyer: excellent! thanks for checking, and thanks for working with us on this20:00
dtroyershould I clean up my pep8 issues and resubmit the unit tests?20:01
rosmaitastevelle: can you review https://review.openstack.org/#/c/423499/ ?20:03
rosmaitadtroyer: feel free, they would not hurt20:03
stevellerosmaita: yeah, already on it20:03
rosmaitastevelle: ty ... if it LGTY, then i will give it an anticipatory +A20:04
stevellerosmaita: want to watch the change or would you like a ping when I'm done?20:05
rosmaitaa ping would be helpful20:05
stevellerosmaita: +220:09
rosmaitastevelle: ty20:09
openstackgerritDean Troyer proposed openstack/glance: Add image update tests for is_public  https://review.openstack.org/42334520:12
sigmavirusdtroyer: yeah that would be great20:13
marstHello. I'm having troubles with using "glance image-create --location http://blablabla" with corporate proxy. http_proxy is set in env and "wget -O http://blablabla" works fine. Error message: "The HTTP URL is invalid. _get_size /usr/lib/python2.7/site-packages/glance/api/v1/images.py:758" This is OS liberty and glance-api.conf has "stores=glance.store.http.Store,glance.store.rbd.Store" enabled." Any idea what could be wrong or what to check??20:14
sigmavirusmarst: I assume your glance is configured to allow use of locations?20:14
*** esmiurium has quit IRC20:15
marstsigmavirus: I'd guess so, how do I check?20:15
sigmavirusmarst: check glance-api.conf for show_image_direct_url and show_multiple_locations20:17
sigmavirusone will have to be true (iirc) to allow you to set a location20:17
sigmavirusrosmaita: stevemar can you help marst? I have to hop on the VPN for a short bit20:19
marstsigmavirus: show_image_direct_url=True, while show_multiple_locations is commented out. I'll play with those parameters. Thanks a lot!20:20
*** ChanServ changes topic to "OpenStack Glance"20:23
*** ChanServ changes topic to "OpenStack Glance | priorities: http://lists.openstack.org/pipermail/openstack-dev/2017-January/110617.html"20:23
*** ChanServ changes topic to "OpenStack Glance | priorities: http://lists.openstack.org/pipermail/openstack-dev/2017-January/110617.html | logs at http://eavesdrop.openstack.org/irclogs/%23openstack-glance/"20:23
*** esmiurium has joined #openstack-glance20:31
*** TravT_ has quit IRC20:33
sigmavirusmarst: could also be that the glance environment that the URL is unreachable20:38
sigmavirusalso if glance is behind the same proxy, it needs to be able to detect that20:38
sigmavirusthat could be why the URL is unreachable20:38
sigmavirusGlance the API will need to reach the URL and if the Proxy doesn't allow it that could be the reason20:39
marstsigmavirus: checked tcpdump on proxy server, no requests are coming from controller. wget with the same proxy works fine. I guess it's not a proxy problem, after all.20:42
sigmavirusmarst: are you sure Glance is using the proxy though?20:43
sigmavirusyou might need to turn on debug logging to confirm that20:43
marstsigmavirus: undefined "http_proxy" from env, and changed url to "http://glance_own_ip/test123". Now it says "HTTPBadRequest: 400 Bad Request: External sources are not supported:"20:44
marstsigmavirus: is "glance --debug" enough?20:45
marstor I need to change it glance-api.conf and restart the service?20:45
sigmaviruswell that won't tell you if glance (the service) is using a proxy20:45
sigmavirusbut --debug will give you info20:45
sigmavirusmarst: putting that info into paste.openstack.org would be good20:45
marstI've unset both http_proxy and no_proxy variables.20:45
marstsigmavirus: http://paste.openstack.org/show/595838/20:46
marstsigmavirus: thanks for the help, btw. Are you going to be in Atlanta?20:47
*** david-lyle has joined #openstack-glance20:47
sigmavirusmarst: I won't be, no20:47
sigmavirusAlso have to jet so I won't be around after this20:51
sigmavirusHave a good weekend y'all20:51
sigmavirusrosmaita: stevelle ^ marst could still use some help20:51
marstsigmavirus: it's a pity, I was hoping to buy you a beer.20:52
marstsigmavirus: it's still on me though.20:52
sigmavirusmarst: no need. I don't drink =D20:52
marstsigmavirus. thanks a lot, anyway!20:52
marstI'll google around, it's sounds like something very simple error in my config20:53
stevellestay shiny sigmavirus20:53
*** thiagolib has quit IRC20:58
*** dalgaaf has quit IRC21:00
*** catinthe_ has quit IRC21:02
*** catintheroof has joined #openstack-glance21:03
marststevelle: if you have a minute, can you have a quick look on http://paste.openstack.org/show/595840/ ? Found old bug: https://bugs.launchpad.net/glance-store/+bug/1473009 , but I guess it doesn't apply in my case.21:03
openstackLaunchpad bug 1473009 in glance_store "HTTP external sources are not supported" [Undecided,Invalid]21:03
stevellelooking now marst21:05
*** catintheroof has quit IRC21:07
stevellefair warning: I'm not great with v1 api stuff since I have spent most of my time focused on v2, so I may not get this very fast21:10
stevellemarst: are you sure that you shouldn't have http in the stores list as indicated in the bug comments because that does seem to be straight forward reading21:16
marststevelle: I have "stores=glance.store.http.Store,glance.store.rbd.Store", while bug description has: "stores = glance.store.filesystem.Store, glance.store.rbd.Store, glance.store.http.Store"21:21
stevellemarst: the suggestion in the comments there was that the issue was resolved by adding ", glance.store.http.Store" to the stores key21:21
stevellethis should allow the glance API to accept locations beginning with http21:22
marststevelle: I'm not following. I already have http store defined in glance-api.conf: http://paste.openstack.org/show/595840/. Shall I change order?21:23
stevellecomment #4 "resolved it by adding glance.store.http.Store to the stores in glance-api.conf"21:23
marststevelle: yes!21:24
marststevelle: I was so happy when I found that solution. and a bit disappointed since I already have it defined in config file21:24
stevelleIn this case order should not be the problem. But to be clear, http was already there before you started?21:25
marststevelle: yes.21:27
stevemarrosmaita: stevelle looks like https://review.openstack.org/#/c/423499/ isn't working as expected :(21:27
stevellemarst: if you do turn on debug logging and restart the service, I'd want you to look for lines featuring "Registering scheme"21:27
marststevelle: will do. thank you!21:28
stevellemight just check to see what shows up at the last restart if debug was already on21:28
*** jamielennox is now known as jamielennox|away21:28
*** mfedosin has quit IRC21:29
*** smatzek has quit IRC21:31
*** flwang1 has joined #openstack-glance21:41
*** david-lyle has quit IRC21:45
stevellestevemar: we might have spoken too soon on the community images revert.21:46
stevellerosmaita: ^ when you're back21:46
dharinicshouldnt have these been caught before +w?21:47
dharinicby jenkins21:48
dharinicor did we not wait for jenkins?21:48
dharinicstevelle^21:48
stevellewe didn't wait. I ran local suite with and without CI before zuul finished first pass21:48
*** _ducttape_ has joined #openstack-glance21:48
dharinicpy27 failed locally for me on that patch. I was actually waiting on Jenkins before +1 ing it21:49
*** _ducttape_ has quit IRC21:49
dharinicokayy21:49
stevelleI probably borked my git history when setting up the test with CI21:50
stevellethat's my best guess21:50
*** _ducttape_ has joined #openstack-glance21:50
*** ducttape_ has quit IRC21:51
stevelleat least I can confirm - Failed: 2621:54
*** dalgaaf has joined #openstack-glance21:57
dharinicYes stevelle. I saw that before that patch was +w'd21:58
stevelledoh21:58
dharinicI suspected some issues with my env cos i saw that it was already approved21:58
dharinichence did not bother to tell it on the channel21:58
*** sabari has quit IRC22:00
stevellethat we don't or can't trust our own envs is probably something to look at later :)22:05
stevelledharinic: are you digging into the failure too?22:10
*** dalgaaf has quit IRC22:11
dharinicyes stevelle. Not much progress though22:11
stevelledharinic: so all of the failures seem to be related to functional/test_cache_middleware.py in the process of creating images, so the change fixed updates but breaks a create scenario.22:12
stevelleor at least a sizable portion of them seem to point there22:12
dharinicyeah thats true stevelle22:13
stevelledharinic: and db/simple/api.py always applies ensure_image_dict_v2_compliant, whereas db/sqlalchemy/api.py conditionally applies it22:13
stevellethat has me suspicious of a logic error, but that's what I have right now22:14
dharinicwhats intersting the tests in the same test file of that patch glance.tests.functional.v1.test_api.TestApi.22:14
dharinicyeah. The call that goes form db/simple/api.py for the update methods need to be looked at22:14
dhariniclike a similar situtation as in the sqlalchemy/api.py22:15
stevellemarst: yt?22:17
marststevelle: yes!22:18
marststevelle: I'm a certified idiot.22:18
marststevelle: copy-pasted url. it was htttp, instead of http.22:18
stevellewait, does that mean you fixed it?22:18
stevellewin!22:18
stevelleI was just going to ask you b/c your original comment said:         External sources are not supported:"22:19
marststevelle: sorry for wasting your time22:19
stevelleyou didn't paste the actual protocol that wasn't supported22:19
marstI've spent 2 days fighting this. :(22:19
stevellemarst: sorry you wasted your time :((22:19
marststevelle: it's ok though. learned quite a bit about glance in the process. :)22:20
stevellelet's call that a win22:20
marststevelle: thanks a lot! :)22:20
marststevelle: you have a great weekend!22:20
stevellecheers22:20
rosmaitaso, looks like there's still work to do on CI22:22
*** burgerk has quit IRC22:25
stevelleit shouldn't take much, but yes. the CI patch we merged did have a couple hidden problems. Glad we are finding them now though22:32
openstackgerritSteve Lewis (stevelle) proposed openstack/glance: Fix regression introduced by Community Images  https://review.openstack.org/42349922:37
*** dalgaaf has joined #openstack-glance22:39
*** dalgaaf has quit IRC22:43
*** dalgaaf has joined #openstack-glance22:43
openstackgerritSteve Lewis (stevelle) proposed openstack/glance: Add image update tests for is_public  https://review.openstack.org/42334522:44
*** wjhofer has quit IRC23:01
*** _ducttape_ has quit IRC23:22
*** kebray has quit IRC23:30
openstackgerritHemanth Makkapati proposed openstack/glance: Port Glance Migrations to Alembic  https://review.openstack.org/38295823:57

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!