| *** bpokorny_ has joined #openstack-glance | 00:00 | |
| *** bpokorny has quit IRC | 00:01 | |
| *** ctrath has joined #openstack-glance | 00:02 | |
| openstackgerrit | Dharini Chandrasekar proposed openstack/glance: Location updates (replace and remove) status checks https://review.openstack.org/366995 | 00:06 |
|---|---|---|
| openstackgerrit | Merged openstack/glance: Complete and update Newton release notes https://review.openstack.org/366973 | 00:08 |
| *** ducttape_ has joined #openstack-glance | 00:21 | |
| openstackgerrit | Ying Zuo proposed openstack/glance: Fix inconsistent metadata names https://review.openstack.org/303658 | 00:23 |
| *** ducttape_ has quit IRC | 00:26 | |
| *** thumpba has quit IRC | 00:29 | |
| *** markvoelker has joined #openstack-glance | 00:34 | |
| *** bpokorny_ has quit IRC | 00:38 | |
| *** bpokorny has joined #openstack-glance | 00:38 | |
| *** ctrath has quit IRC | 00:39 | |
| *** ducttape_ has joined #openstack-glance | 00:45 | |
| *** TravT has quit IRC | 00:51 | |
| *** thumpba has joined #openstack-glance | 00:55 | |
| *** ducttape_ has quit IRC | 01:04 | |
| *** bpokorny_ has joined #openstack-glance | 01:05 | |
| *** bpokorny has quit IRC | 01:05 | |
| *** bpokorny_ has quit IRC | 01:07 | |
| *** bpokorny has joined #openstack-glance | 01:08 | |
| *** TravT has joined #openstack-glance | 01:10 | |
| *** TravT has quit IRC | 01:11 | |
| *** TravT_ has joined #openstack-glance | 01:11 | |
| *** ducttape_ has joined #openstack-glance | 01:11 | |
| *** bpokorny has quit IRC | 01:13 | |
| *** TravT has joined #openstack-glance | 01:14 | |
| *** TravT_ has quit IRC | 01:15 | |
| *** TravT has quit IRC | 01:15 | |
| *** TravT has joined #openstack-glance | 01:16 | |
| *** TravT has quit IRC | 01:16 | |
| *** TravT has joined #openstack-glance | 01:17 | |
| *** TravT has quit IRC | 01:17 | |
| *** TravT has joined #openstack-glance | 01:18 | |
| *** TravT_ has joined #openstack-glance | 01:19 | |
| *** TravT has quit IRC | 01:22 | |
| *** ducttape_ has quit IRC | 01:27 | |
| *** ducttape_ has joined #openstack-glance | 01:31 | |
| *** mtanin___ has joined #openstack-glance | 01:31 | |
| *** mtanino has quit IRC | 01:32 | |
| *** TravT_ has quit IRC | 01:37 | |
| *** TravT has joined #openstack-glance | 01:42 | |
| *** mingyu has joined #openstack-glance | 01:54 | |
| *** TravT has quit IRC | 01:55 | |
| *** hemanthm|away is now known as hemanthm | 01:59 | |
| *** TravT has joined #openstack-glance | 02:00 | |
| *** rrecio_ has quit IRC | 02:05 | |
| *** thumpba has quit IRC | 02:08 | |
| *** mtanin___ has quit IRC | 02:08 | |
| *** mingyu_ has joined #openstack-glance | 02:09 | |
| *** mingyu has quit IRC | 02:09 | |
| *** TravT has quit IRC | 02:10 | |
| *** TravT has joined #openstack-glance | 02:14 | |
| *** tsymanczyk has quit IRC | 02:23 | |
| *** TravT has quit IRC | 02:24 | |
| *** catintheroof has joined #openstack-glance | 02:27 | |
| *** TravT has joined #openstack-glance | 02:32 | |
| *** thumpba has joined #openstack-glance | 02:35 | |
| *** TravT has quit IRC | 02:37 | |
| *** TravT has joined #openstack-glance | 02:42 | |
| *** ducttape_ has quit IRC | 02:44 | |
| *** ducttape_ has joined #openstack-glance | 02:45 | |
| *** TravT has quit IRC | 02:51 | |
| *** TravT has joined #openstack-glance | 02:56 | |
| *** sdake_ has quit IRC | 03:01 | |
| *** smatzek has joined #openstack-glance | 03:01 | |
| *** mingyu_ has quit IRC | 03:02 | |
| *** ducttape_ has quit IRC | 03:04 | |
| *** TravT has quit IRC | 03:09 | |
| *** TravT has joined #openstack-glance | 03:14 | |
| *** mingyu has joined #openstack-glance | 03:23 | |
| *** TravT has quit IRC | 03:23 | |
| *** smatzek has quit IRC | 03:28 | |
| *** thumpba has quit IRC | 03:40 | |
| *** thumpba has joined #openstack-glance | 03:40 | |
| *** mingyu_ has joined #openstack-glance | 03:42 | |
| *** mingyu has quit IRC | 03:43 | |
| *** mingyu_ has quit IRC | 03:45 | |
| *** hemanthm is now known as hemanthm|away | 03:51 | |
| *** TravT has joined #openstack-glance | 03:51 | |
| *** mingyu has joined #openstack-glance | 03:54 | |
| *** TravT has quit IRC | 03:55 | |
| *** thumpba has quit IRC | 03:58 | |
| *** thumpba has joined #openstack-glance | 03:58 | |
| *** thumpba has quit IRC | 03:58 | |
| *** thumpba has joined #openstack-glance | 03:59 | |
| *** thumpba has quit IRC | 03:59 | |
| *** thumpba has joined #openstack-glance | 03:59 | |
| *** thumpba has quit IRC | 04:00 | |
| *** TravT has joined #openstack-glance | 04:00 | |
| *** pdeore has joined #openstack-glance | 04:01 | |
| *** ducttape_ has joined #openstack-glance | 04:05 | |
| *** mingyu has quit IRC | 04:06 | |
| *** mingyu has joined #openstack-glance | 04:07 | |
| *** jdurgin has joined #openstack-glance | 04:10 | |
| *** ducttape_ has quit IRC | 04:11 | |
| *** TravT has quit IRC | 04:23 | |
| *** TravT has joined #openstack-glance | 04:27 | |
| *** markvoelker has quit IRC | 04:28 | |
| *** rcernin has quit IRC | 04:37 | |
| *** harlowja has quit IRC | 04:45 | |
| *** TravT has quit IRC | 04:45 | |
| *** TravT has joined #openstack-glance | 04:50 | |
| *** TravT has quit IRC | 04:55 | |
| *** TravT has joined #openstack-glance | 04:59 | |
| *** TravT has quit IRC | 05:04 | |
| *** TravT has joined #openstack-glance | 05:09 | |
| *** baojg_ has quit IRC | 05:13 | |
| *** baojg has joined #openstack-glance | 05:14 | |
| *** TravT has quit IRC | 05:18 | |
| *** ratailor has joined #openstack-glance | 05:18 | |
| *** TravT has joined #openstack-glance | 05:23 | |
| *** markvoelker has joined #openstack-glance | 05:28 | |
| *** TravT has quit IRC | 05:32 | |
| *** markvoelker has quit IRC | 05:33 | |
| *** dshakhray has joined #openstack-glance | 05:36 | |
| *** TravT has joined #openstack-glance | 05:36 | |
| *** rcernin has joined #openstack-glance | 05:43 | |
| *** TravT has quit IRC | 05:45 | |
| *** wxy__ has quit IRC | 05:49 | |
| *** wxy__ has joined #openstack-glance | 05:50 | |
| *** thumpba has joined #openstack-glance | 06:01 | |
| *** groen692 has joined #openstack-glance | 06:04 | |
| *** thumpba has quit IRC | 06:06 | |
| *** atod has quit IRC | 06:10 | |
| *** rcernin has quit IRC | 06:14 | |
| *** rcernin has joined #openstack-glance | 06:19 | |
| *** pcaruana has joined #openstack-glance | 06:23 | |
| *** dshakhray has quit IRC | 06:31 | |
| *** dhellmann has quit IRC | 06:39 | |
| *** dhellmann has joined #openstack-glance | 06:42 | |
| *** mosulica has joined #openstack-glance | 06:47 | |
| *** david-lyle_ has joined #openstack-glance | 06:59 | |
| *** david-lyle has quit IRC | 07:00 | |
| *** TravT has joined #openstack-glance | 07:03 | |
| *** Jokke_ has quit IRC | 07:13 | |
| *** atod has joined #openstack-glance | 07:13 | |
| *** TravT has quit IRC | 07:17 | |
| *** atod has quit IRC | 07:18 | |
| *** david-lyle has joined #openstack-glance | 07:28 | |
| *** david-lyle_ has quit IRC | 07:29 | |
| *** markvoelker has joined #openstack-glance | 07:29 | |
| *** mfedosin has joined #openstack-glance | 07:31 | |
| *** markvoelker has quit IRC | 07:34 | |
| openstackgerrit | Thierry Carrez proposed openstack/glance: Update reno for stable/newton https://review.openstack.org/371323 | 07:54 |
| *** zzzeek has quit IRC | 08:00 | |
| *** zzzeek has joined #openstack-glance | 08:00 | |
| *** TravT has joined #openstack-glance | 08:01 | |
| *** thumpba has joined #openstack-glance | 08:01 | |
| *** openstackgerrit has quit IRC | 08:03 | |
| *** openstackgerrit has joined #openstack-glance | 08:03 | |
| *** TravT has quit IRC | 08:10 | |
| *** TravT has joined #openstack-glance | 08:15 | |
| *** tshefi has joined #openstack-glance | 08:21 | |
| *** TravT has quit IRC | 08:24 | |
| *** tshefi has quit IRC | 08:25 | |
| *** e0ne has joined #openstack-glance | 08:28 | |
| *** TravT has joined #openstack-glance | 08:29 | |
| *** thumpba has quit IRC | 08:30 | |
| *** namnh has joined #openstack-glance | 08:41 | |
| *** TravT has quit IRC | 08:47 | |
| *** pdeore has quit IRC | 08:50 | |
| *** Linkmark has joined #openstack-glance | 08:51 | |
| *** TravT has joined #openstack-glance | 08:51 | |
| *** pdeore has joined #openstack-glance | 08:54 | |
| *** dshakhray has joined #openstack-glance | 09:00 | |
| *** mosulica has quit IRC | 09:00 | |
| *** TravT has quit IRC | 09:00 | |
| *** TravT has joined #openstack-glance | 09:05 | |
| *** tshefi has joined #openstack-glance | 09:09 | |
| *** TravT has quit IRC | 09:14 | |
| *** tshefi has quit IRC | 09:15 | |
| *** TravT has joined #openstack-glance | 09:19 | |
| *** jdurgin has quit IRC | 09:21 | |
| *** TravT has quit IRC | 09:29 | |
| *** TravT has joined #openstack-glance | 09:33 | |
| *** mosulica has joined #openstack-glance | 09:39 | |
| *** namnh has quit IRC | 09:41 | |
| *** namnh has joined #openstack-glance | 09:41 | |
| *** TravT has quit IRC | 09:42 | |
| *** TravT has joined #openstack-glance | 09:47 | |
| *** TravT has quit IRC | 09:56 | |
| *** TravT has joined #openstack-glance | 10:01 | |
| *** lujinluo has quit IRC | 10:04 | |
| openstackgerrit | Darja Shakhray proposed openstack/glance: Fix "500 error when filtering on non-ASCII value" https://review.openstack.org/367971 | 10:23 |
| *** mfedosin has quit IRC | 10:24 | |
| *** BlackDex has joined #openstack-glance | 10:26 | |
| BlackDex | hello there | 10:26 |
| *** ducttape_ has joined #openstack-glance | 10:26 | |
| BlackDex | when i try to upload an image (via horizon) i get the following message: "Recoverable error: Error finding address for http://172.18.10.76:9292/v1/images: ('Connection aborted.', BadStatusLine("''",))" | 10:26 |
| *** thumpba has joined #openstack-glance | 10:27 | |
| *** ducttape_ has quit IRC | 10:30 | |
| *** thumpba has quit IRC | 10:32 | |
| *** TravT has quit IRC | 10:32 | |
| *** Jokke_ has joined #openstack-glance | 10:34 | |
| *** TravT has joined #openstack-glance | 10:37 | |
| *** sdake has joined #openstack-glance | 10:42 | |
| *** TravT has quit IRC | 10:51 | |
| *** TravT has joined #openstack-glance | 10:56 | |
| *** namnh has quit IRC | 10:57 | |
| *** TravT has quit IRC | 11:09 | |
| *** TravT has joined #openstack-glance | 11:14 | |
| *** TravT has quit IRC | 11:19 | |
| *** smatzek has joined #openstack-glance | 11:20 | |
| *** ducttape_ has joined #openstack-glance | 11:27 | |
| *** ccesario has joined #openstack-glance | 11:28 | |
| *** markvoelker has joined #openstack-glance | 11:31 | |
| *** ducttape_ has quit IRC | 11:31 | |
| *** markvoelker has quit IRC | 11:35 | |
| *** mfedosin has joined #openstack-glance | 11:36 | |
| *** jdurgin has joined #openstack-glance | 11:37 | |
| *** catintheroof has quit IRC | 11:39 | |
| *** jdurgin has quit IRC | 11:42 | |
| *** ratailor has quit IRC | 11:44 | |
| *** pdeore has quit IRC | 11:48 | |
| *** TravT has joined #openstack-glance | 11:50 | |
| *** jdurgin has joined #openstack-glance | 11:55 | |
| *** TravT has quit IRC | 11:59 | |
| *** TravT has joined #openstack-glance | 12:04 | |
| *** pdeore has joined #openstack-glance | 12:06 | |
| *** baojg has quit IRC | 12:10 | |
| *** pdeore has quit IRC | 12:11 | |
| *** baojg has joined #openstack-glance | 12:12 | |
| *** ducttape_ has joined #openstack-glance | 12:14 | |
| *** TravT has quit IRC | 12:14 | |
| *** pdeore has joined #openstack-glance | 12:15 | |
| *** TravT has joined #openstack-glance | 12:18 | |
| *** takedakn has joined #openstack-glance | 12:20 | |
| *** markvoelker has joined #openstack-glance | 12:26 | |
| *** catintheroof has joined #openstack-glance | 12:27 | |
| *** pdeore has quit IRC | 12:28 | |
| *** TravT has quit IRC | 12:32 | |
| *** edmondsw has joined #openstack-glance | 12:32 | |
| *** TravT has joined #openstack-glance | 12:36 | |
| *** GB21 has joined #openstack-glance | 12:37 | |
| *** mfedosin has quit IRC | 12:38 | |
| *** mtanino has joined #openstack-glance | 12:38 | |
| *** ducttape_ has quit IRC | 12:39 | |
| *** TravT has quit IRC | 12:41 | |
| *** porunov has joined #openstack-glance | 12:44 | |
| *** thumpba has joined #openstack-glance | 12:44 | |
| *** porunov has left #openstack-glance | 12:45 | |
| *** TravT has joined #openstack-glance | 12:46 | |
| *** mfedosin has joined #openstack-glance | 12:50 | |
| *** mtanino has quit IRC | 12:52 | |
| *** TravT has quit IRC | 12:59 | |
| *** sdake_ has joined #openstack-glance | 13:00 | |
| *** sdake has quit IRC | 13:03 | |
| *** TravT has joined #openstack-glance | 13:04 | |
| *** GB21 has quit IRC | 13:05 | |
| *** TravT has quit IRC | 13:09 | |
| *** atod has joined #openstack-glance | 13:12 | |
| openstackgerrit | Merged openstack/glance: Update reno for stable/newton https://review.openstack.org/371323 | 13:15 |
| *** thumpba has quit IRC | 13:17 | |
| *** TravT has joined #openstack-glance | 13:18 | |
| *** takedakn has quit IRC | 13:21 | |
| *** ctrath has joined #openstack-glance | 13:23 | |
| *** hemanthm|away is now known as hemanthm | 13:26 | |
| *** takedakn has joined #openstack-glance | 13:32 | |
| *** smatzek has quit IRC | 13:34 | |
| *** ctrath1 has joined #openstack-glance | 13:34 | |
| *** ctrath has quit IRC | 13:34 | |
| *** TravT has quit IRC | 13:41 | |
| *** TravT has joined #openstack-glance | 13:45 | |
| *** sdake_ has quit IRC | 13:52 | |
| *** smatzek has joined #openstack-glance | 13:55 | |
| *** ctrath1 has quit IRC | 13:56 | |
| *** ctrath has joined #openstack-glance | 13:56 | |
| *** TravT has quit IRC | 13:59 | |
| *** tsymanczyk has joined #openstack-glance | 14:00 | |
| *** ducttape_ has joined #openstack-glance | 14:03 | |
| *** TravT has joined #openstack-glance | 14:04 | |
| *** mfedosin has quit IRC | 14:13 | |
| *** TravT has quit IRC | 14:13 | |
| * nikhil loves our newton release notes http://docs.openstack.org/releasenotes/glance/newton.html | 14:13 | |
| *** _ducttape_ has joined #openstack-glance | 14:18 | |
| *** TravT has joined #openstack-glance | 14:18 | |
| *** ducttape_ has quit IRC | 14:21 | |
| *** mfedosin has joined #openstack-glance | 14:25 | |
| *** atod has quit IRC | 14:28 | |
| *** TravT has quit IRC | 14:35 | |
| *** TravT has joined #openstack-glance | 14:40 | |
| *** burgerk has joined #openstack-glance | 14:42 | |
| openstackgerrit | Merged openstack/glance: Fix five typos on doc https://review.openstack.org/358363 | 14:42 |
| *** TravT has quit IRC | 14:49 | |
| *** jdurgin has quit IRC | 14:54 | |
| *** TravT has joined #openstack-glance | 14:54 | |
| *** rrecio_ has joined #openstack-glance | 14:57 | |
| *** mosulica has quit IRC | 15:07 | |
| *** TravT has quit IRC | 15:08 | |
| openstackgerrit | Merged openstack/glance: Dev-docs: command in code block for refresh config https://review.openstack.org/366953 | 15:08 |
| *** Linkmark has quit IRC | 15:13 | |
| *** sdake has joined #openstack-glance | 15:14 | |
| *** rcernin has quit IRC | 15:15 | |
| *** TravT has joined #openstack-glance | 15:17 | |
| *** sdake_ has joined #openstack-glance | 15:18 | |
| *** sdake has quit IRC | 15:20 | |
| hemanthm | nikhil, _sigmavirus24: Is this a likely candidate for newton backport? https://review.openstack.org/#/c/359402/ | 15:23 |
| nikhil | hemanthm: you are welcome to propose it | 15:24 |
| nikhil | hemanthm: it's one click away, see the cherry pick button on gerrit | 15:25 |
| hemanthm | nikhil: just wanted to get an opinion :) | 15:25 |
| nikhil | hemanthm: wet can discuss details on the patch itself and it can be a reference point for others too | 15:25 |
| hemanthm | alright | 15:25 |
| hemanthm | dharinic ^ | 15:26 |
| nikhil | hemanthm: k, I wasn't sure | 15:26 |
| dharinic | hemanthm, ack. :) | 15:26 |
| *** GB21 has joined #openstack-glance | 15:29 | |
| *** takedakn has quit IRC | 15:46 | |
| *** bpokorny has joined #openstack-glance | 15:46 | |
| *** MattMan has quit IRC | 15:48 | |
| *** MattMan has joined #openstack-glance | 15:49 | |
| *** ctrath1 has joined #openstack-glance | 15:52 | |
| *** groen692 has quit IRC | 15:55 | |
| *** ctrath has quit IRC | 15:56 | |
| *** bpokorny has quit IRC | 15:58 | |
| *** e0ne has quit IRC | 15:58 | |
| *** bpokorny has joined #openstack-glance | 15:58 | |
| tsymanczyk | rosmaita: nikhil buenos dias y buenos viernes! re community images sync, there's a little bit to talk about. | 16:03 |
| *** mtanino has joined #openstack-glance | 16:03 | |
| *** bpokorny has quit IRC | 16:03 | |
| tsymanczyk | like i said yesterday, i'm working on a total rewrite of the first horrible patch and it's going well. all of the py34 unit tests pass, and iirc right now 34 py27 unit tests say that they fail - although i'm not sure if theres another batch of tests that would run after that batch if they had all passed. | 16:04 |
| tsymanczyk | the really big difference with this new changeset is that i'm trying very hard to ONLY target and change the instances of is_public that represent backend data. so in the case of unit tests, that would be the dict fixtures and their associated assertTrue(i[is_public]) for example | 16:05 |
| *** bpokorny has joined #openstack-glance | 16:05 | |
| *** TravT has quit IRC | 16:05 | |
| tsymanczyk | (to me) if this change were done and 100% perfect, the interface should not change AT ALL. no invocations should change AT ALL. it shouldn't be necessary. this is only a DB schema change. | 16:06 |
| *** takedakn has joined #openstack-glance | 16:06 | |
| *** takedakn has quit IRC | 16:07 | |
| tsymanczyk | anyways the 30 some py27 that currently fail are of the nature that nikhil had regretably encountered when helping with the last changeset - the answers answers are coming back the opposite way as they should. | 16:07 |
| tsymanczyk | my GUT FEELING is this is indicative that i've neglected to identify a different portion of code that needs to change. i have yet to see an objective reason why, with the new change, an additional compatibility layer or any additional complexity should be NECESSARY. but i guess we'll see. | 16:08 |
| tsymanczyk | i have not yet had the opportunity to investigate these failing tests as deeply as i'd like, will do that today - getting anyone else involved at this point would be too premature and a waste of your time. | 16:08 |
| tsymanczyk | but there's one portion of the new changeset i wanted to explicitly call out since i think there's a strong potential for misunderstanding or tension unless i slip in the backstory, logic, and plan | 16:09 |
| tsymanczyk | (looking up files & line numbers) | 16:10 |
| *** TravT has joined #openstack-glance | 16:10 | |
| tsymanczyk | here, the diff between base and patchset 3 highlights what i wanted to throw a spotlight on | 16:12 |
| tsymanczyk | https://review.openstack.org/#/c/369110/3/glance/db/sqlalchemy/api.py | 16:12 |
| tsymanczyk | so part of the confusion i've always had was what to do when the is_public param may conflict with a visibility request, so that's handled in a way that i feel is rather clean and non-disruptive | 16:13 |
| tsymanczyk | but the BIGGER confusion i've always had is the difference between the is_public param and the is_public filter option. | 16:13 |
| tsymanczyk | ONLY FOR MY OWN BENEFIT OF UNDERSTANDING and making my life as easy as possible, early in this changeset i chose to simply disable the is_public filter | 16:14 |
| tsymanczyk | after really looking at what we "lose" by having it disabled, in retrospect i think that i'd argue this feature shouldn't exist at all | 16:14 |
| tsymanczyk | if you look at the 3 unit tests that i disabled to make it work, they're all setting a COMPLETELY SEPARATE AND DISTINCT 'is_public' PROPERTY (separate from the is_public db value) to arbitrary garbage values. | 16:15 |
| tsymanczyk | from a fundamental "data duplication is bad" and "ambiguity is bad" perspective i don't see how that can be a desirable ability. | 16:16 |
| tsymanczyk | but anyways. | 16:16 |
| tsymanczyk | the long and short of it is that i'm not at all trying to force through these disabling as part of my changeset. | 16:16 |
| tsymanczyk | if this is a feature that must remain, i'm happy to try adding it back in later after i've gotten this simplified version of the code solid with the desired changes. | 16:17 |
| tsymanczyk | i think that's all from my end. | 16:17 |
| * tsymanczyk is done monologuing. | 16:18 | |
| tsymanczyk | i'll be around for at least the next hour and half whenever you guys pop in. | 16:19 |
| tsymanczyk | oh one last thing because i love hearing myself type. | 16:28 |
| tsymanczyk | i know that one of the big concerns regarding screwing with is_public is that it has some weirdness grandfathered in to accommodate v1 admin vs admin-as-regular user requests. | 16:28 |
| nikhil | tsymanczyk: was reading through and trying to digest this :) | 16:28 |
| tsymanczyk | nikhil : no worries or rush at all. i know it's a lot at once. | 16:29 |
| nikhil | tsymanczyk: yeah, that is the weirdness with admin and admin as user | 16:29 |
| nikhil | tsymanczyk: can you show me where is the conflicting behavior you see? | 16:30 |
| tsymanczyk | i tried to the best of my ability to manually test with the old glancecli and osc with v1 and v2, and i have yet to see a difference in actual realworld functionality with having this property/filter disabled. it all still works as intended afaict. | 16:30 |
| *** hemanthm is now known as hemanthm|vto | 16:30 | |
| tsymanczyk | nikhil : there's nothing i can point you to. it was always just ambiguity in my head or in the design - like what if someone were to somehow send a request that was is_public=True and visibility=community. what do you do? it makes no sense. | 16:31 |
| tsymanczyk | when i originally added that code that ensured they made sense together i was ASSUMING there would be conflicts. but in reality i haven't seen any. | 16:31 |
| nikhil | tsymanczyk: interesting, I thought in v2 we ignored is_public | 16:32 |
| tsymanczyk | and in fact the preexisting unit tests that attempt to make calls with both, the comments actually explicitly say "we're testing these scenarios to be complete, but this is not an anticipated use case". | 16:32 |
| tsymanczyk | nikhil : if there's a way to invoke is-public using the v2 interface in the real world i don't know how to do it. but there do seem to be unit tests that force it. | 16:33 |
| nikhil | tsymanczyk: this is weird! | 16:33 |
| tsymanczyk | either that or i simply have misunderstood code. | 16:33 |
| tsymanczyk | lemme find the file and lines i'm tlaking about. | 16:34 |
| nikhil | tsymanczyk: most likely tests are wrong but if they are /unit/ that means, they are testing some specific thing | 16:34 |
| tsymanczyk | starting at line 2191 in tests/functional/db/base.py | 16:35 |
| nikhil | tsymanczyk: the main reason I was suggesting compat layer was the v1 admin and admin as user use case | 16:35 |
| tsymanczyk | sure. | 16:35 |
| nikhil | tsymanczyk: the visibility does come back as private when is_public true for some images | 16:36 |
| tsymanczyk | i'm hoping that won't be necessary now that so much unnecessary garbage (of mine :) ) is no longer there. | 16:36 |
| tsymanczyk | oh! | 16:36 |
| tsymanczyk | oh. | 16:36 |
| tsymanczyk | oh :( | 16:36 |
| nikhil | tsymanczyk: and that is the result of intersecting use cases for v1 and v2 | 16:36 |
| tsymanczyk | well that's clearly a case i hadn't understood. | 16:36 |
| *** _ducttape_ has quit IRC | 16:36 | |
| nikhil | tsymanczyk: remember, we have another field called protected for restricting the image access :) | 16:36 |
| *** ducttape_ has joined #openstack-glance | 16:37 | |
| tsymanczyk | nikhil : so how do we go forward? | 16:37 |
| *** ducttape_ has quit IRC | 16:38 | |
| *** GB21 has quit IRC | 16:38 | |
| *** ducttape_ has joined #openstack-glance | 16:38 | |
| *** TravT has quit IRC | 16:40 | |
| *** dshakhray has quit IRC | 16:42 | |
| *** TravT has joined #openstack-glance | 16:45 | |
| nikhil | tsymanczyk: ha! I don't know where exactly are you stuck | 16:46 |
| tsymanczyk | nikhil only regarding the cases you had mentioned, where visibility would be private and is_public used to be 'true'. the other broken tests i can handle fine. but that seems like a ... design / architecture decision. | 16:47 |
| tsymanczyk | since now there is no is_public property at all. | 16:48 |
| nikhil | tsymanczyk: what is the most weird part -- the functional tests are for only DB api but we need to find that filtering conflict for the API too to make sense of things | 16:48 |
| nikhil | tsymanczyk: I am guessing the above comment for osc / glanceclient were for the tests you did on the v1, v2 API with the combination of filters? | 16:49 |
| *** agireud has quit IRC | 16:49 | |
| *** agireud has joined #openstack-glance | 16:51 | |
| *** bpokorny_ has joined #openstack-glance | 16:52 | |
| tsymanczyk | nikhil : the manual testing i had done with v1/v2/osc/glancecli were all comparing the old and "current" behaviours (with the is_public property being ignored). specifically including the admin behaviour. at no point did have i ever successfully combine options with any of glancecli osc horizon or curl. | 16:53 |
| *** ctrath1 has quit IRC | 16:53 | |
| *** bpokorny_ has quit IRC | 16:53 | |
| *** bpokorn__ has joined #openstack-glance | 16:53 | |
| *** bpokorny has quit IRC | 16:55 | |
| nikhil | tsymanczyk: okay, I think we need to add a bullet list of break points in our etherpad.. I was unable to comprehend your experience with those filters from that message. (sorry I just think like that, more explicitly) | 16:56 |
| *** mwturvey has quit IRC | 16:56 | |
| nikhil | tsymanczyk: adding notes to the bottom of the etherpad https://etherpad.openstack.org/p/community-images-work-items | 16:57 |
| tsymanczyk | nikhil : i'm happy to document anything you'd like as explicitly as you'd like. | 16:57 |
| nikhil | tsymanczyk: does that make sense? | 17:07 |
| nikhil | line #46 onward | 17:07 |
| tsymanczyk | what you've written certainly makes sense | 17:08 |
| tsymanczyk | my concern would be the difference between what can actually be invoked in reality by hitting the API, and what can be invoked by unit tests playing funny games trying to hit weirdo corner cases. | 17:09 |
| tsymanczyk | for example i don't currently believe that is_public can "get through" a v2 call. | 17:09 |
| tsymanczyk | but if that's the case, then i guess that's what gets documented. | 17:09 |
| nikhil | tsymanczyk: exactly, I have a feeling that unit tests were written to keep a check on the DB api changes then | 17:10 |
| tsymanczyk | nikhil : can you please clarify the difference between a user-admin and glance-admin ? | 17:10 |
| nikhil | tsymanczyk: i.e when developing v2, mark wanted to keep sanity check on v1 | 17:10 |
| *** ducttape_ has quit IRC | 17:11 | |
| nikhil | tsymanczyk: user admin has access to only the tenancy that user belongs to | 17:11 |
| nikhil | tsymanczyk: glance admin gets entire DB access | 17:11 |
| nikhil | tsymanczyk: but we mostly run with user_is_tenant=True so user admin cases are rare | 17:12 |
| tsymanczyk | nikhil : which of those two happen when the user has the 'admin' role? how would i invoke the other? | 17:12 |
| nikhil | tsymanczyk: I'm 90% sure that glance ignores user-admin but I don't remember all tests | 17:15 |
| nikhil | tsymanczyk: so, we will need to create a user admin in devstack and test it | 17:15 |
| nikhil | tsymanczyk: the admin created with shipped configs is project admin | 17:15 |
| nikhil | (in devstack) | 17:15 |
| tsymanczyk | nikhil : i can see with certainty that i've used the is_public=None 'hack' successfully via v1 using the default devstack admin | 17:16 |
| tsymanczyk | nikhil : regarding the other types of admins, i'm afraid i'm not familiar with them / how to do them. glance-admin and user-admin. | 17:17 |
| nikhil | tsymanczyk: the devstack admin is glance-admin (project admin) | 17:18 |
| nikhil | tsymanczyk: other type of admin is something we need to create a role in devstack keystone setup | 17:18 |
| *** sdake_ has quit IRC | 17:18 | |
| nikhil | tsymanczyk: but like I said on the etherpad, we don't need to rush it. it can be our final sanity check when the patch is close to getting +2s | 17:18 |
| tsymanczyk | nikhil : yeah, agreed. | 17:19 |
| tsymanczyk | nikhil : the more immediate question is how you'd like me to handle the failing unit tests where the old behaviour is known that the visibility value and is_public value conflict? (unless i misunderstood the problem you were trying to point out earlier) | 17:20 |
| nikhil | tsymanczyk: I think we don't need to test the enntire 72 sub cases, a decent 15-16 randomly chosen should help during the dev process. | 17:20 |
| nikhil | tsymanczyk: are you talking about this test https://github.com/openstack/glance/blob/master/glance/tests/functional/db/base.py#L2191 ? | 17:21 |
| tsymanczyk | no, those tests are fine. | 17:21 |
| tsymanczyk | nikhil : i'll point you to a specific example in a few minutes. | 17:22 |
| tsymanczyk | i ctrl-k'd my output already unfortunatel. | 17:22 |
| nikhil | tsymanczyk: kk | 17:22 |
| tsymanczyk | nikhil : you know what this really isn't worth discussing right now. i'd like to be 100% sure about what i'm saying before i go asking difficult questions (that may be only based on imagination). | 17:25 |
| tsymanczyk | nikhil : i'll work on the tests i suspect are going to be problematic, and bother you early next week with any i find actually need a design or arch decision made. | 17:25 |
| *** rvasilets___ has joined #openstack-glance | 17:25 | |
| *** e0ne has joined #openstack-glance | 17:26 | |
| nikhil | tsymanczyk: sounds good! ttyl then. (feel free to ping me q.s. though) | 17:28 |
| tsymanczyk | nikhil : awesome, thank you. have a good weekend if we don't speak again before then. | 17:29 |
| nikhil | tsymanczyk: have a good one yourself :) | 17:31 |
| * nikhil away | 17:31 | |
| openstackgerrit | Alexander Bashmakov proposed openstack/glance: Trivial doc fix. https://review.openstack.org/371727 | 17:35 |
| *** mfedosin has quit IRC | 17:40 | |
| *** bpokorn__ has quit IRC | 17:44 | |
| *** bpokorny has joined #openstack-glance | 17:44 | |
| *** bpokorny has quit IRC | 17:44 | |
| *** bpokorny has joined #openstack-glance | 17:45 | |
| *** ducttape_ has joined #openstack-glance | 17:45 | |
| *** TravT has quit IRC | 18:08 | |
| openstackgerrit | Alexander Bashmakov proposed openstack/glance: Update api-ref to add newly supported 'vhdx' disk format option. https://review.openstack.org/356693 | 18:09 |
| *** harlowja has joined #openstack-glance | 18:13 | |
| *** ducttape_ has quit IRC | 18:13 | |
| *** chlong_ has quit IRC | 18:27 | |
| *** e0ne has quit IRC | 18:30 | |
| *** dshakhray has joined #openstack-glance | 18:41 | |
| *** thiagolib has quit IRC | 18:58 | |
| *** bpokorny has quit IRC | 19:00 | |
| *** anush__ has quit IRC | 19:08 | |
| *** anush__ has joined #openstack-glance | 19:09 | |
| *** mfedosin has joined #openstack-glance | 19:27 | |
| dharinic | nikhil can you please have a look at this when free and share what you think about comments on line 289? https://review.openstack.org/#/c/367528/5/glance/api/v2/image_data.py | 19:30 |
| *** david-lyle has quit IRC | 19:30 | |
| *** david-lyle has joined #openstack-glance | 19:30 | |
| *** atod has joined #openstack-glance | 19:38 | |
| *** david-lyle has quit IRC | 19:43 | |
| nikhil | dharinic: looking now | 19:44 |
| dharinic | cool. Thanks nikhil. Here is the link for the method - https://github.com/openstack/glance/blob/master/glance/common/wsgi.py#L975-L983 | 19:50 |
| openstackgerrit | Ying Zuo proposed openstack/glance: Fix inconsistent metadata names https://review.openstack.org/303658 | 19:52 |
| *** TravT has joined #openstack-glance | 19:57 | |
| *** openstackstatus has quit IRC | 19:58 | |
| *** TravT has quit IRC | 19:59 | |
| *** sdake has joined #openstack-glance | 19:59 | |
| *** openstackstatus has joined #openstack-glance | 19:59 | |
| *** ChanServ sets mode: +v openstackstatus | 19:59 | |
| *** bpokorny has joined #openstack-glance | 20:00 | |
| *** bpokorny has quit IRC | 20:01 | |
| *** bpokorny has joined #openstack-glance | 20:02 | |
| *** TravT has joined #openstack-glance | 20:02 | |
| openstackgerrit | Alexander Bashmakov proposed openstack/glance: Update description of image_destroy method. https://review.openstack.org/371727 | 20:02 |
| *** atod has quit IRC | 20:08 | |
| *** smatzek has quit IRC | 20:19 | |
| *** ccesario has quit IRC | 20:35 | |
| *** sdake has quit IRC | 20:37 | |
| *** baojg_ has joined #openstack-glance | 20:40 | |
| *** baojg has quit IRC | 20:43 | |
| *** atod has joined #openstack-glance | 20:49 | |
| *** baojg_ has quit IRC | 20:51 | |
| *** edmondsw has quit IRC | 20:51 | |
| *** baojg has joined #openstack-glance | 20:52 | |
| *** sdake has joined #openstack-glance | 20:55 | |
| nikhil | dharinic: had to go then, back now looking | 20:56 |
| dharinic | no problem nikhil | 20:56 |
| *** baojg has quit IRC | 21:00 | |
| *** burgerk has quit IRC | 21:14 | |
| *** sdake has quit IRC | 21:20 | |
| *** sdake has joined #openstack-glance | 21:21 | |
| *** sdake has quit IRC | 21:25 | |
| nikhil | dharinic: just done with the reasearch on your patch. I think stevelle is right for making that change at the wsgi layer | 21:29 |
| nikhil | dharinic: was that the question though :) ? | 21:29 |
| dharinic | awesome. Thank you nikhil. Wanted to make sure all of us were on the same page. :) | 21:29 |
| dharinic | The question was: I was currentl;y translating a 400 returned by a method "get_content_range()" from glance/common/wsgi.py to 416 for malformed content range. | 21:30 |
| dharinic | So wanted to make sure that it was okay to edit that method in wsgi.py to directly return 416 | 21:30 |
| dharinic | as Steve had suggested. | 21:31 |
| nikhil | excellent | 21:31 |
| nikhil | dharinic: that is one convoluted review! | 21:31 |
| dharinic | Glad to have created such a review ;) | 21:31 |
| *** ctrath has joined #openstack-glance | 21:31 | |
| nikhil | dharinic: too much good enough time to wrap my head around all the different things you are fixing | 21:31 |
| nikhil | indeed! | 21:31 |
| nikhil | dharinic: I have some side comments, will comment there | 21:31 |
| dharinic | yayy. :) That made my day (and weekend) | 21:32 |
| dharinic | Sure. Waiting for it. | 21:32 |
| dharinic | I have the fix on wsgi.py ready. Was waiting for your comments. | 21:32 |
| *** ctrath has quit IRC | 21:34 | |
| *** dshakhray has quit IRC | 21:35 | |
| nikhil | dharinic: nice work | 21:36 |
| nikhil | dharinic: you can push your latest and I can comment on it | 21:36 |
| dharinic | Cool. Will do. | 21:37 |
| dharinic | Thanks nikhil :) | 21:37 |
| openstackgerrit | Dharini Chandrasekar proposed openstack/glance: Handling HTTP range requests in Glance https://review.openstack.org/367528 | 21:38 |
| nikhil | dharinic: still around for weekend? | 22:09 |
| dharinic | nikhil, yeah | 22:09 |
| nikhil | dharinic: got a few comments coming up | 22:10 |
| dharinic | Sure | 22:10 |
| nikhil | dharinic: you don't have to fix them today though :) | 22:10 |
| nikhil | dharinic: you can ask me questions if needed | 22:11 |
| *** bpokorny has quit IRC | 22:11 | |
| dharinic | sure. I can see a -1 on its way :D | 22:11 |
| nikhil | dharinic: ha | 22:13 |
| nikhil | it is, sorry about ruining your friday mood | 22:13 |
| *** bpokorny has joined #openstack-glance | 22:15 | |
| dharinic | Haha. Not at all. | 22:17 |
| openstackgerrit | Merged openstack/glance: Update description of image_destroy method. https://review.openstack.org/371727 | 22:19 |
| *** catintheroof has quit IRC | 22:31 | |
| *** markvoelker has quit IRC | 22:34 | |
| *** david-lyle has joined #openstack-glance | 22:48 | |
| openstackgerrit | Dharini Chandrasekar proposed openstack/glance: Fixing inconsistency in Glance store names. https://review.openstack.org/359402 | 22:52 |
| *** mfedosin has quit IRC | 23:00 | |
| *** erhudy has quit IRC | 23:02 | |
| openstackgerrit | Dharini Chandrasekar proposed openstack/glance: Fixing inconsistency in Glance store names. https://review.openstack.org/359402 | 23:05 |
| *** jdillaman has quit IRC | 23:09 | |
| openstackgerrit | Timothy Symanczyk proposed openstack/glance: WIP EXPERIMENT of deprecating the is_public column https://review.openstack.org/369110 | 23:12 |
| *** TravT has quit IRC | 23:16 | |
| *** rvasilets___ has quit IRC | 23:27 | |
| *** bpokorny has quit IRC | 23:38 | |
| *** bpokorny has joined #openstack-glance | 23:39 | |
| *** jdillaman has joined #openstack-glance | 23:40 | |
| *** bpokorny has quit IRC | 23:43 | |
| *** atod has quit IRC | 23:43 | |
| *** bpokorny has joined #openstack-glance | 23:46 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!