| *** bpokorny_ has quit IRC | 00:02 | |
| *** bpokorny has joined #openstack-glance | 00:02 | |
| *** chlong has quit IRC | 00:05 | |
| *** agireud has joined #openstack-glance | 00:11 | |
| *** david-lyle has joined #openstack-glance | 00:14 | |
| openstackgerrit | Timothy Symanczyk proposed openstack/glance: WIP Add explicit 'visibility' column to images https://review.openstack.org/326128 | 00:19 |
|---|---|---|
| *** agireud has quit IRC | 00:22 | |
| *** ducttape_ has quit IRC | 00:23 | |
| *** agireud has joined #openstack-glance | 00:29 | |
| *** ducttape_ has joined #openstack-glance | 00:31 | |
| *** agireud has quit IRC | 00:36 | |
| *** buzztroll has quit IRC | 00:39 | |
| *** agireud has joined #openstack-glance | 00:40 | |
| *** david-lyle has quit IRC | 00:46 | |
| *** pt_15 has quit IRC | 00:46 | |
| *** itisha has quit IRC | 00:50 | |
| openstackgerrit | Jamie Lennox proposed openstack/glance: Use oslo.context features https://review.openstack.org/314889 | 00:51 |
| *** bpokorny has quit IRC | 00:59 | |
| *** david-lyle has joined #openstack-glance | 01:13 | |
| *** gjayavelu has joined #openstack-glance | 01:17 | |
| *** ozialien10 has joined #openstack-glance | 01:18 | |
| *** david-lyle has quit IRC | 01:18 | |
| *** dhellmann has quit IRC | 01:19 | |
| *** gjayavelu has quit IRC | 01:21 | |
| *** dhellmann has joined #openstack-glance | 01:26 | |
| *** chlong has joined #openstack-glance | 01:27 | |
| *** prateek has joined #openstack-glance | 01:30 | |
| *** dhellmann has quit IRC | 01:31 | |
| *** dhellmann has joined #openstack-glance | 01:31 | |
| *** prateek has quit IRC | 01:36 | |
| *** dhellmann has quit IRC | 01:39 | |
| *** dhellmann has joined #openstack-glance | 01:39 | |
| *** buzztroll has joined #openstack-glance | 01:40 | |
| *** buzztroll has quit IRC | 01:45 | |
| *** dhellmann has quit IRC | 01:45 | |
| *** dhellmann has joined #openstack-glance | 01:46 | |
| *** ducttape_ has quit IRC | 01:48 | |
| *** dhellmann has quit IRC | 01:51 | |
| *** dhellmann has joined #openstack-glance | 01:52 | |
| *** dhellmann has quit IRC | 01:59 | |
| *** dhellmann has joined #openstack-glance | 02:00 | |
| *** ducttape_ has joined #openstack-glance | 02:03 | |
| *** chlong has quit IRC | 02:08 | |
| *** ducttape_ has quit IRC | 02:24 | |
| *** ametts has joined #openstack-glance | 02:40 | |
| *** dharinic_ has joined #openstack-glance | 02:44 | |
| *** ducttape_ has joined #openstack-glance | 02:51 | |
| *** dharinic_ has quit IRC | 02:51 | |
| *** buzztroll has joined #openstack-glance | 02:57 | |
| *** aslaen has joined #openstack-glance | 03:00 | |
| *** dharinic_ has joined #openstack-glance | 03:01 | |
| *** sdake has joined #openstack-glance | 03:08 | |
| *** sdake_ has joined #openstack-glance | 03:10 | |
| *** sdake has quit IRC | 03:14 | |
| *** sdake_ has quit IRC | 03:15 | |
| *** sdake has joined #openstack-glance | 03:17 | |
| *** dharinic_ has quit IRC | 03:22 | |
| *** btully has joined #openstack-glance | 03:25 | |
| *** btully has quit IRC | 03:30 | |
| *** pdeore__ has joined #openstack-glance | 03:37 | |
| *** aslaen has left #openstack-glance | 03:42 | |
| *** MattMan has quit IRC | 03:43 | |
| *** MattMan has joined #openstack-glance | 03:43 | |
| *** GB21 has joined #openstack-glance | 03:44 | |
| *** ducttape_ has quit IRC | 03:53 | |
| *** btully has joined #openstack-glance | 04:13 | |
| openstackgerrit | Merged openstack/glance_store: Remove unused variable in vmware store https://review.openstack.org/339277 | 04:14 |
| *** chlong has joined #openstack-glance | 04:20 | |
| *** links has joined #openstack-glance | 04:24 | |
| *** ametts has quit IRC | 04:26 | |
| *** ametts has joined #openstack-glance | 04:26 | |
| *** sdake has quit IRC | 04:27 | |
| *** sdake has joined #openstack-glance | 04:27 | |
| *** buzztroll has quit IRC | 04:48 | |
| *** mfedosin has joined #openstack-glance | 04:49 | |
| *** ratailor has joined #openstack-glance | 04:52 | |
| *** mfedosin has quit IRC | 04:54 | |
| *** ametts has quit IRC | 05:01 | |
| *** flwang1 has quit IRC | 05:06 | |
| *** gjayavelu has joined #openstack-glance | 05:17 | |
| *** GB21 has quit IRC | 05:19 | |
| *** mfedosin has joined #openstack-glance | 05:20 | |
| *** ducttape_ has joined #openstack-glance | 05:24 | |
| *** ducttape_ has quit IRC | 05:29 | |
| *** groen692 has joined #openstack-glance | 05:35 | |
| *** ametts has joined #openstack-glance | 05:37 | |
| *** sdake_ has joined #openstack-glance | 05:39 | |
| *** sdake has quit IRC | 05:42 | |
| *** GB21 has joined #openstack-glance | 05:58 | |
| *** rcernin has joined #openstack-glance | 06:09 | |
| *** pdeore__ has quit IRC | 06:23 | |
| *** chlong has quit IRC | 06:42 | |
| *** GB21 has quit IRC | 06:43 | |
| *** pcaruana has joined #openstack-glance | 06:51 | |
| *** ntt has joined #openstack-glance | 06:53 | |
| *** GB21 has joined #openstack-glance | 06:55 | |
| *** tesseract- has joined #openstack-glance | 06:59 | |
| *** btully has quit IRC | 07:02 | |
| *** ducttape_ has joined #openstack-glance | 07:26 | |
| *** ducttape_ has quit IRC | 07:30 | |
| *** GB21 has quit IRC | 07:33 | |
| *** ntt has quit IRC | 07:37 | |
| *** ntt has joined #openstack-glance | 07:42 | |
| *** mine0901 has joined #openstack-glance | 07:48 | |
| *** rcernin has quit IRC | 08:02 | |
| *** sdake_ has quit IRC | 08:07 | |
| *** sdake has joined #openstack-glance | 08:08 | |
| *** sdake has quit IRC | 08:08 | |
| *** sdake has joined #openstack-glance | 08:08 | |
| *** MattMan has quit IRC | 08:15 | |
| *** mick_m has joined #openstack-glance | 08:17 | |
| *** GB21 has joined #openstack-glance | 08:17 | |
| *** MattMan has joined #openstack-glance | 08:19 | |
| *** rcernin has joined #openstack-glance | 08:22 | |
| *** ducttape_ has joined #openstack-glance | 08:27 | |
| *** ducttape_ has quit IRC | 08:31 | |
| *** btully has joined #openstack-glance | 08:47 | |
| *** rsjethani has joined #openstack-glance | 08:50 | |
| *** btully has quit IRC | 08:51 | |
| *** gjayavelu has quit IRC | 09:03 | |
| *** pt_15 has joined #openstack-glance | 09:08 | |
| *** mick_m has quit IRC | 09:10 | |
| openstackgerrit | Ilya Menkov proposed openstack/glance: [WIP][Glare] add tests for create and update artifacts https://review.openstack.org/338868 | 09:11 |
| *** aswadr_ has joined #openstack-glance | 09:17 | |
| *** ducttape_ has joined #openstack-glance | 09:28 | |
| openstackgerrit | Kairat Kushaev proposed openstack/glance: [WIP][Glare] add tests for create and update artifacts https://review.openstack.org/338868 | 09:28 |
| openstackgerrit | Kairat Kushaev proposed openstack/glance: [WIP][Glare] add tests for create and update artifacts https://review.openstack.org/338868 | 09:29 |
| *** sdake has quit IRC | 09:30 | |
| openstackgerrit | Kairat Kushaev proposed openstack/glance: [WIP] Glare https://review.openstack.org/292327 | 09:32 |
| *** ducttape_ has quit IRC | 09:33 | |
| *** YifanZeng has quit IRC | 09:34 | |
| *** GB21 has quit IRC | 09:44 | |
| *** mine0901 has quit IRC | 09:53 | |
| *** GB21 has joined #openstack-glance | 09:56 | |
| *** rcernin has quit IRC | 10:15 | |
| *** ducttape_ has joined #openstack-glance | 10:28 | |
| *** ducttape_ has quit IRC | 10:33 | |
| *** nikhil has quit IRC | 10:33 | |
| bunting | Is CI broken for us? | 10:34 |
| *** nikhil has joined #openstack-glance | 10:34 | |
| bunting | gate-tempest-dsvm-postgres-full | 10:35 |
| kairat__ | Yep, looks like it is broken | 10:57 |
| *** rcernin has joined #openstack-glance | 11:08 | |
| openstackgerrit | Mike Fedosin proposed openstack/glance: [WIP] Marker and pagination updates https://review.openstack.org/339473 | 11:16 |
| *** mfedosin has quit IRC | 11:23 | |
| *** ducttape_ has joined #openstack-glance | 11:29 | |
| *** ntt has quit IRC | 11:33 | |
| *** ducttape_ has quit IRC | 11:34 | |
| openstackgerrit | Kairat Kushaev proposed openstack/glance: [WIP][Glare] Add tests for artifact activate-reactivate https://review.openstack.org/338868 | 11:50 |
| *** mfedosin has joined #openstack-glance | 11:53 | |
| *** gjayavelu has joined #openstack-glance | 12:02 | |
| *** pt_15 has quit IRC | 12:06 | |
| *** ducttape_ has joined #openstack-glance | 12:07 | |
| *** gjayavelu has quit IRC | 12:08 | |
| *** jdurgin has quit IRC | 12:10 | |
| *** GB21 has quit IRC | 12:16 | |
| *** ccesario has quit IRC | 12:23 | |
| *** pdeore__ has joined #openstack-glance | 12:24 | |
| *** btully has joined #openstack-glance | 12:25 | |
| *** jdurgin has joined #openstack-glance | 12:28 | |
| *** btully has quit IRC | 12:30 | |
| *** takedakn has joined #openstack-glance | 12:31 | |
| *** takedakn has quit IRC | 12:33 | |
| *** ducttape_ has quit IRC | 12:37 | |
| *** ratailor has quit IRC | 12:43 | |
| *** mfedosin has quit IRC | 12:43 | |
| rosmaita | flwang: any chance you are around? | 12:49 |
| rosmaita | (i should be available for the next 8 hours or so) | 12:49 |
| *** buzztroll has joined #openstack-glance | 12:53 | |
| *** links has quit IRC | 13:15 | |
| *** ducttape_ has joined #openstack-glance | 13:29 | |
| *** cdelatte has quit IRC | 13:37 | |
| *** cdelatte has joined #openstack-glance | 13:37 | |
| *** pdeore__ has quit IRC | 13:40 | |
| *** ducttape_ has quit IRC | 13:42 | |
| *** mfedosin has joined #openstack-glance | 13:46 | |
| openstackgerrit | Brian Rosmaita proposed openstack/glance-specs: Database strategy for rolling upgrades https://review.openstack.org/331740 | 13:48 |
| *** takedakn has joined #openstack-glance | 13:50 | |
| *** takedakn has quit IRC | 13:52 | |
| *** thumpba has joined #openstack-glance | 13:56 | |
| *** sigmavirus_away is now known as sigmavirus | 14:03 | |
| rsjethani | Hi jokke_ | 14:04 |
| *** burgerk has joined #openstack-glance | 14:08 | |
| *** ducttape_ has joined #openstack-glance | 14:08 | |
| *** mtanino has joined #openstack-glance | 14:10 | |
| *** burgerk has quit IRC | 14:15 | |
| *** rsjethani has quit IRC | 14:17 | |
| openstackgerrit | Akhila Kishore proposed openstack/glance: Nitpick spell change https://review.openstack.org/338594 | 14:26 |
| openstackgerrit | Kairat Kushaev proposed openstack/glance: [WIP] Glare https://review.openstack.org/338868 | 14:28 |
| *** Baregna has joined #openstack-glance | 14:30 | |
| openstackgerrit | Kairat Kushaev proposed openstack/glance: [WIP] Glare https://review.openstack.org/292327 | 14:34 |
| *** Baregna has quit IRC | 14:44 | |
| *** links has joined #openstack-glance | 14:45 | |
| *** thumpba has quit IRC | 14:50 | |
| *** thumpba has joined #openstack-glance | 14:51 | |
| *** rrecio has joined #openstack-glance | 14:51 | |
| *** rrecio_ has joined #openstack-glance | 14:53 | |
| *** links has quit IRC | 14:54 | |
| *** burgerk has joined #openstack-glance | 14:56 | |
| *** rrecio has quit IRC | 14:56 | |
| *** dharinic_ has joined #openstack-glance | 15:07 | |
| *** david-lyle has joined #openstack-glance | 15:08 | |
| *** sdake has joined #openstack-glance | 15:10 | |
| *** sdake_ has joined #openstack-glance | 15:12 | |
| *** pcaruana has quit IRC | 15:13 | |
| *** hemanthm|afk is now known as hemanthm | 15:15 | |
| *** sdake has quit IRC | 15:15 | |
| *** ducttape_ has quit IRC | 15:16 | |
| *** sdake_ has quit IRC | 15:17 | |
| *** sdake has joined #openstack-glance | 15:18 | |
| *** gjayavelu has joined #openstack-glance | 15:18 | |
| *** tesseract- has quit IRC | 15:27 | |
| *** sdake_ has joined #openstack-glance | 15:27 | |
| *** groen693 has joined #openstack-glance | 15:29 | |
| *** groen692 has quit IRC | 15:30 | |
| *** groen693 is now known as groen692 | 15:30 | |
| *** sdake has quit IRC | 15:32 | |
| *** bpokorny has joined #openstack-glance | 15:32 | |
| *** bpokorny has quit IRC | 15:32 | |
| *** bpokorny has joined #openstack-glance | 15:32 | |
| *** sdake_ has quit IRC | 15:35 | |
| *** ducttape_ has joined #openstack-glance | 15:37 | |
| *** prateek has joined #openstack-glance | 15:41 | |
| *** sdake has joined #openstack-glance | 15:45 | |
| *** prateek has quit IRC | 15:47 | |
| *** prateek has joined #openstack-glance | 15:48 | |
| *** tsymanczyk has joined #openstack-glance | 15:54 | |
| *** btully has joined #openstack-glance | 16:02 | |
| *** ametts has quit IRC | 16:05 | |
| *** bpokorny has quit IRC | 16:06 | |
| tsymanczyk | nikhil rosmaita : good morning and happy friday! re community images sync. no movement in the past week on the spec, so if anyone has any remaining issues they're playing it close to the chest. the code is progressing much more slowly than i would really like but i have no current blockers. two questions have come up that i'd appreciate your insight on 1) to | 16:07 |
| tsymanczyk | what extent does "shared" visibility currently exist? brian istr during the v-midcycle you had said something along the lines of "some people believe incorrectly that glance currently has a shared visibility" so i would assume that that doesn't currently exist, but some of the tests i was reading earlier seem to at least try and use a 'shared' status. in my | 16:07 |
| tsymanczyk | local testing adding members to a private image does not change the visibility away from 'private' for an image show command. anyways the answer seems clear i just wanted to confirm. and 2) i noticed that there's currently a 'visibility' column in the artifacts table which is a varchar(32). that isn't directly relevant to anything we're doing, right? i'm | 16:07 |
| tsymanczyk | terribly familiar with ALL of the glance functionality, and wanted to check with you as to whether or not that column should also be switched to an enum somewhere along this journey. | 16:07 |
| * tsymanczyk drops the mic | 16:07 | |
| *** gjayavelu has quit IRC | 16:07 | |
| *** bpokorny has joined #openstack-glance | 16:14 | |
| *** GB21 has joined #openstack-glance | 16:17 | |
| *** gjayavelu has joined #openstack-glance | 16:17 | |
| *** gjayavelu has quit IRC | 16:17 | |
| *** rcernin has quit IRC | 16:18 | |
| *** groen692 has quit IRC | 16:18 | |
| *** pcaruana has joined #openstack-glance | 16:21 | |
| *** ducttape_ has quit IRC | 16:28 | |
| *** pcaruana has quit IRC | 16:31 | |
| openstackgerrit | Kairat Kushaev proposed openstack/glance: [WIP!!!] move all artifact attr specific logic to base https://review.openstack.org/339695 | 16:31 |
| *** gjayavelu has joined #openstack-glance | 16:31 | |
| nikhil | tsymanczyk: good morning. Sorry about delay, coming back from another meeting scheduled recently. | 16:32 |
| tsymanczyk | no worries. nothing terribly urgent to say. | 16:33 |
| nikhil | tsymanczyk: since we have the is public boolean for visibility, there is no such status . Now the question is the situation when that is revealed in the v2 API. Don't worry about v1 and artifacts. | 16:34 |
| nikhil | tsymanczyk: it's worth checking in the new docs proposed by rosmaita in glance gerrit review. | 16:35 |
| nikhil | tsymanczyk: one thing to notice is that there is shared filter for reducing the image list to only shared images. | 16:36 |
| *** ducttape_ has joined #openstack-glance | 16:36 | |
| nikhil | tsymanczyk: alternative is to look for functional tests in glance repi | 16:36 |
| nikhil | Repo | 16:36 |
| nikhil | Hope that helps a bit. | 16:37 |
| tsymanczyk | it certainly does, thank you. | 16:38 |
| *** gjayavelu has quit IRC | 16:41 | |
| *** ccesario has joined #openstack-glance | 16:42 | |
| *** _stowa has joined #openstack-glance | 16:43 | |
| *** _stowa has quit IRC | 16:46 | |
| *** zul_ has joined #openstack-glance | 16:47 | |
| rosmaita | tsymanczyk: nikhil: sorry, i got distracted and missed the sync | 16:47 |
| rosmaita | tsymanczyk: as nikhil said, you will see code looking for 'visibility=shared' as a query filter, but it is a signal to use the members list to figure out what images should be included in the response | 16:48 |
| rosmaita | tsymanczyk: one other thing i wanted to mention is that hemanthm and i are working on a spec for how to do rolling upgrades in glance ... we are using your change from is_public to visibility as an example to make sure our approach makes sense | 16:49 |
| rosmaita | anyway, the point is that (subject to nikhil agreeing) we may propose doing the db changes required for community images in the rolling upgrade manner | 16:51 |
| tsymanczyk | rosmaita : sounds good. what can or should i do differently to help? or am i the experiment? | 16:51 |
| rosmaita | tsymanczyk: i'll give you the link, the spec is still in progress, but you can let us know what you think | 16:51 |
| rosmaita | and yeah, you may be the experiment! | 16:51 |
| nikhil | I think that sounds like a sane plan rosmaita . I had a long discussion with Hemanth on that and it looka like candidate for testing the approach. | 16:52 |
| rosmaita | but see if you think it would be reasonable to try out as part of your changes | 16:52 |
| rosmaita | nikhil: cool | 16:52 |
| rosmaita | tsymanczyk: https://review.openstack.org/#/c/331740/ | 16:52 |
| rosmaita | that's all from me, thanks for the update | 16:54 |
| tsymanczyk | rosmaita : thanks for the link. i want to give it proper consideration and thought. will try to get back to you (with at least a 'yeah good with me' or 'that seems terrifying') before end of day. | 16:55 |
| rosmaita | tsymanczyk: thanks ... and early next week is fine | 16:56 |
| hemanthm | rosmaita: thanks for bringing that up. | 17:03 |
| hemanthm | We should at least consider splitting the migrations into expand/contract | 17:04 |
| * hemanthm thinks it needs a separate spec possibly | 17:04 | |
| rosmaita | hemanthm: possibly (separate spec), but let's work out the issues on the current spec first | 17:06 |
| hemanthm | sure | 17:06 |
| *** davideagnello has joined #openstack-glance | 17:19 | |
| *** rcernin has joined #openstack-glance | 17:20 | |
| *** rcernin has quit IRC | 17:20 | |
| *** rcernin has joined #openstack-glance | 17:24 | |
| *** sdake_ has joined #openstack-glance | 17:30 | |
| *** zul has quit IRC | 17:31 | |
| *** prateek has quit IRC | 17:33 | |
| *** sdake has quit IRC | 17:34 | |
| *** ducttape_ has quit IRC | 17:37 | |
| *** GB21 has quit IRC | 17:38 | |
| *** zul has joined #openstack-glance | 17:45 | |
| *** gjayavelu has joined #openstack-glance | 18:01 | |
| *** gjayavelu has quit IRC | 18:02 | |
| *** zul_ has quit IRC | 18:18 | |
| *** dharinic_ has quit IRC | 18:22 | |
| *** pcaruana has joined #openstack-glance | 18:37 | |
| *** zul has quit IRC | 18:38 | |
| openstackgerrit | Mike Fedosin proposed openstack/glance: [WIP] Fix adding custom locations https://review.openstack.org/339767 | 18:42 |
| *** mfedosin has quit IRC | 18:47 | |
| *** btully has quit IRC | 18:50 | |
| *** dharinic_ has joined #openstack-glance | 18:52 | |
| *** ducttape_ has joined #openstack-glance | 18:55 | |
| *** zul_ has joined #openstack-glance | 18:57 | |
| *** aswadr_ has quit IRC | 19:01 | |
| *** ducttape_ has quit IRC | 19:05 | |
| *** TravT_ has joined #openstack-glance | 19:13 | |
| *** zul_ has quit IRC | 19:14 | |
| *** zul has joined #openstack-glance | 19:15 | |
| *** TravT has quit IRC | 19:16 | |
| *** ducttape_ has joined #openstack-glance | 19:19 | |
| *** TravT has joined #openstack-glance | 19:21 | |
| *** TravT_ has quit IRC | 19:22 | |
| *** btully has joined #openstack-glance | 19:35 | |
| *** TravT_ has joined #openstack-glance | 19:45 | |
| *** TravT has quit IRC | 19:47 | |
| *** pt_15 has joined #openstack-glance | 19:51 | |
| *** itisha has joined #openstack-glance | 19:51 | |
| *** sdake_ has quit IRC | 19:51 | |
| *** mfedosin has joined #openstack-glance | 19:52 | |
| *** burgerk has quit IRC | 19:54 | |
| *** mtanino has quit IRC | 20:05 | |
| *** mfedosin has quit IRC | 20:08 | |
| *** buzztroll has quit IRC | 20:15 | |
| *** buzztroll has joined #openstack-glance | 20:17 | |
| *** markvoelker has joined #openstack-glance | 20:19 | |
| *** mfedosin has joined #openstack-glance | 20:20 | |
| *** cdelatte has quit IRC | 20:26 | |
| *** flwang1 has joined #openstack-glance | 20:26 | |
| *** ccesario has quit IRC | 20:33 | |
| *** flwang1 has quit IRC | 20:40 | |
| openstackgerrit | Mike Fedosin proposed openstack/glance: [WIP] Fix adding custom locations https://review.openstack.org/339767 | 20:43 |
| *** mfedosin has quit IRC | 20:49 | |
| *** rcernin has quit IRC | 20:52 | |
| *** flwang1 has joined #openstack-glance | 20:59 | |
| openstackgerrit | Brian Rosmaita proposed openstack/glance: WADL to RST migration (part 2 - images) https://review.openstack.org/332950 | 21:07 |
| openstackgerrit | Hemanth Makkapati proposed openstack/glance-specs: Database strategy for rolling upgrades https://review.openstack.org/331740 | 21:15 |
| *** buzztroll has quit IRC | 21:15 | |
| openstackgerrit | Hemanth Makkapati proposed openstack/glance-specs: Database strategy for rolling upgrades https://review.openstack.org/331740 | 21:16 |
| *** buzztroll has joined #openstack-glance | 21:26 | |
| rosmaita | flwang1: around? | 21:27 |
| *** bpokorny has quit IRC | 21:30 | |
| *** TravT_ is now known as TravT | 21:38 | |
| *** bpokorny has joined #openstack-glance | 21:41 | |
| flwang1 | rosmaita: yes | 21:53 |
| *** ayoung has quit IRC | 21:55 | |
| rosmaita | flwang1: hello ... it's your weekend now, i think ... are you working? | 21:55 |
| flwang1 | rosmaita: yep, it's Sat here :) | 21:55 |
| flwang1 | but yes, i always work anytime :D | 21:56 |
| flwang1 | how can i help? | 21:56 |
| rosmaita | when i got in this morning, i saw that you had pinged me last night | 21:57 |
| flwang1 | rosmaita: oh, yep | 21:58 |
| flwang1 | rosmaita: just wanna discuss the location strategy restrict issue | 21:58 |
| rosmaita | sure | 21:58 |
| flwang1 | rosmaita: i'm not really sure what you want to see. just a new bug to track the change? | 21:59 |
| rosmaita | flwang1: yes ... iiuc, the issue is that the way the config option is currently defined prevents the feature from working properly | 22:00 |
| flwang1 | rosmaita: yep, agree | 22:00 |
| *** sigmavirus is now known as sigmavirus_away | 22:00 | |
| rosmaita | so, before that dude removes the tests, i'd like him to be able to say something like, "follow up fix to this is bug #1234" | 22:01 |
| openstack | bug 1234 in Launchpad itself "Gina is an unmaintainable mess of command line options, environment variables and shell scripts" [Medium,Fix released] https://launchpad.net/bugs/1234 - Assigned to Daniel Henrique Debonzi (debonzi) | 22:01 |
| rosmaita | ha! | 22:01 |
| flwang1 | haha | 22:01 |
| rosmaita | but also, from what you say, it looks like the validate code is never called? | 22:01 |
| flwang1 | ok, i see. initially, i created bug https://launchpad.net/bugs/1598282 to track the change | 22:02 |
| openstack | Launchpad bug 1598282 in Glance "location strategy config shouldn't be ristricted" [Undecided,New] - Assigned to Fei Long Wang (flwang) | 22:02 |
| flwang1 | but seems changbo guo just grabbed it to track his change | 22:02 |
| * rosmaita looking | 22:02 | |
| flwang1 | so, haha | 22:02 |
| flwang1 | so how do you think we merge the two patches as one as just use 1598282 to track it? | 22:03 |
| flwang1 | s/as/and | 22:03 |
| rosmaita | ok, sorry, was reading | 22:06 |
| rosmaita | ok | 22:06 |
| rosmaita | so my problem right now is: (1) gbo removed the option validation that oslo_config was doing | 22:06 |
| rosmaita | (2) your patch https://review.openstack.org/#/c/336761/ removes the validation method and its test cases | 22:07 |
| rosmaita | so, we now have the situation where an operator can put anything for that config option | 22:07 |
| *** ducttape_ has quit IRC | 22:07 | |
| rosmaita | the follow-up bug would be to fix it so that the validation function is called | 22:07 |
| rosmaita | iirc, what it did was read the option name and check the appropriate directory to see if there was a location strategy with that name | 22:08 |
| rosmaita | and it raised an exception if there was no such strategy | 22:08 |
| rosmaita | i think we want to preserve that behavior | 22:08 |
| rosmaita | but, i also wonder if this is a quesiton for nikhil | 22:09 |
| rosmaita | namely, is the feature supposed to be taht configurable? | 22:09 |
| rosmaita | by an operator, i mean | 22:09 |
| * nikhil reads back | 22:09 | |
| flwang1 | rosmaita: yes, you're right | 22:09 |
| rosmaita | or did zhi code it like that for future strategies that the *glance* team would add | 22:09 |
| rosmaita | ? | 22:09 |
| flwang1 | the strategy is loadded by stevedore | 22:10 |
| flwang1 | so if there is no valid strategy with the given name | 22:10 |
| flwang1 | there is an error | 22:10 |
| flwang1 | and what i need to verify is when the exception will be thrown | 22:10 |
| rosmaita | ok | 22:11 |
| flwang1 | when starting the glance-api or only when loading the strategy, because i haven't dig into the code | 22:11 |
| flwang1 | but that's basically the idea | 22:11 |
| nikhil | def looks like a big change | 22:12 |
| rosmaita | so i haven't dug too much either, but i think that validation function that isn't called is supposed to trigger when the glance-api starts | 22:12 |
| rosmaita | so the operator gets quick feedback that a strategy is missing | 22:12 |
| rosmaita | that was my impression, anyway | 22:12 |
| nikhil | though ideally, we don't restrict the strategy but we sort of validate the use cases used for it | 22:12 |
| rosmaita | nikhil: yes, i think that as long as the operator has supplied strategy code, we'll use it | 22:13 |
| rosmaita | the problem was that oslo_config was set up so that an operator could only use 1 of 2 specific values | 22:14 |
| rosmaita | so we want to loosen that a bit without giving up entierly on some kind of validation of that config option | 22:14 |
| flwang1 | nikhil: no, we're ristricting the strategy name by oslo, but we never use the method to verify it | 22:14 |
| flwang1 | rosmaita: exactly | 22:14 |
| flwang1 | rosmaita: so how about just use changbo's patch to 'loose' the ristriction | 22:15 |
| flwang1 | and meanwhile, i need to use my patch to track how to fail quickly if the strategy name is invalid | 22:15 |
| flwang1 | for operator | 22:15 |
| nikhil | I got the idea that we are restricting strategies top leve using config, though strategies can be simply supplied via ext modules | 22:16 |
| flwang1 | and another thing maybe not related(but it does) to this, is the global location strategy is bad IMHO, which i commented to zhiyan when i reviewed the patch | 22:17 |
| flwang1 | nikhil: yes, the idea is let operator can add customized strategy, but now they can't | 22:17 |
| rosmaita | flwang1: do you know if many people use non default location strategies? | 22:17 |
| nikhil | is the idea that the stragy would be patch downstream from now on? | 22:17 |
| nikhil | strategy would be patched* | 22:18 |
| rosmaita | nikhil: well, that's why i flagged you in irc just now | 22:18 |
| flwang1 | rosmaita: i don't know, but given the change from https://review.openstack.org/268865 | 22:18 |
| rosmaita | maybe we don't want it to be so configurable? | 22:18 |
| nikhil | rosmaita: thanks for flagging. I think you are very right to raise the concern. | 22:18 |
| rosmaita | but yes, basically what flwang1 says | 22:18 |
| flwang1 | rosmaita: the original author of that patches comes from https://nectar.org.au/ | 22:19 |
| flwang1 | one of largest public cloud of AU | 22:19 |
| nikhil | rosmaita: flwang1 : I am cool with this idea. it basically facilitates operator what we really want them to do with locations. | 22:19 |
| rosmaita | it looks to me like the feature was designed so that an operator adds some code to the location strategy directory, changes the config option value, does a sighup, and away you go with the new strategy | 22:19 |
| rosmaita | and if there's a problem, they change the config value back, sighup again, and back to normal | 22:20 |
| rosmaita | flwang1: that's sam morrison's cloud, right? | 22:20 |
| nikhil | rosmaita: flwang1 : but I think we need to write good documentation for this change and possible remove any code that won't be used. | 22:20 |
| nikhil | rosmaita: yes, sam's | 22:20 |
| flwang1 | nikhil: yep, so if we can 'open' the restriction, we can basically deny the patch https://review.openstack.org/268865 and let them keep it in downstream :) | 22:20 |
| rosmaita | nikhil: +1 | 22:20 |
| nikhil | flwang1: makes sense | 22:21 |
| flwang1 | nikhil: just like powerVM driver ;) | 22:21 |
| nikhil | flwang1: but let's open with good instructions of how to setup and what consequences would be to use strategies in a particular way. the last thing we want is locations being used incorrectly, ifkwim :) | 22:21 |
| rosmaita | so, flwang1 all i was requesting was to for you to say this in a bug, because i don't want to approve removing validation of a config option without there being some kind of plan | 22:21 |
| flwang1 | rosmaita: yep, i agree. it's a bigger change than I thought | 22:22 |
| nikhil | oh, removing config needs standard deprecation path | 22:22 |
| rosmaita | just in case you win the lottery or something and decide to stop working on glance, someone can pick it up :) | 22:22 |
| flwang1 | we need to loose the restriction and a better document | 22:22 |
| rosmaita | nikhil: won't remove the config, will still use it, just validate it differently | 22:23 |
| flwang1 | nikhil: are you happy if i just use a bug to track this? | 22:23 |
| flwang1 | nikhil: no | 22:23 |
| rosmaita | fwiw, i think it really is a bug fix | 22:23 |
| flwang1 | we're NOT removing config | 22:23 |
| nikhil | ok, I think I misread a irc chat above. pardon me. | 22:24 |
| flwang1 | rosmaita: as for lottery | 22:24 |
| nikhil | flwang1: you can add info to the bug, I will use it to add to documentation separately. something I am planning to do regularly. | 22:24 |
| *** btully has quit IRC | 22:24 | |
| flwang1 | now the pool in NZ is $40M | 22:24 |
| flwang1 | everybody is talking about lottery in NZ now | 22:25 |
| flwang1 | nikhil: cool | 22:25 |
| rosmaita | wow, that's almost enough money to make me suspend my statistical knowledge and buy a ticket | 22:25 |
| flwang1 | rosmaita: do you think we still need a separate bug? | 22:25 |
| nikhil | flwang1: just let me know when you've added so that I can followup. | 22:25 |
| flwang1 | or just use that bug https://launchpad.net/bugs/1598282 to track all the change? | 22:26 |
| openstack | Launchpad bug 1598282 in Glance "location strategy config shouldn't be ristricted" [Undecided,New] - Assigned to Fei Long Wang (flwang) | 22:26 |
| rosmaita | flwang1: not necessarily, i think if you just say what we've talked about in bullet points on your current bug, we can do partial-bug fixes | 22:26 |
| flwang1 | rosmaita: ok, cool, that's basically i want to confirm with you | 22:27 |
| flwang1 | and i'm happy now :) | 22:27 |
| rosmaita | me too! | 22:27 |
| rosmaita | flwang1: hey, thanks for your reviews on the images api-ref | 22:27 |
| rosmaita | i have some questions for you on patch set 9 | 22:28 |
| flwang1 | rosmaita: so i would suggest let changbo's patch depends on the patch i'm working on, that said, i don't want to see it's merged early | 22:28 |
| flwang1 | and we do need a release note for this change, IMHO | 22:28 |
| flwang1 | rosmaita: sure, api ref is always my fav topic :) | 22:28 |
| flwang1 | rosmaita: i need to go in 30 mins, btw | 22:29 |
| tsymanczyk | rosmaita : just by the by, i had a chance to look over the rolling upgrades spec and posted my only comment for now. i would not be against using the community images change as the experiment case. my only real concern would be that i'm not certain the implementation vision in my head matches what you have intended, and so me just spinning on it would pretty | 22:29 |
| tsymanczyk | much guarantee community images would not make newton. | 22:29 |
| rosmaita | flwang1: i am probably good with whatever strategy you think is the best way to fix the config option | 22:30 |
| flwang1 | rosmaita: lovely | 22:30 |
| rosmaita | flwang1: no rush on the api-ref, have a good weekend | 22:30 |
| rosmaita | but if you win the lottery, promise you will hire a glance core to review it for you! | 22:30 |
| flwang1 | rosmaita: cool, thanks. will catch you later about the api-ref | 22:30 |
| rosmaita | tsymanczyk: thanks ... we do not want to delay community images, so we can discuss next week | 22:31 |
| flwang1 | rosmaita: if i win the lottery, i will stay in the team i promise, in case the rich life is too boring :D | 22:31 |
| rosmaita | tsymanczyk: i think the idea is not that you'd have to implement the rolling upgrade stuff yourself, hemanthm and i will help out | 22:32 |
| rosmaita | flwang1: ok, have a good weekend! | 22:32 |
| flwang1 | rosmaita: see you guys | 22:32 |
| rosmaita | tsymanczyk: but, yeah, if its going to delay past newton, i don't think we want to do it | 22:32 |
| rosmaita | flwang1: bye | 22:32 |
| tsymanczyk | rosmaita : if the intention is for you and hemanthm to help out then my concern is certainly lessened. my real concern came from the thankfully incorrect assumption of "new PoC requirement out of nowhere, deal with it tim". | 22:36 |
| openstackgerrit | Brian Rosmaita proposed openstack/glance: WADL to RST migration (part 2 - metadefs) https://review.openstack.org/333031 | 22:37 |
| rosmaita | tsymanczyk: glad you raised the red flag ... that wasn't the intention! | 22:38 |
| rosmaita | someday all the api-ref will be merged and i will have my life back | 22:38 |
| openstackgerrit | Eric Brown proposed openstack/glance_store: Add bandit to pep8 and bandit testenv https://review.openstack.org/310803 | 22:39 |
| *** markvoelker has quit IRC | 22:40 | |
| rosmaita | tsymanczyk: thanks for your comments on the rolling upgrade spec, we are working on answers! but right now, i agree, it's not clear exactly how this is supposed to work | 22:42 |
| rosmaita | john garbutt is convinced that when we write out operators instructions, it will become clear that we are being too ambitious to try to have the entire upgrade occur in a single cycle | 22:43 |
| *** tsymanczyk has left #openstack-glance | 22:48 | |
| rosmaita | hasta la vista, folks, have a good weekend | 22:53 |
| *** ozialien10 has quit IRC | 23:02 | |
| *** thumpba has quit IRC | 23:02 | |
| *** ozialien10 has joined #openstack-glance | 23:02 | |
| *** dramakri has joined #openstack-glance | 23:23 | |
| *** dramakri has quit IRC | 23:28 | |
| *** dramakri has joined #openstack-glance | 23:30 | |
| *** wxy has joined #openstack-glance | 23:31 | |
| *** buzztroll has quit IRC | 23:39 | |
| *** markvoelker has joined #openstack-glance | 23:41 | |
| *** greghaynes has quit IRC | 23:46 | |
| *** rrecio_ has quit IRC | 23:47 | |
| *** markvoelker has quit IRC | 23:47 | |
| openstackgerrit | Merged openstack/glance: Improving help text for public_endpoint https://review.openstack.org/326126 | 23:51 |
| openstackgerrit | Merged openstack/glance: Add image signature verification metadefs https://review.openstack.org/329112 | 23:55 |
| *** greghaynes has joined #openstack-glance | 23:59 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!