Thursday, 2016-03-10

*** openstack has joined #openstack-glance00:08
*** ducttape_ has quit IRC00:12
*** davideag_ has quit IRC00:14
*** davideagnello has joined #openstack-glance00:14
*** openstackgerrit has quit IRC00:17
*** openstackgerrit has joined #openstack-glance00:18
*** vilobhmm11 has joined #openstack-glance00:20
*** dims has quit IRC00:35
*** vilobhmm11 has quit IRC00:44
*** lin_yang_ has joined #openstack-glance00:45
*** ativelkov_ has joined #openstack-glance00:48
*** lin_yang has quit IRC00:49
*** eglute has quit IRC00:49
*** ativelkov has quit IRC00:49
*** jdillaman has quit IRC00:49
*** lin_yang_ is now known as lin_yang00:49
*** eglute_s has joined #openstack-glance00:49
*** jdillaman has joined #openstack-glance00:52
openstackgerritSabari proposed openstack/glance: Remove state transition from active to queued  https://review.openstack.org/29090900:55
*** harshs has quit IRC00:56
*** haomaiwang has quit IRC01:01
*** haomaiwang has joined #openstack-glance01:01
*** ducttape_ has joined #openstack-glance01:08
*** ducttape_ has quit IRC01:14
*** ducttape_ has joined #openstack-glance01:15
*** nikhil_k has quit IRC01:22
*** dims has joined #openstack-glance01:31
*** mtanino has quit IRC01:43
*** edmondsw has quit IRC01:44
*** ducttape_ has quit IRC01:45
*** haomaiwang has quit IRC01:58
*** baojg has joined #openstack-glance02:02
*** mingdang1 has joined #openstack-glance02:37
openstackgerritSteve Martinelli proposed openstack/glance_store: Update reno for stable/mitaka  https://review.openstack.org/29074702:44
*** houming has joined #openstack-glance02:47
*** aslaen has quit IRC02:50
*** RustShen has joined #openstack-glance02:59
*** ducttape_ has joined #openstack-glance03:11
*** ducttape_ has quit IRC03:11
*** dims has quit IRC03:14
*** bapalm has quit IRC03:24
*** tjcocozz has quit IRC03:25
*** houming has quit IRC03:39
*** bapalm has joined #openstack-glance03:43
*** tjcocozz has joined #openstack-glance03:43
*** houming has joined #openstack-glance03:45
*** links has joined #openstack-glance03:50
*** vilobhmm11 has joined #openstack-glance03:58
*** mine0901 has quit IRC03:59
*** dims has joined #openstack-glance04:01
*** gjayavel_ has joined #openstack-glance04:05
*** vilobhmm11 has quit IRC04:10
*** dims has quit IRC04:13
*** nikhil has joined #openstack-glance04:15
*** nikhil_k has joined #openstack-glance04:15
*** vilobhmm11 has joined #openstack-glance04:16
*** jamielennox is now known as jamielennox|away04:41
*** RustShen has quit IRC04:47
*** RustShen has joined #openstack-glance04:47
*** kragniz has quit IRC04:52
*** kragniz has joined #openstack-glance04:54
*** GB21 has joined #openstack-glance04:59
*** mfedosin has joined #openstack-glance04:59
*** xiexs has quit IRC05:03
*** mfedosin has quit IRC05:05
*** kragniz has quit IRC05:05
*** kragniz has joined #openstack-glance05:05
*** houming has quit IRC05:11
*** RustShen has quit IRC05:23
*** RustShen has joined #openstack-glance05:24
*** RustShen has quit IRC05:28
*** sgotliv has joined #openstack-glance05:29
*** satwant has quit IRC05:42
*** 16WAADQPV has joined #openstack-glance05:49
*** RustShen has joined #openstack-glance05:50
*** ayoung has quit IRC05:53
*** melwitt has quit IRC05:54
*** mfisch has quit IRC05:56
*** melwitt has joined #openstack-glance05:59
*** 16WAADQPV has quit IRC06:01
*** haomaiwang has joined #openstack-glance06:01
*** RustShen has quit IRC06:01
*** RustShen has joined #openstack-glance06:02
*** ayoung has joined #openstack-glance06:04
*** RustShen has quit IRC06:07
*** RustShen_ has joined #openstack-glance06:07
*** gjayave__ has joined #openstack-glance06:14
*** gjayavel_ has quit IRC06:17
openstackgerritOpenStack Proposal Bot proposed openstack/glance: Imported Translations from Zanata  https://review.openstack.org/29101006:18
*** gberginc has joined #openstack-glance06:22
openstackgerritSabari proposed openstack/glance: Remove state transition from active to queued  https://review.openstack.org/29090906:22
*** tjcocozz has quit IRC06:23
*** bapalm has quit IRC06:23
*** mfisch has joined #openstack-glance06:27
*** mfisch is now known as Guest3848406:27
*** satwant has joined #openstack-glance06:32
*** bapalm has joined #openstack-glance06:42
*** tjcocozz has joined #openstack-glance06:45
*** melwitt has quit IRC06:45
*** melwitt has joined #openstack-glance06:50
*** melwitt is now known as Guest9853406:50
*** Guest98534 is now known as melwitt06:55
*** melwitt has quit IRC06:58
*** melwitt has joined #openstack-glance07:00
*** haomaiwang has quit IRC07:01
*** haomaiwang has joined #openstack-glance07:01
*** melwitt has quit IRC07:03
*** haomaiwang has quit IRC07:04
*** melwitt has joined #openstack-glance07:04
*** haomaiwang has joined #openstack-glance07:04
*** melwitt is now known as Guest3702007:05
*** groen692 has joined #openstack-glance07:25
*** rcernin has joined #openstack-glance07:33
*** GB21 has quit IRC07:36
*** dshakhray has joined #openstack-glance07:38
*** belmoreira has joined #openstack-glance07:41
*** melwitt has joined #openstack-glance07:41
*** nikhil has quit IRC07:45
*** nikhil has joined #openstack-glance07:47
*** e0ne has joined #openstack-glance07:53
*** RustShen_ has quit IRC07:55
*** RustShen has joined #openstack-glance07:56
openstackgerritRust Shen proposed openstack/glance: test  https://review.openstack.org/29104507:57
*** RustShen has quit IRC07:59
*** RustShen has joined #openstack-glance08:00
*** RustShen has quit IRC08:00
*** RustShen has joined #openstack-glance08:00
*** haomaiwang has quit IRC08:01
*** haomaiwang has joined #openstack-glance08:01
*** ihrachys has joined #openstack-glance08:07
*** ihrachys has quit IRC08:08
*** gjayave__ has quit IRC08:10
*** daemontool_ has joined #openstack-glance08:11
*** ihrachys has joined #openstack-glance08:13
*** daemontool has quit IRC08:14
*** e0ne has quit IRC08:21
*** e0ne has joined #openstack-glance08:25
*** davideagnello has quit IRC08:32
*** pcaruana has joined #openstack-glance08:34
*** davideagnello has joined #openstack-glance08:35
*** permalac has joined #openstack-glance08:35
*** permalac has quit IRC08:35
*** zhiyan has quit IRC08:36
*** ameade has quit IRC08:36
*** zhiyan has joined #openstack-glance08:39
*** ameade has joined #openstack-glance08:40
*** permalac has joined #openstack-glance08:41
*** permalac has quit IRC08:41
*** RustShen has quit IRC08:41
*** RustShen has joined #openstack-glance08:41
*** e0ne has quit IRC08:42
*** gjayavel_ has joined #openstack-glance08:48
*** ishant has joined #openstack-glance08:58
*** permalac_ has joined #openstack-glance09:00
*** permalac_ has quit IRC09:00
*** haomaiwang has quit IRC09:01
*** haomaiwa_ has joined #openstack-glance09:01
*** GB21 has joined #openstack-glance09:04
*** RustShen_ has joined #openstack-glance09:05
*** RustShen has quit IRC09:05
*** RustShen_ has quit IRC09:05
*** RustShen has joined #openstack-glance09:06
*** jistr has joined #openstack-glance09:09
*** mvk has joined #openstack-glance09:10
openstackgerritDanny Al-Gaaf proposed openstack/glance: Catch exceptions.HasSnapshot() from delete image in rbd driver  https://review.openstack.org/29106709:13
*** openstackgerrit has quit IRC09:30
*** openstackgerrit_ has joined #openstack-glance09:30
*** openstackgerrit_ is now known as openstackgerrit09:31
*** openstackgerrit has quit IRC09:31
*** openstackgerrit_ has joined #openstack-glance09:31
*** mingdang1 has quit IRC09:32
*** openstackgerrit_ is now known as openstackgerrit09:32
*** openstackgerrit has quit IRC09:32
*** openstackgerrit_ has joined #openstack-glance09:32
*** openstackgerrit_ is now known as openstackgerrit09:33
*** openstackgerrit has quit IRC09:33
*** openstackgerrit_ has joined #openstack-glance09:33
*** e0ne has joined #openstack-glance09:33
*** openstackgerrit_ is now known as openstackgerrit09:34
*** gjayavel_ has quit IRC09:40
*** daemontool__ has joined #openstack-glance09:45
*** daemontool_ has quit IRC09:49
*** haomaiwa_ has quit IRC10:01
*** haomaiwang has joined #openstack-glance10:01
*** sayalilunkad_lap has joined #openstack-glance10:06
*** vilobhmm11 has quit IRC10:13
*** GB21 has quit IRC10:18
*** GB21 has joined #openstack-glance10:22
*** lennyb has left #openstack-glance10:33
*** RustShen has quit IRC10:33
*** mingdang1 has joined #openstack-glance10:33
*** mvk has quit IRC10:42
*** dims has joined #openstack-glance10:47
*** bapalm has quit IRC10:51
*** dims has quit IRC10:52
*** baojg has quit IRC10:56
*** dims has joined #openstack-glance10:56
*** baojg has joined #openstack-glance10:56
openstackgerritDanny Al-Gaaf proposed openstack/glance: Catch exceptions.HasSnapshot() from delete image in rbd driver  https://review.openstack.org/29106710:58
*** haomaiwang has quit IRC11:01
*** mfedosin has joined #openstack-glance11:01
*** haomaiwang has joined #openstack-glance11:01
*** baojg has quit IRC11:01
flaper87flwang: we can backport it11:03
*** bapalm has joined #openstack-glance11:08
*** mvk has joined #openstack-glance11:10
*** satwant has quit IRC11:11
flaper87nikhil: sabari https://review.openstack.org/#/c/278870/ pls :D11:13
*** dims has quit IRC11:19
*** dims has joined #openstack-glance11:21
*** bapalm has quit IRC11:24
flaper87sabari: jokke_ thoughts on my last comment? https://review.openstack.org/#/c/280789/11:24
openstackgerritNiall Bunting proposed openstack/glance: Copy the size of the tag set  https://review.openstack.org/29074111:25
*** ishant has quit IRC11:25
openstackgerritNiall Bunting proposed openstack/glance: Copy the size of the tag set  https://review.openstack.org/29074111:25
*** tjcocozz has quit IRC11:26
*** satwant has joined #openstack-glance11:28
flaper87jokke_: what are your thoughts on https://review.openstack.org/#/c/269496/ ?11:32
*** satwant has quit IRC11:35
*** smatzek has joined #openstack-glance11:42
*** tjcocozz has joined #openstack-glance11:43
*** bapalm has joined #openstack-glance11:44
*** sayalilunkad_lap has quit IRC11:45
*** gjayavel_ has joined #openstack-glance11:52
*** dims has quit IRC11:56
*** gjayavel_ has quit IRC11:56
*** haomaiwang has quit IRC12:01
*** haomaiwang has joined #openstack-glance12:01
*** dims has joined #openstack-glance12:04
*** GB21 has quit IRC12:22
*** mingdang1 has quit IRC12:22
openstackgerritMerged openstack/glance: Remove state transition from active to queued  https://review.openstack.org/29090912:29
*** ndonegan has quit IRC12:35
*** ndonegan has joined #openstack-glance12:36
*** lakshmiS has joined #openstack-glance12:36
*** gberginc has quit IRC12:37
*** mingdang1 has joined #openstack-glance12:38
*** GB21 has joined #openstack-glance12:38
openstackgerritMerged openstack/python-glanceclient: Catch InUseByStore case in do_image_delete  https://review.openstack.org/29088212:40
*** lakshmiS has quit IRC12:42
*** GB21 has quit IRC12:43
*** fesp has joined #openstack-glance12:43
*** pcaruana has quit IRC12:45
*** fesp has quit IRC12:51
*** sayalilunkad has quit IRC12:51
*** sayalilunkad has joined #openstack-glance12:52
*** e0ne_ has joined #openstack-glance12:53
*** e0ne has quit IRC12:54
jokke_clicking12:56
*** cdelatte has quit IRC12:57
*** mingdang1 has quit IRC12:58
jokke_flaper87: https://review.openstack.org/#/c/280789/ how the server returns if we do not pass valid metadata. If it does not crap out the current client, I do agree with your assesment. If it fails anyways and breaks the scripts, you think that's still valid point. Now honestly I do not know current situation12:59
openstackgerritMerged openstack/glance: Updated the wording in the database architecture docs.  https://review.openstack.org/29082312:59
*** pcaruana has joined #openstack-glance13:00
*** haomaiwang has quit IRC13:01
*** haomaiwang has joined #openstack-glance13:01
flaper87jokke_: I think it's still a valid point. If the server craps out, I'd rather handle that exception for now and print a proper message and then make that an error or something. I might be being a bit too conservative here but I do want to avoid breaking scripts and the CVE was on the server side, we can help lib users transition13:02
jokke_flaper87: ++13:04
jokke_so lets make client deal with it gracefully and continue. "Just smile and wave boys, just smile and wave"13:05
jokke_o/~13:05
flaper87o/~13:05
flaper87flwang: ^ you might want to read  the above13:06
flaper87rosmaita: nikhil sabari kairat mfedosin mclaren https://review.openstack.org/#/c/282516/13:06
flaper87sigmavirus24_awa: ^13:06
*** haomaiwang has quit IRC13:11
*** ducttape_ has joined #openstack-glance13:12
*** cdelatte has joined #openstack-glance13:20
*** edmondsw has joined #openstack-glance13:21
*** mtanino has joined #openstack-glance13:27
*** ducttape_ has quit IRC13:29
*** sayalilunkad has quit IRC13:32
flaper87tjcocozz: hey, did you work on a fix for that glance_store issue?13:34
flaper87anything we can do to help?13:34
flaper87it's becoming more urgent :P13:34
flaper87we need to unbreak our mitaka gate13:34
*** sayalilunkad has joined #openstack-glance13:35
*** dims has quit IRC13:38
*** dims has joined #openstack-glance13:39
*** porunov has joined #openstack-glance13:40
*** ninag has joined #openstack-glance13:42
*** burgerk has joined #openstack-glance13:43
*** links has quit IRC13:48
*** delattec has joined #openstack-glance13:49
*** cdelatte has quit IRC13:52
tjcocozzflaper87, still working on it :-(13:53
flaper87tjcocozz: ok, please, let us know if we can help13:53
tjcocozzflaper87, okay i will! :13:54
flaper87Courtesy meeting reminder: ativelkov, cpallares, flaper87, flwang1, hemanthm, jokke_, kragniz, lakshmiS, mclaren, mfedosin, nikhil_k14:01
flaper87Courtesy meeting reminder: Nikolay_St, Olena, pennerc, rosmaita, sigmavirus24, sabari, TravT, ajayaa, GB21, bpoulos, harshs, abhishekk, bunting14:01
flaper87Courtesy meeting reminder: dshakhray, wxy, dhellmann, kairat14:01
*** burgerk has quit IRC14:03
*** openstackgerrit_ has joined #openstack-glance14:03
*** openstackgerrit has quit IRC14:03
*** haomaiwa_ has joined #openstack-glance14:04
*** openstackgerrit_ is now known as openstackgerrit14:04
*** openstackgerrit has quit IRC14:04
*** openstackgerrit_ has joined #openstack-glance14:04
*** openstackgerrit_ is now known as openstackgerrit14:05
*** openstackgerrit has quit IRC14:05
*** openstackgerrit_ has joined #openstack-glance14:05
*** openstackgerrit_ is now known as openstackgerrit14:06
*** openstackgerrit has quit IRC14:07
*** openstackgerrit_ has joined #openstack-glance14:07
*** openstackgerrit_ is now known as openstackgerrit14:08
*** openstackgerrit has quit IRC14:08
*** openstackgerrit_ has joined #openstack-glance14:08
*** openstackgerrit_ is now known as openstackgerrit14:09
*** gjayavel_ has joined #openstack-glance14:09
*** openstackgerrit has quit IRC14:09
*** openstackgerrit_ has joined #openstack-glance14:09
*** openstackgerrit_ is now known as openstackgerrit14:10
*** Guest41345 has joined #openstack-glance14:10
openstackgerritBrian Rosmaita proposed openstack/glance: Stop 500s when adding duplicate image property  https://review.openstack.org/29119814:10
*** burgerk has joined #openstack-glance14:12
*** mtanino has quit IRC14:22
*** mingdang1 has joined #openstack-glance14:27
*** dims has quit IRC14:29
*** mingdang1 has quit IRC14:31
openstackgerritMerged openstack/glance: Imported Translations from Zanata  https://review.openstack.org/29101014:33
*** dims has joined #openstack-glance14:35
*** pcaruana has quit IRC14:41
*** ducttape_ has joined #openstack-glance14:43
*** pcaruana has joined #openstack-glance14:53
*** lakshmiS has joined #openstack-glance14:57
*** belmoreira has quit IRC14:59
*** haomaiwa_ has quit IRC15:01
*** haomaiwang has joined #openstack-glance15:01
*** mtanino has joined #openstack-glance15:01
*** kairat has left #openstack-glance15:02
*** burgerk has quit IRC15:06
nikhil_keveryone: if people want to learn more about quotas in general please see this nice talk by vilobh https://www.youtube.com/watch?v=PTFww2RH21c15:07
*** sigmavirus24_awa is now known as sigmavirus2415:08
sigmavirus24mfedosin: I complain about lots of things ;)15:09
*** GB21 has joined #openstack-glance15:10
sigmavirus24mfedosin: tl;dr, if we're going to  have JSONPATCH for a resource, that should be all we use. I know it's *nice* to have shortcuts for editing/modifying/deleteing tags on a resource but there should be one obvious way to do something and I think that if we do JSONPATCH correctly for once, we will be fine with just having that15:10
mfedosinsigmavirus24: but it was one of the latest your complains15:11
sigmavirus24mfedosin: yeah, luckily for you, I recall most of my complaints15:11
sigmavirus24:P15:11
mfedosinsigmavirus24: I just think what to do in Glare15:12
mfedosinof course we will support PATCH tags15:12
sigmavirus24Right, I think Glare gives us a chance to do an API right from the beginning :)15:12
sigmavirus24mfedosin: context you might not have is that JSONPATCH is not fully implemented in Glance15:12
sigmavirus24The existing endpoints we have does its own thing and should be using a library to support JSONPATCH completely and correctly15:13
mfedosinsigmavirus24: "JSONPATCH is not fully implemented in Glance" you mean things like 'copy'?15:15
sigmavirus24mfedosin: there are 2-5 bugs that I can think of having seen15:15
sigmavirus24mfedosin: let me grab those for yoyu15:16
sigmavirus24*you15:16
mfedosinokay15:17
*** gjayavel_ has quit IRC15:18
dimsfolks, i turned on logging for deprecations in devstack-gate and i see a lot of repeated log messages in glance log files : http://logs.openstack.org/01/289901/4/check/gate-tempest-dsvm-neutron-full/f24d675/logs/deprecations.txt.gz15:22
*** dshakhray has quit IRC15:28
*** dshakhray has joined #openstack-glance15:30
*** burgerk has joined #openstack-glance15:35
dimsforgot to mention, each line starts with a count of the number of lines (before the "::")15:37
*** sigmavirus24 is now known as sigmavirus24_awa15:40
*** GB21 has quit IRC15:42
*** mfedosin has quit IRC15:42
*** lakshmiS has quit IRC15:45
*** gjayavel_ has joined #openstack-glance15:45
*** sigmavirus24_awa is now known as sigmavirus2415:46
*** aslaen has joined #openstack-glance15:56
*** mfedosin has joined #openstack-glance15:56
*** gberginc has joined #openstack-glance15:58
*** gberginc has quit IRC15:59
*** gberginc has joined #openstack-glance15:59
*** jistr has quit IRC15:59
*** haomaiwang has quit IRC16:01
*** haomaiwang has joined #openstack-glance16:01
*** haomaiwang has quit IRC16:07
*** gberginc has quit IRC16:09
*** pushkaru has joined #openstack-glance16:09
*** vijendar has joined #openstack-glance16:10
sigmavirus24mfedosin: sorry, got distracted grabbing bugs now16:10
mfedosinnp, I'm on meeting anyway16:11
sigmavirus24mfedosin: https://bugs.launchpad.net/glance/+bug/1521591 https://bugs.launchpad.net/glance/+bug/1521607 are two of them16:11
openstackLaunchpad bug 1521591 in Glance "v2 - replacing root document returns a schema error" [Medium,Triaged] - Assigned to Mohammed Ashraf (mohammed-asharaf)16:11
openstackLaunchpad bug 1521607 in Glance "v2 - replacing array elements with PATCH results in 400 error" [Medium,Triaged]16:11
sigmavirus24I think I remember more but I'd have to dig a bit deeper16:11
*** kairat has joined #openstack-glance16:12
mfedosinsigmavirus24: yes, danke!16:12
sigmavirus24mfedosin: which isn't "I want to fix these before glare" but just an example of how our current JSONPATCH implementation is broken and how I don't want that for glare16:13
mfedosinwe're discussing Glare's json-patch at the moment16:13
mfedosinthanks for new topics :)16:13
*** vijendar has left #openstack-glance16:14
*** sayalilunkad has quit IRC16:16
openstackgerritBrian Rosmaita proposed openstack/glance: Stop 500s when adding duplicate image property  https://review.openstack.org/29119816:18
*** itisha has joined #openstack-glance16:19
*** sayalilunkad has joined #openstack-glance16:19
sigmavirus24mfedosin: always happy to help16:23
sigmavirus24mfedosin: glare should use a library (like the one aptly named jsonpatch) that will do the right thing for us in parsing and whatnot16:23
sigmavirus24I think it's already in g-r16:23
*** dshakhray has quit IRC16:24
mfedosinsigmavirus24: yes, we do it https://review.openstack.org/#/c/287362/3/glance/api/glare/v1/glare.py16:28
*** gberginc has joined #openstack-glance16:29
*** pt_15 has joined #openstack-glance16:31
*** gberginc has quit IRC16:35
*** sigmavirus24 is now known as sigmavirus24_awa16:42
*** ducttape_ has quit IRC16:42
*** sigmavirus24_awa is now known as sigmavirus2416:42
*** vijendar has joined #openstack-glance16:46
*** e0ne_ has quit IRC16:46
*** pcaruana has quit IRC16:47
*** ihrachys has quit IRC16:48
*** avarner has quit IRC16:49
*** lakshmiS has joined #openstack-glance16:49
*** avarner has joined #openstack-glance16:53
*** ducttape_ has joined #openstack-glance16:55
*** ducttape_ has quit IRC16:59
*** ihrachys has joined #openstack-glance17:00
*** dims has quit IRC17:04
*** dims has joined #openstack-glance17:06
*** MattMan has quit IRC17:17
*** MattMan has joined #openstack-glance17:17
openstackgerritMerged openstack/glance-specs: Initial lite-specs.rst and per deliverable folders  https://review.openstack.org/28251617:22
*** haomaiwang has joined #openstack-glance17:23
*** ducttape_ has joined #openstack-glance17:25
*** haomaiwang has quit IRC17:28
*** dshakhray has joined #openstack-glance17:32
*** gberginc has joined #openstack-glance17:36
*** vilobhmm11 has joined #openstack-glance17:37
*** vilobhmm111 has joined #openstack-glance17:39
*** mgarza has joined #openstack-glance17:40
*** vilobhmm11 has quit IRC17:41
*** gjayavel_ has quit IRC17:42
*** nikhil has quit IRC17:51
*** mfedosin has quit IRC17:52
*** e0ne has joined #openstack-glance17:53
*** dims has quit IRC17:54
*** dims has joined #openstack-glance18:03
*** groen692 has quit IRC18:14
flaper87tjcocozz: no pressure but, how's that fix coming along ?18:15
*** dims has quit IRC18:21
*** dims has joined #openstack-glance18:22
*** ihrachys has quit IRC18:23
*** ducttape_ has quit IRC18:26
*** ducttape_ has joined #openstack-glance18:26
*** openstackgerrit_ has joined #openstack-glance18:29
*** mine0901 has joined #openstack-glance18:30
*** TravT has quit IRC18:48
tjcocozzflaper87, sorry i was out.  Can i walk you through what is going on.. Me and avarner are hitting a blocker18:54
flaper87tjcocozz: yup18:54
tjcocozzflaper87, give me 1 sec to write up something18:54
flaper87tjcocozz: ok18:54
flaper87tjcocozz: 118:54
flaper87tjcocozz: so, sup?18:54
flaper87:P18:54
* flaper87 stops trolling tjcocozz18:54
tjcocozzflaper87, lol18:55
*** ducttape_ has quit IRC18:56
zigoHi there! We've noticed that swiftclient 3.0.0 broke glance-store.18:59
zigoIs there patches available for it?18:59
jokke_zigo: ^^18:59
tjcocozzflaper87, this is the commit that broke  us... https://github.com/openstack/python-swiftclient/commit/4af623bcf171a63240849b84b9359a4f74471455  what it is doing is expecting get_object to return a generotor when the reponse is chuncked and the reponse when it is not.  well since we are stubbing out get object here: https://github.com/openstack/glance_store/blob/master/glance_store/tests/unit/test_swift_store.py#L144-L118:59
tjcocozz78 it is alway returning a ByteSTring instead of the generetor even when we have a chunked response18:59
zigojokke_: Do you mean the answer is up in the history of this chat? :)19:00
jokke_zigo: literally the discussion ongoing19:00
*** vilobhmm111 has quit IRC19:00
jokke_past 7min19:00
zigoOh ! :)19:00
zigojokke_: So I guess, no patch available yet then.19:02
jokke_zigo: correct19:02
zigoLet me know when there's something I can use to fix it in Debian.19:02
jokke_zigo: good news is, that glance_store is not broken, tests are19:02
zigoGood ! :)19:03
tjcocozzflaper87, so what me and avarner have been trying to do is hack fake_get_object to return a generator instead well the nice thing that swiftclient is doing in returning a custome generator so if we want to stub this out still we will need thier custome generator: _ObjectBody19:03
flaper87tjcocozz: mhh, since this is a unittest and we're stubbing stuff anyway, can't we just stub swift's call entirely ?19:04
flaper87Instead of stubbing the object we pass, we stub the swiftclient method that is being called in the store19:05
flaper87I don't care about testing swift's happy path in our unittests19:05
flaper87I kinda expect that to work, tbh.19:05
flaper87to that, we should add that functional tests would do that job19:05
flaper87(if we had them)19:05
flaper87but we will have them19:05
flaper87so, thoughts?19:05
tjcocozzflaper87, sorry i dropped out for a second. That is what we were thinking of doing. but we came across this19:06
tjcocozzhttps://github.com/openstack/glance_store/blob/master/glance_store/tests/unit/test_swift_store.py#L6719:06
* flaper87 clicks19:06
* jokke_ gets scared19:07
flaper87tjcocozz: well, TBH, that's a philosophical argument :D19:07
flaper87To me, anything that happens after I call some function in swiftclient is swiftclient's responsibility.19:08
jokke_tjcocozz: feel free to remove that comment in your patch as well :P19:08
flaper87In fact, this is an exact proof that we shouldn't be doing that19:08
tjcocozzflaper87, okay so we can stub the whole thing.. the thing is if we do this then we are not correctly testing the code that is running.. which could be a problem in the future19:08
flaper87We stubbed things that are part of swift's private API19:08
flaper87which is... wrong19:08
flaper87:D19:08
flaper87tjcocozz: it's not a problem for unittests, tbh. That's why we need to get our functional tests going asap19:09
flaper87:)19:09
flaper87tjcocozz: also, we do have a swift gate, FWIW19:09
jokke_tjcocozz: honestly this is unit test ... what is tried to do there is something gray between functional and integration19:09
flaper87at least in glance19:09
tjcocozzjokke_, yeah it is a complicated tests. all of yesturday i was trying to figure out why it was returning a 404 when it was running in debug mode :/19:10
flaper87also, despite what git says, I'm not the author of that comment19:10
flaper87hahahahah19:10
jokke_flaper87: yes you are19:10
jokke_:P19:10
flaper87that code existed in glance/store/19:10
flaper87I just ported it over19:10
jokke_flaper87: excuses ... you brought it in :P19:11
tjcocozzflaper87, lolol19:11
flaper87rolf19:11
* flaper87 won't feed the troll19:11
flaper87tjcocozz: so yeah, stub the function :)19:11
flaper87that's the way to go19:11
jokke_makes everyone happy19:11
flaper87tjcocozz: if you're interested in helping with the functional tests, lemme know19:12
tjcocozzflaper87, will do!19:12
tjcocozzflaper87, let me get decent with the code base first19:13
flaper87tjcocozz: Let me help you with that: it's full of @$@#$@!19:13
jokke_we've never done that here in Glance :D19:13
flaper87done19:13
flaper87you know all you need to know about glance_Store19:13
flaper87:P19:13
flaper87The idea is great, despite what jokke_ says19:13
flaper87but we need to refactor the code19:14
flaper87And have a decent API19:14
jokke_tjcocozz: all you need to know about glance_store is that it's flaper87's baby, it wouldn't exists without him and he will alwways take care of it :P19:14
jokke_so just ping him19:14
tjcocozzjokke_, that works for me!19:15
flaper87tjcocozz: ^ true that. By "always take care of it" he means that I'll always find someone to do the job19:15
flaper87tjcocozz: you're an example of that19:15
* flaper87 ducks19:15
jokke_:)19:15
flaper87jokes apart19:15
jokke_trolololo19:15
*** jistr has joined #openstack-glance19:15
flaper87tjcocozz: happy to talk more about why it exists if you want to.19:15
flaper87Let's first get this patch going19:15
flaper87lemme know if you need help19:15
tjcocozzflaper87, agreed!19:15
*** vijendar has quit IRC19:16
flaper87and let us know when it's up for review19:16
flaper87that way we can get it in asap19:16
tjcocozzflaper87, i will take you up on that in a little later :-)19:16
flaper87tjcocozz: sounds good19:16
*** vijendar has joined #openstack-glance19:16
flaper87tjcocozz: but please, wait until jokke_ goes to sleep19:16
*** vijendar has left #openstack-glance19:16
flaper87:P19:16
*** ducttape_ has joined #openstack-glance19:17
* jokke_ wonders if there was recording of Liberty mid cycle meeting19:17
flaper87I don't think there was19:17
flaper87I do remember you saying: "let's kill glance_store" and me trying to find a way to close your mic19:18
flaper87ah wait19:18
flaper87not the virtual one19:18
*** harshs has joined #openstack-glance19:18
jokke_tjcocozz: and just for the reference, we pick around with flaper87 like this all the time ... nothing to be worried about, just get used to it ;)19:18
flaper87you mean the one in Blacksburg19:18
jokke_flaper87: that was the one ...19:18
flaper87yeah, I didn't go there, I just know people came back saying: "Yup, we're getting rid of glance_store"19:19
flaper87and jokke_ agreed, of course19:19
flaper87because, why not?19:19
flaper87>.>19:20
*** mfedosin has joined #openstack-glance19:20
flaper87tjcocozz: ah yeah, this convos are normal procedure. I just wish I was better with referencing movies19:20
flaper87that would make convos more fun19:20
flaper87sabari: https://review.openstack.org/#/c/278870/19:20
flaper87pretty please19:20
jokke_I wasn't even there. I expressed my agreement remotely :D19:21
tjcocozzflaper87, haha that would be awesome!19:21
flaper87tjcocozz: also, is the patch ready?19:21
flaper87:P19:21
flaper87yeah, and I was in a layover in singapore when I figured all this out19:21
tjcocozzflaper87,  i am in the middle of a meeting right now.  can it wait till 2? :-)19:21
flaper87tjcocozz: one more thing, UTC or it is not part of this universe19:22
flaper87:P19:22
flaper87tjcocozz: yeah sure, just ping me19:22
flaper87when it's up19:22
tjcocozzflaper87, thank you!  Will do!19:22
flaper87tjcocozz: also, why are you chatting in the middle of a meeting?19:22
flaper87I totally never ever ever do that19:22
* flaper87 hangs up19:22
tjcocozzflaper87, mulit-tasking :p19:23
* flaper87 sends the log of this chat to tjcocozz's manager19:23
jokke_flaper87: don't, I like that he keeps his priorities in order ;)19:24
*** vilobhmm11 has joined #openstack-glance19:25
*** vilobhmm11 has quit IRC19:25
*** zul has quit IRC19:25
*** vilobhmm11 has joined #openstack-glance19:25
flaper87jokke_: good point19:26
*** zul has joined #openstack-glance19:26
flaper87very good point19:26
*** dims_ has joined #openstack-glance19:28
*** mvk has quit IRC19:28
*** dims has quit IRC19:29
*** lakshmiS has quit IRC19:30
*** lakshmiS has joined #openstack-glance19:30
sabariflaper87: sorry about marking the glance_store for RC1.19:35
sabariExactly why someone shouldn't review patches before going to bed ! :)19:35
flaper87sabari: hahaha, not big deal, really :)19:36
flaper87as long as you keep the reviews coming, I'll keep forgiving you19:36
flaper87:P19:36
sabariflaper87: lol then I think I have some karma points.19:38
sabariand I hope they rollover too :P19:39
sabariover to the next release19:39
*** rcernin has quit IRC19:40
*** e0ne has quit IRC19:43
openstackgerritDanny Al-Gaaf proposed openstack/glance: Catch exceptions.HasSnapshot() from delete image in rbd driver  https://review.openstack.org/29106719:52
*** ayoung has quit IRC19:52
*** e0ne has joined #openstack-glance20:12
flwangflaper87: thanks, reading the log20:13
*** ducttape_ has quit IRC20:18
*** ducttape_ has joined #openstack-glance20:20
*** vilobhmm11 has quit IRC20:22
*** vilobhmm11 has joined #openstack-glance20:23
*** e0ne has quit IRC20:23
*** pushkaru has quit IRC20:27
*** vilobhmm11 has quit IRC20:29
*** vilobhmm11 has joined #openstack-glance20:29
*** vilobhmm11 has quit IRC20:33
*** pushkaru has joined #openstack-glance20:37
*** ninag has quit IRC20:41
flwangflaper87: ping20:44
flwangre the stable branch of glance client20:44
*** smatzek has quit IRC20:56
*** haomaiwang has joined #openstack-glance20:56
*** sigmavirus24 is now known as sigmavirus24_awa21:00
*** haomaiwang has quit IRC21:01
* tjcocozz is writing disgusting code :P21:01
*** vijendar has joined #openstack-glance21:04
*** sigmavirus24_awa is now known as sigmavirus2421:07
*** toanster has quit IRC21:10
*** vijendar has quit IRC21:11
*** toan has joined #openstack-glance21:11
*** vijendar has joined #openstack-glance21:13
*** vilobhmm11 has joined #openstack-glance21:19
*** vilobhmm11 has quit IRC21:19
*** vilobhmm11 has joined #openstack-glance21:19
jokke_flwang: what's up, ref stable21:19
jokke_flwang: can I help?21:20
*** boris-42 has joined #openstack-glance21:30
tjcocozzflaper87, could you help me with 1 thing? i have it passing everything but 1 tests :/21:33
tjcocozztjcocozz, its not done since it is hard coding values but i think it is close ....21:34
*** gjayavelu has joined #openstack-glance21:34
tjcocozzflaper87, Idk why i just told my self that :P21:34
*** ninag has joined #openstack-glance21:37
*** jistr has quit IRC21:40
*** openstackstatus has quit IRC21:42
*** nikhil_k has quit IRC21:42
*** openstackstatus has joined #openstack-glance21:43
*** ChanServ sets mode: +v openstackstatus21:43
*** dshakhray has quit IRC21:48
flwangjokke_: for https://review.openstack.org/280789, we won't include it in current client release, right?21:48
*** ihrachys has joined #openstack-glance21:49
jokke_the stable/mitaka was cut from 2.0.021:49
jokke_I don't have issue backporting that after Flavio's concern is addressed21:50
jokke_but it did not merge in time to be in the release where the branch was cut21:50
*** sgotliv has quit IRC21:51
*** dims has joined #openstack-glance21:52
*** jamielennox|away is now known as jamielennox21:52
*** dims_ has quit IRC21:52
jokke_tjcocozz: I think flaper87 passed out before me today :)21:53
jokke_tjcocozz: or then he is enjoying some good Rum21:53
tjcocozzjokke_, ahah its all good i think it can wait till tomorrow. where does he live?21:54
jokke_tjcocozz: currently in Dom. Republic I think, it varies :P21:55
tjcocozzjokke_, cool!21:56
flwangjokke_: i see. i will upload a new patch set to address flaper87's comment21:57
jokke_thanks flwang I was gonna W+ when I saw his comment and held myself back :)21:58
*** TravT has joined #openstack-glance22:00
*** melwitt has quit IRC22:00
*** delattec has quit IRC22:02
flwangjokke_: :) cool, cheers22:03
*** rcernin has joined #openstack-glance22:11
*** pushkaru has quit IRC22:12
*** porunov has quit IRC22:14
*** melwitt has joined #openstack-glance22:16
*** melwitt has quit IRC22:16
*** pushkaru has joined #openstack-glance22:17
*** rcernin has quit IRC22:22
*** pushkaru has quit IRC22:24
*** pushkaru has joined #openstack-glance22:24
*** pt_15 has quit IRC22:25
*** vijendar has quit IRC22:28
*** pushkaru has quit IRC22:29
*** itisha has quit IRC22:29
*** chlong has quit IRC22:39
*** pushkaru has joined #openstack-glance22:39
*** cdelatte has joined #openstack-glance22:43
*** pushkaru has quit IRC22:43
*** pushkaru has joined #openstack-glance22:43
*** burgerk has quit IRC22:44
*** sgotliv has joined #openstack-glance22:45
*** vilobhmm11 has quit IRC22:45
*** vilobhmm11 has joined #openstack-glance22:46
*** ninag has quit IRC22:49
*** mgarza has quit IRC22:54
*** sigmavirus24 is now known as sigmavirus24_awa23:01
*** TravT has quit IRC23:03
*** harshs has quit IRC23:06
openstackgerritMerged openstack/glance: Test tag against schema to check length  https://review.openstack.org/21675223:14
*** ducttape_ has quit IRC23:15
*** ihrachys has quit IRC23:16
*** haomaiwang has joined #openstack-glance23:27
*** nikhil_k has joined #openstack-glance23:28
*** melwitt has joined #openstack-glance23:29
*** ninag has joined #openstack-glance23:30
*** haomaiwang has quit IRC23:32
*** ninag has quit IRC23:35
openstackgerritMike Fedosin proposed openstack/glance: [WIP] Base object for Glare artifacts  https://review.openstack.org/28817123:38
openstackgerritMike Fedosin proposed openstack/glance: [WIP] Glare v1 API  https://review.openstack.org/28736223:38
openstackgerritMike Fedosin proposed openstack/glance: [WIP] Image Artifact Type  https://review.openstack.org/29148823:38
*** sgotliv has quit IRC23:40
*** TravT has joined #openstack-glance23:54
*** mfedosin has quit IRC23:59
*** mine0901 has quit IRC23:59

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!