| *** haomaiwang has quit IRC | 00:01 | |
| *** haomaiwang has joined #openstack-glance | 00:01 | |
| *** haomaiwang has quit IRC | 00:58 | |
| *** achanda has quit IRC | 01:00 | |
| *** haomaiwa_ has joined #openstack-glance | 01:42 | |
| *** vilobhmm11 has joined #openstack-glance | 01:43 | |
| *** ducttape_ has joined #openstack-glance | 01:53 | |
| *** vilobhmm11 has quit IRC | 02:00 | |
| *** haomaiwa_ has quit IRC | 02:01 | |
| *** haomaiwang has joined #openstack-glance | 02:01 | |
| *** ducttape_ has quit IRC | 02:05 | |
| *** achanda has joined #openstack-glance | 02:10 | |
| *** achanda has quit IRC | 02:14 | |
| *** achanda has joined #openstack-glance | 02:15 | |
| *** achanda has quit IRC | 02:22 | |
| *** mingdang1 has joined #openstack-glance | 02:41 | |
| *** mdavidson has quit IRC | 02:46 | |
| *** lennyb__ has quit IRC | 02:46 | |
| *** jokke_ has quit IRC | 02:47 | |
| *** jokke_ has joined #openstack-glance | 02:47 | |
| *** lennyb__ has joined #openstack-glance | 02:47 | |
| *** kfox1111 has quit IRC | 02:49 | |
| *** kfox1111 has joined #openstack-glance | 02:49 | |
| *** mdavidson has joined #openstack-glance | 02:50 | |
| *** boris-42 has joined #openstack-glance | 02:50 | |
| *** vilobhmm11 has joined #openstack-glance | 02:58 | |
| *** mdnadeem has joined #openstack-glance | 02:59 | |
| *** haomaiwang has quit IRC | 03:01 | |
| *** haomaiwang has joined #openstack-glance | 03:01 | |
| openstackgerrit | Merged openstack/glance-specs: Move implemented specs out of approved https://review.openstack.org/284798 | 03:06 |
|---|---|---|
| *** julim has quit IRC | 03:07 | |
| *** baojg has joined #openstack-glance | 03:07 | |
| *** achanda has joined #openstack-glance | 03:37 | |
| *** achanda has quit IRC | 03:42 | |
| *** links has joined #openstack-glance | 03:44 | |
| *** achanda has joined #openstack-glance | 03:49 | |
| *** stevemar has joined #openstack-glance | 03:53 | |
| *** achanda has quit IRC | 03:55 | |
| *** haomaiwang has quit IRC | 04:01 | |
| *** haomaiwang has joined #openstack-glance | 04:01 | |
| *** links has quit IRC | 04:01 | |
| *** flwang1 has quit IRC | 04:02 | |
| *** baojg has quit IRC | 04:02 | |
| *** itisha has joined #openstack-glance | 04:03 | |
| *** david-lyle has joined #openstack-glance | 04:13 | |
| *** links has joined #openstack-glance | 04:18 | |
| *** baojg has joined #openstack-glance | 04:30 | |
| *** haomaiwang has quit IRC | 04:31 | |
| *** david-lyle has quit IRC | 04:36 | |
| *** david-lyle has joined #openstack-glance | 04:50 | |
| *** TravT has joined #openstack-glance | 04:51 | |
| *** kstepniewski has joined #openstack-glance | 04:52 | |
| *** achanda has joined #openstack-glance | 04:55 | |
| *** david-lyle has quit IRC | 04:56 | |
| *** achanda has quit IRC | 05:01 | |
| openstackgerrit | Cao ShuFeng proposed openstack/python-glanceclient: Fix loss of debug info after we use session https://review.openstack.org/285889 | 05:07 |
| *** ishant has joined #openstack-glance | 05:19 | |
| *** baojg has quit IRC | 05:22 | |
| openstackgerrit | Cao ShuFeng proposed openstack/python-glanceclient: Fix loss of debug info after we use session https://review.openstack.org/285889 | 05:22 |
| *** baojg has joined #openstack-glance | 05:24 | |
| openstackgerrit | Cao ShuFeng proposed openstack/python-glanceclient: Fix loss of debug info after we use session https://review.openstack.org/285889 | 05:32 |
| *** mine0901 has joined #openstack-glance | 05:33 | |
| *** achanda has joined #openstack-glance | 05:58 | |
| *** achanda has quit IRC | 06:02 | |
| *** achanda has joined #openstack-glance | 06:11 | |
| *** nikhil has quit IRC | 06:32 | |
| *** groen692 has joined #openstack-glance | 06:44 | |
| *** rcernin has joined #openstack-glance | 06:45 | |
| *** rcernin has quit IRC | 06:49 | |
| *** AJaeger has joined #openstack-glance | 07:02 | |
| AJaeger | glance stable cores, could you import translations again, please? https://review.openstack.org/#/c/277699/ | 07:02 |
| *** baojg has quit IRC | 07:17 | |
| *** baojg has joined #openstack-glance | 07:18 | |
| *** rcernin has joined #openstack-glance | 07:24 | |
| *** belmoreira has joined #openstack-glance | 07:25 | |
| *** nikhil has joined #openstack-glance | 07:32 | |
| *** haomaiwang has joined #openstack-glance | 07:41 | |
| *** pcaruana has joined #openstack-glance | 07:43 | |
| *** haomaiwang has quit IRC | 08:01 | |
| *** haomaiwang has joined #openstack-glance | 08:01 | |
| *** ihrachys has joined #openstack-glance | 08:06 | |
| *** mine0901 has quit IRC | 08:09 | |
| *** baojg has quit IRC | 08:24 | |
| *** achanda has quit IRC | 08:26 | |
| *** baojg has joined #openstack-glance | 08:26 | |
| *** rcernin has quit IRC | 08:29 | |
| *** achanda has joined #openstack-glance | 08:37 | |
| *** rcernin has joined #openstack-glance | 08:37 | |
| *** d0ugal_ has quit IRC | 08:46 | |
| *** baojg has quit IRC | 08:46 | |
| *** d0ugal has joined #openstack-glance | 08:46 | |
| *** flwang1 has joined #openstack-glance | 08:46 | |
| *** kstepniewski has quit IRC | 08:48 | |
| flwang1 | flaper87: ping | 08:53 |
| flwang1 | flaper87: can you help review https://review.openstack.org/280786 ? i really hope we can get it in Mitaka | 08:53 |
| *** baojg has joined #openstack-glance | 08:56 | |
| *** mfedosin has joined #openstack-glance | 08:58 | |
| *** haomaiwang has quit IRC | 09:01 | |
| *** haomaiwang has joined #openstack-glance | 09:01 | |
| *** dshakhray has joined #openstack-glance | 09:06 | |
| *** achanda has quit IRC | 09:08 | |
| *** achanda has joined #openstack-glance | 09:12 | |
| *** jistr has joined #openstack-glance | 09:20 | |
| *** vilobhmm11 has quit IRC | 09:31 | |
| *** e0ne has joined #openstack-glance | 09:43 | |
| *** baojg has quit IRC | 09:44 | |
| *** achanda has quit IRC | 09:53 | |
| *** boris-42 has quit IRC | 09:54 | |
| *** ihrachys has quit IRC | 09:54 | |
| *** e0ne has quit IRC | 09:55 | |
| *** ihrachys has joined #openstack-glance | 09:59 | |
| *** haomaiwang has quit IRC | 10:01 | |
| *** haomaiwang has joined #openstack-glance | 10:01 | |
| *** baojg has joined #openstack-glance | 10:04 | |
| *** ishant has quit IRC | 10:05 | |
| *** groen692 has quit IRC | 10:09 | |
| *** groen692 has joined #openstack-glance | 10:09 | |
| *** daemontool_ has quit IRC | 10:23 | |
| *** flwang1 has quit IRC | 10:26 | |
| *** daemontool has joined #openstack-glance | 10:29 | |
| kairat | flaper87, Looks like we can remove -2 here: https://review.openstack.org/#/c/258904/ | 10:31 |
| *** daemontool_ has joined #openstack-glance | 10:39 | |
| *** daemontool has quit IRC | 10:41 | |
| *** daemontool_ is now known as daemontool | 10:42 | |
| *** baojg has quit IRC | 10:42 | |
| *** groen692 has quit IRC | 10:49 | |
| *** daemontool__ has joined #openstack-glance | 10:56 | |
| *** flaper87 has quit IRC | 10:56 | |
| *** flaper87 has joined #openstack-glance | 10:56 | |
| *** groen692 has joined #openstack-glance | 10:57 | |
| *** daemontool has quit IRC | 10:57 | |
| flaper87 | flwang: we're in feature freeze week. We have time for bug fixes (although it'd be nicer if we'd get them all in asap | 11:00 |
| flaper87 | _ | 11:00 |
| flaper87 | ) | 11:00 |
| flaper87 | Hey folks, don't forget today is Review Monday | 11:00 |
| flaper87 | :D | 11:00 |
| *** haomaiwang has quit IRC | 11:01 | |
| flaper87 | ^^^^ kairat: mfedosin sabari flwang nikhil jokke_ rosmaita bunting (tell mclaren too) :P | 11:01 |
| *** haomaiwang has joined #openstack-glance | 11:01 | |
| AJaeger | flaper87: could you do a final import of translations for liberty, please? 277699 | 11:01 |
| *** mingdang1 has quit IRC | 11:02 | |
| flaper87 | AJaeger: done | 11:08 |
| AJaeger | thanks, flaper87 | 11:09 |
| AJaeger | now we need to wait for Zuul to go through a massive backlog ;( | 11:09 |
| flaper87 | :( | 11:10 |
| openstackgerrit | Cao ShuFeng proposed openstack/python-glanceclient: Fix missing of debug info after we use session https://review.openstack.org/285889 | 11:19 |
| *** daemontool_ has joined #openstack-glance | 11:23 | |
| *** achanda has joined #openstack-glance | 11:24 | |
| *** daemontool__ has quit IRC | 11:27 | |
| *** achanda has quit IRC | 11:29 | |
| *** dims has joined #openstack-glance | 11:29 | |
| *** mfedosin has quit IRC | 11:31 | |
| *** dims has quit IRC | 11:32 | |
| *** dims has joined #openstack-glance | 11:32 | |
| *** groen692 has quit IRC | 11:37 | |
| *** mfedosin has joined #openstack-glance | 11:44 | |
| *** groen692 has joined #openstack-glance | 11:45 | |
| openstackgerrit | Merged openstack/python-glanceclient: Removes MANIFEST.in as it is not needed explicitely by PBR https://review.openstack.org/258904 | 11:51 |
| AJaeger | glance cores, I've removed my WIP from https://review.openstack.org/#/c/285827/ - this fixes your post jobs. flaper87 gave already a +2, I suggest to merge this soon... | 11:51 |
| AJaeger | kragniz: thanks! | 11:53 |
| *** khushbu_ has joined #openstack-glance | 11:53 | |
| flaper87 | AJaeger: what an awesome time. Right ? :D | 11:53 |
| flaper87 | kragniz: You get cookies! | 11:54 |
| * kragniz noms the cookies | 11:54 | |
| AJaeger | ;) | 11:54 |
| *** marcusvrn_ has joined #openstack-glance | 11:56 | |
| *** htruta` is now known as htruta | 11:58 | |
| *** mfedosin has quit IRC | 11:58 | |
| *** haomaiwang has quit IRC | 12:01 | |
| *** haomaiwa_ has joined #openstack-glance | 12:02 | |
| *** baojg has joined #openstack-glance | 12:02 | |
| -openstackstatus- NOTICE: Infra currently has a long backlog. Please be patient and where possible avoid rechecks while it catches up. | 12:06 | |
| *** smatzek has joined #openstack-glance | 12:08 | |
| *** khushbu_ has quit IRC | 12:13 | |
| *** mfedosin has joined #openstack-glance | 12:16 | |
| *** daemontool_ has quit IRC | 12:18 | |
| *** daemontool has joined #openstack-glance | 12:20 | |
| *** achanda has joined #openstack-glance | 12:26 | |
| *** achanda has quit IRC | 12:30 | |
| *** daemontool has quit IRC | 12:32 | |
| *** daemontool has joined #openstack-glance | 12:34 | |
| *** haomaiwa_ has quit IRC | 12:42 | |
| *** haomaiwang has joined #openstack-glance | 12:43 | |
| *** haomaiwang has quit IRC | 12:43 | |
| *** haomaiwa_ has joined #openstack-glance | 12:43 | |
| *** haomaiwa_ has quit IRC | 12:43 | |
| kairat | flaper87, would be cool if you would response here: https://review.openstack.org/#/c/281165 | 12:48 |
| kairat | we can get 2 patches merged | 12:48 |
| *** pcaruana has quit IRC | 12:53 | |
| *** daemontool has quit IRC | 12:55 | |
| *** daemontool has joined #openstack-glance | 12:55 | |
| *** daemontool has quit IRC | 12:56 | |
| *** julim has joined #openstack-glance | 12:56 | |
| flaper87 | kairat: done, thanks for the heads up | 12:57 |
| *** daemontool has joined #openstack-glance | 12:59 | |
| openstackgerrit | Merged openstack/python-glanceclient: Handle 403 forbidden on download https://review.openstack.org/254328 | 13:04 |
| *** Oku_OS has joined #openstack-glance | 13:05 | |
| *** mine0901 has joined #openstack-glance | 13:07 | |
| *** pcaruana has joined #openstack-glance | 13:08 | |
| *** haomaiwang has joined #openstack-glance | 13:12 | |
| *** takedakn has joined #openstack-glance | 13:16 | |
| *** dane-fichter has joined #openstack-glance | 13:18 | |
| *** links has quit IRC | 13:18 | |
| openstackgerrit | Wenjun Wang proposed openstack/glance: 'image-show' does not show attributes whose value is 'None' https://review.openstack.org/286034 | 13:21 |
| flaper87 | kairat: your patches are blocked in jenkins | 13:23 |
| flaper87 | kairat: glance_store ones | 13:23 |
| flaper87 | kairat: oh you reverified them | 13:23 |
| kairat | Yep | 13:24 |
| kairat | waiting for result | 13:24 |
| flaper87 | good, hope the gate will pass now | 13:24 |
| openstackgerrit | Wenjun Wang proposed openstack/glance: 'image-show' does not show attributes whose value is 'None' https://review.openstack.org/286034 | 13:24 |
| dane-fichter | flaper87: can I get some eyes on this? I'd like to get image-signing in for Mitaka... https://review.openstack.org/#/c/255584/ | 13:24 |
| flaper87 | kairat: will release glance_store after that | 13:24 |
| kairat | flaper87, ok, thanks | 13:24 |
| flaper87 | dane-fichter: sure, let's see if sigmavirus24_awa has some time today to dedicate to https://review.openstack.org/#/c/255584/ | 13:25 |
| flaper87 | dane-fichter: I'll review as well | 13:25 |
| *** edmondsw has joined #openstack-glance | 13:25 | |
| dane-fichter | flaper87: excellent. thanks :) | 13:25 |
| kairat | Oh, seems gates are overloaded | 13:35 |
| *** takedakn has quit IRC | 13:37 | |
| *** ninag has joined #openstack-glance | 13:47 | |
| *** daemontool has quit IRC | 13:48 | |
| *** achanda has joined #openstack-glance | 13:53 | |
| *** daemontool has joined #openstack-glance | 13:54 | |
| *** daemontool_ has joined #openstack-glance | 13:55 | |
| *** links has joined #openstack-glance | 13:59 | |
| *** daemontool has quit IRC | 13:59 | |
| *** haomaiwang has quit IRC | 14:01 | |
| *** haomaiwang has joined #openstack-glance | 14:01 | |
| flaper87 | kairat: super overloaded | 14:01 |
| *** baojg has quit IRC | 14:06 | |
| *** MVenesio has joined #openstack-glance | 14:09 | |
| *** achanda has quit IRC | 14:13 | |
| *** baojg has joined #openstack-glance | 14:15 | |
| *** links has quit IRC | 14:16 | |
| *** boris-42 has joined #openstack-glance | 14:17 | |
| *** cdelatte has joined #openstack-glance | 14:21 | |
| flaper87 | folks, please, focus on reviewing features. I've added a FF section to our meeting etherpad: https://etherpad.openstack.org/p/glance-team-meeting-agenda | 14:26 |
| flaper87 | Note that this is not to say bug fixes are not important but let's let features that are ready land | 14:26 |
| flaper87 | ^^^^^^ nikhil kairat mfedosin jokke_ bunting rosmaita sabari sigmavirus24_awa flwang | 14:28 |
| kairat | Ok, got iy | 14:28 |
| kairat | *got it | 14:28 |
| rosmaita | flaper87: ok | 14:29 |
| *** baojg has quit IRC | 14:32 | |
| openstackgerrit | Merged openstack/glance: Do not use constraints for venv https://review.openstack.org/285827 | 14:33 |
| *** smatzek has quit IRC | 14:33 | |
| *** baojg has joined #openstack-glance | 14:34 | |
| *** pt_15 has joined #openstack-glance | 14:34 | |
| jokke_ | flaper87: ack | 14:34 |
| *** pcaruana has quit IRC | 14:38 | |
| *** TravT has quit IRC | 14:39 | |
| *** TravT has joined #openstack-glance | 14:41 | |
| *** sigmavirus24_awa is now known as sigmavirus24 | 14:42 | |
| *** baojg has quit IRC | 14:50 | |
| openstackgerrit | Niall Bunting proposed openstack/glance: Halt deletion if image is deactivated https://review.openstack.org/256381 | 14:50 |
| *** pcaruana has joined #openstack-glance | 14:52 | |
| *** ducttape_ has joined #openstack-glance | 14:53 | |
| bunting | flaper87: Okay | 14:54 |
| *** baojg has joined #openstack-glance | 14:57 | |
| *** haomaiwang has quit IRC | 15:01 | |
| *** haomaiwang has joined #openstack-glance | 15:01 | |
| sigmavirus24 | flaper87: reviewed that signature utils patch | 15:02 |
| sigmavirus24 | flaper87: also, got it, bug fixes only ;) | 15:02 |
| *** smatzek has joined #openstack-glance | 15:02 | |
| *** lennyb__ is now known as lennyb | 15:03 | |
| *** khushbu has joined #openstack-glance | 15:10 | |
| *** khushbu_ has joined #openstack-glance | 15:11 | |
| *** mtanino has joined #openstack-glance | 15:16 | |
| *** permalac has joined #openstack-glance | 15:19 | |
| *** permalac has quit IRC | 15:19 | |
| openstackgerrit | Mike Fedosin proposed openstack/glance-specs: Glare API https://review.openstack.org/283136 | 15:20 |
| *** permalac has joined #openstack-glance | 15:20 | |
| *** vijendar has joined #openstack-glance | 15:33 | |
| *** vijendar1 has joined #openstack-glance | 15:35 | |
| *** vijendar has quit IRC | 15:38 | |
| mfedosin | flaper87: hey, what do you think? https://review.openstack.org/#/c/237742/ | 15:41 |
| *** pushkaru has joined #openstack-glance | 15:45 | |
| *** baojg has quit IRC | 15:48 | |
| *** julim has quit IRC | 15:51 | |
| *** julim has joined #openstack-glance | 15:53 | |
| *** wolsen has joined #openstack-glance | 15:53 | |
| *** haomaiwang has quit IRC | 16:01 | |
| *** haomaiwang has joined #openstack-glance | 16:01 | |
| openstackgerrit | Merged openstack/glance: Add unit test for default number of workers https://review.openstack.org/281165 | 16:11 |
| openstackgerrit | Merged openstack/glance: Make sure the generated glance-api.conf.sample is always the same https://review.openstack.org/280587 | 16:11 |
| openstackgerrit | Merged openstack/glance: Updated from global requirements https://review.openstack.org/285552 | 16:11 |
| *** rcernin has quit IRC | 16:16 | |
| *** dane-fichter has quit IRC | 16:17 | |
| *** pcaruana has quit IRC | 16:17 | |
| *** stevelle_ is now known as stevelle | 16:18 | |
| *** mine0901 has quit IRC | 16:21 | |
| *** mine0901 has joined #openstack-glance | 16:22 | |
| *** belmoreira has quit IRC | 16:24 | |
| *** sigmavirus24 is now known as sigmavirus24_awa | 16:25 | |
| *** sigmavirus24_awa is now known as sigmavirus24 | 16:25 | |
| *** groen692 has quit IRC | 16:55 | |
| *** daemontool_ has quit IRC | 16:55 | |
| *** vijendar1 has quit IRC | 16:56 | |
| *** vijendar has joined #openstack-glance | 16:56 | |
| *** dane-fichter has joined #openstack-glance | 16:59 | |
| *** haomaiwang has quit IRC | 17:01 | |
| *** haomaiwa_ has joined #openstack-glance | 17:01 | |
| *** boris-42 has quit IRC | 17:14 | |
| *** MattMan has quit IRC | 17:14 | |
| *** MattMan has joined #openstack-glance | 17:14 | |
| *** openstackgerrit has quit IRC | 17:18 | |
| *** openstackgerrit has joined #openstack-glance | 17:18 | |
| *** vijendar has quit IRC | 17:18 | |
| *** vijendar has joined #openstack-glance | 17:18 | |
| *** ayoung has quit IRC | 17:23 | |
| openstackgerrit | Niall Bunting proposed openstack/glance: Changes behaviour when an image fails uploading https://review.openstack.org/215154 | 17:24 |
| *** sigmavirus24 is now known as sigmavirus24_awa | 17:26 | |
| *** daemontool_ has joined #openstack-glance | 17:26 | |
| *** jistr has quit IRC | 17:26 | |
| nikhil | mfedosin: hi | 17:28 |
| nikhil | mfedosin: please check the change in the meeting-id and INFO section to agenda etherpad https://etherpad.openstack.org/p/glance-artifacts-sub-team-meeting-agenda | 17:28 |
| nikhil | it was a request from flaper87 | 17:28 |
| *** lakshmiS has joined #openstack-glance | 17:29 | |
| nikhil | mfedosin: trying to point it out before you start the glare meeting. | 17:29 |
| mfedosin | nikhil, hi | 17:30 |
| *** david-lyle has joined #openstack-glance | 17:30 | |
| mfedosin | I see | 17:30 |
| mfedosin | let's begin | 17:30 |
| *** AJaeger has left #openstack-glance | 17:30 | |
| nikhil | cool | 17:30 |
| mfedosin | Courtesy meeting reminder ( #openstack-meeting-alt ): nikhil_k, ativelkov, mfedosin, docaedo, dshakhray, kfox111, kairat, nikhil, sudipto | 17:30 |
| *** dane-fichter has quit IRC | 17:32 | |
| rosmaita | flaper87: was looking again at the CIM metadata patch, realized that I forgot to look at the response from the Images v1 and Compute v2 images/detail call ... those calls DO respect whatever case the property was defined in ... so my analysis in the email was oversimplified. Now I am thinking that the CIM stuff should use CamelCase ... kind of sucks for API consumers, but we already have the situation that you get differing-cased property names i | 17:38 |
| rosmaita | i will put this into a comment on the patch | 17:38 |
| *** davideagnello has joined #openstack-glance | 17:40 | |
| flaper87 | rosmaita: right. IIRC, I proposed on that email thread that we should have case insensitive queries but respect cases in the DB | 17:40 |
| flaper87 | The case insensitive queries are to avoid duplicates | 17:41 |
| rosmaita | flaper87: i will have to reread your response | 17:41 |
| rosmaita | i agree on the duplicates, but how do you feel about the GET responses? | 17:41 |
| flaper87 | I guess they should respect the case, right? That's what they do now, IIUC | 17:42 |
| rosmaita | well, sometimes they do and sometimes they don't | 17:43 |
| rosmaita | if you use v2 to create CamelProp , v1 returns camelprop, unless you do v1/images/detail, and then you get CamelProp | 17:44 |
| *** ihrachys has quit IRC | 17:45 | |
| nikhil | rosmaita: may be the char encoding at the API level from this guideline help https://specs.openstack.org/openstack/api-wg/guidelines/metadata.html ? | 17:45 |
| *** achanda has joined #openstack-glance | 17:47 | |
| rosmaita | nikhil: thanks for the ref ... did you notice that that doc appears to be unaware of the PATCH verb? | 17:48 |
| *** rbradfor_ is now known as rbradfor | 17:49 | |
| nikhil | rosmaita: oh I did not.. I know that api wg is very particular about using POST for (sub)resources may be that it | 17:49 |
| rosmaita | sometimes it seems like glance was designed by people who wanted to be incompatible with the rest of openstack ... for exmaple, the v2 flat-properties scheme instead of image metadata | 17:49 |
| nikhil | heh | 17:50 |
| nikhil | def a weird craft out from nova and now we're getting nova compat layer in the client :D | 17:50 |
| *** vijendar has quit IRC | 17:52 | |
| *** david-lyle has quit IRC | 17:55 | |
| *** david-lyle_ has joined #openstack-glance | 17:55 | |
| *** sudipto has joined #openstack-glance | 18:00 | |
| *** kairat_ has joined #openstack-glance | 18:00 | |
| *** kzaitsev_mb has joined #openstack-glance | 18:00 | |
| *** haomaiwa_ has quit IRC | 18:01 | |
| kzaitsev_mb | so. my followup on glare meeting. | 18:01 |
| nikhil | o/ | 18:01 |
| mfedosin | o/ | 18:01 |
| *** haomaiwang has joined #openstack-glance | 18:01 | |
| *** agireud has quit IRC | 18:01 | |
| mfedosin | kzaitsev_mb: afair, you need something to deploy plugins with pip | 18:02 |
| docaedo | o/ (for a few minutes at least) | 18:02 |
| kzaitsev_mb | murano currently stores it's plugin under /contrib dir in murano-code-base. This creates some confusion, especially for packagers (And there are a lot of those around OS =)) | 18:02 |
| kzaitsev_mb | so the question is — what would be the correct way to distribute, develop those plugins | 18:03 |
| *** agireud has joined #openstack-glance | 18:03 | |
| kzaitsev_mb | mfedosin: and yes, being able to install 3d-party plugins looks important to me =) | 18:03 |
| nikhil | kzaitsev_mb: would you be okay to call them glare-objects (or GLO/glo) ? | 18:03 |
| nikhil | everyone? | 18:03 |
| mfedosin | I though we found the solution | 18:03 |
| nikhil | so, I have a lot of concerns wrt having something outside of the source tree be a dynamic (even lazy_load) dependency on the project (like installing from pip) | 18:04 |
| mfedosin | globs :D | 18:04 |
| nikhil | ok, mfedosin wins | 18:04 |
| kzaitsev_mb | mfedosin: we talked it through, yes, but I want it to be documented and avail for everyone =) | 18:04 |
| nikhil | globs it is | 18:04 |
| mfedosin | nikhil: let me tell you about it | 18:04 |
| *** achanda has quit IRC | 18:04 | |
| nikhil | k | 18:04 |
| mfedosin | there are 2 ways of installing globs | 18:05 |
| mfedosin | by default they are located in glance/objects folder | 18:05 |
| kzaitsev_mb | globs is a bad name, since they're taken | 18:05 |
| kzaitsev_mb | https://docs.python.org/2/library/glob.html | 18:05 |
| nikhil | glos (like glows) ? | 18:06 |
| mfedosin | https://en.wikipedia.org/wiki/Glob_%28programming%29 :( | 18:06 |
| kzaitsev_mb | nikhil: my question is — would there be an option to add custom logic, for example for validation? | 18:06 |
| mfedosin | kzaitsev_mb: yes | 18:06 |
| mfedosin | there is a proposal from api-wg | 18:07 |
| mfedosin | it's not merged yet | 18:07 |
| nikhil | kzaitsev_mb: you mean a custom API response serializer ? | 18:07 |
| mfedosin | no-no | 18:07 |
| kzaitsev_mb | i.e if there is a blob — verify what's inside of it. if there param X is true — check that Y param is present | 18:07 |
| mfedosin | just custom actions | 18:07 |
| mfedosin | kzaitsev_mb: it will be like that https://review.openstack.org/#/c/234994 | 18:07 |
| *** sudipto has quit IRC | 18:08 | |
| docaedo | kzaitsev_mb: when you say "verify what's inside of it" do you mean like a signed blob? | 18:08 |
| mfedosin | POST /v1/artifacts/{artifact_type}/{artifacts_id}/actions | 18:08 |
| kzaitsev_mb | mfedosin: that's not what I'm asking about | 18:08 |
| nikhil | ah ok | 18:08 |
| nikhil | yes, I think that makes sense | 18:08 |
| kzaitsev_mb | docaedo: yes, I mean, that when an artifact get's loaded into glare — at that particular moment we might want to perform some custom verification | 18:09 |
| nikhil | Can you please elaborate? | 18:09 |
| mfedosin | after that we don't need 'something' after 'actions' and API becomes unified | 18:09 |
| kzaitsev_mb | ok, I might have started from the wrong side of things ) | 18:10 |
| docaedo | this sounds to me like it's just a signed artifact, I thought there was a definition already for how to do that? | 18:10 |
| mfedosin | kzaitsev_mb: it's exactly what you need | 18:10 |
| mfedosin | POST /v1/artifacts/{artifact_type}/{artifacts_id}/actions | 18:11 |
| nikhil | mfedosin: I think he's talking about install time verification | 18:11 |
| mfedosin | and in the body "name": "verify", | 18:11 |
| nikhil | so install time verification is operator issue and API side verification is a user issue | 18:11 |
| nikhil | is that correct kzaitsev_mb ? | 18:12 |
| mfedosin | your plugin may add any logic you want | 18:12 |
| kzaitsev_mb | mfedosin: that's not what I'm asking for. I'm asking to have custom verification logic. imagine an artifact, that has 3 fields X, Y and Z. X is bool. I want Y to be required if X is true. Otherwise I want Z to be required, but X not. | 18:12 |
| mfedosin | one requirement it must correspond with base interface | 18:13 |
| kzaitsev_mb | currently I can only set artifact properties as required or not | 18:13 |
| kairat_ | kzaitsev_mb: why this logic can't be implemented in glare? | 18:13 |
| kzaitsev_mb | kairat_: what do you mean in glare? | 18:13 |
| nikhil | umm, let's all calm down a bit here. | 18:14 |
| kzaitsev_mb | sure, sorry if I sound angry or anything =) | 18:14 |
| kzaitsev_mb | that's not the case =) | 18:14 |
| nikhil | I think we need some exact use case from you kzaitsev_mb, like at what point of installation, instantiation and use of the Glare API you need what actions. | 18:14 |
| mfedosin | kzaitsev_mb: you just need to determine your verification method, I think | 18:15 |
| mfedosin | and describe what exactly you want when you activate artifact | 18:16 |
| mfedosin | it's pretty customizable | 18:16 |
| mfedosin | about plugin installation - you can specify full pythonic name in glare.conf and then use it | 18:18 |
| *** lakshmiS_ has joined #openstack-glance | 18:19 | |
| kzaitsev_mb | so all in all — I have 2 concerns. 1) I want to be able to install glare plugins/art-types, that do not live inside glare code-base | 18:20 |
| kzaitsev_mb | 2) I want to have custome verification methods for an artifact type | 18:20 |
| openstackgerrit | Merged openstack/glance: Add sign-the-data signature verification https://review.openstack.org/255584 | 18:20 |
| *** lakshmiS has quit IRC | 18:21 | |
| kzaitsev_mb | and #2 brings me to an interesting point | 18:21 |
| kzaitsev_mb | where at some point I might want to use project specific code in that verification code | 18:21 |
| kzaitsev_mb | do I make sense? =) | 18:21 |
| mfedosin | look... | 18:22 |
| mfedosin | there will be base artifact type, that implements *base* artifact logic | 18:22 |
| mfedosin | plugins may append it or reimplement it | 18:22 |
| mfedosin | so, all you need is write your verification method in your plugin | 18:23 |
| kzaitsev_mb | mfedosin: awesome! | 18:23 |
| nikhil | mfedosin: and he wants that plugin outside of glare | 18:23 |
| mfedosin | before activation glare will call it and verify your artifact | 18:23 |
| *** Guest63721 is now known as mfisch | 18:24 | |
| mfedosin | nikhil, there is a nuance :) | 18:24 |
| kzaitsev_mb | nikhil: is that a problem? | 18:24 |
| nikhil | and my concern is that we can't allow pip/github/tarball/http based installs | 18:24 |
| *** mfisch is now known as Guest2004 | 18:25 | |
| nikhil | I will let mfedosin say his opinion first :) | 18:25 |
| mfedosin | all 'blessed' plugins will be located in galnce repo | 18:25 |
| nikhil | ++ | 18:25 |
| mfedosin | if operator wants to install something else he can, I think | 18:25 |
| nikhil | and that is where I think we disagree | 18:25 |
| mfedosin | of course there is security risk | 18:25 |
| nikhil | yes | 18:26 |
| nikhil | and one more | 18:26 |
| nikhil | that we need to support pbr like logic | 18:26 |
| kairat_ | We could look at heat | 18:26 |
| nikhil | within glare/glance | 18:26 |
| nikhil | kairat_: sure .. how does that work? | 18:27 |
| kzaitsev_mb | nikhil: wouldn't that technically mean, that to get anything on glare — one would need to push that to glare repository and wait for next major OS release? | 18:27 |
| mfedosin | first, I think we have to add config opt: 'allow_custom_types' | 18:27 |
| kairat_ | All plugins in heat codebase | 18:27 |
| nikhil | so, my tradeoff proposal there is to create another oslo-incubator like repo that can sync logic into glare and ensure no operator mess at the source level | 18:28 |
| nikhil | kzaitsev_mb: so you get to sync in intervals | 18:28 |
| *** Guest2004 is now known as mfisch | 18:28 | |
| *** mfisch has quit IRC | 18:28 | |
| *** mfisch has joined #openstack-glance | 18:28 | |
| nikhil | Consider this situation | 18:28 |
| nikhil | when a operator installs a custom plugin with a hope that all the packages do not conflict | 18:29 |
| kairat_ | Heat refused from plugins after a while | 18:29 |
| kzaitsev_mb | kairat_: https://wiki.openstack.org/wiki/Heat/Plugins#Installation_and_Configuration | 18:29 |
| nikhil | currently the upper constraints in the openstack wide requirements effort ensure that projects and operators are stable | 18:29 |
| kzaitsev_mb | or is it outdated? | 18:29 |
| kairat_ | All contribs were moved to main tree | 18:30 |
| kairat_ | Afaik | 18:30 |
| *** vijendar has joined #openstack-glance | 18:30 | |
| kairat_ | You can install them, of course | 18:30 |
| *** boris-42 has joined #openstack-glance | 18:30 | |
| mfedosin | kzaitsev_mb: also, you don't need to update your plugin too often | 18:30 |
| nikhil | It's a operator mess to install custom packages | 18:30 |
| nikhil | as pip is not as advanced like apt-* or yum | 18:30 |
| kairat_ | But overall idea was not so successful afaiu | 18:31 |
| mfedosin | nikhil: you can install it with apt :) | 18:31 |
| kzaitsev_mb | mfedosin: that's a bad argument IMO =) | 18:31 |
| nikhil | mfedosin: that's even worse | 18:31 |
| johnthetubaguy | nikhil: we should catch up if that compat layer is nova specific, thats not the intention of the request from Nova | 18:31 |
| kzaitsev_mb | kairat_: https://github.com/openstack/heat/search?utf8=✓&q=plugin_dirs&type=Code a quick look at the code says, that you can have custom plugins in heat | 18:31 |
| nikhil | johnthetubaguy: sure thing. I am afraid to turn glanceclient into a openstack compat layer where we need layer over layer logic for small API calls :) | 18:32 |
| kairat_ | kzaitsev_mb: no new plugins | 18:32 |
| kairat_ | Only old plugins | 18:32 |
| mfedosin | johnthetubaguy: may I join too? | 18:32 |
| kairat_ | They stopped support it afaok | 18:32 |
| nikhil | johnthetubaguy: I find a different repo better route. | 18:33 |
| mfedosin | folks, let's add support of custom plugins for Murano | 18:33 |
| kzaitsev_mb | kairat_: any link to any discussion? =) | 18:33 |
| mfedosin | but add it secure | 18:33 |
| nikhil | I would like this approach to be documented too | 18:33 |
| kairat_ | Now i am walking | 18:33 |
| kairat_ | But will provide )) | 18:33 |
| mfedosin | and say - if you want to shoot you in the foot, enable this option | 18:33 |
| mfedosin | and of course it will be documented | 18:34 |
| nikhil | because I don't want to sign off on something that's prolly going to establish no-guarantee API run in the middle of upgrades (including failure to comply to failover logic etc) | 18:34 |
| kairat_ | mfedosin: seems reasonable | 18:34 |
| kairat_ | We must provide ot | 18:35 |
| *** flwang1 has joined #openstack-glance | 18:36 | |
| nikhil | sure, let's discuss technical details over the technical draft. | 18:36 |
| mfedosin | anyway, operator always can put his type in glance/objects | 18:36 |
| mfedosin | it's almost the same | 18:36 |
| mfedosin | nikhil: okay, let's do it on the next meeting | 18:36 |
| mfedosin | there will be a lot of votings there :D | 18:37 |
| nikhil | I would like to understand better, may be I am missing something really important here. | 18:37 |
| nikhil | mfedosin: sure, but I feel a bit disconnected with everyone in terms of the level of risk involved. | 18:38 |
| nikhil | so, if possible please share some collaborative document with us, kairat_ kzaitsev_mb and mfedosin | 18:38 |
| kzaitsev_mb | nikhil: I see 2 major problems with not allowing plugins from outside. 1) speed of development & delivering. It becomes basically impossible to add anything to stable glare, once it has been released. 2) custom verification logic. If everything lives inside glance — there will be no way to use external code for it. | 18:38 |
| kzaitsev_mb | not saying, that the approach is bad though | 18:38 |
| nikhil | kzaitsev_mb: ok, I think that gives me clearer picture. | 18:39 |
| nikhil | kzaitsev_mb: but did you get my concern? | 18:39 |
| kzaitsev_mb | nikhil: your main concern is that allowing external plugins basically makes glare unstable, since you do not have quality controll over plugin contents, right? | 18:40 |
| johnthetubaguy | nikhil: mfedosin: we have pencilled in a session at the summit on this, but it would be good to review your plans for the compat layer | 18:41 |
| nikhil | kzaitsev_mb: not exactly | 18:41 |
| nikhil | johnthetubaguy: ++ (review early) | 18:41 |
| nikhil | johnthetubaguy: may be a huddle sometime in the 3rd/4th week of march? | 18:41 |
| johnthetubaguy | nikhil: mfedosin: the thinking was simple, nova is not the only user of glance v1 API, so it seems odd for that code to live in nova, especially when glance has the experts on the differences | 18:41 |
| johnthetubaguy | nikhil: possibly, yeah | 18:41 |
| nikhil | johnthetubaguy: sounds good! | 18:42 |
| *** flwang1 has quit IRC | 18:42 | |
| nikhil | kzaitsev_mb: Just repeating things for clarity sake: if for some reason the installation goes bad like the custom plugin conflicts with a already installed package then in the middle of a upgrade or ops maintenance glare API will fail to start and for that matter glance API too | 18:42 |
| mfedosin | johnthetubaguy: but other project already have compat layers inside their codebase | 18:43 |
| mfedosin | and when we will have this layer inside glanceclient it will be hard to make them use it | 18:43 |
| mfedosin | but we will try | 18:43 |
| johnthetubaguy | mfedosin: there are other users of the API out there that we don't control, at least thats what folks were saying before | 18:44 |
| kzaitsev_mb | nikhil: oh, so your main concern is that there is no guarantee on external plugin's requirements/dependencies (like most OS projects have), and they can break installations pretty bad? | 18:44 |
| nikhil | kzaitsev_mb: so we have a very angry operator complaining (stable or master) glance or glare is not working where the issue was simple packaging logic that is currently governed by global requirements/release team | 18:44 |
| nikhil | kzaitsev_mb: correct | 18:44 |
| johnthetubaguy | mfedosin: some private clouds exposed glance v1, and gave their users python-glanceclient to access it, they have to move too, but lets go over this post FF week | 18:44 |
| nikhil | what we may end up having is that release team asking us to revert the custom logic out of glare | 18:44 |
| nikhil | kzaitsev_mb: ^ | 18:45 |
| kzaitsev_mb | packaging is hard | 18:45 |
| kzaitsev_mb | =) | 18:45 |
| nikhil | johnthetubaguy: I am interested in listening to the feedback too. | 18:45 |
| nikhil | kzaitsev_mb: yeah :| | 18:46 |
| nikhil | that's been the issue with pip for long time | 18:46 |
| nikhil | a more mature dependency mgmt may help (so if you are aware you could give potiners ...) | 18:46 |
| kzaitsev_mb | nikhil: actually packaging is the reason I wanted to come to the meeting today. We currently have our glare plugin inside murano and we're not happy with it =) | 18:46 |
| kzaitsev_mb | well actually we are happy. but everyone else isn't =) | 18:47 |
| nikhil | kzaitsev_mb: I can understand | 18:47 |
| nikhil | and I agree that should not be the case either, for a good health of openstack | 18:47 |
| mfedosin | johnthetubaguy: please ping me when you're ready to discuss the layer. I think I'll be the main developer, so I have to be aware of it | 18:48 |
| kzaitsev_mb | nikhil: ideal situation for packagers would be to have that plugin in a separate repository with it's own tags and and requirements. | 18:48 |
| *** vilobhmm11 has joined #openstack-glance | 18:49 | |
| nikhil | kzaitsev_mb: and that's the very reason I want to have a single unified place for all the custom plugins | 18:49 |
| nikhil | kzaitsev_mb: if it's just one repo then the issue can be narrowed down | 18:49 |
| kzaitsev_mb | nikhil: I believe, that such situation would have also solved your concerns. But not 100%, I guess, since once you allow one plugin in — everyone can come. | 18:50 |
| nikhil | kzaitsev_mb: sure, I think we *DO* want to encourage more custom plugins | 18:50 |
| nikhil | and slowly start adopting them in the main tree if at all possible | 18:51 |
| nikhil | but the nascent phase can be tricky | 18:51 |
| nikhil | until the projects and scope stabilize | 18:51 |
| *** e0ne has joined #openstack-glance | 18:51 | |
| *** khushbu has quit IRC | 18:52 | |
| nikhil | so, ideally we want the plugins to be looked after by multiple governing factors within openstack ecosystem | 18:52 |
| nikhil | 1. glare evolution | 18:52 |
| nikhil | 2. security evaluation before stable | 18:52 |
| nikhil | 3. requirements | 18:52 |
| nikhil | 4. collaboration (primarily within openstack) | 18:52 |
| *** khushbu_ has quit IRC | 18:52 | |
| nikhil | hence, a oslo-inc style repo would mean that we look at the plugins closely and together as a cross project effort and avoid last min hustle | 18:53 |
| *** sigmavirus24_awa is now known as sigmavirus24 | 18:53 | |
| kzaitsev_mb | nikhil: actually a separate repo doesn't sound bad from the point of the speed of development & ease of packaging/use | 18:54 |
| nikhil | kzaitsev_mb: I share the feelings | 18:54 |
| kzaitsev_mb | I'm still a bit concerned about the fact, that once stable/newton is out — there would be no way to add anything to it =) | 18:54 |
| nikhil | (for both of the points) | 18:54 |
| nikhil | kzaitsev_mb: so that's where we can tweak a little bit | 18:55 |
| nikhil | instead of oslo-inc we can release that repo to pip | 18:55 |
| nikhil | and catch up on global requirements sync | 18:55 |
| nikhil | and upper cap the repo everytime you want a change | 18:55 |
| nikhil | of course, I'm not the authority on that and this approach needs to be blessed by the release team to begin with | 18:55 |
| nikhil | so wasn't my first choice | 18:56 |
| kzaitsev_mb | nikhil: I see, that actually solves my concern, awesome idea | 18:56 |
| nikhil | ++ | 18:56 |
| *** lakshmiS_ has quit IRC | 18:57 | |
| mfedosin | nikhil: like glance_store? | 18:58 |
| nikhil | mfedosin: darn, but yes :D | 18:58 |
| mfedosin | good idea | 18:58 |
| kzaitsev_mb | nikhil: I think I'm sold on the idea =) gotta think it through a couple more times, but so far I like it. | 18:59 |
| mfedosin | I thought about it, but wanted to do it when we have a huge amount of types | 18:59 |
| *** kairat__ has joined #openstack-glance | 18:59 | |
| *** delattec has joined #openstack-glance | 19:00 | |
| *** delattec has quit IRC | 19:00 | |
| *** haomaiwang has quit IRC | 19:01 | |
| kzaitsev_mb | mfedosin: nikhil: so, what would be the next steps for glare and glos? =) | 19:01 |
| *** haomaiwang has joined #openstack-glance | 19:01 | |
| mfedosin | design base type (interface) | 19:02 |
| mfedosin | this week | 19:02 |
| nikhil | mfedosin: ah cool! | 19:02 |
| nikhil | kzaitsev_mb: ++ | 19:02 |
| mfedosin | next week start implementing api if there're no big concerns from api-wg | 19:02 |
| mfedosin | also creating a POC for images after that | 19:03 |
| mfedosin | other things will be discussed on the summit | 19:03 |
| kzaitsev_mb | I mean regarding what we've talked about =) should we document the idea somewhere, so that it not forgotten? =) | 19:03 |
| *** cdelatte has quit IRC | 19:03 | |
| nikhil | I think we can amend the API spec | 19:04 |
| nikhil | Add this in the Developer and Deployer impact sections. | 19:05 |
| mfedosin | kzaitsev_mb: it will be a part of glare api spec | 19:07 |
| *** julim has quit IRC | 19:07 | |
| mfedosin | I'll amend it tomorrow :) | 19:07 |
| nikhil | mfedosin: was about to ask | 19:08 |
| nikhil | mfedosin: let me comment it too for bookkeeping sake. | 19:08 |
| mfedosin | sure, please | 19:08 |
| kzaitsev_mb | nikhil: mfedosin: kairat__: thanks guys for the conversation. Please excuse me if I sounded edgy =) I would attribute that to the pressure of m-3 and upcoming FF (= | 19:09 |
| mfedosin | kzaitsev_mb: np man :) | 19:09 |
| *** julim has joined #openstack-glance | 19:10 | |
| mfedosin | kzaitsev_mb: go for sleep now ;) | 19:10 |
| mfedosin | it's late | 19:10 |
| nikhil | kzaitsev_mb: np at all. thanks for starting it early and for all your attempts to understand clearly during crunch time! | 19:11 |
| *** dims_ has joined #openstack-glance | 19:11 | |
| *** dims has quit IRC | 19:11 | |
| *** pt_15 has quit IRC | 19:12 | |
| *** pt_15 has joined #openstack-glance | 19:14 | |
| *** mtanino has quit IRC | 19:14 | |
| *** ducttape_ has quit IRC | 19:16 | |
| *** harshs has joined #openstack-glance | 19:16 | |
| *** ihrachys has joined #openstack-glance | 19:20 | |
| *** e0ne has quit IRC | 19:20 | |
| openstackgerrit | Merged openstack/python-glanceclient: Test: use assert_has_calls() instead https://review.openstack.org/281676 | 19:21 |
| *** cdelatte has joined #openstack-glance | 19:22 | |
| *** kzaitsev_mb has quit IRC | 19:23 | |
| *** ducttape_ has joined #openstack-glance | 19:23 | |
| *** jdillaman has quit IRC | 19:27 | |
| *** khushbu__ has joined #openstack-glance | 19:30 | |
| *** khushbu___ has joined #openstack-glance | 19:31 | |
| *** mtanino has joined #openstack-glance | 19:35 | |
| *** ihrachys has quit IRC | 19:44 | |
| *** achanda has joined #openstack-glance | 19:47 | |
| *** jdillaman has joined #openstack-glance | 19:56 | |
| flaper87 | Hey folks, if there are patches you'd like to see as part of the FF cut, please, let me know. | 19:57 |
| flaper87 | Let's work together on building the review queue | 19:57 |
| flaper87 | rosmaita: hey, any updates on the CIM patch? | 19:57 |
| *** achanda has quit IRC | 19:57 | |
| *** dims_ has quit IRC | 19:58 | |
| *** vijendar has quit IRC | 19:58 | |
| rosmaita | flaper87: i expressed my opinion that instead of using all lowercase property names, they should use camel case and not worry about the problem Lin talks about in his comment on PS 4 (Feb 17, 10:13 AM) | 20:00 |
| rosmaita | what do you think about that? | 20:00 |
| *** haomaiwang has quit IRC | 20:01 | |
| *** Guest71383 is now known as redrobot | 20:01 | |
| *** haomaiwang has joined #openstack-glance | 20:01 | |
| *** achanda has joined #openstack-glance | 20:11 | |
| *** dims has joined #openstack-glance | 20:12 | |
| *** david-lyle_ is now known as david-lyle | 20:12 | |
| *** pushkaru has quit IRC | 20:13 | |
| *** pushkaru has joined #openstack-glance | 20:13 | |
| flaper87 | rosmaita: I think I'd agree with that. I'm a bit worry on the impact of this when moving from v1 to v2 | 20:21 |
| flaper87 | Don't change the state of things, that is | 20:21 |
| flaper87 | at least not on that patch | 20:22 |
| *** flwang1 has joined #openstack-glance | 20:23 | |
| flwang | flaper87: ping re the location update | 20:24 |
| flaper87 | flwang: yo | 20:24 |
| flaper87 | sup ? | 20:25 |
| flaper87 | flwang: https://review.openstack.org/#/c/238130/ <- btw, help | 20:25 |
| flaper87 | :D | 20:25 |
| flaper87 | rosmaita: https://review.openstack.org/#/c/237742/ <- thoughts ? | 20:25 |
| *** kzaitsev_mb has joined #openstack-glance | 20:27 | |
| flwang | flaper87: clicking.... | 20:27 |
| *** vijendar has joined #openstack-glance | 20:27 | |
| *** dims has quit IRC | 20:29 | |
| flwang | flaper87: as for the location update patch, you asked why do we have to check if the location urls as same with current urls | 20:30 |
| flwang | that because based on current design, user can't change image's locations from non-empty to non-empty | 20:31 |
| flwang | so we need to make sure the urls are same, but we should allow the end user change location's metadata | 20:31 |
| flwang | flaper87: does that answer your question? | 20:31 |
| flaper87 | flwang: oh, I think I follow now. That if is convoluted, though | 20:35 |
| flwang | flaper87: yep, i can document it somewhere if it's necessary | 20:36 |
| flwang | flaper87: for now, the location update is totally broken :( | 20:36 |
| *** mfedosin has quit IRC | 20:37 | |
| flaper87 | flwang: I guess one thing that confuses me is why we need the second `if` | 20:40 |
| flaper87 | why can't we have a single for loop? | 20:40 |
| *** kairat__ has quit IRC | 20:41 | |
| flwang | flaper87: good question, maybe my note is not very clear | 20:41 |
| flwang | if the locations' url are not changed(same), then it's not necessary to recheck the locations | 20:41 |
| flwang | otherwise, if there is one location with restricted scheme(like file:///), then it will fail | 20:42 |
| flaper87 | Oh man, this logic | 20:42 |
| flwang | and it's really not necessary to recheck if the locations' url are same, we discussed it before | 20:42 |
| flwang | flaper87: yep, generally PTL is always on the top level so don't care the details :D | 20:43 |
| flaper87 | I remember when Zhi Yan wrote most of it, I commented saying that it was way to convoluted | 20:43 |
| flaper87 | I always care about details | 20:43 |
| flaper87 | :( | 20:43 |
| flwang | flaper87: it's very complicated, yes | 20:43 |
| flaper87 | Let's fix it for now and then, hopefully, we'll clean it up a bit | 20:44 |
| flwang | flaper87: i'm interested in locations part, in Newton, i may do some refactoring for it | 20:44 |
| flwang | flaper87: so does above explanation address your concern? | 20:44 |
| flaper87 | jokke_: https://review.openstack.org/#/c/280786/ if you have a chance! I know it's late for you so feel free to wait until tomorrow | 20:45 |
| *** pt_15 has quit IRC | 20:45 | |
| jokke_ | flaper87: https://review.openstack.org/#/q/topic:glance-store_0.12.0 | 20:46 |
| flaper87 | jokke_: thanks | 20:46 |
| *** TravT has quit IRC | 20:46 | |
| *** mine0901 has quit IRC | 20:49 | |
| *** MVenesio has quit IRC | 20:49 | |
| *** itisha has quit IRC | 20:49 | |
| *** MVenesio has joined #openstack-glance | 20:49 | |
| *** MVenesio has quit IRC | 20:50 | |
| *** ducttape_ has quit IRC | 20:50 | |
| flwang | flaper87: thanks | 20:53 |
| * jokke_ is reading backlog | 20:53 | |
| *** mine0901 has joined #openstack-glance | 20:53 | |
| flwang | flaper87: would you mind reviewing the client change for the location update issue? https://review.openstack.org/#/c/280789/ | 20:53 |
| *** kairat_ has quit IRC | 20:56 | |
| *** harshs has quit IRC | 20:57 | |
| jokke_ | flaper87, flwang: just sent you an invite ... I'd like to talk about something ref locations | 20:59 |
| *** harshs has joined #openstack-glance | 21:01 | |
| *** haomaiwang has quit IRC | 21:01 | |
| *** chlong_ has joined #openstack-glance | 21:01 | |
| *** haomaiwang has joined #openstack-glance | 21:01 | |
| *** ducttape_ has joined #openstack-glance | 21:02 | |
| *** davideagnello has quit IRC | 21:03 | |
| *** davideagnello has joined #openstack-glance | 21:04 | |
| *** lakshmiS has joined #openstack-glance | 21:05 | |
| *** smatzek has quit IRC | 21:09 | |
| *** pushkaru has quit IRC | 21:09 | |
| *** khushbu__ has quit IRC | 21:13 | |
| *** khushbu___ has quit IRC | 21:13 | |
| *** vijendar has quit IRC | 21:16 | |
| *** ayoung has joined #openstack-glance | 21:17 | |
| openstackgerrit | dane-fichter proposed openstack/glance: Add support for ECC signatures https://review.openstack.org/244347 | 21:19 |
| *** lakshmiS_ has joined #openstack-glance | 21:20 | |
| *** TravT has joined #openstack-glance | 21:23 | |
| *** dims has joined #openstack-glance | 21:23 | |
| *** lakshmiS has quit IRC | 21:23 | |
| *** vijendar has joined #openstack-glance | 21:26 | |
| *** lakshmiS_ has quit IRC | 21:29 | |
| *** lakshmiS has joined #openstack-glance | 21:29 | |
| *** lakshmiS_ has joined #openstack-glance | 21:30 | |
| *** davideagnello has quit IRC | 21:32 | |
| *** cdelatte has quit IRC | 21:33 | |
| rosmaita | nikhil: got a minute? | 21:34 |
| *** davideagnello has joined #openstack-glance | 21:34 | |
| *** lakshmiS has quit IRC | 21:34 | |
| *** dims has quit IRC | 21:40 | |
| *** lakshmiS_ has quit IRC | 21:41 | |
| *** lakshmiS has joined #openstack-glance | 21:42 | |
| *** cdelatte has joined #openstack-glance | 21:42 | |
| nikhil | rosmaita: hey yes, was in a cp quotas meeting | 21:43 |
| nikhil | here now | 21:43 |
| rosmaita | cool | 21:43 |
| rosmaita | quick question ... did you have any reservations about deprecating use_user_token ? | 21:44 |
| rosmaita | i thought maybe you did , but i may be confusing it with something else | 21:44 |
| *** dims has joined #openstack-glance | 21:44 | |
| *** sabari has joined #openstack-glance | 21:44 | |
| *** kebray has joined #openstack-glance | 21:44 | |
| rosmaita | nikhil: https://review.openstack.org/#/c/237742/ | 21:45 |
| nikhil | rosmaita: I don't personally but I think all those long running snapshots would suddenly start failing without trusts and ops relying on this config option for them to succeed would be super duper angry | 21:46 |
| nikhil | those were my $0.02 (well, more like $0.10 :P) ifkwim | 21:46 |
| rosmaita | nikhil: thanks ... i guess the deprecation will get people's attention, and if there's an outcry, we can reconsider | 21:47 |
| rosmaita | this patch set just adds the deprecation and changes the value in a test; the default was already use_user_token = true | 21:48 |
| nikhil | rosmaita: I don't think there's coming back because it's a sec risk. only option is to delay or enforce use of trusts and ask for all necessary changes to happen for that to succeed. | 21:48 |
| nikhil | rosmaita: right, I didn't see the deletion promise timeline | 21:49 |
| nikhil | rosmaita: if it's not Newton, I think we're safe | 21:49 |
| rosmaita | nikhil: it doesn't explicitly say newton (i don't think, i will look again) | 21:49 |
| nikhil | rosmaita: but I think for trusts to work correctly we need to provide a in-source migration to operators to help them upgrade old style swift locations to swift+config | 21:49 |
| nikhil | rosmaita: in-source (in-tree) migration for image-locations and I think that's nowhere on the timline! | 21:50 |
| rosmaita | gotcha | 21:50 |
| nikhil | I think such fast deprecations work fine for private clouds | 21:50 |
| nikhil | BUT I'm seriously worried about our approach working out for large and old public ones | 21:50 |
| *** cdelatte has quit IRC | 21:52 | |
| *** cdelatte has joined #openstack-glance | 21:53 | |
| *** edmondsw has quit IRC | 21:53 | |
| *** cdelatte has quit IRC | 21:54 | |
| *** vilobhmm11 has quit IRC | 21:58 | |
| *** vilobhmm11 has joined #openstack-glance | 21:59 | |
| *** vilobhmm11 has quit IRC | 22:00 | |
| *** vilobhmm11 has joined #openstack-glance | 22:00 | |
| *** haomaiwang has quit IRC | 22:01 | |
| *** haomaiwa_ has joined #openstack-glance | 22:01 | |
| openstackgerrit | Fei Long Wang proposed openstack/python-glanceclient: Fix location update https://review.openstack.org/280789 | 22:04 |
| rosmaita | nikhil: you may want to leave a comment on https://review.openstack.org/#/c/237742/ if you have a minute | 22:04 |
| nikhil | rosmaita: *just* saw your comment! I am adding mine too.. | 22:05 |
| *** dims has quit IRC | 22:09 | |
| *** vilobhmm11 has left #openstack-glance | 22:13 | |
| *** vijendar has quit IRC | 22:29 | |
| *** vijendar has joined #openstack-glance | 22:37 | |
| *** julim has quit IRC | 22:39 | |
| *** ninag has quit IRC | 22:47 | |
| *** MVenesio has joined #openstack-glance | 22:50 | |
| rosmaita | nikhil: thanks for looking ... i don't know how i missed all those Ns ... guess i need new glasses | 22:51 |
| nikhil | rosmaita: np | 22:51 |
| *** achanda has quit IRC | 22:54 | |
| *** azbiswas has joined #openstack-glance | 22:55 | |
| *** MVenesio has quit IRC | 22:56 | |
| *** azbiswas has left #openstack-glance | 22:59 | |
| *** haomaiwa_ has quit IRC | 23:01 | |
| *** haomaiwang has joined #openstack-glance | 23:01 | |
| *** achanda has joined #openstack-glance | 23:08 | |
| *** vijendar has quit IRC | 23:14 | |
| *** dims has joined #openstack-glance | 23:14 | |
| *** ninag has joined #openstack-glance | 23:18 | |
| *** ninag has quit IRC | 23:22 | |
| *** dshakhray has quit IRC | 23:31 | |
| *** mine0901 has quit IRC | 23:49 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!