| *** haomaiwang has quit IRC | 00:01 | |
| *** 77CAAFBH5 has joined #openstack-glance | 00:01 | |
| *** harshs has quit IRC | 00:15 | |
| *** harshs has joined #openstack-glance | 00:55 | |
| *** 77CAAFBH5 has quit IRC | 01:01 | |
| *** tobe has joined #openstack-glance | 01:02 | |
| *** haomaiwa_ has joined #openstack-glance | 01:03 | |
| *** tobe has quit IRC | 01:03 | |
| *** haomaiwa_ has quit IRC | 01:03 | |
| *** takedakn has joined #openstack-glance | 01:32 | |
| *** takedakn has quit IRC | 01:40 | |
| *** 5EXAAL60H has joined #openstack-glance | 01:51 | |
| *** boris-42 has quit IRC | 01:53 | |
| *** 5EXAAL60H has quit IRC | 02:01 | |
| *** haomaiwang has joined #openstack-glance | 02:01 | |
| *** mingdang1 has joined #openstack-glance | 02:17 | |
| *** nikhil_k has joined #openstack-glance | 02:20 | |
| *** nikhil has quit IRC | 02:22 | |
| *** houming has joined #openstack-glance | 02:31 | |
| *** haomaiwang has quit IRC | 03:01 | |
| *** 17WABFXHA has joined #openstack-glance | 03:01 | |
| openstackgerrit | wangxiyuan proposed openstack/glance: Fix help command in cache manange and replicator https://review.openstack.org/262365 | 03:10 |
|---|---|---|
| *** MattMan has quit IRC | 03:17 | |
| *** MattMan has joined #openstack-glance | 03:17 | |
| *** links has joined #openstack-glance | 03:32 | |
| *** harshs has quit IRC | 03:45 | |
| *** 17WABFXHA has quit IRC | 04:01 | |
| *** 7YUAAH1CF has joined #openstack-glance | 04:01 | |
| *** rsjethani has joined #openstack-glance | 04:15 | |
| *** dims has quit IRC | 04:24 | |
| *** sigmavirus24_awa is now known as sigmavirus24 | 04:30 | |
| *** ducttape_ has quit IRC | 04:49 | |
| *** ducttape_ has joined #openstack-glance | 04:51 | |
| *** 7YUAAH1CF has quit IRC | 05:01 | |
| *** haomaiwang has joined #openstack-glance | 05:01 | |
| *** ducttape_ has quit IRC | 05:17 | |
| *** harshs has joined #openstack-glance | 05:25 | |
| *** changbl has quit IRC | 05:26 | |
| *** sigmavirus24 is now known as sigmavirus24_awa | 05:30 | |
| *** sgotliv has joined #openstack-glance | 05:38 | |
| *** harshs has quit IRC | 05:57 | |
| *** haomaiwang has quit IRC | 06:01 | |
| *** haomaiwang has joined #openstack-glance | 06:01 | |
| *** harshs has joined #openstack-glance | 06:14 | |
| *** rsjethani has quit IRC | 06:16 | |
| *** haomaiwang has quit IRC | 06:19 | |
| *** haomaiwang has joined #openstack-glance | 06:19 | |
| *** harshs has quit IRC | 06:50 | |
| *** haomaiwang has quit IRC | 07:01 | |
| *** haomaiwang has joined #openstack-glance | 07:01 | |
| *** gberginc has joined #openstack-glance | 07:12 | |
| *** rsjethani has joined #openstack-glance | 07:24 | |
| *** GB21 has joined #openstack-glance | 07:36 | |
| *** sgotliv has quit IRC | 07:54 | |
| *** haomaiwang has quit IRC | 07:58 | |
| *** haomaiwa_ has joined #openstack-glance | 08:02 | |
| *** wxy__ has quit IRC | 08:04 | |
| *** wxy__ has joined #openstack-glance | 08:05 | |
| *** GB21 has quit IRC | 08:39 | |
| rsjethani | kairat u here? | 08:47 |
| *** openstackstatus has quit IRC | 08:50 | |
| *** openstackstatus has joined #openstack-glance | 08:51 | |
| *** ChanServ sets mode: +v openstackstatus | 08:51 | |
| *** haomaiwa_ has quit IRC | 09:01 | |
| *** haomaiwang has joined #openstack-glance | 09:01 | |
| *** sgotliv has joined #openstack-glance | 09:08 | |
| kairat | rsjethani, hi | 09:18 |
| kairat | yep, i am here | 09:18 |
| rsjethani | i would like to discuss ur approach regarding request id patch | 09:19 |
| rsjethani | https://review.openstack.org/#/c/261288/ | 09:20 |
| kairat | yep, I have seen that | 09:20 |
| kairat | IIUC, your approach is more robust according to the following criteria: | 09:21 |
| kairat | The 'AppendHeaderHook' method has to know that request id is present as a value for a key called 'x-openstack-request-id'. What if in future this key changes? | 09:21 |
| kairat | The 'AppendHeaderHook' method is assuming that it will be given a 'Response' object but the API may decide to use something else in the future. | 09:21 |
| kairat | When I was writing the review I was wondering if request_id should be really part of our API | 09:23 |
| kairat | IMO, when you have some empty list as part of API then smth is not good | 09:24 |
| kairat | I'll try to reply in details although your suggestion make sense | 09:28 |
| kairat | I just would to hear more opinion on this | 09:28 |
| rsjethani | ok | 09:31 |
| kairat | But I think you will get more opinions after Holidays=) | 09:32 |
| rsjethani | ya thats true :) | 09:32 |
| rsjethani | how od you see your approach being affected by future changes? | 09:35 |
| rsjethani | do* | 09:35 |
| rsjethani | let me summarize your approach to see if I understand it correclty | 09:39 |
| rsjethani | 'AppendHeaderHook' method will be on caller side. And there can be many more methods like these | 09:40 |
| rsjethani | These 'hook' methods will be passed as a list to the API. Then these will be simply passed as response hooks while making request. | 09:42 |
| rsjethani | Is this correct? | 09:42 |
| rsjethani | OR do you mean to say that glance client will extract request id from response header and then call this 'hook' function? | 09:45 |
| kairat | I meant first | 09:49 |
| kairat | I know that this approach is not so robust as yours | 09:49 |
| kairat | But once we add request_ids to API it will never get changed | 09:49 |
| kairat | perhaps we need to require some interface for hook class to ensure that API is not broken | 09:50 |
| kairat | need to think about it | 09:50 |
| rsjethani | if you are saying that 'AppendHeaderHook' will be simply passed as hook while making request then AppendHeaderHook should also be passed response object so that it can extract req id | 09:52 |
| rsjethani | I am trying to implement your approach that is why i need more details. i was unable to clearly understand the appraoach in the comments | 09:56 |
| kairat | Yep | 09:56 |
| kairat | I am not sure it is passed to server | 09:56 |
| kairat | AFAIK, request lib provides hooks for responses only | 09:56 |
| kairat | hmm | 09:57 |
| kairat | I am also thinking about changing response in hook | 09:57 |
| kairat | Is it possible? WDYT? | 09:57 |
| kairat | If yes then my proposal probably is wrong | 09:58 |
| kairat | until we allow hook to just extract attribute values. | 09:58 |
| rsjethani | changin response? why? | 10:00 |
| *** haomaiwang has quit IRC | 10:01 | |
| rsjethani | ya requests only provides responsehook rit now | 10:01 |
| *** haomaiwang has joined #openstack-glance | 10:01 | |
| kairat | We cannot be sure that this can't be used by frauds=) | 10:01 |
| kairat | sorry, not correct word | 10:02 |
| kairat | yep, you are right | 10:03 |
| rsjethani | hmm then lets wait for others to review | 10:03 |
| kairat | If I am making request then there is nothing to do with response | 10:03 |
| kairat | Ok | 10:03 |
| rsjethani | so you think this hook feature of requests lib can have security issues? | 10:07 |
| kairat | Now, i don't think | 10:08 |
| kairat | If you are updating only response | 10:09 |
| kairat | If you updated response somehow with the hook you've got incorrect response | 10:09 |
| kairat | But that's is not client trouble=) | 10:09 |
| rsjethani | ryt | 10:10 |
| rsjethani | i didnt understand your 'changing response in hook' comment | 10:10 |
| rsjethani | please explain | 10:11 |
| kairat | That's actually was a question | 10:12 |
| kairat | If we will provide hook as part of api | 10:12 |
| kairat | then smb can get header values from response | 10:12 |
| kairat | Can smd set header values in hook? | 10:12 |
| kairat | This was a question | 10:13 |
| kairat | But it is not relevant anymore | 10:13 |
| kairat | Just wanted to explain my thought | 10:13 |
| rsjethani | yes i think we can set headers | 10:13 |
| kairat | I think you better to wait other reviews | 10:14 |
| kairat | Perhaps, smd will enhance the approach | 10:15 |
| kairat | or agree with you | 10:16 |
| kairat | I need some time to think how to enhance my proposal to address your concerns | 10:17 |
| rsjethani | ok :) | 10:18 |
| *** e0ne has joined #openstack-glance | 10:19 | |
| rsjethani | can u tell me what is meant by IIUC? | 10:19 |
| kairat | If i understand correctly | 10:20 |
| rsjethani | ohh thanks | 10:20 |
| rsjethani | m new to irc ;) | 10:20 |
| *** mingdang1 has quit IRC | 10:49 | |
| *** haomaiwang has quit IRC | 11:01 | |
| *** haomaiwa_ has joined #openstack-glance | 11:01 | |
| *** rsjethani has quit IRC | 11:03 | |
| *** slunkad has quit IRC | 11:25 | |
| *** slunkad has joined #openstack-glance | 11:38 | |
| *** smatzek has joined #openstack-glance | 11:40 | |
| *** haomaiwa_ has quit IRC | 12:01 | |
| *** wxy__ has quit IRC | 12:01 | |
| *** 5EXAAL93X has joined #openstack-glance | 12:01 | |
| *** wxy has joined #openstack-glance | 12:02 | |
| *** mfedosin has joined #openstack-glance | 12:12 | |
| *** dims has joined #openstack-glance | 12:13 | |
| *** HenryG has quit IRC | 12:42 | |
| *** HenryG has joined #openstack-glance | 12:46 | |
| *** 5EXAAL93X has quit IRC | 12:48 | |
| *** rsjethani has joined #openstack-glance | 12:49 | |
| *** 5EXAAMAE2 has joined #openstack-glance | 12:49 | |
| rsjethani | kairat u here? | 12:50 |
| *** houming has quit IRC | 12:52 | |
| kairat | yep | 12:52 |
| *** 5EXAAMAE2 has quit IRC | 13:01 | |
| *** haomaiwa_ has joined #openstack-glance | 13:01 | |
| rsjethani | kindly check: https://pastee.org/ms62u | 13:14 |
| *** ducttape_ has joined #openstack-glance | 13:14 | |
| rsjethani | is this code reflects your approach? | 13:15 |
| openstackgerrit | zhangguoqing proposed openstack/glance: Use timeutils from oslo.utils https://review.openstack.org/262491 | 13:17 |
| *** haomaiwa_ has quit IRC | 13:26 | |
| kairat | yes | 13:28 |
| openstackgerrit | Darja Shakhray proposed openstack/python-glanceclient: Use session when not specified token or endpoint https://review.openstack.org/262220 | 13:28 |
| kairat | Like this | 13:29 |
| kairat | Although you can do the same within one object | 13:30 |
| *** sigmavirus24_awa is now known as sigmavirus24 | 13:44 | |
| *** rsjethani has quit IRC | 13:49 | |
| *** gberginc has quit IRC | 13:54 | |
| *** 14WAAJM8B has joined #openstack-glance | 13:58 | |
| *** links has quit IRC | 13:59 | |
| *** changbl has joined #openstack-glance | 13:59 | |
| *** 14WAAJM8B has quit IRC | 14:01 | |
| *** haomaiwang has joined #openstack-glance | 14:01 | |
| *** ducttape_ has quit IRC | 14:15 | |
| openstackgerrit | HouMing Wang proposed openstack/glance: Use six.moves.reduce instead of builtin reduce https://review.openstack.org/262523 | 14:16 |
| *** haomaiwang has quit IRC | 14:17 | |
| *** haomaiw__ has joined #openstack-glance | 14:17 | |
| *** ducttape_ has joined #openstack-glance | 14:18 | |
| *** ducttape_ has quit IRC | 14:24 | |
| *** gberginc has joined #openstack-glance | 14:27 | |
| *** ducttape_ has joined #openstack-glance | 14:33 | |
| *** ducttape_ has quit IRC | 14:34 | |
| *** mfedosin has quit IRC | 14:38 | |
| openstackgerrit | Harshada Mangesh Kakad proposed openstack/glance: Fixing the deprecated library function. https://review.openstack.org/262265 | 14:41 |
| *** ducttape_ has joined #openstack-glance | 14:46 | |
| openstackgerrit | LiuNanke proposed openstack/glance: Using LOG.warning replace LOG.warn https://review.openstack.org/262237 | 14:47 |
| *** mingdang1 has joined #openstack-glance | 14:54 | |
| *** links has joined #openstack-glance | 14:55 | |
| *** ducttape_ has quit IRC | 14:58 | |
| *** haomaiw__ has quit IRC | 15:01 | |
| *** gberginc has quit IRC | 15:01 | |
| *** 18WABN3YA has joined #openstack-glance | 15:01 | |
| *** mingdang1 has quit IRC | 15:35 | |
| *** smatzek has quit IRC | 15:51 | |
| *** 18WABN3YA has quit IRC | 15:53 | |
| *** links has quit IRC | 16:11 | |
| *** 14WAAJOMA has joined #openstack-glance | 16:13 | |
| *** 14WAAJOMA has quit IRC | 16:16 | |
| *** e0ne has quit IRC | 16:18 | |
| *** bharath has joined #openstack-glance | 16:21 | |
| *** links has joined #openstack-glance | 16:33 | |
| *** ducttape_ has joined #openstack-glance | 16:34 | |
| *** sgotliv has quit IRC | 16:34 | |
| *** haomaiwang has joined #openstack-glance | 16:34 | |
| *** jaypipes has joined #openstack-glance | 16:37 | |
| *** haomaiwang has quit IRC | 16:38 | |
| *** ducttape_ has quit IRC | 16:40 | |
| *** links has quit IRC | 16:41 | |
| *** groen692 has quit IRC | 17:00 | |
| *** ducttape_ has joined #openstack-glance | 17:36 | |
| *** ducttape_ has quit IRC | 17:40 | |
| *** dslevin has joined #openstack-glance | 17:44 | |
| *** e0ne has joined #openstack-glance | 17:53 | |
| *** e0ne has quit IRC | 17:54 | |
| *** e0ne has joined #openstack-glance | 17:58 | |
| *** harshs has joined #openstack-glance | 18:30 | |
| *** ducttape_ has joined #openstack-glance | 18:36 | |
| *** ducttape_ has quit IRC | 18:41 | |
| *** e0ne has quit IRC | 18:48 | |
| *** davideag_ has joined #openstack-glance | 19:01 | |
| *** davideagnello has quit IRC | 19:03 | |
| *** bharath has quit IRC | 19:04 | |
| *** agireud has joined #openstack-glance | 19:26 | |
| *** ducttape_ has joined #openstack-glance | 19:37 | |
| *** harshs has quit IRC | 19:41 | |
| *** ducttape_ has quit IRC | 19:42 | |
| *** haomaiwang has joined #openstack-glance | 19:54 | |
| *** haomaiwang has quit IRC | 19:58 | |
| *** openstackstatus has quit IRC | 20:35 | |
| *** openstack has joined #openstack-glance | 20:36 | |
| *** openstackstatus has joined #openstack-glance | 20:36 | |
| *** ChanServ sets mode: +v openstackstatus | 20:36 | |
| *** ducttape_ has joined #openstack-glance | 20:38 | |
| *** ducttape_ has quit IRC | 20:42 | |
| *** e0ne has joined #openstack-glance | 20:56 | |
| *** e0ne has quit IRC | 21:01 | |
| *** openstackstatus has quit IRC | 21:05 | |
| *** openstack has joined #openstack-glance | 21:06 | |
| *** openstackstatus has joined #openstack-glance | 21:06 | |
| *** ChanServ sets mode: +v openstackstatus | 21:06 | |
| *** dslevin has quit IRC | 21:14 | |
| *** dslevin has joined #openstack-glance | 21:14 | |
| *** dslevin has quit IRC | 21:18 | |
| *** ducttape_ has joined #openstack-glance | 21:39 | |
| *** haomaiwa_ has joined #openstack-glance | 21:43 | |
| *** david-lyle has quit IRC | 21:43 | |
| *** ducttape_ has quit IRC | 21:43 | |
| *** haomaiwa_ has quit IRC | 21:45 | |
| *** harshs has joined #openstack-glance | 21:45 | |
| *** harshs has quit IRC | 21:51 | |
| *** john5223 has joined #openstack-glance | 21:57 | |
| *** sgotliv has joined #openstack-glance | 21:59 | |
| john5223 | anyone know why --copy-from was removed from glance? | 22:00 |
| *** dslevin has joined #openstack-glance | 22:01 | |
| *** dslevin has quit IRC | 22:06 | |
| *** openstackstatus has quit IRC | 22:19 | |
| *** openstackstatus has joined #openstack-glance | 22:20 | |
| *** ChanServ sets mode: +v openstackstatus | 22:20 | |
| *** harshs has joined #openstack-glance | 22:30 | |
| openstackgerrit | Brianna Poulos proposed openstack/glance: Add support for ECC signatures https://review.openstack.org/244347 | 22:31 |
| *** harshs has quit IRC | 22:39 | |
| *** ducttape_ has joined #openstack-glance | 22:40 | |
| openstackgerrit | Brianna Poulos proposed openstack/glance: Add support for DSA signatures https://review.openstack.org/248237 | 22:43 |
| *** ducttape_ has quit IRC | 22:44 | |
| *** david-lyle has joined #openstack-glance | 22:44 | |
| *** dslevin has joined #openstack-glance | 22:55 | |
| *** dslevin has quit IRC | 23:00 | |
| *** bapalm has quit IRC | 23:17 | |
| *** sigmavirus24 is now known as sigmavirus24_awa | 23:19 | |
| *** bapalm has joined #openstack-glance | 23:23 | |
| *** harshs has joined #openstack-glance | 23:30 | |
| *** haomaiwang has joined #openstack-glance | 23:31 | |
| *** haomaiwang has quit IRC | 23:34 | |
| *** ducttape_ has joined #openstack-glance | 23:40 | |
| *** ducttape_ has quit IRC | 23:45 | |
| *** dslevin has joined #openstack-glance | 23:50 | |
| *** dslevin has quit IRC | 23:54 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!