*** annashen has joined #openstack-glance | 00:03 | |
*** ericpeterson has joined #openstack-glance | 00:19 | |
*** ericpeterson has quit IRC | 00:19 | |
*** sigmavirus24_awa is now known as sigmavirus24 | 00:26 | |
*** annashen has quit IRC | 00:38 | |
stevelle | would it be considered ill mannered of me to just rebase and mark Co-Authored-By for https://review.openstack.org/#/c/80847 at this point? | 00:38 |
---|---|---|
nikhil_k | stevelle: or you can propose a new one too. it's been a while | 00:42 |
nikhil_k | btw, I'm about to log off for now | 00:42 |
stevelle | nikhil_k: I'm happy to leave as co-authored since much of the work is done there already and it closes an old CR that is just languishing | 00:43 |
stevelle | thx for the answer btw | 00:43 |
*** stpierre has quit IRC | 00:56 | |
openstackgerrit | Chris St. Pierre proposed openstack/glance: Purge dead file-backed scrubber queue code https://review.openstack.org/161051 | 01:02 |
sigmavirus24 | stevelle: go for it | 01:04 |
*** sigmavirus24 is now known as sigmavirus24_awa | 01:06 | |
*** annegentle has quit IRC | 01:08 | |
*** annegentle has joined #openstack-glance | 01:12 | |
*** davechen has joined #openstack-glance | 01:17 | |
*** annegentle has quit IRC | 01:19 | |
junhongl | flwang: hello | 01:21 |
flwang | junhongl: hi | 01:21 |
junhongl | flwang: i have a patch here, which has got one +2, could you help to have a look? | 01:22 |
junhongl | flwang: https://review.openstack.org/#/c/153169/ | 01:22 |
flwang | just had a quick review, so after catch the notfound exception, can the image be deleted? | 01:24 |
junhongl | yes | 01:24 |
junhongl | which is the common mechanism similar with other backend, like filesystem | 01:25 |
flwang | ok, I need check the code in images.py to make sure it works | 01:27 |
flwang | btw, did you verify it in both v1 and v2? | 01:27 |
junhongl | sure | 01:27 |
flwang | ok, cool | 01:28 |
junhongl | hmm, as far as i remembered, i just verify in v1, i can check the v2 as well | 01:28 |
flwang | pls do it :) | 01:29 |
junhongl | yep, will keep you updated | 01:29 |
*** TravT has quit IRC | 01:30 | |
*** vilobhmm has quit IRC | 01:48 | |
*** jamielennox is now known as jamielennox|away | 01:59 | |
*** annegentle has joined #openstack-glance | 02:20 | |
*** annegentle has quit IRC | 02:25 | |
*** jamielennox|away is now known as jamielennox | 02:37 | |
*** Longgeek has joined #openstack-glance | 02:47 | |
*** jamielennox is now known as jamielennox|away | 02:52 | |
*** jamielennox|away is now known as jamielennox | 02:55 | |
*** jamielennox is now known as jamielennox|away | 02:56 | |
*** jamielennox|away is now known as jamielennox | 02:57 | |
*** annegentle has joined #openstack-glance | 03:05 | |
openstackgerrit | Steve Lewis proposed openstack/glance: Refactor API function test class https://review.openstack.org/80847 | 03:06 |
*** annegentle has quit IRC | 03:07 | |
openstackgerrit | Steve Lewis proposed openstack/glance: Refactor API function test class https://review.openstack.org/80847 | 03:07 |
*** harlowja_ is now known as harlowja_away | 03:21 | |
sabari | zhiyan: https://review.openstack.org/#/c/148426/ is actually ready for reviews. | 03:34 |
sabari | I am investigating failure with unit tests in the gate though it passes locally. | 03:34 |
sabari | Just FYI :) | 03:34 |
openstackgerrit | Zhi Yan Liu proposed openstack/glance: Add capabilities to storage driver https://review.openstack.org/141825 | 03:36 |
zhiyan | sabari: for sure. actually I was going to have a check this morning, but noticed -1 from jenkins.. | 03:41 |
zhiyan | Just FYI too :) | 03:42 |
sabari | zhiyan: Yeah, there is something with the mock that fails upstream but passes locally. I will update the patch asap :). Thanks | 03:42 |
zhiyan | sabari: ok .. (even for pep8 check ?) | 03:43 |
sabari | zhiyan: haha no, that passed before recheck, I need to fix it :) | 03:44 |
zhiyan | sabari: i'm checking functional code now...no rush :) | 03:46 |
*** changbl has joined #openstack-glance | 03:48 | |
*** ericpeterson has joined #openstack-glance | 03:49 | |
*** flwang1 has quit IRC | 03:56 | |
*** ericpeterson has quit IRC | 03:57 | |
*** vilobhmm has joined #openstack-glance | 03:57 | |
*** spzala has quit IRC | 04:03 | |
*** haomaiwang has joined #openstack-glance | 04:04 | |
*** adam_g has quit IRC | 04:20 | |
openstackgerrit | Merged openstack/glance_store: Enable DRIVER_REUSABLE for vmware store https://review.openstack.org/160532 | 04:22 |
*** adam_g has joined #openstack-glance | 04:28 | |
*** mgagne has quit IRC | 04:31 | |
*** vilobhmm has quit IRC | 04:44 | |
*** mgagne has joined #openstack-glance | 04:45 | |
*** mgagne is now known as Guest75711 | 04:45 | |
*** rajesht has joined #openstack-glance | 04:45 | |
*** openstackgerrit has quit IRC | 04:46 | |
*** openstackgerrit has joined #openstack-glance | 04:52 | |
*** comstud has quit IRC | 05:00 | |
*** abhishekk has joined #openstack-glance | 05:03 | |
*** bkopilov has joined #openstack-glance | 05:05 | |
*** vilobhmm has joined #openstack-glance | 05:11 | |
*** vilobhmm1 has joined #openstack-glance | 05:16 | |
*** vilobhmm has quit IRC | 05:19 | |
openstackgerrit | Abhishek Talwar proposed openstack/python-glanceclient: Wrong help for glance image-update https://review.openstack.org/157347 | 05:23 |
*** Longgeek has quit IRC | 05:28 | |
openstackgerrit | Zhi Yan Liu proposed openstack/glance_store: Correct such logic in store.get() when chunk_size param provided https://review.openstack.org/136039 | 05:32 |
*** jamielennox is now known as jamielennox|away | 05:32 | |
*** openstack has joined #openstack-glance | 05:35 | |
openstackgerrit | Abhishek Talwar proposed openstack/python-glanceclient: Wrong help for glance image-update https://review.openstack.org/157347 | 05:51 |
openstackgerrit | OpenStack Proposal Bot proposed openstack/glance: Imported Translations from Transifex https://review.openstack.org/158570 | 06:02 |
*** vilobhmm1 has quit IRC | 06:07 | |
*** Longgeek has joined #openstack-glance | 06:08 | |
junhongl | flwang: hi Fei Long, I checked for both v1 and v2 api in command | 06:08 |
junhongl | flwang: both worked | 06:08 |
junhongl | flwang: I deleted the image in vmware datastore first, then run image-delete cli with --os-image-api-version 1 and 2 | 06:09 |
junhongl | flwang: work fine | 06:10 |
*** TravT has joined #openstack-glance | 06:15 | |
*** TravT has quit IRC | 06:15 | |
openstackgerrit | Rajesh Tailor proposed openstack/glance: Raise exception if store location URL not found https://review.openstack.org/137515 | 06:17 |
*** TravT has joined #openstack-glance | 06:18 | |
*** nlevinki has joined #openstack-glance | 06:50 | |
*** flwang has quit IRC | 07:04 | |
*** flwang has joined #openstack-glance | 07:07 | |
*** groen692 has joined #openstack-glance | 07:17 | |
*** Longgeek has quit IRC | 07:21 | |
*** david-lyle_afk has joined #openstack-glance | 07:33 | |
*** Longgeek has joined #openstack-glance | 07:34 | |
*** sgotliv has quit IRC | 07:43 | |
*** openstackgerrit has quit IRC | 07:49 | |
*** openstackgerrit has joined #openstack-glance | 07:49 | |
*** flwang1 has joined #openstack-glance | 07:50 | |
openstackgerrit | Sabari proposed openstack/glance_store: VMware: Support Multiple Datastores https://review.openstack.org/148426 | 07:56 |
*** ParsectiX has joined #openstack-glance | 08:00 | |
*** markus_z has joined #openstack-glance | 08:03 | |
*** chlong has quit IRC | 08:20 | |
*** abhishekk has quit IRC | 08:34 | |
openstackgerrit | Merged openstack/python-glanceclient: https: Prevent leaking sockets for some operations https://review.openstack.org/156975 | 08:38 |
*** Miouge has joined #openstack-glance | 08:38 | |
*** tshefi has quit IRC | 08:50 | |
*** jistr has joined #openstack-glance | 08:50 | |
*** openstack has joined #openstack-glance | 15:27 | |
*** nlevinki has quit IRC | 15:36 | |
*** rajesht has quit IRC | 16:09 | |
*** annegentle has quit IRC | 16:21 | |
*** annegentle has joined #openstack-glance | 16:22 | |
*** ParsectiX has joined #openstack-glance | 16:28 | |
openstackgerrit | Merged openstack/python-glanceclient: Unify using six.moves.range rename everywhere https://review.openstack.org/159095 | 16:29 |
sigmavirus24 | woah | 16:30 |
sigmavirus24 | the gate merged something? | 16:30 |
sigmavirus24 | that's unpossible | 16:30 |
openstackgerrit | Merged openstack/glance_store: Unify using six.moves.range rename everywhere https://review.openstack.org/159091 | 16:32 |
sigmavirus24 | NO WAY | 16:36 |
sigmavirus24 | 2 merges in less than 5 minutes? | 16:36 |
kragniz | :o | 16:36 |
sigmavirus24 | did someone add eleventy billion new nodes? | 16:36 |
*** rwsu-afk is now known as rwsu | 16:42 | |
*** julim has quit IRC | 16:44 | |
openstackgerrit | Lakshmi N Sampath proposed openstack/glance: Catalog Index Service - Index Update https://review.openstack.org/153544 | 16:44 |
*** julim has joined #openstack-glance | 16:45 | |
*** sgotliv has quit IRC | 16:51 | |
*** groen692 has quit IRC | 16:56 | |
*** sgotliv has joined #openstack-glance | 16:58 | |
openstackgerrit | Merged openstack/python-glanceclient: Show error on trying to upload to non-queued image https://review.openstack.org/136520 | 17:05 |
kragniz | so much merged! | 17:05 |
*** pkoniszewski has joined #openstack-glance | 17:05 | |
*** ericpeterson has quit IRC | 17:06 | |
sigmavirus24 | How is our stuff getting through? | 17:06 |
sigmavirus24 | wtf | 17:06 |
kragniz | sigmavirus24: don't question it | 17:06 |
* sigmavirus24 looks at zuul | 17:07 | |
sigmavirus24 | looks like in-use nodes is finally approaching normal levels ish | 17:08 |
sigmavirus24 | FINALLY | 17:08 |
sigmavirus24 | and jobs waiting is only slightly less than total jobs at the moment | 17:08 |
sigmavirus24 | which is around 4k jbos | 17:08 |
sigmavirus24 | *jobs | 17:08 |
sigmavirus24 | wooooooo | 17:08 |
sigmavirus24 | At least gerrit events have plummeted recently | 17:08 |
*** jistr has quit IRC | 17:13 | |
*** pkoniszewski has quit IRC | 17:16 | |
*** nellysmitt has quit IRC | 17:18 | |
*** ericpeterson has joined #openstack-glance | 17:24 | |
*** sgotliv has quit IRC | 17:27 | |
*** sgotliv has joined #openstack-glance | 17:27 | |
*** ericpeterson has quit IRC | 17:30 | |
*** ericpeterson has joined #openstack-glance | 17:30 | |
openstackgerrit | Louis Taylor proposed openstack/python-glanceclient: Add release notes for 0.16.1 https://review.openstack.org/161338 | 17:37 |
kragniz | sigmavirus24: check the urllib3 line in that? ^ | 17:37 |
sigmavirus24 | kragniz: it more works around the differences that occur when urllib3 is vendored versus when it isn't | 17:38 |
sigmavirus24 | so that it's always consistent | 17:38 |
sigmavirus24 | it also avoids the problem where urllib3 is vendored but also installed globally | 17:39 |
sigmavirus24 | which was the case in the bug | 17:39 |
sigmavirus24 | the person has both requests.packages.urllib3 and urllib3 | 17:39 |
sigmavirus24 | and the latter was chosen | 17:39 |
kragniz | what's a better line? | 17:39 |
sigmavirus24 | we've done a lot of work in the last month/month-and-a-half to patch over that stuff with wallpaper | 17:40 |
kragniz | (I normally don't add internal stuff to release notes, but people seemed to care about this one) | 17:40 |
sigmavirus24 | kragniz: I would say "More reliably register connection pools in cases where urllib3 is both vendored and installed system-wide" | 17:40 |
kragniz | I can just remove it if you don't think it's actually important to end users | 17:41 |
kragniz | and packagers | 17:41 |
sigmavirus24 | kragniz: it is important | 17:41 |
sigmavirus24 | Especially to junhongl | 17:41 |
sigmavirus24 | kragniz: it's going to piss of the debian packager | 17:41 |
kragniz | that's what I thought :P | 17:41 |
sigmavirus24 | (but not the one that packages requests) | 17:41 |
sigmavirus24 | (the one that packages requests loves me) | 17:41 |
sigmavirus24 | so does the red hat requests package manager | 17:41 |
openstackgerrit | Louis Taylor proposed openstack/python-glanceclient: Add release notes for 0.16.1 https://review.openstack.org/161338 | 17:42 |
kragniz | updated to your message, thanks! | 17:42 |
sigmavirus24 | kragniz: can you put my +1 on that for me? | 17:42 |
kragniz | sure, send over your gerrit password! | 17:43 |
kragniz | nikhil_k: I added release notes to the todo list on trello | 17:45 |
nikhil_k | thanks | 17:45 |
nikhil_k | kragniz: still looking to see if we can get this merged https://review.openstack.org/#/c/156481/1 | 17:46 |
kragniz | nikhil_k: using choices there would be neater | 17:48 |
kragniz | nikhil_k: since we have a +2 on that from flaper87, we could just merge it and add a follow-up commit | 17:50 |
openstackgerrit | Gorka Eguileor proposed openstack/glance_store: Only warn on duplicate path on fs backend https://review.openstack.org/157013 | 17:50 |
*** pdb has quit IRC | 17:50 | |
*** stpierre has joined #openstack-glance | 17:51 | |
sigmavirus24 | kragniz: true, that could be targetted to 0.16.2/0.17.0 | 17:52 |
nikhil_k | umm, let's skip it rather and have it all in 17.0 | 17:53 |
kragniz | sure, that works also | 17:54 |
kragniz | I retargeted the bug | 17:54 |
sigmavirus24 | kragniz:++ | 17:55 |
kragniz | nikhil_k: nothing else to be merged for 0.16.1? | 17:59 |
nikhil_k | doen't look like it | 17:59 |
nikhil_k | kragniz: | 17:59 |
kragniz | cool | 17:59 |
kragniz | (just checking before the release notes merge :P ) | 18:00 |
nikhil_k | :) | 18:01 |
*** markus_z has quit IRC | 18:03 | |
*** annashen has joined #openstack-glance | 18:03 | |
*** rajesht has joined #openstack-glance | 18:05 | |
*** rajesht has quit IRC | 18:10 | |
*** flwang has quit IRC | 18:18 | |
nikhil_k | from the looks, it might be tomorrow when we would be able to cut a release | 18:18 |
kragniz | why? | 18:18 |
kragniz | gatey stuff? | 18:18 |
*** harlowja_away is now known as harlowja_ | 18:19 | |
*** vilobhmm has joined #openstack-glance | 18:24 | |
*** vilobhmm1 has joined #openstack-glance | 18:25 | |
openstackgerrit | Gorka Eguileor proposed openstack/glance_store: Only warn on duplicate path on fs backend https://review.openstack.org/157013 | 18:28 |
*** vilobhmm has quit IRC | 18:29 | |
*** vilobhmm1 has left #openstack-glance | 18:32 | |
nikhil_k | the check on the client hasn't moved in a while | 18:32 |
*** ericpeterson has quit IRC | 18:33 | |
*** flwang1 has quit IRC | 18:35 | |
*** ericpeterson has joined #openstack-glance | 18:44 | |
*** spzala has joined #openstack-glance | 18:47 | |
*** sgotliv has quit IRC | 18:48 | |
*** ericpeterson has quit IRC | 18:58 | |
*** ericpeterson has joined #openstack-glance | 19:15 | |
*** ParsectiX has quit IRC | 19:17 | |
*** ParsectiX has joined #openstack-glance | 19:17 | |
*** aix has quit IRC | 19:24 | |
*** jbernard has left #openstack-glance | 19:25 | |
openstackgerrit | Lakshmi N Sampath proposed openstack/glance: Catalog Index Service - Index Update https://review.openstack.org/153544 | 19:28 |
*** vilobhmm1 has joined #openstack-glance | 19:31 | |
*** sgotliv has joined #openstack-glance | 19:37 | |
*** pkoniszewski has joined #openstack-glance | 19:41 | |
*** r-daneel has joined #openstack-glance | 19:47 | |
*** zz_jgrimm is now known as jgrimm | 19:51 | |
*** EmilienM is now known as EmilienM|afk | 19:56 | |
*** harlowja_ has quit IRC | 19:57 | |
*** devlaps has joined #openstack-glance | 19:58 | |
*** harlowja has joined #openstack-glance | 20:01 | |
openstackgerrit | Mike Fedosin proposed openstack/glance-specs: Glance sorting API specification https://review.openstack.org/155841 | 20:04 |
openstackgerrit | Louis Taylor proposed openstack/python-glanceclient: Fix leaking sockets after v1 list operation https://review.openstack.org/157516 | 20:08 |
*** pkoniszewski has quit IRC | 20:12 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/glance: Updated from global requirements https://review.openstack.org/161386 | 20:15 |
*** annashen has quit IRC | 20:17 | |
*** flwang has joined #openstack-glance | 20:17 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/python-glanceclient: Updated from global requirements https://review.openstack.org/155581 | 20:22 |
*** chlong has joined #openstack-glance | 20:30 | |
kragniz | sigmavirus24: a pair of eyes on https://review.openstack.org/#/c/157516 would be nice - I hopefully didn't do anything too ugly! | 20:34 |
sigmavirus24 | kragniz: looking | 20:37 |
*** annashen has joined #openstack-glance | 20:54 | |
*** ParsectiX has quit IRC | 21:02 | |
*** ParsectiX has joined #openstack-glance | 21:02 | |
*** mriedem has joined #openstack-glance | 21:09 | |
mriedem | is anyone aware of a bug or a patch for glance_store due to some of the backends, e.g. s3 and vmware, not being optional at load time for their dependencies? | 21:10 |
*** Longgeek has quit IRC | 21:10 | |
mriedem | e.g. boto is in test-requirements.txt b/c the s3 backend is optional, but when loading the s3 driver via extension points (stevedore, when loading the options from the backends), if you don't have boto in your env you'll fail with an ImportError | 21:10 |
mriedem | flaper87: ^? | 21:11 |
sigmavirus24 | Oh that sounds like a patch I -1'd earlier because I forgot we load extensions | 21:12 |
sigmavirus24 | We should probably turn auto-loading off though | 21:12 |
sigmavirus24 | mriedem: https://review.openstack.org/#/c/160136/ | 21:13 |
sigmavirus24 | There has to be a better way to load options from drivers than https://github.com/openstack/glance_store/blob/c5eb4fc54dd4adb8c52a089c3591dc9d0ef1cc50/glance_store/backend.py#L61 | 21:15 |
mriedem | sigmavirus24: yeah, hmm, that'd be a question for oslo.config i guess | 21:16 |
sigmavirus24 | mriedem: yep. asking in #openstack-oslo | 21:17 |
mriedem | sigmavirus24: so thinking do like the gridfs backend and conditionally import boto and if boto isn't there at load time, raise BadConfigurationError | 21:20 |
mriedem | *BadStoreConfiguration | 21:20 |
mriedem | i see _load_stores handles BadStoreConfiguration and continues, but _loadStore doesn't | 21:21 |
mriedem | *_load_store | 21:21 |
*** ericpete_ has joined #openstack-glance | 21:21 | |
sigmavirus24 | huh | 21:22 |
sigmavirus24 | how does gridfs even work then? =P | 21:22 |
* sigmavirus24 will see if he can figure this out | 21:22 | |
sigmavirus24 | unless BadStoreConfiguration subclasses RuntimeError mriedem | 21:23 |
sigmavirus24 | ;) | 21:23 |
mriedem | it doesn't | 21:23 |
mriedem | i already checked that | 21:23 |
mriedem | https://github.com/openstack/glance_store/blob/master/glance_store/_drivers/gridfs.py#L98 | 21:23 |
mriedem | oh, i know | 21:24 |
mriedem | pymongo isn't in test-requirements.txt, so it's different | 21:24 |
mriedem | and in the gate we have pymongo b/c of ceilometer | 21:24 |
*** ericpeterson has quit IRC | 21:24 | |
mriedem | pymongo isn't listed in either reqs file in glance_store, so that's it's own problem | 21:24 |
mriedem | sigmavirus24: i'm happy to work on cleaning some of this up | 21:25 |
mriedem | not sure how gridfs gets through a tox run though? | 21:26 |
mriedem | https://github.com/openstack/glance_store/blob/master/tests/unit/test_gridfs_store.py#L101 | 21:26 |
mriedem | b/c the tests are skipped if it's not there | 21:26 |
mriedem | brilliant | 21:26 |
sigmavirus24 | >_< | 21:26 |
kragniz | lol | 21:27 |
mriedem | well i'll push a patch to fix the pymongo thing for gridfs | 21:29 |
sigmavirus24 | so mriedem also configure handles the BadStoreConfiguration | 21:29 |
mriedem | yeah https://github.com/openstack/glance_store/blob/master/glance_store/driver.py#L61 | 21:31 |
mriedem | but that's only called after you've loaded the module and hit an ImportError | 21:31 |
mriedem | so doesn't help | 21:31 |
sigmavirus24 | right | 21:33 |
sigmavirus24 | but if we make the import conditional | 21:33 |
sigmavirus24 | it should help us | 21:33 |
mriedem | yeah, definitely | 21:33 |
mriedem | i'm working some things | 21:33 |
sigmavirus24 | mriedem: me too | 21:34 |
sigmavirus24 | heh | 21:34 |
sigmavirus24 | teamwork o/ \o | 21:34 |
mriedem | ok, are you adding the BadStoreConfiguration error handling to backend._load_store? | 21:35 |
sigmavirus24 | No but I can if you aren't | 21:35 |
mriedem | was going to do that and handle gridfs' need for pymongo in test-requirements.txt | 21:35 |
mriedem | i assume you're working on making boto conditional in s3? | 21:35 |
sigmavirus24 | I am | 21:35 |
mriedem | k | 21:35 |
sigmavirus24 | worked | 21:37 |
sigmavirus24 | mriedem: I'm not sure _load_store needs to handle that exception | 21:38 |
sigmavirus24 | I don't see that exception raised anywhere outside of configure_add and one other place (that I don't think will affect _load_opts) | 21:38 |
sigmavirus24 | (Or at least isn't via my experimentation) | 21:39 |
openstackgerrit | Ian Cordasco proposed openstack/glance_store: Make dependency on boto entirely conditional https://review.openstack.org/161428 | 21:39 |
sigmavirus24 | mriedem: is the vmware driver causing issues for you? | 21:40 |
mriedem | sigmavirus24: it would, but i have oslo.vmware in my env | 21:40 |
mriedem | b/c it's not an optional req in nova https://github.com/openstack/nova/blob/master/requirements.txt#L43 | 21:40 |
sigmavirus24 | mriedem: I don't have oslo.vmware in my env (neither oslo_vmware nor oslo.vwmare work) and I can list the opts just fine | 21:41 |
*** EmilienM|afk is now known as EmilienM | 21:43 | |
mriedem | that seems odd | 21:43 |
mriedem | sigmavirus24: it's in your tox though | 21:43 |
mriedem | b/c of test-requirements | 21:43 |
sigmavirus24 | mriedem: I'll paste.openstack.org what I did | 21:44 |
mriedem | what's really weird is i don't even see the gridfs tests in the testr listing, even skipped http://git.openstack.org/cgit/openstack/glance_store/tree/tests/unit/test_gridfs_store.py | 21:45 |
mriedem | http://logs.openstack.org/36/160136/1/check/gate-glance_store-python27/5819969/testr_results.html.gz | 21:45 |
mriedem | oh there it is test_cleanup_when_add_image_exception | 21:46 |
sigmavirus24 | mriedem: http://paste.openstack.org/show/188149/ | 21:46 |
sigmavirus24 | mriedem: might be that gridfs tests can't be imported? | 21:46 |
mriedem | sigmavirus24: the tests are skipped if pymongo isn't imported | 21:46 |
mriedem | and pymongo isn't in test-requirements | 21:46 |
sigmavirus24 | and not in requirements.txt either I suspect? | 21:47 |
mriedem | nope | 21:47 |
mriedem | so i'm adding it | 21:47 |
mriedem | there is one test and it looks like it mocks out pymongo anyway | 21:47 |
mriedem | so should be safe to add, i'll see | 21:47 |
sigmavirus24 | mriedem: lol | 21:49 |
sigmavirus24 | wouldn't it be funny if by adding that dep you break everything? =P | 21:49 |
mriedem | god i hope so | 21:49 |
sigmavirus24 | o_O | 21:52 |
*** dhellmann has quit IRC | 21:52 | |
*** dhellmann has joined #openstack-glance | 21:55 | |
sigmavirus24 | mriedem: anything I can help with? | 21:56 |
*** dhellmann has quit IRC | 21:56 | |
*** dhellmann has joined #openstack-glance | 21:57 | |
mriedem | naw | 21:57 |
mriedem | side tracked with angry internal corporate emails atm | 21:57 |
*** harlowja has quit IRC | 21:58 | |
*** belmoreira has joined #openstack-glance | 21:58 | |
mriedem | sigmavirus24: i'm not well versed in stevedore, but maybe it doesn't blow up when registering opts because invoke_on_load=False? | 22:05 |
mriedem | http://git.openstack.org/cgit/openstack/glance_store/tree/glance_store/backend.py#n61 | 22:05 |
sigmavirus24 | mriedem: probably | 22:06 |
mriedem | yeah...compared to oslo.messaging: https://github.com/openstack/oslo.messaging/blob/master/oslo_messaging/transport.py#L182 | 22:07 |
mriedem | i've seen that explode if you don't have the right version of kombu or something that a project requires | 22:07 |
mriedem | b/c it's actually loading up the kombu backend | 22:07 |
*** annegentle has quit IRC | 22:10 | |
*** annegentle has joined #openstack-glance | 22:11 | |
*** chlong has quit IRC | 22:12 | |
sigmavirus24 | =/ | 22:13 |
*** peristeri has quit IRC | 22:14 | |
*** jamielennox|away is now known as jamielennox | 22:14 | |
*** jgrimm is now known as zz_jgrimm | 22:23 | |
*** thangp has quit IRC | 22:25 | |
openstackgerrit | Matt Riedemann proposed openstack/glance_store: gridfs: add pymongo to test-requirements and update tests https://review.openstack.org/161450 | 22:27 |
mriedem | sigmavirus24: ^ that was too easy | 22:27 |
sigmavirus24 | mriedem: that's a good thing | 22:27 |
sigmavirus24 | mriedem: didn't you create a bug for that issue? | 22:28 |
mriedem | for it not being tested? | 22:28 |
mriedem | no | 22:28 |
sigmavirus24 | h | 22:28 |
sigmavirus24 | let me check | 22:28 |
sigmavirus24 | I think there may be one already | 22:28 |
mriedem | i created one for the boto thing | 22:28 |
sigmavirus24 | oh that was a dupe then | 22:28 |
*** harlowja has joined #openstack-glance | 22:28 | |
mriedem | yup | 22:28 |
mriedem | i duped it to the other guy's | 22:29 |
sigmavirus24 | mriedem: https://bugs.launchpad.net/glance-store/+bug/1428353 mark your change as closing that | 22:29 |
openstack | Launchpad bug 1428353 in glance_store "gridfs tests are always skipped" [Undecided,New] | 22:29 |
openstackgerrit | Matt Riedemann proposed openstack/glance_store: gridfs: add pymongo to test-requirements and update tests https://review.openstack.org/161450 | 22:30 |
mriedem | done | 22:30 |
mriedem | time to run. later. | 22:30 |
*** mriedem is now known as mriedem-away | 22:30 | |
sigmavirus24 | bye mriedem-away thanks | 22:31 |
*** ParsectiX has quit IRC | 22:59 | |
*** ParsectiX has joined #openstack-glance | 23:00 | |
*** stpierre has quit IRC | 23:02 | |
*** annegentle has quit IRC | 23:04 | |
*** vijendar has quit IRC | 23:05 | |
*** hemanth has quit IRC | 23:17 | |
*** annegentle has joined #openstack-glance | 23:25 | |
*** gokrokve has joined #openstack-glance | 23:31 | |
*** annegentle has quit IRC | 23:32 | |
*** gokrokve has quit IRC | 23:32 | |
*** annegentle has joined #openstack-glance | 23:33 | |
openstackgerrit | Flavio Percoco proposed openstack/glance: Glance Image Introspection https://review.openstack.org/156249 | 23:33 |
openstackgerrit | Flavio Percoco proposed openstack/glance: Remove the eventlet executor https://review.openstack.org/159078 | 23:33 |
openstackgerrit | Flavio Percoco proposed openstack/glance: Basic support for image conversion https://review.openstack.org/159129 | 23:33 |
*** chlong has joined #openstack-glance | 23:42 | |
*** annegentle has quit IRC | 23:43 | |
*** annegentle has joined #openstack-glance | 23:43 | |
*** belmoreira has quit IRC | 23:44 | |
*** chlong has quit IRC | 23:46 | |
*** annashen has quit IRC | 23:46 | |
*** chlong has joined #openstack-glance | 23:46 | |
*** annegentle has quit IRC | 23:48 | |
*** EmilienM is now known as EmilienM|afk | 23:56 | |
*** annegentle has joined #openstack-glance | 23:56 | |
*** annegentle has quit IRC | 23:57 | |
*** annegentle has joined #openstack-glance | 23:57 | |
*** annegentle has quit IRC | 23:58 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!