*** diegows has joined #openstack-glance | 00:12 | |
*** boris-42 has joined #openstack-glance | 01:13 | |
*** echevemaster has joined #openstack-glance | 01:31 | |
*** diegows has quit IRC | 02:04 | |
*** vilobhmm has quit IRC | 02:36 | |
*** buzztroll has joined #openstack-glance | 03:02 | |
*** echevemaster has quit IRC | 03:30 | |
*** kapil___ has joined #openstack-glance | 03:40 | |
*** annashen has joined #openstack-glance | 03:47 | |
*** buzztroll has quit IRC | 04:05 | |
*** vilobhmm has joined #openstack-glance | 04:12 | |
*** rwsu-afk has quit IRC | 04:19 | |
*** annashen has quit IRC | 04:22 | |
*** buzztroll has joined #openstack-glance | 04:22 | |
*** annashen has joined #openstack-glance | 04:24 | |
*** annashen has quit IRC | 04:24 | |
*** annashen has joined #openstack-glance | 04:27 | |
*** vilobhmm1 has joined #openstack-glance | 04:28 | |
*** vilobhmm has quit IRC | 04:30 | |
*** annashen has quit IRC | 05:31 | |
*** pcaruana has quit IRC | 05:45 | |
*** krypto has joined #openstack-glance | 06:00 | |
*** bkopilov has quit IRC | 06:06 | |
*** ankit_ag has joined #openstack-glance | 06:08 | |
*** bkopilov has joined #openstack-glance | 06:19 | |
*** buzztroll has quit IRC | 06:36 | |
*** vilobhmm1 has quit IRC | 07:01 | |
*** groen692 has joined #openstack-glance | 07:03 | |
*** belmoreira has joined #openstack-glance | 07:10 | |
*** vilobhmm has joined #openstack-glance | 07:14 | |
*** krykowski has joined #openstack-glance | 07:37 | |
*** vilobhmm1 has joined #openstack-glance | 07:42 | |
*** vilobhmm has quit IRC | 07:44 | |
*** bkopilov has quit IRC | 07:49 | |
*** bkopilov has joined #openstack-glance | 07:49 | |
*** buzztroll has joined #openstack-glance | 08:14 | |
*** buzztroll has quit IRC | 08:14 | |
*** vilobhmm1 has quit IRC | 08:16 | |
*** eglynn has joined #openstack-glance | 08:16 | |
*** sgotliv has joined #openstack-glance | 08:45 | |
*** krypto has quit IRC | 08:46 | |
*** jistr has joined #openstack-glance | 08:55 | |
openstackgerrit | Flavio Percoco proposed openstack/glance: Glance Image Introspection https://review.openstack.org/156249 | 09:31 |
---|---|---|
*** MattMan has joined #openstack-glance | 09:33 | |
openstackgerrit | Flavio Percoco proposed openstack/glance: Glance Image Introspection https://review.openstack.org/156249 | 09:42 |
*** sgotliv has quit IRC | 09:47 | |
*** sgotliv has joined #openstack-glance | 10:12 | |
*** sgotliv has quit IRC | 10:12 | |
*** sgotliv has joined #openstack-glance | 10:12 | |
flaper87 | I'm happy that our image states check have improved a lot | 10:17 |
*** ParsectiX has joined #openstack-glance | 10:21 | |
flaper87 | .... but I gotta admit that I wish it'd be broken right now :P | 10:23 |
kragniz | flaper87: hehe | 10:24 |
flaper87 | kragniz: here's the thing | 10:24 |
flaper87 | The current PS for the introspect task attempts to change the disk_format | 10:25 |
flaper87 | which is not allowed when the image state != queued | 10:25 |
flaper87 | Thing is that in order to introspect the image we need to save it | 10:25 |
flaper87 | (which obviously changes the status to saving) | 10:25 |
flaper87 | anyway, I'll remove that disk_format update for now | 10:25 |
openstackgerrit | Flavio Percoco proposed openstack/glance: Glance Image Introspection https://review.openstack.org/156249 | 10:26 |
kragniz | hmm | 10:26 |
flaper87 | Also, I'm not happy about calling qemu-img but we need it for image conversion anyway | 10:28 |
flaper87 | and it supports multiple formats | 10:28 |
flaper87 | vmdk, qcow2, raw, ovf, ova, etc etc etc | 10:28 |
kragniz | is there any reason not to? | 10:29 |
kragniz | there isn't like a libqemu, is there? | 10:29 |
flaper87 | there's not :( | 10:30 |
flaper87 | I mean, not for python for sure | 10:30 |
kragniz | there's something called libqemu | 10:30 |
flaper87 | It wouldn't be hard to implement it, it's a matter of reading the file headers and parsing them | 10:30 |
kragniz | but I don't know what is does :P | 10:30 |
flaper87 | but again, we need qemu-img anyway | 10:31 |
flaper87 | so it's probably not worth it | 10:31 |
kragniz | yeah, I guess so | 10:31 |
flaper87 | now I have another problem | 10:32 |
openstackgerrit | Abhishek Talwar proposed openstack/python-glanceclient: Wrong help for glance image-update https://review.openstack.org/157347 | 10:32 |
flaper87 | (pfff and psichologists think *they* are problem solvers) | 10:32 |
*** sgotliv has quit IRC | 10:34 | |
*** sgotliv has joined #openstack-glance | 10:49 | |
*** krykowski has quit IRC | 11:00 | |
*** krykowski has joined #openstack-glance | 11:00 | |
*** jaypipes has joined #openstack-glance | 11:05 | |
kragniz | flaper87: would you be okay if https://review.openstack.org/#/c/140336/ doesn't make it into the next client release? | 11:08 |
*** sgotliv has quit IRC | 11:09 | |
*** aix has joined #openstack-glance | 11:28 | |
*** nellysmitt has joined #openstack-glance | 11:29 | |
*** diegows has joined #openstack-glance | 11:36 | |
flaper87 | kragniz: when are we planning to release the client? | 11:37 |
flaper87 | I'd really like to have it in | 11:37 |
kragniz | flaper87: today, ideally | 11:37 |
flaper87 | but I must admit I haven't written down answer's to nikhil_k's questions | 11:37 |
flaper87 | kragniz: then there's not much I can do | 11:37 |
flaper87 | :( | 11:37 |
kragniz | :( | 11:38 |
flaper87 | it's a shame, though. | 11:38 |
flaper87 | I think that patch was blocked under a wrong perspective | 11:38 |
kragniz | this version of the client was supposed to be released more than a month ago, though :P | 11:39 |
flaper87 | (don't worry, I've said that to jokke__ :P) | 11:39 |
flaper87 | kragniz: yeah, that's fine, I guess. | 11:39 |
kragniz | yeah, I think the patch is okay | 11:39 |
kragniz | okay! | 11:39 |
kragniz | flaper87: could you +2 this? https://review.openstack.org/#/c/122749/ | 11:42 |
kragniz | ...I mean review it | 11:42 |
kragniz | :P | 11:43 |
kragniz | sigmavirus24_awa: when you're around, what's your current stance on https://bugs.launchpad.net/python-glanceclient/+bug/1398838? | 11:47 |
openstack | Launchpad bug 1398838 in python-glanceclient "Errors should not print json" [Medium,In progress] - Assigned to David Wilde (david-wilde-rackspace) | 11:47 |
kragniz | sigmavirus24_awa: you said in the bug report it would be better fixed in glance, but also +1ed the glanceclient review | 11:47 |
flaper87 | kragniz: LOL | 11:56 |
flaper87 | kragniz: +2 | 11:57 |
kragniz | flaper87: thanks! | 11:58 |
kragniz | now need to hunt someone else down... | 11:58 |
*** ihrachyshka has joined #openstack-glance | 12:03 | |
*** sgotliv has joined #openstack-glance | 12:18 | |
*** sgotliv has quit IRC | 12:18 | |
*** sgotliv has joined #openstack-glance | 12:19 | |
*** krykowski has quit IRC | 12:40 | |
*** zigo has quit IRC | 12:52 | |
*** diegows has quit IRC | 12:53 | |
*** zigo has joined #openstack-glance | 12:56 | |
openstackgerrit | Flavio Percoco proposed openstack/glance: Glance Image Introspection https://review.openstack.org/156249 | 13:01 |
*** hollandais has quit IRC | 13:06 | |
*** hollandais has joined #openstack-glance | 13:08 | |
*** krykowski has joined #openstack-glance | 13:08 | |
*** ParsectiX has quit IRC | 13:10 | |
openstackgerrit | Flavio Percoco proposed openstack/glance: Glance Image Introspection https://review.openstack.org/156249 | 13:10 |
flaper87 | I'll get it right, I promisse. I'll eventually will | 13:10 |
flaper87 | :D | 13:10 |
kragniz | hehe | 13:11 |
*** pkoniszewski has joined #openstack-glance | 13:19 | |
*** eglynn has quit IRC | 13:42 | |
*** sgotliv has quit IRC | 13:43 | |
*** sgotliv has joined #openstack-glance | 13:43 | |
*** eglynn has joined #openstack-glance | 13:53 | |
*** eglynn has quit IRC | 14:01 | |
*** krykowski_ has joined #openstack-glance | 14:01 | |
*** krykowski has quit IRC | 14:02 | |
*** ankit_ag has quit IRC | 14:08 | |
number80 | Is upcoming glance_store 0.1.11 compatible with juno glance ? It has some interesting fixes for VMWare stores | 14:11 |
*** mjturek1 has joined #openstack-glance | 14:12 | |
*** diegows has joined #openstack-glance | 14:12 | |
number80 | From basic testing, it works but my testing is not that extensive :) | 14:12 |
*** eglynn has joined #openstack-glance | 14:13 | |
*** Guest28285 is now known as mgagne | 14:13 | |
*** mgagne has joined #openstack-glance | 14:13 | |
*** krykowski_ has quit IRC | 14:14 | |
kragniz | number80: it should be | 14:14 |
number80 | kragniz: thanks sir ! | 14:14 |
kragniz | number80: if it isn't, tell us :P | 14:15 |
*** peristeri has joined #openstack-glance | 14:30 | |
*** nlevinki has joined #openstack-glance | 14:38 | |
*** thangp has joined #openstack-glance | 14:47 | |
*** alok_ has joined #openstack-glance | 15:03 | |
alok_ | hi | 15:03 |
alok_ | getting error http://paste.openstack.org/show/180578/ while doing /usr/local/bin/glance-manage db_sync | 15:04 |
alok_ | any help please ? | 15:04 |
*** esheffield has joined #openstack-glance | 15:08 | |
*** pkoniszewski has quit IRC | 15:13 | |
*** nlevinki has quit IRC | 15:16 | |
*** sigmavirus24_awa is now known as sigmavirus24 | 15:16 | |
sigmavirus24 | kragniz: I think not allowing the client to print junk to the user is good | 15:17 |
sigmavirus24 | I also think not having glance return junk to anyone is good | 15:17 |
sigmavirus24 | kragniz: note "I'm pretty sure this should also be fixed on glance's end." see the usage of "also" (implying it should be fixed in both places =P) | 15:18 |
kragniz | sigmavirus24: I missed the also, sorry :P | 15:18 |
sigmavirus24 | No worries | 15:19 |
kragniz | I just wasn't sure which you liked more | 15:19 |
sigmavirus24 | I like 'em equally | 15:22 |
*** alok_ has quit IRC | 15:28 | |
openstackgerrit | Kamil Rykowski proposed openstack/python-glanceclient: Catalog Index Service - Client https://review.openstack.org/146074 | 15:29 |
*** nlevinki has joined #openstack-glance | 15:32 | |
*** zigo_ has joined #openstack-glance | 15:35 | |
*** nlevinki has quit IRC | 15:42 | |
*** aix has quit IRC | 15:47 | |
openstackgerrit | Merged openstack/python-glanceclient: Reduce the set of supported client SSL ciphers https://review.openstack.org/122749 | 16:06 |
kragniz | nikhil_k, flaper87: could people with +2 powers send some love to these patches for the client release? https://review.openstack.org/#/c/136520/ https://review.openstack.org/#/c/148387/ https://review.openstack.org/#/c/140151/ | 16:14 |
kragniz | (last three) | 16:14 |
* nikhil_k needs a few mins | 16:15 | |
kragniz | nikhil_k: no rush! | 16:16 |
*** belmoreira has quit IRC | 16:17 | |
*** devlaps has joined #openstack-glance | 16:21 | |
*** spzala has joined #openstack-glance | 16:28 | |
*** cpallares has joined #openstack-glance | 16:29 | |
*** devlaps has quit IRC | 16:42 | |
*** buzztroll has joined #openstack-glance | 16:44 | |
*** devlaps has joined #openstack-glance | 16:48 | |
*** sgotliv has quit IRC | 16:50 | |
*** pdb has joined #openstack-glance | 16:59 | |
*** rwsu has joined #openstack-glance | 17:05 | |
*** groen692 has quit IRC | 17:11 | |
nikhil_k | flaper87: https://review.openstack.org/#/c/157067/ | 17:18 |
nikhil_k | zhiyan: flwang ^ | 17:18 |
*** ihrachyshka has quit IRC | 17:19 | |
*** bkopilov has quit IRC | 17:26 | |
*** jistr has quit IRC | 17:29 | |
*** bkopilov has joined #openstack-glance | 17:41 | |
*** zul has quit IRC | 17:51 | |
*** zul has joined #openstack-glance | 17:53 | |
openstackgerrit | Stuart McLaren proposed openstack/glance: Unbreak python-swiftclient gate https://review.openstack.org/158377 | 17:53 |
*** pdb has quit IRC | 17:55 | |
*** mclaren has joined #openstack-glance | 17:57 | |
mclaren | flaper87: ping | 17:58 |
*** annashen has joined #openstack-glance | 18:00 | |
*** Guest52553 is now known as hemanthm | 18:01 | |
*** flwang1 has joined #openstack-glance | 18:07 | |
*** david-lyle_afk is now known as david-lyle | 18:09 | |
*** eglynn has quit IRC | 18:13 | |
*** zul has quit IRC | 18:25 | |
*** zul has joined #openstack-glance | 18:25 | |
*** vilobhmm has joined #openstack-glance | 18:27 | |
*** vilobhmm has quit IRC | 18:29 | |
*** mclaren has quit IRC | 18:30 | |
*** ericpeterson has joined #openstack-glance | 18:30 | |
*** vilobhmm has joined #openstack-glance | 18:31 | |
*** vilobhmm1 has joined #openstack-glance | 18:32 | |
*** vilobhmm_ has joined #openstack-glance | 18:32 | |
*** harlowja has joined #openstack-glance | 18:33 | |
*** vilobhmm has quit IRC | 18:35 | |
*** vilobhmm_ is now known as vilobhmm | 18:35 | |
*** zul has quit IRC | 18:42 | |
*** zul has joined #openstack-glance | 18:44 | |
*** flwang1 has quit IRC | 18:51 | |
openstackgerrit | Steve McLellan proposed openstack/glance: WIP - Functional tests for catalog index service https://review.openstack.org/157209 | 18:53 |
openstackgerrit | Merged openstack/python-glanceclient: Fixed CLI help for bash-completion https://review.openstack.org/151065 | 19:02 |
*** zul has quit IRC | 19:04 | |
*** zul has joined #openstack-glance | 19:04 | |
*** zul has quit IRC | 19:11 | |
*** zul has joined #openstack-glance | 19:11 | |
*** eglynn has joined #openstack-glance | 19:15 | |
*** sgotliv has joined #openstack-glance | 19:30 | |
*** GB21 has joined #openstack-glance | 19:38 | |
*** zul has quit IRC | 19:48 | |
*** openstackgerrit has quit IRC | 19:51 | |
*** openstackgerrit has joined #openstack-glance | 19:52 | |
nikhil_k | sabari: hi | 19:55 |
sabari | Hi nikhil_k | 19:55 |
nikhil_k | sabari: I was curious about your intent to have this https://review.openstack.org/#/c/148426/ in kilo | 19:56 |
nikhil_k | sabari: the spec can be approved however, the code needs to be ready to merge it in kilo | 19:56 |
sabari | I was just thinking the spec has to be approved first :) | 19:57 |
sabari | I can quickly rebase and put it back for reviews today. | 19:57 |
sabari | and also make sure it sticks to the specs. | 19:58 |
sabari | nikhil_k: thanks for pinging. | 20:00 |
*** zul has joined #openstack-glance | 20:01 | |
nikhil_k | sabari: awesome, thanks. I'm not approving specs before hand as we may have a lot of code sitting for review and may not make into kilo. So, trying to get a few things at a time into master | 20:06 |
nikhil_k | hope that helps | 20:06 |
openstackgerrit | OpenStack Proposal Bot proposed openstack/python-glanceclient: Updated from global requirements https://review.openstack.org/155581 | 20:09 |
flwang | any HP guys around? | 20:19 |
kragniz | flwang: sort of | 20:19 |
flwang | kragniz: awesome :) | 20:20 |
flwang | kragniz: do you guys update the image of HP public cloud frequently? | 20:21 |
*** flwang1 has joined #openstack-glance | 20:21 | |
kragniz | flwang: I'm not involved with it, but I think fairly frequently | 20:23 |
*** eglynn has quit IRC | 20:23 | |
flwang | kragniz: can you help check what's the update interval/period? | 20:23 |
flwang | i mean if it's a regular update | 20:23 |
flwang | you know, glance doesn't support image file/data update, so the image update means creating a new image, as a result, the image id will be a new one | 20:24 |
kragniz | flwang: I can tomorrow | 20:24 |
flwang | kragniz: awesome, thanks a lot, man | 20:24 |
kragniz | actually, emailing stuart is probably your best bet | 20:25 |
flwang | kragniz: cool, I will drop a mail to him | 20:25 |
kragniz | I'll just ask him anyway :P | 20:25 |
flwang | haha, got it | 20:25 |
kragniz | s/I'll/I would have/ | 20:25 |
flwang | I will send a mail to him and cc you :) | 20:26 |
*** harlowja has quit IRC | 20:34 | |
*** harlowja_ has joined #openstack-glance | 20:34 | |
*** cpallares has quit IRC | 20:34 | |
*** annashen has quit IRC | 20:35 | |
*** cpallares has joined #openstack-glance | 20:37 | |
*** GB21 has quit IRC | 20:40 | |
*** zul has quit IRC | 20:40 | |
*** zul has joined #openstack-glance | 20:40 | |
openstackgerrit | Louis Taylor proposed openstack/python-glanceclient: Add release notes for 0.16.0 https://review.openstack.org/157372 | 21:08 |
*** jwang_ has joined #openstack-glance | 21:19 | |
*** jwang has quit IRC | 21:20 | |
*** jwang_ has quit IRC | 21:20 | |
*** jwang has joined #openstack-glance | 21:21 | |
*** vilobhmm2 has joined #openstack-glance | 21:25 | |
*** vilobhmm has quit IRC | 21:25 | |
*** vilobhmm1 has quit IRC | 21:25 | |
*** annashen has joined #openstack-glance | 21:32 | |
*** pkoniszewski has joined #openstack-glance | 21:33 | |
*** annashen has quit IRC | 21:39 | |
*** annashen has joined #openstack-glance | 21:40 | |
*** jwang has quit IRC | 21:48 | |
*** jwang has joined #openstack-glance | 21:55 | |
*** annashen has quit IRC | 21:56 | |
*** annashen has joined #openstack-glance | 21:59 | |
*** ericpete_ has joined #openstack-glance | 22:04 | |
sigmavirus24 | nikhil_k: https://review.openstack.org/#/c/140151/ is really breaking a number of people and has been for months. No chance of squeezing that into 0.16.0? | 22:05 |
sigmavirus24 | /cc kragniz ^ | 22:05 |
*** ericpeterson has quit IRC | 22:07 | |
kragniz | sigmavirus24: I'd like it to be included, but I don't think enough people with +2 power are around to merge it | 22:10 |
kragniz | and we'd rather not have to delay this release again :P | 22:11 |
*** thangp has quit IRC | 22:11 | |
sigmavirus24 | kragniz: a quick follow-on release (e.g., 0.16.1) would be nice | 22:11 |
openstackgerrit | Merged openstack/glance: Handle empty request body with chunked encoding https://review.openstack.org/78134 | 22:11 |
sigmavirus24 | also, I thought we were adding more cores | 22:11 |
nikhil_k | sigmavirus24: yeah, I've put the next release due next week | 22:11 |
sigmavirus24 | okay then | 22:12 |
nikhil_k | sigmavirus24: yes, we are hopefully today email will be sent | 22:12 |
* sigmavirus24 was only kidding about the cores thing =P | 22:14 | |
*** nellysmitt has quit IRC | 22:16 | |
*** nellysmitt has joined #openstack-glance | 22:16 | |
*** nellysmitt has quit IRC | 22:17 | |
*** vilobhmm1 has joined #openstack-glance | 22:18 | |
*** vilobhmm2 has quit IRC | 22:18 | |
kragniz | omg sigmavirus24, you can't just kid about cores | 22:20 |
sigmavirus24 | kragniz: stop trying to make cores happen. they're not going to happen | 22:20 |
cpallares | sigmavirus24: +1 for mean girl reference | 22:22 |
sigmavirus24 | cpallares: this is fetch all over again | 22:22 |
sigmavirus24 | That's also the only reference I know from that movie | 22:22 |
kragniz | omg sigmavirus24, you can't just make mean girl references | 22:24 |
cpallares | sigmavirus24: You go glen coco. | 22:24 |
sigmavirus24 | cpallares: how did you know we're twins? | 22:24 |
*** aix has joined #openstack-glance | 22:26 | |
*** harlowja_ has quit IRC | 22:29 | |
*** harlowja has joined #openstack-glance | 22:30 | |
kragniz | also, no pycon for me, sorry | 22:33 |
* sigmavirus24 throws a tantrum | 22:33 | |
* kragniz thows a party | 22:34 | |
*** jwang_ has joined #openstack-glance | 22:34 | |
cpallares | kragniz: :( | 22:36 |
cpallares | kragniz: Bad timing? | 22:36 |
sigmavirus24 | cpallares: kragniz just doesn't love us the same amount that we love him =P | 22:38 |
*** jwang has quit IRC | 22:38 | |
cpallares | kragniz: Yes, I can see that now. | 22:40 |
cpallares | sigmavirus24: ^ | 22:40 |
sigmavirus24 | heh | 22:40 |
cpallares | sigmavirus24: We should have lots of fun without him. | 22:40 |
sigmavirus24 | and then tell him all about it | 22:40 |
cpallares | exactly | 22:40 |
sigmavirus24 | we'll take plenty of selfies in front of cool people like flaper87 and brag | 22:41 |
cpallares | sigmavirus24: And use hashtags like #glancebesties | 22:41 |
cpallares | #nokragniznoproblem | 22:41 |
flaper87 | :D | 22:42 |
sigmavirus24 | a wild core appears who can help out with that glanceclient patch =P | 22:42 |
sigmavirus24 | btw, requests 2.5.2 was just released everyone | 22:43 |
cpallares | hahaha | 22:43 |
* sigmavirus24 raises a slice of toast to more timely releases of requests | 22:43 | |
flaper87 | sigmavirus24: w000t | 22:43 |
cpallares | sigmavirus24: Quick throw a pokeball make sure he doesn't get away. | 22:43 |
* sigmavirus24 uses pester. it isn't very effective | 22:43 | |
sigmavirus24 | flake8 2.4.0 should be out soonish | 22:44 |
sigmavirus24 | switching flake8 to git was probably the 2nd best decision I've made as maintainer of that project | 22:44 |
cpallares | sigmavirus24: What did you use before? | 22:46 |
sigmavirus24 | the project was created using mercurial | 22:46 |
sigmavirus24 | I maintained it in mercurial for 3 years | 22:46 |
sigmavirus24 | And recently switched it over to git | 22:46 |
sigmavirus24 | Mostly because I was able to rally people and there's a F/OSS hosting solution that I don't have to administer so everyone was happy | 22:47 |
sigmavirus24 | -BitBucket +GitLab +git | 22:47 |
sigmavirus24 | Also got really good CI set up for it sponsored by Rackspace | 22:47 |
cpallares | Nice! | 22:47 |
sigmavirus24 | Yep | 22:47 |
sigmavirus24 | Integration with GitLab still seems a bit odd but it works well enough | 22:48 |
sigmavirus24 | Just need to increase test coverage =P | 22:48 |
*** harlowja has quit IRC | 23:04 | |
*** rwsu is now known as rwsu-afk | 23:04 | |
openstackgerrit | GB21 proposed openstack/glance: asserts used in cache.py The asserts in the snippet below check at #2 to see if the HTTP method match the HTTP methods actually specified in the patterns at #1. https://review.openstack.org/158480 | 23:06 |
*** GB21 has joined #openstack-glance | 23:08 | |
openstackgerrit | Louis Taylor proposed openstack/python-glanceclient: Add release notes for 0.16.0 https://review.openstack.org/157372 | 23:09 |
*** devlaps has quit IRC | 23:14 | |
*** devlaps has joined #openstack-glance | 23:14 | |
*** harlowja has joined #openstack-glance | 23:16 | |
openstackgerrit | GB21 proposed openstack/glance: asserts used in cache.py The assert statement is replaced by if not condition: raise AssertionError. As stated in the Python documentation assert statements will not be evaluated when the Python code is compiled with optimization flags. This means that th https://review.openstack.org/158480 | 23:16 |
*** pkoniszewski has quit IRC | 23:28 | |
*** peristeri has quit IRC | 23:34 | |
*** krtaylor has quit IRC | 23:35 | |
openstackgerrit | GB21 proposed openstack/glance: "Fixes insecure use of asserts in cache.py" The assert statement is replaced by if not condition: raise AssertionError. As stated in the Python documentation assert statements will not be evaluated when the Python code is compiled with optimization flags https://review.openstack.org/158480 | 23:36 |
*** mfisch has quit IRC | 23:36 | |
*** GB21 has quit IRC | 23:37 | |
flaper87 | hey guys, I'd really appreciate to get your thoughts on the discussion happening here: https://review.openstack.org/#/c/156249/8/glance/async/flows/base_import.py,cm | 23:39 |
flaper87 | nikhil_k: kragniz sigmavirus24 cpallares ^ | 23:39 |
* sigmavirus24 is looking at flaper87's link | 23:41 | |
*** krtaylor has joined #openstack-glance | 23:47 | |
sigmavirus24 | flaper87: honestly curious, why do you think a spec is a bad idea? i had frankly assumed one would be coming anyway | 23:52 |
*** MasterPiece has joined #openstack-glance | 23:53 | |
flaper87 | sigmavirus24: not generally, just in this case. We're almost in K-3, adding a spec just means dedicating more time to that and this is something that has been discussed in several meetings, summits etc | 23:53 |
flaper87 | I mean, don't get me wrong. I'm not fully opposed I just really don't think it's necessary | 23:54 |
flaper87 | for this specific thing that we've already agreed on (tasks landed already) | 23:54 |
*** mfisch has joined #openstack-glance | 23:54 | |
flaper87 | I'm just doing refactor and working on the introspection and conversion tasks | 23:54 |
sigmavirus24 | I get that | 23:54 |
*** mfisch has quit IRC | 23:54 | |
*** mfisch has joined #openstack-glance | 23:54 | |
flaper87 | if one is needed, I'd probably ask for help | 23:55 |
sigmavirus24 | The thing is that personally I see specs as the culmination of your email thread | 23:55 |
sigmavirus24 | flaper87: I know 0 about it but I'd be willing to help if there's good documentation to describe it | 23:55 |
flaper87 | which thread, the "lets keep things opened" ? | 23:55 |
* sigmavirus24 hasn't been to a summit yet and hasn't seen the discussions | 23:55 | |
sigmavirus24 | flaper87: yep | 23:55 |
sigmavirus24 | things that happen at summits tend to never get documented very well | 23:55 |
flaper87 | sigmavirus24: yeah, you're totally right there. FWIW, the discussion around this work is not "closed" | 23:56 |
sigmavirus24 | meeting decisions can be easy to find but with so many meetings its hard to find the right one and with this channel mostly unlogged, it's hard for someone like me to get all the context | 23:56 |
flaper87 | as in, it'll be done like that, etc, etc. | 23:56 |
sigmavirus24 | flaper87: oh no I didn't mean to imply the discussion around this was "closed" | 23:56 |
flaper87 | it's just goes to what I said before, available time | 23:56 |
sigmavirus24 | Just that a spec is the ultimate way of keeping the decision itself open | 23:56 |
flaper87 | it* | 23:56 |
sigmavirus24 | right | 23:56 |
flaper87 | sigmavirus24: yeah, you're totally right there | 23:56 |
sigmavirus24 | If you can send me references and stuff I'll write it | 23:56 |
flaper87 | if you're willing to help, I'm willing to guide you | 23:57 |
flaper87 | mind commenting on the review saying that you'd be happy to take the spec over ? | 23:57 |
sigmavirus24 | I see specs as 2 fold: 1. a place for improving the suggested feature. 2 (more importantly) documenting the new stuff in a more formal way | 23:57 |
sigmavirus24 | flaper87: will do | 23:57 |
flaper87 | sigmavirus24: yeah, I fully agree with you | 23:57 |
flaper87 | sigmavirus24: if you want, since jokke_ is not here, mention that we talked this on IRC and we'll work together on the spec... etc etc | 23:58 |
sigmavirus24 | eh too late =P | 23:58 |
flaper87 | hehe, np | 23:58 |
flaper87 | :) | 23:58 |
sigmavirus24 | Already posted my comment and I have to run. But I'll be back if you're still going to be up | 23:58 |
flaper87 | probably not but we can chat tomorrow | 23:59 |
flaper87 | :) | 23:59 |
flaper87 | sigmavirus24: thanks btw | 23:59 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!