Monday, 2015-01-19

*** takedakn has joined #openstack-glance00:12
*** sabari is now known as zz_sabari00:33
*** takedakn has quit IRC00:45
*** buzztroll has joined #openstack-glance01:24
*** buzztroll has quit IRC01:29
*** julim has joined #openstack-glance01:35
*** julim has quit IRC01:40
*** zz_sabari is now known as sabari01:44
*** spzala has joined #openstack-glance02:00
*** HenryG has joined #openstack-glance02:44
*** TravT has joined #openstack-glance02:54
*** TravT has quit IRC02:58
*** spzala has quit IRC03:15
*** buzztroll has joined #openstack-glance03:23
*** buzztroll has quit IRC03:30
*** slDabbler has joined #openstack-glance04:08
*** TravT has joined #openstack-glance04:10
*** TravT has quit IRC04:14
*** Longgeek has joined #openstack-glance04:15
*** sabari is now known as zz_sabari04:38
*** zz_sabari is now known as sabari05:12
*** TravT has joined #openstack-glance05:26
*** sabari is now known as zz_sabari05:26
*** TravT has quit IRC05:30
*** pcaruana has quit IRC05:32
*** zz_sabari is now known as sabari05:44
openstackgerritOpenStack Proposal Bot proposed openstack/glance: Imported Translations from Transifex  https://review.openstack.org/14676506:04
*** alex_xu has quit IRC06:21
*** bkopilov has joined #openstack-glance06:23
*** diegows has quit IRC06:34
*** TravT has joined #openstack-glance06:42
*** buzztroll has joined #openstack-glance06:42
*** TravT has quit IRC06:46
*** buzztroll has quit IRC06:53
*** buzztroll has joined #openstack-glance06:55
*** groen692 has joined #openstack-glance06:56
*** belmoreira has joined #openstack-glance06:57
*** buzztroll has quit IRC07:04
*** buzztrol_ has joined #openstack-glance07:07
*** chlong has quit IRC07:10
*** sgotliv_ has quit IRC07:16
*** buzztrol_ has quit IRC07:22
*** buzztroll has joined #openstack-glance07:23
*** buzztroll has quit IRC07:28
*** buzztrol_ has joined #openstack-glance07:28
*** tshefi has joined #openstack-glance07:28
*** pkoniszewski has joined #openstack-glance07:28
*** slDabbler has quit IRC07:35
*** pcaruana has joined #openstack-glance07:42
*** Krast has joined #openstack-glance07:47
*** Krast has quit IRC07:47
*** sabari is now known as zz_sabari07:47
*** buzztrol_ has quit IRC07:48
*** buzztroll has joined #openstack-glance07:48
*** zz_sabari is now known as sabari07:50
*** buzztroll has quit IRC07:54
*** markus_z has joined #openstack-glance08:04
*** nlevinki has joined #openstack-glance08:07
junhonglzhiyan: ping08:15
*** markus_z has quit IRC08:19
*** sabari is now known as zz_sabari08:19
*** zz_sabari is now known as sabari08:21
junhonglhi all, i opened a bug https://bugs.launchpad.net/glance/+bug/1408940, which is about the lack of support to https in glance-replicator clis08:21
junhongli read the implementation of glance-replicator08:22
junhongland found that the api call is initiated by httplib.HTTPConnection only without considering the https case08:24
*** markus_z has joined #openstack-glance08:24
junhongli think we can enhance it by adding httplib.HTTPSConnection into it. but i'm hesitating about it because i noticed the implementation of glance-replicator08:25
*** nellysmitt has joined #openstack-glance08:26
junhonglis kind of different from other clis, i don't see other clis like nova, cinder use httplib, so i would like to see any comments from your guys08:27
junhonglabout how to enhance glance-replicator to let it support https08:27
*** TravT has joined #openstack-glance08:30
*** jamielennox is now known as jamielennox|away08:34
*** TravT has quit IRC08:35
*** sgotliv_ has joined #openstack-glance08:44
*** sabari is now known as zz_sabari08:48
*** flwang1 has joined #openstack-glance08:48
*** zz_sabari is now known as sabari08:48
*** krykowski has joined #openstack-glance08:53
*** nlevinki has quit IRC09:04
*** sgotliv_ has quit IRC09:10
*** nlevinki has joined #openstack-glance09:19
*** krykowski has quit IRC09:22
*** pdb has joined #openstack-glance09:23
*** jistr has joined #openstack-glance09:24
*** sgotliv_ has joined #openstack-glance09:27
*** krykowski has joined #openstack-glance09:28
*** sabari is now known as zz_sabari09:42
*** krykowski has quit IRC09:49
*** MattMan has joined #openstack-glance09:54
*** MattMan has left #openstack-glance09:54
*** MattMan has joined #openstack-glance09:55
*** alex_xu has joined #openstack-glance09:58
*** belmoreira has quit IRC10:02
*** groen693 has joined #openstack-glance10:07
*** andrearo1 has joined #openstack-glance10:07
*** andrearosa has quit IRC10:07
*** groen692 has quit IRC10:08
*** nlevinki has quit IRC10:11
*** krykowski has joined #openstack-glance10:14
*** TravT has joined #openstack-glance10:19
*** TravT has quit IRC10:24
*** nlevinki has joined #openstack-glance10:24
*** takedakn has joined #openstack-glance10:28
*** nellysmi_ has joined #openstack-glance10:34
*** nellysmitt has quit IRC10:35
*** andrearo1 is now known as andrearosa10:37
*** takedakn has quit IRC10:38
*** sgotliv_ has quit IRC10:38
*** sgotliv_ has joined #openstack-glance10:42
*** aix has joined #openstack-glance10:43
openstackgerritPawel Koniszewski proposed openstack/glance: Add operators to provide multivalue support  https://review.openstack.org/14821310:44
*** sgotliv_ has quit IRC10:47
*** sgotliv_ has joined #openstack-glance10:59
openstackgerritFei Long Wang proposed openstack/glance: Ensure digital signatures are a minimum of SHA2  https://review.openstack.org/8017811:03
*** pkoniszewski has quit IRC11:13
*** flwang1 has quit IRC11:16
*** nellysmitt has joined #openstack-glance11:32
*** nellysmi_ has quit IRC11:36
openstackgerritInessa Vasilevskaya proposed openstack/glance: Artifacts Domain  https://review.openstack.org/13289811:39
*** krykowski has quit IRC11:43
*** krykowski has joined #openstack-glance11:46
openstackgerritMike Fedosin proposed openstack/glance: Artifacts API  https://review.openstack.org/13662911:47
*** sgotliv_ has quit IRC11:54
*** sgotliv has joined #openstack-glance11:54
openstackgerritLouis Taylor proposed openstack/glance-specs: Improvements to swift store retry behaviour  https://review.openstack.org/14643712:06
*** krykowski has quit IRC12:09
openstackgerritMike Fedosin proposed openstack/glance: Artifacts API  https://review.openstack.org/13662912:10
*** pkoniszewski has joined #openstack-glance12:16
*** belmoreira has joined #openstack-glance12:27
*** belmoreira has quit IRC12:29
*** takedakn has joined #openstack-glance12:37
*** takedakn has quit IRC12:39
*** krykowski has joined #openstack-glance12:56
*** sgotliv has quit IRC12:58
*** takedakn has joined #openstack-glance13:10
*** takedakn has quit IRC13:12
*** takedakn has joined #openstack-glance13:12
openstackgerritInessa Vasilevskaya proposed openstack/glance: Artifacts Domain  https://review.openstack.org/13289813:13
*** takedakn has quit IRC13:13
*** sgotliv has joined #openstack-glance13:13
*** takedakn has joined #openstack-glance13:13
openstackgerritInessa Vasilevskaya proposed openstack/glance: Artifacts API  https://review.openstack.org/13662913:20
*** EmilienM|afk is now known as EmilienM13:22
*** pkoniszewski has quit IRC13:36
*** nellysmitt has quit IRC13:52
*** nellysmitt has joined #openstack-glance13:53
*** TravT has joined #openstack-glance13:57
*** sileht has quit IRC13:58
*** diegows has joined #openstack-glance13:59
*** TravT has quit IRC14:02
*** takedakn has quit IRC14:03
*** julim has joined #openstack-glance14:06
*** julim has quit IRC14:08
*** diegows has quit IRC14:08
*** takedakn has joined #openstack-glance14:11
*** julim has joined #openstack-glance14:11
*** sileht has joined #openstack-glance14:11
*** spzala has joined #openstack-glance14:18
*** spzala has quit IRC14:20
*** sgotliv has quit IRC14:20
*** sgotliv has joined #openstack-glance14:20
*** mjturek has joined #openstack-glance14:22
*** peristeri has joined #openstack-glance14:27
*** sileht has quit IRC14:32
*** krykowski has quit IRC14:36
*** sileht has joined #openstack-glance14:37
*** krykowski has joined #openstack-glance14:48
*** EmilienM is now known as EmilienM|afk14:57
*** pkoniszewski has joined #openstack-glance14:59
*** sigmavirus24_awa is now known as sigmavirus2415:08
sigmavirus24junhongl: if you're still around can you show me the bug?15:13
openstackgerritPawel Koniszewski proposed openstack/glance: Add operators to provide multivalue support  https://review.openstack.org/14821315:15
sigmavirus24nikhil_k_: are you around?15:16
*** esheffield has joined #openstack-glance15:21
ativelkovFolks, any experts on swift store around?15:26
kragnizativelkov: define expert15:27
ativelkovanybody who knows the chunking approach of the swift sotre15:28
nikhil_k_sigmavirus24: o/15:29
nikhil_k_ativelkov: what's the issue?15:29
ativelkovI have some strange behavior with it and cannot understand what's going on15:29
*** krykowski has quit IRC15:30
nikhil_k_hmm, mind elaborating a bit more?15:30
sigmavirus24ativelkov: or providing a link to what you're looking at?15:30
ativelkovmoment. typing... )15:30
ativelkovnikhil_k_: I am creating an image with "copy-from" command. The image is larger then 'swift_store_large_object_size', i.e. the image is stored as multiple swift objects. The sizes of objects in switch does not match the size of the original image. i.e. the data seems corrupt15:31
sigmavirus24nikhil_k_: https://blueprints.launchpad.net/glance/+spec/software-metadefs was submitted Friday and the author targetted it to k-2/kilo which seems to be a stretch since no one's even had the chance to review the spec yet. Might be a good idea to remove the target until it's been discussed some and then we can decide on the milestone/release15:31
sigmavirus24ativelkov: larger or smaller?15:31
ativelkovsigmavirus24: size in swift is smaller. I.e. some data is missing15:32
sigmavirus24hm15:32
*** krykowski has joined #openstack-glance15:33
ativelkovno errors in glance logs till I attempt to download the image. When I do, there is an obvious error of checksum mismatch15:33
ativelkovIssue seems to be reproducible on latest devstack.15:34
ativelkov(and on stable/icehouse as well)15:35
sigmavirus24huh15:35
ativelkovThere is no problem if creating image directly from local file (i.e. no --copy-from param) or if the swift_store_large_object_size is larger then the size of the image15:37
* sigmavirus24 goes to investigate15:37
*** vijendar has joined #openstack-glance15:38
ativelkovsigmavirus24: thanks!15:38
sigmavirus24ativelkov: don't expect much15:38
sigmavirus24I know nothing about this code15:38
sigmavirus24but I'm curious =P15:38
ativelkovSure :) But any help is appreciated15:38
nikhil_k_ativelkov: err, got distracted15:39
nikhil_k_ativelkov: there was a bug which mclaren opened for copy-from not working after grizzly15:39
nikhil_k_lemme check15:39
nikhil_k_hmm, your issue seems different - though here it is https://bugs.launchpad.net/glance/+bug/139890315:40
*** nlevinki has quit IRC15:41
ativelkovyes, this looks different. In my case there are no errors, and the image successfully moves to "active" state15:42
ativelkovbut sizes in swift differs from the expected size15:42
nikhil_k_ativelkov: are you measuring the summation of sizes?15:46
nikhil_k_ativelkov: also, the checksum in glance is a checksum or checksum (etag)15:46
nikhil_k_checksum _of_ checksum15:47
ativelkovnikhil_k_: yes, summation of sizes15:48
ativelkovalso, swift has some special object which is (probably) corresponding to all the chunks15:48
nikhil_k_sigmavirus24: Thanks for raising that one. Will definitely look int this15:49
nikhil_k_seems like a small change, mostly document library of the descriptions15:49
nikhil_k_so might be do-able15:49
nikhil_k_ativelkov: right, it by default falls back to a Dynamic Large Object (DLO)15:50
nikhil_k_it has a file called manifest file stored in swift proxy to locate the chunks across the ecosystem of storage drives15:50
nikhil_k_you'd see it to be an empty 0 bytes file while uploading from glance15:51
ativelkovok, so the size of this object is the same as the sum of all chunks15:51
nikhil_k_ativelkov: btw, does glance give out error while downloading that image?15:51
ativelkovand is different from the image which was passed as the copy-from source15:51
nikhil_k_ativelkov: ah that's a relief15:51
ativelkovnikhil_k_: yes, it does15:51
nikhil_k_hmm15:51
nikhil_k_do you mind sharing the version of swiftclient and glance_store too?15:52
*** tellesnobrega has quit IRC15:52
ativelkovsure15:52
ativelkovone moment15:52
nikhil_k_looking at glance/master there does not seem to be any issue right up front15:52
ativelkovright now python-swiftclient is at 2.2.0, but that's after I've triyed playing with it. Initially it installed most recent version (2.3.1) and it had the same issue15:54
ativelkovglance-store==0.1.1015:54
*** nlevinki has joined #openstack-glance15:55
ativelkovnikhil_k_: some output here: http://paste.openstack.org/show/158899/15:58
ativelkovswift_large_object_size is set to 200 megs15:59
*** sileht has quit IRC16:01
ativelkovseems like it lost 25984 K of data.16:01
ativelkovWhich is a multiple of 16K, where 16K is size of datachunk to be transferred by swiftclient16:02
*** nlevinki has quit IRC16:02
ativelkov1624 chunks lost. May be just a coincidence, of course16:02
*** krykowski has quit IRC16:02
sigmavirus24ativelkov: I thought you said each of the swift chunks added up to the original image size16:03
sigmavirus24did I misunderstand you?16:03
ativelkovsigmavirus24: no, these are different "chunks"16:03
ativelkovthere are "chunks" as different objects used by glance to split large object into smaller ones16:04
ativelkovthese are configured to be 200 Mb16:04
ativelkov(not exactly, because we use some strange constant for 1 Mb here: https://github.com/openstack/glance_store/blob/master/glance_store/_drivers/swift/store.py#L46)16:05
*** tellesnobrega has joined #openstack-glance16:06
sigmavirus24yeah I saw that16:07
ativelkovSo, for object of 536412160 bytes the first object in swift is 204800000, and so is the second16:08
*** EmilienM|afk is now known as EmilienM16:08
ativelkovBut the third one is 100204544, while it should be 126 812 16016:09
*** nlevinki has joined #openstack-glance16:15
openstackgerritLouis Taylor proposed openstack/glance_store: Add option to wait between swift retries  https://review.openstack.org/14180316:15
openstackgerritLouis Taylor proposed openstack/glance_store: Default number of swift download retries to 5  https://review.openstack.org/14590716:15
kragniznikhil_k_: reckon we could start getting some of the oslo namespace patches merged?16:22
kragnizsigmavirus24: I ended up just removing the eventlet stuff from the glance_store swift patch. This means the consumer of glance_store should do the monkey_patching16:25
kragnizsigmavirus24: reckon this is a better way to go?16:25
sigmavirus24kragniz: given that eventlet will monkey-patch the world I think that's okay16:25
* sigmavirus24 isn't 100% certain though16:25
kragnizI'm pretty sure it does, given how python modules work16:26
*** olc has joined #openstack-glance16:26
sigmavirus24also how eventlet works16:26
sigmavirus24I think we just need to check that something does monkey patch the world with eventlet before assuming it will just work16:27
kragnizsigmavirus24: https://github.com/openstack/glance/blob/master/glance/cmd/api.py#L3216:28
kragnizsame for the registry16:28
olchi - sri for crosspost :) Did someone build an image for jessie successfully using build-openstack-debian-image?16:28
* sigmavirus24 didn't olc 16:29
kragnizolc: not I, although I haven't attempted it16:30
*** groen693 has quit IRC16:30
*** sileht has joined #openstack-glance16:33
*** sileht has quit IRC16:33
*** tshefi has quit IRC16:34
*** sileht has joined #openstack-glance16:34
nikhil_k_ativelkov: the upload_utils has a method to check if the checksum back from the store is same as that in the image meta16:34
nikhil_k_ativelkov:  how did your upload happen successfully?16:35
olchmm ok, thanks guys! No inittab is created by default in jessie and build-openstack-debian-image complains about that. Anyway I'll investigate further.16:37
ativelkovnikhil_k_: well, I don't know. May be because the checksum being computed at swift-store is correct, and the problem happens after it is computed?16:39
nikhil_k_ativelkov: yeah, my guess is that something wrong with download; in the case of this particular way of image data upload to your backend storage16:40
nikhil_k_ativelkov: mind cross checking the checksum entity on image with that on swift http://paste.openstack.org/show/158899/ (<- not here)16:40
*** cpallares has joined #openstack-glance16:40
ativelkovnikhil_k_: sorry, didn't understand what do you suggest16:41
nikhil_k_ativelkov: nvm16:43
nikhil_k_though verifying the checkum might give us an indication on16:44
ativelkovWhat is the source of the "checksum" value which is stored in glance?16:44
nikhil_k_whether the issue is in the downloading process or the storage is behaving inconsistently16:44
ativelkovIs it computed when the image is being uploaded?16:45
*** tshefi has joined #openstack-glance16:46
*** TravT has joined #openstack-glance16:47
*** TravT has quit IRC16:51
*** nlevinki has quit IRC16:52
*** tshefi has quit IRC16:55
*** markus_z has quit IRC16:59
*** rwsu has joined #openstack-glance16:59
nikhil_k_ativelkov: a bit distracted this morning. can you please create a bug for this? we may get some more info from other folks17:04
nikhil_k_ativelkov: and yeah, the checksum is set after upload process is complete17:04
ativelkovnikhil_k_: sure, will do in about 30 mins17:05
ativelkovnikhil_k_: the checksum is correct, btw. I mean, when I md5 the original file it has the same value as in Glance17:05
*** spzala has joined #openstack-glance17:05
nikhil_k_however, the weird thing is it's set based on what is recieved back from the add_to_backend method17:05
nikhil_k_ativelkov: ah k17:06
ativelkovso, turns out that the code in glance_store reads all the data from remote source correctly - and computes the sum correctly as well. But something gets lost on the way to swift17:08
sigmavirus24weird17:09
mfedosincan it be because 1 mb in glance store is ONE_MB = 1000 * 1024 https://github.com/openstack/glance_store/blob/master/glance_store/_drivers/swift/store.py#L46 instead of 1024 * 1024?17:09
sigmavirus24mfedosin: yeah we all noticed that17:09
ativelkovmfedosin: no, that is not the reason: I've just changed it to 1024*1024, but the problem is still there17:10
nikhil_k_ativelkov: do you have access to the store logs? might be worth grepping for that X-Trans-Id: tx01a19f7476a541808c9a1-0054bd28e117:10
nikhil_k_or whatever corres. to that upload (this might be your stat id)17:11
ativelkovnikhil_k_: it's a devstack on my VM, so I have any access, But I don't know anything about swift and its logging, don't know where to look17:11
nikhil_k_try starting from swift proxy service17:12
*** pkoniszewski has quit IRC17:13
*** EmilienM is now known as EmilienM|afk17:27
kragnizsigmavirus24: that was a harsh -1 :P17:28
sigmavirus24kragniz: yw17:29
openstackgerritLouis Taylor proposed openstack/glance-specs: Improvements to swift store retry behaviour  https://review.openstack.org/14643717:29
sigmavirus24kragniz: thoughts on https://bugs.launchpad.net/glance/+bug/1412394 ?17:39
sigmavirus24kragniz: it's related to flaper87's work on https://review.openstack.org/#/c/147912/17:39
flaper87what did I do now?17:40
flaper87haven't you learned you shouldn't be summoing ghosts ?17:40
sigmavirus24flaper87: you grievanced me last17:42
*** pdb has quit IRC17:43
*** sigmavirus24 is now known as sigmavirus24_awa17:50
kragnizsigmavirus24_awa: /win 4318:06
kragnizgrr18:06
kragnizsigmavirus24_awa: I don't think he's proposing the schema is made more permissive, just more common parameters are added to it18:07
kragnizwhich I think is fairly sane18:08
*** pcaruana has quit IRC18:08
openstackgerritMike Fedosin proposed openstack/glance: Add the ability to specify the sort dir for each key  https://review.openstack.org/14832618:15
ativelkovnikhil_k_: I've checked the swift-proxy logs.. No errors there, but seems like it does not receive all the needed data. The log contains messages like "Reading chunk..." and "Read 65536 bytes". If we sum all these bytes we will get 100204544 bytes for the last (third) object. That is exactly what is actually stored in swift. But it should be 116981760 instead. Seems like I have 16 megs missing18:16
mfedosinclient support for multiple sort dirs will be added tomorrow with a new syntax18:17
*** TravT has joined #openstack-glance18:19
*** sgotliv has quit IRC18:20
*** TravT has quit IRC18:24
*** EmilienM|afk is now known as EmilienM18:24
*** openstackgerrit has quit IRC18:37
*** openstackgerrit has joined #openstack-glance18:37
*** aix has quit IRC18:41
*** Longgeek has quit IRC18:47
nikhil_k_ativelkov: that's weird. don't want to increase your work, however if you get a chance - might be worth looking at the g-api logs to cross-verify how much data was written18:47
ativelkovnikhil_k_: Doing just this: I am adding some logging to python-swiftclient18:48
ativelkovto log every 64 chunk which it sends18:48
nikhil_k_it will have a log like msg = ("Wrote chunk %(chunk_name)s (%(chunk_id)d/"18:48
ativelkovnikhil_k_: afair these "chunks" are the large ones18:49
nikhil_k_yeah, glance chunks18:49
ativelkov200 Mb or whatever is configured18:49
nikhil_k_yes18:49
ativelkovAnd I am looking for smaller pieaces of lost data18:49
nikhil_k_no, good point to increase logging to swiftclient!18:49
* nikhil_k_ hides18:50
*** nikhil_k_ is now known as nikhil_k18:50
ativelkovwait, no. Iven the logging messages you speak about show the problem18:51
ativelkovEven*18:51
*** sigmavirus24_awa is now known as sigmavirus2418:51
sigmavirus24kragniz: I have no objections but they were in fact complaining that we don't allow os_type which we do... if we're told to18:52
ativelkovWrote chunk faf778a5-84d8-48a4-bf64-963fe977c72d-00001 (1/3) of length 218103808 to Swift returning MD5 of content: 1296786a9aa728616adf4235f6a8d2df add /usr/local/lib/python2.7/dist-packages/glance_store/_drivers/swift/store.py:52518:52
ativelkovthen Wrote chunk faf778a5-84d8-48a4-bf64-963fe977c72d-00002 (2/3) of length 218103808 to Swift returning MD5 of content: 0b95b310aa2c532bbf4b15522f0c2334 add /usr/local/lib/python2.7/dist-packages/glance_store/_drivers/swift/store.py:52518:52
ativelkovWrote chunk faf778a5-84d8-48a4-bf64-963fe977c72d-00003 (3/3) of length 100204544 to Swift returning MD5 of content: 75d857ea350ff04b9836e1deb85f3d7e add /usr/local/lib/python2.7/dist-packages/glance_store/_drivers/swift/store.py:52518:53
sigmavirus24wut18:53
ativelkovIt looks like this is it18:53
ativelkovAccording to config glance chunks should be 209715200 bytes (and actually swift reports of receiving exact this amount). But Glance thinks that it has sent 21810380818:54
sigmavirus24which is the size of the entire image?18:55
kragnizsigmavirus24: I guess, I was reading it as changing the default schema to explicitly list the allowed properties18:57
ativelkovsigmavirus24: entire image is 53641216018:57
sigmavirus24kragniz: with the context from the review it seemed like they were complaining that it wasn't there to begin with because nova sends extra cruft that the service isn't necessarily going to use or expect18:58
nikhil_kativelkov: the chunk addition from the logs seem right and come to 53641216018:58
sigmavirus24because nova's never heard the part about "be conservative in what you send" they only heard "be liberal"18:58
*** TravT has joined #openstack-glance18:58
ativelkovnikhil_k: right18:58
ativelkovnikhil_k: but it does not actually send 218103808 - it should send 20480000018:59
ativelkovas it is configured to create chunks of 200 "megabytes"18:59
ativelkovand it actually sends these 204800000 (according to swift)19:00
sigmavirus24ah that's the ONE_MB problem :(19:00
ativelkovnope19:00
ativelkovif ONE_MB is set to real one mb, glance is supposed to create chunks of 209715200 bytes.19:01
ativelkovBut it still reports the same 218103808 per chunk19:01
sigmavirus24odd19:01
ativelkovyou know what? These 218103808 are exactly 13*16*Mb19:02
ativelkov16 is the READ_CHUNK_SIZE19:02
ativelkovfor the external source19:03
ativelkov(HTTP)19:03
*** bkopilov has quit IRC19:03
*** TravT has quit IRC19:03
ativelkovSo, I now see what is going on19:03
ativelkovGlance copies data from remote source in 16 Mb chunks19:04
ativelkovand "flushes" this data to swift in large 200 "megabyte" chunks19:04
ativelkovbut 200 "megabytes" (and even 200 megabytes if we had a correct constant) is not a multiple of 16Mb19:05
ativelkovso, some (significant) part of the last 16 mb chunk which was read from external source is discarded at the end of each 200 Mb chunk19:06
ativelkovthus, we are loosing data19:06
nikhil_kativelkov: that is an excellent catch19:06
nikhil_kand does show loop hole into not having checksum for that upload chunk process!19:07
nikhil_kchecksum verification :(19:07
ativelkovno, the checksum verifies correctly19:07
ativelkovas it verifies it against datat which was READ, not against which was sent19:07
nikhil_keven after upload to store?19:07
nikhil_kright, yes19:07
nikhil_kso, it does that partially19:08
*** zul has quit IRC19:09
nikhil_kThis may mean we need a common module for store drivers to declare constants19:09
d34dh0r53nikhil_k: sigmavirus24 pointed me in your direction, is there any magic required to get glance client from master to auth against rackspace public cloud?19:09
ativelkovnikhil_k: I'd prefer to decouple constan sizes from each other19:10
ativelkovwe just don't need to loose the last part of previous read chunk19:10
nikhil_kd34dh0r53: hmm, tricky one19:10
nikhil_kd34dh0r53: what error do you see?19:10
d34dh0r53Unauthorized 40119:11
kragnizsigmavirus24: yeah, I don't think it should accept any cruft by default19:11
sigmavirus24kragniz: we can accept it but that doesn't mean it should be in the schema19:11
sigmavirus24Do we use/need os_type even?19:11
nikhil_kativelkov: basically, in future if some store driver adds constants - we will get a inconsistent chunk size ratio19:11
d34dh0r53nikhil_k: don't see any debug or verbose output either19:12
*** zul has joined #openstack-glance19:12
kragnizsigmavirus24: we don't need it to be19:12
kragnizas far as I know19:12
sigmavirus24kragniz: trick question. https://github.com/openstack/glance/blob/5a74548f4649e1cbb8914f4ac5e1d889be54efc4/etc/metadefs/compute-xenapi.json#L13 is the only reference to it19:12
* kragniz not sure19:18
kragnizanyone know if there's a list of the properties used by nova drivers?19:18
kragnizthese seem to be the only 'blessed' properties http://docs.openstack.org/developer/glance/common-image-properties.html19:19
*** zz_sabari is now known as sabari19:20
sigmavirus24nikhil_k: we can probably mark this as rejected right? https://blueprints.launchpad.net/glance/+spec/remove-simple-driver (before the meeting)19:26
*** bkopilov has joined #openstack-glance19:26
nikhil_ksigmavirus24: +119:27
nikhil_ksigmavirus24: can you do that?19:28
sigmavirus24nikhil_k: would you mind doing that then? I dont' have permissions to19:28
sigmavirus24heh19:28
nikhil_kahk19:28
nikhil_k:)19:28
nikhil_k(that's what I meant btw) (confusing IRC <.<)19:28
mfedosinread here ignores the length param https://github.com/openstack/glance_store/blob/master/glance_store/common/utils.py#L127 may be it's our problem?19:29
nikhil_kd34dh0r53: may be this should help https://github.com/emonty/rackspace-auth-openstack19:31
nikhil_kd34dh0r53: Monty was using the CLI a few weeks back and did not have any issues..19:32
sigmavirus24^19:34
*** bkopilov has quit IRC19:34
d34dh0r53nikhil_k: ty sir19:34
nikhil_knp19:34
*** bkopilov has joined #openstack-glance19:36
ativelkovnikhil_k: ok, I've got the root cause of the issue19:40
ativelkovhttps://github.com/openstack/glance/blob/master/glance/common/utils.py#L153 here, the cooperative reader ignores the length we asked for19:41
ativelkovwhich is understandable, as its underlying is not a file or a stream, but just a generator19:42
ativelkovwhich may return only fixed-size chunks19:42
nikhil_kgotcha19:44
nikhil_kativelkov: Though, the issue really is with global constants not being multiples of each other right?19:45
ativelkovno19:45
ativelkovthey don't have to be19:45
nikhil_khmm19:45
ativelkovwe just dontt need to rely on this19:46
nikhil_kimplement a carry over?19:46
ativelkovWe actually do stuff wrong in our ChunkReader19:46
ativelkovwhen the consumer code (swift-client in this case) ask our datat stream for a next chunk, it specifies the size19:46
ativelkovin my case it is 8K per chunk19:47
ativelkovbut we return 6Mb instead, assuming that they will maintain the buffer19:47
ativelkovnot 6Mb, 16Mb19:47
nikhil_kativelkov: the put_object specifies a content length of 200M (by default)19:54
ativelkovnikhil_k: ok, let's put it this way. Look here: https://github.com/openstack/glance_store/blob/master/glance_store/_drivers/swift/store.py#L89419:55
ativelkovwhat value would you expect for i?19:55
nikhil_kativelkov: https://github.com/openstack/glance_store/blob/master/glance_store/_drivers/swift/store.py#L51819:58
nikhil_kchunk_size19:58
ativelkovnikhil_k: no. Read is being called by the code which tries to read from this ChunkReader19:58
ativelkovin our case this is httplib which is called by swiftclient19:59
ativelkovthis is how it looks like: http://paste.openstack.org/show/158958/20:00
ativelkov(line 14)20:00
ativelkovthe lib requests next 8K of data from the stream20:01
ativelkovthis value (8192) gets to the read method of ChunkReader20:01
ativelkovAnd ChunkReader actually ignores this value and returns the amount of data it is configured to read from the remote source20:05
*** sabari is now known as zz_sabari20:05
nikhil_kativelkov: ok, might be best discussing this on a bug.20:07
sigmavirus24nikhil_k +120:08
nikhil_kTrying to co-relate where exactly the 16M factor is coming in :|20:08
nikhil_kSeems like we are dealing with 2 streams20:08
ativelkovnikhil_k: I'll file a bug - and a patchset20:08
nikhil_kone using reading from remote source (store type A) and other dest. (store type B(20:09
nikhil_kif you can please include the flow of things looking correct on download and not on upload and the stream mis-match, it would be really appreciated!20:10
*** flwang1 has joined #openstack-glance20:18
flwangsigmavirus24: ping20:20
sigmavirus24flwang: pong20:20
flwangI'm looking the comment from you on https://review.openstack.org/#/c/80178/12/glance/common/config.py20:20
flwangsigmavirus24: I'm wondering why it deserved a -120:21
sigmavirus24flwang: I'm more concerned with using more secure defaults. So if we're not using a more secure default, I'm -1 until a good reason has been supplied20:22
flwangas for your question in the comment, the reason why i'm using sha1 as the default is because we want to get a smooth upgrade20:22
*** jistr has quit IRC20:23
flwangsigmavirus24: did you see my previous patch sets ?20:23
flwangdid you see the other change in the same patch?20:23
flwangwe use sha1 since it's the hard code value we're using currently20:24
flwangafter discussed with nikhil_k, we believe set sha1 as the default is better for smooth upgrade from the operator/deployer perspective20:24
flwangand we will change it in next release(L)20:25
sigmavirus24flwang: that makes sense. I didn't look at the earlier versions of the patch though20:25
sigmavirus24I left other comments iirc too and kragniz had some comments that were worth addressing20:25
flwangkragniz's -1 is asking change  (Using -> Use)20:26
flwangthat's scaring me :P20:27
sigmavirus24=P20:28
*** sgotliv has joined #openstack-glance20:28
flwangit's ok for me, but I think it will scare the new comer for glance team20:29
openstackgerritFei Long Wang proposed openstack/glance: Ensure digital signatures are a minimum of SHA2  https://review.openstack.org/8017820:33
kragnizflwang: to be fair, I'm being very paranoid about differences between config files and the help text on the cfg options at the moment20:36
kragnizflwang: sorry for the -1 :P20:37
flwangkragniz: no worries :) i'm kidding20:37
flwangbut it would be great if you guys can be nice for those new comer to avoid scaring them :D20:38
*** zz_sabari is now known as sabari20:38
kragnizflwang: of course :)20:39
flwangawesome :)20:39
sigmavirus24flwang: I know why that default of sha1 threw me off20:42
*** spzala_ has joined #openstack-glance20:42
sigmavirus24Your commit message says "Ensure digital signatures are a minimum of SHA2"20:42
sigmavirus24Which is no longer true in the current patchset so I had that in mind while reviewing the rest of it20:43
*** spzala has quit IRC20:43
*** spzala_ is now known as spzala20:43
sigmavirus24flwang: mind updating the commit message to represent reality?20:46
*** sabari is now known as zz_sabari21:04
flwangsigmavirus24: ah, good point21:04
sigmavirus24flwang: I'd -1 you but I don't want new contributors to be afraid of us making them write accurate commit messages =P21:05
flwangthat's true21:06
openstackgerritFei Long Wang proposed openstack/glance: Make digest algorithm configurable  https://review.openstack.org/8017821:31
*** julim has quit IRC21:32
sigmavirus24flwang: ++21:32
flwangsigmavirus24:  cheers, man21:35
cpallaressigmavirus24: That's really nice of you to consider new contributors.21:37
cpallaressigmavirus24: +221:37
*** diegows has joined #openstack-glance21:41
kragnizwe need a glance PR campaign to attract new contributors21:43
kragnizthis should be in the form of a cool logo21:44
* kragniz likes cool logos21:44
sigmavirus24kragniz: should be an illuminati eye21:45
sigmavirus24get it. glance. eye.21:45
sigmavirus24Ooooh. Eye of sauron!21:45
sigmavirus24no wait, that's ceilometer21:45
*** peristeri has quit IRC21:45
kragnizheh21:45
kragnizgetting eyes to fit the openstack branding style is kind of hard21:46
kragnizI should give it a go21:46
sigmavirus24kragniz: use inkscape21:46
cpallaresLOL21:46
kragnizof course21:46
* cpallares likes the eye of sauron21:46
cpallaresI'd be great at marketing.21:46
cpallaresAlthough my freddie kruger idea didn't go so well in Zaqar.21:47
sigmavirus24cpallares: it'd always be able to find the OpenStack O21:47
sigmavirus24lol21:47
kragnizhaha21:47
sigmavirus24One hypervisor to rule them all and in the darkness boot them21:47
cpallaressigmavirus24: You are a marketing genius.21:48
kragniznine rings for the swift nodes under the cloud21:48
sigmavirus24lmao21:48
cpallaresWe don't need the marketing team. We can do this all by ourselves.21:49
cpallareswhich reminds me: http://www.smbc-comics.com/comics/20120501.gif21:50
kragnizcpallares: haha21:50
__hemanthmThere is some good in this cloud, and its worth developing for  :P21:51
sigmavirus24cpallares++21:51
*** __hemanthm is now known as hemanthm21:51
*** nellysmitt has quit IRC22:05
*** TravT has joined #openstack-glance22:33
*** rwsu has quit IRC22:35
*** TravT has quit IRC22:38
*** zz_sabari is now known as sabari22:39
*** echevemaster has joined #openstack-glance22:40
*** sabari is now known as zz_sabari22:40
*** zz_sabari is now known as sabari22:42
*** buzztroll has joined #openstack-glance22:44
*** buzztroll has quit IRC22:54
*** echevemaster has quit IRC22:54
*** bkopilov has quit IRC22:57
*** vijendar has quit IRC23:01
*** vijendar has joined #openstack-glance23:03
kragnizhmm, that didn't really come out right23:05
kragnizhttp://a.pomf.se/ypyetb.png23:05
kragnizdiskuminati!23:06
*** vijendar has quit IRC23:07
*** sabari is now known as zz_sabari23:09
*** chlong has joined #openstack-glance23:11
*** takedakn has quit IRC23:12
cpallareskragniz: haha23:15
cpallaresthat is amazing :)23:15
cpallaresthat could be the A in glAnce :P23:16
sigmavirus24kragniz: that's hilarious23:16
sigmavirus24kragniz: +2 +W23:17
cpallareskragniz: That eye looks a lot like a CD23:17
sigmavirus24cpallares: I think that's the point of kragniz's "diskuminati" comment =P23:19
cpallaressigmavirus24: Ah! Reading the word makes sense. I didn't understand the reference at first glance.23:20
cpallaresNo pun intended.23:21
sigmavirus24uhuh23:21
sigmavirus24sure you didn't23:21
*** jamielennox|away is now known as jamielennox23:21
sigmavirus24(intend the pun)23:21
* cpallares intended the pun23:21
cpallaresjk23:21
kragniz:)23:24
kragnizcpallares: it was supposed to look like a CD!23:24
*** zz_sabari is now known as sabari23:25
*** takedakn has joined #openstack-glance23:34
*** takedakn has quit IRC23:35
*** sabari is now known as zz_sabari23:42
*** zz_sabari is now known as sabari23:43
*** diegows has quit IRC23:45
*** TravT has joined #openstack-glance23:49
*** EmilienM is now known as EmilienM|afk23:52
*** sabari is now known as zz_sabari23:52
*** TravT has quit IRC23:53

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!