| *** ivasilevskaya1 has quit IRC | 00:24 | |
| *** hoangcx has joined #openstack-fwaas | 00:49 | |
| *** yamamoto has joined #openstack-fwaas | 01:51 | |
| *** lnicolas has quit IRC | 01:53 | |
| *** yamamoto has quit IRC | 02:05 | |
| *** yamamoto has joined #openstack-fwaas | 02:24 | |
| *** yamamoto has quit IRC | 02:30 | |
| *** yamamoto has joined #openstack-fwaas | 02:41 | |
| *** yamamoto has quit IRC | 03:18 | |
| *** yamamoto has joined #openstack-fwaas | 03:31 | |
| *** yamamoto has quit IRC | 03:42 | |
| *** yamamoto has joined #openstack-fwaas | 03:47 | |
| *** yamamoto has quit IRC | 03:51 | |
| *** yamamoto has joined #openstack-fwaas | 04:00 | |
| *** vks1 has joined #openstack-fwaas | 04:29 | |
| *** eezhova has joined #openstack-fwaas | 04:40 | |
| *** yamamoto has quit IRC | 05:02 | |
| *** yamamoto has joined #openstack-fwaas | 05:03 | |
| *** yamamoto has quit IRC | 05:08 | |
| *** eezhova has quit IRC | 05:19 | |
| *** yamamoto has joined #openstack-fwaas | 05:39 | |
| *** yamamoto has quit IRC | 05:41 | |
| *** yamamoto has joined #openstack-fwaas | 05:45 | |
| *** yamamoto has quit IRC | 05:48 | |
| *** vks1 has quit IRC | 06:06 | |
| *** annp has joined #openstack-fwaas | 06:22 | |
| *** vks1 has joined #openstack-fwaas | 06:31 | |
| *** yamamoto has joined #openstack-fwaas | 06:49 | |
| *** yamamoto has quit IRC | 06:58 | |
| *** ivasilevskaya has joined #openstack-fwaas | 07:43 | |
| *** eezhova has joined #openstack-fwaas | 08:20 | |
| openstackgerrit | Reedip proposed openstack/neutron-fwaas master: Introduce default firewall groups https://review.openstack.org/425769 | 08:35 |
|---|---|---|
| *** vks1 has quit IRC | 08:41 | |
| *** yushiro has joined #openstack-fwaas | 08:55 | |
| yushiro | ping annp ivasilevskaya | 09:01 |
| *** vks1 has joined #openstack-fwaas | 09:07 | |
| *** yamamoto has joined #openstack-fwaas | 09:29 | |
| *** ivasilevskaya has quit IRC | 09:46 | |
| *** eezhova has quit IRC | 09:52 | |
| openstackgerrit | Reedip proposed openstack/neutron-fwaas master: Introduce default firewall groups https://review.openstack.org/425769 | 10:08 |
| *** ivasilevskaya has joined #openstack-fwaas | 10:27 | |
| openstackgerrit | Reedip proposed openstack/neutron-fwaas master: Add validation for Firewall Rules and Policies https://review.openstack.org/488438 | 10:28 |
| reedip | yushiro : https://review.openstack.org/#/c/488438/ needs a review ... I know its yours, but still ... | 10:28 |
| yushiro | reedip, Hi. Thanks for your update. | 10:29 |
| *** eezhova has joined #openstack-fwaas | 10:29 | |
| yushiro | reedip, sure. | 10:29 |
| reedip | eh no issues :) | 10:29 |
| yushiro | reedip, let me try this patch in devstack. | 10:33 |
| ivasilevskaya | reedip, hi! | 10:33 |
| yushiro | just looked and this patch looks good. | 10:33 |
| ivasilevskaya | reedip, the diff between PS48 and PS51 shows you've added a test. But I can't figure out what it is supposed to test :( | 10:34 |
| reedip | ivasilevskaya : hi ... I didnt address xgerman_ 's issues on the patch . Need to do that | 10:34 |
| *** eezhova_ has joined #openstack-fwaas | 10:34 | |
| ivasilevskaya | reedip: no problem I have sorted out most of them (once I'm done I'll file a PS). Just tell me about a test please. What was the idea and why do you have a try: except there? | 10:35 |
| reedip | ivasilevskaya : Its a simple API test to verify if our functionality actually works or not. The tempest test is a test for the API working. It failing here showcases that anyone who tries to access the "default" fwg would have the lib_exc.Conflict exception | 10:35 |
| reedip | ivasilevskaya : oh you have already addressed the comments?? Didnt know that :) | 10:36 |
| *** eezhova has quit IRC | 10:36 | |
| ivasilevskaya | reedip: I have them in a local commit, not all of them are ready | 10:37 |
| ivasilevskaya | reedip: this test only checks that a (non-admin?) can't create group with name default, right? | 10:39 |
| reedip | Yes | 10:39 |
| reedip | Its just an API related test, to ensure completeness of the feature. Tempest tests are something which are used for sufficiency testing ( not a necessity ) | 10:39 |
| ivasilevskaya | reedip: I know what tempest tests are, I just bother about the name that doesn't relate to the functionality tested | 10:40 |
| ivasilevskaya | reedip: I believe it should be renamed to test_cant_create_group_with_name_default or smth of the kind (I'm bad at naming, sorry) | 10:40 |
| reedip | oh ok :) . So do you want me to change it and bring another patch set ??? :) | 10:42 |
| ivasilevskaya | reedip: I'll change it when I file the PS, so that's fine | 10:44 |
| ivasilevskaya | reedip: just wanted to check that I understood the idea. Though if you are planning to add some more testcases (update default group, delete default group by admin\non-admin) - you can do it yourself | 10:45 |
| annp | yushiro, ping | 10:48 |
| annp | yushiro, pong | 10:49 |
| openstackgerrit | Nguyen Phuong An proposed openstack/neutron-fwaas master: FWaaS v2 extension for L2 agent https://review.openstack.org/323971 | 10:50 |
| openstackgerrit | Nguyen Phuong An proposed openstack/neutron-fwaas master: OVS based l2 Firewall driver for FWaaS v2 https://review.openstack.org/447251 | 10:50 |
| annp | yushiro, ivasilevskaya, Could you take a look https://review.openstack.org/#/c/323971/ and https://review.openstack.org/#/c/447251/37. It already for reviewing and testing. thanks in advance. | 10:54 |
| *** annp has quit IRC | 10:56 | |
| *** vks1 has quit IRC | 11:03 | |
| *** yamamoto has quit IRC | 11:03 | |
| *** vks1 has joined #openstack-fwaas | 11:15 | |
| ivasilevskaya | annp: I noticed some tests were removed (I look at diff PS60-PS64). Was it update from master? | 11:23 |
| ivasilevskaya | annp: I'm talking about l2 ext patch | 11:23 |
| ivasilevskaya | annp: https://review.openstack.org/#/c/323971/60..64/neutron_fwaas/tests/unit/services/firewall/agents/l2/test_fwaas_v2.py test_inactivity_patterns for example | 11:26 |
| *** yamamoto has joined #openstack-fwaas | 11:34 | |
| *** yamamoto has quit IRC | 11:39 | |
| *** yushiro has quit IRC | 11:47 | |
| *** vks1 has quit IRC | 12:20 | |
| *** yamamoto has joined #openstack-fwaas | 12:23 | |
| *** yushiro has joined #openstack-fwaas | 12:48 | |
| *** eezhova_ has quit IRC | 14:03 | |
| openstackgerrit | Inessa Vasilevskaya proposed openstack/neutron-fwaas master: Introduce default firewall groups https://review.openstack.org/425769 | 14:23 |
| ivasilevskaya | let's wait for the tests to pass and then reviews are appreciated :) | 14:29 |
| openstackgerrit | Yushiro FURUKAWA proposed openstack/neutron-fwaas-dashboard master: FWaaS V2 Horizon Dashboard https://review.openstack.org/475840 | 14:30 |
| ivasilevskaya | xgerman, I added details to default rules\policies (and covered by UT), renamed the tempest test that confused me and added another exception class for better clearer errors on updated | 14:30 |
| ivasilevskaya | for clearer error messages on update* | 14:31 |
| *** eezhova has joined #openstack-fwaas | 14:59 | |
| xgerman_ | thanks — let me know and I will retest ;-) | 15:10 |
| *** eezhova has quit IRC | 15:29 | |
| *** ivasilevskaya has quit IRC | 15:31 | |
| *** eezhova has joined #openstack-fwaas | 15:38 | |
| *** yushiro has quit IRC | 15:41 | |
| *** eezhova has quit IRC | 15:52 | |
| openstackgerrit | Reedip proposed openstack/neutron-fwaas master: Add validation for Firewall Rules and Policies https://review.openstack.org/488438 | 16:30 |
| *** eezhova has joined #openstack-fwaas | 17:57 | |
| *** eezhova has quit IRC | 18:15 | |
| *** eezhova has joined #openstack-fwaas | 18:43 | |
| *** eezhova has quit IRC | 18:52 | |
| openstackgerrit | Inessa Vasilevskaya proposed openstack/neutron-fwaas master: Introduce default firewall groups https://review.openstack.org/425769 | 22:25 |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/neutron-fwaas master: Updated from global requirements https://review.openstack.org/510105 | 22:32 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!