| *** yushiro2 has quit IRC | 00:17 | |
| *** sarathmekala_ has quit IRC | 01:57 | |
| openstackgerrit | Merged openstack/neutron-fwaas master: Updated from global requirements https://review.openstack.org/496051 | 03:31 |
|---|---|---|
| *** yushiro2 has joined #openstack-fwaas | 04:08 | |
| *** SridarK has joined #openstack-fwaas | 04:24 | |
| SridarK | yushiro: hi | 04:42 |
| reedip | o/ | 04:44 |
| reedip | yushiro is not there today | 04:44 |
| reedip | <yushiro2> morning. sarathmekala_ Sorry for yesterday. I took care of my wife and fall asleep last night. | 04:44 |
| reedip | team, today I leave my office and am in another office. If you ask me something, please reach out me in IRC or e-mail(y.furukawa8@gmail.com) | 04:44 |
| reedip | I cannot see company e-mail.. | 04:44 |
| reedip | SridarK : ^^ | 04:44 |
| yushiro2 | SridarK, reedip hi | 04:45 |
| reedip | oh good he is there :D | 04:45 |
| yushiro2 | yushiro is not active.. please lemme call yushiro2 :) | 04:45 |
| reedip | hahahahaha | 04:45 |
| yushiro2 | Maybe I forgot turn off hexChat in my comapny | 04:46 |
| amotoki | we can assume two yushiro: yushiro and yushiro2 at the same time :) | 04:49 |
| yushiro2 | hahaa, sorry for confuse. yushiro2: status=ACTIVE | 04:50 |
| SridarK | :-) | 04:50 |
| yushiro2 | Now, I'm fixing v2 dashboard UTs. | 04:51 |
| SridarK | so with PS25 - i am able to Create FWG but have issue if policy is not specified | 04:51 |
| SridarK | Policy is better | 04:51 |
| yushiro2 | SridarK, OK. Could you tell me some error message? I assume 'None' or '' is specified in ingress/egress firewall_policy_id | 04:52 |
| SridarK | let me pull that | 04:52 |
| SridarK | Unable to add Firewall Group "TestPS25FWG".Invalid input for ingress_firewall_policy_id. Reason: '' is not a valid UUID. Neutron server returns request_ids: ['req-90dad3ca-b767-4e73-ae33-1c5602121d82'] | 04:53 |
| SridarK | yushiro2: yes exactly | 04:54 |
| amotoki | I think Sarath is fixing something last night | 04:54 |
| amotoki | but I don't see any new fix from Sarath... | 04:54 |
| SridarK | Same issue is seen if i update an existing FWG and set one of the policy to None | 04:55 |
| yushiro2 | amotoki, yes... | 04:55 |
| yushiro2 | SridarK, Oh, really... https://review.openstack.org/#/c/475840/25/neutron_fwaas_dashboard/dashboards/project/firewalls_v2/forms.py@392 | 04:56 |
| yushiro2 | SridarK, I implemented this method for converting '' to None. | 04:56 |
| yushiro2 | Maybe it won't work correctly in update case. | 04:56 |
| amotoki | yushiro2: you added a function to prepare a body only with modified fields but it converts '' to None too much | 04:58 |
| amotoki | yushiro2: have you fixed it? | 04:58 |
| amotoki | yushiro2: the function converts '' of name/descrption to None | 04:58 |
| yushiro2 | amotoki, You're right. This is a bug.. | 04:59 |
| amotoki | see the log last night | 04:59 |
| amotoki | yushiro2: http://eavesdrop.openstack.org/irclogs/%23openstack-fwaas/%23openstack-fwaas.2017-08-23.log.html#t2017-08-23T17:40:59 | 04:59 |
| yushiro2 | amotoki, Thanks. | 04:59 |
| yushiro2 | I haven't fixed yet. | 05:00 |
| amotoki | it seems Sarath has a local fix.....hmmm again | 05:01 |
| amotoki | how can we move forward effectively??? | 05:01 |
| SridarK | let me see if Sarath can be reached - i will see if i can send a text to chandan and have him ping Sarath - i have no other way of reaching | 05:04 |
| amotoki | thanks SridarK | 05:06 |
| SridarK | When i update the ports (add/remove) - i lose the drop down - until i reload the browser - the button is a delete FWG - sorry my knowledge of UI is very primitive | 05:07 |
| SridarK | amotoki: np | 05:07 |
| SridarK | otherwise other than the None issue for ingress or egress pol FWG is looking decent - for basic operations | 05:08 |
| yushiro2 | I ready the log. Thanks amotoki | 05:09 |
| yushiro2 | 1. converting None for 'ingress/egress_firewall_policy_id' in FWG | 05:13 |
| SridarK | On policy - Create works now but cannot Create with Rules (all Rules have undefined next to them) | 05:14 |
| SridarK | But i can Insert/Add Rules on a Policy | 05:15 |
| SridarK | So while it is better now with PS25 still some issues on Create | 05:15 |
| SridarK | I have marked on etherpad for PS25 | 05:15 |
| yushiro2 | OK | 05:15 |
| yushiro2 | amotoki, I'll implement convert_to_none() like clean() in form.py | 05:19 |
| yushiro2 | currently, I don't have devstack env (I can only execute UT), so I'll paste patch file. | 05:21 |
| SridarK | yushiro2: if u push PS26 - i will test on devstack env | 05:22 |
| amotoki | btw, when will we make the final decision? | 05:23 |
| SridarK | amotoki: what do u think - it seems we still have issues | 05:23 |
| yushiro2 | hmm, yes.. | 05:23 |
| amotoki | I think so. the current situation has not changed from the last night (12 hours ago) | 05:24 |
| SridarK | We may just be able to verify some basic workflows - i think time wise the testing will be quite limited | 05:25 |
| amotoki | my personal vote is to havie it in early Queens. if it is for developers, it works perfectly | 05:25 |
| SridarK | amotoki: yes i think one change is that Create for FWG and Policy works but issues with Policy being None. On Policy Rule specification is a problem in Create | 05:26 |
| amotoki | at least I think the current version cannot be for end-users | 05:26 |
| SridarK | amotoki: yes i completely agree | 05:26 |
| SridarK | During the IRC we said we will make a call by Wed | 05:27 |
| amotoki | so how about continuing our effort and land it by the next week and cut a first release with v2 dashboard next week (hopefully) | 05:27 |
| amotoki | ? | 05:27 |
| amotoki | so we can use it more earily by pip install or devstack | 05:28 |
| SridarK | amotoki: so that will be Queens | 05:28 |
| amotoki | yes | 05:28 |
| amotoki | that is my current vote | 05:28 |
| SridarK | yushiro2: how do u feel. I am ok with that | 05:28 |
| SridarK | Also chandan is trying to reach Sarath - he just messaged me | 05:29 |
| yushiro2 | SridarK, amotoki OK, we don't have enough time too. | 05:30 |
| yushiro2 | I agree with cutting first release for current status. | 05:31 |
| SridarK | I think we have the above mentioned 2 issues (Create with FWG and Pol) and UT faiures | 05:32 |
| SridarK | But this is basic workflow | 05:32 |
| SridarK | Ok so i think we are in agreement with amotoki's suggestion | 05:33 |
| amotoki | SridarK: yushiro2: agree. it's a difficult choice but let's land it soon for queens! | 05:36 |
| amotoki | SridarK: yushiro2: I removed my WIP from https://review.openstack.org/#/c/496307/. if you are okay, +1 to this | 05:37 |
| *** SarathMekala has joined #openstack-fwaas | 05:37 | |
| SarathMekala | hi O/ | 05:39 |
| yushiro2 | hi | 05:39 |
| reedip | ?? | 05:41 |
| SarathMekala | is SridarK around | 05:42 |
| SridarK | SarathMekala: Hi | 05:42 |
| SarathMekala | hi SridarK | 05:42 |
| SridarK | SarathMekala: quick digest - looks like while we are close - it is best to land it in Queens so we have more testing | 05:43 |
| SarathMekala | SridarK, right.. I too am of the same opinion | 05:43 |
| SridarK | SarathMekala: pls check etherpad for issues on PS25 | 05:44 |
| SarathMekala | SridarK, I will do that | 05:44 |
| SridarK | Create FWG and Create Pol are better but still have some issues. yushiro2 is looking at a fix | 05:44 |
| SarathMekala | even UT needs to be fixed up a bit | 05:44 |
| SridarK | SarathMekala: yes | 05:44 |
| SarathMekala | ok | 05:45 |
| SarathMekala | yushiro2, did you put in the fix I mentioned yesterday night for _get_request_body | 05:45 |
| *** sarathmekala_ has joined #openstack-fwaas | 05:50 | |
| *** SarathMekala has quit IRC | 05:53 | |
| *** hoangcx has joined #openstack-fwaas | 05:54 | |
| yushiro2 | sarathmekala_, I'll update soon. | 05:56 |
| openstackgerrit | Yushiro FURUKAWA proposed openstack/neutron-fwaas-dashboard master: FWaaS V2 Horizon Dashboard https://review.openstack.org/475840 | 06:16 |
| yushiro2 | Just fixed _get_request_body and None issue. Could you try it? | 06:16 |
| sarathmekala_ | yushiro2, sure.. will try it out | 06:17 |
| *** eezhova has joined #openstack-fwaas | 06:20 | |
| yushiro2 | sarathmekala_, thanks. Currently I don't have devstack. | 06:21 |
| yushiro2 | Please test following case: 1. create FWG with no policies, 2. update FWG with policy to None 3. create FWR with no protocol/source/dest/ip/port 4. update FWR with protocol -> None, source/dst_ip,port -> None | 06:23 |
| sarathmekala_ | ok | 06:24 |
| yushiro2 | sarathmekala_, Thank you so much :) | 06:26 |
| sarathmekala_ | np.. I should be thanking you :0 | 06:27 |
| *** eezhova has quit IRC | 07:07 | |
| *** eezhova has joined #openstack-fwaas | 07:47 | |
| *** yamamoto has joined #openstack-fwaas | 08:10 | |
| sarathmekala_ | hi yushiro2 | 08:23 |
| yushiro2 | hi | 08:24 |
| sarathmekala_ | all the test cases you mentioned are working | 08:24 |
| sarathmekala_ | I had one comment though | 08:24 |
| yushiro2 | sarathmekala_, OK, good :) Thank you | 08:24 |
| yushiro2 | OK | 08:25 |
| sarathmekala_ | instead of having individual _get_body_content.. we can have a generic method (like the one at the bottom) and have a list of fields that need to be checked for none | 08:25 |
| sarathmekala_ | I will give this a shot in the evening | 08:26 |
| sarathmekala_ | I have also observed one issue.. | 08:26 |
| sarathmekala_ | when we create a policy and assign it rules.. they are being ignored | 08:26 |
| yushiro2 | you mean _convert_req_body ? | 08:26 |
| sarathmekala_ | but insertion and deletion of rules to policy works | 08:26 |
| sarathmekala_ | yushiro2, yes | 08:26 |
| sarathmekala_ | we can have a generic _convert_req_body and have an array of fields that need to be checked for none | 08:27 |
| yushiro2 | sarathmekala_, However, target parametrs is different each resources(fwg, fwr, fwp). | 08:28 |
| yushiro2 | Therefore, I implemented as an instance method. | 08:28 |
| yushiro2 | _get_request_body() is generic for all resources. | 08:29 |
| sarathmekala_ | yes.. but across all the three we have only a few | 08:29 |
| yushiro2 | sarathmekala_, creating policy with rule is another problem I think. We have to implement clean() in workflow.py | 08:30 |
| yushiro2 | forms.py is only update case. | 08:30 |
| *** reedip has quit IRC | 08:31 | |
| sarathmekala_ | yes | 08:32 |
| sarathmekala_ | I will jump in once I reach back home today | 08:32 |
| sarathmekala_ | will sync up with you in case you get a chance to make any progress | 08:32 |
| yushiro2 | OK | 08:34 |
| yushiro2 | I'll consider create case either. | 08:34 |
| *** yushiro2 has quit IRC | 08:51 | |
| *** SridarK has quit IRC | 08:59 | |
| *** yamamoto has quit IRC | 09:16 | |
| *** yamamoto has joined #openstack-fwaas | 09:17 | |
| *** yamamoto has quit IRC | 09:27 | |
| *** yamamoto has joined #openstack-fwaas | 09:29 | |
| *** yamamoto has quit IRC | 09:30 | |
| *** reedip has joined #openstack-fwaas | 09:51 | |
| reedip | o/ | 09:52 |
| *** yamamoto has joined #openstack-fwaas | 10:31 | |
| *** yamamoto has quit IRC | 10:36 | |
| *** yamamoto has joined #openstack-fwaas | 11:33 | |
| *** yamamoto has quit IRC | 11:38 | |
| *** sarathmekala_ has quit IRC | 11:52 | |
| *** SarathMekala has joined #openstack-fwaas | 12:00 | |
| *** sarathmekala_ has joined #openstack-fwaas | 12:01 | |
| *** SarathMekala has quit IRC | 12:05 | |
| amotoki | yushiro: sarathmekala_: what's the current status? we are focusing on testing the v2 dashboard, so I believe it is nice to update and test it intensively this and next weeks. | 12:26 |
| *** yamamoto has joined #openstack-fwaas | 12:34 | |
| *** yamamoto has quit IRC | 12:41 | |
| *** reedip has quit IRC | 13:01 | |
| *** reedip has joined #openstack-fwaas | 13:13 | |
| *** yamamoto has joined #openstack-fwaas | 13:36 | |
| *** yamamoto has quit IRC | 13:42 | |
| *** sarathmekala_ has quit IRC | 13:45 | |
| openstackgerrit | OpenStack Release Bot proposed openstack/neutron-fwaas-dashboard master: Update reno for stable/pike https://review.openstack.org/497245 | 13:53 |
| *** TuanVu_ has joined #openstack-fwaas | 14:06 | |
| amotoki | neutron-fwaas-dashboard 1.0.0 has been released with v1 dashboard stuff | 14:11 |
| amotoki | let's continue the work for sooner landing of v2 dashboard :) | 14:11 |
| openstackgerrit | Merged openstack/neutron-fwaas-dashboard master: Update reno for stable/pike https://review.openstack.org/497245 | 14:17 |
| openstackgerrit | Merged openstack/neutron-fwaas-dashboard master: Updated from global requirements https://review.openstack.org/494855 | 14:20 |
| xgerman_ | o/ | 14:36 |
| *** yamamoto has joined #openstack-fwaas | 14:38 | |
| *** yamamoto has quit IRC | 14:44 | |
| *** TuanVu_ has quit IRC | 14:50 | |
| *** eezhova has quit IRC | 15:09 | |
| *** reedip_ has joined #openstack-fwaas | 15:21 | |
| reedip_ | o/ | 15:29 |
| *** yamamoto has joined #openstack-fwaas | 15:40 | |
| *** yamamoto has quit IRC | 15:45 | |
| *** SarathMekala has joined #openstack-fwaas | 15:45 | |
| *** sarathmekala_ has joined #openstack-fwaas | 15:46 | |
| *** eezhova has joined #openstack-fwaas | 15:46 | |
| *** amotoki is now known as amotoki__away | 15:47 | |
| *** SarathMekala has quit IRC | 15:49 | |
| *** SarathMekala has joined #openstack-fwaas | 15:52 | |
| *** sarathmekala_ has quit IRC | 15:54 | |
| *** sarathmekala_ has joined #openstack-fwaas | 15:55 | |
| *** SarathMekala has quit IRC | 15:58 | |
| sarathmekala_ | hi amotoki.. | 15:58 |
| sarathmekala_ | The current status is that all the CRUD for FWG, Policy and Rule are working | 15:59 |
| sarathmekala_ | there are some issues related to Rule addition while creating a policy | 16:00 |
| sarathmekala_ | UT is another area that needs to be fixed, yushiro was working on them | 16:01 |
| *** openstackgerrit has quit IRC | 16:04 | |
| *** reedip_ has quit IRC | 16:12 | |
| *** yamamoto has joined #openstack-fwaas | 16:41 | |
| *** yamamoto has quit IRC | 16:47 | |
| *** openstackgerrit has joined #openstack-fwaas | 16:48 | |
| openstackgerrit | Merged openstack/neutron-fwaas master: Update policy on rule addition/removal https://review.openstack.org/494742 | 16:48 |
| *** sarathmekala_ has quit IRC | 16:57 | |
| *** eezhova has quit IRC | 17:34 | |
| *** yamamoto has joined #openstack-fwaas | 17:43 | |
| *** eezhova has joined #openstack-fwaas | 17:46 | |
| *** eezhova has quit IRC | 17:47 | |
| *** yamamoto has quit IRC | 17:48 | |
| *** eezhova has joined #openstack-fwaas | 17:48 | |
| *** SumitNaiksatam has joined #openstack-fwaas | 17:56 | |
| *** yamamoto has joined #openstack-fwaas | 18:44 | |
| *** yamamoto has quit IRC | 18:50 | |
| *** eezhova has quit IRC | 19:13 | |
| *** SumitNaiksatam has quit IRC | 19:15 | |
| *** eezhova has joined #openstack-fwaas | 19:27 | |
| *** yamamoto has joined #openstack-fwaas | 19:46 | |
| *** yamamoto has quit IRC | 19:51 | |
| *** yamamoto has joined #openstack-fwaas | 19:51 | |
| *** eezhova has quit IRC | 20:13 | |
| *** yamamoto has quit IRC | 20:45 | |
| *** yamamoto has joined #openstack-fwaas | 21:46 | |
| *** yamamoto has quit IRC | 21:51 | |
| *** yamamoto has joined #openstack-fwaas | 22:47 | |
| *** yamamoto has quit IRC | 22:53 | |
| openstackgerrit | Yushiro FURUKAWA proposed openstack/neutron-fwaas master: Remove log translations https://review.openstack.org/479102 | 22:57 |
| openstackgerrit | Yushiro FURUKAWA proposed openstack/neutron-fwaas master: OVS based l2 Firewall driver for FWaaS v2 https://review.openstack.org/447251 | 22:59 |
| *** yushiro2 has joined #openstack-fwaas | 23:29 | |
| yushiro2 | morning | 23:29 |
| yushiro2 | regarding v2 dashboard, I'm fixing UTs now. However, today I haven't enough time to work, so I need to help someone to fix following case in PS27 | 23:30 |
| yushiro2 | When creating fw_policy and fw_rule, we need to validate request body parameters either. | 23:32 |
| yushiro2 | ^^^ I think it's better to implement clean() into workflows.py for each class. | 23:33 |
| yushiro2 | In case of fw_policy with rule, we need to check 'firewall_rules' parameter. If we don't specify 'firewall_rules', it should be []. | 23:39 |
| yushiro2 | In case of fw_rule, we should convert 'protocol', 'source/destination_port', 'source/destination_ip_address'. Please refer https://review.openstack.org/#/c/475840/26/neutron_fwaas_dashboard/dashboards/project/firewalls_v2/forms.py@79 | 23:42 |
| *** yamamoto has joined #openstack-fwaas | 23:49 | |
| *** yamamoto has quit IRC | 23:55 | |
| *** yushiro2 has quit IRC | 23:57 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!