| *** yamamoto has quit IRC | 00:01 | |
| *** yamamoto has joined #openstack-fwaas | 00:05 | |
| openstackgerrit | Merged openstack/neutron-fwaas-dashboard master: Fix wrong homepage in setup.cfg https://review.openstack.org/489128 | 00:15 |
|---|---|---|
| *** vishwana_ has joined #openstack-fwaas | 00:18 | |
| *** vishwanathj has quit IRC | 00:22 | |
| *** https_GK1wmSU has joined #openstack-fwaas | 00:23 | |
| *** https_GK1wmSU has left #openstack-fwaas | 00:25 | |
| openstackgerrit | Merged openstack/neutron-fwaas master: Replace deprecated test.attr with decorators.attr https://review.openstack.org/486814 | 00:26 |
| *** yushiro has joined #openstack-fwaas | 01:02 | |
| *** yamamoto has quit IRC | 01:25 | |
| *** yamamoto has joined #openstack-fwaas | 01:29 | |
| *** Tim_Eberhard has joined #openstack-fwaas | 01:46 | |
| *** Tim_Eberhard has quit IRC | 01:51 | |
| *** yamamoto has quit IRC | 01:51 | |
| *** yamamoto has joined #openstack-fwaas | 01:56 | |
| *** yamamoto has quit IRC | 02:07 | |
| *** yamamoto has joined #openstack-fwaas | 02:19 | |
| *** https_GK1wmSU has joined #openstack-fwaas | 02:49 | |
| *** https_GK1wmSU has left #openstack-fwaas | 02:50 | |
| reedip | o/ | 02:54 |
| *** yamamoto has quit IRC | 03:01 | |
| *** yamamoto has joined #openstack-fwaas | 03:06 | |
| *** yamamoto has quit IRC | 03:21 | |
| *** yamamoto has joined #openstack-fwaas | 03:24 | |
| *** yamamoto has quit IRC | 03:36 | |
| *** yamamoto has joined #openstack-fwaas | 03:44 | |
| *** Tim_Eberhard has joined #openstack-fwaas | 03:48 | |
| *** Tim_Eberhard has quit IRC | 03:52 | |
| *** yamamoto has quit IRC | 04:04 | |
| *** yamamoto has joined #openstack-fwaas | 04:09 | |
| reedip | yushiro : yo | 04:33 |
| yushiro | reedip, yo-yo- ;) | 04:42 |
| yushiro | sorry for late | 04:43 |
| reedip | no issues, I wanted to discuss the patches we have | 04:43 |
| yushiro | aha, sure | 04:43 |
| yushiro | you mean, insert_rule ? | 04:43 |
| reedip | yes | 04:43 |
| yushiro | OK | 04:44 |
| reedip | yushiro : we have similar patches | 04:44 |
| reedip | yushiro : https://review.openstack.org/#/c/486377/ already considers that the create firewall-policy has the check | 04:45 |
| reedip | because otherwise the bug https://launchpad.net/bugs/1699706 wont exist | 04:45 |
| openstack | Launchpad bug 1699706 in neutron "Updation of shared firewall-policy with non shared firewall-rule should be restricted" [Undecided,In progress] - Assigned to Reedip (reedip-banerjee) | 04:45 |
| reedip | We dont need a check in the firewall-rule creation | 04:46 |
| reedip | but yes, updating the firewall-rule from shared to no-shared can be an issue | 04:46 |
| yushiro | yes. | 04:46 |
| yushiro | so, I'd like to combine these patches. | 04:46 |
| reedip | ok, it makes sense now :) | 04:47 |
| yushiro | Ok, I think it's OK to merge my patch to your patch | 04:47 |
| yushiro | it can be solved bug1614680 | 04:48 |
| reedip | Ok, I will merge my patch with yours, but the thing is you modified only db_v2 | 04:48 |
| reedip | not the v1's files... may I know the reason ? | 04:48 |
| reedip | I mean shouldnt your patch also target v1 ? | 04:48 |
| yushiro | aha, @testtools.skip('bug/1614680') is only appeared v1. That's why I fixed it only v2. | 04:50 |
| yushiro | s/v1/v2 | 04:50 |
| yushiro | But, it is definitely a bug :) | 04:51 |
| yushiro | It's OK to apply v1 also. | 04:51 |
| yushiro | Please add "Closes-Bug: #1614680" into commit message. | 04:51 |
| openstack | bug 1614680 in neutron "In FWaaS v2 cross-tenant assignment of policies is inconsistent" [Undecided,In progress] https://launchpad.net/bugs/1614680 - Assigned to Yushiro FURUKAWA (y-furukawa-2) | 04:51 |
| yushiro | wow | 04:51 |
| yushiro | I didn't know such command :) | 04:52 |
| reedip | it used the Bug ID :) | 04:53 |
| reedip | ok, now I am confused... | 04:53 |
| reedip | First let me merge my patch with yours , then we can proceed further ... | 04:53 |
| reedip | I updated it | 05:07 |
| openstackgerrit | Reedip proposed openstack/neutron-fwaas master: Add validation for Firewall Rules and Policies https://review.openstack.org/488438 | 05:08 |
| reedip | @yushiro : you can add the additional validation on v1 as well | 05:10 |
| yushiro | OK | 05:20 |
| yushiro | will check your updated patch | 05:20 |
| *** Tim_Eberhard has joined #openstack-fwaas | 07:50 | |
| *** Tim_Eberhard has quit IRC | 07:54 | |
| *** yushiro has quit IRC | 09:03 | |
| *** yamamoto has quit IRC | 09:37 | |
| *** yamamoto has joined #openstack-fwaas | 09:57 | |
| *** yamamoto has quit IRC | 10:08 | |
| *** yamamoto has joined #openstack-fwaas | 10:25 | |
| *** Tim_Eberhard has joined #openstack-fwaas | 11:01 | |
| *** Tim_Eberhard has quit IRC | 11:05 | |
| *** yamamoto has quit IRC | 11:17 | |
| *** yamamoto has joined #openstack-fwaas | 11:32 | |
| *** yamamoto has quit IRC | 11:49 | |
| *** yamamoto has joined #openstack-fwaas | 12:49 | |
| *** hoangcx_ has joined #openstack-fwaas | 12:50 | |
| *** yamamoto has quit IRC | 12:59 | |
| *** TuanVu has joined #openstack-fwaas | 13:48 | |
| *** yushiro has joined #openstack-fwaas | 13:57 | |
| *** SarathMekala has joined #openstack-fwaas | 14:00 | |
| *** reedip_ has joined #openstack-fwaas | 14:13 | |
| *** chandanc has joined #openstack-fwaas | 15:00 | |
| SarathMekala | ok lets continue here :) | 15:00 |
| *** SridarK has joined #openstack-fwaas | 15:00 | |
| yushiro | yes | 15:00 |
| chandanc | sure | 15:01 |
| SarathMekala | Now coming to ports | 15:01 |
| *** reedip_ has quit IRC | 15:01 | |
| SarathMekala | currently I am fetching router ports only | 15:01 |
| *** hoangcx_ has quit IRC | 15:01 | |
| SridarK | SarathMekala: sorry go ahead | 15:01 |
| SridarK | SarathMekala: that is fine since only tht exists in code today | 15:01 |
| SarathMekala | but once L2 support is added, we will have to fetch VM ports as well | 15:01 |
| SarathMekala | and the UI has to seggregate the VM and Router ports and make it more informative to the user | 15:02 |
| SarathMekala | right now I am showing the port name, which looks very ugly | 15:02 |
| SridarK | TuanVu: sorry we did not get to ur patch in the mtg - looking at it | 15:02 |
| TuanVu | Hi SridarK, thanks for your concern, I really appreciate it | 15:03 |
| yushiro | SarathMekala, How about showing device_owner ? | 15:03 |
| SridarK | SarathMekala: the segration will make for a better user exp IMHO | 15:03 |
| SarathMekala | SridarK, yes.. i have some idea but I need to get it done with AngularJS.. will take some time | 15:04 |
| SarathMekala | I will try to improve the UI incrementally | 15:04 |
| SridarK | SarathMekala: i think that can happen in the next release | 15:04 |
| SridarK | SarathMekala: yes | 15:04 |
| SarathMekala | SridarK, yes | 15:04 |
| SarathMekala | one more thing | 15:04 |
| SarathMekala | in the Fwaas V1 UI, the rule had a mapping to the policy its attached to | 15:05 |
| SridarK | Now if u can address the UT issues pointed to by amotoki and get this basic stuff ready - we have a good chance of getting an FFE | 15:05 |
| SarathMekala | this made it easy in the UI to filter out | 15:05 |
| SarathMekala | SridarK, I will try.. I am in a really tight spot | 15:06 |
| SridarK | SarathMekala: yes - in v1 a rule can be associated only with one policy | 15:06 |
| SridarK | that makes it easier | 15:06 |
| SridarK | we remove that restriction in v2 | 15:06 |
| SridarK | but as a user it will be nice to know which policies contain a rule | 15:06 |
| SridarK | there are some issues here i thin | 15:07 |
| SridarK | but this can be an incremental change | 15:07 |
| SarathMekala | SridarK, yes | 15:07 |
| SarathMekala | I will also require some additional rpcs | 15:07 |
| amotoki | what is 'rpcs'? | 15:08 |
| SarathMekala | remote procedure calls | 15:08 |
| SridarK | yushiro: do u know if patches can merge now - i checked https://review.openstack.org/#/c/479102/ | 15:08 |
| SarathMekala | on the neutronclient | 15:08 |
| amotoki | got it | 15:09 |
| yushiro | SridarK, Yes, I think it's OK to merge. | 15:09 |
| SarathMekala | I will check the requirement and send across a mail of what i will need and add it to the plugin/client | 15:09 |
| SridarK | yushiro: yes since it is more a fix | 15:10 |
| *** TuanVu has quit IRC | 15:10 | |
| SarathMekala | amotoki, I have one question for you | 15:10 |
| amotoki | SridarK: yushiro: log translation is no longer requirement, so you can drop it any time, but personally it is better to drop them at the beginning of cycles. | 15:10 |
| SridarK | amotoki: ok | 15:10 |
| amotoki | SridarK: yushiro: i think we will do same fro the neutron repo | 15:10 |
| amotoki | SarathMekala: what? | 15:11 |
| SarathMekala | the UI dashboard plugin does not have runserver module in tox | 15:11 |
| yushiro | amotoki, aha, OK. sounds reasonable. | 15:11 |
| *** TuanVu has joined #openstack-fwaas | 15:11 | |
| SridarK | amotoki: ok then we will wait and get it in as son as Q opens up | 15:11 |
| amotoki | SridarK: there is no need for runserver. | 15:11 |
| yushiro | SridarK, Thanks. So, can we sync up with neutron-side update? | 15:11 |
| amotoki | runserver in the horizon repo loads horizon plugins | 15:11 |
| amotoki | SarathMekala: ^ | 15:12 |
| SarathMekala | amotoki, yes.. that how I run my code changes | 15:12 |
| SarathMekala | I dont change the actual openstack code | 15:12 |
| SridarK | yushiro: yes lets do that | 15:13 |
| amotoki | SarathMekala: what you need to do is to install neutron-fwaas-dashboard into runserver tox env, put the enabled file into openstack_dashboard/local/enabled and runserver in horizon repo | 15:13 |
| amotoki | SarathMekala: what I usually do is: tox -e runserver (in horizon repo), .tox/runserver/bin/pip install -e <somewhere>/neutron-fwaas-dashboard and copy the enabled file | 15:14 |
| SarathMekala | amotoki, ok.. I am not sure if I get you.. but I will give your procedure a try | 15:14 |
| amotoki | and then run tox -e runserver again | 15:14 |
| SarathMekala | oh.. ok .. got you | 15:14 |
| *** TuanVu has quit IRC | 15:14 | |
| SarathMekala | amotoki, thanks.. I understand now | 15:14 |
| yushiro | SridarK, today's discussion, we implement l2 driver's validation on server side, right? | 15:15 |
| amotoki | SarathMekala: feel free to ping me like horizon related things in #-horizon | 15:15 |
| SridarK | yushiro: 2 min | 15:15 |
| SarathMekala | amotoki, sure.. thanks | 15:15 |
| amotoki | SarathMekala: other folks like rob will help you too | 15:15 |
| yushiro | sure | 15:16 |
| SarathMekala | SridarK, amotoki, for FFE what will be the timelines? | 15:16 |
| amotoki | wait for a while | 15:16 |
| amotoki | looking at the schedule https://releases.openstack.org/pike/schedule.html, the week of Aug 7 is RC1 week | 15:16 |
| amotoki | RC1 release is the last chance for RFE patches. | 15:17 |
| SridarK | yushiro: sorry back | 15:17 |
| amotoki | In most cases, Mon or Tue of the week is the deadline. | 15:17 |
| amotoki | that means patches need to be in good shape this week | 15:18 |
| SarathMekala | so we will have time till Aug 8 approximately | 15:18 |
| yushiro | no problem | 15:18 |
| SridarK | amotoki: thx for all the help here | 15:18 |
| amotoki | we need to merge it till Aug 8 | 15:18 |
| amotoki | at the latest | 15:18 |
| SarathMekala | hmmm | 15:19 |
| SarathMekala | so what will be the basic requirements? | 15:19 |
| SridarK | yushiro: yes my thinking was if we trigger the validation based on the setting of the L2 driver - it will be easier | 15:19 |
| SarathMekala | UT and UI feature | 15:19 |
| amotoki | I don't know what is the basic requirements. it is okay if the FWaaS team can think it is ready for ship as features or behaviors. | 15:20 |
| SarathMekala | ok | 15:20 |
| amotoki | from my side, basic unit test coverage would be nice | 15:20 |
| yushiro | SridarK, OK, We're on same page now. I agree. | 15:21 |
| amotoki | otherwise it makes difficult to handle backport patches if any | 15:21 |
| SridarK | SarathMekala: i think u can focus on ensuring that basic features are working along the UT coverage | 15:21 |
| SarathMekala | SridarK, amotoki Ok | 15:21 |
| yushiro | SridarK, I wrote today's A.I on fwaas etherpad now. | 15:22 |
| SarathMekala | SridarK, I think the following should do it | 15:22 |
| amotoki | SarathMekala: i can help UT coverage for cleanup, but the current status looks far away from that stage | 15:22 |
| SridarK | u can reiterate for some of the more nicer things as refinements in the next release | 15:22 |
| SridarK | yushiro: ok great | 15:22 |
| amotoki | +1 for SridarK's suggestion | 15:22 |
| SarathMekala | The only things mising from functionality are add/delete ports to FWG | 15:22 |
| SarathMekala | i will finish it and add UT | 15:22 |
| SridarK | yushiro: it is late for u do u want to spend some time in ur morning time along with chandanc | 15:23 |
| SridarK | let me know what is a good time and i will be available | 15:23 |
| SarathMekala | amotoki, I havent worked on UT till now | 15:23 |
| chandanc | SridarK: i was chatting with yushiro | 15:23 |
| SarathMekala | its basically V1 UT code that I took initially | 15:23 |
| SridarK | chandanc: ok :-) | 15:23 |
| SarathMekala | I will fix it | 15:24 |
| chandanc | i think it will be good to summarize the plugin extension and flag base l2 discussion on mail | 15:24 |
| chandanc | i stiil have questions :( | 15:24 |
| yushiro | SridarK, haha, thanks. but I'd like to clarify more :) | 15:24 |
| SridarK | chandanc: ok no worries | 15:24 |
| SridarK | chandanc: are u ok to talk more in ur morning time ? | 15:24 |
| amotoki | SarathMekala: no problem. sounds good | 15:25 |
| SarathMekala | amotoki, thanks for your help | 15:25 |
| chandanc | SridarK: i am | 15:25 |
| SridarK | yushiro: chandanc: my view is that we want to ensure that basic L2 works decently end to end | 15:25 |
| chandanc | Actualluy i have a meeting in another 2 mins :) | 15:26 |
| SridarK | a few caveats or corner cases is ok | 15:26 |
| yushiro | yes | 15:26 |
| chandanc | SridarK: ok agree | 15:26 |
| SridarK | chandanc: ok lets talk in ur morning and yushiro's afternoon | 15:26 |
| chandanc | sure | 15:26 |
| yushiro | currently, golden route seems to be passed. | 15:26 |
| yushiro | SridarK, sorry. Could you discuss 1 thing? | 15:27 |
| SarathMekala | I need to log off now.. will be working on the areas that we discussed today | 15:27 |
| SridarK | yushiro: yes sure | 15:27 |
| *** SarathMekala has quit IRC | 15:27 | |
| SridarK | i am ok it is only 8:30am here :-) | 15:27 |
| yushiro | OK. I need to decide a constraint to be able to delete firewall group. | 15:28 |
| SridarK | yushiro: so there should be no ports on it | 15:28 |
| SridarK | if i recall correctly | 15:29 |
| yushiro | SridarK, OK, so we can delete its firewall group which status is 'INACTIVE' | 15:29 |
| yushiro | same as no port | 15:29 |
| SridarK | yushiro: that for sure | 15:29 |
| yushiro | SridarK, OK, we're on same page. | 15:29 |
| yushiro | How about ingress/egress firewall policy ? | 15:30 |
| SridarK | hmm actually i dont think we have a constraint | 15:30 |
| yushiro | Current my validation, these parameter doesn't care | 15:30 |
| yushiro | yeah... I think if we consider policies, we have to check firewall-rule-policies relation at last... | 15:31 |
| SridarK | yushiro: yes that for sure | 15:31 |
| SridarK | we cannot delete a policy if it is associated to a fwg | 15:32 |
| yushiro | OK, I'll keep this validation. | 15:32 |
| yushiro | yeah | 15:32 |
| SridarK | deleting a fwg is fine | 15:33 |
| yushiro | SridarK, xgerman_ https://review.openstack.org/#/c/486377/ This patch can solve share/unshared rule - policy validation | 15:33 |
| yushiro | I hope to review it if reedip is able to update :) | 15:34 |
| yushiro | just information! | 15:35 |
| *** Tim_Eberhard has joined #openstack-fwaas | 15:35 | |
| SridarK | yushiro: oh yes this is a bug indeed | 15:35 |
| SridarK | we will get this in | 15:35 |
| yushiro | yes, it is necessary to handle a validation between firewall group and policy. | 15:36 |
| yushiro | OK, last 1 thing about default firewall group. | 15:38 |
| SridarK | yushiro: ok shall we continue in ur morning ? | 15:38 |
| SridarK | lets clean up anything else we need to get in | 15:39 |
| SridarK | yushiro: if nothing else to discuss now - i will step away to get ready to head to the office | 15:39 |
| yushiro | SridarK, sure. Thanks for your kindness :) I'll online tomorrow's afternoon | 15:40 |
| SridarK | yushiro: no worries at all thank u for all the work - lets talk then | 15:40 |
| SridarK | Good night | 15:40 |
| yushiro | good night ! | 15:40 |
| *** chandanc has quit IRC | 16:07 | |
| *** vishwana_ has quit IRC | 16:18 | |
| *** vishwanathj has joined #openstack-fwaas | 16:19 | |
| *** SridarK has quit IRC | 16:55 | |
| *** yushiro has quit IRC | 17:25 | |
| *** yamamoto has joined #openstack-fwaas | 21:17 | |
| *** yamamoto has quit IRC | 21:21 | |
| *** SridarK has joined #openstack-fwaas | 21:21 | |
| *** yamamoto has joined #openstack-fwaas | 21:21 | |
| *** yamamoto has quit IRC | 21:26 | |
| *** yamamoto has joined #openstack-fwaas | 22:23 | |
| *** yamamoto has quit IRC | 22:25 | |
| *** yamamoto has joined #openstack-fwaas | 22:25 | |
| *** Tim_Eberhard has quit IRC | 23:02 | |
| -openstackstatus- NOTICE: osic nodes have been removed from nodepool due to a problem with the mirror host beginning around 22:20 UTC. please recheck any jobs with failures installing packages. | 23:46 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!