| *** amotoki_away is now known as amotoki | 00:37 | |
| *** amotoki is now known as amotoki_away | 00:52 | |
| *** yamamoto has joined #openstack-fwaas | 01:15 | |
| *** yamamoto has quit IRC | 01:18 | |
| *** yamamoto has joined #openstack-fwaas | 01:18 | |
| *** yamamoto has quit IRC | 01:23 | |
| *** yamamoto has joined #openstack-fwaas | 01:26 | |
| *** yamamoto has quit IRC | 02:23 | |
| *** yamamoto has joined #openstack-fwaas | 02:26 | |
| *** amotoki_away is now known as amotoki | 02:44 | |
| *** amotoki is now known as amotoki_away | 02:53 | |
| *** amotoki_away is now known as amotoki | 03:44 | |
| *** yamamoto has quit IRC | 03:47 | |
| *** amotoki is now known as amotoki_away | 03:54 | |
| *** amotoki_away is now known as amotoki | 04:45 | |
| *** yamamoto has joined #openstack-fwaas | 04:47 | |
| *** yamamoto has quit IRC | 04:55 | |
| *** amotoki is now known as amotoki_away | 04:55 | |
| *** reedip_ has joined #openstack-fwaas | 05:14 | |
| *** amotoki_away is now known as amotoki | 05:37 | |
| reedip_ | amotoki : https://review.openstack.org/#/c/478719/17 updated | 06:05 |
|---|---|---|
| amotoki | reedip_: I am not sure what was done for L.66 https://review.openstack.org/#/c/478719/17/neutron_lib/exceptions/firewall_v2.py@66 | 06:10 |
| amotoki | reedip_: should I file a bug against fwaas? | 06:10 |
| reedip_ | checking | 06:11 |
| reedip_ | amotoki : Please check https://review.openstack.org/#/c/478719/17..18/neutron_lib/exceptions/firewall_v2.py | 06:12 |
| amotoki | according to the description, this is a case where 404 should be raised. if correct, FirewallPolicyConflict would be unncessary. | 06:12 |
| reedip_ | oh ok, so the name is causing confusion ? | 06:13 |
| amotoki | reedip_: I wonder why FirewallPolicyConflict is needed to raise a wrong exception (409 is incorrect API behavior and 404 should be returned) | 06:13 |
| reedip_ | amotoki : Sorry, I changed it NotFound, but seems like I forgot to save it | 06:14 |
| amotoki | reedip_: in this case, a requested firewall policy is not visible to a requester. | 06:14 |
| reedip_ | the next exception was correct | 06:14 |
| amotoki | reedip_: ah, i just saw the class name (not a base class) | 06:14 |
| reedip_ | amotoki : oh ok | 06:15 |
| amotoki | it seems worth filing a bug on fwaas to track the reason of the change | 06:15 |
| reedip_ | amotoki : so you consider not to have the Firewall PolicyCOnflict exception ? | 06:16 |
| amotoki | we have several ways: | 06:16 |
| reedip_ | as it can be taken care with FirewallPolicyNotFound exception ? | 06:16 |
| amotoki | (a) introduce a new exception FirewallPolicyNotFound inheriting NotFound | 06:16 |
| reedip_ | Already there in Line#46 ^^ | 06:16 |
| amotoki | (b) keep FirewallPolicyConflict and fix it as a bug in a separate effort. | 06:16 |
| amotoki | (c) do not introduce FirewallPolicyConflict and change the FWaaS v2 code | 06:17 |
| amotoki | thought? | 06:17 |
| reedip_ | Remove FirewallPolicyConflict exception. modify the message for FirewallPolicyNotFound so that it can be generic (handle the Not Found and Conflict scenario) | 06:18 |
| amotoki | reedip_: so do you agree (c) in my list above? | 06:19 |
| reedip_ | yes | 06:19 |
| reedip_ | If we are going to keep it as NotFound, then there is no need for a separate exception | 06:19 |
| amotoki | I think a bug is also needed for FWaaS v2 side | 06:19 |
| amotoki | in either way, I started to think it is beyond the scope of the migration | 06:20 |
| amotoki | so I started to think it can be fixed later. | 06:21 |
| amotoki | dropping FirewallPolicyConflict can make neutron-lib migration complicated. | 06:22 |
| amotoki | if you are okay, I do not put my -1 regarding this point. | 06:22 |
| reedip_ | amotoki : Okay, let me log a bug which can be modified later on | 06:23 |
| reedip_ | plus, others can also pitch it | 06:23 |
| amotoki | reedip_: I can do it if you want me to do it | 06:23 |
| reedip_ | it -> in * | 06:23 |
| reedip_ | amotoki : if you want to log the bug, then sure | 06:24 |
| reedip_ | please go ahead, thanks :) | 06:24 |
| amotoki | reedip_: sure. perhaps I should | 06:24 |
| amotoki | reedip_: another question: https://review.openstack.org/#/c/478719/17/neutron_lib/exceptions/firewall_v2.py@192 | 06:24 |
| amotoki | reedip_: a reserved name vs the reserved name | 06:24 |
| reedip_ | Yeah | 06:24 |
| amotoki | reedip_: I think 'default' is the only one name reserved by neutron-fwaas API | 06:25 |
| amotoki | so I suggested 'the' for it. | 06:25 |
| reedip_ | amotoki : yes, it is the Only one reserved. | 06:25 |
| reedip_ | makes sense, ok, I will change it | 06:25 |
| amotoki | thanks for clarification | 06:25 |
| reedip_ | I have updated the same | 06:28 |
| *** reedip_ has quit IRC | 06:57 | |
| *** bzhao has quit IRC | 07:26 | |
| *** bzhao has joined #openstack-fwaas | 07:27 | |
| *** yamamoto has joined #openstack-fwaas | 08:06 | |
| *** yamamoto has quit IRC | 08:08 | |
| *** yamamoto has joined #openstack-fwaas | 08:14 | |
| *** yamamoto has quit IRC | 08:18 | |
| *** yamamoto has joined #openstack-fwaas | 08:20 | |
| *** yamamoto has quit IRC | 08:20 | |
| *** reedip_ has joined #openstack-fwaas | 08:41 | |
| *** yamamoto has joined #openstack-fwaas | 08:42 | |
| *** yamamoto has quit IRC | 08:45 | |
| *** yamamoto has joined #openstack-fwaas | 08:46 | |
| *** yamamoto has quit IRC | 08:52 | |
| *** reedip_ has quit IRC | 08:52 | |
| *** yamamoto has joined #openstack-fwaas | 09:00 | |
| *** yamamoto has quit IRC | 09:08 | |
| *** yamamoto has joined #openstack-fwaas | 09:35 | |
| *** bzhao has quit IRC | 10:24 | |
| *** bzhao has joined #openstack-fwaas | 10:24 | |
| *** yamamoto has quit IRC | 10:52 | |
| *** yamamoto has joined #openstack-fwaas | 10:54 | |
| *** yamamoto has quit IRC | 10:57 | |
| *** yamamoto has joined #openstack-fwaas | 10:57 | |
| *** yamamoto has quit IRC | 11:01 | |
| *** yamamoto has joined #openstack-fwaas | 11:11 | |
| *** yamamoto has quit IRC | 11:11 | |
| *** yamamoto has joined #openstack-fwaas | 11:29 | |
| *** yamamoto has quit IRC | 12:25 | |
| *** yamamoto has joined #openstack-fwaas | 12:31 | |
| *** yamamoto has quit IRC | 12:36 | |
| *** yamamoto has joined #openstack-fwaas | 13:01 | |
| *** yamamoto has quit IRC | 13:06 | |
| *** yamamoto has joined #openstack-fwaas | 13:31 | |
| *** yamamoto has quit IRC | 13:35 | |
| *** reedip_ has joined #openstack-fwaas | 14:09 | |
| *** yamamoto has joined #openstack-fwaas | 14:16 | |
| *** yamamoto has quit IRC | 14:20 | |
| *** bzhao has quit IRC | 14:59 | |
| *** yamamoto has joined #openstack-fwaas | 15:16 | |
| *** reedip_ has quit IRC | 15:20 | |
| *** yamamoto has quit IRC | 15:21 | |
| *** openstackgerrit has joined #openstack-fwaas | 23:58 | |
| openstackgerrit | Akihiro Motoki proposed openstack/neutron-fwaas-dashboard master: Import FWaaS policy file from Horizon https://review.openstack.org/481867 | 23:58 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!