| *** Tim_Eberhard has quit IRC | 00:18 | |
| *** hoangcx has quit IRC | 00:20 | |
| *** trungnv has quit IRC | 00:20 | |
| *** Tim_Eberhard has joined #openstack-fwaas | 00:22 | |
| *** trungnv has joined #openstack-fwaas | 00:34 | |
| *** hoangcx has joined #openstack-fwaas | 00:34 | |
| *** cuongnv has joined #openstack-fwaas | 00:57 | |
| *** amotoki is now known as amotoki_away | 00:58 | |
| *** amotoki_away is now known as amotoki | 00:58 | |
| *** Tim_Eberhard has quit IRC | 01:02 | |
| *** trungnv has quit IRC | 01:58 | |
| *** hoangcx has quit IRC | 01:58 | |
| *** cuongnv has quit IRC | 01:59 | |
| *** yamamoto has joined #openstack-fwaas | 02:49 | |
| *** trungnv has joined #openstack-fwaas | 03:04 | |
| *** hoangcx has joined #openstack-fwaas | 03:06 | |
| *** reedip has quit IRC | 03:09 | |
| *** amotoki is now known as amotoki_away | 03:47 | |
| *** yamamoto has quit IRC | 03:50 | |
| *** yamamoto has joined #openstack-fwaas | 03:53 | |
| *** cuongnv has joined #openstack-fwaas | 03:58 | |
| *** amotoki_away is now known as amotoki | 04:15 | |
| *** amotoki is now known as amotoki_away | 04:36 | |
| *** Tim_Eberhard has joined #openstack-fwaas | 04:47 | |
| *** amotoki_away is now known as amotoki | 04:47 | |
| *** lnicolas has quit IRC | 04:51 | |
| *** Tim_Eberhard has quit IRC | 05:17 | |
| *** Tim_Eberhard has joined #openstack-fwaas | 05:18 | |
| *** Tim_Eberhard has quit IRC | 05:23 | |
| *** reedip has joined #openstack-fwaas | 06:13 | |
| reedip | amotoki : If you have time, can you please review https://review.openstack.org/#/c/478719/ , we have updated it as per your reviews | 06:14 |
|---|---|---|
| *** yushiro has joined #openstack-fwaas | 06:26 | |
| *** Tim_Eberhard has joined #openstack-fwaas | 06:29 | |
| *** Tim_Eberhard has quit IRC | 06:33 | |
| *** trungnv has quit IRC | 06:54 | |
| yushiro | reedip, hi | 07:43 |
| reedip | hello yushiro | 07:43 |
| reedip | how can I help you | 07:44 |
| yushiro | regarding https://review.openstack.org/#/c/478719/ , did you discuss with akihiro about that? Could you tell me some result? We do not separate file with fwaas_v1 and fwaas_v2? | 07:44 |
| amotoki | yushiro: i have no reply from the review. I am not sure how it was discussed and proposed the current version. | 07:45 |
| *** openstackgerrit has quit IRC | 07:48 | |
| yushiro | amotoki, Yes, so, I'd like to confirm with reedip. | 07:48 |
| *** trungnv has joined #openstack-fwaas | 08:12 | |
| reedip | yushiro : as of now , I think we can move forward with a single file ( however, its jsut a thought) | 08:33 |
| *** yamamoto has quit IRC | 09:20 | |
| yushiro | reedip, sorry, I just come back. | 09:21 |
| reedip | lucky, I was leaving :) | 09:21 |
| *** yamamoto has joined #openstack-fwaas | 09:22 | |
| yushiro | reedip, so, you reflected all comment from amotoki except splitting file? | 09:23 |
| reedip | yep | 09:24 |
| reedip | except that and the FirewallRuleConflict | 09:24 |
| yushiro | reedip, OK, so, I'll take a look more not to confuse b/w v1 and v2 exception. | 09:24 |
| reedip | sure | 09:25 |
| amotoki | i am not sure we need docstring for all exceptions. as quick look, most docstring and message have very similar description | 09:25 |
| amotoki | is it worth having duplicated strings? or is only message enough? | 09:25 |
| amotoki | I would like to know your opinions from the point of view of FWaaS exception definition | 09:25 |
| amotoki | I am necessarily suggest to add docstring. either choice is okay unless most of them have duplicated similar strings. | 09:27 |
| yushiro | amotoki, yes. I think all of exceptions should have docstring and easy to understand their purpose and usage. | 09:30 |
| amotoki | yushiro: even though _message and docstring have almost same content? | 09:30 |
| *** Tim_Eberhard has joined #openstack-fwaas | 09:31 | |
| *** Tim_Eberhard has quit IRC | 09:35 | |
| *** amotoki is now known as amotoki_away | 09:36 | |
| *** cuongnv has quit IRC | 10:15 | |
| *** hoangcx has quit IRC | 10:25 | |
| *** trungnv has quit IRC | 10:25 | |
| *** Tim_Eberhard has joined #openstack-fwaas | 10:32 | |
| *** Tim_Eberhard has quit IRC | 10:37 | |
| *** yamamoto has quit IRC | 10:45 | |
| *** yamamoto has joined #openstack-fwaas | 10:46 | |
| yushiro | amotoki, ah, TBH, I think totally similar exceptions should be integrated. However, currently it is transition period. 1. migration to neutron-lib, 2. fwaas v1 and v2 are supported. | 10:46 |
| *** yamamoto has quit IRC | 10:46 | |
| yushiro | amotoki_away, Therefore, I don't want to occur regression for v1. | 10:46 |
| yushiro | amotoki_away, So, we shuld keep v1 exceptions and take care not to confuse b/w v1 and v2. In order not to confuse, docstring is necessary. That's my answer. | 10:47 |
| yushiro | althgouh you are away :) | 10:47 |
| *** hoangcx has joined #openstack-fwaas | 11:15 | |
| *** trungnv has joined #openstack-fwaas | 11:15 | |
| *** mestery has quit IRC | 11:22 | |
| *** mestery has joined #openstack-fwaas | 11:26 | |
| *** yamamoto has joined #openstack-fwaas | 11:46 | |
| *** yamamoto has quit IRC | 11:50 | |
| *** yamamoto has joined #openstack-fwaas | 11:50 | |
| *** yamamoto has quit IRC | 11:53 | |
| *** yamamoto has joined #openstack-fwaas | 12:10 | |
| *** yamamoto has quit IRC | 12:19 | |
| *** yamamoto has joined #openstack-fwaas | 12:23 | |
| *** yamamoto has quit IRC | 12:28 | |
| *** Tim_Eberhard has joined #openstack-fwaas | 12:33 | |
| *** Tim_Eberhard has quit IRC | 12:38 | |
| *** yamamoto has joined #openstack-fwaas | 12:59 | |
| *** amotoki_away is now known as amotoki | 14:02 | |
| *** yushiro has quit IRC | 14:29 | |
| *** openstackgerrit has joined #openstack-fwaas | 14:36 | |
| openstackgerrit | Merged openstack/neutron-fwaas-dashboard master: Consume horizon master https://review.openstack.org/476413 | 14:36 |
| -openstackstatus- NOTICE: We have switched now all docs publishing jobs to new documentation builds. For details see dhellmann's email http://lists.openstack.org/pipermail/openstack-dev/2017-July/119221.html . For problems, join us on #openstack-doc | 14:37 | |
| *** Tim_Eberhard has joined #openstack-fwaas | 15:14 | |
| -openstackstatus- NOTICE: "We're experiencing a few problems with the reorg on docs.openstack.org and are looking into these..." | 15:16 | |
| *** ChanServ changes topic to ""We're experiencing a few problems with the reorg on docs.openstack.org and are looking into these..."" | 15:16 | |
| *** Tim_Eberhard has quit IRC | 15:18 | |
| *** yamamoto has quit IRC | 15:28 | |
| *** Tim_Eberhard has joined #openstack-fwaas | 15:30 | |
| *** yamamoto has joined #openstack-fwaas | 15:31 | |
| *** ChanServ changes topic to "#openstack-fwaas" | 15:35 | |
| -openstackstatus- NOTICE: "docs.openstack.org is working fine again, due to move of new location, each repo needs to merge one change to appear on docs.o.o" | 15:35 | |
| *** yamamoto has quit IRC | 15:36 | |
| openstackgerrit | Merged openstack/neutron-fwaas master: use plugin constants from neutron-lib https://review.openstack.org/473878 | 15:38 |
| *** amotoki is now known as amotoki_away | 16:17 | |
| *** yamamoto has joined #openstack-fwaas | 16:33 | |
| *** yamamoto has quit IRC | 16:39 | |
| *** Tim_Eberhard has quit IRC | 17:15 | |
| *** Tim_Eberhard has joined #openstack-fwaas | 17:23 | |
| *** Tim_Eberhard has quit IRC | 18:46 | |
| *** Tim_Eberhard has joined #openstack-fwaas | 18:50 | |
| *** Tim_Eberhard has quit IRC | 18:55 | |
| *** Tim_Eberhard has joined #openstack-fwaas | 19:53 | |
| *** Tim_Eberhard has quit IRC | 19:58 | |
| *** Tim_Eberhard has joined #openstack-fwaas | 20:39 | |
| *** Tim_Eberhard has quit IRC | 21:13 | |
| *** trungnv has quit IRC | 23:35 | |
| *** hoangcx has quit IRC | 23:35 | |
| *** yushiro has joined #openstack-fwaas | 23:43 | |
| *** Tim_Eberhard has joined #openstack-fwaas | 23:43 | |
| *** Tim_Eberhard has quit IRC | 23:48 | |
| *** trungnv has joined #openstack-fwaas | 23:49 | |
| *** hoangcx has joined #openstack-fwaas | 23:49 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!