*** amotoki is now known as amotoki_away | 00:17 | |
*** amotoki_away is now known as amotoki | 00:18 | |
*** amotoki is now known as amotoki_away | 00:27 | |
openstackgerrit | Yushiro FURUKAWA proposed openstack/neutron-fwaas master: Remove log translations https://review.openstack.org/479102 | 00:50 |
---|---|---|
*** cuongnv has joined #openstack-fwaas | 00:58 | |
*** amotoki_away is now known as amotoki | 01:23 | |
openstackgerrit | Yushiro FURUKAWA proposed openstack/neutron-fwaas master: Remove log translations https://review.openstack.org/479102 | 01:56 |
openstackgerrit | Yushiro FURUKAWA proposed openstack/neutron-fwaas master: Handle rehome of firewall exceptions https://review.openstack.org/478363 | 02:39 |
openstackgerrit | Yushiro FURUKAWA proposed openstack/neutron-fwaas master: Use API Definitions from Neutron-Lib https://review.openstack.org/478883 | 02:42 |
reedip | yushiro :good morning :) I have made the neutron-lib ON TOP of the exceptions patch ( you can see it on the right hand side ) Thats why I didnt need the Depends-On | 02:44 |
yushiro | reedip, oh, sorry. I didn't noticed. | 02:46 |
reedip | was there a pep8 error ? I didnt see it yesterday :P) | 02:46 |
reedip | no issues yushiro | 02:47 |
yushiro | reedip, yes, 1 nit pep8 error. just fixed. | 02:47 |
reedip | Lets first complete the neutron-lib and fwaas patch for exception, then we will push the neutron-lib migration and midonet patch | 02:47 |
yushiro | reedip, OK, thanks. | 02:47 |
reedip | yushiro : but we need to change the parent revision for neutron-lib | 02:48 |
openstackgerrit | Reedip proposed openstack/neutron-fwaas master: Use API Definitions from Neutron-Lib https://review.openstack.org/478883 | 02:49 |
reedip | done :) | 02:49 |
yushiro | thanks | 02:51 |
openstackgerrit | Van Hung Pham proposed openstack/neutron-fwaas master: Switch from oslosphinx to openstackdocstheme https://review.openstack.org/478750 | 02:59 |
*** vks1 has joined #openstack-fwaas | 03:01 | |
*** yamamoto has joined #openstack-fwaas | 03:05 | |
reedip | yushiro : the fwaas patches cannot understand neutron_lib.exceptions | 03:45 |
reedip | seems like the depends-on didnt work | 03:45 |
yushiro | yes, something wrong? but it looks depends-on doesn't work correctly. | 03:46 |
yushiro | I'm checking now | 03:46 |
yushiro | about that. | 03:46 |
yushiro | http://logs.openstack.org/02/479102/2/check/gate-neutron-fwaas-v2-dsvm-tempest/ee4ed95/logs/devstack-early.txt.gz | 03:49 |
yushiro | GITREPO["neutron-lib"]=git://git.openstack.org/openstack/neutron-lib.git | 03:49 |
yushiro | GITBRANCH["neutron-lib"]=master | 03:49 |
yushiro | wow | 03:50 |
yamamoto | hi, do you want me help something? i just saw a few occurrences of "midonet" in the backlog. | 03:53 |
reedip | yamamoto : we are trying to migrate to neutron-lib again . | 04:08 |
reedip | and trying to check its impact on midonet | 04:08 |
reedip | dont want things to be broken like they were earlier :) | 04:08 |
*** vks1 has quit IRC | 04:49 | |
*** vks1 has joined #openstack-fwaas | 05:06 | |
yamamoto | reedip: did you figure out "race in midonet"? did you file a bug? | 05:33 |
reedip | yamamoto : no, I didnt. I will, if the new patch fails . I didnt think it to be useful once the revert was complete | 05:36 |
reedip | yamamoto san , can you confirm if this issue is still occuring ? https://bugs.launchpad.net/networking-midonet/+bug/1700454 | 05:37 |
openstack | Launchpad bug 1700454 in networking-midonet ""Quota exceeded for instances" in fwaas tempest tests" [Critical,In progress] - Assigned to YAMAMOTO Takashi (yamamoto) | 05:37 |
reedip | after the neutron-lib patch was reverted for fwaas | 05:37 |
reedip | just want to make sure that the neutron-lib change was not a reason for this bug | 05:37 |
yushiro | reedip, Hi. about fwaas exception in neutron-lib | 05:57 |
yushiro | reedip, I got a comment from akihiro with some concering about separating v1 and v2. | 05:58 |
yushiro | "Don't we need to have separate exception modules for FWaaS v1 and v2? I am afraid that consumers of the exception modules might be confused and FWaaS v1/v2 exceptions are used in a mixed way. | 05:59 |
amotoki | yushiro: reedip: I am not sure how much v1 and v2 has common stuffs... my comment is generic one, so I am not sure my comment is reasonable or not. | 06:00 |
yushiro | amotoki, OK. but I'd like to consider your comment. Though v1 will be deprecated, currently it is still maintained. So, I think we should separate file(e.g. fwaas_v1.py, fwaas_v2.py in neutron_lib/exceptions) | 06:02 |
reedip | amotoki : I think that the exception messages are pretty generic which can be used by both v1 and v2 . However, the exceptions raised by fwaas_V1 and fwaas_v2 implementation are different.so yes, combining them together may cause the new consumers of fwaas some effort to read the actual fwaas implementation | 06:12 |
yushiro | reedip, I see. I'll update it. | 06:12 |
amotoki | reedip: if the expected usages are differnt between v1 and v2, i think it is better to be separate module. | 06:13 |
openstackgerrit | Ritesh proposed openstack/neutron-fwaas master: Replace the usage of 'admin_manager' with 'os_admin' https://review.openstack.org/479183 | 06:49 |
*** vks1 has quit IRC | 07:19 | |
reedip | amotoki: the exceptions defined for fwaas v1 , can be used by fwaas v2 as well. the exceptions are generic. | 07:35 |
amotoki | reedip: if the usage (the condition where an individual exception is raised) is exactly same, you can share both versions. | 07:36 |
amotoki | reedip: if the usage is different and you re-use existing one, i do no think it is a good idea. | 07:36 |
amotoki | it is based on the fact the exception description defines exact confidition when an exception is raised. | 07:37 |
yamamoto | reedip: i haven't seen the symptom laterly. maybe it's fixed in somewhere. i don't think it's related to the fwaas revert. | 08:46 |
*** yamamoto has quit IRC | 09:35 | |
*** yamamoto has joined #openstack-fwaas | 09:36 | |
*** yamamoto has quit IRC | 09:38 | |
*** yamamoto has joined #openstack-fwaas | 09:42 | |
*** yamamoto has quit IRC | 09:42 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/neutron-fwaas-dashboard master: Imported Translations from Zanata https://review.openstack.org/479230 | 09:44 |
*** vks1 has joined #openstack-fwaas | 09:45 | |
*** yamamoto has joined #openstack-fwaas | 09:46 | |
*** yamamoto has quit IRC | 09:51 | |
*** vks1 has quit IRC | 10:00 | |
*** trungnv has quit IRC | 10:03 | |
*** trungnv has joined #openstack-fwaas | 10:05 | |
*** yamamoto has joined #openstack-fwaas | 10:10 | |
*** yamamoto has quit IRC | 10:12 | |
*** yamamoto has joined #openstack-fwaas | 10:13 | |
*** yamamoto has quit IRC | 10:16 | |
*** yamamoto has joined #openstack-fwaas | 10:16 | |
*** yamamoto has quit IRC | 10:18 | |
*** yushiro has quit IRC | 10:33 | |
*** yamamoto has joined #openstack-fwaas | 10:52 | |
*** cuongnv has quit IRC | 10:54 | |
*** amotoki is now known as amotoki_away | 11:11 | |
openstackgerrit | Ritesh proposed openstack/neutron-fwaas master: Drop MANIFEST.in - it's not needed by pbr https://review.openstack.org/479260 | 11:15 |
openstackgerrit | Merged openstack/neutron-fwaas master: use service type constants from neutron_lib plugins https://review.openstack.org/478240 | 11:32 |
*** yamamoto has quit IRC | 11:34 | |
*** yamamoto has joined #openstack-fwaas | 11:36 | |
openstackgerrit | Merged openstack/neutron-fwaas master: Enable to set neutron's local repository for testing https://review.openstack.org/468398 | 11:44 |
*** yamamoto has quit IRC | 11:58 | |
*** amotoki_away is now known as amotoki | 12:19 | |
*** yamamoto has joined #openstack-fwaas | 12:26 | |
openstackgerrit | Merged openstack/neutron-fwaas master: Replace the usage of 'manager' with 'os_primary' https://review.openstack.org/476329 | 12:43 |
*** yamamoto has quit IRC | 12:55 | |
*** yamamoto has joined #openstack-fwaas | 12:56 | |
*** yamamoto has quit IRC | 13:01 | |
*** yamamoto has joined #openstack-fwaas | 13:58 | |
*** reedip_ has joined #openstack-fwaas | 13:59 | |
*** amotoki is now known as amotoki_away | 14:04 | |
*** yamamoto has quit IRC | 14:10 | |
*** reedip_ has quit IRC | 14:18 | |
*** vks1 has joined #openstack-fwaas | 14:22 | |
*** vks1 has quit IRC | 14:50 | |
*** vks1 has joined #openstack-fwaas | 15:04 | |
*** lnicolas has quit IRC | 15:24 | |
*** Tim_Eberhard has joined #openstack-fwaas | 15:57 | |
*** reedip_ has joined #openstack-fwaas | 17:35 | |
*** vks1 has quit IRC | 18:02 | |
*** reedip_ has quit IRC | 18:29 | |
*** Tim_Eberhard has quit IRC | 21:08 | |
*** Tim_Eberhard has joined #openstack-fwaas | 22:29 | |
*** Tim_Eberhard has quit IRC | 22:41 | |
*** Tim_Eberhard has joined #openstack-fwaas | 23:27 | |
*** lnicolas has joined #openstack-fwaas | 23:45 | |
*** Tim_Eberhard has quit IRC | 23:50 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!