| *** SridarK has quit IRC | 00:39 | |
| *** hoangcx has joined #openstack-fwaas | 00:49 | |
| *** chandanc_ has joined #openstack-fwaas | 01:17 | |
| *** xgerman has joined #openstack-fwaas | 01:24 | |
| njohnston | yushiro: ping | 01:25 |
|---|---|---|
| yushiro | njohnston, pong | 01:26 |
| yushiro | hi | 01:26 |
| njohnston | Good morning! I was wondering if you could take a look at https://bugs.launchpad.net/neutron/+bug/1661418 - I have been looking at it today but without success. | 01:26 |
| openstack | Launchpad bug 1661418 in neutron "neutron-fwaas functional tests do not execute" [Critical,Confirmed] | 01:26 |
| njohnston | I tried looking at the changes in the tox configuration and the test configuration between master and stable/newton to see what changed, but I did not find the source there. | 01:27 |
| *** chandanc_ has quit IRC | 01:28 | |
| njohnston | Then I tried looking at the differences between the neutron tox config and the neutron-fwaas tox config to see if there was something missing for fwaas, but I was not able to find the problem there | 01:28 |
| njohnston | But this is keeping neutron-fwaas from releasing an ocata version, so it is an urgent thing | 01:29 |
| yushiro | njohnston, OK. it's urgent.. I'll check it now. | 01:29 |
| njohnston | yushiro: I have every confidence that you can do it! But if you aren't able to, then just ping me with what you tried that didn't work, and I can continue in the morning. | 01:31 |
| yushiro | njohnston, OK. Thank you. | 01:31 |
| njohnston | yushiro: Thank you! | 01:31 |
| yushiro | njohnston, You're welcome. BTW, sorry for slow progress for my default fwg / l2 agent patch :( | 01:32 |
| njohnston | That's all right, I know it is a complex issue, especially with testing. | 01:32 |
| yushiro | :) BTW njohnston , what time is it now for your timezone? | 01:33 |
| njohnston | It is 20:33 here. | 01:33 |
| yushiro | I see. I'll ping you ASAP. | 01:34 |
| *** chandanc_ has joined #openstack-fwaas | 01:41 | |
| *** chandanc_ has quit IRC | 01:47 | |
| yushiro | njohnston, I found that(maybe you also found) stable/newton's environment has some environment values as follows: | 01:55 |
| yushiro | http://logs.openstack.org/03/425003/1/check/gate-neutron-fwaas-dsvm-functional/35cae70/console.html.gz#_2017-01-25_10_04_05_550936 | 01:56 |
| yushiro | OS_STDOUT_CAPTURE and so on. | 01:56 |
| yushiro | njohnston, On the other hand, master(ocata) environment doesn't have such as values: | 01:57 |
| yushiro | http://logs.openstack.org/51/424551/13/check/gate-neutron-fwaas-dsvm-functional/2596d9d/console.html.gz#_2017-02-02_09_09_31_079823 | 01:57 |
| yushiro | njohnston, So, I consider that whether ".testr.conf" exists or not. | 01:57 |
| yushiro | This is my quick research. I'll dig more. | 01:58 |
| yushiro | sorry. Environment values exists but "--load-list" are missing. | 02:06 |
| *** chandanc_ has joined #openstack-fwaas | 02:54 | |
| yushiro | I'll take a lunch! | 03:00 |
| *** yushiro is now known as yushiro_lunch | 03:00 | |
| *** mickeys has quit IRC | 03:04 | |
| *** mickeys has joined #openstack-fwaas | 03:10 | |
| *** yushiro_lunch has quit IRC | 03:37 | |
| *** lnicolas1 has joined #openstack-fwaas | 04:01 | |
| *** yushiro has joined #openstack-fwaas | 04:01 | |
| *** mickeys has quit IRC | 05:23 | |
| *** lnicolas1 has quit IRC | 06:01 | |
| *** mickeys has joined #openstack-fwaas | 06:05 | |
| *** mickeys has quit IRC | 07:06 | |
| *** yamamoto has quit IRC | 07:38 | |
| yushiro | ping reedip | 07:42 |
| reedip | pong ! | 07:42 |
| reedip | :) | 07:42 |
| yushiro | super quick :) | 07:42 |
| yushiro | Hello | 07:42 |
| yushiro | I'm focusing on https://bugs.launchpad.net/neutron/+bug/1661418 | 07:43 |
| openstack | Launchpad bug 1661418 in neutron "neutron-fwaas functional tests do not execute" [Critical,Confirmed] | 07:43 |
| yushiro | That's strange behavior. I'd like to run "tox -e dsvm-functional" but no test executed. | 07:44 |
| yushiro | reedip, Please tell me if you know something :) "strange" what I thought was as folloing behavior: | 07:45 |
| reedip | can you run tox -e functional ? | 07:45 |
| reedip | What you are trying to run is the functional tests, right? | 07:45 |
| reedip | wait, lemme pull up the issue as well | 07:46 |
| reedip | yushiro : have we seen logstash ? | 07:47 |
| reedip | how many times has this bug been reproduced ? | 07:47 |
| reedip | I have seen this type of issue on my local machine when pgsql / mysql is not running | 07:47 |
| reedip | but it generally passes the jenkins gate | 07:48 |
| reedip | woahh, sorry, I see that the newton is running, ocata isnt | 07:48 |
| reedip | wait | 07:48 |
| yushiro | I think it occurs 100% with master(ocata) branch. yeah. | 07:48 |
| yushiro | reedip, Here is a result in my local devstack. http://paste.openstack.org/show/597900/ | 07:49 |
| reedip | interesting to see that the functional tests didnt seem to run in this case | 07:50 |
| yushiro | Running with 'tox' => not running Running with command directly => running correctly. | 07:50 |
| yushiro | reedip, yeah it's strange. | 07:50 |
| reedip | yushiro, the second command is Unit test, not functional | 07:51 |
| reedip | see the paths | 07:51 |
| reedip | neutron_fwaas.tests.unit.services.firewall.test_fwaas_plugin_v2.TestFirewallPluginBasev2.test_update_firewall_group_with_new_ports_status_active 4.653 | 07:52 |
| yushiro | aha! wow. | 07:52 |
| yushiro | thanks. | 07:52 |
| reedip | yushiro : found the issue, I think | 08:01 |
| yushiro | reedip, wow.. great. | 08:02 |
| yushiro | tox.ini? | 08:02 |
| reedip | yushiro : no, there are no tests in functional folder actually | 08:04 |
| reedip | just checking it though | 08:07 |
| *** mickeys has joined #openstack-fwaas | 08:07 | |
| reedip | Like http://logs.openstack.org/52/429052/4/gate/gate-neutron-fwaas-dsvm-functional/23885f5/testr_results.html.gz has 3 tests | 08:07 |
| yushiro | reedip, OK. However, I've changed OS_TEST_PATH=./neutron_fwaas/tests/functional/db/ and not changed in this morning. | 08:07 |
| reedip | yushiro: in fact http://logs.openstack.org/08/427508/2/check/gate-neutron-fwaas-dsvm-functional/34ce465/testr_results.html.gz also has 3 tests included | 08:09 |
| reedip | yushiro: but http://logs.openstack.org/20/429920/1/check/gate-neutron-fwaas-dsvm-functional/82e6c35/testr_results.html.gz doesnt have the 3 tests | 08:11 |
| yushiro | reedip, I see. | 08:11 |
| *** mickeys has quit IRC | 08:11 | |
| *** mickeys has joined #openstack-fwaas | 08:11 | |
| reedip | Basically this file is missing https://github.com/openstack/neutron-fwaas/blob/stable/newton/neutron_fwaas/tests/functional/test_fwaas_driver.py | 08:12 |
| reedip | and thats because of https://review.openstack.org/#/c/404927/ | 08:12 |
| reedip | njohnston : once you have logged in, maybe we would need your inputs in the same | 08:13 |
| yushiro | reedip, Yeah. | 08:13 |
| reedip | njohnston, yushiro : I am going back in history to see if this change has made this impact, gimme some time | 08:14 |
| reedip | yushiro, njohnston : Following patches have been merged in branch AFTER the above commit | 08:15 |
| reedip | 1) http://logs.openstack.org/57/412257/2/check/gate-neutron-fwaas-dsvm-functional/95eaab6/testr_results.html.gz | 08:15 |
| reedip | 2)http://logs.openstack.org/74/416474/2/check/gate-neutron-fwaas-dsvm-functional/a3e6a83/testr_results.html.gz | 08:16 |
| reedip | 3)http://logs.openstack.org/54/412754/5/check/gate-neutron-fwaas-dsvm-functional/e466541/testr_results.html.gz | 08:17 |
| reedip | 4)http://logs.openstack.org/47/423047/1/check/gate-neutron-fwaas-dsvm-functional/e7e2887/testr_results.html.gz | 08:17 |
| reedip | 5)http://logs.openstack.org/16/424716/1/check/gate-neutron-fwaas-dsvm-functional/19ee0e8/testr_results.html.gz | 08:17 |
| reedip | All do not have the functional test cases | 08:17 |
| yushiro | reedip, OK. We should add at least 1 test code at the top of neutron_fwaas/tests/functional in order to execute 'dsvm-functional' test, shouldn't we? | 08:17 |
| reedip | yushiro : Yep | 08:18 |
| yushiro | like https://review.openstack.org/#/c/404927/1/neutron_fwaas/tests/functional/test_fwaas_driver.py | 08:18 |
| reedip | No we cannot add that yushiro, as it does nothing | 08:19 |
| yushiro | ah sorry. it shouldn't add the same test code and should add alternative code. | 08:20 |
| reedip | Yes | 08:21 |
| reedip | yushiro: you creating a test case for this ? | 08:29 |
| yushiro | reedip, Let me see.., currently we don't have much time for this cycle. Therefore, If you don't mind, I'll upload a patch with you as co-authored-by. What do you think? | 08:30 |
| reedip | yushiro : I dont mind, but then we can update this bug report with this information, so that Armando and others know that this was kind of intentional | 08:31 |
| yushiro | Aha, yes. It is necessary. | 08:32 |
| *** yamamoto has joined #openstack-fwaas | 08:32 | |
| reedip | yushiro : done, now test case addition can be a call by SridarK and njohnston when they come online | 08:33 |
| yushiro | reedip, Thank you. Currently, I've added dummy test code and executed 'tox -e dsvm-functional'. Then, the test ran correctly. | 08:34 |
| yushiro | However, only 1 test code loaded and never ran functional/db/test_*.py codes.. | 08:35 |
| yushiro | Am I missing something? I'll dig more. | 08:35 |
| reedip | yushiro : there are no calls for functional/db | 08:37 |
| reedip | test cases | 08:37 |
| reedip | I think we need to track this separately ( growth of functional test cases in FWaaS) | 08:38 |
| yushiro | reedip, wow. | 08:38 |
| reedip | Assigned the bug to you for now. So that you can put the patch for it :) | 08:39 |
| yushiro | reedip, OK. I'll add it. Thanks. As you know, I'm not good at writing English document. Please take a look after I posted the patch :) | 08:41 |
| reedip | np yushiro | 08:41 |
| yushiro | reedip, in neutron_fwaas/tests/functional/db/test_migrations.py , _TestModelsMigrationsFwaaS inherits from neutron.tests.functional.db.test_migrations._TestModelsMigrations. I wonder why this class doesn't call parent test method? | 09:19 |
| yushiro | just a curious. | 09:20 |
| yushiro | reedip, I just uploaded. Sorry for late: https://review.openstack.org/430148 Add functional test to run dsvm-functional | 09:27 |
| yushiro | I'll go for dinner and turn back ASAP. | 09:27 |
| *** yushiro is now known as yushiro_dinner | 09:27 | |
| reedip | sure yushiro | 09:29 |
| *** yamamoto has quit IRC | 09:30 | |
| *** yamamoto has joined #openstack-fwaas | 09:33 | |
| *** yamamoto has quit IRC | 09:39 | |
| *** mickeys has quit IRC | 09:53 | |
| *** hoangcx has quit IRC | 10:08 | |
| *** yushiro_dinner is now known as yushiro | 10:21 | |
| *** mickeys has joined #openstack-fwaas | 10:54 | |
| *** mickeys has quit IRC | 10:58 | |
| *** chandanc_ has quit IRC | 11:05 | |
| *** mickeys has joined #openstack-fwaas | 11:54 | |
| *** mickeys has quit IRC | 11:59 | |
| *** mickeys has joined #openstack-fwaas | 12:55 | |
| *** mickeys has quit IRC | 13:01 | |
| *** hoangcx has joined #openstack-fwaas | 13:36 | |
| *** amotoki has joined #openstack-fwaas | 13:44 | |
| *** chandanc_ has joined #openstack-fwaas | 13:57 | |
| *** mickeys has joined #openstack-fwaas | 13:57 | |
| *** chandanc_ has quit IRC | 14:00 | |
| *** chandanc_ has joined #openstack-fwaas | 14:01 | |
| *** mickeys has quit IRC | 14:02 | |
| *** SarathMekala has joined #openstack-fwaas | 14:02 | |
| *** mickeys has joined #openstack-fwaas | 14:58 | |
| *** yushiro has quit IRC | 15:00 | |
| *** SridarK has joined #openstack-fwaas | 15:00 | |
| SridarK | SarathMekala: ping | 15:01 |
| SarathMekala | hi SridarK | 15:02 |
| SarathMekala | the review link for tempest scenario tests https://review.openstack.org/#/c/391392/ | 15:02 |
| SridarK | on the cherry pick | 15:02 |
| *** mickeys has quit IRC | 15:03 | |
| SarathMekala | yes link git fetch ssh://SarathChandraMekala@review.openstack.org:29418/openstack/neutron-fwaas refs/changes/92/391392/11 && git cherry-pick FETCH_HEAD | 15:03 |
| SarathMekala | now? | 15:03 |
| SridarK | Do u see a Cherry Pick button below the block with Owner Reviewers etc | 15:04 |
| SridarK | to the left of the Revert button | 15:04 |
| SarathMekala | yes | 15:04 |
| SridarK | click on the Cherry Pick button | 15:04 |
| SarathMekala | done.. its asking the branch | 15:04 |
| SridarK | yes | 15:05 |
| SridarK | put in stable/newton | 15:05 |
| SarathMekala | ok | 15:05 |
| SarathMekala | done | 15:06 |
| SridarK | perfect | 15:06 |
| SarathMekala | new review link @ https://review.openstack.org/#/c/430292/ | 15:06 |
| SarathMekala | Shoud I open it for reviews here? | 15:06 |
| SridarK | hopefully there are not other dependencies | 15:06 |
| SridarK | lets wait on Jenkins | 15:07 |
| SarathMekala | ok | 15:07 |
| SarathMekala | I will track this and take care of any issues | 15:07 |
| SridarK | if Jenkins is good - then we can add more folks and hopefully get it in | 15:07 |
| SridarK | thx SarathMekala | 15:07 |
| SarathMekala | sure SridarK.. understand the flow now :) | 15:08 |
| SarathMekala | thanks | 15:08 |
| SridarK | no worries | 15:08 |
| SarathMekala | ok logging off now | 15:09 |
| SridarK | ok then catch up later, my dog clearly does not care abt fwaas and she is going crazy :-) | 15:09 |
| SridarK | ttyl | 15:09 |
| SarathMekala | ha ha :) | 15:09 |
| SarathMekala | bye | 15:09 |
| *** SarathMekala has quit IRC | 15:14 | |
| *** hoangcx has quit IRC | 15:24 | |
| *** mickeys has joined #openstack-fwaas | 15:59 | |
| *** mickeys has quit IRC | 16:03 | |
| *** reedip_ has joined #openstack-fwaas | 16:42 | |
| reedip_ | sorry guys , jsut got back | 16:42 |
| *** mickeys has joined #openstack-fwaas | 16:59 | |
| *** mickeys has quit IRC | 17:04 | |
| *** chandanc_ has quit IRC | 17:29 | |
| *** reedip_ has quit IRC | 17:31 | |
| *** chandanc_ has joined #openstack-fwaas | 17:52 | |
| *** mickeys has joined #openstack-fwaas | 18:00 | |
| *** chandanc_ has quit IRC | 18:04 | |
| *** mickeys has quit IRC | 18:05 | |
| *** SridarK has quit IRC | 18:20 | |
| *** faizy has joined #openstack-fwaas | 18:21 | |
| *** mickeys has joined #openstack-fwaas | 18:36 | |
| *** SridarK has joined #openstack-fwaas | 19:06 | |
| *** faizy has quit IRC | 19:16 | |
| *** mickeys has quit IRC | 20:24 | |
| *** reedip_ has joined #openstack-fwaas | 20:32 | |
| *** reedip_ has quit IRC | 20:35 | |
| *** mickeys has joined #openstack-fwaas | 20:42 | |
| *** amotoki has quit IRC | 20:51 | |
| *** yamamoto has joined #openstack-fwaas | 21:43 | |
| *** yamamoto has quit IRC | 22:07 | |
| *** yamamoto has joined #openstack-fwaas | 22:12 | |
| *** reedip_ has joined #openstack-fwaas | 23:35 | |
| *** reedip_ has quit IRC | 23:37 | |
| *** yushiro has joined #openstack-fwaas | 23:53 | |
| yushiro | morning. | 23:55 |
| yushiro | Thanks njohnston for dsvm-functional patch! | 23:55 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!