| SridarK | yushiro: hi no worries | 00:32 |
|---|---|---|
| yushiro | SridarK: Thanks. | 00:32 |
| SridarK | yushiro: thx for the review of the plugin | 00:32 |
| SridarK | i am doing some integration testing - with the agent - i think there are some things that need fixing there | 00:33 |
| yushiro | SridarK: no warries! | 00:34 |
| yushiro | SridarK: great! I'm reviewing mfranc213 patch and updating CLI patch. If you ask me to something, please let me know :) | 00:36 |
| yushiro | s/to/to do/ | 00:37 |
| SridarK | yushiro: ok great - let me leave some comments in gerrit | 00:37 |
| SridarK | so u dont hit the same issues if u pull things in devstack | 00:37 |
| SridarK | yamamoto: thx for ur patience - i hope things are resolved for u. And thx for pushing the patches out | 00:39 |
| yushiro | SridarK: I built devstack with master(yesterday) repositories and succeeded. I don't check with agents but I'll try it now. | 00:43 |
| yamamoto | SridarK: the issues settled for us now. thank you! | 00:44 |
| SridarK | yushiro: just hang on for a few mins - i am debugging this and will let u know so u dont hit the same issue, we have one issue where we pick up the the v1 agent | 00:44 |
| yushiro | SridarK: Sure :) | 00:45 |
| SridarK | yamamoto: no many thx for helping to take care of things | 00:45 |
| SridarK | yushiro: i specified some of the issues i saw - mfranc213 is on PTO - i will ask if chandanc can push a new rev. Since we have been doing the end to end testing - hopefully with this no other issues will crop up | 01:05 |
| *** vishwanathj has quit IRC | 01:11 | |
| yushiro | SridarK: Thanks for your information. I check it. | 01:22 |
| SridarK | yushiro: ok thx | 01:29 |
| SridarK | yushiro: i am heading back home from the office - will get online b4 our mtg | 01:30 |
| yushiro | SridarK: Sure. | 01:31 |
| *** SridarK has quit IRC | 01:47 | |
| *** mickeys has quit IRC | 02:17 | |
| *** chandanc_ has joined #openstack-fwaas | 02:55 | |
| njohnston | chandanc_: Are you working on SridarK's comments to https://review.openstack.org/#/c/337699/23/neutron_fwaas/services/firewall/agents/l3reference/firewall_l3_agent_v2.py@126 | 03:11 |
| *** vishwanathj has joined #openstack-fwaas | 03:11 | |
| chandanc_ | yes, just verifying the comments | 03:11 |
| chandanc_ | the rpc part is done, checking the dict problem now | 03:12 |
| njohnston | chandanc_: Excellent, thank you! | 03:13 |
| chandanc_ | nate, sure happy to be of help :) | 03:13 |
| *** vishwanathj is now known as vishwanathj_zzz | 03:19 | |
| njohnston | biab | 03:23 |
| *** yushiro has quit IRC | 03:38 | |
| njohnston | back | 03:48 |
| *** SarathMekala has joined #openstack-fwaas | 03:56 | |
| *** yushiro has joined #openstack-fwaas | 03:57 | |
| *** padkrish has joined #openstack-fwaas | 04:00 | |
| *** _SarathMekala_ has joined #openstack-fwaas | 04:07 | |
| *** _SarathMekala_ has quit IRC | 04:07 | |
| *** _SarathMekala_ has joined #openstack-fwaas | 04:07 | |
| *** _SarathMekala_ has quit IRC | 04:08 | |
| *** _SarathMekala_ has joined #openstack-fwaas | 04:08 | |
| *** SarathMekala has quit IRC | 04:10 | |
| *** yamamoto has quit IRC | 04:39 | |
| *** yamamoto has joined #openstack-fwaas | 04:39 | |
| *** yamamoto has quit IRC | 04:41 | |
| *** yamamoto has joined #openstack-fwaas | 04:42 | |
| *** yamamoto has quit IRC | 04:42 | |
| *** mickeys has joined #openstack-fwaas | 04:51 | |
| *** mickeys has quit IRC | 04:57 | |
| yushiro | I'm home. | 05:02 |
| njohnston | chandanc_: We never got a chance to talk about https://review.openstack.org/333338 "Make ip_conntrack.IpConntrackManager a singleton" | 05:02 |
| njohnston | chandanc_: How is that going? | 05:02 |
| chandanc_ | Hello njohnston | 05:02 |
| chandanc_ | yes, just fixing up the l3 comments from sridark | 05:02 |
| yushiro | ping padkrish | 05:03 |
| chandanc_ | njohnston, do you have anh question on conntrack patch | 05:03 |
| padkrish | yushiro# yes, i skimmed through https://review.openstack.org/#/c/323971/6 | 05:03 |
| njohnston | chandanc_: No, I just want to see how far away it is from being ready. Do you want me to take a look at the test failures in the morning? | 05:04 |
| chandanc_ | sure, that will help a lot | 05:04 |
| njohnston | must save maximum time for slow neutron reviews | 05:04 |
| chandanc_ | yes agree | 05:04 |
| njohnston | OK, I will devoute time to that in the morning. | 05:04 |
| njohnston | chandanc_: Please feel free to tap me to help, if help can be used. | 05:04 |
| padkrish | yushiro# handle_port needs more details like subnets etc from the plugin, right? | 05:05 |
| chandanc_ | njohnston, sure will do | 05:05 |
| chandanc_ | njohnston, i will be pushing a update on the l3 PS today | 05:06 |
| *** SridarK has joined #openstack-fwaas | 05:06 | |
| njohnston | chandanc_: I look forward to testing it out | 05:06 |
| chandanc_ | :) thanks | 05:06 |
| SridarK | njohnston: quick q b4 u head to bed | 05:06 |
| njohnston | yes SridarK> | 05:07 |
| njohnston | ? | 05:07 |
| SridarK | on the gate check for tempest | 05:07 |
| SridarK | shall we wait until we get the L3 Agent ext patch in | 05:07 |
| SridarK | sorry moving from non-voting | 05:07 |
| njohnston | SridarK: you mean https://review.openstack.org/359320 | 05:07 |
| njohnston | No, it will still be non-voting | 05:08 |
| SridarK | yes | 05:08 |
| SridarK | oh ok | 05:08 |
| njohnston | Currently it's in the check-experimental queue | 05:08 |
| njohnston | this would move it to the check queue | 05:08 |
| njohnston | so we would always see it's results | 05:08 |
| njohnston | but it would not affect gating if it misfired | 05:08 |
| SridarK | i was concerned as we will likely hit some speed bumps as we move to the new framework | 05:08 |
| njohnston | indeed, thats partially why I want to give this visibility... but not handicap us in the process | 05:09 |
| SridarK | njohnston: we can discuss more on the coexistence of v1, v2 etc tomorrow am | 05:09 |
| njohnston | sounds good, ping me when you are ready | 05:09 |
| SridarK | ok i just put a comment and no -1 | 05:10 |
| SridarK | we can sync tomorrow and i will also do a +1 | 05:10 |
| njohnston | ok | 05:10 |
| njohnston | thats good because I worry Ihar might think the comment "I would like to wait to open this up" is like a -1 | 05:10 |
| SridarK | njohnston: ok i am hoping my preface will be clear :-) | 05:11 |
| njohnston | :-) | 05:11 |
| njohnston | and on that note, I can not keep my eyes open any longer... talk to you all tomorrow | 05:11 |
| SridarK | no issues - i did not want to bug given the time - so i just put in a cautionary note in case it merged | 05:12 |
| SridarK | :-) | 05:12 |
| SridarK | GN | 05:12 |
| SridarK | chandanc_: hi | 05:12 |
| chandanc_ | Hello SridarK | 05:12 |
| SridarK | chandanc_: pls let me know if u had any clarifications on the comments | 05:12 |
| chandanc_ | SridarK, I found some more small issues | 05:13 |
| SridarK | chandanc_: ok | 05:13 |
| chandanc_ | I could verify the create workflow till the iptable rule generation | 05:13 |
| chandanc_ | now fixing the delete issues | 05:14 |
| SridarK | chandanc_: ok | 05:14 |
| chandanc_ | should we have a short call on the l2 driver | 05:14 |
| chandanc_ | or is it too late for you ? | 05:14 |
| SridarK | chandanc_: no we can do that | 05:14 |
| chandanc_ | should i login to the same webex link ? | 05:15 |
| SridarK | chandanc_: 2 mins | 05:16 |
| *** yamamoto has joined #openstack-fwaas | 05:39 | |
| *** mickeys has joined #openstack-fwaas | 05:53 | |
| *** mickeys has quit IRC | 05:58 | |
| *** chandanc_ has quit IRC | 06:23 | |
| *** padkrish has quit IRC | 06:26 | |
| yushiro | ping SridarK | 07:25 |
| *** _SarathMekala_ has quit IRC | 08:09 | |
| *** _SarathMekala_ has joined #openstack-fwaas | 08:29 | |
| *** mickeys has joined #openstack-fwaas | 08:40 | |
| *** mickeys has quit IRC | 08:43 | |
| *** _SarathMekala_ is now known as SarathMekala | 09:25 | |
| *** yushiro is now known as yushiro_dinner | 09:58 | |
| *** chandanc_ has joined #openstack-fwaas | 10:43 | |
| *** SarathMekala is now known as SarathMekala_Off | 11:02 | |
| *** SarathMekala_Off has quit IRC | 11:02 | |
| *** chandanc_ has quit IRC | 11:04 | |
| *** xdcc has joined #openstack-fwaas | 12:32 | |
| *** yamamoto has quit IRC | 12:50 | |
| *** vishwanathj_zzz is now known as vishwanthj | 13:03 | |
| *** yamamoto has joined #openstack-fwaas | 13:32 | |
| *** yamamoto has quit IRC | 13:40 | |
| *** yamamoto has joined #openstack-fwaas | 13:52 | |
| *** yamamoto has quit IRC | 14:20 | |
| *** chandanc_ has joined #openstack-fwaas | 14:34 | |
| *** yamamoto has joined #openstack-fwaas | 14:43 | |
| *** chandanc_ has quit IRC | 14:52 | |
| *** chandanc_ has joined #openstack-fwaas | 14:52 | |
| SridarK | chandanc_: hi | 15:08 |
| chandanc_ | Hello SridarK | 15:09 |
| SridarK | chandanc_: i think we ran into some UT failures | 15:09 |
| chandanc_ | sorry I am little out of context | 15:09 |
| chandanc_ | you mean the l3 patch ? | 15:09 |
| SridarK | chandanc_: sorry on the L3 Agent | 15:09 |
| SridarK | yes | 15:10 |
| chandanc_ | what change is causing the issue ? | 15:10 |
| SridarK | i am also juggling another mtg - shd be done soon - going thru the patch | 15:10 |
| chandanc_ | ok | 15:11 |
| *** yushiro_dinner has quit IRC | 15:12 | |
| SridarK | chandanc_: it seems like the cfg opt has some issues | 15:43 |
| SridarK | with the UT failures | 15:43 |
| chandanc_ | sorry was away | 15:52 |
| chandanc_ | I think as i have moved the opt registration to the cmd file UT is failing | 15:53 |
| SridarK | chandanc_: no prob | 15:55 |
| *** vishwanthj has quit IRC | 15:56 | |
| SridarK | yes it seems so | 15:56 |
| chandanc_ | SridarK, please leave a comment if you feel this should be reverted | 15:56 |
| SridarK | chandanc_: no i think what u have is good | 15:57 |
| chandanc_ | ok | 15:57 |
| SridarK | chandanc_: just trying to see if register of the opts needs a tweak | 15:57 |
| SridarK | chandanc_: if u are busy on iptables stuff - pls go ahead - let me pull the PS and rerun UT | 15:58 |
| chandanc_ | ok, i could not find any better place to register the opts | 15:58 |
| chandanc_ | sure please leave a comment, i will get back | 15:58 |
| chandanc_ | SridarK, just wanted to know how do i resolve the merge conflict showing up in gerrit for this patch | 15:59 |
| SridarK | chandanc_: ok let me debug | 15:59 |
| SridarK | if u update ur repo and then cherry-pick the changeset | 16:01 |
| SridarK | it will show u the conflict, which u will need to resolve | 16:01 |
| SridarK | basically the cherry-pick will tell u the steps | 16:02 |
| chandanc_ | got it, will do that . Thanks for the help | 16:02 |
| SridarK | no prob at all | 16:02 |
| *** yamamoto has quit IRC | 16:37 | |
| *** mickeys has joined #openstack-fwaas | 16:45 | |
| *** vishwanathj has joined #openstack-fwaas | 16:52 | |
| *** chandanc__ has joined #openstack-fwaas | 17:02 | |
| *** chandanc_ has quit IRC | 17:04 | |
| *** xdcc has quit IRC | 17:04 | |
| *** chandanc_ has joined #openstack-fwaas | 17:13 | |
| *** chandanc__ has quit IRC | 17:14 | |
| *** chandanc_ has quit IRC | 17:30 | |
| *** chandanc_ has joined #openstack-fwaas | 17:30 | |
| *** xdcc has joined #openstack-fwaas | 17:34 | |
| *** yamamoto has joined #openstack-fwaas | 17:38 | |
| *** yamamoto has quit IRC | 17:44 | |
| *** chandanc_ has quit IRC | 18:01 | |
| *** mickeys has quit IRC | 18:20 | |
| njohnston | SridarK: I was wondering if you could help me with something. It looks like the current code gets a "router_id" when looking for router information. But I thought that it got a port id. Which is correct? | 18:21 |
| njohnston | SridarK: If it is port id, can you show me where that lookup happens, similarly to the lookup using router id that occurs here: https://github.com/openstack/neutron-fwaas/blob/master/neutron_fwaas/services/firewall/agents/l3reference/firewall_l3_agent.py#L107 | 18:21 |
| SridarK | njohnston: ok | 18:21 |
| SridarK | mfranc213: had changes to translate the port-id | 18:22 |
| SridarK | to reflect the owner router | 18:22 |
| SridarK | to get to the ns | 18:22 |
| njohnston | ok, I'll check her patches then | 18:22 |
| SridarK | in this case with v1 it is the router-id | 18:23 |
| SridarK | https://review.openstack.org/#/c/337699/24/neutron_fwaas/services/firewall/agents/l3reference/firewall_l3_agent_v2.py L#139 | 18:24 |
| *** vishwanathj has quit IRC | 18:25 | |
| *** vishwanathj has joined #openstack-fwaas | 18:26 | |
| *** xdcc has quit IRC | 18:57 | |
| *** mickeys has joined #openstack-fwaas | 19:21 | |
| *** mickeys has quit IRC | 19:25 | |
| *** mickeys has joined #openstack-fwaas | 19:59 | |
| *** vishwanathj has quit IRC | 22:02 | |
| *** mickeys has quit IRC | 22:11 | |
| *** SridarK has quit IRC | 22:31 | |
| *** yamamoto has joined #openstack-fwaas | 22:48 | |
| *** zigo has quit IRC | 22:56 | |
| *** zigo has joined #openstack-fwaas | 22:57 | |
| *** mickeys has joined #openstack-fwaas | 23:55 | |
| *** yushiro has joined #openstack-fwaas | 23:59 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!