| *** yushiro has joined #openstack-fwaas | 00:12 | |
| *** vishwanathj has joined #openstack-fwaas | 00:34 | |
| *** padkrish has quit IRC | 00:35 | |
| SridarK | yushiro: ping | 00:48 |
|---|---|---|
| yushiro | SridarK: pong | 00:48 |
| SridarK | yushiro: sent u email on the db patch | 00:48 |
| yushiro | SridarK: Yes, thank you. I'm reading now. | 00:49 |
| SridarK | yushiro: thank u :-) | 00:49 |
| yushiro | SridarK: Sure. I'll try it now and put +2 if there is no problems. | 00:51 |
| SridarK | yushiro: ok i will wait to provide any clarification b4 i drive back home | 00:52 |
| yushiro | SridarK: good. If exist some bugs, I'll put the comment ASAP. | 00:53 |
| SridarK | yushiro: ok i will wait here so we can discuss | 00:55 |
| SridarK | if u have questions | 00:55 |
| yushiro | SridarK: OK. thanks | 00:56 |
| yushiro | SridarK: I have one question about DB patch. | 01:08 |
| yushiro | SridarK: in PS45, An and I commented into migration file. | 01:09 |
| yushiro | https://review.openstack.org/#/c/311159/45/neutron_fwaas/db/migration/alembic_migrations/versions/d6a12e637e28_neutron_fwaas_v2_0.py | 01:10 |
| yushiro | SridarK: Is it not necessary to revert 'tenant_id'? | 01:11 |
| yushiro | I'll put the comment just in case. | 01:13 |
| SridarK | yushiro: hmm | 01:19 |
| SridarK | let me look | 01:19 |
| SridarK | yushiro: i believe project_id is mapped to tenant_id | 01:20 |
| *** padkrish has joined #openstack-fwaas | 01:20 | |
| SridarK | in the db layer | 01:20 |
| *** chandanc_afk has joined #openstack-fwaas | 01:21 | |
| SridarK | https://github.com/openstack/neutron-fwaas/commit/c3e491cae388713bb175d803de6a216a8816b816 | 01:21 |
| yushiro | SridarK: Maybe I think so because migration file for mapping has already implemented. | 01:22 |
| yushiro | SridarK: Thanks for your link. | 01:26 |
| yushiro | SridarK: I should refer model_base.HasProject at neutron side. It's same strategy. Does it make sense?(I think it's not an issue but nit fix) | 01:27 |
| SridarK | ok if it is a nit, i will pick it up with the plugin changes | 01:29 |
| *** chandanc_afk has quit IRC | 01:39 | |
| *** padkrish has quit IRC | 01:50 | |
| yushiro | I just commented DB patch. please check it.. | 01:52 |
| *** padkrish has joined #openstack-fwaas | 01:56 | |
| *** diogogmt has quit IRC | 02:00 | |
| SridarK | yushiro: looking | 02:03 |
| *** padkrish has quit IRC | 02:09 | |
| SridarK | ok so i will change models_v2.HasTenant to model_base.HasProject | 02:10 |
| yushiro | SridarK: OK, if you change this, please fix migration file too (add index=True) | 02:15 |
| yushiro | Thanks for your checking. You work so hard. I think it's midnight for you.(11:18 in Japan) | 02:18 |
| SridarK | yushiro: what is that change | 02:18 |
| SridarK | no it is 7:20pm | 02:19 |
| SridarK | :-) | 02:19 |
| SridarK | yushiro: i am just running the baseline ut | 02:19 |
| SridarK | and fixing this | 02:20 |
| SridarK | yushiro: and the change in the migration file - i want to make sure | 02:20 |
| yushiro | SridarK: OK. let me explain. In migration file , sa.Column('project_id', sa.String(length=36)) | 02:21 |
| yushiro | There is no 'index=True'. | 02:21 |
| yushiro | If you change model_base.HasProject at fwaas_db_v2.py, I think it's necessary to align the option('index=True'). | 02:22 |
| yushiro | into migration file. | 02:22 |
| SridarK | so like: sa.Column('project_id', sa.String(length=36), index=True) | 02:26 |
| SridarK | yushiro: ^^ | 02:26 |
| yushiro | SridarK: Yes. | 02:26 |
| SridarK | ok let me make the change and run UT | 02:26 |
| SridarK | yushiro: found another issue in the migration file | 02:35 |
| SridarK | we dont have to create the addr group, cidr association | 02:35 |
| yushiro | SridarK: oh, really? I have 1 concern too. | 02:35 |
| SridarK | also on the L#105 | 02:36 |
| yushiro | SridarK: oh, yes, you're right. | 02:36 |
| SridarK | there is no project_id in the policy rule association table | 02:36 |
| SridarK | yushiro: if u see L#91 in the db file | 02:38 |
| yushiro | SridarK: watching... yes, missing 'project_id'.. | 02:39 |
| yushiro | my concern is L#105's project_id | 02:40 |
| yushiro | Is project_id in firewall_rule_policy_associations_v2 for 'firewall_policy_id' or 'firewall_rule_id' or both? | 02:40 |
| yushiro | I'm confusing in case of 'public' policy and public rule. | 02:41 |
| SridarK | in policy rule association there is no project_id | 02:41 |
| SridarK | it just associates a policy with a rule | 02:42 |
| SridarK | we are not tracking the project_id | 02:42 |
| yushiro | SridarK: ah, you just said above my comment!! sorry I missed. | 02:42 |
| SridarK | yushiro: ok :-) | 02:43 |
| yushiro | SridarK: Yes. OK, Can I comment it now? | 02:43 |
| yushiro | or you will ? | 02:43 |
| SridarK | yushiro: i will | 02:44 |
| SridarK | yushiro: http://paste.openstack.org/show/560992/ | 02:44 |
| SridarK | pls take a quick scan | 02:44 |
| yushiro | OK. watching | 02:46 |
| yushiro | checked! LGTM | 02:47 |
| SridarK | actually not just project_id, id, name, desc do not belong in the policy rule assoc table | 02:47 |
| yushiro | oh, indeed. these are not necessary. | 02:48 |
| *** padkrish has joined #openstack-fwaas | 02:49 | |
| yushiro | I've commented on https://review.openstack.org/#/c/311159/12/neutron_fwaas/db/migration/alembic_migrations/versions/d6a12e637e28_neutron_fwaas_v2_0.py | 02:49 |
| yushiro | I forgot to review and put same comment. | 02:50 |
| *** chandanc_ has joined #openstack-fwaas | 02:51 | |
| SridarK | yushiro: http://paste.openstack.org/show/560993/ | 02:51 |
| SridarK | pls do a quick scan - esp on the primary keys for the policy rule assoc table | 02:52 |
| yushiro | scannng.. | 02:53 |
| SridarK | running UT | 02:53 |
| yushiro | difference is OK. but other thing... in L#26 | 02:54 |
| *** chandanc__ has joined #openstack-fwaas | 02:54 | |
| yushiro | down_revision = 'kilo' | 02:54 |
| SridarK | hmm | 02:55 |
| yushiro | I think we should specify previous migration revision as 'down_revision' | 02:55 |
| *** chandanc_ has quit IRC | 02:56 | |
| SridarK | yes was just checking | 02:57 |
| SridarK | 796c68dffbb | 02:57 |
| SridarK | but i am going to remove that as a vendor | 02:57 |
| SridarK | so it is a nop, i will set it to 540142f314f4 | 02:57 |
| yushiro | OK. | 02:58 |
| SridarK | yushiro: other wise the diff looks ok ? | 02:59 |
| yushiro | Yes, It's OK for me. | 02:59 |
| SridarK | i want to avoid multiple Jenkins | 02:59 |
| SridarK | ok | 02:59 |
| *** padkrish has quit IRC | 03:02 | |
| SridarK | ok i actually put the down revision to the cisco thing - which would be the right thing, when i remove i will fix this - | 03:02 |
| SridarK | yushiro: so if are good - i push up a PS | 03:02 |
| yushiro | OK. I'll check it soon. | 03:03 |
| SridarK | yushiro: pep8 does not like it if i change the downrev, so i put it back to kilo | 03:08 |
| SridarK | i will fix this with my plugin | 03:09 |
| yushiro | SridarK: oh, OK. | 03:09 |
| SridarK | so at least other patches can move fwd, in any case for v2 it is a new set of tables and will not break v2 | 03:09 |
| SridarK | and since Jenkins was ok | 03:10 |
| SridarK | with this on the prev patch | 03:10 |
| SridarK | we can fix it quickly tomorrow | 03:10 |
| SridarK | yushiro: i will let njohnston know as well | 03:11 |
| yushiro | Sure. sorry, I'll go lunch and back to 13:00 pm(50 minutes later) | 03:12 |
| *** yushiro is now known as yushiro|lunch | 03:12 | |
| SridarK | yushiro: ok shall i push ? | 03:12 |
| SridarK | yushiro|lunch: np i am pushing next rev - pls take a look when u are back | 03:13 |
| yushiro|lunch | yes, please. | 03:13 |
| *** SridarK has quit IRC | 03:22 | |
| *** yushiro|lunch has quit IRC | 03:39 | |
| *** yushiro has joined #openstack-fwaas | 03:58 | |
| *** SridarK has joined #openstack-fwaas | 04:38 | |
| yushiro | I'm reviewing DB patch now. | 05:00 |
| *** SarathMekala has joined #openstack-fwaas | 05:43 | |
| yushiro | SridarK: I tried to migrate DB and got result (http://paste.openstack.org/show/561029/) | 05:49 |
| yushiro | SridarK: I think it looks good. | 05:51 |
| SridarK | yushiro: ok good thanks for all the help with the reviews | 06:10 |
| yushiro | SridarK: NP! | 06:15 |
| SarathMekala | /chandanc ping | 06:24 |
| *** yamamoto has quit IRC | 06:31 | |
| *** mickeys has joined #openstack-fwaas | 07:21 | |
| *** mickeys has quit IRC | 07:26 | |
| *** vishwanathj has quit IRC | 07:51 | |
| *** chandanc__ has quit IRC | 07:52 | |
| *** vishwanathj has joined #openstack-fwaas | 08:14 | |
| *** chandanc__ has joined #openstack-fwaas | 08:50 | |
| yushiro | Hi all, | 09:06 |
| yushiro | I have to leave my office today. If you have time, please take a look on CLI patch :) https://review.openstack.org/#/c/351582/ | 09:07 |
| yushiro | Currently, I'm going to support not only '--public' but '--shared' but I can't and some UT is missing (Coverage is about 80%) | 09:09 |
| yushiro | bye bye ! | 09:09 |
| *** yushiro has quit IRC | 09:09 | |
| *** vishwanathj is now known as vishwanathj_zzz | 09:15 | |
| *** yamamoto has joined #openstack-fwaas | 10:58 | |
| SarathMekala | SridarK : I have tested out the db migration on my setup and its working fine | 11:01 |
| SarathMekala | Please find the output @ http://paste.openstack.org/show/561243/ | 11:02 |
| *** chandanc__ has quit IRC | 11:02 | |
| *** SarathMekala has quit IRC | 11:07 | |
| -openstackstatus- NOTICE: Precise tests on OSIC provider are currently failing, please stop your checks until the issue is resolved. | 11:16 | |
| -openstackstatus- NOTICE: DSVM jobs on OSIC currently failing because of IP collisions, fix is in the gate - https://review.openstack.org/#/c/357764/ - please hold rechecks until merged | 11:21 | |
| -openstackstatus- NOTICE: OSIC has burned through the problematic IP range with failures, things should be back to normal now. | 11:49 | |
| *** yamamoto has quit IRC | 12:05 | |
| *** yamamoto has joined #openstack-fwaas | 12:06 | |
| *** yamamoto has quit IRC | 12:11 | |
| *** yamamoto has joined #openstack-fwaas | 12:36 | |
| *** diogogmt has joined #openstack-fwaas | 12:51 | |
| njohnston | good morning all | 13:57 |
| *** diogogmt has quit IRC | 14:03 | |
| *** diogogmt has joined #openstack-fwaas | 14:04 | |
| SridarK | njohnston: GM | 14:18 |
| SridarK | GM all | 14:18 |
| SridarK | So the db patch is in, i am trying to finish up the plugin | 14:19 |
| njohnston | Great news about the DB patch | 14:20 |
| njohnston | Congrats to everyone - it was a real team effort | 14:21 |
| SridarK | njohnston: +1 | 14:24 |
| *** SarathMekala has joined #openstack-fwaas | 14:37 | |
| *** chandanc__ has joined #openstack-fwaas | 14:42 | |
| *** mickeys has joined #openstack-fwaas | 15:41 | |
| *** yamamoto has quit IRC | 15:47 | |
| *** yamamoto has joined #openstack-fwaas | 15:50 | |
| *** yamamoto has quit IRC | 15:59 | |
| *** yamamoto has joined #openstack-fwaas | 16:02 | |
| *** yamamoto has quit IRC | 16:08 | |
| *** xdcc has joined #openstack-fwaas | 16:13 | |
| *** chandanc__ has quit IRC | 16:23 | |
| *** SarathMekala has quit IRC | 16:36 | |
| mfranc213 | hello everyone. | 16:42 |
| xgerman | hi | 16:43 |
| SridarK | hi | 17:07 |
| SridarK | mfranc213: njohnston: can we sync around 3:30pm EDT ? To discuss the plugin refactoring that we shd plan for | 17:08 |
| SridarK | i want to get a plugin patch that is as complete as possible b4 that | 17:09 |
| mfranc213 | i can. i have a detailed doc to send out first. SridarK I can meet at pretty much anytime from now until sunday morning. :) | 17:09 |
| SridarK | mfranc213: ok perfect | 17:12 |
| SridarK | i have to add the agent -> plugin rpc methods (u have a comment on me for that already) I am testing some port validation | 17:13 |
| SridarK | mfranc213: only sun morn ? i can just see u pushing patches on the plane or car as u head for vacation. :-) | 17:15 |
| mfranc213 | car! | 17:20 |
| mfranc213 | and my daughter can drive :) | 17:20 |
| SridarK | :-) | 17:20 |
| *** mickeys has quit IRC | 17:32 | |
| *** SarathMekala has joined #openstack-fwaas | 17:40 | |
| njohnston | SridarK: 3:30pm works for me as well | 17:42 |
| SridarK | njohnston: ok sounds good | 17:43 |
| *** yamamoto has joined #openstack-fwaas | 17:47 | |
| *** yamamoto has quit IRC | 17:52 | |
| *** SarathMekala has quit IRC | 17:56 | |
| *** SarathMekala has joined #openstack-fwaas | 18:09 | |
| SridarK | SarathMekala: ping | 18:17 |
| *** SarathMekala has quit IRC | 18:19 | |
| *** vishwanathj_zzz is now known as vishwanathj | 18:23 | |
| *** yamamoto has joined #openstack-fwaas | 18:32 | |
| *** yamamoto has quit IRC | 18:38 | |
| SridarK | mfranc213: njohnston: got pulled into a mtg - so could not get the patch out - are u guys okay to talk at 4:30pm EDT | 19:08 |
| SridarK | mfranc213: njohnston: if that is too late - we can just talk at 3:30pm EDT as discussed earlier | 19:09 |
| njohnston | 4:30 is OK for me | 19:09 |
| SridarK | ok | 19:11 |
| *** yamamoto has joined #openstack-fwaas | 19:18 | |
| njohnston | SridarK: Can we go ahead and drop a patch to get rid of the varmour stuff? | 19:21 |
| SridarK | njohnston: on it no worries | 19:21 |
| njohnston | Thanks! It'll make testing simpler | 19:21 |
| SridarK | njohnston: agreed | 19:21 |
| *** yamamoto has quit IRC | 19:22 | |
| njohnston | It'll be interesting to see if our FWaaS talk was among the <20% of talks that were selected: https://twitter.com/emaganap/status/766719352389373952 | 19:41 |
| mfranc213 | 4:30 works for me but i will be calling in only. | 19:44 |
| mfranc213 | sending you guys the write-up now. | 19:44 |
| *** yamamoto has joined #openstack-fwaas | 19:48 | |
| *** yamamoto has quit IRC | 19:52 | |
| *** xdcc has quit IRC | 20:01 | |
| njohnston | Thanks for writing that all up, mfranc213! | 20:07 |
| mfranc213 | njohnston: it's pretty turgid! | 20:14 |
| mfranc213 | SridarK: i can be on webex after all, as needed. | 20:28 |
| SridarK | mfranc213: ok | 20:28 |
| SridarK | mfranc213: ok starting up soon | 20:28 |
| *** yamamoto has joined #openstack-fwaas | 20:32 | |
| *** yamamoto has quit IRC | 20:37 | |
| *** yamamoto has joined #openstack-fwaas | 21:07 | |
| *** yamamoto has quit IRC | 21:11 | |
| *** mickeys has joined #openstack-fwaas | 21:43 | |
| *** diogogmt has quit IRC | 21:48 | |
| *** mickeys has quit IRC | 21:58 | |
| *** mickeys has joined #openstack-fwaas | 23:21 | |
| *** mickeys has quit IRC | 23:23 | |
| *** yamamoto has joined #openstack-fwaas | 23:53 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!