*** yushiro has joined #openstack-fwaas | 01:24 | |
*** mickeys has joined #openstack-fwaas | 01:41 | |
*** mickeys has quit IRC | 01:45 | |
*** yushiro has quit IRC | 03:32 | |
*** yushiro has joined #openstack-fwaas | 03:57 | |
*** mickeys_ has joined #openstack-fwaas | 05:12 | |
*** mickeys_ has quit IRC | 05:29 | |
*** vishwanathj has joined #openstack-fwaas | 05:51 | |
*** vishwanathj has quit IRC | 05:55 | |
*** mickeys has joined #openstack-fwaas | 06:04 | |
*** mickeys has quit IRC | 06:08 | |
*** vishwanathj has joined #openstack-fwaas | 06:21 | |
*** yamamoto has quit IRC | 08:26 | |
*** yushiro has quit IRC | 08:43 | |
*** vishwanathj has quit IRC | 09:22 | |
*** Hemanth has joined #openstack-fwaas | 09:40 | |
*** yamamoto has joined #openstack-fwaas | 09:53 | |
*** yamamoto has quit IRC | 09:57 | |
*** yamamoto has joined #openstack-fwaas | 10:13 | |
*** yamamoto has quit IRC | 10:16 | |
*** yamamoto has joined #openstack-fwaas | 10:18 | |
*** mickeys has joined #openstack-fwaas | 10:20 | |
*** Hemanth has quit IRC | 10:23 | |
*** yamamoto has quit IRC | 10:24 | |
*** mickeys has quit IRC | 10:24 | |
*** yamamoto has joined #openstack-fwaas | 10:54 | |
*** yamamoto has quit IRC | 11:19 | |
*** yamamoto has joined #openstack-fwaas | 11:19 | |
*** yamamoto has quit IRC | 11:46 | |
*** yamamoto has joined #openstack-fwaas | 11:46 | |
*** mickeys has joined #openstack-fwaas | 12:08 | |
*** mickeys has quit IRC | 12:13 | |
*** yamamoto has quit IRC | 13:32 | |
*** SridarK has quit IRC | 13:33 | |
*** yamamoto has joined #openstack-fwaas | 13:34 | |
*** yamamoto has quit IRC | 13:40 | |
*** njohnston|PTO is now known as njohnston | 13:49 | |
*** mestery has quit IRC | 13:58 | |
*** mestery has joined #openstack-fwaas | 14:00 | |
*** dougwig has quit IRC | 14:04 | |
*** xgerman has quit IRC | 14:04 | |
*** carl_baldwin has quit IRC | 14:04 | |
*** afranc_ has quit IRC | 14:05 | |
*** afranc has joined #openstack-fwaas | 14:10 | |
*** dougwig has joined #openstack-fwaas | 14:14 | |
*** xgerman has joined #openstack-fwaas | 14:18 | |
*** carl_baldwin has joined #openstack-fwaas | 14:21 | |
*** mickeys has joined #openstack-fwaas | 14:35 | |
*** yamamoto has joined #openstack-fwaas | 14:36 | |
*** mickeys_ has joined #openstack-fwaas | 14:36 | |
*** hwcomcn has joined #openstack-fwaas | 14:38 | |
*** hwcomcn has quit IRC | 14:39 | |
*** mickeys has quit IRC | 14:39 | |
*** hwcomcn has joined #openstack-fwaas | 14:39 | |
*** diogogmt has quit IRC | 14:40 | |
*** hwcomcn has quit IRC | 14:41 | |
*** yamamoto has quit IRC | 14:41 | |
*** hwcomcn has joined #openstack-fwaas | 14:42 | |
*** vishwanathj has joined #openstack-fwaas | 14:46 | |
*** hwcomcn_ has joined #openstack-fwaas | 14:52 | |
*** hwcomcn has quit IRC | 14:55 | |
*** diogogmt has joined #openstack-fwaas | 15:23 | |
*** mickeys_ has quit IRC | 15:26 | |
*** yamamoto has joined #openstack-fwaas | 15:37 | |
*** yamamoto has quit IRC | 15:43 | |
*** mickeys has joined #openstack-fwaas | 15:44 | |
*** mickeys has quit IRC | 15:47 | |
*** hwcomcn_ has quit IRC | 16:21 | |
*** yamamoto has joined #openstack-fwaas | 16:39 | |
*** yamamoto has quit IRC | 16:44 | |
*** asingh has joined #openstack-fwaas | 16:46 | |
asingh | Hi All. i have https://review.openstack.org/#/c/339177/ , it has 2 +2 and +1 workflow , the dependent patch has merged few days back, not sure why is not getting merged . can someone take a look at it? | 16:49 |
---|---|---|
*** SridarK has joined #openstack-fwaas | 17:38 | |
*** yamamoto has joined #openstack-fwaas | 17:41 | |
*** yamamoto has quit IRC | 17:46 | |
njohnston | asingh: I think you should direct your question to #openstack-infra | 18:05 |
njohnston | They can probably help you get it unstuck. | 18:05 |
asingh | ok, thank you njohnston: | 18:05 |
njohnston | mfranc213: As I am catching up on things, it looks like the only thing left to do for change 339246 is this comment: https://review.openstack.org/#/c/339246/10/neutron/agent/l3/agent.py@433 | 18:09 |
njohnston | I will take a look at making that change. | 18:09 |
njohnston | mfranc213: But before I do, you say, "I'm pinging some others who worked on the analogous part of the QoS implementation to see if they can chime in on this one." - did you succeed in this? | 18:10 |
mfranc213 | i didn't, and i'm a bit worried about making that change without them because it seems pretty substantial | 18:11 |
njohnston | I don't think it is that substantial; if I understand the comment correctly, it would be to add a separate 'add_router' in the l3 agent extension manager and agent extension abstract class that could be implemented using different logic than the existing 'update_router'. | 18:15 |
njohnston | Or an agent would have the ability to implement 'add_router' by calling 'update_router' if there is no difference under the hood. | 18:15 |
njohnston | mfranc213 ^^ | 18:16 |
SridarK | njohnston: mfranc213: we will want to distinguish, add_router will be of interest in the agent restart scenario, del router would be something that could happen and we will need to trigger some cleanup on the driver | 18:17 |
SridarK | njohnston: btw, welcome back from PTO | 18:17 |
njohnston | SridarK: Thanks! Only back for 2 days, but trying to make the most of them! | 18:18 |
SridarK | njohnston: :-) | 18:18 |
njohnston | SridarK: Thanks for pushing up your changes to https://review.openstack.org/#/c/311159/ by the way | 18:19 |
SridarK | njohnston: no worries, i will have more updates | 18:19 |
*** yamamoto has joined #openstack-fwaas | 18:43 | |
*** mickeys has joined #openstack-fwaas | 18:47 | |
*** yamamoto has quit IRC | 18:48 | |
*** mickeys has quit IRC | 18:52 | |
*** mickeys has joined #openstack-fwaas | 19:22 | |
*** mickeys has quit IRC | 19:27 | |
*** mickeys has joined #openstack-fwaas | 19:30 | |
*** mickeys has quit IRC | 19:32 | |
*** mickeys has joined #openstack-fwaas | 19:32 | |
asingh | xgerman: https://review.openstack.org/#/c/339177/ was approved while its dependency was still under review. now that the dependency has merged , it needs a new approval vote on it to get merged. | 19:36 |
*** mickeys has quit IRC | 19:37 | |
xgerman | ok, let’s hope a recheck helps | 19:39 |
asingh | thank you xgerman | 19:39 |
*** yamamoto has joined #openstack-fwaas | 19:45 | |
*** yamamoto has quit IRC | 19:50 | |
*** yamamoto has joined #openstack-fwaas | 20:46 | |
*** yamamoto has quit IRC | 20:52 | |
*** mickeys has joined #openstack-fwaas | 21:10 | |
*** mickeys_ has joined #openstack-fwaas | 21:11 | |
*** mickeys has quit IRC | 21:15 | |
*** mickeys_ has quit IRC | 21:25 | |
*** yamamoto has joined #openstack-fwaas | 21:48 | |
*** yamamoto has quit IRC | 21:54 | |
*** diogogmt has quit IRC | 21:55 | |
*** mickeys has joined #openstack-fwaas | 22:04 | |
*** mickeys has quit IRC | 22:09 | |
*** mickeys has joined #openstack-fwaas | 22:11 | |
*** mickeys has quit IRC | 22:15 | |
*** mickeys has joined #openstack-fwaas | 22:24 | |
*** mickeys has quit IRC | 22:28 | |
*** yamamoto has joined #openstack-fwaas | 22:50 | |
*** mickeys has joined #openstack-fwaas | 22:54 | |
*** yamamoto has quit IRC | 22:54 | |
*** SridarK has quit IRC | 23:13 | |
*** diogogmt has joined #openstack-fwaas | 23:17 | |
*** mickeys has quit IRC | 23:39 | |
*** mickeys has joined #openstack-fwaas | 23:40 | |
*** mickeys has quit IRC | 23:44 | |
*** yamamoto has joined #openstack-fwaas | 23:51 | |
*** yamamoto has quit IRC | 23:56 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!