*** caoyuan has joined #openstack-freezer | 00:38 | |
*** caoyuan has quit IRC | 00:57 | |
*** 07EABJC85 has joined #openstack-freezer | 00:59 | |
*** 07EABJC85 has quit IRC | 00:59 | |
*** jiaopeng_ has joined #openstack-freezer | 00:59 | |
*** caoyuan has joined #openstack-freezer | 01:58 | |
*** caoyuan has quit IRC | 02:34 | |
*** caoyuan has joined #openstack-freezer | 02:35 | |
*** caoyuan has quit IRC | 02:40 | |
*** caoyuan has joined #openstack-freezer | 02:40 | |
*** caoyuan has quit IRC | 03:55 | |
*** caoyuan has joined #openstack-freezer | 03:55 | |
*** caoyuan has quit IRC | 04:03 | |
*** caoyuan has joined #openstack-freezer | 04:07 | |
*** AlexeyAbashkin has joined #openstack-freezer | 05:01 | |
*** AlexeyAbashkin has quit IRC | 05:34 | |
*** AlexeyAbashkin has joined #openstack-freezer | 05:39 | |
*** jiaopeng_ has quit IRC | 05:58 | |
*** jiaopengju has joined #openstack-freezer | 06:00 | |
*** AlexeyAbashkin has quit IRC | 06:07 | |
*** jiaopen__ has joined #openstack-freezer | 06:13 | |
*** jiaopengju has quit IRC | 06:15 | |
*** jiaopen__ has quit IRC | 06:41 | |
*** jiaopeng_ has joined #openstack-freezer | 06:42 | |
*** jiaopen__ has joined #openstack-freezer | 06:43 | |
*** jiaopeng_ has quit IRC | 06:47 | |
*** jiaopen__ has quit IRC | 07:14 | |
*** jiaopeng_ has joined #openstack-freezer | 07:19 | |
openstackgerrit | Kent Wu proposed openstack/freezer master: Fix KeyError if a deprecated key is given https://review.openstack.org/575950 | 08:18 |
---|---|---|
*** AlexeyAbashkin has joined #openstack-freezer | 08:25 | |
*** e0ne has joined #openstack-freezer | 08:34 | |
*** piepmatz has joined #openstack-freezer | 08:49 | |
*** caoyuan has quit IRC | 08:50 | |
*** caoyuan has joined #openstack-freezer | 08:51 | |
*** caoyuan has quit IRC | 08:58 | |
*** caoyuan has joined #openstack-freezer | 08:59 | |
*** caoyuan has quit IRC | 09:03 | |
*** caoyuan has joined #openstack-freezer | 09:08 | |
*** caoyuan has quit IRC | 09:12 | |
*** caoyuan has joined #openstack-freezer | 09:22 | |
*** electrofelix has joined #openstack-freezer | 10:42 | |
*** rnoriega has quit IRC | 12:13 | |
*** rnoriega has joined #openstack-freezer | 12:14 | |
*** rnoriega has quit IRC | 12:14 | |
*** rnoriega has joined #openstack-freezer | 12:16 | |
*** caoyuan has quit IRC | 13:00 | |
*** jiaopeng_ has quit IRC | 13:36 | |
*** jiaopengju has joined #openstack-freezer | 14:07 | |
*** jiaopengju has quit IRC | 14:11 | |
*** caoyuan has joined #openstack-freezer | 14:18 | |
*** e0ne has quit IRC | 14:27 | |
*** e0ne has joined #openstack-freezer | 14:27 | |
*** caoyuan has quit IRC | 15:28 | |
*** caoyuan has joined #openstack-freezer | 15:29 | |
*** prometheanfire has joined #openstack-freezer | 15:34 | |
prometheanfire | can we get a second review on https://review.openstack.org/#/c/575199/ | 15:34 |
prometheanfire | once that merges this should pass https://review.openstack.org/#/c/575163/ | 15:34 |
*** e0ne has quit IRC | 15:44 | |
*** e0ne has joined #openstack-freezer | 15:44 | |
*** jiaopengju has joined #openstack-freezer | 15:50 | |
openstackgerrit | Matthew Thode proposed openstack/freezer master: fix lower constraints https://review.openstack.org/575199 | 15:52 |
piepmatz | prometheanfire: why should the second one pass after merging the first one? the first is parent of the second, isn't that enough? | 15:52 |
*** belmoreira has quit IRC | 15:53 | |
openstackgerrit | Matthew Thode proposed openstack/freezer master: switch to cryptography https://review.openstack.org/575163 | 15:54 |
*** jiaopengju has quit IRC | 15:55 | |
prometheanfire | piepmatz: it is, I think I fixed the reqs error, the lc for cryptography needed to match requirements, 2.1, not 2.1.0 | 15:56 |
prometheanfire | both should be good now, if tests pass of course | 15:57 |
piepmatz | prometheanfire: what is actually the reason for having setuptools in the lc? I've seen it in almost no other project | 16:05 |
prometheanfire | piepmatz: it's in the requirements file, so it has to be in lc too | 16:06 |
prometheanfire | most projects don't have it in their reqs file | 16:06 |
prometheanfire | I assume you have a reason to have it in the reqs file :P | 16:06 |
piepmatz | prometheanfire: probably, I see ;) | 16:07 |
prometheanfire | https://github.com/openstack/nova/blob/master/lower-constraints.txt#L153 | 16:07 |
prometheanfire | nova has it in their reqs too | 16:07 |
piepmatz | yeah, nova was the only one of the five or six repos I checked | 16:08 |
piepmatz | anyways, I can only give +1 and have no objections regarding the 1st change and cannot judge the 2nd one | 16:09 |
*** jiaopengju has joined #openstack-freezer | 16:09 | |
*** jiaopengju has quit IRC | 16:14 | |
*** caoyuan has quit IRC | 16:15 | |
prometheanfire | k | 16:20 |
prometheanfire | the second one didn't have tests, my code tested good in ipython though | 16:21 |
prometheanfire | technically it's still needed by all projects | 16:21 |
*** jiaopengju has joined #openstack-freezer | 16:22 | |
prometheanfire | https://github.com/gentoo/gentoo/blob/master/sys-cluster/cinder/cinder-2018.1.9999.ebuild#L30 for instance for cinder | 16:22 |
*** jiaopengju has quit IRC | 16:26 | |
*** AlexeyAbashkin has quit IRC | 16:52 | |
*** e0ne has quit IRC | 17:19 | |
*** e0ne has joined #openstack-freezer | 17:29 | |
*** jiaopengju has joined #openstack-freezer | 17:33 | |
*** e0ne has quit IRC | 17:34 | |
*** jiaopengju has quit IRC | 17:38 | |
*** electrofelix has quit IRC | 18:27 | |
*** e0ne has joined #openstack-freezer | 18:31 | |
*** piepmatz has quit IRC | 19:15 | |
*** e0ne has quit IRC | 19:16 | |
*** e0ne has joined #openstack-freezer | 19:17 | |
*** e0ne has quit IRC | 19:24 | |
*** AlexeyAbashkin has joined #openstack-freezer | 19:26 | |
*** AlexeyAbashkin has quit IRC | 19:37 | |
*** e0ne has joined #openstack-freezer | 19:39 | |
*** jiaopeng_ has joined #openstack-freezer | 20:10 | |
*** jiaopeng_ has quit IRC | 20:15 | |
*** e0ne has quit IRC | 20:46 | |
*** jiaopengju has joined #openstack-freezer | 20:55 | |
*** jiaopengju has quit IRC | 20:59 | |
*** jiaopengju has joined #openstack-freezer | 21:15 | |
*** jiaopengju has quit IRC | 21:19 | |
*** jiaopeng_ has joined #openstack-freezer | 21:26 | |
*** jiaopeng_ has quit IRC | 21:31 | |
openstackgerrit | Kent Wu proposed openstack/freezer-web-ui master: Avoid using deprecated opt in Web-UI https://review.openstack.org/576657 | 22:12 |
*** kwtw83 has joined #openstack-freezer | 22:20 | |
*** jiaopengju has joined #openstack-freezer | 23:49 | |
*** jiaopengju has quit IRC | 23:54 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!