Friday, 2016-07-01

*** yangyapeng has quit IRC00:11
*** ddieterly has joined #openstack-freezer00:24
*** ddieterly has quit IRC00:41
*** iceyao has joined #openstack-freezer01:04
*** zhurong has joined #openstack-freezer01:12
*** yangyapeng has joined #openstack-freezer01:19
*** EinstCrazy has joined #openstack-freezer01:22
*** ddieterly has joined #openstack-freezer01:38
*** zhurong has quit IRC01:40
*** zhurong has joined #openstack-freezer01:41
*** ddieterly has quit IRC01:43
*** ddieterly has joined #openstack-freezer01:57
*** EinstCra_ has joined #openstack-freezer02:02
*** EinstCrazy has quit IRC02:05
*** EinstCra_ has quit IRC02:23
*** EinstCrazy has joined #openstack-freezer02:24
*** ddieterly has quit IRC02:29
*** M00nr41n has joined #openstack-freezer03:47
*** M00nr41n has quit IRC03:51
*** M00nr41n has joined #openstack-freezer03:53
*** zhurong has quit IRC04:03
*** M00nr41n has quit IRC04:04
*** M00nr41n has joined #openstack-freezer04:06
*** zhurong has joined #openstack-freezer04:13
*** EinstCrazy has quit IRC04:50
*** EinstCrazy has joined #openstack-freezer04:50
*** zhurong has quit IRC04:58
*** M00nr41n has quit IRC04:58
*** zhurong has joined #openstack-freezer05:00
openstackgerrityapeng Yang proposed openstack/freezer: Remove unnecessary executable permissions  https://review.openstack.org/32025005:17
*** lpetrut has joined #openstack-freezer05:22
*** EinstCra_ has joined #openstack-freezer05:32
*** EinstCrazy has quit IRC05:35
*** zhurong has quit IRC05:43
*** zhurong has joined #openstack-freezer05:48
*** M00nr41n has joined #openstack-freezer05:53
*** fawadkhaliq has joined #openstack-freezer06:03
*** fawadkhaliq has quit IRC06:09
*** EinstCra_ has quit IRC06:10
*** fawadkhaliq has joined #openstack-freezer06:10
*** EinstCrazy has joined #openstack-freezer06:16
*** zhangjn has quit IRC06:19
*** zhangjn has joined #openstack-freezer06:24
*** lpetrut has quit IRC06:24
*** zhurong has quit IRC06:41
*** zhurong has joined #openstack-freezer06:44
*** sxc731 has joined #openstack-freezer07:01
*** openstackgerrit has quit IRC07:33
*** popawu has quit IRC07:33
*** openstackgerrit has joined #openstack-freezer07:34
*** fawadkhaliq has quit IRC07:44
*** sxc731 has left #openstack-freezer07:57
*** openstackgerrit has quit IRC08:18
*** openstackgerrit has joined #openstack-freezer08:19
*** electrofelix has joined #openstack-freezer09:00
*** lpetrut has joined #openstack-freezer09:07
*** EinstCra_ has joined #openstack-freezer09:09
*** EinstCrazy has quit IRC09:13
*** fawadkhaliq has joined #openstack-freezer09:30
*** fawadkhaliq has quit IRC09:30
*** EinstCra_ has quit IRC09:38
*** EinstCrazy has joined #openstack-freezer09:38
*** fawadkhaliq has joined #openstack-freezer09:46
*** zengchen has quit IRC09:58
*** EinstCrazy has quit IRC10:01
*** yangyapeng has quit IRC10:01
*** sxc731 has joined #openstack-freezer10:03
*** sxc731 has left #openstack-freezer10:04
*** zhurong has quit IRC10:17
*** fawadkhaliq has quit IRC10:22
*** fawadkhaliq has joined #openstack-freezer10:23
*** yangyapeng has joined #openstack-freezer10:23
openstackgerritDomhnall Walsh proposed openstack/freezer-api: Middleware loading now works for falcon >= 0.1.6  https://review.openstack.org/33492010:24
openstackgerritDomhnall Walsh proposed openstack/freezer-api: Fix Middleware loading for falcon >= 0.1.6  https://review.openstack.org/33492010:27
*** lpetrut has quit IRC10:27
*** yangyapeng has quit IRC10:27
jokke_domhnallw: around?10:28
*** fawadkhaliq has quit IRC10:28
*** iceyao_ has joined #openstack-freezer10:28
*** iceyao_ has quit IRC10:29
*** fawadkhaliq has joined #openstack-freezer10:29
*** iceyao has quit IRC10:32
*** fawadkhaliq has quit IRC10:35
*** fawadkhaliq has joined #openstack-freezer10:37
*** fawadkhaliq has quit IRC10:40
domhnallwHey, yep.10:40
domhnallwHi jokke_10:40
*** fawadkhaliq has joined #openstack-freezer10:40
*** fawadk has joined #openstack-freezer10:46
*** fawadkhaliq has quit IRC10:47
*** fawadk has quit IRC10:47
*** fawadkhaliq has joined #openstack-freezer10:47
*** fawadk has joined #openstack-freezer10:52
*** fawadkhaliq has quit IRC10:52
*** fawadkhaliq has joined #openstack-freezer10:58
jokke_hey10:59
jokke_was looking the falcon change10:59
*** fawadk has quit IRC10:59
jokke_is there change in behavior on the req.get_header between versions?11:00
jokke_domhnallw: ^^11:00
jokke_iiuc the who try: except: block is built in to the default behavior of the get_header if not specifically defined required11:01
*** fawadkhaliq has quit IRC11:05
*** fawadkhaliq has joined #openstack-freezer11:05
*** fawadk has joined #openstack-freezer11:07
*** fawadkhaliq has quit IRC11:08
domhnallwHey.11:09
domhnallwBasically, get_header returns (None,) if the header isn't set, otherwise you can ask it to throw an exception.11:09
domhnallwget_header() appears to be consistent across all versions.11:10
*** fawadkhaliq has joined #openstack-freezer11:11
domhnallwhttp://falcon.readthedocs.io/en/stable/api/request_and_response.html#falcon.Request.get_header11:11
*** fawadk has quit IRC11:12
*** fawadkhaliq has quit IRC11:12
domhnallwThe docs say it returns None if the header isn't set but in practice it's returning a tuple containing None.11:12
domhnallwThat appears to be consistent across all versions.11:12
*** fawadkhaliq has joined #openstack-freezer11:12
domhnallwI agree that the approach I've taken looks odd.11:13
domhnallwIf it returned None instead of (None,) it'd be fine.11:14
jokke_yeah11:14
*** fawadkhaliq has quit IRC11:14
*** fawadkhaliq has joined #openstack-freezer11:15
domhnallwIf you think that testing to see if it looks *like* None is better, I can do that?11:16
*** electrofelix has quit IRC11:17
*** fawadkhaliq has quit IRC11:18
*** fawadkhaliq has joined #openstack-freezer11:18
*** electrofelix has joined #openstack-freezer11:22
*** fawadk has joined #openstack-freezer11:23
*** fawadkhaliq has quit IRC11:23
domhnallwFYI am double-checking to absolutely confirm how I arrived at the conclusion it was misbehaving.11:24
domhnallw(i.e. returning (None,)11:24
*** fawadk has quit IRC11:26
*** fawadkhaliq has joined #openstack-freezer11:26
domhnallwWeird, I can't seem to replicate it. It's passed for 0.1.6, 0.2.0 and 1.0.0 and is in the process of passing for 0.3.0.11:30
*** fawadkhaliq has quit IRC11:31
*** fawadkhaliq has joined #openstack-freezer11:31
domhnallwOkay, I'm ripping that try catch block out.11:31
domhnallwAny other stuff that looks odd/weird/wrong?11:31
openstackgerritDomhnall Walsh proposed openstack/freezer-api: Fix Middleware loading for falcon >= 0.1.6  https://review.openstack.org/33492011:32
domhnallwHave to run to lunch before the queue gets insane. Back in a bit :)11:33
jokke_the rest there looks good ... that was just weird ;)11:36
*** fawadkhaliq has quit IRC11:37
*** fawadkhaliq has joined #openstack-freezer11:37
*** fawadkhaliq has quit IRC11:39
*** fawadkhaliq has joined #openstack-freezer11:39
*** fawadkhaliq has quit IRC11:42
*** fawadkhaliq has joined #openstack-freezer11:42
*** fawadk has joined #openstack-freezer11:46
*** fawadkhaliq has quit IRC11:46
*** fawadk has quit IRC11:48
*** fawadkhaliq has joined #openstack-freezer11:48
*** ddieterly has joined #openstack-freezer11:48
*** fawadkhaliq has quit IRC11:50
*** fawadkhaliq has joined #openstack-freezer11:50
*** fawadkhaliq has quit IRC11:58
*** fawadk has joined #openstack-freezer11:58
*** fawadkhaliq has joined #openstack-freezer12:03
*** fawadk has quit IRC12:04
*** ddieterly has quit IRC12:07
*** fawadkhaliq has quit IRC12:07
*** fawadkhaliq has joined #openstack-freezer12:08
openstackgerritDomhnall Walsh proposed openstack/freezer-api: Fix Middleware loading for falcon >= 0.1.6  https://review.openstack.org/33492012:11
domhnallw^^^ removes an unneeded import I just spotted, otherwise the same.12:11
*** fawadk has joined #openstack-freezer12:13
*** fawadkhaliq has quit IRC12:14
*** fawadkhaliq has joined #openstack-freezer12:18
*** fawadkhaliq has quit IRC12:18
*** fawadk has quit IRC12:20
*** lpetrut has joined #openstack-freezer12:22
*** ddieterly has joined #openstack-freezer12:24
*** fawadkhaliq has joined #openstack-freezer12:25
*** ddieterly has quit IRC12:29
*** fawadkhaliq has quit IRC12:30
*** ddieterly has joined #openstack-freezer12:46
*** ddieterly has quit IRC12:56
*** M00nr41n has quit IRC13:14
*** ddieterly has joined #openstack-freezer13:30
*** ddieterly is now known as ddieterly[away]13:30
*** iceyao has joined #openstack-freezer13:38
*** ddieterly[away] is now known as ddieterly13:39
*** daemontool has joined #openstack-freezer13:43
*** yangyapeng has joined #openstack-freezer13:54
*** sxc731 has joined #openstack-freezer13:59
*** sxc731 has left #openstack-freezer13:59
*** EinstCrazy has joined #openstack-freezer14:01
*** zhangjn has quit IRC14:02
*** iceyao has quit IRC14:02
*** zhangjn has joined #openstack-freezer14:04
*** EinstCrazy has quit IRC14:04
*** iceyao has joined #openstack-freezer14:07
*** daemontool has quit IRC14:12
*** EinstCrazy has joined #openstack-freezer14:14
*** daemontool has joined #openstack-freezer14:14
openstackgerritDomhnall Walsh proposed openstack/freezer-api: Fix Middleware loading for falcon >= 0.1.6  https://review.openstack.org/33492014:15
*** M00nr41n has joined #openstack-freezer14:28
*** zhurong has joined #openstack-freezer14:30
*** EinstCrazy has quit IRC15:14
*** sxc731 has joined #openstack-freezer15:16
*** sxc731 has left #openstack-freezer15:17
*** iceyao has quit IRC15:24
*** iceyao has joined #openstack-freezer15:26
*** daemontool has quit IRC15:28
*** Marcellin has joined #openstack-freezer15:29
*** M00nr41n has quit IRC15:32
*** zhurong has quit IRC15:32
*** iceyao has quit IRC16:02
*** daemontool has joined #openstack-freezer16:31
*** M00nr41n has joined #openstack-freezer16:47
*** ddieterly is now known as ddieterly[away]16:52
*** ddieterly[away] is now known as ddieterly16:58
*** electrofelix has quit IRC17:12
*** ddieterly is now known as ddieterly[away]17:19
*** fawadkhaliq has joined #openstack-freezer17:35
*** fawadkhaliq has quit IRC17:39
*** daemontool has quit IRC18:00
*** ddieterly[away] has quit IRC18:19
*** lpetrut has quit IRC18:22
*** ddieterly has joined #openstack-freezer19:09
*** M00nr41n_ has joined #openstack-freezer19:42
*** M00nr41n has quit IRC19:42
*** lpetrut has joined #openstack-freezer19:51
*** ddieterly is now known as ddieterly[away]20:03
*** ddieterly[away] is now known as ddieterly20:26
*** lpetrut has quit IRC21:36
*** ddieterly is now known as ddieterly[away]21:49
openstackgerritDomhnall Walsh proposed openstack/freezer-api: Fix Middleware loading for falcon >= 0.1.6  https://review.openstack.org/33492021:53
*** ddieterly[away] is now known as ddieterly22:12
*** ddieterly is now known as ddieterly[away]22:55
*** ddieterly[away] has quit IRC22:55
openstackgerritDomhnall Walsh proposed openstack/freezer-api: Fix Middleware loading for falcon >= 0.1.6  https://review.openstack.org/33492023:11

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!