*** openstack has joined #openstack-freezer | 05:59 | |
*** lpetrut has quit IRC | 06:13 | |
*** lpetrut has joined #openstack-freezer | 06:24 | |
*** EinstCrazy has quit IRC | 06:28 | |
*** EinstCrazy has joined #openstack-freezer | 06:29 | |
*** EinstCrazy has quit IRC | 06:30 | |
*** EinstCrazy has joined #openstack-freezer | 06:30 | |
*** lpetrut has quit IRC | 06:40 | |
*** EinstCrazy has quit IRC | 06:41 | |
*** EinstCrazy has joined #openstack-freezer | 06:45 | |
*** yangyape_ has joined #openstack-freezer | 06:54 | |
*** yangyapeng has quit IRC | 06:56 | |
*** yangyapeng has joined #openstack-freezer | 07:06 | |
*** yangyapeng has quit IRC | 07:06 | |
*** yangyapeng has joined #openstack-freezer | 07:07 | |
*** yangyape_ has quit IRC | 07:08 | |
domhnallw | timothyb89, sorry about that. Regarding https://launchpad.net/bugs/1592046 m3mo and I were talking here and he thinks (and I agree) that the behaviour of Elastic Search for conditions where limit is either 0 or -1 is contrary to what you'd expect - typically, I would have thought that limit=0 returns no results or a "not found" depending on the presence or absence of results, and limit=-1, being technically an illegal | 07:43 |
---|---|---|
openstack | Launchpad bug 1592046 in Freezer "GET requests to the Freezer API with negative offset, limit values fail" [Undecided,In progress] - Assigned to Tim Buckley (timothy-jas-buckley) | 07:43 |
domhnallw | value for a quantity of items, would be interpreted as a synonym for "no limit", suggesting that all records should be returned. But that's just my 2c. I also reckon that the API's responses should not depend on the quirks of ElasticSearch as these may change without warning leading to changes in how the Freezer API works. | 07:43 |
*** samuelBartel has joined #openstack-freezer | 07:53 | |
domhnallw | My gut feeling is that it offset and limit should be treated by the API in a specific, documented way and how these are passed on to Elastic Search should be abstracted. | 07:55 |
domhnallw | After all, pretty much everything else is :) | 07:57 |
*** lpetrut has joined #openstack-freezer | 08:07 | |
*** lpetrut1 has joined #openstack-freezer | 08:12 | |
*** lpetrut has quit IRC | 08:12 | |
*** lpetrut1 is now known as lpetrut | 08:12 | |
openstackgerrit | Ice Yao proposed openstack/freezer: add cinder restore can define special backup id https://review.openstack.org/330381 | 08:51 |
*** liudan has joined #openstack-freezer | 08:51 | |
*** electrofelix has joined #openstack-freezer | 09:27 | |
*** gahan has joined #openstack-freezer | 09:38 | |
*** samuelBartel has quit IRC | 09:56 | |
openstackgerrit | Ice Yao proposed openstack/freezer: add cinder restore can define special backup id https://review.openstack.org/330381 | 10:25 |
*** iceyao_ has joined #openstack-freezer | 10:28 | |
*** iceyao has quit IRC | 10:32 | |
*** iceyao_ has quit IRC | 10:33 | |
*** liudan has left #openstack-freezer | 10:44 | |
*** liudan has joined #openstack-freezer | 10:44 | |
yangyapeng | ping liudan | 11:23 |
*** liudan has quit IRC | 11:23 | |
*** ddieterly has joined #openstack-freezer | 11:47 | |
ddieterly | anyone know anything about the state of the multiple storage functionality? | 11:48 |
*** iceyao has joined #openstack-freezer | 11:49 | |
*** ddieterly is now known as ddieterly[away] | 12:05 | |
*** samuelBartel has joined #openstack-freezer | 12:17 | |
*** ddieterly has joined #openstack-freezer | 12:32 | |
m3m0 | ddieterly: you here? | 12:37 |
ddieterly | yes | 12:37 |
m3m0 | I can help you with that | 12:38 |
ddieterly | great | 12:38 |
ddieterly | what's up with multiple storage? | 12:38 |
ddieterly | we can do a phone call when i get into the office, ok? | 12:39 |
m3m0 | even better | 12:41 |
m3m0 | yes, just let me know | 12:41 |
*** ddieterly is now known as ddieterly[away] | 12:41 | |
*** ddieterly[away] has quit IRC | 12:41 | |
*** _slashme_ has joined #openstack-freezer | 12:55 | |
*** saggi1 has joined #openstack-freezer | 13:16 | |
*** yangyapeng_ has joined #openstack-freezer | 13:20 | |
*** EinstCrazy has quit IRC | 13:20 | |
*** yangyape_ has joined #openstack-freezer | 13:21 | |
*** EinstCrazy has joined #openstack-freezer | 13:21 | |
*** EinstCrazy_ has joined #openstack-freezer | 13:22 | |
*** yangyapeng_ has quit IRC | 13:23 | |
*** yangyape_ has quit IRC | 13:23 | |
*** yangyapeng has quit IRC | 13:24 | |
*** EinstCrazy has quit IRC | 13:26 | |
*** EinstCrazy__ has joined #openstack-freezer | 13:26 | |
*** EinstCrazy___ has joined #openstack-freezer | 13:27 | |
*** EinstCrazy_ has quit IRC | 13:30 | |
*** EinstCrazy__ has quit IRC | 13:30 | |
*** yangyapeng_ has joined #openstack-freezer | 13:31 | |
*** EinstCrazy___ has quit IRC | 13:32 | |
*** saggi1 has quit IRC | 13:34 | |
*** yangyapeng_ has quit IRC | 13:39 | |
*** ddieterly has joined #openstack-freezer | 13:40 | |
*** ddieterly is now known as ddieterly[away] | 13:44 | |
*** ddieterly[away] is now known as ddieterly | 13:49 | |
*** saggi1 has joined #openstack-freezer | 13:51 | |
*** saggi1 has quit IRC | 13:54 | |
*** Marcellin has joined #openstack-freezer | 13:57 | |
*** yangyapeng_ has joined #openstack-freezer | 13:58 | |
*** yangyapeng_ has quit IRC | 13:59 | |
*** yangyapeng has joined #openstack-freezer | 14:04 | |
*** yangyapeng has quit IRC | 14:05 | |
*** yangyapeng has joined #openstack-freezer | 14:06 | |
*** EinstCrazy___ has joined #openstack-freezer | 14:07 | |
openstackgerrit | Tim Buckley proposed openstack/freezer: Add Tempest tests to validate checksum usage https://review.openstack.org/329113 | 14:07 |
*** daemontool has joined #openstack-freezer | 14:19 | |
*** yangyapeng has quit IRC | 14:25 | |
*** EinstCrazy____ has joined #openstack-freezer | 14:27 | |
*** yangyapeng has joined #openstack-freezer | 14:27 | |
*** EinstCrazy___ has quit IRC | 14:30 | |
*** yangyapeng has quit IRC | 14:33 | |
*** yangyapeng has joined #openstack-freezer | 14:33 | |
*** yangyapeng has quit IRC | 14:43 | |
*** thatsdone has joined #openstack-freezer | 14:47 | |
openstackgerrit | Ice Yao proposed openstack/freezer: add cindernative-backup-id option when restore cinder https://review.openstack.org/330381 | 14:47 |
iceyao | m3m0: sorry | 14:48 |
iceyao | m3m0: I have done that just now | 14:48 |
*** EinstCrazy has joined #openstack-freezer | 14:58 | |
*** yangyapeng has joined #openstack-freezer | 14:59 | |
*** thatsdone_ has joined #openstack-freezer | 15:00 | |
*** yangyapeng has quit IRC | 15:02 | |
*** thatsdone has quit IRC | 15:02 | |
*** EinstCrazy____ has quit IRC | 15:03 | |
timothyb89 | domhnallw: thanks for the details, I think that strategy makes the most sense. I'll look into adapting my patch to enforce those rules | 15:03 |
*** pennerc has joined #openstack-freezer | 15:04 | |
domhnallw | timothyb89: no problem :) | 15:05 |
*** EinstCrazy____ has joined #openstack-freezer | 15:06 | |
*** iceyao has quit IRC | 15:09 | |
*** EinstCrazy____ has quit IRC | 15:09 | |
*** iceyao has joined #openstack-freezer | 15:09 | |
*** iceyao has quit IRC | 15:14 | |
jonaspf | sorry to be a pest about this but could you please review https://review.openstack.org/#/c/320591/ | 15:24 |
jonaspf | this change contains an end-to-end integration test. IMO it is very important that we have those tests. Master was broken a couple of times in the last weeks and all of that could have been prevented with this test alone. | 15:25 |
*** openstackgerrit has quit IRC | 15:34 | |
*** openstackgerrit has joined #openstack-freezer | 15:34 | |
_slashme_ | jonaspf: done | 15:49 |
jonaspf | yeahy, thanks :-) | 15:51 |
*** ddieterly is now known as ddieterly[away] | 15:51 | |
*** ddieterly[away] is now known as ddieterly | 15:51 | |
*** EinstCrazy has quit IRC | 15:53 | |
timothyb89 | domhnallw: my plan right now is to adjust the API endpoints to always raise an error on limit <= 0, with no special actions for 0 or -1 | 15:58 |
domhnallw | That seems simplest. | 15:59 |
timothyb89 | domhnallw: it seems that elasticsearch doesn't have any notion of an 'unlimited' return size so fancy handling for limit=0 isn't really possible | 15:59 |
timothyb89 | domhnallw: and I figure if someone wants to test for the existence of data, limit=1 and checking for an empty list is probably sufficient? | 15:59 |
domhnallw | That being the case there's absolutely nothing to be gained from trying to handle that special case. | 15:59 |
timothyb89 | I figured that might be the case :) | 16:00 |
domhnallw | Absolutely. The difference in actual work done is effectively meaningless. | 16:00 |
timothyb89 | okay, great! is there somewhere I should formally document the behavior? I don't see any obvious places in the doc folder? | 16:01 |
*** samuelBartel has quit IRC | 16:02 | |
timothyb89 | ah, specs/Freezer-API-spec.rst seems appropriate, nevermind :) | 16:02 |
*** thatsdone_ has quit IRC | 16:03 | |
domhnallw | :) | 16:03 |
*** jmarianu has joined #openstack-freezer | 16:13 | |
jmarianu | ddieterly. Should I expect an email or call from someone at HPE? | 16:19 |
ddieterly | yes, arun said that he would follow up with you | 16:19 |
ddieterly | i'll ping him about it today | 16:19 |
jmarianu | I am presenting my recommendations tomorrow | 16:20 |
ddieterly | just sent him a follow up email | 16:20 |
openstackgerrit | Merged openstack/freezer: First scenario test https://review.openstack.org/320591 | 16:22 |
jmarianu | I have asked a few questions on this channel and attempted to communicate with the technical leads but they have ignored my questions and chat requests. | 16:22 |
jmarianu | Are my questions not appropriate for this forum | 16:23 |
jmarianu | What is the accepted method to ask a question and receive a response? | 16:23 |
jmarianu | Should my questions be more specific | 16:23 |
openstackgerrit | OpenStack Proposal Bot proposed openstack/freezer: Updated from global requirements https://review.openstack.org/315055 | 16:27 |
*** ddieterly is now known as ddieterly[away] | 16:29 | |
jmarianu | My recommendations are going to set the direction for how at&t will provide backup and restoration services for its openstack deployment. So the lack of response to my questions is disconcerting. | 16:31 |
*** ddieterly[away] is now known as ddieterly | 16:54 | |
_slashme_ | Hello jmarianu | 17:07 |
*** daemontool has quit IRC | 17:08 | |
_slashme_ | I'm sorry you did not get all the answer you needed. | 17:10 |
_slashme_ | Please let me know what I can do to help. | 17:11 |
*** ddieterly is now known as ddieterly[away] | 17:24 | |
*** lpetrut has quit IRC | 17:27 | |
openstackgerrit | Tim Buckley proposed openstack/freezer-api: Return an error for negative limits and offsets https://review.openstack.org/329671 | 17:45 |
openstackgerrit | Memo Garcia proposed openstack/freezer-web-ui: Fized Catch errors in horizon tables https://review.openstack.org/330728 | 17:47 |
openstackgerrit | Memo Garcia proposed openstack/freezer-web-ui: Fixed Catch errors in horizon tables https://review.openstack.org/330728 | 17:49 |
openstackgerrit | Memo Garcia proposed openstack/freezer-web-ui: Fixed Catch errors in horizon tables https://review.openstack.org/330728 | 17:54 |
*** electrofelix has quit IRC | 17:58 | |
openstackgerrit | Tim Buckley proposed openstack/freezer: Add Tempest tests to validate checksum usage https://review.openstack.org/329113 | 18:21 |
*** lpetrut has joined #openstack-freezer | 18:22 | |
*** ddieterly[away] has quit IRC | 18:24 | |
*** ddieterly has joined #openstack-freezer | 18:30 | |
*** _slashme_ has quit IRC | 18:57 | |
*** _slashme_ has joined #openstack-freezer | 19:10 | |
*** lpetrut has quit IRC | 19:13 | |
*** lpetrut has joined #openstack-freezer | 19:46 | |
*** ddieterly is now known as ddieterly[away] | 20:14 | |
*** lpetrut has quit IRC | 20:38 | |
*** ddieterly[away] is now known as ddieterly | 20:44 | |
*** pennerc has quit IRC | 20:51 | |
*** lpetrut has joined #openstack-freezer | 20:51 | |
openstackgerrit | Deklan Dieterly proposed openstack/freezer: Fix exception propagation https://review.openstack.org/330787 | 21:04 |
openstackgerrit | Deklan Dieterly proposed openstack/freezer: Fix exception propagation https://review.openstack.org/330787 | 21:07 |
openstackgerrit | Deklan Dieterly proposed openstack/freezer: Fix exception propagation https://review.openstack.org/330787 | 21:10 |
*** lpetrut has quit IRC | 21:39 | |
openstackgerrit | Deklan Dieterly proposed openstack/freezer: Fix exception propagation https://review.openstack.org/330787 | 21:50 |
*** _slashme_ has quit IRC | 21:57 | |
openstackgerrit | Deklan Dieterly proposed openstack/freezer: Fix tox.ini file https://review.openstack.org/330803 | 22:10 |
openstackgerrit | Deklan Dieterly proposed openstack/freezer: Fix tox.ini file https://review.openstack.org/330803 | 22:27 |
*** ddieterly is now known as ddieterly[away] | 22:32 | |
*** ddieterly[away] has quit IRC | 22:32 | |
*** jmarianu has quit IRC | 22:34 | |
*** Marcellin has quit IRC | 23:56 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!