| *** ddieterly has joined #openstack-freezer | 00:04 | |
| *** Marcel_ has joined #openstack-freezer | 00:05 | |
| *** yangyape_ has quit IRC | 00:11 | |
| *** yangyapeng has joined #openstack-freezer | 01:17 | |
| *** ddieterly has quit IRC | 01:34 | |
| *** EinstCrazy has joined #openstack-freezer | 01:35 | |
| zengchen | hi, guys. is it a bug when the mode is 'mongo' and loading the mode instance at BackupJob.execute_method. I think the loading may failed, because the mod_name=freezer.mode.mongo.MongoMode which is not exist, the real mod=name=freezer.mode.mongo.MongoDbMode. | 01:43 |
|---|---|---|
| zengchen | I think it is needed to change the class name of MongoDbMode to MongoMode. | 01:44 |
| yangyapeng | hi zengchen | 01:56 |
| yangyapeng | ping zengchen | 01:57 |
| zengchen | yangyapeng:hello | 01:57 |
| yangyapeng | HI zengchen | 01:57 |
| yangyapeng | I see it , this is a bug . | 01:57 |
| yangyapeng | if you can report a bug to fix it ? | 01:58 |
| zengchen | yangyapeng:ok, i will fix it. | 01:58 |
| yangyapeng | OK. thank you , report a bug https://bugs.launchpad.net/freezer | 01:59 |
| *** Marcel_ has quit IRC | 02:45 | |
| zengchen | yangyapeng: ping | 03:20 |
| zengchen | is it a bug for the following codes on the 'instance = nova.servers.get(instance)', the argument should be the instance_id. | 03:23 |
| zengchen | def backup_nova(self, instance_id): | 03:23 |
| zengchen | """ | 03:23 |
| zengchen | Implement nova backup | 03:23 |
| zengchen | :param instance_id: Id of the instance for backup | 03:23 |
| zengchen | :return: | 03:23 |
| zengchen | """ | 03:23 |
| zengchen | instance_id = instance_id | 03:23 |
| zengchen | client_manager = self.client_manager | 03:23 |
| zengchen | nova = client_manager.get_nova() | 03:23 |
| zengchen | instance = nova.servers.get(instance_id) | 03:23 |
| zengchen | glance = client_manager.get_glance() | 03:23 |
| zengchen | if instance.__dict__['OS-EXT-STS:task_state']: | 03:23 |
| zengchen | time.sleep(5) | 03:23 |
| zengchen | instance = nova.servers.get(instance) | 03:23 |
| zengchen | the last line. | 03:23 |
| zengchen | the bug is on the last line. | 03:24 |
| yangyapeng | ? | 03:26 |
| yangyapeng | instance_id is a str | 03:31 |
| zengchen | yangyapeng:hi , you can see the codes above. | 03:31 |
| yangyapeng | but instance is nova instance.id . | 03:32 |
| yangyapeng | this shoud use instance | 03:32 |
| zengchen | yangyapeng:yes, the argument for nova.servers.get should be the instance id. | 03:33 |
| zengchen | yangyapeng:but the instance is passed to it at last line. | 03:33 |
| openstackgerrit | zengchen proposed openstack/freezer: Fix the failure of loading the instance of MongoDbMode https://review.openstack.org/326219 | 03:57 |
| *** lpetrut has joined #openstack-freezer | 05:18 | |
| yangyapeng | ping zengchen | 05:21 |
| yangyapeng | zengchen: | 05:21 |
| zengchen | yangyapeng:ping | 06:05 |
| *** lpetrut has quit IRC | 06:08 | |
| zengchen | yangyapeng:please, review the bug. thanks.https://review.openstack.org/326219 | 06:11 |
| yangyapeng | ping zengchen | 06:14 |
| zengchen | yangyapeng:hi, good afternoon. | 06:14 |
| yangyapeng | good afternoon . this patch is good. | 06:15 |
| zengchen | yangyapeng:thanks. | 06:16 |
| zengchen | yangyapeng:about the instance = nova.servers.get(instance), can you expain it again? thanks. | 06:17 |
| yangyapeng | in novaclinet , ServerManager def get () | 06:21 |
| yangyapeng | server shoud be obj | 06:22 |
| yangyapeng | wait | 06:23 |
| yangyapeng | 38 def getid(obj): | 06:23 |
| yangyapeng | 39 """Get object's ID or object. | 06:23 |
| yangyapeng | 40 | 06:23 |
| yangyapeng | 41 Abstracts the common pattern of allowing both an object or an object's ID | 06:23 |
| yangyapeng | 42 as a parameter when dealing with relationships. | 06:23 |
| yangyapeng | 43 """ | 06:23 |
| yangyapeng | 44 try: | 06:24 |
| yangyapeng | 45 return obj.id | 06:24 |
| yangyapeng | 46 except AttributeError: | 06:24 |
| yangyapeng | 47 return obj | 06:24 |
| yangyapeng | abut it ,instance or instance_id , it shoud be ok always, but instance shoud be better. | 06:24 |
| yangyapeng | instance.id is true , but instnace_id have not the attribute id | 06:25 |
| zengchen | yangyapeng:ok, i will check it again. thank you. | 06:26 |
| yangyapeng | :) | 06:26 |
| yangyapeng | https://github.com/openstack/python-novaclient/blob/master/novaclient/base.py#L38 | 06:28 |
| *** yuval has joined #openstack-freezer | 06:36 | |
| *** saggi has joined #openstack-freezer | 07:09 | |
| *** saggi has quit IRC | 07:59 | |
| *** saggi has joined #openstack-freezer | 08:00 | |
| *** electrofelix has joined #openstack-freezer | 09:03 | |
| *** lpetrut has joined #openstack-freezer | 10:07 | |
| *** yangyapeng has quit IRC | 10:16 | |
| *** yangyapeng has joined #openstack-freezer | 11:51 | |
| openstackgerrit | Deklan Dieterly proposed openstack/freezer-api: Fix RST syntax in tempest tests README https://review.openstack.org/326157 | 12:06 |
| *** zengchen has quit IRC | 12:21 | |
| *** EinstCrazy has quit IRC | 12:41 | |
| *** EinstCrazy has joined #openstack-freezer | 12:41 | |
| *** EinstCrazy has quit IRC | 12:46 | |
| openstackgerrit | Domhnall Walsh proposed openstack/freezer-api: Update behaviour for deleting actions in Freezer API https://review.openstack.org/326471 | 13:47 |
| openstackgerrit | Jonas Pfannschmidt proposed openstack/freezer: WIP: First scenario test https://review.openstack.org/320591 | 14:21 |
| *** Marcel_ has joined #openstack-freezer | 14:22 | |
| *** Marcel_ has quit IRC | 14:36 | |
| *** yuval has quit IRC | 14:37 | |
| *** Marcel_ has joined #openstack-freezer | 14:51 | |
| *** yuval has joined #openstack-freezer | 14:53 | |
| gahan | is the above bug related to saving nova instances to local drive ? | 15:02 |
| *** Marcel_ has quit IRC | 15:18 | |
| *** yuval_ has joined #openstack-freezer | 15:29 | |
| *** yuval has quit IRC | 15:29 | |
| *** yuval_ is now known as yuval | 15:29 | |
| *** saggi has quit IRC | 16:08 | |
| *** yuval has quit IRC | 16:09 | |
| openstackgerrit | Jonas Pfannschmidt proposed openstack/freezer: WIP: First scenario test https://review.openstack.org/320591 | 16:10 |
| *** Marcel_ has joined #openstack-freezer | 16:18 | |
| *** Marcel_ is now known as Marcellin | 16:23 | |
| *** saggi has joined #openstack-freezer | 16:33 | |
| *** saggi has quit IRC | 16:49 | |
| *** lpetrut has quit IRC | 17:01 | |
| *** timothyb89 has quit IRC | 17:07 | |
| *** timothyb89 has joined #openstack-freezer | 17:09 | |
| *** electrofelix has quit IRC | 18:02 | |
| *** lpetrut has joined #openstack-freezer | 18:34 | |
| *** clenimar has joined #openstack-freezer | 20:04 | |
| *** saggi has joined #openstack-freezer | 20:29 | |
| *** saggi has quit IRC | 21:00 | |
| *** clenimar has quit IRC | 21:02 | |
| *** lpetrut has quit IRC | 21:17 | |
| *** fawadkhaliq has joined #openstack-freezer | 22:28 | |
| *** fawadkhaliq has quit IRC | 23:37 | |
| *** clenimar has joined #openstack-freezer | 23:49 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!