*** reldan has quit IRC | 00:35 | |
*** reldan has joined #openstack-freezer | 00:38 | |
*** reldan has quit IRC | 00:46 | |
*** jokke_ has quit IRC | 00:58 | |
*** jokke_ has joined #openstack-freezer | 00:58 | |
*** dschroeder has quit IRC | 01:22 | |
*** mingyu has quit IRC | 02:54 | |
*** mingyu has joined #openstack-freezer | 02:54 | |
*** lordd has joined #openstack-freezer | 03:41 | |
*** lordd is now known as damia_pi | 03:45 | |
*** damia_pi has quit IRC | 03:52 | |
*** damia_pi has joined #openstack-freezer | 04:14 | |
*** damia_pi has quit IRC | 05:26 | |
*** damia_pi has joined #openstack-freezer | 05:27 | |
*** damia_pi has quit IRC | 05:35 | |
*** mingyu has quit IRC | 05:42 | |
*** mingyu has joined #openstack-freezer | 05:43 | |
*** damia_pi has joined #openstack-freezer | 05:50 | |
*** damia_pi has quit IRC | 05:55 | |
*** damia_pi has joined #openstack-freezer | 05:57 | |
*** damia_pi has quit IRC | 05:57 | |
*** daemontool_ has joined #openstack-freezer | 05:58 | |
*** daemontool has quit IRC | 06:02 | |
*** damia_pi has joined #openstack-freezer | 06:20 | |
*** damia_pi has quit IRC | 06:54 | |
*** damia_pi has joined #openstack-freezer | 07:28 | |
dmellado | Slashme_: on that one you *don't* have a configuration file for sphinx | 07:29 |
---|---|---|
dmellado | this is not running | 07:29 |
dmellado | it should be there and it's strange that it's not | 07:29 |
*** openstackgerrit has quit IRC | 07:47 | |
*** openstackgerrit has joined #openstack-freezer | 07:48 | |
openstackgerrit | Fabrizio Fresco proposed openstack/freezer: Blueprint specs for DR in freezer https://review.openstack.org/278242 | 07:51 |
*** samuelBartel has joined #openstack-freezer | 08:24 | |
dmellado | btw guys, can some give +A to this? https://review.openstack.org/#/c/277484/ | 08:28 |
openstackgerrit | Fabrizio Fresco proposed openstack/freezer: Blueprint specs for DR in freezer https://review.openstack.org/278242 | 08:39 |
*** reldan has joined #openstack-freezer | 08:45 | |
*** reldan has quit IRC | 08:59 | |
*** reldan has joined #openstack-freezer | 09:05 | |
*** reldan has quit IRC | 09:24 | |
*** damia_pi has quit IRC | 09:45 | |
*** reldan has joined #openstack-freezer | 09:48 | |
*** root_152 has joined #openstack-freezer | 09:53 | |
*** root_152 has quit IRC | 09:54 | |
*** m3m0_ has joined #openstack-freezer | 09:56 | |
*** EmilDi has joined #openstack-freezer | 10:36 | |
reldan | daemontool_ | 11:00 |
reldan | Hi, how are you? | 11:00 |
reldan | https://review.openstack.org/#/c/277875/ | 11:01 |
reldan | I don’t know how to fix this, it seemst that now we can make only one commit that should fix everything | 11:01 |
*** samuelBartel has quit IRC | 11:15 | |
daemontool_ | reldan, looking | 11:42 |
daemontool_ | I'm good thanks | 11:42 |
reldan | daemontool_: and here is something strange https://review.openstack.org/#/c/278242/ | 11:43 |
reldan | gate-freezer-python34FAILURE in 1m 27 | 11:43 |
daemontool_ | reldan, I think we have to execute the dsvm gate job only on liberty and master | 11:44 |
daemontool_ | it's too much hassle to backport that | 11:44 |
*** reldan has quit IRC | 11:46 | |
daemontool_ | if some day we have to set it up for particular reasons | 11:49 |
daemontool_ | we'll backport it | 11:49 |
*** daemontool_ has quit IRC | 12:00 | |
*** reldan has joined #openstack-freezer | 12:06 | |
*** daemontool_ has joined #openstack-freezer | 12:16 | |
daemontool_ | reldan, https://pythonhosted.org/six/ search for configparser | 12:21 |
daemontool_ | with python-six we can solve that issue | 12:21 |
reldan | Yes, seems so | 12:22 |
reldan | daemontool_: how can we disable dsvm for kilo? | 12:33 |
reldan | daemontool_: Can you do this? | 12:33 |
*** mingyu has quit IRC | 12:35 | |
*** mingyu has joined #openstack-freezer | 12:36 | |
daemontool_ | reldan, https://review.openstack.org/#/c/278323/ | 12:37 |
reldan | daemontool_: great! :) Thank you | 12:37 |
daemontool_ | in my opinion, we should focus on delivering features | 12:38 |
daemontool_ | and backport patches if necessary | 12:38 |
reldan | daemontool_: I 100% agree with you | 12:40 |
daemontool_ | the python34 | 12:41 |
daemontool_ | we need to use python-six | 12:41 |
daemontool_ | that is 3 lines changes | 12:41 |
daemontool_ | that can be backported as it requires low efforts | 12:41 |
daemontool_ | I can do that | 12:41 |
dmellado | yep, just saw the issue myself | 12:49 |
dmellado | I agree on using python-six for that, that's the usual way ;) | 12:49 |
dmellado | daemontool_: will you be fixing the py34 gate then? | 12:50 |
daemontool_ | dmellado, I can do it yes | 12:51 |
daemontool_ | we just need to see if it can be backported easily | 12:51 |
daemontool_ | yes, six>=1.9.0 # MIT is the same on kilo liberty and master | 12:56 |
daemontool_ | dmellado, if we have the same issue on freezer-api and freezer-web-ui | 12:57 |
daemontool_ | you can do it if you want | 12:57 |
daemontool_ | I don't know yet | 12:57 |
daemontool_ | easy to discover tho | 12:58 |
openstackgerrit | Eldar Nugaev proposed openstack/freezer: Add six for py3 compatibility https://review.openstack.org/278346 | 12:58 |
dmellado | daemontool_: as of now I only changed that to freezer repo, will submite the equivalent patch to those and if it gets triggered I'll fix it | 12:58 |
daemontool_ | ah ok reldan did it | 12:58 |
daemontool_ | :) | 12:58 |
dmellado | great xD | 12:58 |
reldan | :) Sorry | 12:58 |
dmellado | thanks reldan ;) | 13:02 |
reldan | We can use six. Or do as it did Fausto before | 13:03 |
reldan | try: | 13:03 |
reldan | import configparser | 13:03 |
reldan | except ImportError: | 13:03 |
reldan | import ConfigParser as configparser | 13:03 |
dmellado | reldan: I'd go for six if possible | 13:04 |
dmellado | but up to you | 13:04 |
daemontool_ | yes, I think six is the most common way | 13:04 |
daemontool_ | probably at that time I didn't know about six | 13:04 |
reldan | Agree with you, I send patch with six :) | 13:04 |
openstackgerrit | Eldar Nugaev proposed openstack/freezer: Add six for py3 compatibility https://review.openstack.org/278346 | 13:21 |
daemontool_ | reldan, there are may other issues we need to fix I think. I'd probably rename that commit to porting freezer to py3 | 13:23 |
daemontool_ | if you add py34 to tox.ini | 13:23 |
daemontool_ | and run tox -r -v -epy34 you'll get all the errors | 13:24 |
reldan | Oh, I see - thank you! | 13:24 |
daemontool_ | envlist = py27,pep8,pylint,docs,py34 | 13:24 |
reldan | I will fix them all :) | 13:24 |
openstackgerrit | Memo Garcia proposed openstack/freezer-web-ui: Add SSL support for freezer-web-ui https://review.openstack.org/278366 | 13:40 |
openstackgerrit | Memo Garcia proposed openstack/freezer: Add SSL support for freezer https://review.openstack.org/278367 | 13:40 |
daemontool_ | reldan, I'm going to send a patched tox.ini to https://review.openstack.org/278346 | 13:41 |
daemontool_ | I think that is the layout we should probably use now that we have 2 python environments | 13:41 |
reldan | Yes, sure | 13:41 |
*** EmilDi has quit IRC | 13:52 | |
*** EmilDi has joined #openstack-freezer | 13:53 | |
*** fabriziof has joined #openstack-freezer | 13:56 | |
*** mingyu has quit IRC | 14:05 | |
*** mingyu has joined #openstack-freezer | 14:07 | |
m3m0_ | yo guys, we should spend more time reviewing https://bugs.launchpad.net/freezer/ | 14:24 |
m3m0_ | there are people submiting bugs there | 14:25 |
daemontool_ | yes | 14:27 |
m3m0_ | and clean it a little bit :) | 14:28 |
daemontool_ | we should do something like bug rotation | 14:31 |
*** Slashme_ has quit IRC | 14:34 | |
openstackgerrit | Memo Garcia proposed openstack/freezer-web-ui: Fix misleading labeling for filters https://review.openstack.org/278407 | 14:43 |
*** damia_pi has joined #openstack-freezer | 14:45 | |
*** daemontool_ has quit IRC | 14:49 | |
*** daemontool_ has joined #openstack-freezer | 14:50 | |
*** daemontool__ has joined #openstack-freezer | 14:52 | |
*** daemontool__ is now known as daemontool | 14:52 | |
m3m0_ | daemontool_ I'm going to remove cinder and nova modes from the ui until we are make sure they work properly, what are your thoughs on this? | 14:55 |
m3m0_ | reldan ^^ | 14:55 |
*** daemontool_ has quit IRC | 14:55 | |
reldan | m3m0_: What do you mean by “work properly”? | 14:55 |
openstackgerrit | Eldar Nugaev proposed openstack/freezer: Fix freezer for py3 compatibility https://review.openstack.org/278346 | 15:01 |
*** EmilDi has quit IRC | 15:03 | |
*** Slashme has joined #openstack-freezer | 15:07 | |
*** Slashme has quit IRC | 15:11 | |
daemontool | m3m0_, they work now | 15:19 |
daemontool | the incrementals are not supported | 15:20 |
daemontool | but backups can be executed | 15:20 |
*** damia_pi has quit IRC | 15:23 | |
*** damia_pi has joined #openstack-freezer | 15:23 | |
*** damia_pi has quit IRC | 15:43 | |
m3m0_ | sorry guys I was AFK | 15:43 |
m3m0_ | because I'm doing a small cleaning in the ui, just want to make sure that everything that is there is working as expected | 15:44 |
*** reldan has quit IRC | 15:51 | |
daemontool | m3m0_, brilliant ++. what is not working right now? | 15:51 |
*** slashme has joined #openstack-freezer | 15:53 | |
m3m0_ | nova and cinder with incrementals, but that's a matter of block that configuration from the ui | 15:54 |
*** Slashme_ has joined #openstack-freezer | 16:04 | |
*** EmilDi has joined #openstack-freezer | 16:06 | |
*** Slashme_ has quit IRC | 16:09 | |
*** reldan has joined #openstack-freezer | 16:11 | |
daemontool | m3m0_, cinder incrementals are provided by https://review.openstack.org/#/c/276685/ | 16:12 |
daemontool | for nova we need to wait a bit | 16:13 |
daemontool | I need to understand if for the Nova Team is OK is we work on the hypervisor directly | 16:13 |
*** dschroeder has joined #openstack-freezer | 16:13 | |
daemontool | or not | 16:13 |
daemontool | that would change the solution | 16:13 |
*** Slashme_ has joined #openstack-freezer | 16:18 | |
*** Slashme_ has quit IRC | 16:22 | |
*** EmilDi has quit IRC | 16:33 | |
*** mingyu has quit IRC | 16:38 | |
*** mingyu has joined #openstack-freezer | 16:41 | |
*** mingyu has left #openstack-freezer | 16:43 | |
daemontool | reldan, I think we have to change the files structure of our tests | 16:48 |
reldan | daemontool: what do you mean? | 16:49 |
daemontool | like | 16:49 |
daemontool | tests/functional | 16:49 |
daemontool | tests/integration | 16:49 |
daemontool | let's plan to do that in the future | 16:49 |
daemontool | but now py34 fails because of the integration tests (which are not executed) | 16:50 |
daemontool | it fails for the import error | 16:50 |
reldan | but it is good, it is better to find error now | 16:50 |
daemontool | ok, but shouldn't recourse on that directory | 16:52 |
daemontool | it's a different sets of tests | 16:52 |
openstackgerrit | Eldar Nugaev proposed openstack/freezer: Fix freezer for py3 compatibility https://review.openstack.org/278346 | 16:52 |
reldan | Yes, it is. But currently we run local tests as unit tests | 16:53 |
reldan | and it is good | 16:53 |
reldan | but sure we should think about different mechanisms for running integration and unit | 16:53 |
daemontool | exactly | 16:53 |
reldan | daemontool: It seems that I have fixed problems with py3, but it is not small change https://review.openstack.org/#/c/278346/ | 16:54 |
dmellado | how're you launching those? one option would be to embed unit in another dir with OS_TEST_PATH=./freezer/tests testr run --parallel | 16:55 |
reldan | currently integration have the same trigger as unit | 16:55 |
reldan | but it also checks some additional env variables | 16:55 |
reldan | and if it cannot find them, it skips several tests | 16:56 |
reldan | but always works for local | 16:56 |
daemontool | dmellado, the integration tests are no executed automatically with dsvm unfortunately | 16:57 |
dmellado | daemontool: oh, I see | 16:57 |
daemontool | it should be done like this https://github.com/openstack/python-novaclient/blob/master/tox.ini | 16:58 |
daemontool | but there's also the dsvm side | 16:58 |
dmellado | daemontool: I was about to paste the same but from neutron xD | 16:58 |
daemontool | thing is that we need to change the tests files structure | 16:59 |
*** damia_pi has joined #openstack-freezer | 16:59 | |
dmellado | daemontool: I'm having a look and all that I see it's abracadabra xD | 17:01 |
*** damia_pi has quit IRC | 17:01 | |
dmellado | anyway, I guess this will have to be refactored | 17:03 |
daemontool | ahah ok ty | 17:05 |
daemontool | I think so | 17:05 |
daemontool | reldan, we are going to disable py34 for kilo | 17:08 |
reldan | daemontool: I suppose yes, we should disable for kilo | 17:08 |
*** fabriziof has quit IRC | 17:11 | |
*** daemontool has quit IRC | 17:13 | |
*** fabriziof has joined #openstack-freezer | 17:24 | |
*** reldan has quit IRC | 18:00 | |
*** EmilDi has joined #openstack-freezer | 18:26 | |
*** slashme has quit IRC | 18:28 | |
*** slashme has joined #openstack-freezer | 18:33 | |
*** reldan has joined #openstack-freezer | 18:33 | |
openstackgerrit | Pierre Mathieu proposed openstack/freezer: Fix freezer for py3 compatibility https://review.openstack.org/278346 | 19:01 |
*** EmilDi has quit IRC | 19:03 | |
*** daemontool has joined #openstack-freezer | 19:04 | |
*** fabriziof has quit IRC | 19:07 | |
daemontool | all, this should solve, python34 and dsvm gate on kilo https://review.openstack.org/#/c/278323/ | 19:24 |
daemontool | but we still need to backport python34 fix to liberty | 19:24 |
*** daemontool has quit IRC | 19:38 | |
*** daemontool has joined #openstack-freezer | 20:08 | |
openstackgerrit | Fausto Marzi proposed openstack/freezer-api: Switch to testr from pytest https://review.openstack.org/260950 | 20:25 |
daemontool | vannif, ^^ | 20:39 |
daemontool | m3m0_, ping | 20:52 |
*** daemontool has quit IRC | 21:07 | |
*** daemontool has joined #openstack-freezer | 21:15 | |
*** reldan has quit IRC | 22:04 | |
*** reldan has joined #openstack-freezer | 22:10 | |
*** daemontool has quit IRC | 22:13 | |
*** daemontool has joined #openstack-freezer | 23:15 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!