| daemontool | the commit would be empty other than the version bump in setup.cfg | 00:00 |
|---|---|---|
| daemontool | or pep8 will need to be fixed next time we want backport a bug in stable/kilo | 00:00 |
| daemontool | not sure if I was clear | 00:01 |
| memogarcia | not really hahaha but I'm very tired at the moment | 00:01 |
| daemontool | ok np | 00:01 |
| daemontool | don't worry | 00:01 |
| memogarcia | ok do you think we can fix this issue or reldan should do it tomorrow? | 00:04 |
| memogarcia | I think he will be back | 00:04 |
| memogarcia | there is this name thing about freezer-web-ui | 00:06 |
| memogarcia | https://review.openstack.org/#/c/276777/ | 00:06 |
| daemontool | nope it's a different issue | 00:06 |
| memogarcia | It make sense to have freezer-web-ui as a name in the code but keep disaster recovery as a ui label only | 00:06 |
| daemontool | that is to enable the python-jobs in our repo as it is required | 00:06 |
| daemontool | ah ok | 00:07 |
| daemontool | sorry didn't get your comment in the first place | 00:07 |
| daemontool | I agree | 00:07 |
| daemontool | so | 00:07 |
| daemontool | frescof_, is publishing this coming week | 00:07 |
| daemontool | a bp for disaster recovery | 00:07 |
| daemontool | there's also some code ready afaik | 00:08 |
| memogarcia | but does that bp relates to freezer? | 00:08 |
| daemontool | for now let's have everything under disaster recovery | 00:08 |
| daemontool | after this specific disaster recovery task goes in | 00:08 |
| daemontool | we can have one tab for backup | 00:08 |
| daemontool | and one tab for disaster recovery | 00:08 |
| daemontool | I think so | 00:09 |
| memogarcia | I need to read that bp then :) | 00:09 |
| memogarcia | btw have you seen this? | 00:09 |
| memogarcia | https://github.com/borgbackup/borg | 00:09 |
| daemontool | it's the disaster recovery thing | 00:09 |
| memogarcia | I think we should integrated as an engine | 00:09 |
| daemontool | they guys have been working on | 00:10 |
| daemontool | yes | 00:10 |
| daemontool | it will afaik | 00:10 |
| daemontool | once we have the bp we can discuss this | 00:10 |
| memogarcia | oooo I think is the usha one | 00:10 |
| daemontool | borg is good, but there are issue for data dedup when using object storage I think | 00:11 |
| daemontool | anyway if we do that we cannot use the DLO support from swift | 00:12 |
| daemontool | we'll talking about this tomorrow | 00:12 |
| memogarcia | yep I'm closing my eyes, talk you tomorrow | 00:14 |
| memogarcia | have a good day over there :) | 00:14 |
| memogarcia | and I think is only python 3.4 or greater (borg) | 00:14 |
| *** EinstCrazy has joined #openstack-freezer | 01:50 | |
| *** EinstCrazy has quit IRC | 01:54 | |
| *** daemontool has quit IRC | 02:12 | |
| *** daemontool has joined #openstack-freezer | 02:13 | |
| *** daemontool has quit IRC | 02:47 | |
| *** mingyu has joined #openstack-freezer | 03:27 | |
| *** mingyu has quit IRC | 03:28 | |
| *** daemontool has joined #openstack-freezer | 03:38 | |
| *** EinstCrazy has joined #openstack-freezer | 03:46 | |
| *** EinstCrazy has quit IRC | 03:51 | |
| *** mingyu has joined #openstack-freezer | 04:21 | |
| *** EmilDi_ has joined #openstack-freezer | 04:38 | |
| *** EmilDi has quit IRC | 04:38 | |
| *** dschroeder has joined #openstack-freezer | 04:40 | |
| *** dschroeder has quit IRC | 04:58 | |
| *** daemontool has quit IRC | 06:53 | |
| *** daemontool has joined #openstack-freezer | 06:54 | |
| *** EinstCrazy has joined #openstack-freezer | 06:56 | |
| *** daemontool has quit IRC | 06:58 | |
| *** EinstCrazy has quit IRC | 07:02 | |
| *** samuelBartel has joined #openstack-freezer | 08:13 | |
| *** EinstCrazy has joined #openstack-freezer | 09:01 | |
| *** openstackgerrit has quit IRC | 09:02 | |
| *** openstackgerrit has joined #openstack-freezer | 09:03 | |
| *** EinstCrazy has quit IRC | 09:06 | |
| *** memogarcia has quit IRC | 09:48 | |
| *** memogarcia has joined #openstack-freezer | 10:07 | |
| *** reldan has joined #openstack-freezer | 10:33 | |
| *** mingyu has quit IRC | 10:39 | |
| *** reldan has quit IRC | 10:56 | |
| *** reldan has joined #openstack-freezer | 10:59 | |
| *** memogarcia has left #openstack-freezer | 11:09 | |
| *** memogarcia has joined #openstack-freezer | 11:09 | |
| *** mingyu has joined #openstack-freezer | 11:17 | |
| *** reldan has quit IRC | 11:43 | |
| openstackgerrit | Fabrizio Vanni proposed openstack/freezer: list backups stored in API https://review.openstack.org/277352 | 12:00 |
| *** reldan has joined #openstack-freezer | 12:00 | |
| openstackgerrit | Fabrizio Vanni proposed openstack/freezer: list backups stored in API https://review.openstack.org/277352 | 12:13 |
| openstackgerrit | Eldar Nugaev proposed openstack/freezer: Fix parsing multiline ini files https://review.openstack.org/277371 | 12:53 |
| *** daemontool has joined #openstack-freezer | 13:01 | |
| *** EinstCrazy has joined #openstack-freezer | 13:05 | |
| daemontool | Hi | 13:07 |
| daemontool | currently the pep8 gate fails on stable/liberty | 13:08 |
| daemontool | sorry | 13:08 |
| daemontool | stable/kilo | 13:08 |
| daemontool | I've tried to backport this commit https://review.openstack.org/#/c/266470/5 | 13:09 |
| *** EinstCrazy has quit IRC | 13:09 | |
| daemontool | the thing is that in stable/liberty that code is already there (otherwise pep8 would fail in stable/liberty too, but this is not the case) | 13:09 |
| daemontool | so now we have to find a way to fix that in kilo, but we cannot send patches directly on stable/kilo | 13:11 |
| daemontool | also, please review https://review.openstack.org/#/c/276488/ https://review.openstack.org/#/c/276768/ https://review.openstack.org/#/c/276777/ | 13:12 |
| openstackgerrit | Pierre Mathieu proposed openstack/freezer: Fix parsing multiline ini files https://review.openstack.org/277371 | 13:25 |
| openstackgerrit | Pierre Mathieu proposed openstack/freezer: Fix parsing multiline ini files https://review.openstack.org/277371 | 13:34 |
| openstackgerrit | Pierre Mathieu proposed openstack/freezer: Fix parsing multiline ini files https://review.openstack.org/277371 | 13:36 |
| openstackgerrit | Pierre Mathieu proposed openstack/freezer: Fix parsing multiline ini files https://review.openstack.org/277371 | 13:41 |
| openstackgerrit | Pierre Mathieu proposed openstack/freezer: Fix parsing multiline ini files https://review.openstack.org/277371 | 13:43 |
| openstackgerrit | Merged openstack/freezer: Add Sphinx doc build https://review.openstack.org/276488 | 14:04 |
| openstackgerrit | Merged openstack/freezer-api: Add Sphinx doc build https://review.openstack.org/276768 | 14:04 |
| openstackgerrit | Fabrizio Vanni proposed openstack/freezer: list backups stored in API https://review.openstack.org/277352 | 14:09 |
| openstackgerrit | Pierre Mathieu proposed openstack/freezer: Fix parsing multiline ini files https://review.openstack.org/277371 | 14:30 |
| openstackgerrit | Memo Garcia proposed openstack/freezer: Fix typo in keystone v3 creation dict https://review.openstack.org/277432 | 14:55 |
| *** EinstCrazy has joined #openstack-freezer | 14:57 | |
| *** EinstCrazy has quit IRC | 15:04 | |
| *** pennerc has joined #openstack-freezer | 16:16 | |
| openstackgerrit | Daniel Mellado proposed openstack/freezer: Start using oslosphinx theme for docs https://review.openstack.org/277484 | 16:27 |
| dmellado | daemontool: btw small update for the sphinx doc ;) | 16:28 |
| dmellado | + is there any reason for the double .gitignore (root folder + doc folder)? | 16:29 |
| dmellado | ping memogarcia ^^ | 16:30 |
| *** Slashme has joined #openstack-freezer | 16:31 | |
| memogarcia | sup dmellado, como estas? | 16:31 |
| dmellado | hey, cool ;) | 16:31 |
| daemontool | nope, we would manage that from the root .gitignore without any problem at all, | 16:31 |
| dmellado | daemontool: then I'll follow up with a patch | 16:31 |
| dmellado | + also added openstack style for the docs ;) | 16:32 |
| daemontool | dmellado, ok ty | 16:32 |
| daemontool | brilliant | 16:32 |
| dmellado | https://review.openstack.org/277484 | 16:32 |
| dmellado | feel free to have a look | 16:32 |
| daemontool | dmellado, on that I think oslosphinx was already in the test-requirements.txt | 16:35 |
| daemontool | line 6 | 16:35 |
| daemontool | but probably it wasn't used | 16:35 |
| dmellado | daemontool: typo | 16:35 |
| openstackgerrit | Daniel Mellado proposed openstack/freezer: Start using oslosphinx theme for docs https://review.openstack.org/277484 | 16:35 |
| dmellado | ;) | 16:35 |
| *** Slashme has quit IRC | 16:35 | |
| daemontool | dmellado, pylint too | 16:36 |
| dmellado | + I changed it now to be consistent with other projects' test-requirements | 16:36 |
| daemontool | that's good | 16:36 |
| daemontool | but pylint is repeated | 16:36 |
| dmellado | damn, blame my setup, hold a second | 16:36 |
| daemontool | ty | 16:37 |
| openstackgerrit | Daniel Mellado proposed openstack/freezer: Start using oslosphinx theme for docs https://review.openstack.org/277484 | 16:37 |
| dmellado | at last! xD | 16:37 |
| dmellado | sorry for the duplication, and blame my 'yanks' | 16:38 |
| dmellado | daemontool: xD | 16:38 |
| daemontool | np thanks | 16:38 |
| daemontool | I'll give +2 as soon as it is verified | 16:38 |
| dmellado | cool | 16:39 |
| dmellado | hope everything's great in the US (don't do like a friend of mine working in Seattle, I met him over christmas and he looked like his oversized twin) | 16:39 |
| dmellado | xD | 16:39 |
| daemontool | haha let's hope not | 16:41 |
| daemontool | currently I'm not in US but I should move there soon | 16:41 |
| dmellado | if you happen to go to San Jose premises, let me know, I've got a friend over there | 16:43 |
| openstackgerrit | Pierre Mathieu proposed openstack/freezer: Fix parsing multiline ini files https://review.openstack.org/277371 | 16:48 |
| daemontool | dmellado, ok | 16:53 |
| daemontool | I'll be based in Texas | 16:54 |
| daemontool | but CA is always in the middle, lol :) | 16:54 |
| daemontool | reldan, ping | 17:03 |
| reldan | daemontool: pong! | 17:03 |
| daemontool | reldan, do you remember per chance the commit we used to fix pep8 issues on stable/liberty? | 17:04 |
| daemontool | cause in stable/kilo we have the same issue right now | 17:04 |
| daemontool | and I'd like to backport that | 17:04 |
| reldan | daemontool: yes sure | 17:04 |
| daemontool | it was the logging one? | 17:04 |
| reldan | Yes, with logging | 17:04 |
| daemontool | all, please review https://review.openstack.org/#/c/276777/ | 17:05 |
| daemontool | but the that changes were already in liberty | 17:05 |
| daemontool | https://review.openstack.org/#/c/266470/5 | 17:05 |
| daemontool | that is for master | 17:05 |
| daemontool | that is for liberty https://review.openstack.org/#/c/277188/1 | 17:06 |
| daemontool | but if you see | 17:06 |
| daemontool | after the cherry-pick | 17:06 |
| daemontool | only the arguments.py file is merged | 17:06 |
| daemontool | and also that shouldn't happen | 17:06 |
| daemontool | as there's a repetition of --log-level and nothing more | 17:06 |
| daemontool | so that should be removed | 17:06 |
| daemontool | the things is that is we remove that the commit is empty | 17:07 |
| daemontool | and that same commit cannot be backported to kilo | 17:07 |
| daemontool | there's a conflict I didn't go deep | 17:07 |
| reldan | daemontool: How I can help with that? | 17:07 |
| daemontool | so now we have to resolve the pep8 issue in kilo | 17:08 |
| daemontool | I'd like to undersatnd | 17:08 |
| daemontool | on which commit | 17:08 |
| daemontool | we resolved | 17:08 |
| daemontool | the pep8 issue on liberty | 17:08 |
| daemontool | and backport that to kilo | 17:08 |
| daemontool | hoping that we committed a patch only for that | 17:08 |
| daemontool | me you vannif or memogarcia did that | 17:08 |
| daemontool | can't remember who | 17:09 |
| daemontool | and I can't find a commit for that in the history | 17:09 |
| reldan | That is original commit in master https://github.com/openstack/freezer/commit/8f4b53da6836fd2426dde1072ce7b8d7332f7473 | 17:09 |
| daemontool | ok, so we need to backport that to kilo | 17:10 |
| reldan | And last commit to stable/kilo is committed with sl4shme on Nov 20, 2015 | 17:10 |
| reldan | I can try to do it | 17:10 |
| daemontool | and I did that here https://review.openstack.org/#/c/277188/1 | 17:10 |
| daemontool | here https://review.openstack.org/#/c/277188/1/freezer/arguments.py | 17:10 |
| daemontool | log-level is repeated | 17:11 |
| daemontool | if we remove it there's no change | 17:11 |
| daemontool | and than we have to merge an empty commit | 17:11 |
| daemontool | reldan, can you ping Slashme there if he can join IRC? | 17:11 |
| reldan | I don’t see him now | 17:11 |
| *** samuelBartel has quit IRC | 17:13 | |
| *** mingyu has quit IRC | 17:15 | |
| *** mingyu has joined #openstack-freezer | 17:16 | |
| *** mingyu has quit IRC | 17:16 | |
| *** mingyu has joined #openstack-freezer | 17:16 | |
| reldan | daemontool: I suppose the easiest way I can offer to you - I can fix pep in stable/kilo and make a new pull request | 17:18 |
| *** memogarcia has quit IRC | 17:26 | |
| *** mingyu has quit IRC | 17:30 | |
| *** mingyu has joined #openstack-freezer | 17:30 | |
| daemontool | reldan, I don't think we can commit patches directly on stable/kilo | 17:34 |
| reldan | daemontool: why not? | 17:35 |
| daemontool | I think we have to cherry-pick it from a parent repo | 17:35 |
| daemontool | try it | 17:35 |
| reldan | daemontool: I just tried to cherry-pick pep8 fix and it seems a lot of conflicts | 17:35 |
| daemontool | yep :( | 17:36 |
| reldan | because two branches is very far from each other | 17:36 |
| reldan | and fixes pep8 in master is intermixed with additonal changes and probably even don’t cover all pep8 problems in stable/kilo | 17:36 |
| daemontool | once you have a related cherry-pick from a parent repo | 17:37 |
| daemontool | you can modify the content of the commit for an older stable branch | 17:37 |
| reldan | both modified: freezer/apiclient/client.py | 17:37 |
| reldan | both modified: freezer/arguments.py | 17:37 |
| reldan | both modified: freezer/backup.py | 17:37 |
| reldan | both modified: freezer/engine/engine.py | 17:37 |
| reldan | both modified: freezer/main.py | 17:37 |
| reldan | both modified: freezer/scheduler/arguments.py | 17:37 |
| reldan | both modified: freezer/scheduler/freezer_scheduler.py | 17:37 |
| reldan | both modified: freezer/scheduler/utils.py | 17:37 |
| reldan | deleted by us: freezer/scheduler/win_daemon.py | 17:37 |
| reldan | deleted by us: freezer/scheduler/win_service.py | 17:37 |
| reldan | both modified: freezer/storage/swift.py | 17:37 |
| reldan | both modified: freezer/streaming.py | 17:37 |
| reldan | both modified: freezer/utils.py | 17:37 |
| reldan | both modified: freezer/vss.py | 17:37 |
| reldan | both modified: freezer/winutils.py | 17:37 |
| reldan | I would prefer to have different commit, because they will be absolutely different | 17:37 |
| reldan | to many conflicts | 17:38 |
| reldan | too | 17:38 |
| daemontool | reldan, if we can do it, OK | 17:38 |
| reldan | Let me try then! | 17:38 |
| daemontool | but I don't think gerrit allow us to do that | 17:38 |
| daemontool | ok | 17:38 |
| daemontool | sure | 17:38 |
| reldan | Thanks! | 17:38 |
| daemontool | you never needed my permission to do anything by the way lol :) | 17:39 |
| daemontool | haha | 17:39 |
| reldan | :) | 17:51 |
| *** daemontool has quit IRC | 17:58 | |
| *** daemontool has joined #openstack-freezer | 17:58 | |
| *** reldan has quit IRC | 18:08 | |
| *** reldan has joined #openstack-freezer | 18:08 | |
| *** reldan has quit IRC | 18:09 | |
| *** daemontool has quit IRC | 18:09 | |
| *** daemontool_ has joined #openstack-freezer | 18:09 | |
| openstackgerrit | Pierre Mathieu proposed openstack/freezer: Fix parsing multiline ini files https://review.openstack.org/277371 | 18:39 |
| *** memogarcia has joined #openstack-freezer | 18:41 | |
| daemontool_ | please anyone around to review https://review.openstack.org/#/c/276777/ | 18:51 |
| *** reldan has joined #openstack-freezer | 19:00 | |
| *** EinstCrazy has joined #openstack-freezer | 19:04 | |
| *** EinstCrazy has quit IRC | 19:09 | |
| daemontool_ | reldan, any joy? | 19:24 |
| *** reldan has left #openstack-freezer | 19:26 | |
| *** daemontool_ has quit IRC | 19:56 | |
| *** memogarcia has quit IRC | 20:09 | |
| *** daemontool has joined #openstack-freezer | 20:10 | |
| *** Slashme has joined #openstack-freezer | 20:15 | |
| *** Slashme has quit IRC | 20:20 | |
| *** daemontool_ has joined #openstack-freezer | 22:04 | |
| *** daemontool has quit IRC | 22:06 | |
| *** Slashme has joined #openstack-freezer | 22:25 | |
| *** Slashme has quit IRC | 22:31 | |
| *** pennerc has quit IRC | 22:34 | |
| *** EinstCrazy has joined #openstack-freezer | 22:58 | |
| *** Slashme has joined #openstack-freezer | 23:02 | |
| *** EinstCrazy has quit IRC | 23:05 | |
| *** daemontool_ has quit IRC | 23:07 | |
| *** Slashme has quit IRC | 23:08 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!