Friday, 2015-11-20

« Thursday, 2015-11-19 Index Saturday, 2015-11-21 »
*** reldan has quit IRC00:00
*** dschroeder has quit IRC00:00
*** reldan has joined #openstack-freezer00:10
*** daemontool_ has quit IRC01:41
*** daemontool_ has joined #openstack-freezer01:42
*** reldan has quit IRC03:12
*** daemontool_ has quit IRC04:58
*** daemontool_ has joined #openstack-freezer04:58
*** daemontool_ has quit IRC08:36
*** daemontool_ has joined #openstack-freezer08:39
*** reldan has joined #openstack-freezer09:07
daemontool_Morning09:34
*** reldan has quit IRC09:35
daemontool_vannif, ping09:40
vannifmorning09:41
daemontool_vannif,  how do we remove pep3143 as dep09:42
daemontool_?09:42
daemontool_are we placing that 2 files in the repo and that's it?09:42
daemontool_I mean the 2 files in the pep3143daemon repo09:43
daemontool_here https://github.com/schlitzered/pep3143daemon/tree/master/pep3143daemon09:43
*** jonaspf has joined #openstack-freezer09:44
vannifI was thinking to place the relevant code to go into daemon mode in the freezer-scheduler code09:49
vannifthe Daemon class to be more precise. only the code that is needed09:49
daemontool_why not put directly the content of https://github.com/schlitzered/pep3143daemon/tree/master/pep3143daemon09:51
*** reldan has joined #openstack-freezer10:08
openstackgerritMerged openstack/freezer: Fix metadata storage  https://review.openstack.org/24751810:33
*** reldan has quit IRC11:14
*** reldan has joined #openstack-freezer11:31
daemontool_vannif,  if we put that directory on a dir let's say called lib11:32
daemontool_there's very little changes to do11:32
daemontool_reldan,  please do not approve your own commit11:33
reldanI had a +2 from you and +1 from memo. What I should do in this situation?11:34
reldanWe have critical bug in master and in stable/kilo. What I should do?11:34
daemontool_ask to vannif Slashme ffresh  to approve11:34
reldanOk then11:34
daemontool_I understand that11:34
daemontool_vannif,  we need to move fast also with pep314311:38
reldanPlease merge it to fix stable/kilo at your convenience https://review.openstack.org/#/c/246460/11:48
daemontool_reldan,  ok just to be sure, you followe this guide right? https://wiki.openstack.org/wiki/StableBranch11:49
daemontool_in particular11:49
daemontool_$> git checkout stable/icehouse11:49
daemontool_$> git cherry-pick -x $master_commit_d11:49
daemontool_$> git review stable/icehouse11:49
daemontool_?11:49
daemontool_or click cherry pick to button from gerrit?11:49
reldanYes, but without -x, if it is significant I can rerun it with -x option11:50
daemontool_in the documentation it says11:51
daemontool_Note: cherry-pick -x option includes 'cherry-picked from ...' line in the commit message which is required to avoid Gerrit bug11:51
reldannot a problem11:51
daemontool_this is the gerrit bug https://code.google.com/p/gerrit/issues/detail?id=110711:51
daemontool_not sure if in the gerrit version used in openstack-infra that bug is fixed11:51
reldanFixed now11:52
reldanChange-Id: I0869b7d432e8f8a7f0839e4670a8845bf932e69c11:52
reldan(cherry picked from commit 5d577d043a4c192a8446b930447dafef0ad586dc)11:52
reldandaemontool_: Is it good now?11:54
*** szaher_ has quit IRC11:55
reldanNope?11:58
*** daemontool_ has quit IRC11:58
*** daemontool_ has joined #openstack-freezer12:01
*** jonaspf has quit IRC12:01
daemontool_reldan,  yes it is12:03
daemontool_as soon it is verified I'll give +212:04
reldandaemontool_: Thank you, please merge it at your convenience12:04
daemontool_vannif, Slashme  m3m0  ffresh  please review https://review.openstack.org/#/c/246460/12:17
*** jonaspf has joined #openstack-freezer12:22
*** szaher_ has joined #openstack-freezer12:27
*** reldan has quit IRC12:33
Jokke_daemontool_: ping12:34
daemontool_Jokke_,  yes12:35
daemontool_tell me some good news please12:35
daemontool_lol12:36
Jokke_I was just looking that reldan's backport12:36
daemontool_yes12:36
Jokke_it looks fine, are you ok if I just make a small note to the commit message before approving it?12:36
daemontool_sure!12:36
*** jonaspf has quit IRC12:36
Jokke_just to point out the diff between proposed and cherrypick12:37
daemontool_perfect12:37
daemontool_Jokke_,  also that should have the version bumped in setup.cfg  right?12:37
daemontool_the one in stable/kilo12:39
*** jonaspf has joined #openstack-freezer12:39
Jokke_yup +2A12:39
Jokke_daemontool_: wasn't it merged yet?12:39
Jokke_should be as the tests passes12:40
daemontool_yes12:41
daemontool_but I think we forgot bumping version in setup.cfg12:41
daemontool_is that right?12:41
daemontool_it should fail the verification now probably12:42
Jokke_81bbb0befd826dfd4e6d6b76c8a6c51773ef6e1612:44
Jokke_that's the hash for the version bump :P12:44
daemontool_ok12:46
daemontool_:)12:46
daemontool_vannif,  ping12:51
*** reldan has joined #openstack-freezer12:52
*** samuelBartel has joined #openstack-freezer12:55
vannifaye, I was in a meeting12:56
daemontool_vannif,  ok13:02
daemontool_so why not adding this directory that contains two files of few hundreds of lines13:02
daemontool_https://github.com/schlitzered/pep3143daemon/tree/master/pep3143daemon13:03
daemontool_so the changes will be little from our side13:03
daemontool_I can do that13:03
daemontool_we create a new directory called lib13:03
daemontool_and that's it13:03
daemontool_not the best solution but the problem is solved once for all13:03
daemontool_and with newer version of pbr we are good13:03
daemontool_as we said yestarday13:04
daemontool_Jokke_,  why here https://review.openstack.org/#/c/246460/ test_job.py is incompatible?13:06
daemontool_subunit was supported also before13:06
daemontool_that tests were skipped before13:07
daemontool_with the transitino from pytest to testr13:07
Jokke_daemontool_: if you compare the change proposed to stable/kilo and the one where it was cherry picked from that file has lots of difference13:08
Jokke_thus just flagging out that it's not direct cherrypick13:08
daemontool_ah ok13:09
daemontool_so when files are modified in the cherrypick process we need to state that in the commit message13:09
Jokke_yes13:09
daemontool_ok ty13:09
Jokke_one reason to use the cherry-pick -x is to get that cherry-picked from line so people can verify that it's actually backport without hunting the change13:10
Jokke_"original change"13:10
Jokke_and if there is diff between is nice to explain that in the commit message13:10
daemontool_ok ty13:11
daemontool_ping -f vannif13:12
daemontool_ping -s 1500 -f vannif  (fragmented)13:13
Jokke_LOL13:13
daemontool_:)13:13
openstackgerritFausto Marzi proposed openstack/freezer: Import pep3134daemon as local module  https://review.openstack.org/24806913:23
vannifif you think it solves the issue quickly ...13:23
openstackgerritFausto Marzi proposed openstack/freezer: Import pep3134daemon as local module  https://review.openstack.org/24806913:28
daemontool_vannif,  with that we are sure it works13:29
daemontool_on that module, there's code in __init__.py and the other two files13:29
daemontool_it's not a good solution at all13:29
daemontool_but we solve the kilo issue and move forward13:30
daemontool_start working fully on liberty13:30
vannifok. should I go on putting that feature in the freezer-scheduler code ? so we get rid of the lib stuff ?13:30
daemontool_which feature?13:32
daemontool_are you referring about the file location?13:33
vannifdaemonizing13:33
daemontool_so13:33
daemontool_my point is13:33
daemontool_there are 3 files there13:33
daemontool___init__.py, daemon.py and pid.py13:33
daemontool_if we place that files locally13:34
daemontool_we are 100% sure it work13:34
daemontool_we just need to change the import13:34
daemontool_path13:34
daemontool_for that module in the old code13:34
daemontool_and it works as it is working now13:34
daemontool_my question is13:34
daemontool_if you take only the classes, are you 100% sure it will work as it is now?13:34
daemontool_cause probably we should invest time now on liberty13:35
openstackgerritPierre Mathieu proposed openstack/freezer: Import pep3134daemon as local module  https://review.openstack.org/24806913:45
Slashmedaemontool_: ^^13:45
*** ddieterly has joined #openstack-freezer14:15
daemontool_hi ddieterly  :)14:16
ddieterlyhi14:16
daemontool_how are you doing14:16
ddieterlyfine thanks14:16
daemontool_are we going to have the meeting today?14:16
ddieterlyat what time/14:17
daemontool_so I've just saw you can't at 16:0014:17
ddieterlyrigth14:17
daemontool_ok14:17
daemontool_now?14:17
ddieterlyi have to drive to the office14:18
daemontool_ok14:18
ddieterlyi'll be there in 30 minutes14:18
ddieterlymy calendar is fairly open today14:18
daemontool_ok let's do that14:18
daemontool_I have a meeting around that time14:20
daemontool_If  I'm busy we'll see if we can talk later14:20
ddieterlyyou can just schedule some time on my calendar that is free14:20
daemontool_yes ddieterly the think is that I'm on GMT +1 and I'd like to avoid having meeting Fri at 7pm is possible14:22
daemontool_s/is/if/14:22
ddieterlywhat time is it now at your locaation?14:23
daemontool_15:2714:26
daemontool_I have a 1:1 at 18:0014:27
daemontool_ok14:27
*** ddieterly has quit IRC14:27
*** daemontool has joined #openstack-freezer14:35
openstackgerritMemo Garcia proposed openstack/freezer: Freezer instructions for Windows  https://review.openstack.org/24811414:36
m3m0daemontool, could you help me to review this: https://review.openstack.org/24811414:37
daemontoolm3m0,  ok14:37
daemontoollooking14:37
*** daemontool_ has quit IRC14:37
m3m0and the next step is to have an installer on windows, because we need to install lots of dependencies manually14:40
openstackgerritEldar Nugaev proposed openstack/freezer: Parallel backup  https://review.openstack.org/24784014:49
reldanHi all, I actually want to share my current progress. I need to add .osrc suport, readme, etc. But this version can successfully backup and restore into several local/ssh storages14:50
daemontoolvannif, *I think*, we can safely import the classes inside the daemon.py file14:50
daemontoolvannif,  what do you think?14:50
vannifthat is what I was thinking. more or less.14:51
openstackgerritEldar Nugaev proposed openstack/freezer: Parallel backup  https://review.openstack.org/24784014:51
daemontoolwe need also the content of pidfile.py14:52
daemontoolI wonder if really that make sense...14:52
daemontoolprobably we could just leave it as it is14:52
m3m0cool reldan :) I need to sync up with you to integrate in windows and in the ui14:52
daemontooland add the licenses things14:52
m3m0reldan, let me know when you need review14:53
reldanThank you, sure!14:53
daemontoolvannif, I'm sending a new patchset14:56
openstackgerritMemo Garcia proposed openstack/freezer: Freezer instructions for Windows  https://review.openstack.org/24811415:08
openstackgerritMemo Garcia proposed openstack/freezer: Freezer instructions for Windows  https://review.openstack.org/24811415:10
openstackgerritMerged openstack/freezer: Freezer instructions for Windows  https://review.openstack.org/24811415:29
openstackgerritFausto Marzi proposed openstack/freezer: Import pep3134daemon as local module  https://review.openstack.org/24806915:37
daemontoolm3m0, reldan ffresh vannif  Slashme Jokke_  please review https://review.openstack.org/#/c/248069/315:37
daemontoolsorry https://review.openstack.org/#/c/248069/15:38
daemontoolI think we need to keep that for liberty too15:39
daemontoolvannif, any news about https://review.openstack.org/#/c/246993/2/requirements.txt ?15:43
vannifI'm going to remove that method, so we can be fully compliant15:46
daemontoolok15:50
daemontoolthat's a blocker for liberty15:50
*** dschroeder has joined #openstack-freezer16:05
*** daemontool has quit IRC16:59
*** daemontool has joined #openstack-freezer17:02
*** samuelBartel has quit IRC17:02
*** reldan has quit IRC17:07
*** memogarcia has joined #openstack-freezer17:48
*** daemontool has quit IRC18:05
*** daemontool has joined #openstack-freezer18:07
*** reldan has joined #openstack-freezer18:16
daemontoolanyone around to review: https://review.openstack.org/#/c/248069/18:26
*** szaher_ has quit IRC18:28
memogarcia+1 daemontool18:32
daemontoolmemogarcia, why on the last days you are going +1 only? lol?18:33
daemontoolconservative it's a good thing :)18:33
daemontoolwell done18:34
*** jonaspf has quit IRC18:36
*** jonaspf has joined #openstack-freezer18:39
*** jonaspf has quit IRC18:54
memogarciabecause is better if more people gets to review the code18:55
memogarciaso we can avoid breaking stuff :)18:56
*** jonaspf has joined #openstack-freezer18:56
memogarciaI think I'm going to move from windows_service to new approach for windows18:56
*** reldan has quit IRC19:03
*** jonaspf has quit IRC19:11
*** jonaspf has joined #openstack-freezer19:28
*** jonaspf has quit IRC19:42
daemontoolmemogarcia, ++20:07
*** jonaspf has joined #openstack-freezer20:58
*** openstack has joined #openstack-freezer21:06
*** daemontool has quit IRC21:19
*** daemontool has joined #openstack-freezer21:19
*** jonaspf has quit IRC21:24
*** jonaspf has joined #openstack-freezer22:09
*** jonaspf has quit IRC22:24
*** jonaspf has joined #openstack-freezer22:46
*** jonaspf has quit IRC23:02
*** jonaspf has joined #openstack-freezer23:46
« Thursday, 2015-11-19 Index Saturday, 2015-11-21 »

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!