Thursday, 2015-10-15

*** dschroeder has quit IRC00:49
*** marzif has joined #openstack-freezer08:12
*** reldan has joined #openstack-freezer08:14
*** marzif has quit IRC08:19
*** marzif has joined #openstack-freezer08:20
*** reldan has quit IRC08:26
*** reldan has joined #openstack-freezer09:02
*** marzif_ has joined #openstack-freezer09:04
*** marzif has quit IRC09:04
*** jonaspf has joined #openstack-freezer09:09
openstackgerritMemo Garcia proposed stackforge/freezer-web-ui: Fixed retrieval of freezer url from keystone catalog  https://review.openstack.org/23484409:12
openstackgerritMerged stackforge/freezer: Test Coverage: Improving test coverage by creation fs_like storage  https://review.openstack.org/23427009:57
*** reldan has quit IRC11:00
*** reldan has joined #openstack-freezer11:04
openstackgerritEldar Nugaev proposed stackforge/freezer: Forgotten return in ssh  https://review.openstack.org/23527111:35
*** marzif_ has quit IRC11:57
*** marzif_ has joined #openstack-freezer11:58
openstackgerritMerged stackforge/freezer: Forgotten return in ssh  https://review.openstack.org/23527112:18
*** marzif_ has quit IRC12:28
*** marzif_ has joined #openstack-freezer12:28
*** reldan has quit IRC12:58
*** marzif_ has quit IRC13:02
*** marzif_ has joined #openstack-freezer13:03
openstackgerritMerged stackforge/freezer-web-ui: Fixed retrieval of freezer url from keystone catalog  https://review.openstack.org/23484413:06
*** marzif_ has quit IRC13:08
openstackgerritMerged stackforge/freezer-web-ui: Fix: Job creation now sends client_id instead of uuid  https://review.openstack.org/23423413:08
*** reldan has joined #openstack-freezer13:14
*** dschroeder has joined #openstack-freezer13:59
openstackgerritFausto Marzi proposed stackforge/freezer: Swift from pytest to testr for unittests  https://review.openstack.org/23538714:29
openstackgerritFausto Marzi proposed stackforge/freezer: Swift from pytest to testr for unittests  https://review.openstack.org/23538714:30
daemontool_all: this is very important, please review https://review.openstack.org/23538714:30
vannifhi everyone15:10
daemontool_Hi vannif15:10
vannifshall we start the meeting ?15:11
daemontool_yep15:11
vannif#startmeeting 2015-10-1515:12
freezerBot`Meeting started Thu Oct 15 15:12:27 2015 UTC and is due to finish in 60 minutes.  The chair is vannif. Information about MeetBot at http://wiki.debian.org/MeetBot.15:12
freezerBot`Useful Commands: #action #agreed #help #info #idea #link #topic #startvote.15:12
freezerBot`The meeting name has been set to '2015_10_15'15:12
openstackMeeting started Thu Oct 15 15:12:27 2015 UTC and is due to finish in 60 minutes.  The chair is vannif. Information about MeetBot at http://wiki.debian.org/MeetBot.15:12
openstackUseful Commands: #action #agreed #help #info #idea #link #topic #startvote.15:12
openstackThe meeting name has been set to '2015_10_15'15:12
vannifhi everyone15:12
vannifdaemontool_ would you start ?15:13
daemontool_ok15:13
daemontool_I've been working mainly on testing15:13
daemontool_helping vannif   integrated testing with devstack15:14
daemontool_and also now I'm working on moveing from pytest to testr15:14
daemontool_to be consistent witht he other openstack proejcts15:14
daemontool_the issue with this15:14
daemontool_is that many of our unittests are now incompatible15:14
daemontool_because of the use of monkeypatch from pytests15:15
daemontool_the unittests needs to be changed asap after  https://review.openstack.org/235387 lands in15:15
daemontool_I'm planning this week also to swift the stackforge/freezer repo to PBR15:15
daemontool_that's all from me15:15
vannifcan you give a rough estimate of the effort to remove the dependency on pytest ?15:17
daemontool_I think it will take ~2 weeks15:17
daemontool_realistically15:17
daemontool_these are the bp for pbr and testr https://blueprints.launchpad.net/freezer/+spec/switch-to-pbr  https://blueprints.launchpad.net/freezer/+spec/swift-to-testr15:18
daemontool_I'll be full on it to have it completed15:18
daemontool_asap15:18
daemontool_reldan,  I think this task involves you too15:18
reldanYes, sure. I have some pytest tests and can help with migration15:19
reldanI work with tests anyway, so can replace pytes to unittest step by step15:19
daemontool_perfect15:20
daemontool_afaik the probelm is only with monkeypatch15:20
daemontool_s/probelm/problem/15:20
vannifgood. maybe everyone can help moving it's own part of code to unittest15:20
daemontool_that's be fantastic15:21
vannifI've recently moved the tests for lvm to unittest. if you know the code, it's faster. even though to be really good the tests should be written by someone else ;)15:22
vannifok.15:22
vannifreldan ?15:22
reldanThank you15:23
daemontool_ok15:23
reldanI was improving test coverage. So I wrote additional tests and for example improved ssh and local storeages in terms of code deduplication15:23
reldanNow ssh only has stuff related to work with ssh and local only os.blabla invokations15:24
reldanI have 62 code coverage overall. The biggest uncovered part is scheduler, so I’m trying to write some tests on it. At least invoke methods to catch syntax errors if any15:25
reldanAlso the problem part is OpenStack Cinder/Nova backups15:25
reldanCurrent coverage is http://pastebin.com/GfAdZ3cE15:26
reldanAlso ssh paramiko is very-very slow. Probably we should try some different libary after release. And I have an idea how to read only part of backups from ssh - probably it will improve speed of our integration tests with ssh15:27
reldanBecause they get all backups many many times pre run15:27
reldanIt is all from my side15:27
vannifthank you. remember not to use pytest ;)15:28
reldanYes, sure :) Thank you15:28
vannifon my side15:28
vannifthe freezer-api devstack plugin is ready.15:29
vannifwell, almost.15:29
vannifI just need to add a few lines in the readme15:29
vannifand the plugin for the web-ui also.15:30
vannifso, all it takes to have freezer, freezer-api and freezer-web-ui working in devstack is a couple of lines in the local.conf15:30
daemontool_vannif,  sorry one sec15:30
daemontool_reldan,  why paramiko is slow, do you have an idea?15:30
*** openstackgerrit has quit IRC15:31
*** openstackgerrit has joined #openstack-freezer15:32
reldanI have read a lot of message threads on stackoverflow and in repo of paramiko. And I also saw a lot of branches where some guys are trying to resolve it. As far as I know Fabric has it’s own fork of paramiko15:32
reldanBut why paramiko is so slow - id don’t know. https://www.google.ie/search?q=paramiko+is+slow&oq=paramiko+is+slow&aqs=chrome..69i57j69i60l2j0l3.2588j0j7&sourceid=chrome&es_sm=91&ie=UTF-815:33
daemontool_ok...15:33
reldanProbably it has some problem with buffers15:33
reldanI read it reads information byte-by-byte15:34
daemontool_ah ok15:34
daemontool_there's some for in binary_data there....15:34
reldanI’m not sure, but it seems to be a common problem15:34
daemontool_ok15:34
reldanI have found it - but don’t try it yet https://github.com/wallix/pylibssh215:34
reldanand it is old15:35
daemontool_let's have a meeting at some point about it15:35
daemontool_but how much is slow15:35
daemontool_how much MB/s can we transfer?15:35
daemontool_do you have an idea?15:35
reldanNope, but it is really slow - I work with hpcloud and even listdir takes minutes15:36
daemontool_ah.....15:36
daemontool_ok15:36
vannifthat's really slow15:37
daemontool_yes15:37
reldanI was trying to tune windows size - didn’t help15:38
reldanwindow size15:38
daemontool_ok15:38
vannifwindow size of tcp connection ?15:38
reldanYes15:38
daemontool_what uses ansible under the hood?15:38
vannifhmm. that should be a separate issue. the OS should take care of that ...15:39
daemontool_I'm not sure it's the tcp windows15:39
vannifI think paramiko15:39
daemontool_anyway we need to find a solution about it15:40
daemontool_but I have to say reldan  with the tests from vanni15:40
reldanI know that Fabric uses paramiko15:40
daemontool_using ssh15:40
reldan# Development version of Paramiko, just in case we're in one of those phases.15:40
reldan-e git+https://github.com/paramiko/paramiko#egg=paramiko15:40
reldan# Pull in actual "you already have local installed checkouts of Fabric +15:40
daemontool_it wasn't that slow...15:40
reldan# Paramiko" dev deps.15:40
reldan-r dev-requirements.txt15:40
daemontool_vannif,  do you remember the tests we did also for the demo?15:40
daemontool_it was acceptable15:40
daemontool_we should try to transfer few GB15:41
reldanI suppose it is because your ssh machine was not in hpcloud15:41
vannifno, sorry, ansible uses paramiko as a fall back15:41
daemontool_ah ok15:41
vannifit uses something else15:41
daemontool_we where using a devstack instance15:41
daemontool_we'll check this in the future15:42
daemontool_s/future/near future/15:42
daemontool_:)15:42
daemontool_now let's fix the tests things15:42
vannifyes, definitely. it wouldn't be bad to have a summary of the upload/download speed of the backups15:42
reldanSure!15:42
reldanAgree15:42
reldanProbably we need some test installation15:43
reldanWith distribute metrics15:43
reldanLike http://graphite.wikidot.com/15:44
vannifyou know that the temperature of the exhaust gas from an engine is an important parameter to understand if the engines are healthy and in good operating conditions ? so should be the effective transfer rate for freezer engines :)15:44
reldanAgree. It will be great to actually do some improvement and see - that after merging we actually have improvement )15:45
vannifyes. I'll help you with that if you want. it's interesting15:46
reldanLet’s say we can have a machine that will be do every 2 hours backup of 1 GB of data to different storages and report transfer speed/errors/…15:46
reldanWe also can use https://www.elastic.co/products/kibana for gathering errors from multiple instances15:47
reldanhttps://www.elastic.co/videos/kibana-logstash15:47
daemontool_that's th centralized logging tool used in helion :)15:47
vannifyes, with elasticsearch it will be easy to gather statistics and trigger alarms upon threshold crossings15:48
vannifanyway ... back on track15:48
reldanSo let’s say we will have several machines and they will check new code from repo, run big tests with actual data and show errors and performance15:48
reldanOk15:49
daemontool_reldan,  can you try to disable compression in paramiko if enabled by default?15:49
vannifwe need to invertigate the effective speed and possible alternatives to paramiko, right ?15:49
daemontool_we are always sending compressed data with freezer15:49
reldanYes, I have checked that - no improvement15:49
daemontool_ok15:49
reldanIt will be great. I know how to reduce count of invoking listdir significantly, but still have no idea how to improve transfer15:50
vannifwhich should play the biggest part in large backups, right ?15:51
reldanIt depends on how many backups do we already have in our repo15:51
reldanNow I have one additional listdir per zero-level-backup15:52
reldanI actually can reduce number - if I need only last one for example - I should get number or zero-level and then get all incremental only for this backup15:52
reldanSo instead of n+1 backups I can get 215:53
daemontool_reldan,  did you take a looka at this? http://asyncssh.readthedocs.org/en/latest/15:53
reldannot backups - listdirs15:53
daemontool_check under "Direct TCP connections"15:53
vannifso, you are getting listdirs which could be avoided ?15:54
reldanWe can try15:54
reldanYes, I can define only zero-level backup that I need and make only one additional checks for increments instead of doing it for all zero-level backups15:55
daemontool_ok, I 've never used it, just found it now, so t might not fit the purpose15:55
reldanWill see15:55
vannifit seems it requires python 3.415:56
daemontool_there's a port for python 215:56
daemontool_http://trollius.readthedocs.org/15:56
daemontool_+ https://github.com/ronf/asyncssh15:56
vannifdamn back ports ... we'll never get rid of python2 ... nor IPv4 :)15:57
daemontool_haha15:57
reldan)))15:57
daemontool_let's move forward15:59
daemontool_:)15:59
vannifshall we move forward ?15:59
vannifok15:59
vannif:)15:59
vannifso. as I was saying, the plugins for devstack are ready15:59
vannifin review16:00
vannifthey "work on my machine" :)16:00
vannifbut you're encouraged to test them on your VMs16:00
vannifaah, only thing, you need to adjust the git repo to one on your local machine where you have the correct patchset, so that devstack will clone and install that repo/branch16:01
vannifthanks daemontool_ for the support :)16:02
vannifI'm also peeking to Saad's from time to time, he's working on oslo.conf and oslo.log, but I haven't still  taken a deep look at that. maybe it will be in revirew soon16:03
vannifI was also evaluating the simplification of agent tasks. this is not a high priority I think. just an idea running on16:04
vannifas emerged in recent meetings, the plan is to have a sophisticated freezer-scheduler to manage the jobs, while the agent should be relatively dumb.16:04
vannifATM the agent does a somewhat articulated task which is: lock the tables, take the snapshot, release the table lock, upload the backup, release the snapshot16:05
vannifthis should be broken into pieces and controlled by the scheduler.16:05
vannifas reldan was suggesting, maybe using manager objects with specific responsibilities: snapshots, db locking/unlocking16:06
vannifeach one instructed to act in specific moments of the backup "workflow"16:07
vannifkind of "hooks"16:07
reldanOh, it will be great. I was trying to refactor lvm/shadow - but it’s really hard16:07
vannifyes, we also need to provide a consistent interface for lvm and shadow16:08
reldanit would be great to have single responsability objects, otherwise we are stopping database in one place and starting it in shadow/lvm code - it is conterintuitive16:08
vannifreldan, I can work on some diagrams and then we can discus them16:09
vannifexactly16:09
reldanWe can just seat together and try to understand it :)16:09
vannifcode is not just nested, it's even intermixed16:09
reldanAgree!16:09
vannifI think I'll send for review the small update to lvm.py I have been working on, and then plan for some more deep refactoring16:11
reldanDeal16:11
vannifso, let's move on. that's all from me.16:11
vannifif you don't have any question ...16:11
vannifm3m0_16:12
m3m0_I've been fixing some minor bugs in the ui16:12
m3m0_specially for the backup_id for local and ssh modes16:13
m3m0_the id is a string with slashes16:13
m3m0_so the urls using those slashes breaks the ui16:13
m3m0_but that is fixed now16:13
vannifand also the retrieval of the freezer-api endpoint from the keystone catalog, right ?16:13
m3m0_yes, that was another bug, the retrieval was incorrect16:14
m3m0_at least the logic of the function16:14
m3m0_but now is fixed and merged16:14
m3m0_and I'm working in UX improvements16:14
vannifany plan fo future improvements of the web-ui ?16:15
m3m0_but they are not going to get into master soon16:15
m3m0_yes, first of all, an overhaul of the readme16:15
m3m0_then a specific tab for actions16:15
m3m0_and another for clients16:15
m3m0_improve unittesting16:16
m3m0_and ui testing with selenium16:16
m3m0_improvement in the action and job modal window16:16
m3m0_add more visual clues for the user16:16
m3m0_and an overview page as well16:17
m3m0_so there is a lot to do for the ui16:17
vannifyes, the ui hasn't been high in the priority scale. but in the end it's the think that the user sees and interacts with. it sometimes help also the developers to understand if all they have been working on makes sense :)16:17
m3m0_but I have a very limited time in freezer now16:17
vannifs/think/thing16:17
m3m0_agree with that for us, it seems simple for new people they don't know what even a job means16:18
m3m0_well at least in the context16:18
m3m0_of backup and restore16:18
openstackgerritMemo Garcia proposed stackforge/freezer-web-ui: Fix minor bugs in freezer dashboard  https://review.openstack.org/23547816:19
vannifyou can work on it on the upcoming long and boring winter sundays :)16:19
m3m0_winter is coming16:19
vannifgood. anythink else to say ?16:19
m3m0_yes, windows16:20
m3m0_I need to rebase the changes and make sure that I didn't break the code by adding the support of the new code16:20
m3m0_and that's it16:20
vannifbtw, when we rework the code for the snapshots we well need your support for the windows snapshots16:21
vannifs/well/will16:21
m3m0_of course16:21
m3m0_just let me know16:21
vannifdefinitely. we'll need you: days are getting shorter, and the nights are long and full of terrors16:22
vannifthanks m3m016:22
m3m0_it's dangerous to go alone :)16:22
m3m0_you're welcome16:22
vannifszaher16:23
szaherThanks vannif16:23
vannifI know you've been involved in other tasks16:23
szaherI have been working on using oslo.log now it works fine with freezer api16:24
vannifbut you had also taken a look at oslo log and conf right ?16:24
vannifis it in review ?16:24
szahernot yet16:25
szaherI am just trying to add all files then I will commit16:26
szaherI need to change all freezer-api files to use oslo.log16:26
szaherand I will do that in one commit16:27
szaherafter that I will move to freezer scheduler then agent16:27
vannifif you want some early advice, you can send in for review and mark it as work in progress16:27
vannifjust to start the discussion and allow others to see anch give hints16:27
vannifs/anch/and16:28
szaherOk, will do that today16:28
szaherthere is also problem with pylint16:28
vannifI'll checkout the patchset and have a look at it. so we'll see how to deal with it16:30
vannifthanks szaher16:30
szaherthanks vannif :)16:30
vannifI think that's all since slashme hasn't been involved on the public side16:31
vannifanythink else to say ?16:31
vannifanyone ?16:31
vannifok. thanks all16:36
vannif#endmeeting16:36
freezerBot`Meeting ended Thu Oct 15 16:36:49 2015 UTC.  Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4)16:36
freezerBot`Minutes:        http://meetbot.stefanocanepa.it/freezer/openstack-freezer/2015/openstack-freezer.2015-10-15-15.12.html16:36
freezerBot`Minutes (text): http://meetbot.stefanocanepa.it/freezer/openstack-freezer/2015/openstack-freezer.2015-10-15-15.12.txt16:36
freezerBot`Log:            http://meetbot.stefanocanepa.it/freezer/openstack-freezer/2015/openstack-freezer.2015-10-15-15.12.log.html16:36
openstackMeeting ended Thu Oct 15 16:36:49 2015 UTC.  Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4)16:36
openstackMinutes:        http://eavesdrop.openstack.org/meetings/2015_10_15/2015/2015_10_15.2015-10-15-15.12.html16:36
openstackMinutes (text): http://eavesdrop.openstack.org/meetings/2015_10_15/2015/2015_10_15.2015-10-15-15.12.txt16:36
openstackLog:            http://eavesdrop.openstack.org/meetings/2015_10_15/2015/2015_10_15.2015-10-15-15.12.log.html16:36
*** reldan has quit IRC17:02
*** bitblt has joined #openstack-freezer17:13
*** jonaspf has quit IRC17:38
*** bitblt has quit IRC18:16
*** reldan has joined #openstack-freezer18:27
*** marzif has joined #openstack-freezer18:36
*** marzif has quit IRC18:36
*** marzif has joined #openstack-freezer18:36
*** jonaspf has joined #openstack-freezer18:40
*** subscope has joined #openstack-freezer18:56
*** jonaspf has quit IRC19:00
*** jonaspf has joined #openstack-freezer19:20
*** jonaspf has quit IRC19:47
*** marzif has quit IRC19:50
*** subscope has quit IRC20:25
*** jonaspf has joined #openstack-freezer20:33
*** jonaspf has quit IRC20:48
*** jonaspf has joined #openstack-freezer20:50
*** reldan has quit IRC21:08
*** jonaspf has quit IRC21:11
*** reldan has joined #openstack-freezer21:27
*** reldan has quit IRC21:32
*** reldan has joined #openstack-freezer21:34
*** jonaspf has joined #openstack-freezer21:37
*** jonaspf has quit IRC22:19
*** dschroeder has quit IRC23:26
*** vannif_ has joined #openstack-freezer23:27
*** vannif has quit IRC23:32
*** ChanServ has quit IRC23:54
*** nullvariable has quit IRC23:54
*** module000 has quit IRC23:54
*** sc has quit IRC23:54
*** smekel has quit IRC23:54
*** freezerBot` has quit IRC23:55
*** vannif_ has quit IRC23:55
*** openstackgerrit has quit IRC23:55
*** jokke_ has quit IRC23:55
*** daemontool_ has quit IRC23:55
*** samuelBartel_ has quit IRC23:55
*** m3m0_ has quit IRC23:55
*** szaher has quit IRC23:55
*** frescof__ has quit IRC23:55
*** epheo has quit IRC23:55
*** Slashme_ has quit IRC23:55

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!