*** evrardjp has quit IRC | 05:33 | |
*** evrardjp has joined #openstack-election | 05:33 | |
*** lpetrut has joined #openstack-election | 11:59 | |
*** ianychoi__ is now known as ianychoi | 12:34 | |
ianychoi | fungi, not sure where there are some logics to check whether one winner from candidates for a project set as True to reflect election result from civs. In my opinion, it would be great if we implement such logics not to forget to flag one winner as True | 12:37 |
---|---|---|
ianychoi | And do you think just my +2 with +A would be a good idea? I am now open.. | 12:39 |
fungi | ianychoi: yes, that's basically what the todo is saying there in the patch. i think the routine might be designed to also do something when elections are not closed yet, but i don't think it's useful until elections close so i agree we're better off just using the closed election structured data we have and not try to count the number of candidates in the candidates tree | 13:18 |
fungi | this was more of a hotfix to try not to disturb the code which is already there any more than necessary, but ultimately that entire function should be rewritten | 13:18 |
fungi | i wanted to get something up so that i could correctly generate the updated patch to governance for adding in the telemetry election result, and to make sure there was nothing else we were missing | 13:20 |
*** evrardjp has quit IRC | 14:38 | |
*** evrardjp has joined #openstack-election | 14:40 | |
*** lpetrut has quit IRC | 14:56 | |
fungi | our call is now? | 17:01 |
* fungi switches to meetpad | 17:01 | |
fungi | er, wrong channel, sorry! | 17:02 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!