| openstackgerrit | chenge proposed openstack/dragonflow master: Spelling mistakes https://review.openstack.org/600616 | 02:28 |
|---|---|---|
| *** AJaeger has joined #openstack-dragonflow | 07:22 | |
| AJaeger | oanson: could you review the python3-first changes, please? https://review.openstack.org/#/c/597472/ https://review.openstack.org/#/c/597473/ and https://review.openstack.org/#/c/597474/ | 07:22 |
| oanson | AJaeger, sure. I'll try and get to it today. | 07:27 |
| oanson | (I did pass the master branch ones (: ) | 07:27 |
| AJaeger | thanks, oanson. I just reviewed and updated - there was one small problem in them. | 07:27 |
| oanson | Sure. Thanks! | 07:28 |
| oanson | AJaeger, I went over the patches. I see there are some issues with the fullstack tests. Let me look at it next week (I won't have a chance before that due to local holidays). If I can't get it to work, I'll push them through as is. | 08:07 |
| AJaeger | oanson: if you can fix them, sure, let's make them voting again! | 08:12 |
| AJaeger | oanson: regarding missing full stack tests: Those are not in project-config... | 08:14 |
| oanson | AJaeger, I was sure we had a fullstack test at least since Newton release? I'll double check. | 08:15 |
| AJaeger | oanson: http://git.openstack.org/cgit/openstack-infra/project-config/tree/zuul.d/projects.yaml#n4140 | 08:15 |
| AJaeger | oanson: you might have removed them when moving those in-tree - and forgot to backport... | 08:15 |
| AJaeger | oanson: so, not a fault of the import... | 08:16 |
| oanson | AJaeger, yes. I think we have. (I didn't do it personally, so my memory is a bit rusted (: ) | 08:16 |
| AJaeger | oanson: so, if you could approve those that are fine? It's good idea afterwards to review all the settings... | 08:17 |
| AJaeger | oanson: I'd like us to finish the python3-first goal, we have too many changes in flight ;( | 08:18 |
| oanson | Sure. No worries | 08:18 |
| AJaeger | thanks. Enjoy your local holiday! | 08:19 |
| AJaeger | oanson: wow, the fullstack import was done in October 2017 - and apparently not backported everywhere. So, quite some time that nobody noticed ;( | 08:20 |
| oanson | Those branches don't change much :) | 08:21 |
| AJaeger | too little in this case ;) | 08:21 |
| oanson | In that case, I'll push the changes forwards, and I'll see if we can backport the tests later. | 08:23 |
| AJaeger | oanson: shouldn't be hard to backport... | 08:23 |
| oanson | No. Probably not. | 08:24 |
| AJaeger | enjoy your evening - I'll step out for a bit... | 08:24 |
| openstackgerrit | chen jiao proposed openstack/dragonflow master: spelling error https://review.openstack.org/600718 | 11:38 |
| *** yamamoto has joined #openstack-dragonflow | 13:08 | |
| *** yamamoto has quit IRC | 15:53 | |
| *** yamamoto has joined #openstack-dragonflow | 15:54 | |
| *** yamamoto has quit IRC | 15:59 | |
| *** yamamoto has joined #openstack-dragonflow | 16:35 | |
| *** yamamoto has quit IRC | 22:05 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!