opendevreview | Akihiro Motoki proposed openstack/openstack-manuals master: generatepot-rst.sh: Drop UUID filtering https://review.opendev.org/c/openstack/openstack-manuals/+/895585 | 06:20 |
---|---|---|
opendevreview | Akihiro Motoki proposed openstack/openstack-manuals master: generatepot-rst.sh: Drop UUID filtering https://review.opendev.org/c/openstack/openstack-manuals/+/895585 | 07:58 |
opendevreview | Akihiro Motoki proposed openstack/security-doc master: generatepot-rst.sh: Drop UUID filtering https://review.opendev.org/c/openstack/security-doc/+/895598 | 08:09 |
opendevreview | Akihiro Motoki proposed openstack/training-guides master: generatepot-rst.sh: Drop UUID filtering https://review.opendev.org/c/openstack/training-guides/+/895599 | 08:11 |
slaweq | stephenfin hi, how are You? May I have one qq to You? Recently You removed Sphinx RTD theme from requirements https://review.opendev.org/c/openstack/requirements/+/893665. We are using this theme in the tobiko docs currently and it broke our gate as requirements-check job is failing for us. | 12:05 |
slaweq | Can we use official openstack theme for docs which will be published in the tobiko.readhthedocs.io webpage? | 12:05 |
slaweq | or do we need to find another way to use still RTD theme and not have it in our docs/requirements maybe to not fail requirements-check job? | 12:06 |
stephenfin | slaweq: Hmm, that's a question for the TC I would guess? However, given it's not an official OpenStack project, why are you using the requirements-check job? | 12:06 |
slaweq | we are using this requirements job to be "in sync" with other OpenStack projects | 12:07 |
slaweq | at least that was my understanding always :) | 12:07 |
stephenfin | I mean you can but it's not really necessary | 12:09 |
stephenfin | However, to answer your question, I would just add the theme to the '[docs] deps' option in tox.ini | 12:09 |
stephenfin | and then configure 'doc/source/conf.py' so that it'll only configure the theme if it's available in the env (i.e. fallback to alabaster otherwise) | 12:10 |
stephenfin | Sorry for the hassle too: I wouldn't have removed it only for it was causing issues with the Sphinx version bump and I really wanted to get that in | 12:11 |
slaweq | thx a lot | 12:13 |
opendevreview | Merged openstack/security-doc master: generatepot-rst.sh: Drop UUID filtering https://review.opendev.org/c/openstack/security-doc/+/895598 | 12:48 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!