| *** tosky has quit IRC | 00:46 | |
| *** jamesmcarthur has quit IRC | 01:21 | |
| *** jamesmcarthur has joined #openstack-doc | 01:23 | |
| *** jamesmcarthur has quit IRC | 01:27 | |
| *** _fragatina has quit IRC | 01:56 | |
| *** jamesmcarthur has joined #openstack-doc | 01:58 | |
| *** jamesmcarthur has quit IRC | 01:58 | |
| *** jamesmcarthur has joined #openstack-doc | 02:22 | |
| *** dims has quit IRC | 02:38 | |
| *** jamesmcarthur has quit IRC | 02:47 | |
| *** dims has joined #openstack-doc | 02:55 | |
| *** _fragatina has joined #openstack-doc | 04:18 | |
| *** _fragatina has quit IRC | 04:19 | |
| *** _fragatina has joined #openstack-doc | 04:19 | |
| *** _fragatina has quit IRC | 04:21 | |
| *** _fragatina has joined #openstack-doc | 04:21 | |
| *** _fragatina has quit IRC | 04:27 | |
| *** _fragatina has joined #openstack-doc | 04:28 | |
| *** _fragatina has quit IRC | 04:31 | |
| *** _fragatina has joined #openstack-doc | 04:31 | |
| *** _fragatina has quit IRC | 04:32 | |
| *** _fragatina has joined #openstack-doc | 04:33 | |
| *** _fragatina has quit IRC | 04:41 | |
| *** _fragatina has joined #openstack-doc | 04:42 | |
| *** _fragatina has quit IRC | 04:42 | |
| *** _fragatina has joined #openstack-doc | 04:43 | |
| *** _fragatina has quit IRC | 04:44 | |
| *** _fragatina has joined #openstack-doc | 04:44 | |
| *** jamesmcarthur has joined #openstack-doc | 04:48 | |
| *** jamesmcarthur has quit IRC | 04:54 | |
| *** _fragatina has quit IRC | 05:11 | |
| *** _fragatina has joined #openstack-doc | 05:11 | |
| *** _fragatina has quit IRC | 05:16 | |
| *** _fragatina has joined #openstack-doc | 05:16 | |
| *** _fragatina has quit IRC | 05:19 | |
| *** _fragatina has joined #openstack-doc | 05:20 | |
| *** _fragatina has quit IRC | 05:38 | |
| *** _fragatina has joined #openstack-doc | 05:39 | |
| *** jamesmcarthur has joined #openstack-doc | 06:50 | |
| *** jamesmcarthur has quit IRC | 06:54 | |
| *** kopecmartin|off is now known as kopecmartin | 07:30 | |
| *** tosky has joined #openstack-doc | 08:34 | |
| *** jamesmcarthur has joined #openstack-doc | 08:51 | |
| *** jamesmcarthur has quit IRC | 08:55 | |
| *** jamesmcarthur has joined #openstack-doc | 10:52 | |
| *** jamesmcarthur has quit IRC | 10:56 | |
| *** pkovar has joined #openstack-doc | 11:54 | |
| *** pkovar has quit IRC | 12:03 | |
| *** pkovar has joined #openstack-doc | 12:20 | |
| *** jamesmcarthur has joined #openstack-doc | 12:52 | |
| *** jamesmcarthur has quit IRC | 12:57 | |
| *** pkovar has quit IRC | 12:58 | |
| *** pkovar has joined #openstack-doc | 13:03 | |
| *** jamesmcarthur has joined #openstack-doc | 13:15 | |
| *** jamesmcarthur has quit IRC | 13:20 | |
| *** jamesmcarthur has joined #openstack-doc | 13:46 | |
| *** jamesmcarthur has quit IRC | 13:51 | |
| *** pcaruana has quit IRC | 13:52 | |
| *** pcaruana has joined #openstack-doc | 14:02 | |
| *** dmacpher has quit IRC | 14:45 | |
| *** dmacpher has joined #openstack-doc | 15:22 | |
| *** eumel8 has joined #openstack-doc | 15:55 | |
| eumel8 | o/ | 15:56 |
|---|---|---|
| pkovar | \o | 15:58 |
| eumel8 | Hello Dr. Doc ;) | 15:58 |
| *** jamesmcarthur has joined #openstack-doc | 16:00 | |
| *** _fragatina has quit IRC | 16:03 | |
| *** _fragatina has joined #openstack-doc | 16:04 | |
| *** _fragatina has quit IRC | 16:04 | |
| *** _fragatina has joined #openstack-doc | 16:05 | |
| *** _fragatina has quit IRC | 16:10 | |
| pkovar | nothing in agenda for today's meeting. | 16:13 |
| pkovar | should we cancel? | 16:13 |
| eumel8 | I have something | 16:14 |
| eumel8 | but not on agenda | 16:14 |
| eumel8 | if nobody is there from i18n | 16:14 |
| *** jamesmcarthur has quit IRC | 16:16 | |
| *** jamesmcarthur_ has joined #openstack-doc | 16:16 | |
| *** jamesmcarthur has joined #openstack-doc | 16:17 | |
| pkovar | aha, okay | 16:19 |
| *** jamesmcarthur_ has quit IRC | 16:20 | |
| pkovar | >>>>>> #openstack-meeting | 16:34 |
| *** efried has joined #openstack-doc | 16:43 | |
| efried | o/ | 16:43 |
| efried | I'm mucking with the contributor-guide and noticing some weirdnesses. | 16:43 |
| efried | 1) Attempting to build the contributor-guide via `tox -e docs` is failing on some syntax stuff. Assuming it's just because we've made some common build tool stricter, I can go clean those up. | 16:44 |
| efried | 2) Whenever I build, all the source rst files are getting *modified*. A block like http://paste.openstack.org/show/744325/ is being added, to each file, each time I build. | 16:46 |
| efried | stephenfin, dhellmann: ^ (or feel free to point me to the right person) | 16:47 |
| dhellmann | efried : that looks like the translation stuff that was added to the build. I don't know how that works, but AJaeger or eumel8 might | 16:49 |
| efried | ack, thanks | 16:49 |
| dhellmann | efried : you might want to look at the tox file to see if there are other targets that don't run that step. | 16:50 |
| efried | dhellmann: Doesn't look like it. But in any case that seems broken to me. | 16:50 |
| dhellmann | yeah, that seems very much designed to just run in the CI system and not locally | 16:51 |
| eumel8 | efried: its more a feature then a bug. the rst files are modifified with the language header after translation build | 16:51 |
| efried | eumel8: Fair enough, but a) shouldn't those headers go into a doc/build artifact rather than the source; and b) shouldn't the tool detect when the header is already there and not add it again? | 16:52 |
| efried | a) is important for the sake of being able to develop actual changes to the source. The way it is now, I would have to finish making/testing my changes, then go in and edit every rst file to remove the headers before doing my commit. | 16:54 |
| eumel8 | efried: a) no, thats a dynamic build dependly on the translated files or books. and b) don't know if that happen, I'll make a git checkout after tox build locally to get the normal files back | 16:55 |
| efried | eumel8: Yes, there are ways to do a checkout or patch to reverse the header adds, but I have to be careful not to overwrite the actual changes I wanted to make when I do that. | 16:56 |
| efried | I'll propose a patch with dhellmann's suggestion of a different tox target that doesn't add the headers. | 16:56 |
| dhellmann | it should be possible to do the data injection without modifying the rst files by creating a special directive | 16:57 |
| dhellmann | or using the sphinx features for inserting a common prefix/suffix to files as it builds them (in memory) | 16:57 |
| efried | dhellmann: It's not quite common - would have to parameterize the basename of the source file - can that be done? | 16:58 |
| dhellmann | "not quite common"? | 16:58 |
| dhellmann | is it different in each file? | 16:58 |
| efried | yes, if you look at the paste - the basename of the file is included in the links. | 16:58 |
| efried | so it's the same *shape*, but the basename would have to be %s'd or similar. | 16:59 |
| dhellmann | ah, I see | 16:59 |
| dhellmann | yeah, a directive then | 16:59 |
| efried | not just the basename, actually, the path too. | 16:59 |
| dhellmann | yeah, I think all of that info would be available inside a directive | 17:00 |
| efried | This is going to be over my head. For now I'm just going to propose a change that a) adds a tox target that doesn't insert the headers; and b) fixes the build errors; so that I can c) get on with the actual content changes I was trying to make. | 17:00 |
| dhellmann | yeah, that's fine | 17:00 |
| efried | whom should I pester about the 'directive' thing? | 17:00 |
| dhellmann | AJaeger and eumel8 own this stuff afaik | 17:01 |
| eumel8 | should be here: https://github.com/openstack/openstackdocstheme/blob/master/bin/docstheme-build-translated.sh | 17:02 |
| dhellmann | I guess another way to do this would have been to do it in the page templates | 17:03 |
| dhellmann | that would keep it out of the content entirely | 17:03 |
| *** kopecmartin is now known as kopecmartin|off | 17:04 | |
| dhellmann | and wouldn't rely on us remembering to add a directive in every page | 17:04 |
| efried | eumel8: I see `recover_rst_files` in that script, which at a glance looks like it should be restoring the unadulterated sources; but it's clearly not working. | 17:05 |
| efried | yuh, git status is showing all the backup files still, which it wouldn't if that guy was working. | 17:06 |
| *** _fragatina has joined #openstack-doc | 17:08 | |
| efried | oh. It's because it's not running :P | 17:09 |
| efried | Because the build is still failing. | 17:09 |
| eumel8 | yes | 17:09 |
| efried | Should put that in an exit trap. | 17:09 |
| *** openstackgerrit has joined #openstack-doc | 17:31 | |
| openstackgerrit | Eric Fried proposed openstack/openstackdocstheme master: Exit trap cleanup in docstheme-build-translated.sh https://review.openstack.org/634284 | 17:31 |
| efried | dhellmann, eumel8: ^ | 17:31 |
| *** jamesmcarthur has quit IRC | 18:46 | |
| *** jamesmcarthur has joined #openstack-doc | 19:14 | |
| *** pkovar has quit IRC | 19:18 | |
| *** pcaruana has quit IRC | 19:30 | |
| *** jamesmcarthur has quit IRC | 19:36 | |
| *** jamesmcarthur has joined #openstack-doc | 19:47 | |
| openstackgerrit | Merged openstack/openstackdocstheme master: Exit trap cleanup in docstheme-build-translated.sh https://review.openstack.org/634284 | 19:49 |
| AJaeger | efried: stephenfin wanted to enhance sphinx to do this but hasn't had time yet. If you want to help, you're more than welcome | 19:52 |
| AJaeger | thanks, efried for your change | 19:52 |
| *** jamesmcarthur has quit IRC | 20:42 | |
| *** jamesmcarthur has joined #openstack-doc | 20:44 | |
| *** jamesmcarthur has quit IRC | 20:49 | |
| *** jamesmcarthur has joined #openstack-doc | 20:51 | |
| *** efried has quit IRC | 21:02 | |
| *** efried has joined #openstack-doc | 21:02 | |
| efried | AJaeger: Roger that. It's way outside my area of expertise, but maybe with stephenfin's guidance I could make a start. Not going to be able to make it a high priority though :P | 21:03 |
| *** jamesmcarthur has quit IRC | 21:04 | |
| *** efried has quit IRC | 21:16 | |
| *** efried has joined #openstack-doc | 21:17 | |
| *** jamesmcarthur has joined #openstack-doc | 21:51 | |
| *** jamesmcarthur has quit IRC | 22:08 | |
| *** jamesmcarthur has joined #openstack-doc | 22:26 | |
| openstackgerrit | Eric Fried proposed openstack/contributor-guide master: Tutorial: changes in a series https://review.openstack.org/634333 | 22:28 |
| efried | dhellmann, edmondsw: ^ | 22:29 |
| edmondsw | efried sweet, thanks | 22:31 |
| *** jamesmcarthur has quit IRC | 22:41 | |
| *** jamesmcarthur has joined #openstack-doc | 23:22 | |
| efried | Can a guy edit .po files, or will they be blown away next time "Zanata" happens (whatever that is)? | 23:22 |
| *** jamesmcarthur has quit IRC | 23:26 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!