| *** jamesmcarthur has quit IRC | 00:02 | |
| *** lbragstad has quit IRC | 00:59 | |
| *** lbragstad has joined #openstack-doc | 01:08 | |
| *** lbragstad has quit IRC | 01:09 | |
| *** tosky has quit IRC | 01:17 | |
| *** AJaeger has quit IRC | 01:23 | |
| *** AJaeger has joined #openstack-doc | 01:29 | |
| *** jamesmcarthur has joined #openstack-doc | 01:32 | |
| openstackgerrit | Takashi NATSUME proposed openstack/openstack-manuals master: Enable has_install_guide for the Placement project https://review.openstack.org/628324 | 02:21 |
|---|---|---|
| *** jamesmcarthur has quit IRC | 03:21 | |
| *** jamesmcarthur has joined #openstack-doc | 03:24 | |
| *** jamesmcarthur has quit IRC | 03:31 | |
| *** jamesmcarthur has joined #openstack-doc | 04:00 | |
| *** jamesmcarthur has quit IRC | 04:47 | |
| *** jamesmcarthur has joined #openstack-doc | 04:47 | |
| *** diablo_rojo has quit IRC | 05:03 | |
| *** jamesmcarthur has quit IRC | 05:27 | |
| *** rcernin has quit IRC | 06:47 | |
| *** jamesmcarthur has joined #openstack-doc | 06:50 | |
| *** jamesmcarthur has quit IRC | 06:55 | |
| *** jawad_axd has joined #openstack-doc | 07:21 | |
| *** kopecmartin|off is now known as kopecmartin | 08:28 | |
| *** tosky has joined #openstack-doc | 08:47 | |
| *** pkovar has joined #openstack-doc | 13:07 | |
| eumel8 | pkovar: I reserved a room in Denver for one day | 13:58 |
| pkovar | eumel8: thanks. was there an email about it somewhere? | 14:01 |
| eumel8 | pkovar: yeah, today or last night | 14:01 |
| eumel8 | time flies so better answer it now ;) | 14:02 |
| *** lbragstad has joined #openstack-doc | 14:08 | |
| pkovar | true that | 14:14 |
| openstackgerrit | Colleen Murphy proposed openstack/openstack-manuals master: Update install guide for Rocky on SUSE https://review.openstack.org/628445 | 14:22 |
| *** EmilienM is now known as EvilienM | 14:34 | |
| openstackgerrit | Merged openstack/openstack-manuals master: Update install guide for Rocky on SUSE https://review.openstack.org/628445 | 14:59 |
| *** jawad_axd has quit IRC | 15:13 | |
| *** jawad_axd has joined #openstack-doc | 15:14 | |
| *** jawad_axd has quit IRC | 15:16 | |
| *** lbragstad has quit IRC | 15:36 | |
| *** EvilienM is now known as EmilienM | 15:37 | |
| *** lbragstad has joined #openstack-doc | 15:40 | |
| aspiers | any jinja2 experts here? | 15:51 |
| *** diablo_rojo has joined #openstack-doc | 16:00 | |
| *** jamesmcarthur has joined #openstack-doc | 16:07 | |
| aspiers | never mind, I figured it out | 16:36 |
| aspiers | AJaeger: I figured out how to make www-generator.py cache the expensive-to-fetch repo/project metadata | 16:36 |
| aspiers | AJaeger: I guess we don't want it to always use a cache, but it's super useful for saving time when hacking on this script | 16:37 |
| aspiers | AJaeger: maybe I'll add a --cache option for use when hacking | 16:37 |
| aspiers | dhellmann: I guess you might have an opinion on that too? | 16:38 |
| aspiers | I did it with https://pypi.org/project/percache/, which does mean another dependency in test-requirements.txt | 16:38 |
| aspiers | If that's a problem I could make it optional | 16:38 |
| openstackgerrit | weizj proposed openstack/os-api-ref master: Update hacking version to latest https://review.openstack.org/628593 | 16:42 |
| *** pkovar has quit IRC | 16:45 | |
| dhellmann | aspiers : what data are you caching? | 16:50 |
| aspiers | dhellmann: https://github.com/aspiers/openstack-manuals/commit/cache | 16:52 |
| aspiers | I didn't submit to Gerrit yet pending this discussion | 16:53 |
| aspiers | probably needs to be optional | 16:53 |
| aspiers | and maybe with a non-predictable cache filename | 16:53 |
| aspiers | although I'm not sure symlink attacks necessary apply in this context :) | 16:54 |
| dhellmann | see the note on line 439 (or 444, I'm not sure how to read the github diff) | 16:54 |
| aspiers | ah yeah | 16:55 |
| dhellmann | we already have a flag --skip-links or whatever; I anticipated adding a --governance flag that could point to the local repo or file | 16:55 |
| dhellmann | but caching like this is probably ok, too | 16:56 |
| dhellmann | simpler, eeven | 16:56 |
| aspiers | --governance sounds nice for sure | 16:56 |
| dhellmann | it would be good if it was easy to know (a) that a cache was written and (b) how to remove it | 16:56 |
| dhellmann | so maybe write to ./ instead of /tmp? | 16:56 |
| aspiers | well it's just a file, so yeah it's easy :) | 16:56 |
| dhellmann | and then .gitignore the file | 16:56 |
| aspiers | sure, makes sense | 16:56 |
| dhellmann | and make the output name something like OS_GOVERNANCE_DATA_CACHE_DELETEME or something :-) | 16:56 |
| aspiers | I was thinking --project-cache or something | 16:56 |
| dhellmann | I'm not sure there's a reason to make it optional | 16:57 |
| aspiers | i.e. opt-in, but yeah, opt-out-via-deletion might work too | 16:57 |
| dhellmann | this is mostly run in the gate, and the cache will just be deleted there anyway | 16:57 |
| aspiers | it would be recreated from scratch in each CI environment | 16:57 |
| aspiers | ... right :) | 16:57 |
| dhellmann | and locally it's nice to not have to think too much about it when running locally | 16:57 |
| aspiers | only remaining potential objection is introducing the percache dependency | 16:58 |
| dhellmann | meh | 16:58 |
| aspiers | ok :) | 16:58 |
| dhellmann | this repo doesn't need to deal with upper-constraints or the g-r list | 16:58 |
| aspiers | that's what I thought | 16:58 |
| aspiers | but I've never really touched this repo before so I thought I should check | 16:58 |
| dhellmann | sure, no worries | 16:59 |
| aspiers | OK, sounds like it's worth submitting then | 16:59 |
| aspiers | a future --governance could potentially disable the cache | 16:59 |
| dhellmann | sure, that makes sense | 17:04 |
| openstackgerrit | Adam Spiers proposed openstack/openstack-manuals master: www-generator.py: cache expensive repo/project metadata to disk https://review.openstack.org/628636 | 17:11 |
| *** kopecmartin is now known as kopecmartin|off | 17:58 | |
| *** tosky has quit IRC | 18:09 | |
| *** jamesmcarthur has quit IRC | 18:10 | |
| *** jamesmcarthur has joined #openstack-doc | 18:10 | |
| *** jamesmcarthur has quit IRC | 18:11 | |
| *** jamesmcarthur has joined #openstack-doc | 18:11 | |
| aspiers | dhellmann: I'm struggling to understand this discussion https://review.openstack.org/#/c/585516/3/www/templates/deprecated_badge.tmpl@6 | 18:44 |
| aspiers | in what circumstances would it be "included externally"? I don't understand what "as it does on doctheme" means | 18:44 |
| aspiers | unfortunately it is (as predicted) making it hard for me to test changes to this CSS | 18:45 |
| *** jamesmcarthur has quit IRC | 18:46 | |
| aspiers | ah, smarcet is in #openstack-infra | 18:46 |
| aspiers | maybe he can answer | 18:46 |
| *** jamesmcarthur has joined #openstack-doc | 18:47 | |
| *** jamesmcarthur has quit IRC | 18:51 | |
| *** jamesmcarthur has joined #openstack-doc | 18:55 | |
| aspiers | never mind, figured it out myself | 19:01 |
| *** jamesmcarthur has quit IRC | 19:11 | |
| openstackgerrit | Adam Spiers proposed openstack/openstack-manuals master: Provide links from latest pages to released equivalents https://review.openstack.org/628072 | 19:12 |
| *** jamesmcarthur has joined #openstack-doc | 19:17 | |
| openstackgerrit | Adam Spiers proposed openstack/openstack-manuals master: Provide dropdown menu which allows switching doc release https://review.openstack.org/628072 | 19:23 |
| *** jamesmcarthur has quit IRC | 19:43 | |
| *** jamesmcarthur has joined #openstack-doc | 19:43 | |
| *** jamesmcarthur has quit IRC | 19:46 | |
| *** jamesmcarthur has joined #openstack-doc | 19:47 | |
| *** jamesmcarthur has quit IRC | 19:52 | |
| dhellmann | aspiers : I think the issue is that a page like https://docs.o.o/nova/old_release/something.html includes that deprecated_badge.tmpl file when the page is loaded through some jiggery-pokery that the openstackdocstheme does. If the CSS path is wrong, the badge doesn't work properly. | 20:36 |
| dhellmann | I didn't build any of that, though, so I'm not sure how it actually works | 20:37 |
| dhellmann | :-/ | 20:37 |
| aspiers | dhellmann: yeah, I found it in https://github.com/openstack/openstackdocstheme/blob/a0684ace5e49ef935bd314928dc1acde3da6e11a/openstackdocstheme/theme/openstackdocs/layout.html#L107 | 23:26 |
| aspiers | so I guess it would load relative/path/to/some.css as relative to https://docs.openstack.org/{{ series }}/badge.html | 23:28 |
| aspiers | but actually that would be correct, so I don't see the problem ... | 23:35 |
| aspiers | I'm also confused why www/latest/badge.html doesn't just include the template like all the others | 23:37 |
| *** openstack has joined #openstack-doc | 23:46 | |
| *** ChanServ sets mode: +o openstack | 23:46 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!