| opendevreview | Erik Olof Gunnar Andersson proposed openstack/designate master: Improved DNSMiddlware test coverage https://review.opendev.org/c/openstack/designate/+/901585 | 01:32 |
|---|---|---|
| opendevreview | Erik Olof Gunnar Andersson proposed openstack/designate master: Improved Zone Export coverage https://review.opendev.org/c/openstack/designate/+/901586 | 02:17 |
| opendevreview | Erik Olof Gunnar Andersson proposed openstack/designate master: Improved Zone Export coverage https://review.opendev.org/c/openstack/designate/+/901586 | 02:18 |
| opendevreview | Merged openstack/designate master: Remove devstack support for suse https://review.opendev.org/c/openstack/designate/+/900932 | 02:46 |
| opendevreview | Erik Olof Gunnar Andersson proposed openstack/designate-tempest-plugin master: Add wait_until=const.ACTIVE on zone creation to increase stability https://review.opendev.org/c/openstack/designate-tempest-plugin/+/901590 | 13:39 |
| opendevreview | Erik Olof Gunnar Andersson proposed openstack/designate master: Improved Zone Export coverage https://review.opendev.org/c/openstack/designate/+/901586 | 13:40 |
| opendevreview | Erik Olof Gunnar Andersson proposed openstack/designate master: Improved DNSMiddlware test coverage https://review.opendev.org/c/openstack/designate/+/901585 | 13:40 |
| eandersson | ehm... frickler | 16:02 |
| eandersson | You remember that range bug? | 16:02 |
| eandersson | https://github.com/openstack/designate/blob/master/designate/producer/service.py#L67 | 16:02 |
| opendevreview | Erik Olof Gunnar Andersson proposed openstack/designate master: Fix Producer shard range ignoring the last shard https://review.opendev.org/c/openstack/designate/+/901592 | 16:12 |
| opendevreview | Erik Olof Gunnar Andersson proposed openstack/designate master: Fix Producer shard range ignoring the last shard https://review.opendev.org/c/openstack/designate/+/901592 | 16:13 |
| eandersson | tl;dr in Bobcat one in 4095 zones just won't work :'( | 16:15 |
| frickler | eandersson: oh my, how many more of these are there? do we need to scan the code for all occurrences of 2^n and 2^n-1 ? also, as usual, can we add better testing? | 16:23 |
| opendevreview | Erik Olof Gunnar Andersson proposed openstack/designate master: Fix Producer shard range ignoring the last shard https://review.opendev.org/c/openstack/designate/+/901592 | 16:24 |
| eandersson | Yep just added a unit test | 16:26 |
| eandersson | Also did a scan and couldn't find any more occurences | 16:27 |
| eandersson | This has been broken for like 10 years, but no one noticed since the producer wasn't critical path | 16:27 |
| eandersson | We only really found it now as we were pushing to have everything covered by tests lol | 16:28 |
| opendevreview | Erik Olof Gunnar Andersson proposed openstack/designate master: Add shard id to shard and recorset representation https://review.opendev.org/c/openstack/designate/+/901593 | 16:38 |
| opendevreview | Erik Olof Gunnar Andersson proposed openstack/designate master: Add shard id to zone and recorset representation https://review.opendev.org/c/openstack/designate/+/901593 | 16:38 |
| opendevreview | Erik Olof Gunnar Andersson proposed openstack/designate master: Add shard id to zone and recordset representation https://review.opendev.org/c/openstack/designate/+/901593 | 16:38 |
| eandersson | typos -_- | 16:38 |
| eandersson | The above should make it easier to debug shard related issues | 16:39 |
| opendevreview | Erik Olof Gunnar Andersson proposed openstack/designate master: Remove executable flag from recordset.py https://review.opendev.org/c/openstack/designate/+/901594 | 16:40 |
| opendevreview | Erik Olof Gunnar Andersson proposed openstack/designate master: Fix Producer shard range ignoring the last shard https://review.opendev.org/c/openstack/designate/+/901592 | 16:47 |
| opendevreview | Erik Olof Gunnar Andersson proposed openstack/designate master: Add shard id to zone and recordset representation https://review.opendev.org/c/openstack/designate/+/901593 | 16:47 |
| frickler | eandersson: thx, I'm off now and won't be around tomorrow, but I'll review afterwards | 16:52 |
| opendevreview | Erik Olof Gunnar Andersson proposed openstack/designate master: Improved Zone Export coverage https://review.opendev.org/c/openstack/designate/+/901586 | 16:55 |
| opendevreview | Erik Olof Gunnar Andersson proposed openstack/designate master: Improved DNSMiddlware test coverage https://review.opendev.org/c/openstack/designate/+/901585 | 16:55 |
| opendevreview | Erik Olof Gunnar Andersson proposed openstack/designate master: Improved Zone Export coverage https://review.opendev.org/c/openstack/designate/+/901586 | 18:01 |
| opendevreview | Erik Olof Gunnar Andersson proposed openstack/designate master: Improved DNSMiddlware test coverage https://review.opendev.org/c/openstack/designate/+/901585 | 18:01 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!