| opendevreview | Merged openstack/designate master: Fix bug with new zone default values being ignored https://review.opendev.org/c/openstack/designate/+/900106 | 00:31 |
|---|---|---|
| frickler | eandersson: just as an afterthought, does it make sense to add some testing for ^^ ? | 06:46 |
| eandersson | frickler: So yea I might add some tests, but the reason I originally didn't add tests was because it wasn't possible to catch the problem | 11:33 |
| eandersson | I guess I could have added a expect fail test | 11:34 |
| eandersson | That was mostly nonsense. I could totally have added tests. It was just messy because how the code was built. | 11:34 |
| frickler | maybe a scenario test would be better and easier | 11:46 |
| eandersson | I actually don't know how to test this. | 11:59 |
| eandersson | When I tested the patch I manually tested it. | 11:59 |
| opendevreview | Jan Hartkopf proposed openstack/designate master: Add support for catalog zones https://review.opendev.org/c/openstack/designate/+/885594 | 13:00 |
| opendevreview | Jan Hartkopf proposed openstack/designate master: Add catalog zone support to devstack plugin https://review.opendev.org/c/openstack/designate/+/892814 | 13:02 |
| opendevreview | Brent Eagles proposed openstack/designate master: Add charset and engine parameters to alembic create tables https://review.opendev.org/c/openstack/designate/+/901135 | 13:06 |
| opendevreview | Brent Eagles proposed openstack/designate master: Add charset and engine parameters to alembic create tables https://review.opendev.org/c/openstack/designate/+/901135 | 13:51 |
| opendevreview | Brent Eagles proposed openstack/designate master: Add charset and engine parameters to alembic create tables https://review.opendev.org/c/openstack/designate/+/901135 | 14:48 |
| opendevreview | Erik Olof Gunnar Andersson proposed openstack/designate master: Add basic storage test to test config overrides https://review.opendev.org/c/openstack/designate/+/901143 | 15:59 |
| eandersson | frickler ^ maybe something like that :D | 16:01 |
| opendevreview | Brent Eagles proposed openstack/designate master: Add charset and engine parameters to alembic create tables https://review.opendev.org/c/openstack/designate/+/901135 | 17:49 |
| frickler | eandersson: commented. though I expected a test checking the actual results in a live zone, but checking in the storage seems to be fine, too | 18:05 |
| opendevreview | Erik Olof Gunnar Andersson proposed openstack/designate master: Add basic storage test to test config overrides https://review.opendev.org/c/openstack/designate/+/901143 | 19:20 |
| opendevreview | Erik Olof Gunnar Andersson proposed openstack/designate master: Add basic storage test to test config overrides https://review.opendev.org/c/openstack/designate/+/901143 | 21:33 |
| eandersson | frickler: I wanted to specifically target the bug fixed and make sure in case something else breaks this (besides import order) that we can more easily narrow down where it broke. | 21:35 |
| opendevreview | Erik Olof Gunnar Andersson proposed openstack/designate master: Add basic storage test to test config overrides https://review.opendev.org/c/openstack/designate/+/901143 | 21:39 |
| eandersson | Added coverage to central too. | 21:40 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!