| opendevreview | Michael Johnson proposed openstack/designate-tempest-plugin master: Update the README file to use tox -e all https://review.opendev.org/c/openstack/designate-tempest-plugin/+/875576 | 00:25 |
|---|---|---|
| opendevreview | Michael Johnson proposed openstack/designate-tempest-plugin master: Update the README file to use tox -e all https://review.opendev.org/c/openstack/designate-tempest-plugin/+/875576 | 00:29 |
| opendevreview | Michael Johnson proposed openstack/designate-tempest-plugin master: Update the README file to use tox -e all https://review.opendev.org/c/openstack/designate-tempest-plugin/+/875576 | 00:34 |
| johnsom | Now I will stop changing the wording. lol | 00:35 |
| eandersson | Thanks gmann! | 01:51 |
| opendevreview | kiran pawar proposed openstack/designate master: Stop service_status on service.stop() https://review.opendev.org/c/openstack/designate/+/866698 | 08:54 |
| zigo | Hello! | 16:11 |
| zigo | As lhommeRares wrote, we have what we believe is a bug in our Victoria public cloud deployment. | 16:11 |
| zigo | First, we've set managed_resource_tenant_id as the ID of the admin project, so PTR managed resources are owned by the admin project. | 16:11 |
| zigo | We also have set allow_reverse_dns_lookup=False in neutron.conf. | 16:11 |
| zigo | - A user creates a floating IP | 16:11 |
| zigo | - That user updates it with dns domain and PTR | 16:11 |
| zigo | - That user then deletes the floating IP | 16:11 |
| zigo | The issue is: the PTR isn't unset and the record stays. | 16:11 |
| zigo | Is this a known issue? | 16:11 |
| lhommeRares | johnsom: frickler: njohnston: ^^ | 16:13 |
| johnsom | Hmm, not sure. I'm not super familiar with how the neutron extension works. | 16:15 |
| johnsom | It might be worth asking in the #openstack-neutron channel. Otherwise I would have to go read the code over there. | 16:16 |
| johnsom | Which extensions do you have enabled for DNS in neutron? | 16:17 |
| johnsom | Also curious, if you have allow_reverse_dns_lookup=False how is the PTR created for the FIP? Manual creation in designate directly? | 16:19 |
| lhommeRares | johnsom: we use dns_port_domain extension and yes we manually do ptr record set directly | 16:23 |
| johnsom | Yeah, if the PTR was created manually and not via the extension, there is no automation to remove the PTR on FIP deletion. It has to be manually deleted as well. | 16:24 |
| lhommeRares | johnsom: we tried variations of this patch to fix the issue https://review.opendev.org/c/openstack/neutron/+/771556 | 16:24 |
| zigo | johnsom: Do you think it'd be worth trying to get this patch merged? | 16:25 |
| zigo | (fixing its unit tests, of course...) | 16:26 |
| johnsom | I am not familiar with this patch, I will have to read through it. It seems like frickler didn't think it was a good idea. Probably worth a discussion with him. | 16:27 |
| johnsom | Ok, I think I see what you are trying to do. So you don't want neutron to manage the PTRs, you are using the /v2/reverse/floatingips/ API to create the PTR for the FIP, but you want some kind of automation to remove the PTR when the FIP is removed in neutron. | 16:30 |
| zigo | Right ! | 16:30 |
| lhommeRares | johnsom: yes exactly | 16:31 |
| johnsom | Sorry, it's still early here, working on my coffee. lol | 16:31 |
| zigo | :) | 16:31 |
| zigo | johnsom: Are you west coast? | 16:31 |
| lhommeRares | johnsom: no problem :D thank you very much to watch with us this issue | 16:31 |
| johnsom | Do you have the neutron floating IP handler turned on in the Designate sink process? | 16:32 |
| johnsom | I think what you want is here: https://github.com/openstack/designate/blob/master/designate/notification_handler/neutron.py#L53 | 16:32 |
| lhommeRares | johnsom: we dont have designate sink component, it is possible to had them after designate deployment ? | 16:33 |
| johnsom | https://github.com/openstack/designate/blob/master/setup.cfg#L72 | 16:34 |
| johnsom | Yeah, you just need to setup the process and configure it to get the neutron notifications from messaging, enable that handler. | 16:34 |
| zigo | Is this something that must be configured in Neutron as well? | 16:34 |
| lajoskatona | johnsom: Hi, I pushed a more VIP patch to change from neutronclient to SDK: https://review.opendev.org/c/openstack/designate/+/874991 | 16:35 |
| frickler | I think that the /reverse/fips API is mostly broken and should be dropped. any reason why you are not using the standard neutron integration with allow_reverse_dns_lookup=True instead? | 16:35 |
| johnsom | Umm, maybe, but I don't think so. I think neutron sends these events by default. | 16:35 |
| lajoskatona | johnsom: my concern is that some cfg options are necessary for instantiating SDK client, which are not filled by default (at least not in zuul or in homemade devstack) | 16:36 |
| lajoskatona | johnsom: and not sure how I broke things if I start to ask for those, when you have some time please check it | 16:36 |
| johnsom | lajoskatona ack, thank you for the patch! | 16:37 |
| zigo | What's the value we should set for enabled_notification_handlers ? | 16:39 |
| johnsom | neutron_floatingip | 16:39 |
| lhommeRares | frickler: We don't use allow_reverse_dns_lookup=True because we offer a public cloud with horizon, the concern is that a client can do an openstack ptr record set on a fips that already has its set ptr automatically and here we have the issue quoted here: https://review.opendev.org/c/openstack/neutron/+/771556, the horizon dns interface uses /reverse/fips AP to display the floatings ptr | 16:39 |
| zigo | Thanks, will try. | 16:40 |
| lhommeRares | frickler: To summarize the best scenario would be to be able to create a ptr automatically thanks to the option allow_reverse=True and to be able to also set it manually afterwards with ptr record set, in this case the module designate horizon to work in all possible cases | 16:42 |
| frickler | interesting scenario, I guess one should really disable that part of the dns api in such a deployment then. plus that panel in horizon. | 16:43 |
| frickler | just have the neutron API to control the ptr | 16:43 |
| lhommeRares | frickler: I agree with you that we should remove the horizon panel view for ptrs and disable ptr creation manually. Do you agree? | 16:44 |
| lhommeRares | frickler: But if we do that we won't be able to modify the ptr of a floating after its creation, we'll have to delete it then recreate it with the new record/name we need | 16:45 |
| zigo | FYI, we're trying to add the sink to our setup, and we'll tell how it goes... | 16:47 |
| zigo | Don't we also need nova_fixed too?!? | 17:03 |
| opendevreview | Michael Johnson proposed openstack/designate-tempest-plugin master: Update the README file to use tox -e all https://review.opendev.org/c/openstack/designate-tempest-plugin/+/875576 | 18:16 |
| opendevreview | Michael Johnson proposed openstack/designate master: WIP Use SDK instead of neutronclient https://review.opendev.org/c/openstack/designate/+/874991 | 18:21 |
| opendevreview | Michael Johnson proposed openstack/designate master: WIP Use SDK instead of neutronclient https://review.opendev.org/c/openstack/designate/+/874991 | 20:26 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!