| opendevreview | Lukas Piwowarski proposed openstack/designate-tempest-plugin master: Fix checking of the [dns].nameservers value https://review.opendev.org/c/openstack/designate-tempest-plugin/+/863895 | 16:23 |
|---|---|---|
| opendevreview | Lukas Piwowarski proposed openstack/designate-tempest-plugin master: Fix checking of the [dns].nameservers value https://review.opendev.org/c/openstack/designate-tempest-plugin/+/862804 | 16:24 |
| JayF | Heya; I'm helping Scott get https://review.opendev.org/c/openstack/designate/+/744013 over the finish line. I've not contributed to designate before; if there's anything I can do to help get this over the finish line please let me know! | 20:02 |
| johnsom | JayF Hi | 20:06 |
| JayF | Hey johnsom o/ | 20:06 |
| johnsom | The patch is marked WIP, so I have not reviewed it in a while. | 20:06 |
| JayF | I think Scott updated that recently with a rebase | 20:07 |
| johnsom | If it's ready for review again, let's remove the WIP flag | 20:07 |
| JayF | I thought the WIP flag was removed from it? is there something I'm issing? | 20:07 |
| JayF | \*missing | 20:07 |
| johnsom | By WIP, I mean the brown "Work in progress" box in the upper left corner | 20:07 |
| JayF | Just when I thought I had seen everything possible in gerrit lol | 20:08 |
| johnsom | Yeah, it's new-ish in gerrit and I don't think the core reviewers can remove it. | 20:08 |
| JayF | Yeah, I don't even know how | 20:08 |
| JayF | I reached out to Ccott, thanks for the heads up | 20:10 |
| JayF | *Scott | 20:10 |
| johnsom | Yeah, good to know that is ready, I will try to re-review today/tomorrow. | 20:10 |
| JayF | heh, so I jumped through every hoop to try and get it to take | 20:14 |
| JayF | can't even push a new, non-WIP version of that patch on my own | 20:14 |
| JayF | > (only users with Toogle-Wip-State permission can modify Work-in-Progress) | 20:14 |
| johnsom | Yeah, it is a bit of an evil feature. It pulls the patch from the dashboards, blocks merge, etc. | 20:17 |
| JayF | I wonder if that missing permission is something we should revise our general core-reviewer perms to have | 20:20 |
| JayF | I was about to ask who we'd ask about that, but I'm on the TC, if I can't figure it out who can lol | 20:20 |
| johnsom | Yeah, I asked infra about it in the past, but the topic dropped | 20:20 |
| johnsom | Lol, no comment. grin | 20:21 |
| JayF | johnsom: looks like Scott got it flipped; thanks for the heads up. Let me know if that patch needs anything... might need unit tests, but I'm not sure if you all enforce code coverage for a straightforward driver fix | 20:44 |
| johnsom | We do gate enforce coverage. I will have a look and see where it's at. | 20:45 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!