| opendevreview | Michael Johnson proposed openstack/designate stable/zed: Fix minimum versions in requirements.txt https://review.opendev.org/c/openstack/designate/+/858610 | 00:51 |
|---|---|---|
| opendevreview | Michael Johnson proposed openstack/designate master: Fix mdns test_handler setup https://review.opendev.org/c/openstack/designate/+/858588 | 00:55 |
| eandersson | Interesting that it never failed for me as I ran those test isolated. | 04:20 |
| eandersson | Fix LGTM thou | 04:20 |
| opendevreview | Merged openstack/designate stable/zed: Fix minimum versions in requirements.txt https://review.opendev.org/c/openstack/designate/+/858610 | 04:27 |
| frickler | eandersson: the issue subtly depends on what test filter you use. "unit.mdns" fails as I wrote above, "unit" fails too, but "mdns" passes, I think that is happening because it runs tests/test_mdns in addition to tests/unit/mdns | 05:09 |
| frickler | would still be interesting to find out why the tests don't seem to be as isolated as one would expect | 05:09 |
| frickler | do we need to make an rc2 for the alembic bump? | 05:53 |
| opendevreview | Merged openstack/designate master: Fix mdns test_handler setup https://review.opendev.org/c/openstack/designate/+/858588 | 06:15 |
| frickler | oh, that test issue is even more fancy, it depends on the number of workers. --serial always works, "tox -e py3 -- --concurrency 16 mdns" is almost always failing. critical number is between 8 and 12 | 06:15 |
| zigo | johnsom: Thanks, looks like the patch fixed it indeed. | 06:57 |
| zigo | However, I had to build the Designate package twice, because on the first run, I had these: | 06:57 |
| zigo | https://paste.opendev.org/show/bjZCqtrkSLw5cbkOjh5h/ | 06:57 |
| zigo | This looks like non-deterministic failures, that's very annoying ... :/ | 06:57 |
| johnsom | frickler Yes, I will push an RC2 now | 14:32 |
| opendevreview | Scott Solkhon proposed openstack/designate master: Reload Infoblox config after deleting zone https://review.opendev.org/c/openstack/designate/+/744013 | 14:36 |
| opendevreview | Merged openstack/designate-tempest-plugin master: Adds TLD cleanup to "test_recordset_validation" test suite https://review.opendev.org/c/openstack/designate-tempest-plugin/+/853172 | 15:38 |
| eandersson | makes sense frickler, been fixing a ton of similar issues | 17:53 |
| eandersson | we have had so many monkey patch related bugs | 17:53 |
| johnsom | I am looking at the fixtures used here. I think it's not cleaning up like it should. | 17:54 |
| johnsom | This seems fishy to me: https://github.com/openstack/designate/blob/master/designate/tests/fixtures.py#L74 | 17:55 |
| johnsom | But I haven't done a lot with fixtures, so trying to read up on them | 17:55 |
| johnsom | It seems to me that should be cleanUp and not deinit | 17:56 |
| johnsom | Though I'm not sure that will really help the situation as this RPC stuff is using globals, so I'm not sure we can stop cross-test bleed here without some re-writing | 18:15 |
| johnsom | Ah, ok, I see why that deinit is there, they recommend not overriding cleanUP. | 18:18 |
| opendevreview | Scott Solkhon proposed openstack/designate master: Reload Infoblox config after deleting zone https://review.opendev.org/c/openstack/designate/+/744013 | 20:35 |
| opendevreview | Arkady Shtempler proposed openstack/designate-tempest-plugin master: New quota boundray test:"test_zone_quota_boundary" https://review.opendev.org/c/openstack/designate-tempest-plugin/+/858295 | 20:36 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!