| opendevreview | Merged openstack/python-designateclient master: Add Designate hacking checks to the client https://review.opendev.org/c/openstack/python-designateclient/+/819737 | 07:54 |
|---|---|---|
| opendevreview | Erik Olof Gunnar Andersson proposed openstack/python-designateclient master: Add basic osc unit tests https://review.opendev.org/c/openstack/python-designateclient/+/819761 | 08:10 |
| opendevreview | Erik Olof Gunnar Andersson proposed openstack/python-designateclient master: Add basic osc unit tests https://review.opendev.org/c/openstack/python-designateclient/+/819761 | 08:13 |
| opendevreview | Erik Olof Gunnar Andersson proposed openstack/python-designateclient master: Add basic osc unit tests https://review.opendev.org/c/openstack/python-designateclient/+/819761 | 08:33 |
| opendevreview | Merged openstack/designate-tempest-plugin master: Abort wait for 404 if the status changes to ERROR https://review.opendev.org/c/openstack/designate-tempest-plugin/+/820075 | 09:42 |
| opendevreview | Arkady Shtempler proposed openstack/designate-tempest-plugin master: New test case: "test_create_zone_on_provided_pool" https://review.opendev.org/c/openstack/designate-tempest-plugin/+/819310 | 10:18 |
| opendevreview | Michael Johnson proposed openstack/designate master: DNM - Testing BIND9 job on centos 9 stream https://review.opendev.org/c/openstack/designate/+/817123 | 17:21 |
| eandersson | Thanks for the review frickler | 18:18 |
| eandersson | btw fully agree with your comment on hacking checks... but that must have been solved by someone else in the OpenStack community right? | 18:19 |
| frickler | eandersson: neutron has some shared checks in neutron-lib. I'm not sure whether we could import designate as test-req in python-designateclient, if yes, we could do https://paste.opendev.org/show/811524/, tested that locally | 20:04 |
| frickler | otherwise we could try to get the checks into hacking itself maybe. I think a dedicated designate-lib would be overkill | 20:05 |
| frickler | oh, we could move the checks into the client proper and use those in designate | 20:06 |
| johnsom | Yeah, it's either getting them into the main hacking, or creating another repo. I am not a fan of importing designate proper as it could mask other import issues. | 20:07 |
| frickler | designate does require python-designateclient already, so that would not change dependencies | 20:07 |
| eandersson | So you thinking we would keep the hack checks in python-designateclient? | 20:15 |
| johnsom | I do. It's not that much code and a common pattern. | 20:19 |
| johnsom | I really don't think folks just installing the client would want to need to install all of designate and it's dependencies on their laptop, etc. | 20:21 |
| johnsom | There is a decent argument for up-streaming them into the main hacking and letting people disable them if they don't care. | 20:22 |
| eandersson | I am suprised that isn't a thing already | 20:31 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!